wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +32 added lines, -32 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -21,8 +21,8 @@ 
 
 	private Statement $statement;
 
-	public function __construct( StatementListProvidingEntity $entity, Statement $statement ) {
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(StatementListProvidingEntity $entity, Statement $statement) {
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -39,21 +39,21 @@ 
 		return $this->statement;
 	}
 
-	public function getSnakGroup( string $groupingMode, array $separators = [] ): array {
+	public function getSnakGroup(string $groupingMode, array $separators = []): array {
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
-		switch ( $groupingMode ) {
+		switch ($groupingMode) {
 			case Context::GROUP_NON_DEPRECATED:
-				$statements = $statements->getByRank( [
+				$statements = $statements->getByRank([
 					Statement::RANK_NORMAL,
 					Statement::RANK_PREFERRED,
-				] );
+				]);
 				break;
 			case Context::GROUP_BEST_RANK:
-				$statements = $this->getBestStatementsPerPropertyId( $statements );
+				$statements = $this->getBestStatementsPerPropertyId($statements);
 				break;
 			default:
-				throw new LogicException( 'Unknown $groupingMode ' . $groupingMode );
+				throw new LogicException('Unknown $groupingMode '.$groupingMode);
 		}
 		return $this->getStatementsWithSameQualifiersForProperties(
 			$this->statement,
@@ -62,13 +62,13 @@ 
 		)->getMainSnaks();
 	}
 
-	private function getBestStatementsPerPropertyId( StatementList $statements ): StatementList {
+	private function getBestStatementsPerPropertyId(StatementList $statements): StatementList {
 		$allBestStatements = new StatementList();
-		foreach ( $statements->getPropertyIds() as $propertyId ) {
-			$bestStatements = $statements->getByPropertyId( $propertyId )
+		foreach ($statements->getPropertyIds() as $propertyId) {
+			$bestStatements = $statements->getByPropertyId($propertyId)
 				->getBestStatements();
-			foreach ( $bestStatements as $bestStatement ) {
-				$allBestStatements->addStatement( $bestStatement );
+			foreach ($bestStatements as $bestStatement) {
+				$allBestStatements->addStatement($bestStatement);
 			}
 		}
 		return $allBestStatements;
@@ -90,20 +90,20 @@ 
 		array $qualifierPropertyIds
 	): StatementList {
 		$similarStatements = new StatementList();
-		foreach ( $allStatements as $statement ) {
-			if ( $statement === $currentStatement ) {
+		foreach ($allStatements as $statement) {
+			if ($statement === $currentStatement) {
 				// if the statement has an “unknown value” qualifier,
 				// it might be considered different from itself,
 				// so add it explicitly to ensure it’s always included
-				$similarStatements->addStatement( $statement );
+				$similarStatements->addStatement($statement);
 				continue;
 			}
-			foreach ( $qualifierPropertyIds as $qualifierPropertyId ) {
-				if ( !$this->haveSameQualifiers( $currentStatement, $statement, $qualifierPropertyId ) ) {
+			foreach ($qualifierPropertyIds as $qualifierPropertyId) {
+				if (!$this->haveSameQualifiers($currentStatement, $statement, $qualifierPropertyId)) {
 					continue 2;
 				}
 			}
-			$similarStatements->addStatement( $statement );
+			$similarStatements->addStatement($statement);
 		}
 		return $similarStatements;
 	}
@@ -112,19 +112,19 @@ 
 	 * Tests whether two statements have the same qualifiers with a certain property ID.
 	 * “unknown value” qualifiers are considered different from each other.
 	 */
-	private function haveSameQualifiers( Statement $s1, Statement $s2, PropertyId $propertyId ): bool {
-		$q1 = $this->getSnaksWithPropertyId( $s1->getQualifiers(), $propertyId );
-		$q2 = $this->getSnaksWithPropertyId( $s2->getQualifiers(), $propertyId );
+	private function haveSameQualifiers(Statement $s1, Statement $s2, PropertyId $propertyId): bool {
+		$q1 = $this->getSnaksWithPropertyId($s1->getQualifiers(), $propertyId);
+		$q2 = $this->getSnaksWithPropertyId($s2->getQualifiers(), $propertyId);
 
-		if ( $q1->count() !== $q2->count() ) {
+		if ($q1->count() !== $q2->count()) {
 			return false;
 		}
 
-		foreach ( $q1 as $qualifier ) {
-			switch ( $qualifier->getType() ) {
+		foreach ($q1 as $qualifier) {
+			switch ($qualifier->getType()) {
 				case 'value':
 				case 'novalue':
-					if ( !$q2->hasSnak( $qualifier ) ) {
+					if (!$q2->hasSnak($qualifier)) {
 						return false;
 					}
 					break;
@@ -142,12 +142,12 @@ 
 	/**
 	 * Returns the snaks of the given snak list with the specified property ID.
 	 */
-	private function getSnaksWithPropertyId( SnakList $allSnaks, PropertyId $propertyId ): SnakList {
+	private function getSnaksWithPropertyId(SnakList $allSnaks, PropertyId $propertyId): SnakList {
 		$snaks = new SnakList();
 		/** @var Snak $snak */
-		foreach ( $allSnaks as $snak ) {
-			if ( $snak->getPropertyId()->equals( $propertyId ) ) {
-				$snaks->addSnak( $snak );
+		foreach ($allSnaks as $snak) {
+			if ($snak->getPropertyId()->equals($propertyId)) {
+				$snaks->addSnak($snak);
 			}
 		}
 		return $snaks;
@@ -157,7 +157,7 @@ 
 		return new MainSnakContextCursor(
 			$this->entity->getId()->getSerialization(),
 			$this->statement->getPropertyId()->getSerialization(),
-			$this->getStatementGuid( $this->statement ),
+			$this->getStatementGuid($this->statement),
 			$this->statement->getMainSnak()->getHash()
 		);
 	}

src/ConstraintCheck/Message/ViolationMessageRenderer.php

Spacing +87 added lines, -87 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -62,17 +62,17 @@ 
 		$this->maxListLength = $maxListLength;
 	}
 
-	public function render( ViolationMessage $violationMessage ): string {
+	public function render(ViolationMessage $violationMessage): string {
 		$messageKey = $violationMessage->getMessageKey();
-		$paramsLists = [ [] ];
-		foreach ( $violationMessage->getArguments() as $argument ) {
-			$params = $this->renderArgument( $argument );
+		$paramsLists = [[]];
+		foreach ($violationMessage->getArguments() as $argument) {
+			$params = $this->renderArgument($argument);
 			$paramsLists[] = $params;
 		}
-		$allParams = call_user_func_array( 'array_merge', $paramsLists );
+		$allParams = call_user_func_array('array_merge', $paramsLists);
 		return $this->messageLocalizer
-			->msg( $messageKey )
-			->params( $allParams )
+			->msg($messageKey)
+			->params($allParams)
 			->escaped();
 	}
 
@@ -81,13 +81,13 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return string HTML
 	 */
-	protected function addRole( string $value, ?string $role ): string {
-		if ( $role === null ) {
+	protected function addRole(string $value, ?string $role): string {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
-			$value .
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
+			$value.
 			'</span>';
 	}
 
@@ -95,15 +95,15 @@ 
 	 * @param string $key message key
 	 * @return string HTML
 	 */
-	protected function msgEscaped( string $key ): string {
-		return $this->messageLocalizer->msg( $key )->escaped();
+	protected function msgEscaped(string $key): string {
+		return $this->messageLocalizer->msg($key)->escaped();
 	}
 
 	/**
 	 * @param array $argument
 	 * @return array[] params (for Message::params)
 	 */
-	protected function renderArgument( array $argument ): array {
+	protected function renderArgument(array $argument): array {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'renderEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'renderEntityIdList',
@@ -124,12 +124,12 @@ 
 		$value = $argument['value'];
 		$role = $argument['role'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$params = $this->$method( $value, $role );
+			$params = $this->$method($value, $role);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
@@ -143,36 +143,36 @@ 
 	 * and return a single-element array with a raw message param (i. e. [ Message::rawParam( … ) ])
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderList( array $list, ?string $role, callable $render ): array {
-		if ( $list === [] ) {
+	private function renderList(array $list, ?string $role, callable $render): array {
+		if ($list === []) {
 			return [
-				Message::numParam( 0 ),
-				Message::rawParam( '<ul></ul>' ),
+				Message::numParam(0),
+				Message::rawParam('<ul></ul>'),
 			];
 		}
 
-		if ( count( $list ) > $this->maxListLength ) {
-			$list = array_slice( $list, 0, $this->maxListLength );
+		if (count($list) > $this->maxListLength) {
+			$list = array_slice($list, 0, $this->maxListLength);
 			$truncated = true;
 		}
 
 		$renderedParamsLists = array_map(
 			$render,
 			$list,
-			array_fill( 0, count( $list ), $role )
+			array_fill(0, count($list), $role)
 		);
-		$renderedParams = array_column( $renderedParamsLists, 0 );
-		$renderedElements = array_column( $renderedParams, 'raw' );
-		if ( isset( $truncated ) ) {
-			$renderedElements[] = $this->msgEscaped( 'ellipsis' );
+		$renderedParams = array_column($renderedParamsLists, 0);
+		$renderedElements = array_column($renderedParams, 'raw');
+		if (isset($truncated)) {
+			$renderedElements[] = $this->msgEscaped('ellipsis');
 		}
 
 		return array_merge(
 			[
-				Message::numParam( count( $list ) ),
+				Message::numParam(count($list)),
 				Message::rawParam(
-					'<ul><li>' .
-					implode( '</li><li>', $renderedElements ) .
+					'<ul><li>'.
+					implode('</li><li>', $renderedElements).
 					'</li></ul>'
 				),
 			],
@@ -185,11 +185,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderEntityId( EntityId $entityId, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			$this->entityIdFormatter->formatEntityId( $entityId ),
+	private function renderEntityId(EntityId $entityId, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			$this->entityIdFormatter->formatEntityId($entityId),
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -197,8 +197,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderEntityIdList( array $entityIdList, ?string $role ): array {
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
+	private function renderEntityIdList(array $entityIdList, ?string $role): array {
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
 	}
 
 	/**
@@ -206,24 +206,24 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, ?string $role ): array {
-		switch ( true ) {
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, ?string $role): array {
+		switch (true) {
 			case $value->isValue():
-				return $this->renderEntityId( $value->getItemId(), $role );
+				return $this->renderEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return [ Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
-						$this->msgEscaped( 'wikibase-snakview-snaktypeselector-somevalue' ) .
+				return [Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
+						$this->msgEscaped('wikibase-snakview-snaktypeselector-somevalue').
 						'</span>',
 					$role
-				) ) ];
+				))];
 			case $value->isNoValue():
-				return [ Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
-					$this->msgEscaped( 'wikibase-snakview-snaktypeselector-novalue' ) .
+				return [Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
+					$this->msgEscaped('wikibase-snakview-snaktypeselector-novalue').
 						'</span>',
 					$role
-				) ) ];
+				))];
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
@@ -238,8 +238,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderItemIdSnakValueList( array $valueList, ?string $role ): array {
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
+	private function renderItemIdSnakValueList(array $valueList, ?string $role): array {
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
 	}
 
 	/**
@@ -247,11 +247,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderDataValue( DataValue $dataValue, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			$this->dataValueFormatter->format( $dataValue ),
+	private function renderDataValue(DataValue $dataValue, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			$this->dataValueFormatter->format($dataValue),
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -259,7 +259,7 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderDataValueType( string $dataValueType, ?string $role ): array {
+	private function renderDataValueType(string $dataValueType, ?string $role): array {
 		$messageKeys = [
 			'string' => 'datatypes-type-string',
 			'monolingualtext' => 'datatypes-type-monolingualtext',
@@ -268,15 +268,15 @@ 
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
 		];
 
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
-			return [ Message::rawParam( $this->addRole(
-				$this->msgEscaped( $messageKeys[$dataValueType] ),
+		if (array_key_exists($dataValueType, $messageKeys)) {
+			return [Message::rawParam($this->addRole(
+				$this->msgEscaped($messageKeys[$dataValueType]),
 				$role
-			) ) ];
+			))];
 		} else {
 			// @codeCoverageIgnoreStart
 			throw new LogicException(
-				'Unknown data value type ' . $dataValueType
+				'Unknown data value type '.$dataValueType
 			);
 			// @codeCoverageIgnoreEnd
 		}
@@ -287,11 +287,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderInlineCode( string $code, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			'<code>' . htmlspecialchars( $code ) . '</code>',
+	private function renderInlineCode(string $code, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			'<code>'.htmlspecialchars($code).'</code>',
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -299,8 +299,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderConstraintScope( string $scope, ?string $role ): array {
-		switch ( $scope ) {
+	private function renderConstraintScope(string $scope, ?string $role): array {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
 				$itemId = $this->config->get(
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -320,10 +320,10 @@ 
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
+		return $this->renderEntityId(new ItemId($itemId), $role);
 	}
 
 	/**
@@ -331,8 +331,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderConstraintScopeList( array $scopeList, ?string $role ): array {
-		return $this->renderList( $scopeList, $role, [ $this, 'renderConstraintScope' ] );
+	private function renderConstraintScopeList(array $scopeList, ?string $role): array {
+		return $this->renderList($scopeList, $role, [$this, 'renderConstraintScope']);
 	}
 
 	/**
@@ -340,25 +340,25 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderPropertyScope( string $scope, ?string $role ): array {
-		switch ( $scope ) {
+	private function renderPropertyScope(string $scope, ?string $role): array {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsMainValueId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsMainValueId');
 				break;
 			case Context::TYPE_QUALIFIER:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsQualifiersId');
 				break;
 			case Context::TYPE_REFERENCE:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsReferencesId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsReferencesId');
 				break;
 			default:
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
+		return $this->renderEntityId(new ItemId($itemId), $role);
 	}
 
 	/**
@@ -366,8 +366,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderPropertyScopeList( array $scopeList, ?string $role ): array {
-		return $this->renderList( $scopeList, $role, [ $this, 'renderPropertyScope' ] );
+	private function renderPropertyScopeList(array $scopeList, ?string $role): array {
+		return $this->renderList($scopeList, $role, [$this, 'renderPropertyScope']);
 	}
 
 	/**
@@ -375,14 +375,14 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderLanguage( string $languageCode, ?string $role ): array {
+	private function renderLanguage(string $languageCode, ?string $role): array {
 		return [
 			// ::renderList (through ::renderLanguageList) requires 'raw' parameter
 			// so we effectively build Message::plaintextParam here
-			Message::rawParam( htmlspecialchars(
-				$this->languageNameUtils->getLanguageName( $languageCode, $this->userLanguageCode )
-			) ),
-			Message::plaintextParam( $languageCode ),
+			Message::rawParam(htmlspecialchars(
+				$this->languageNameUtils->getLanguageName($languageCode, $this->userLanguageCode)
+			)),
+			Message::plaintextParam($languageCode),
 		];
 	}
 
@@ -391,8 +391,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderLanguageList( array $languageCodes, ?string $role ): array {
-		return $this->renderList( $languageCodes, $role, [ $this, 'renderLanguage' ] );
+	private function renderLanguageList(array $languageCodes, ?string $role): array {
+		return $this->renderList($languageCodes, $role, [$this, 'renderLanguage']);
 	}
 
 }

src/ConstraintCheck/Result/NullResult.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result;
 
@@ -27,22 +27,22 @@ 
 	 */
 	private const NULL_PROPERTY_ID = 'P2147483647';
 
-	public function __construct( ContextCursor $contextCursor ) {
+	public function __construct(ContextCursor $contextCursor) {
 		$constraint = new Constraint(
 			'null',
-			new NumericPropertyId( self::NULL_PROPERTY_ID ),
+			new NumericPropertyId(self::NULL_PROPERTY_ID),
 			'none',
 			[]
 		);
-		parent::__construct( $contextCursor, $constraint );
+		parent::__construct($contextCursor, $constraint);
 	}
 
 	public function getConstraint(): Constraint {
-		throw new DomainException( 'NullResult holds no constraint' );
+		throw new DomainException('NullResult holds no constraint');
 	}
 
 	public function getConstraintId(): string {
-		throw new DomainException( 'NullResult holds no constraint' );
+		throw new DomainException('NullResult holds no constraint');
 	}
 
 }

src/Api/CheckConstraints.php

Spacing +30 added lines, -30 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -81,11 +81,11 @@ 
 		CheckResultsRendererFactory $checkResultsRendererFactory,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->resultsSource = $resultsSource;
 		$this->checkResultsRendererFactory = $checkResultsRendererFactory;
 		$this->dataFactory = $dataFactory;
@@ -101,14 +101,14 @@ 
 
 		$params = $this->extractRequestParams();
 
-		$this->validateParameters( $params );
-		$entityIds = $this->parseEntityIds( $params );
-		$claimIds = $this->parseClaimIds( $params );
+		$this->validateParameters($params);
+		$entityIds = $this->parseEntityIds($params);
+		$claimIds = $this->parseClaimIds($params);
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
 		$statuses = $params[self::PARAM_STATUS];
 
 		$checkResultsRenderer = $this->checkResultsRendererFactory
-			->getCheckResultsRenderer( $this->getLanguage(), $this );
+			->getCheckResultsRenderer($this->getLanguage(), $this);
 
 		$this->getResult()->addValue(
 			null,
@@ -122,7 +122,7 @@ 
 				)
 			)->getArray()
 		);
-		$this->resultBuilder->markSuccess( 1 );
+		$this->resultBuilder->markSuccess(1);
 	}
 
 	/**
@@ -130,24 +130,24 @@ 
 	 *
 	 * @return EntityId[]
 	 */
-	private function parseEntityIds( array $params ): array {
+	private function parseEntityIds(array $params): array {
 		$ids = $params[self::PARAM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		return array_map( function ( $id ) {
+		return array_map(function($id) {
 			try {
-				return $this->entityIdParser->parse( $id );
-			} catch ( EntityIdParsingException $e ) {
+				return $this->entityIdParser->parse($id);
+			} catch (EntityIdParsingException $e) {
 				$this->errorReporter->dieError(
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
 			}
-		}, $ids );
+		}, $ids);
 	}
 
 	/**
@@ -155,35 +155,35 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function parseClaimIds( array $params ): array {
+	private function parseClaimIds(array $params): array {
 		$ids = $params[self::PARAM_CLAIM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		foreach ( $ids as $id ) {
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
+		foreach ($ids as $id) {
+			if (!$this->statementGuidValidator->validate($id)) {
 				$this->errorReporter->dieError(
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
 			}
 		}
 
 		return $ids;
 	}
 
-	private function validateParameters( array $params ): void {
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
+	private function validateParameters(array $params): void {
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
 		) {
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
 			$this->errorReporter->dieError(
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
 		}
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
 			$paramId = self::PARAM_ID;
 			$paramClaimId = self::PARAM_CLAIM_ID;
 			$this->errorReporter->dieError(
@@ -224,7 +224,7 @@ 
 				],
 				ParamValidator::PARAM_ISMULTI => true,
 				ParamValidator::PARAM_ALL => true,
-				ParamValidator::PARAM_DEFAULT => implode( '|', CachingResultsSource::CACHED_STATUSES ),
+				ParamValidator::PARAM_DEFAULT => implode('|', CachingResultsSource::CACHED_STATUSES),
 				ApiBase::PARAM_HELP_MSG_PER_VALUE => [],
 			],
 		];

src/ConstraintCheck/Message/MultilingualTextViolationMessageRenderer.php

Spacing +21 added lines, -21 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -27,13 +27,13 @@ 
 		'wbqc-violation-message-format-clarification' => 'wbqc-violation-message-format',
 	];
 
-	public function render( ViolationMessage $violationMessage ): string {
-		if ( !array_key_exists( $violationMessage->getMessageKey(), self::ALTERNATIVE_MESSAGE_KEYS ) ) {
-			return parent::render( $violationMessage );
+	public function render(ViolationMessage $violationMessage): string {
+		if (!array_key_exists($violationMessage->getMessageKey(), self::ALTERNATIVE_MESSAGE_KEYS)) {
+			return parent::render($violationMessage);
 		}
 
 		$arguments = $violationMessage->getArguments();
-		$multilingualTextArgument = array_pop( $arguments );
+		$multilingualTextArgument = array_pop($arguments);
 		$multilingualTextParams = $this->renderMultilingualText(
 			// @phan-suppress-next-line PhanTypeArraySuspiciousNullable TODO Ensure this is not an actual issue
 			$multilingualTextArgument['value'],
@@ -41,22 +41,22 @@ 
 			$multilingualTextArgument['role']
 		);
 
-		$paramsLists = [ [] ];
-		foreach ( $arguments as $argument ) {
-			$paramsLists[] = $this->renderArgument( $argument );
+		$paramsLists = [[]];
+		foreach ($arguments as $argument) {
+			$paramsLists[] = $this->renderArgument($argument);
 		}
-		$regularParams = call_user_func_array( 'array_merge', $paramsLists );
+		$regularParams = call_user_func_array('array_merge', $paramsLists);
 
-		if ( $multilingualTextParams === null ) {
+		if ($multilingualTextParams === null) {
 			return $this->messageLocalizer
-				->msg( self::ALTERNATIVE_MESSAGE_KEYS[$violationMessage->getMessageKey()] )
-				->params( $regularParams )
+				->msg(self::ALTERNATIVE_MESSAGE_KEYS[$violationMessage->getMessageKey()])
+				->params($regularParams)
 				->escaped();
 		} else {
 			return $this->messageLocalizer
-				->msg( $violationMessage->getMessageKey() )
-				->params( $regularParams )
-				->params( $multilingualTextParams )
+				->msg($violationMessage->getMessageKey())
+				->params($regularParams)
+				->params($multilingualTextParams)
 				->escaped();
 		}
 	}
@@ -67,14 +67,14 @@ 
 	 * @return array[]|null list of parameters as accepted by Message::params(),
 	 * or null if the text is not available in the user’s language
 	 */
-	protected function renderMultilingualText( MultilingualTextValue $text, ?string $role ): ?array {
+	protected function renderMultilingualText(MultilingualTextValue $text, ?string $role): ?array {
 		$texts = $text->getTexts();
-		foreach ( $this->languageFallbackChain->getFetchLanguageCodes() as $languageCode ) {
-			if ( array_key_exists( $languageCode, $texts ) ) {
-				return [ Message::rawParam( $this->addRole(
-					htmlspecialchars( $texts[$languageCode]->getText() ),
+		foreach ($this->languageFallbackChain->getFetchLanguageCodes() as $languageCode) {
+			if (array_key_exists($languageCode, $texts)) {
+				return [Message::rawParam($this->addRole(
+					htmlspecialchars($texts[$languageCode]->getText()),
 					$role
-				) ) ];
+				))];
 			}
 		}
 

src/ConstraintCheck/Message/ViolationMessageRendererFactory.php

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -43,12 +43,12 @@ 
 	): ViolationMessageRenderer {
 		$userLanguageCode = $userLanguage->getCode();
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $userLanguageCode );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $userLanguageCode);
 		return new MultilingualTextViolationMessageRenderer(
 			$this->entityIdHtmlLinkFormatterFactory
-				->getEntityIdFormatter( $userLanguage ),
+				->getEntityIdFormatter($userLanguage),
 			$this->valueFormatterFactory
-				->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ),
+				->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions),
 			$this->languageNameUtils,
 			$userLanguageCode,
 			$languageFallbackChain,

src/Api/ResultsCache.php

Spacing +8 added lines, -8 removed lines

@@ -36,7 +36,7 @@ 
 	 * @param WANObjectCache $cache
 	 * @param string $formatVersion The version of the API response format.
 	 */
-	public function __construct( WANObjectCache $cache, $formatVersion ) {
+	public function __construct(WANObjectCache $cache, $formatVersion) {
 		$this->cache = $cache;
 		$this->formatVersion = $formatVersion;
 	}
@@ -45,7 +45,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string cache key
 	 */
-	public function makeKey( EntityId $entityId ) {
+	public function makeKey(EntityId $entityId) {
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'checkConstraints', // action
@@ -61,8 +61,8 @@ 
 	 * @param array &$info
 	 * @return mixed
 	 */
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], array &$info = [] ) {
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $info );
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], array &$info = []) {
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $info);
 	}
 
 	/**
@@ -72,16 +72,16 @@ 
 	 * @param array $opts
 	 * @return bool
 	 */
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
 	}
 
 	/**
 	 * @param EntityId $key
 	 * @return bool
 	 */
-	public function delete( EntityId $key ) {
-		return $this->cache->delete( $this->makeKey( $key ) );
+	public function delete(EntityId $key) {
+		return $this->cache->delete($this->makeKey($key));
 	}
 
 }

src/Api/CheckResultsRendererFactory.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -37,12 +37,12 @@ 
 		Language $userLanguage,
 		MessageLocalizer $messageLocalizer
 	): CheckResultsRenderer {
-		$languageFallbackChain = $this->languageFallbackChainFactory->newFromLanguage( $userLanguage );
+		$languageFallbackChain = $this->languageFallbackChainFactory->newFromLanguage($userLanguage);
 
 		return new CheckResultsRenderer(
 			$this->entityTitleLookup,
 			$this->entityIdLabelFormatterFactory
-				->getEntityIdFormatter( $userLanguage ),
+				->getEntityIdFormatter($userLanguage),
 			$languageFallbackChain,
 			$this->violationMessageRendererFactory
 				->getViolationMessageRenderer(

src/ConstraintCheck/Result/CheckResultSerializer.php

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result;
 
@@ -60,14 +60,14 @@ 
 		$this->serializeDependencyMetadata = $serializeDependencyMetadata;
 	}
 
-	public function serialize( CheckResult $checkResult ): array {
+	public function serialize(CheckResult $checkResult): array {
 		$contextCursor = $checkResult->getContextCursor();
 
 		$serialization = [
-			self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize( $contextCursor ),
+			self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize($contextCursor),
 		];
 
-		if ( $checkResult instanceof NullResult ) {
+		if ($checkResult instanceof NullResult) {
 			$serialization[self::KEY_NULL_RESULT] = 1;
 		} else {
 			$constraint = $checkResult->getConstraint();
@@ -76,57 +76,57 @@ 
 			$clarification = $checkResult->getConstraintClarification();
 
 			$serialization[self::KEY_CONSTRAINT] =
-				$this->constraintSerializer->serialize( $constraint );
+				$this->constraintSerializer->serialize($constraint);
 			$serialization[self::KEY_CHECK_RESULT_STATUS] =
 				$checkResult->getStatus();
 			$serialization[self::KEY_CACHING_METADATA] =
-				$this->serializeCachingMetadata( $cachingMetadata );
+				$this->serializeCachingMetadata($cachingMetadata);
 
-			if ( $violationMessage !== null ) {
+			if ($violationMessage !== null) {
 				$serialization[self::KEY_VIOLATION_MESSAGE] =
-					$this->violationMessageSerializer->serialize( $violationMessage );
+					$this->violationMessageSerializer->serialize($violationMessage);
 			}
-			if ( $clarification->getTexts() !== [] ) {
+			if ($clarification->getTexts() !== []) {
 				$serialization[self::KEY_CONSTRAINT_CLARIFICATION] =
 					$clarification->getArrayValue();
 			}
 		}
 
-		if ( $this->serializeDependencyMetadata ) {
+		if ($this->serializeDependencyMetadata) {
 			$serialization[self::KEY_DEPENDENCY_METADATA] =
-				$this->serializeDependencyMetadata( $checkResult );
+				$this->serializeDependencyMetadata($checkResult);
 		}
 
 		return $serialization;
 	}
 
-	private function serializeCachingMetadata( CachingMetadata $cachingMetadata ): array {
+	private function serializeCachingMetadata(CachingMetadata $cachingMetadata): array {
 		$maximumAge = $cachingMetadata->getMaximumAgeInSeconds();
 
 		$serialization = [];
 
-		if ( $maximumAge > 0 ) {
+		if ($maximumAge > 0) {
 			$serialization[self::KEY_CACHING_METADATA_MAX_AGE] = $maximumAge;
 		}
 
 		return $serialization;
 	}
 
-	private function serializeDependencyMetadata( CheckResult $checkResult ): array {
+	private function serializeDependencyMetadata(CheckResult $checkResult): array {
 		$dependencyMetadata = $checkResult->getMetadata()->getDependencyMetadata();
 		$entityIds = $dependencyMetadata->getEntityIds();
 		$futureTime = $dependencyMetadata->getFutureTime();
 
 		$serialization = [
 			self::KEY_DEPENDENCY_METADATA_ENTITY_IDS => array_map(
-				static function ( EntityId $entityId ) {
+				static function(EntityId $entityId) {
 					return $entityId->getSerialization();
 				},
 				$entityIds
 			),
 		];
 
-		if ( $futureTime !== null ) {
+		if ($futureTime !== null) {
 			$serialization[self::KEY_DEPENDENCY_METADATA_FUTURE_TIME] =
 				$futureTime->getArrayValue();
 		}