@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker; |
6 | 6 | |
@@ -74,26 +74,26 @@ discard block |
||
74 | 74 | * @return array first element is the namespace number (default namespace for TitleParser), |
75 | 75 | * second element is a string to prepend to the title before giving it to the TitleParser |
76 | 76 | */ |
77 | - private function getCommonsNamespace( string $namespace ): array { |
|
78 | - switch ( $namespace ) { |
|
77 | + private function getCommonsNamespace(string $namespace): array { |
|
78 | + switch ($namespace) { |
|
79 | 79 | case '': |
80 | - return [ NS_MAIN, '' ]; |
|
80 | + return [NS_MAIN, '']; |
|
81 | 81 | // extra namespaces, see operations/mediawiki-config.git, |
82 | 82 | // wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey |
83 | 83 | case 'Creator': |
84 | - return [ 100, '' ]; |
|
84 | + return [100, '']; |
|
85 | 85 | case 'TimedText': |
86 | - return [ 102, '' ]; |
|
86 | + return [102, '']; |
|
87 | 87 | case 'Sequence': |
88 | - return [ 104, '' ]; |
|
88 | + return [104, '']; |
|
89 | 89 | case 'Institution': |
90 | - return [ 106, '' ]; |
|
90 | + return [106, '']; |
|
91 | 91 | // extension namespace, see mediawiki/extensions/JsonConfig.git, |
92 | 92 | // extension.json, 'namespaces' key, third element |
93 | 93 | case 'Data': |
94 | - return [ 486, '' ]; |
|
94 | + return [486, '']; |
|
95 | 95 | default: |
96 | - return [ NS_MAIN, $namespace . ':' ]; |
|
96 | + return [NS_MAIN, $namespace.':']; |
|
97 | 97 | } |
98 | 98 | } |
99 | 99 | |
@@ -102,7 +102,7 @@ discard block |
||
102 | 102 | * |
103 | 103 | * @throws ConstraintParameterException |
104 | 104 | */ |
105 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult { |
|
105 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult { |
|
106 | 106 | $constraintParameters = $constraint->getConstraintParameters(); |
107 | 107 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
108 | 108 | |
@@ -113,9 +113,9 @@ discard block |
||
113 | 113 | |
114 | 114 | $snak = $context->getSnak(); |
115 | 115 | |
116 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
116 | + if (!$snak instanceof PropertyValueSnak) { |
|
117 | 117 | // nothing to check |
118 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
118 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
119 | 119 | } |
120 | 120 | |
121 | 121 | $dataValue = $snak->getDataValue(); |
@@ -125,52 +125,52 @@ discard block |
||
125 | 125 | * type of $dataValue for properties with 'Commons link' constraint has to be 'string' |
126 | 126 | * parameter $namespace can be null, works for commons galleries |
127 | 127 | */ |
128 | - if ( $dataValue->getType() !== 'string' ) { |
|
129 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
130 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
131 | - ->withDataValueType( 'string' ); |
|
132 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
128 | + if ($dataValue->getType() !== 'string') { |
|
129 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
130 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
131 | + ->withDataValueType('string'); |
|
132 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
133 | 133 | } |
134 | 134 | |
135 | 135 | $commonsLink = $dataValue->getValue(); |
136 | - if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) { |
|
137 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
138 | - new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) ); |
|
136 | + if (!$this->commonsLinkIsWellFormed($commonsLink)) { |
|
137 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
138 | + new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed')); |
|
139 | 139 | } |
140 | 140 | |
141 | - $dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty( $snak->getPropertyId() ); |
|
142 | - switch ( $dataType ) { |
|
141 | + $dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty($snak->getPropertyId()); |
|
142 | + switch ($dataType) { |
|
143 | 143 | case 'geo-shape': |
144 | 144 | case 'tabular-data': |
145 | - if ( strpos( $commonsLink, $namespace . ':' ) !== 0 ) { |
|
146 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
147 | - new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) ); |
|
145 | + if (strpos($commonsLink, $namespace.':') !== 0) { |
|
146 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
147 | + new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed')); |
|
148 | 148 | } |
149 | 149 | $pageName = $commonsLink; |
150 | 150 | break; |
151 | 151 | default: |
152 | - $pageName = $namespace ? $namespace . ':' . $commonsLink : $commonsLink; |
|
152 | + $pageName = $namespace ? $namespace.':'.$commonsLink : $commonsLink; |
|
153 | 153 | break; |
154 | 154 | } |
155 | 155 | |
156 | - $prefix = $this->getCommonsNamespace( $namespace )[1]; |
|
156 | + $prefix = $this->getCommonsNamespace($namespace)[1]; |
|
157 | 157 | $normalizedTitle = $this->pageNameNormalizer->normalizePageName( |
158 | 158 | $pageName, |
159 | 159 | 'https://commons.wikimedia.org/w/api.php' |
160 | 160 | ); |
161 | - if ( $normalizedTitle === false ) { |
|
162 | - if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) { |
|
163 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
164 | - new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) ); |
|
161 | + if ($normalizedTitle === false) { |
|
162 | + if ($this->valueIncludesNamespace($commonsLink, $namespace)) { |
|
163 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
164 | + new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed')); |
|
165 | 165 | } |
166 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
167 | - new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ) ); |
|
166 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
167 | + new ViolationMessage('wbqc-violation-message-commons-link-no-existent')); |
|
168 | 168 | } |
169 | 169 | |
170 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE, null ); |
|
170 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE, null); |
|
171 | 171 | } |
172 | 172 | |
173 | - public function checkConstraintParameters( Constraint $constraint ): array { |
|
173 | + public function checkConstraintParameters(Constraint $constraint): array { |
|
174 | 174 | $constraintParameters = $constraint->getConstraintParameters(); |
175 | 175 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
176 | 176 | $exceptions = []; |
@@ -179,15 +179,15 @@ discard block |
||
179 | 179 | $constraintParameters, |
180 | 180 | $constraintTypeItemId |
181 | 181 | ); |
182 | - } catch ( ConstraintParameterException $e ) { |
|
182 | + } catch (ConstraintParameterException $e) { |
|
183 | 183 | $exceptions[] = $e; |
184 | 184 | } |
185 | 185 | return $exceptions; |
186 | 186 | } |
187 | 187 | |
188 | - private function commonsLinkIsWellFormed( string $commonsLink ): bool { |
|
189 | - $toReplace = [ "_", "%20" ]; |
|
190 | - $compareString = trim( str_replace( $toReplace, '', $commonsLink ) ); |
|
188 | + private function commonsLinkIsWellFormed(string $commonsLink): bool { |
|
189 | + $toReplace = ["_", "%20"]; |
|
190 | + $compareString = trim(str_replace($toReplace, '', $commonsLink)); |
|
191 | 191 | |
192 | 192 | return $commonsLink === $compareString; |
193 | 193 | } |
@@ -196,9 +196,9 @@ discard block |
||
196 | 196 | * Checks whether the value of the statement already includes the namespace. |
197 | 197 | * This special case should be reported as “malformed title” instead of “title does not exist”. |
198 | 198 | */ |
199 | - private function valueIncludesNamespace( string $value, string $namespace ): bool { |
|
199 | + private function valueIncludesNamespace(string $value, string $namespace): bool { |
|
200 | 200 | return $namespace !== '' && |
201 | - strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0; |
|
201 | + strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0; |
|
202 | 202 | } |
203 | 203 | |
204 | 204 | } |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck; |
6 | 6 | |
@@ -123,10 +123,10 @@ discard block |
||
123 | 123 | callable $defaultResultsPerEntity = null |
124 | 124 | ): array { |
125 | 125 | $checkResults = []; |
126 | - $entity = $this->entityLookup->getEntity( $entityId ); |
|
126 | + $entity = $this->entityLookup->getEntity($entityId); |
|
127 | 127 | |
128 | - if ( $entity instanceof StatementListProvidingEntity ) { |
|
129 | - $startTime = microtime( true ); |
|
128 | + if ($entity instanceof StatementListProvidingEntity) { |
|
129 | + $startTime = microtime(true); |
|
130 | 130 | |
131 | 131 | $checkResults = $this->checkEveryStatement( |
132 | 132 | $entity, |
@@ -134,9 +134,9 @@ discard block |
||
134 | 134 | $defaultResultsPerContext |
135 | 135 | ); |
136 | 136 | |
137 | - $endTime = microtime( true ); |
|
137 | + $endTime = microtime(true); |
|
138 | 138 | |
139 | - if ( $constraintIds === null ) { // only log full constraint checks |
|
139 | + if ($constraintIds === null) { // only log full constraint checks |
|
140 | 140 | $this->loggingHelper->logConstraintCheckOnEntity( |
141 | 141 | $entityId, |
142 | 142 | $checkResults, |
@@ -146,11 +146,11 @@ discard block |
||
146 | 146 | } |
147 | 147 | } |
148 | 148 | |
149 | - if ( $defaultResultsPerEntity !== null ) { |
|
150 | - $checkResults = array_merge( $defaultResultsPerEntity( $entityId ), $checkResults ); |
|
149 | + if ($defaultResultsPerEntity !== null) { |
|
150 | + $checkResults = array_merge($defaultResultsPerEntity($entityId), $checkResults); |
|
151 | 151 | } |
152 | 152 | |
153 | - return $this->sortResult( $checkResults ); |
|
153 | + return $this->sortResult($checkResults); |
|
154 | 154 | } |
155 | 155 | |
156 | 156 | /** |
@@ -172,19 +172,19 @@ discard block |
||
172 | 172 | callable $defaultResults = null |
173 | 173 | ): array { |
174 | 174 | |
175 | - $parsedGuid = $this->statementGuidParser->parse( $guid ); |
|
175 | + $parsedGuid = $this->statementGuidParser->parse($guid); |
|
176 | 176 | $entityId = $parsedGuid->getEntityId(); |
177 | - $entity = $this->entityLookup->getEntity( $entityId ); |
|
178 | - if ( $entity instanceof StatementListProvidingEntity ) { |
|
179 | - $statement = $entity->getStatements()->getFirstStatementWithGuid( $guid ); |
|
180 | - if ( $statement ) { |
|
177 | + $entity = $this->entityLookup->getEntity($entityId); |
|
178 | + if ($entity instanceof StatementListProvidingEntity) { |
|
179 | + $statement = $entity->getStatements()->getFirstStatementWithGuid($guid); |
|
180 | + if ($statement) { |
|
181 | 181 | $result = $this->checkStatement( |
182 | 182 | $entity, |
183 | 183 | $statement, |
184 | 184 | $constraintIds, |
185 | 185 | $defaultResults |
186 | 186 | ); |
187 | - $output = $this->sortResult( $result ); |
|
187 | + $output = $this->sortResult($result); |
|
188 | 188 | return $output; |
189 | 189 | } |
190 | 190 | } |
@@ -192,8 +192,8 @@ discard block |
||
192 | 192 | return []; |
193 | 193 | } |
194 | 194 | |
195 | - private function getValidContextTypes( Constraint $constraint ): array { |
|
196 | - if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
195 | + private function getValidContextTypes(Constraint $constraint): array { |
|
196 | + if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
197 | 197 | return [ |
198 | 198 | Context::TYPE_STATEMENT, |
199 | 199 | Context::TYPE_QUALIFIER, |
@@ -201,25 +201,25 @@ discard block |
||
201 | 201 | ]; |
202 | 202 | } |
203 | 203 | |
204 | - return array_keys( array_filter( |
|
204 | + return array_keys(array_filter( |
|
205 | 205 | $this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedContextTypes(), |
206 | - static function ( $resultStatus ) { |
|
206 | + static function($resultStatus) { |
|
207 | 207 | return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE; |
208 | 208 | } |
209 | - ) ); |
|
209 | + )); |
|
210 | 210 | } |
211 | 211 | |
212 | - private function getValidEntityTypes( Constraint $constraint ): array { |
|
213 | - if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
214 | - return array_keys( ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED ); |
|
212 | + private function getValidEntityTypes(Constraint $constraint): array { |
|
213 | + if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
214 | + return array_keys(ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED); |
|
215 | 215 | } |
216 | 216 | |
217 | - return array_keys( array_filter( |
|
217 | + return array_keys(array_filter( |
|
218 | 218 | $this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedEntityTypes(), |
219 | - static function ( $resultStatus ) { |
|
219 | + static function($resultStatus) { |
|
220 | 220 | return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE; |
221 | 221 | } |
222 | - ) ); |
|
222 | + )); |
|
223 | 223 | } |
224 | 224 | |
225 | 225 | /** |
@@ -230,38 +230,38 @@ discard block |
||
230 | 230 | * |
231 | 231 | * @return ConstraintParameterException[] |
232 | 232 | */ |
233 | - private function checkCommonConstraintParameters( Constraint $constraint ): array { |
|
233 | + private function checkCommonConstraintParameters(Constraint $constraint): array { |
|
234 | 234 | $constraintParameters = $constraint->getConstraintParameters(); |
235 | 235 | try { |
236 | - $this->constraintParameterParser->checkError( $constraintParameters ); |
|
237 | - } catch ( ConstraintParameterException $e ) { |
|
238 | - return [ $e ]; |
|
236 | + $this->constraintParameterParser->checkError($constraintParameters); |
|
237 | + } catch (ConstraintParameterException $e) { |
|
238 | + return [$e]; |
|
239 | 239 | } |
240 | 240 | |
241 | 241 | $problems = []; |
242 | 242 | try { |
243 | - $this->constraintParameterParser->parseExceptionParameter( $constraintParameters ); |
|
244 | - } catch ( ConstraintParameterException $e ) { |
|
243 | + $this->constraintParameterParser->parseExceptionParameter($constraintParameters); |
|
244 | + } catch (ConstraintParameterException $e) { |
|
245 | 245 | $problems[] = $e; |
246 | 246 | } |
247 | 247 | try { |
248 | - $this->constraintParameterParser->parseConstraintClarificationParameter( $constraintParameters ); |
|
249 | - } catch ( ConstraintParameterException $e ) { |
|
248 | + $this->constraintParameterParser->parseConstraintClarificationParameter($constraintParameters); |
|
249 | + } catch (ConstraintParameterException $e) { |
|
250 | 250 | $problems[] = $e; |
251 | 251 | } |
252 | 252 | try { |
253 | - $this->constraintParameterParser->parseConstraintStatusParameter( $constraintParameters ); |
|
254 | - } catch ( ConstraintParameterException $e ) { |
|
253 | + $this->constraintParameterParser->parseConstraintStatusParameter($constraintParameters); |
|
254 | + } catch (ConstraintParameterException $e) { |
|
255 | 255 | $problems[] = $e; |
256 | 256 | } |
257 | 257 | try { |
258 | 258 | $this->constraintParameterParser->parseConstraintScopeParameters( |
259 | 259 | $constraintParameters, |
260 | 260 | $constraint->getConstraintTypeItemId(), |
261 | - $this->getValidContextTypes( $constraint ), |
|
262 | - $this->getValidEntityTypes( $constraint ) |
|
261 | + $this->getValidContextTypes($constraint), |
|
262 | + $this->getValidEntityTypes($constraint) |
|
263 | 263 | ); |
264 | - } catch ( ConstraintParameterException $e ) { |
|
264 | + } catch (ConstraintParameterException $e) { |
|
265 | 265 | $problems[] = $e; |
266 | 266 | } |
267 | 267 | return $problems; |
@@ -274,16 +274,16 @@ discard block |
||
274 | 274 | * @return ConstraintParameterException[][] first level indexed by constraint ID, |
275 | 275 | * second level like checkConstraintParametersOnConstraintId (but without possibility of null) |
276 | 276 | */ |
277 | - public function checkConstraintParametersOnPropertyId( NumericPropertyId $propertyId ): array { |
|
278 | - $constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId ); |
|
277 | + public function checkConstraintParametersOnPropertyId(NumericPropertyId $propertyId): array { |
|
278 | + $constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId); |
|
279 | 279 | $result = []; |
280 | 280 | |
281 | - foreach ( $constraints as $constraint ) { |
|
282 | - $problems = $this->checkCommonConstraintParameters( $constraint ); |
|
281 | + foreach ($constraints as $constraint) { |
|
282 | + $problems = $this->checkCommonConstraintParameters($constraint); |
|
283 | 283 | |
284 | - if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
284 | + if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
285 | 285 | $checker = $this->checkerMap[$constraint->getConstraintTypeItemId()]; |
286 | - $problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) ); |
|
286 | + $problems = array_merge($problems, $checker->checkConstraintParameters($constraint)); |
|
287 | 287 | } |
288 | 288 | |
289 | 289 | $result[$constraint->getConstraintId()] = $problems; |
@@ -300,18 +300,18 @@ discard block |
||
300 | 300 | * @return ConstraintParameterException[]|null list of constraint parameter exceptions |
301 | 301 | * (empty means all parameters okay), or null if constraint is not found |
302 | 302 | */ |
303 | - public function checkConstraintParametersOnConstraintId( string $constraintId ): ?array { |
|
304 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
303 | + public function checkConstraintParametersOnConstraintId(string $constraintId): ?array { |
|
304 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
305 | 305 | '@phan-var NumericPropertyId $propertyId'; |
306 | - $constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId ); |
|
306 | + $constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId); |
|
307 | 307 | |
308 | - foreach ( $constraints as $constraint ) { |
|
309 | - if ( $constraint->getConstraintId() === $constraintId ) { |
|
310 | - $problems = $this->checkCommonConstraintParameters( $constraint ); |
|
308 | + foreach ($constraints as $constraint) { |
|
309 | + if ($constraint->getConstraintId() === $constraintId) { |
|
310 | + $problems = $this->checkCommonConstraintParameters($constraint); |
|
311 | 311 | |
312 | - if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
312 | + if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
313 | 313 | $checker = $this->checkerMap[$constraint->getConstraintTypeItemId()]; |
314 | - $problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) ); |
|
314 | + $problems = array_merge($problems, $checker->checkConstraintParameters($constraint)); |
|
315 | 315 | } |
316 | 316 | |
317 | 317 | return $problems; |
@@ -336,14 +336,14 @@ discard block |
||
336 | 336 | $result = []; |
337 | 337 | |
338 | 338 | /** @var Statement $statement */ |
339 | - foreach ( $entity->getStatements() as $statement ) { |
|
340 | - $result = array_merge( $result, |
|
339 | + foreach ($entity->getStatements() as $statement) { |
|
340 | + $result = array_merge($result, |
|
341 | 341 | $this->checkStatement( |
342 | 342 | $entity, |
343 | 343 | $statement, |
344 | 344 | $constraintIds, |
345 | 345 | $defaultResultsPerContext |
346 | - ) ); |
|
346 | + )); |
|
347 | 347 | } |
348 | 348 | |
349 | 349 | return $result; |
@@ -365,32 +365,32 @@ discard block |
||
365 | 365 | ): array { |
366 | 366 | $result = []; |
367 | 367 | |
368 | - $result = array_merge( $result, |
|
368 | + $result = array_merge($result, |
|
369 | 369 | $this->checkConstraintsForMainSnak( |
370 | 370 | $entity, |
371 | 371 | $statement, |
372 | 372 | $constraintIds, |
373 | 373 | $defaultResultsPerContext |
374 | - ) ); |
|
374 | + )); |
|
375 | 375 | |
376 | - if ( $this->checkQualifiers ) { |
|
377 | - $result = array_merge( $result, |
|
376 | + if ($this->checkQualifiers) { |
|
377 | + $result = array_merge($result, |
|
378 | 378 | $this->checkConstraintsForQualifiers( |
379 | 379 | $entity, |
380 | 380 | $statement, |
381 | 381 | $constraintIds, |
382 | 382 | $defaultResultsPerContext |
383 | - ) ); |
|
383 | + )); |
|
384 | 384 | } |
385 | 385 | |
386 | - if ( $this->checkReferences ) { |
|
387 | - $result = array_merge( $result, |
|
386 | + if ($this->checkReferences) { |
|
387 | + $result = array_merge($result, |
|
388 | 388 | $this->checkConstraintsForReferences( |
389 | 389 | $entity, |
390 | 390 | $statement, |
391 | 391 | $constraintIds, |
392 | 392 | $defaultResultsPerContext |
393 | - ) ); |
|
393 | + )); |
|
394 | 394 | } |
395 | 395 | |
396 | 396 | return $result; |
@@ -405,17 +405,17 @@ discard block |
||
405 | 405 | * @param string[]|null $constraintIds |
406 | 406 | * @return Constraint[] |
407 | 407 | */ |
408 | - private function getConstraintsToUse( PropertyId $propertyId, ?array $constraintIds ): array { |
|
409 | - if ( !( $propertyId instanceof NumericPropertyId ) ) { |
|
408 | + private function getConstraintsToUse(PropertyId $propertyId, ?array $constraintIds): array { |
|
409 | + if (!($propertyId instanceof NumericPropertyId)) { |
|
410 | 410 | throw new InvalidArgumentException( |
411 | - 'Non-numeric property ID not supported:' . $propertyId->getSerialization() |
|
411 | + 'Non-numeric property ID not supported:'.$propertyId->getSerialization() |
|
412 | 412 | ); |
413 | 413 | } |
414 | - $constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId ); |
|
415 | - if ( $constraintIds !== null ) { |
|
414 | + $constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId); |
|
415 | + if ($constraintIds !== null) { |
|
416 | 416 | $constraintsToUse = []; |
417 | - foreach ( $constraints as $constraint ) { |
|
418 | - if ( in_array( $constraint->getConstraintId(), $constraintIds ) ) { |
|
417 | + foreach ($constraints as $constraint) { |
|
418 | + if (in_array($constraint->getConstraintId(), $constraintIds)) { |
|
419 | 419 | $constraintsToUse[] = $constraint; |
420 | 420 | } |
421 | 421 | } |
@@ -439,18 +439,18 @@ discard block |
||
439 | 439 | ?array $constraintIds, |
440 | 440 | ?callable $defaultResults |
441 | 441 | ): array { |
442 | - $context = new MainSnakContext( $entity, $statement ); |
|
442 | + $context = new MainSnakContext($entity, $statement); |
|
443 | 443 | $constraints = $this->getConstraintsToUse( |
444 | 444 | $statement->getPropertyId(), |
445 | 445 | $constraintIds |
446 | 446 | ); |
447 | - $result = $defaultResults !== null ? $defaultResults( $context ) : []; |
|
447 | + $result = $defaultResults !== null ? $defaultResults($context) : []; |
|
448 | 448 | |
449 | - foreach ( $constraints as $constraint ) { |
|
449 | + foreach ($constraints as $constraint) { |
|
450 | 450 | $parameters = $constraint->getConstraintParameters(); |
451 | 451 | try { |
452 | - $exceptions = $this->constraintParameterParser->parseExceptionParameter( $parameters ); |
|
453 | - } catch ( ConstraintParameterException $e ) { |
|
452 | + $exceptions = $this->constraintParameterParser->parseExceptionParameter($parameters); |
|
453 | + } catch (ConstraintParameterException $e) { |
|
454 | 454 | $result[] = new CheckResult( |
455 | 455 | $context, |
456 | 456 | $constraint, |
@@ -460,13 +460,13 @@ discard block |
||
460 | 460 | continue; |
461 | 461 | } |
462 | 462 | |
463 | - if ( in_array( $entity->getId(), $exceptions ) ) { |
|
464 | - $message = new ViolationMessage( 'wbqc-violation-message-exception' ); |
|
465 | - $result[] = new CheckResult( $context, $constraint, CheckResult::STATUS_EXCEPTION, $message ); |
|
463 | + if (in_array($entity->getId(), $exceptions)) { |
|
464 | + $message = new ViolationMessage('wbqc-violation-message-exception'); |
|
465 | + $result[] = new CheckResult($context, $constraint, CheckResult::STATUS_EXCEPTION, $message); |
|
466 | 466 | continue; |
467 | 467 | } |
468 | 468 | |
469 | - $result[] = $this->getCheckResultFor( $context, $constraint ); |
|
469 | + $result[] = $this->getCheckResultFor($context, $constraint); |
|
470 | 470 | } |
471 | 471 | |
472 | 472 | return $result; |
@@ -488,24 +488,24 @@ discard block |
||
488 | 488 | ): array { |
489 | 489 | $result = []; |
490 | 490 | |
491 | - if ( in_array( |
|
491 | + if (in_array( |
|
492 | 492 | $statement->getPropertyId()->getSerialization(), |
493 | 493 | $this->propertiesWithViolatingQualifiers |
494 | - ) ) { |
|
494 | + )) { |
|
495 | 495 | return $result; |
496 | 496 | } |
497 | 497 | |
498 | - foreach ( $statement->getQualifiers() as $qualifier ) { |
|
499 | - $qualifierContext = new QualifierContext( $entity, $statement, $qualifier ); |
|
500 | - if ( $defaultResultsPerContext !== null ) { |
|
501 | - $result = array_merge( $result, $defaultResultsPerContext( $qualifierContext ) ); |
|
498 | + foreach ($statement->getQualifiers() as $qualifier) { |
|
499 | + $qualifierContext = new QualifierContext($entity, $statement, $qualifier); |
|
500 | + if ($defaultResultsPerContext !== null) { |
|
501 | + $result = array_merge($result, $defaultResultsPerContext($qualifierContext)); |
|
502 | 502 | } |
503 | 503 | $qualifierConstraints = $this->getConstraintsToUse( |
504 | 504 | $qualifierContext->getSnak()->getPropertyId(), |
505 | 505 | $constraintIds |
506 | 506 | ); |
507 | - foreach ( $qualifierConstraints as $qualifierConstraint ) { |
|
508 | - $result[] = $this->getCheckResultFor( $qualifierContext, $qualifierConstraint ); |
|
507 | + foreach ($qualifierConstraints as $qualifierConstraint) { |
|
508 | + $result[] = $this->getCheckResultFor($qualifierContext, $qualifierConstraint); |
|
509 | 509 | } |
510 | 510 | } |
511 | 511 | |
@@ -529,19 +529,19 @@ discard block |
||
529 | 529 | $result = []; |
530 | 530 | |
531 | 531 | /** @var Reference $reference */ |
532 | - foreach ( $statement->getReferences() as $reference ) { |
|
533 | - foreach ( $reference->getSnaks() as $snak ) { |
|
532 | + foreach ($statement->getReferences() as $reference) { |
|
533 | + foreach ($reference->getSnaks() as $snak) { |
|
534 | 534 | $referenceContext = new ReferenceContext( |
535 | 535 | $entity, $statement, $reference, $snak |
536 | 536 | ); |
537 | - if ( $defaultResultsPerContext !== null ) { |
|
538 | - $result = array_merge( $result, $defaultResultsPerContext( $referenceContext ) ); |
|
537 | + if ($defaultResultsPerContext !== null) { |
|
538 | + $result = array_merge($result, $defaultResultsPerContext($referenceContext)); |
|
539 | 539 | } |
540 | 540 | $referenceConstraints = $this->getConstraintsToUse( |
541 | 541 | $referenceContext->getSnak()->getPropertyId(), |
542 | 542 | $constraintIds |
543 | 543 | ); |
544 | - foreach ( $referenceConstraints as $referenceConstraint ) { |
|
544 | + foreach ($referenceConstraints as $referenceConstraint) { |
|
545 | 545 | $result[] = $this->getCheckResultFor( |
546 | 546 | $referenceContext, |
547 | 547 | $referenceConstraint |
@@ -553,50 +553,50 @@ discard block |
||
553 | 553 | return $result; |
554 | 554 | } |
555 | 555 | |
556 | - private function getCheckResultFor( Context $context, Constraint $constraint ): CheckResult { |
|
557 | - if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
556 | + private function getCheckResultFor(Context $context, Constraint $constraint): CheckResult { |
|
557 | + if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
558 | 558 | $checker = $this->checkerMap[$constraint->getConstraintTypeItemId()]; |
559 | - $result = $this->handleScope( $checker, $context, $constraint ); |
|
559 | + $result = $this->handleScope($checker, $context, $constraint); |
|
560 | 560 | |
561 | - if ( $result !== null ) { |
|
562 | - $this->addMetadata( $context, $result ); |
|
561 | + if ($result !== null) { |
|
562 | + $this->addMetadata($context, $result); |
|
563 | 563 | return $result; |
564 | 564 | } |
565 | 565 | |
566 | - $startTime = microtime( true ); |
|
566 | + $startTime = microtime(true); |
|
567 | 567 | try { |
568 | - $result = $checker->checkConstraint( $context, $constraint ); |
|
569 | - } catch ( ConstraintParameterException $e ) { |
|
568 | + $result = $checker->checkConstraint($context, $constraint); |
|
569 | + } catch (ConstraintParameterException $e) { |
|
570 | 570 | $result = new CheckResult( |
571 | 571 | $context, |
572 | 572 | $constraint, |
573 | 573 | CheckResult::STATUS_BAD_PARAMETERS, |
574 | 574 | $e->getViolationMessage() |
575 | 575 | ); |
576 | - } catch ( SparqlHelperException $e ) { |
|
577 | - $message = new ViolationMessage( 'wbqc-violation-message-sparql-error' ); |
|
578 | - $result = new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, $message ); |
|
576 | + } catch (SparqlHelperException $e) { |
|
577 | + $message = new ViolationMessage('wbqc-violation-message-sparql-error'); |
|
578 | + $result = new CheckResult($context, $constraint, CheckResult::STATUS_TODO, $message); |
|
579 | 579 | } |
580 | - $endTime = microtime( true ); |
|
580 | + $endTime = microtime(true); |
|
581 | 581 | |
582 | - $this->addMetadata( $context, $result ); |
|
582 | + $this->addMetadata($context, $result); |
|
583 | 583 | |
584 | - $this->addConstraintClarification( $result ); |
|
584 | + $this->addConstraintClarification($result); |
|
585 | 585 | |
586 | - $this->downgradeResultStatus( $result ); |
|
586 | + $this->downgradeResultStatus($result); |
|
587 | 587 | |
588 | 588 | $this->loggingHelper->logConstraintCheck( |
589 | 589 | $context, |
590 | 590 | $constraint, |
591 | 591 | $result, |
592 | - get_class( $checker ), |
|
592 | + get_class($checker), |
|
593 | 593 | $endTime - $startTime, |
594 | 594 | __METHOD__ |
595 | 595 | ); |
596 | 596 | |
597 | 597 | return $result; |
598 | 598 | } else { |
599 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null ); |
|
599 | + return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null); |
|
600 | 600 | } |
601 | 601 | } |
602 | 602 | |
@@ -605,91 +605,91 @@ discard block |
||
605 | 605 | Context $context, |
606 | 606 | Constraint $constraint |
607 | 607 | ): ?CheckResult { |
608 | - $validContextTypes = $this->getValidContextTypes( $constraint ); |
|
609 | - $validEntityTypes = $this->getValidEntityTypes( $constraint ); |
|
608 | + $validContextTypes = $this->getValidContextTypes($constraint); |
|
609 | + $validEntityTypes = $this->getValidEntityTypes($constraint); |
|
610 | 610 | try { |
611 | - [ $checkedContextTypes, $checkedEntityTypes ] = $this->constraintParameterParser->parseConstraintScopeParameters( |
|
611 | + [$checkedContextTypes, $checkedEntityTypes] = $this->constraintParameterParser->parseConstraintScopeParameters( |
|
612 | 612 | $constraint->getConstraintParameters(), |
613 | 613 | $constraint->getConstraintTypeItemId(), |
614 | 614 | $validContextTypes, |
615 | 615 | $validEntityTypes |
616 | 616 | ); |
617 | - } catch ( ConstraintParameterException $e ) { |
|
618 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() ); |
|
617 | + } catch (ConstraintParameterException $e) { |
|
618 | + return new CheckResult($context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage()); |
|
619 | 619 | } |
620 | 620 | |
621 | - if ( $checkedContextTypes === null ) { |
|
621 | + if ($checkedContextTypes === null) { |
|
622 | 622 | $checkedContextTypes = $checker->getDefaultContextTypes(); |
623 | 623 | } |
624 | 624 | $contextType = $context->getType(); |
625 | - if ( !in_array( $contextType, $checkedContextTypes ) ) { |
|
626 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null ); |
|
625 | + if (!in_array($contextType, $checkedContextTypes)) { |
|
626 | + return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null); |
|
627 | 627 | } |
628 | - if ( $checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO ) { |
|
629 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null ); |
|
628 | + if ($checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO) { |
|
629 | + return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null); |
|
630 | 630 | } |
631 | 631 | |
632 | - if ( $checkedEntityTypes === null ) { |
|
632 | + if ($checkedEntityTypes === null) { |
|
633 | 633 | $checkedEntityTypes = $validEntityTypes; |
634 | 634 | } |
635 | 635 | $entityType = $context->getEntity()->getType(); |
636 | - if ( !in_array( $entityType, $checkedEntityTypes ) ) { |
|
637 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null ); |
|
636 | + if (!in_array($entityType, $checkedEntityTypes)) { |
|
637 | + return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null); |
|
638 | 638 | } |
639 | - if ( $checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO ) { |
|
640 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null ); |
|
639 | + if ($checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO) { |
|
640 | + return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null); |
|
641 | 641 | } |
642 | 642 | |
643 | 643 | return null; |
644 | 644 | } |
645 | 645 | |
646 | - private function addMetadata( Context $context, CheckResult $result ): void { |
|
647 | - $result->withMetadata( Metadata::merge( [ |
|
646 | + private function addMetadata(Context $context, CheckResult $result): void { |
|
647 | + $result->withMetadata(Metadata::merge([ |
|
648 | 648 | $result->getMetadata(), |
649 | - Metadata::ofDependencyMetadata( DependencyMetadata::merge( [ |
|
650 | - DependencyMetadata::ofEntityId( $context->getEntity()->getId() ), |
|
651 | - DependencyMetadata::ofEntityId( $result->getConstraint()->getPropertyId() ), |
|
652 | - ] ) ), |
|
653 | - ] ) ); |
|
649 | + Metadata::ofDependencyMetadata(DependencyMetadata::merge([ |
|
650 | + DependencyMetadata::ofEntityId($context->getEntity()->getId()), |
|
651 | + DependencyMetadata::ofEntityId($result->getConstraint()->getPropertyId()), |
|
652 | + ])), |
|
653 | + ])); |
|
654 | 654 | } |
655 | 655 | |
656 | - private function addConstraintClarification( CheckResult $result ): void { |
|
656 | + private function addConstraintClarification(CheckResult $result): void { |
|
657 | 657 | $constraint = $result->getConstraint(); |
658 | 658 | try { |
659 | 659 | $constraintClarification = $this->constraintParameterParser |
660 | - ->parseConstraintClarificationParameter( $constraint->getConstraintParameters() ); |
|
661 | - $result->setConstraintClarification( $constraintClarification ); |
|
662 | - } catch ( ConstraintParameterException $e ) { |
|
663 | - $result->setStatus( CheckResult::STATUS_BAD_PARAMETERS ); |
|
664 | - $result->setMessage( $e->getViolationMessage() ); |
|
660 | + ->parseConstraintClarificationParameter($constraint->getConstraintParameters()); |
|
661 | + $result->setConstraintClarification($constraintClarification); |
|
662 | + } catch (ConstraintParameterException $e) { |
|
663 | + $result->setStatus(CheckResult::STATUS_BAD_PARAMETERS); |
|
664 | + $result->setMessage($e->getViolationMessage()); |
|
665 | 665 | } |
666 | 666 | } |
667 | 667 | |
668 | - private function downgradeResultStatus( CheckResult $result ): void { |
|
668 | + private function downgradeResultStatus(CheckResult $result): void { |
|
669 | 669 | $constraint = $result->getConstraint(); |
670 | 670 | try { |
671 | 671 | $constraintStatus = $this->constraintParameterParser |
672 | - ->parseConstraintStatusParameter( $constraint->getConstraintParameters() ); |
|
673 | - } catch ( ConstraintParameterException $e ) { |
|
674 | - $result->setStatus( CheckResult::STATUS_BAD_PARAMETERS ); |
|
675 | - $result->setMessage( $e->getViolationMessage() ); |
|
672 | + ->parseConstraintStatusParameter($constraint->getConstraintParameters()); |
|
673 | + } catch (ConstraintParameterException $e) { |
|
674 | + $result->setStatus(CheckResult::STATUS_BAD_PARAMETERS); |
|
675 | + $result->setMessage($e->getViolationMessage()); |
|
676 | 676 | return; |
677 | 677 | } |
678 | - if ( $constraintStatus === null ) { |
|
678 | + if ($constraintStatus === null) { |
|
679 | 679 | // downgrade violation to warning |
680 | - if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) { |
|
681 | - $result->setStatus( CheckResult::STATUS_WARNING ); |
|
680 | + if ($result->getStatus() === CheckResult::STATUS_VIOLATION) { |
|
681 | + $result->setStatus(CheckResult::STATUS_WARNING); |
|
682 | 682 | } |
683 | - } elseif ( $constraintStatus === 'suggestion' ) { |
|
683 | + } elseif ($constraintStatus === 'suggestion') { |
|
684 | 684 | // downgrade violation to suggestion |
685 | - if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) { |
|
686 | - $result->setStatus( CheckResult::STATUS_SUGGESTION ); |
|
685 | + if ($result->getStatus() === CheckResult::STATUS_VIOLATION) { |
|
686 | + $result->setStatus(CheckResult::STATUS_SUGGESTION); |
|
687 | 687 | } |
688 | 688 | } else { |
689 | - if ( $constraintStatus !== 'mandatory' ) { |
|
689 | + if ($constraintStatus !== 'mandatory') { |
|
690 | 690 | // @codeCoverageIgnoreStart |
691 | 691 | throw new LogicException( |
692 | - "Unknown constraint status '$constraintStatus', " . |
|
692 | + "Unknown constraint status '$constraintStatus', ". |
|
693 | 693 | "only known statuses are 'mandatory' and 'suggestion'" |
694 | 694 | ); |
695 | 695 | // @codeCoverageIgnoreEnd |
@@ -702,12 +702,12 @@ discard block |
||
702 | 702 | * |
703 | 703 | * @return CheckResult[] |
704 | 704 | */ |
705 | - private function sortResult( array $result ): array { |
|
706 | - if ( count( $result ) < 2 ) { |
|
705 | + private function sortResult(array $result): array { |
|
706 | + if (count($result) < 2) { |
|
707 | 707 | return $result; |
708 | 708 | } |
709 | 709 | |
710 | - $sortFunction = static function ( CheckResult $a, CheckResult $b ) { |
|
710 | + $sortFunction = static function(CheckResult $a, CheckResult $b) { |
|
711 | 711 | $orderNum = 0; |
712 | 712 | $order = [ |
713 | 713 | CheckResult::STATUS_BAD_PARAMETERS => $orderNum++, |
@@ -724,55 +724,55 @@ discard block |
||
724 | 724 | $statusA = $a->getStatus(); |
725 | 725 | $statusB = $b->getStatus(); |
726 | 726 | |
727 | - $orderA = array_key_exists( $statusA, $order ) ? $order[ $statusA ] : $order[ 'other' ]; |
|
728 | - $orderB = array_key_exists( $statusB, $order ) ? $order[ $statusB ] : $order[ 'other' ]; |
|
727 | + $orderA = array_key_exists($statusA, $order) ? $order[$statusA] : $order['other']; |
|
728 | + $orderB = array_key_exists($statusB, $order) ? $order[$statusB] : $order['other']; |
|
729 | 729 | |
730 | - if ( $orderA === $orderB ) { |
|
730 | + if ($orderA === $orderB) { |
|
731 | 731 | $cursorA = $a->getContextCursor(); |
732 | 732 | $cursorB = $b->getContextCursor(); |
733 | 733 | |
734 | - if ( $cursorA instanceof EntityContextCursor ) { |
|
734 | + if ($cursorA instanceof EntityContextCursor) { |
|
735 | 735 | return $cursorB instanceof EntityContextCursor ? 0 : -1; |
736 | 736 | } |
737 | - if ( $cursorB instanceof EntityContextCursor ) { |
|
737 | + if ($cursorB instanceof EntityContextCursor) { |
|
738 | 738 | return $cursorA instanceof EntityContextCursor ? 0 : 1; |
739 | 739 | } |
740 | 740 | |
741 | 741 | $pidA = $cursorA->getSnakPropertyId(); |
742 | 742 | $pidB = $cursorB->getSnakPropertyId(); |
743 | 743 | |
744 | - if ( $pidA === $pidB ) { |
|
744 | + if ($pidA === $pidB) { |
|
745 | 745 | $hashA = $cursorA->getSnakHash(); |
746 | 746 | $hashB = $cursorB->getSnakHash(); |
747 | 747 | |
748 | - if ( $hashA === $hashB ) { |
|
749 | - if ( $a instanceof NullResult ) { |
|
748 | + if ($hashA === $hashB) { |
|
749 | + if ($a instanceof NullResult) { |
|
750 | 750 | return $b instanceof NullResult ? 0 : -1; |
751 | 751 | } |
752 | - if ( $b instanceof NullResult ) { |
|
752 | + if ($b instanceof NullResult) { |
|
753 | 753 | return $a instanceof NullResult ? 0 : 1; |
754 | 754 | } |
755 | 755 | |
756 | 756 | $typeA = $a->getConstraint()->getConstraintTypeItemId(); |
757 | 757 | $typeB = $b->getConstraint()->getConstraintTypeItemId(); |
758 | 758 | |
759 | - if ( $typeA == $typeB ) { |
|
759 | + if ($typeA == $typeB) { |
|
760 | 760 | return 0; |
761 | 761 | } else { |
762 | - return ( $typeA > $typeB ) ? 1 : -1; |
|
762 | + return ($typeA > $typeB) ? 1 : -1; |
|
763 | 763 | } |
764 | 764 | } else { |
765 | - return ( $hashA > $hashB ) ? 1 : -1; |
|
765 | + return ($hashA > $hashB) ? 1 : -1; |
|
766 | 766 | } |
767 | 767 | } else { |
768 | - return ( $pidA > $pidB ) ? 1 : -1; |
|
768 | + return ($pidA > $pidB) ? 1 : -1; |
|
769 | 769 | } |
770 | 770 | } else { |
771 | - return ( $orderA > $orderB ) ? 1 : -1; |
|
771 | + return ($orderA > $orderB) ? 1 : -1; |
|
772 | 772 | } |
773 | 773 | }; |
774 | 774 | |
775 | - uasort( $result, $sortFunction ); |
|
775 | + uasort($result, $sortFunction); |
|
776 | 776 | |
777 | 777 | return $result; |
778 | 778 | } |
@@ -200,73 +200,73 @@ discard block |
||
200 | 200 | $this->defaultUserAgent = $defaultUserAgent; |
201 | 201 | $this->requestFactory = $requestFactory; |
202 | 202 | $this->entityPrefixes = []; |
203 | - foreach ( $rdfVocabulary->entityNamespaceNames as $namespaceName ) { |
|
204 | - $this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI( $namespaceName ); |
|
203 | + foreach ($rdfVocabulary->entityNamespaceNames as $namespaceName) { |
|
204 | + $this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI($namespaceName); |
|
205 | 205 | } |
206 | 206 | |
207 | - $this->endpoint = $config->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
208 | - $this->maxQueryTimeMillis = $config->get( 'WBQualityConstraintsSparqlMaxMillis' ); |
|
209 | - $this->instanceOfId = $config->get( 'WBQualityConstraintsInstanceOfId' ); |
|
210 | - $this->subclassOfId = $config->get( 'WBQualityConstraintsSubclassOfId' ); |
|
211 | - $this->cacheMapSize = $config->get( 'WBQualityConstraintsFormatCacheMapSize' ); |
|
207 | + $this->endpoint = $config->get('WBQualityConstraintsSparqlEndpoint'); |
|
208 | + $this->maxQueryTimeMillis = $config->get('WBQualityConstraintsSparqlMaxMillis'); |
|
209 | + $this->instanceOfId = $config->get('WBQualityConstraintsInstanceOfId'); |
|
210 | + $this->subclassOfId = $config->get('WBQualityConstraintsSubclassOfId'); |
|
211 | + $this->cacheMapSize = $config->get('WBQualityConstraintsFormatCacheMapSize'); |
|
212 | 212 | $this->timeoutExceptionClasses = $config->get( |
213 | 213 | 'WBQualityConstraintsSparqlTimeoutExceptionClasses' |
214 | 214 | ); |
215 | 215 | $this->sparqlHasWikibaseSupport = $config->get( |
216 | 216 | 'WBQualityConstraintsSparqlHasWikibaseSupport' |
217 | 217 | ); |
218 | - $this->sparqlThrottlingFallbackDuration = (int)$config->get( |
|
218 | + $this->sparqlThrottlingFallbackDuration = (int) $config->get( |
|
219 | 219 | 'WBQualityConstraintsSparqlThrottlingFallbackDuration' |
220 | 220 | ); |
221 | 221 | |
222 | - $this->prefixes = $this->getQueryPrefixes( $rdfVocabulary ); |
|
222 | + $this->prefixes = $this->getQueryPrefixes($rdfVocabulary); |
|
223 | 223 | } |
224 | 224 | |
225 | - private function getQueryPrefixes( RdfVocabulary $rdfVocabulary ) { |
|
225 | + private function getQueryPrefixes(RdfVocabulary $rdfVocabulary) { |
|
226 | 226 | // TODO: it would probably be smarter that RdfVocubulary exposed these prefixes somehow |
227 | 227 | $prefixes = ''; |
228 | - foreach ( $rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName ) { |
|
228 | + foreach ($rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName) { |
|
229 | 229 | $prefixes .= <<<END |
230 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
230 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
231 | 231 | END; |
232 | 232 | } |
233 | 233 | $prefixes .= <<<END |
234 | -PREFIX wds: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_STATEMENT )}> |
|
235 | -PREFIX wdv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_VALUE )}>\n |
|
234 | +PREFIX wds: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_STATEMENT)}> |
|
235 | +PREFIX wdv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_VALUE)}>\n |
|
236 | 236 | END; |
237 | 237 | |
238 | - foreach ( $rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces ) { |
|
238 | + foreach ($rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces) { |
|
239 | 239 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_DIRECT_CLAIM]; |
240 | 240 | $prefixes .= <<<END |
241 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
241 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
242 | 242 | END; |
243 | 243 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM]; |
244 | 244 | $prefixes .= <<<END |
245 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
245 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
246 | 246 | END; |
247 | 247 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_STATEMENT]; |
248 | 248 | $prefixes .= <<<END |
249 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
249 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
250 | 250 | END; |
251 | 251 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER]; |
252 | 252 | $prefixes .= <<<END |
253 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
253 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
254 | 254 | END; |
255 | 255 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER_VALUE]; |
256 | 256 | $prefixes .= <<<END |
257 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
257 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
258 | 258 | END; |
259 | 259 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE]; |
260 | 260 | $prefixes .= <<<END |
261 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
261 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
262 | 262 | END; |
263 | 263 | $namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE_VALUE]; |
264 | 264 | $prefixes .= <<<END |
265 | -PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n |
|
265 | +PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n |
|
266 | 266 | END; |
267 | 267 | } |
268 | 268 | $prefixes .= <<<END |
269 | -PREFIX wikibase: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ONTOLOGY )}>\n |
|
269 | +PREFIX wikibase: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ONTOLOGY)}>\n |
|
270 | 270 | END; |
271 | 271 | return $prefixes; |
272 | 272 | } |
@@ -278,21 +278,20 @@ discard block |
||
278 | 278 | * @return CachedBool |
279 | 279 | * @throws SparqlHelperException if the query times out or some other error occurs |
280 | 280 | */ |
281 | - public function hasType( $id, array $classes ) { |
|
281 | + public function hasType($id, array $classes) { |
|
282 | 282 | // TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually |
283 | 283 | $gearingHint = $this->sparqlHasWikibaseSupport ? |
284 | - ' hint:Prior hint:gearing "forward".' : |
|
285 | - ''; |
|
284 | + ' hint:Prior hint:gearing "forward".' : ''; |
|
286 | 285 | |
287 | 286 | $metadatas = []; |
288 | 287 | |
289 | - foreach ( array_chunk( $classes, 20 ) as $classesChunk ) { |
|
290 | - $classesValues = implode( ' ', array_map( |
|
291 | - static function ( $class ) { |
|
292 | - return 'wd:' . $class; |
|
288 | + foreach (array_chunk($classes, 20) as $classesChunk) { |
|
289 | + $classesValues = implode(' ', array_map( |
|
290 | + static function($class) { |
|
291 | + return 'wd:'.$class; |
|
293 | 292 | }, |
294 | 293 | $classesChunk |
295 | - ) ); |
|
294 | + )); |
|
296 | 295 | |
297 | 296 | $query = <<<EOF |
298 | 297 | ASK { |
@@ -302,19 +301,19 @@ discard block |
||
302 | 301 | } |
303 | 302 | EOF; |
304 | 303 | |
305 | - $result = $this->runQuery( $query ); |
|
304 | + $result = $this->runQuery($query); |
|
306 | 305 | $metadatas[] = $result->getMetadata(); |
307 | - if ( $result->getArray()['boolean'] ) { |
|
306 | + if ($result->getArray()['boolean']) { |
|
308 | 307 | return new CachedBool( |
309 | 308 | true, |
310 | - Metadata::merge( $metadatas ) |
|
309 | + Metadata::merge($metadatas) |
|
311 | 310 | ); |
312 | 311 | } |
313 | 312 | } |
314 | 313 | |
315 | 314 | return new CachedBool( |
316 | 315 | false, |
317 | - Metadata::merge( $metadatas ) |
|
316 | + Metadata::merge($metadatas) |
|
318 | 317 | ); |
319 | 318 | } |
320 | 319 | |
@@ -325,7 +324,7 @@ discard block |
||
325 | 324 | * @param PropertyId $separator |
326 | 325 | * @return string |
327 | 326 | */ |
328 | - private function nestedSeparatorFilter( PropertyId $separator ) { |
|
327 | + private function nestedSeparatorFilter(PropertyId $separator) { |
|
329 | 328 | $filter = <<<EOF |
330 | 329 | MINUS { |
331 | 330 | ?statement pq:$separator ?qualifier. |
@@ -369,10 +368,10 @@ discard block |
||
369 | 368 | $pid = $statement->getPropertyId()->getSerialization(); |
370 | 369 | $guid = $statement->getGuid(); |
371 | 370 | '@phan-var string $guid'; // statement must have a non-null GUID |
372 | - $guidForRdf = str_replace( '$', '-', $guid ); |
|
371 | + $guidForRdf = str_replace('$', '-', $guid); |
|
373 | 372 | |
374 | - $separatorFilters = array_map( [ $this, 'nestedSeparatorFilter' ], $separators ); |
|
375 | - $finalSeparatorFilter = implode( "\n", $separatorFilters ); |
|
373 | + $separatorFilters = array_map([$this, 'nestedSeparatorFilter'], $separators); |
|
374 | + $finalSeparatorFilter = implode("\n", $separatorFilters); |
|
376 | 375 | |
377 | 376 | $query = <<<EOF |
378 | 377 | SELECT DISTINCT ?otherEntity WHERE { |
@@ -390,9 +389,9 @@ discard block |
||
390 | 389 | LIMIT 10 |
391 | 390 | EOF; |
392 | 391 | |
393 | - $result = $this->runQuery( $query ); |
|
392 | + $result = $this->runQuery($query); |
|
394 | 393 | |
395 | - return $this->getOtherEntities( $result ); |
|
394 | + return $this->getOtherEntities($result); |
|
396 | 395 | } |
397 | 396 | |
398 | 397 | /** |
@@ -417,16 +416,15 @@ discard block |
||
417 | 416 | $dataType = $this->propertyDataTypeLookup->getDataTypeIdForProperty( |
418 | 417 | $snak->getPropertyId() |
419 | 418 | ); |
420 | - list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType, $dataValue ); |
|
421 | - if ( $isFullValue ) { |
|
419 | + list($value, $isFullValue) = $this->getRdfLiteral($dataType, $dataValue); |
|
420 | + if ($isFullValue) { |
|
422 | 421 | $prefix .= 'v'; |
423 | 422 | } |
424 | 423 | $path = $type === Context::TYPE_QUALIFIER ? |
425 | - "$prefix:$pid" : |
|
426 | - "prov:wasDerivedFrom/$prefix:$pid"; |
|
424 | + "$prefix:$pid" : "prov:wasDerivedFrom/$prefix:$pid"; |
|
427 | 425 | |
428 | 426 | $deprecatedFilter = ''; |
429 | - if ( $ignoreDeprecatedStatements ) { |
|
427 | + if ($ignoreDeprecatedStatements) { |
|
430 | 428 | $deprecatedFilter = <<< EOF |
431 | 429 | MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. } |
432 | 430 | EOF; |
@@ -446,9 +444,9 @@ discard block |
||
446 | 444 | LIMIT 10 |
447 | 445 | EOF; |
448 | 446 | |
449 | - $result = $this->runQuery( $query ); |
|
447 | + $result = $this->runQuery($query); |
|
450 | 448 | |
451 | - return $this->getOtherEntities( $result ); |
|
449 | + return $this->getOtherEntities($result); |
|
452 | 450 | } |
453 | 451 | |
454 | 452 | /** |
@@ -458,8 +456,8 @@ discard block |
||
458 | 456 | * |
459 | 457 | * @return string |
460 | 458 | */ |
461 | - private function stringLiteral( $text ) { |
|
462 | - return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"'; |
|
459 | + private function stringLiteral($text) { |
|
460 | + return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"'; |
|
463 | 461 | } |
464 | 462 | |
465 | 463 | /** |
@@ -469,18 +467,18 @@ discard block |
||
469 | 467 | * |
470 | 468 | * @return CachedEntityIds |
471 | 469 | */ |
472 | - private function getOtherEntities( CachedQueryResults $results ) { |
|
473 | - return new CachedEntityIds( array_map( |
|
474 | - function ( $resultBindings ) { |
|
470 | + private function getOtherEntities(CachedQueryResults $results) { |
|
471 | + return new CachedEntityIds(array_map( |
|
472 | + function($resultBindings) { |
|
475 | 473 | $entityIRI = $resultBindings['otherEntity']['value']; |
476 | - foreach ( $this->entityPrefixes as $entityPrefix ) { |
|
477 | - $entityPrefixLength = strlen( $entityPrefix ); |
|
478 | - if ( substr( $entityIRI, 0, $entityPrefixLength ) === $entityPrefix ) { |
|
474 | + foreach ($this->entityPrefixes as $entityPrefix) { |
|
475 | + $entityPrefixLength = strlen($entityPrefix); |
|
476 | + if (substr($entityIRI, 0, $entityPrefixLength) === $entityPrefix) { |
|
479 | 477 | try { |
480 | 478 | return $this->entityIdParser->parse( |
481 | - substr( $entityIRI, $entityPrefixLength ) |
|
479 | + substr($entityIRI, $entityPrefixLength) |
|
482 | 480 | ); |
483 | - } catch ( EntityIdParsingException $e ) { |
|
481 | + } catch (EntityIdParsingException $e) { |
|
484 | 482 | // fall through |
485 | 483 | } |
486 | 484 | } |
@@ -491,7 +489,7 @@ discard block |
||
491 | 489 | return null; |
492 | 490 | }, |
493 | 491 | $results->getArray()['results']['bindings'] |
494 | - ), $results->getMetadata() ); |
|
492 | + ), $results->getMetadata()); |
|
495 | 493 | } |
496 | 494 | |
497 | 495 | // phpcs:disable Generic.Metrics.CyclomaticComplexity,Squiz.WhiteSpace.FunctionSpacing |
@@ -504,50 +502,50 @@ discard block |
||
504 | 502 | * @return array the literal or IRI as a string in SPARQL syntax, |
505 | 503 | * and a boolean indicating whether it refers to a full value node or not |
506 | 504 | */ |
507 | - private function getRdfLiteral( $dataType, DataValue $dataValue ) { |
|
508 | - switch ( $dataType ) { |
|
505 | + private function getRdfLiteral($dataType, DataValue $dataValue) { |
|
506 | + switch ($dataType) { |
|
509 | 507 | case 'string': |
510 | 508 | case 'external-id': |
511 | - return [ $this->stringLiteral( $dataValue->getValue() ), false ]; |
|
509 | + return [$this->stringLiteral($dataValue->getValue()), false]; |
|
512 | 510 | case 'commonsMedia': |
513 | - $url = $this->rdfVocabulary->getMediaFileURI( $dataValue->getValue() ); |
|
514 | - return [ '<' . $url . '>', false ]; |
|
511 | + $url = $this->rdfVocabulary->getMediaFileURI($dataValue->getValue()); |
|
512 | + return ['<'.$url.'>', false]; |
|
515 | 513 | case 'geo-shape': |
516 | - $url = $this->rdfVocabulary->getGeoShapeURI( $dataValue->getValue() ); |
|
517 | - return [ '<' . $url . '>', false ]; |
|
514 | + $url = $this->rdfVocabulary->getGeoShapeURI($dataValue->getValue()); |
|
515 | + return ['<'.$url.'>', false]; |
|
518 | 516 | case 'tabular-data': |
519 | - $url = $this->rdfVocabulary->getTabularDataURI( $dataValue->getValue() ); |
|
520 | - return [ '<' . $url . '>', false ]; |
|
517 | + $url = $this->rdfVocabulary->getTabularDataURI($dataValue->getValue()); |
|
518 | + return ['<'.$url.'>', false]; |
|
521 | 519 | case 'url': |
522 | 520 | $url = $dataValue->getValue(); |
523 | - if ( !preg_match( '/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url ) ) { |
|
521 | + if (!preg_match('/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url)) { |
|
524 | 522 | // not a valid URL for SPARQL (see SPARQL spec, production 139 IRIREF) |
525 | 523 | // such an URL should never reach us, so just throw |
526 | - throw new InvalidArgumentException( 'invalid URL: ' . $url ); |
|
524 | + throw new InvalidArgumentException('invalid URL: '.$url); |
|
527 | 525 | } |
528 | - return [ '<' . $url . '>', false ]; |
|
526 | + return ['<'.$url.'>', false]; |
|
529 | 527 | case 'wikibase-item': |
530 | 528 | case 'wikibase-property': |
531 | 529 | /** @var EntityIdValue $dataValue */ |
532 | 530 | '@phan-var EntityIdValue $dataValue'; |
533 | - return [ 'wd:' . $dataValue->getEntityId()->getSerialization(), false ]; |
|
531 | + return ['wd:'.$dataValue->getEntityId()->getSerialization(), false]; |
|
534 | 532 | case 'monolingualtext': |
535 | 533 | /** @var MonolingualTextValue $dataValue */ |
536 | 534 | '@phan-var MonolingualTextValue $dataValue'; |
537 | 535 | $lang = $dataValue->getLanguageCode(); |
538 | - if ( !preg_match( '/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang ) ) { |
|
536 | + if (!preg_match('/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang)) { |
|
539 | 537 | // not a valid language tag for SPARQL (see SPARQL spec, production 145 LANGTAG) |
540 | 538 | // such a language tag should never reach us, so just throw |
541 | - throw new InvalidArgumentException( 'invalid language tag: ' . $lang ); |
|
539 | + throw new InvalidArgumentException('invalid language tag: '.$lang); |
|
542 | 540 | } |
543 | - return [ $this->stringLiteral( $dataValue->getText() ) . '@' . $lang, false ]; |
|
541 | + return [$this->stringLiteral($dataValue->getText()).'@'.$lang, false]; |
|
544 | 542 | case 'globe-coordinate': |
545 | 543 | case 'quantity': |
546 | 544 | case 'time': |
547 | 545 | // @phan-suppress-next-line PhanUndeclaredMethod |
548 | - return [ 'wdv:' . $dataValue->getHash(), true ]; |
|
546 | + return ['wdv:'.$dataValue->getHash(), true]; |
|
549 | 547 | default: |
550 | - throw new InvalidArgumentException( 'unknown data type: ' . $dataType ); |
|
548 | + throw new InvalidArgumentException('unknown data type: '.$dataType); |
|
551 | 549 | } |
552 | 550 | } |
553 | 551 | // phpcs:enable |
@@ -560,43 +558,43 @@ discard block |
||
560 | 558 | * @throws SparqlHelperException if the query times out or some other error occurs |
561 | 559 | * @throws ConstraintParameterException if the $regex is invalid |
562 | 560 | */ |
563 | - public function matchesRegularExpression( $text, $regex ) { |
|
561 | + public function matchesRegularExpression($text, $regex) { |
|
564 | 562 | // caching wrapper around matchesRegularExpressionWithSparql |
565 | 563 | |
566 | - $textHash = hash( 'sha256', $text ); |
|
564 | + $textHash = hash('sha256', $text); |
|
567 | 565 | $cacheKey = $this->cache->makeKey( |
568 | 566 | 'WikibaseQualityConstraints', // extension |
569 | 567 | 'regex', // action |
570 | 568 | 'WDQS-Java', // regex flavor |
571 | - hash( 'sha256', $regex ) |
|
569 | + hash('sha256', $regex) |
|
572 | 570 | ); |
573 | 571 | |
574 | 572 | $cacheMapArray = $this->cache->getWithSetCallback( |
575 | 573 | $cacheKey, |
576 | 574 | WANObjectCache::TTL_DAY, |
577 | - function ( $cacheMapArray ) use ( $text, $regex, $textHash ) { |
|
575 | + function($cacheMapArray) use ($text, $regex, $textHash) { |
|
578 | 576 | // Initialize the cache map if not set |
579 | - if ( $cacheMapArray === false ) { |
|
577 | + if ($cacheMapArray === false) { |
|
580 | 578 | $key = 'wikibase.quality.constraints.regex.cache.refresh.init'; |
581 | - $this->dataFactory->increment( $key ); |
|
579 | + $this->dataFactory->increment($key); |
|
582 | 580 | return []; |
583 | 581 | } |
584 | 582 | |
585 | 583 | $key = 'wikibase.quality.constraints.regex.cache.refresh'; |
586 | - $this->dataFactory->increment( $key ); |
|
587 | - $cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $this->cacheMapSize ); |
|
588 | - if ( $cacheMap->has( $textHash ) ) { |
|
584 | + $this->dataFactory->increment($key); |
|
585 | + $cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $this->cacheMapSize); |
|
586 | + if ($cacheMap->has($textHash)) { |
|
589 | 587 | $key = 'wikibase.quality.constraints.regex.cache.refresh.hit'; |
590 | - $this->dataFactory->increment( $key ); |
|
591 | - $cacheMap->get( $textHash ); // ping cache |
|
588 | + $this->dataFactory->increment($key); |
|
589 | + $cacheMap->get($textHash); // ping cache |
|
592 | 590 | } else { |
593 | 591 | $key = 'wikibase.quality.constraints.regex.cache.refresh.miss'; |
594 | - $this->dataFactory->increment( $key ); |
|
592 | + $this->dataFactory->increment($key); |
|
595 | 593 | try { |
596 | - $matches = $this->matchesRegularExpressionWithSparql( $text, $regex ); |
|
597 | - } catch ( ConstraintParameterException $e ) { |
|
598 | - $matches = $this->serializeConstraintParameterException( $e ); |
|
599 | - } catch ( SparqlHelperException $e ) { |
|
594 | + $matches = $this->matchesRegularExpressionWithSparql($text, $regex); |
|
595 | + } catch (ConstraintParameterException $e) { |
|
596 | + $matches = $this->serializeConstraintParameterException($e); |
|
597 | + } catch (SparqlHelperException $e) { |
|
600 | 598 | // don’t cache this |
601 | 599 | return $cacheMap->toArray(); |
602 | 600 | } |
@@ -620,42 +618,42 @@ discard block |
||
620 | 618 | ] |
621 | 619 | ); |
622 | 620 | |
623 | - if ( isset( $cacheMapArray[$textHash] ) ) { |
|
621 | + if (isset($cacheMapArray[$textHash])) { |
|
624 | 622 | $key = 'wikibase.quality.constraints.regex.cache.hit'; |
625 | - $this->dataFactory->increment( $key ); |
|
623 | + $this->dataFactory->increment($key); |
|
626 | 624 | $matches = $cacheMapArray[$textHash]; |
627 | - if ( is_bool( $matches ) ) { |
|
625 | + if (is_bool($matches)) { |
|
628 | 626 | return $matches; |
629 | - } elseif ( is_array( $matches ) && |
|
630 | - $matches['type'] == ConstraintParameterException::class ) { |
|
631 | - throw $this->deserializeConstraintParameterException( $matches ); |
|
627 | + } elseif (is_array($matches) && |
|
628 | + $matches['type'] == ConstraintParameterException::class) { |
|
629 | + throw $this->deserializeConstraintParameterException($matches); |
|
632 | 630 | } else { |
633 | 631 | throw new UnexpectedValueException( |
634 | - 'Value of unknown type in object cache (' . |
|
635 | - 'cache key: ' . $cacheKey . ', ' . |
|
636 | - 'cache map key: ' . $textHash . ', ' . |
|
637 | - 'value type: ' . gettype( $matches ) . ')' |
|
632 | + 'Value of unknown type in object cache ('. |
|
633 | + 'cache key: '.$cacheKey.', '. |
|
634 | + 'cache map key: '.$textHash.', '. |
|
635 | + 'value type: '.gettype($matches).')' |
|
638 | 636 | ); |
639 | 637 | } |
640 | 638 | } else { |
641 | 639 | $key = 'wikibase.quality.constraints.regex.cache.miss'; |
642 | - $this->dataFactory->increment( $key ); |
|
643 | - return $this->matchesRegularExpressionWithSparql( $text, $regex ); |
|
640 | + $this->dataFactory->increment($key); |
|
641 | + return $this->matchesRegularExpressionWithSparql($text, $regex); |
|
644 | 642 | } |
645 | 643 | } |
646 | 644 | |
647 | - private function serializeConstraintParameterException( ConstraintParameterException $cpe ) { |
|
645 | + private function serializeConstraintParameterException(ConstraintParameterException $cpe) { |
|
648 | 646 | return [ |
649 | 647 | 'type' => ConstraintParameterException::class, |
650 | - 'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ), |
|
648 | + 'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()), |
|
651 | 649 | ]; |
652 | 650 | } |
653 | 651 | |
654 | - private function deserializeConstraintParameterException( array $serialization ) { |
|
652 | + private function deserializeConstraintParameterException(array $serialization) { |
|
655 | 653 | $message = $this->violationMessageDeserializer->deserialize( |
656 | 654 | $serialization['violationMessage'] |
657 | 655 | ); |
658 | - return new ConstraintParameterException( $message ); |
|
656 | + return new ConstraintParameterException($message); |
|
659 | 657 | } |
660 | 658 | |
661 | 659 | /** |
@@ -669,25 +667,25 @@ discard block |
||
669 | 667 | * @throws SparqlHelperException if the query times out or some other error occurs |
670 | 668 | * @throws ConstraintParameterException if the $regex is invalid |
671 | 669 | */ |
672 | - public function matchesRegularExpressionWithSparql( $text, $regex ) { |
|
673 | - $textStringLiteral = $this->stringLiteral( $text ); |
|
674 | - $regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' ); |
|
670 | + public function matchesRegularExpressionWithSparql($text, $regex) { |
|
671 | + $textStringLiteral = $this->stringLiteral($text); |
|
672 | + $regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$'); |
|
675 | 673 | |
676 | 674 | $query = <<<EOF |
677 | 675 | SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {} |
678 | 676 | EOF; |
679 | 677 | |
680 | - $result = $this->runQuery( $query, false ); |
|
678 | + $result = $this->runQuery($query, false); |
|
681 | 679 | |
682 | 680 | $vars = $result->getArray()['results']['bindings'][0]; |
683 | - if ( array_key_exists( 'matches', $vars ) ) { |
|
681 | + if (array_key_exists('matches', $vars)) { |
|
684 | 682 | // true or false ⇒ regex okay, text matches or not |
685 | 683 | return $vars['matches']['value'] === 'true'; |
686 | 684 | } else { |
687 | 685 | // empty result: regex broken |
688 | 686 | throw new ConstraintParameterException( |
689 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) ) |
|
690 | - ->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
687 | + (new ViolationMessage('wbqc-violation-message-parameter-regex')) |
|
688 | + ->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE) |
|
691 | 689 | ); |
692 | 690 | } |
693 | 691 | } |
@@ -699,14 +697,14 @@ discard block |
||
699 | 697 | * |
700 | 698 | * @return boolean |
701 | 699 | */ |
702 | - public function isTimeout( $responseContent ) { |
|
703 | - $timeoutRegex = implode( '|', array_map( |
|
704 | - static function ( $fqn ) { |
|
705 | - return preg_quote( $fqn, '/' ); |
|
700 | + public function isTimeout($responseContent) { |
|
701 | + $timeoutRegex = implode('|', array_map( |
|
702 | + static function($fqn) { |
|
703 | + return preg_quote($fqn, '/'); |
|
706 | 704 | }, |
707 | 705 | $this->timeoutExceptionClasses |
708 | - ) ); |
|
709 | - return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent ); |
|
706 | + )); |
|
707 | + return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent); |
|
710 | 708 | } |
711 | 709 | |
712 | 710 | /** |
@@ -718,17 +716,17 @@ discard block |
||
718 | 716 | * @return int|boolean the max-age (in seconds) |
719 | 717 | * or a plain boolean if no max-age can be determined |
720 | 718 | */ |
721 | - public function getCacheMaxAge( $responseHeaders ) { |
|
719 | + public function getCacheMaxAge($responseHeaders) { |
|
722 | 720 | if ( |
723 | - array_key_exists( 'x-cache-status', $responseHeaders ) && |
|
724 | - preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] ) |
|
721 | + array_key_exists('x-cache-status', $responseHeaders) && |
|
722 | + preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0]) |
|
725 | 723 | ) { |
726 | 724 | $maxage = []; |
727 | 725 | if ( |
728 | - array_key_exists( 'cache-control', $responseHeaders ) && |
|
729 | - preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage ) |
|
726 | + array_key_exists('cache-control', $responseHeaders) && |
|
727 | + preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage) |
|
730 | 728 | ) { |
731 | - return intval( $maxage[1] ); |
|
729 | + return intval($maxage[1]); |
|
732 | 730 | } else { |
733 | 731 | return true; |
734 | 732 | } |
@@ -749,34 +747,34 @@ discard block |
||
749 | 747 | * or SparlHelper::EMPTY_RETRY_AFTER if there is an empty Retry-After |
750 | 748 | * or SparlHelper::INVALID_RETRY_AFTER if there is something wrong with the format |
751 | 749 | */ |
752 | - public function getThrottling( MWHttpRequest $request ) { |
|
753 | - $retryAfterValue = $request->getResponseHeader( 'Retry-After' ); |
|
754 | - if ( $retryAfterValue === null ) { |
|
750 | + public function getThrottling(MWHttpRequest $request) { |
|
751 | + $retryAfterValue = $request->getResponseHeader('Retry-After'); |
|
752 | + if ($retryAfterValue === null) { |
|
755 | 753 | return self::NO_RETRY_AFTER; |
756 | 754 | } |
757 | 755 | |
758 | - $trimmedRetryAfterValue = trim( $retryAfterValue ); |
|
759 | - if ( empty( $trimmedRetryAfterValue ) ) { |
|
756 | + $trimmedRetryAfterValue = trim($retryAfterValue); |
|
757 | + if (empty($trimmedRetryAfterValue)) { |
|
760 | 758 | return self::EMPTY_RETRY_AFTER; |
761 | 759 | } |
762 | 760 | |
763 | - if ( is_numeric( $trimmedRetryAfterValue ) ) { |
|
764 | - $delaySeconds = (int)$trimmedRetryAfterValue; |
|
765 | - if ( $delaySeconds >= 0 ) { |
|
766 | - return $this->getTimestampInFuture( new DateInterval( 'PT' . $delaySeconds . 'S' ) ); |
|
761 | + if (is_numeric($trimmedRetryAfterValue)) { |
|
762 | + $delaySeconds = (int) $trimmedRetryAfterValue; |
|
763 | + if ($delaySeconds >= 0) { |
|
764 | + return $this->getTimestampInFuture(new DateInterval('PT'.$delaySeconds.'S')); |
|
767 | 765 | } |
768 | 766 | } else { |
769 | - $return = strtotime( $trimmedRetryAfterValue ); |
|
770 | - if ( !empty( $return ) ) { |
|
771 | - return new ConvertibleTimestamp( $return ); |
|
767 | + $return = strtotime($trimmedRetryAfterValue); |
|
768 | + if (!empty($return)) { |
|
769 | + return new ConvertibleTimestamp($return); |
|
772 | 770 | } |
773 | 771 | } |
774 | 772 | return self::INVALID_RETRY_AFTER; |
775 | 773 | } |
776 | 774 | |
777 | - private function getTimestampInFuture( DateInterval $delta ) { |
|
775 | + private function getTimestampInFuture(DateInterval $delta) { |
|
778 | 776 | $now = new ConvertibleTimestamp(); |
779 | - return new ConvertibleTimestamp( $now->timestamp->add( $delta ) ); |
|
777 | + return new ConvertibleTimestamp($now->timestamp->add($delta)); |
|
780 | 778 | } |
781 | 779 | |
782 | 780 | /** |
@@ -790,65 +788,64 @@ discard block |
||
790 | 788 | * |
791 | 789 | * @throws SparqlHelperException if the query times out or some other error occurs |
792 | 790 | */ |
793 | - public function runQuery( $query, $needsPrefixes = true ) { |
|
791 | + public function runQuery($query, $needsPrefixes = true) { |
|
794 | 792 | |
795 | - if ( $this->throttlingLock->isLocked( self::EXPIRY_LOCK_ID ) ) { |
|
796 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' ); |
|
793 | + if ($this->throttlingLock->isLocked(self::EXPIRY_LOCK_ID)) { |
|
794 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling'); |
|
797 | 795 | throw new TooManySparqlRequestsException(); |
798 | 796 | } |
799 | 797 | |
800 | - if ( $this->sparqlHasWikibaseSupport ) { |
|
798 | + if ($this->sparqlHasWikibaseSupport) { |
|
801 | 799 | $needsPrefixes = false; |
802 | 800 | } |
803 | 801 | |
804 | - if ( $needsPrefixes ) { |
|
805 | - $query = $this->prefixes . $query; |
|
802 | + if ($needsPrefixes) { |
|
803 | + $query = $this->prefixes.$query; |
|
806 | 804 | } |
807 | - $query = "#wbqc\n" . $query; |
|
805 | + $query = "#wbqc\n".$query; |
|
808 | 806 | |
809 | - $url = $this->endpoint . '?' . http_build_query( |
|
807 | + $url = $this->endpoint.'?'.http_build_query( |
|
810 | 808 | [ |
811 | 809 | 'query' => $query, |
812 | 810 | 'format' => 'json', |
813 | 811 | 'maxQueryTimeMillis' => $this->maxQueryTimeMillis, |
814 | 812 | ], |
815 | - '', ini_get( 'arg_separator.output' ), |
|
813 | + '', ini_get('arg_separator.output'), |
|
816 | 814 | // encode spaces with %20, not + |
817 | 815 | PHP_QUERY_RFC3986 |
818 | 816 | ); |
819 | 817 | |
820 | 818 | $options = [ |
821 | 819 | 'method' => 'GET', |
822 | - 'timeout' => (int)round( ( $this->maxQueryTimeMillis + 1000 ) / 1000 ), |
|
820 | + 'timeout' => (int) round(($this->maxQueryTimeMillis + 1000) / 1000), |
|
823 | 821 | 'connectTimeout' => 'default', |
824 | 822 | 'userAgent' => $this->defaultUserAgent, |
825 | 823 | ]; |
826 | - $request = $this->requestFactory->create( $url, $options, __METHOD__ ); |
|
827 | - $startTime = microtime( true ); |
|
824 | + $request = $this->requestFactory->create($url, $options, __METHOD__); |
|
825 | + $startTime = microtime(true); |
|
828 | 826 | $requestStatus = $request->execute(); |
829 | - $endTime = microtime( true ); |
|
827 | + $endTime = microtime(true); |
|
830 | 828 | $this->dataFactory->timing( |
831 | 829 | 'wikibase.quality.constraints.sparql.timing', |
832 | - ( $endTime - $startTime ) * 1000 |
|
830 | + ($endTime - $startTime) * 1000 |
|
833 | 831 | ); |
834 | 832 | |
835 | - $this->guardAgainstTooManyRequestsError( $request ); |
|
833 | + $this->guardAgainstTooManyRequestsError($request); |
|
836 | 834 | |
837 | - $maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() ); |
|
838 | - if ( $maxAge ) { |
|
839 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.cached' ); |
|
835 | + $maxAge = $this->getCacheMaxAge($request->getResponseHeaders()); |
|
836 | + if ($maxAge) { |
|
837 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.cached'); |
|
840 | 838 | } |
841 | 839 | |
842 | - if ( $requestStatus->isOK() ) { |
|
840 | + if ($requestStatus->isOK()) { |
|
843 | 841 | $json = $request->getContent(); |
844 | - $jsonStatus = FormatJson::parse( $json, FormatJson::FORCE_ASSOC ); |
|
845 | - if ( $jsonStatus->isOK() ) { |
|
842 | + $jsonStatus = FormatJson::parse($json, FormatJson::FORCE_ASSOC); |
|
843 | + if ($jsonStatus->isOK()) { |
|
846 | 844 | return new CachedQueryResults( |
847 | 845 | $jsonStatus->getValue(), |
848 | 846 | Metadata::ofCachingMetadata( |
849 | 847 | $maxAge ? |
850 | - CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) : |
|
851 | - CachingMetadata::fresh() |
|
848 | + CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh() |
|
852 | 849 | ) |
853 | 850 | ); |
854 | 851 | } else { |
@@ -865,9 +862,9 @@ discard block |
||
865 | 862 | // fall through to general error handling |
866 | 863 | } |
867 | 864 | |
868 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.error' ); |
|
865 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.error'); |
|
869 | 866 | |
870 | - if ( $this->isTimeout( $request->getContent() ) ) { |
|
867 | + if ($this->isTimeout($request->getContent())) { |
|
871 | 868 | $this->dataFactory->increment( |
872 | 869 | 'wikibase.quality.constraints.sparql.error.timeout' |
873 | 870 | ); |
@@ -882,29 +879,29 @@ discard block |
||
882 | 879 | * @param MWHttpRequest $request |
883 | 880 | * @throws TooManySparqlRequestsException |
884 | 881 | */ |
885 | - private function guardAgainstTooManyRequestsError( MWHttpRequest $request ): void { |
|
886 | - if ( $request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS ) { |
|
882 | + private function guardAgainstTooManyRequestsError(MWHttpRequest $request): void { |
|
883 | + if ($request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS) { |
|
887 | 884 | return; |
888 | 885 | } |
889 | 886 | |
890 | 887 | $fallbackBlockDuration = $this->sparqlThrottlingFallbackDuration; |
891 | 888 | |
892 | - if ( $fallbackBlockDuration < 0 ) { |
|
893 | - throw new InvalidArgumentException( 'Fallback duration must be positive int but is: ' . |
|
894 | - $fallbackBlockDuration ); |
|
889 | + if ($fallbackBlockDuration < 0) { |
|
890 | + throw new InvalidArgumentException('Fallback duration must be positive int but is: '. |
|
891 | + $fallbackBlockDuration); |
|
895 | 892 | } |
896 | 893 | |
897 | - $this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' ); |
|
898 | - $throttlingUntil = $this->getThrottling( $request ); |
|
899 | - if ( !( $throttlingUntil instanceof ConvertibleTimestamp ) ) { |
|
900 | - $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid( $request ); |
|
894 | + $this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling'); |
|
895 | + $throttlingUntil = $this->getThrottling($request); |
|
896 | + if (!($throttlingUntil instanceof ConvertibleTimestamp)) { |
|
897 | + $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid($request); |
|
901 | 898 | $this->throttlingLock->lock( |
902 | 899 | self::EXPIRY_LOCK_ID, |
903 | - $this->getTimestampInFuture( new DateInterval( 'PT' . $fallbackBlockDuration . 'S' ) ) |
|
900 | + $this->getTimestampInFuture(new DateInterval('PT'.$fallbackBlockDuration.'S')) |
|
904 | 901 | ); |
905 | 902 | } else { |
906 | - $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent( $throttlingUntil, $request ); |
|
907 | - $this->throttlingLock->lock( self::EXPIRY_LOCK_ID, $throttlingUntil ); |
|
903 | + $this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent($throttlingUntil, $request); |
|
904 | + $this->throttlingLock->lock(self::EXPIRY_LOCK_ID, $throttlingUntil); |
|
908 | 905 | } |
909 | 906 | throw new TooManySparqlRequestsException(); |
910 | 907 | } |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\Specials; |
6 | 6 | |
@@ -90,7 +90,7 @@ discard block |
||
90 | 90 | Config $config, |
91 | 91 | IBufferingStatsdDataFactory $dataFactory |
92 | 92 | ) { |
93 | - parent::__construct( 'ConstraintReport' ); |
|
93 | + parent::__construct('ConstraintReport'); |
|
94 | 94 | |
95 | 95 | $this->entityLookup = $entityLookup; |
96 | 96 | $this->entityTitleLookup = $entityTitleLookup; |
@@ -110,7 +110,7 @@ discard block |
||
110 | 110 | |
111 | 111 | $this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer( |
112 | 112 | $language, |
113 | - $languageFallbackChainFactory->newFromLanguage( $language ), |
|
113 | + $languageFallbackChainFactory->newFromLanguage($language), |
|
114 | 114 | $this->getContext() |
115 | 115 | ); |
116 | 116 | |
@@ -144,7 +144,7 @@ discard block |
||
144 | 144 | * @inheritDoc |
145 | 145 | */ |
146 | 146 | public function getDescription() { |
147 | - return $this->msg( 'wbqc-constraintreport' ); |
|
147 | + return $this->msg('wbqc-constraintreport'); |
|
148 | 148 | } |
149 | 149 | |
150 | 150 | /** |
@@ -156,43 +156,43 @@ discard block |
||
156 | 156 | * @throws EntityIdParsingException |
157 | 157 | * @throws UnexpectedValueException |
158 | 158 | */ |
159 | - public function execute( $subPage ) { |
|
159 | + public function execute($subPage) { |
|
160 | 160 | $out = $this->getOutput(); |
161 | 161 | |
162 | - $postRequest = $this->getContext()->getRequest()->getVal( 'entityid' ); |
|
163 | - if ( $postRequest ) { |
|
164 | - $out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() ); |
|
162 | + $postRequest = $this->getContext()->getRequest()->getVal('entityid'); |
|
163 | + if ($postRequest) { |
|
164 | + $out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL()); |
|
165 | 165 | return; |
166 | 166 | } |
167 | 167 | |
168 | 168 | $out->enableOOUI(); |
169 | - $out->addModules( $this->getModules() ); |
|
169 | + $out->addModules($this->getModules()); |
|
170 | 170 | |
171 | 171 | $this->setHeaders(); |
172 | 172 | |
173 | - $out->addHTML( $this->getExplanationText() ); |
|
173 | + $out->addHTML($this->getExplanationText()); |
|
174 | 174 | $this->buildEntityIdForm(); |
175 | 175 | |
176 | - if ( !$subPage ) { |
|
176 | + if (!$subPage) { |
|
177 | 177 | return; |
178 | 178 | } |
179 | 179 | |
180 | - if ( !is_string( $subPage ) ) { |
|
181 | - throw new InvalidArgumentException( '$subPage must be string.' ); |
|
180 | + if (!is_string($subPage)) { |
|
181 | + throw new InvalidArgumentException('$subPage must be string.'); |
|
182 | 182 | } |
183 | 183 | |
184 | 184 | try { |
185 | - $entityId = $this->entityIdParser->parse( $subPage ); |
|
186 | - } catch ( EntityIdParsingException $e ) { |
|
185 | + $entityId = $this->entityIdParser->parse($subPage); |
|
186 | + } catch (EntityIdParsingException $e) { |
|
187 | 187 | $out->addHTML( |
188 | - $this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true ) |
|
188 | + $this->buildNotice('wbqc-constraintreport-invalid-entity-id', true) |
|
189 | 189 | ); |
190 | 190 | return; |
191 | 191 | } |
192 | 192 | |
193 | - if ( !$this->entityLookup->hasEntity( $entityId ) ) { |
|
193 | + if (!$this->entityLookup->hasEntity($entityId)) { |
|
194 | 194 | $out->addHTML( |
195 | - $this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true ) |
|
195 | + $this->buildNotice('wbqc-constraintreport-not-existent-entity', true) |
|
196 | 196 | ); |
197 | 197 | return; |
198 | 198 | } |
@@ -200,18 +200,18 @@ discard block |
||
200 | 200 | $this->dataFactory->increment( |
201 | 201 | 'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck' |
202 | 202 | ); |
203 | - $results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId ); |
|
203 | + $results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId); |
|
204 | 204 | |
205 | - if ( $results !== [] ) { |
|
205 | + if ($results !== []) { |
|
206 | 206 | $out->addHTML( |
207 | - $this->buildResultHeader( $entityId ) |
|
208 | - . $this->buildSummary( $results ) |
|
209 | - . $this->buildResultTable( $entityId, $results ) |
|
207 | + $this->buildResultHeader($entityId) |
|
208 | + . $this->buildSummary($results) |
|
209 | + . $this->buildResultTable($entityId, $results) |
|
210 | 210 | ); |
211 | 211 | } else { |
212 | 212 | $out->addHTML( |
213 | - $this->buildResultHeader( $entityId ) |
|
214 | - . $this->buildNotice( 'wbqc-constraintreport-empty-result' ) |
|
213 | + $this->buildResultHeader($entityId) |
|
214 | + . $this->buildNotice('wbqc-constraintreport-empty-result') |
|
215 | 215 | ); |
216 | 216 | } |
217 | 217 | } |
@@ -227,15 +227,15 @@ discard block |
||
227 | 227 | 'name' => 'entityid', |
228 | 228 | 'label-message' => 'wbqc-constraintreport-form-entityid-label', |
229 | 229 | 'cssclass' => 'wbqc-constraintreport-form-entity-id', |
230 | - 'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped(), |
|
230 | + 'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped(), |
|
231 | 231 | ], |
232 | 232 | ]; |
233 | - $htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' ); |
|
234 | - $htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() ); |
|
235 | - $htmlForm->setSubmitCallback( static function () { |
|
233 | + $htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form'); |
|
234 | + $htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped()); |
|
235 | + $htmlForm->setSubmitCallback(static function() { |
|
236 | 236 | return false; |
237 | 237 | } ); |
238 | - $htmlForm->setMethod( 'post' ); |
|
238 | + $htmlForm->setMethod('post'); |
|
239 | 239 | $htmlForm->show(); |
240 | 240 | } |
241 | 241 | |
@@ -249,9 +249,9 @@ discard block |
||
249 | 249 | * |
250 | 250 | * @return string HTML |
251 | 251 | */ |
252 | - private function buildNotice( string $messageKey, bool $error = false ): string { |
|
252 | + private function buildNotice(string $messageKey, bool $error = false): string { |
|
253 | 253 | $cssClasses = 'wbqc-constraintreport-notice'; |
254 | - if ( $error ) { |
|
254 | + if ($error) { |
|
255 | 255 | $cssClasses .= ' wbqc-constraintreport-notice-error'; |
256 | 256 | } |
257 | 257 | |
@@ -260,7 +260,7 @@ discard block |
||
260 | 260 | [ |
261 | 261 | 'class' => $cssClasses, |
262 | 262 | ], |
263 | - $this->msg( $messageKey )->escaped() |
|
263 | + $this->msg($messageKey)->escaped() |
|
264 | 264 | ); |
265 | 265 | } |
266 | 266 | |
@@ -270,16 +270,16 @@ discard block |
||
270 | 270 | private function getExplanationText(): string { |
271 | 271 | return Html::rawElement( |
272 | 272 | 'div', |
273 | - [ 'class' => 'wbqc-explanation' ], |
|
273 | + ['class' => 'wbqc-explanation'], |
|
274 | 274 | Html::rawElement( |
275 | 275 | 'p', |
276 | 276 | [], |
277 | - $this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped() |
|
277 | + $this->msg('wbqc-constraintreport-explanation-part-one')->escaped() |
|
278 | 278 | ) |
279 | 279 | . Html::rawElement( |
280 | 280 | 'p', |
281 | 281 | [], |
282 | - $this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped() |
|
282 | + $this->msg('wbqc-constraintreport-explanation-part-two')->escaped() |
|
283 | 283 | ) |
284 | 284 | ); |
285 | 285 | } |
@@ -290,31 +290,31 @@ discard block |
||
290 | 290 | * |
291 | 291 | * @return string HTML |
292 | 292 | */ |
293 | - private function buildResultTable( EntityId $entityId, array $results ): string { |
|
293 | + private function buildResultTable(EntityId $entityId, array $results): string { |
|
294 | 294 | // Set table headers |
295 | 295 | $table = new HtmlTableBuilder( |
296 | 296 | [ |
297 | 297 | new HtmlTableHeaderBuilder( |
298 | - $this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(), |
|
298 | + $this->msg('wbqc-constraintreport-result-table-header-status')->text(), |
|
299 | 299 | true |
300 | 300 | ), |
301 | 301 | new HtmlTableHeaderBuilder( |
302 | - $this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(), |
|
302 | + $this->msg('wbqc-constraintreport-result-table-header-property')->text(), |
|
303 | 303 | true |
304 | 304 | ), |
305 | 305 | new HtmlTableHeaderBuilder( |
306 | - $this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(), |
|
306 | + $this->msg('wbqc-constraintreport-result-table-header-message')->text(), |
|
307 | 307 | true |
308 | 308 | ), |
309 | 309 | new HtmlTableHeaderBuilder( |
310 | - $this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(), |
|
310 | + $this->msg('wbqc-constraintreport-result-table-header-constraint')->text(), |
|
311 | 311 | true |
312 | 312 | ), |
313 | 313 | ] |
314 | 314 | ); |
315 | 315 | |
316 | - foreach ( $results as $result ) { |
|
317 | - $table = $this->appendToResultTable( $table, $entityId, $result ); |
|
316 | + foreach ($results as $result) { |
|
317 | + $table = $this->appendToResultTable($table, $entityId, $result); |
|
318 | 318 | } |
319 | 319 | |
320 | 320 | return $table->toHtml(); |
@@ -326,35 +326,35 @@ discard block |
||
326 | 326 | CheckResult $result |
327 | 327 | ): HtmlTableBuilder { |
328 | 328 | $message = $result->getMessage(); |
329 | - if ( $message === null ) { |
|
329 | + if ($message === null) { |
|
330 | 330 | // no row for this result |
331 | 331 | return $table; |
332 | 332 | } |
333 | 333 | |
334 | 334 | // Status column |
335 | - $statusColumn = $this->formatStatus( $result->getStatus() ); |
|
335 | + $statusColumn = $this->formatStatus($result->getStatus()); |
|
336 | 336 | |
337 | 337 | // Property column |
338 | - $propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() ); |
|
338 | + $propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId()); |
|
339 | 339 | $propertyColumn = $this->getClaimLink( |
340 | 340 | $entityId, |
341 | 341 | $propertyId, |
342 | - $this->entityIdLabelFormatter->formatEntityId( $propertyId ) |
|
342 | + $this->entityIdLabelFormatter->formatEntityId($propertyId) |
|
343 | 343 | ); |
344 | 344 | |
345 | 345 | // Message column |
346 | - $messageColumn = $this->violationMessageRenderer->render( $message ); |
|
346 | + $messageColumn = $this->violationMessageRenderer->render($message); |
|
347 | 347 | |
348 | 348 | // Constraint column |
349 | 349 | $constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId(); |
350 | 350 | try { |
351 | - $constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) ); |
|
352 | - } catch ( InvalidArgumentException $e ) { |
|
353 | - $constraintTypeLabel = htmlspecialchars( $constraintTypeItemId ); |
|
351 | + $constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId)); |
|
352 | + } catch (InvalidArgumentException $e) { |
|
353 | + $constraintTypeLabel = htmlspecialchars($constraintTypeItemId); |
|
354 | 354 | } |
355 | 355 | $constraintColumn = $this->getClaimLink( |
356 | 356 | $propertyId, |
357 | - new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ), |
|
357 | + new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')), |
|
358 | 358 | $constraintTypeLabel |
359 | 359 | ); |
360 | 360 | |
@@ -362,16 +362,16 @@ discard block |
||
362 | 362 | $table->appendRow( |
363 | 363 | [ |
364 | 364 | new HtmlTableCellBuilder( |
365 | - new HtmlArmor( $statusColumn ) |
|
365 | + new HtmlArmor($statusColumn) |
|
366 | 366 | ), |
367 | 367 | new HtmlTableCellBuilder( |
368 | - new HtmlArmor( $propertyColumn ) |
|
368 | + new HtmlArmor($propertyColumn) |
|
369 | 369 | ), |
370 | 370 | new HtmlTableCellBuilder( |
371 | - new HtmlArmor( $messageColumn ) |
|
371 | + new HtmlArmor($messageColumn) |
|
372 | 372 | ), |
373 | 373 | new HtmlTableCellBuilder( |
374 | - new HtmlArmor( $constraintColumn ) |
|
374 | + new HtmlArmor($constraintColumn) |
|
375 | 375 | ), |
376 | 376 | ] |
377 | 377 | ); |
@@ -386,15 +386,15 @@ discard block |
||
386 | 386 | * |
387 | 387 | * @return string HTML |
388 | 388 | */ |
389 | - protected function buildResultHeader( EntityId $entityId ): string { |
|
390 | - $entityLink = sprintf( '%s (%s)', |
|
391 | - $this->entityIdLinkFormatter->formatEntityId( $entityId ), |
|
392 | - htmlspecialchars( $entityId->getSerialization() ) ); |
|
389 | + protected function buildResultHeader(EntityId $entityId): string { |
|
390 | + $entityLink = sprintf('%s (%s)', |
|
391 | + $this->entityIdLinkFormatter->formatEntityId($entityId), |
|
392 | + htmlspecialchars($entityId->getSerialization())); |
|
393 | 393 | |
394 | 394 | return Html::rawElement( |
395 | 395 | 'h3', |
396 | 396 | [], |
397 | - sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink ) |
|
397 | + sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink) |
|
398 | 398 | ); |
399 | 399 | } |
400 | 400 | |
@@ -405,24 +405,24 @@ discard block |
||
405 | 405 | * |
406 | 406 | * @return string HTML |
407 | 407 | */ |
408 | - protected function buildSummary( array $results ): string { |
|
408 | + protected function buildSummary(array $results): string { |
|
409 | 409 | $statuses = []; |
410 | - foreach ( $results as $result ) { |
|
411 | - $status = strtolower( $result->getStatus() ); |
|
412 | - $statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1; |
|
410 | + foreach ($results as $result) { |
|
411 | + $status = strtolower($result->getStatus()); |
|
412 | + $statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1; |
|
413 | 413 | } |
414 | 414 | |
415 | 415 | $statusElements = []; |
416 | - foreach ( $statuses as $status => $count ) { |
|
417 | - if ( $count > 0 ) { |
|
416 | + foreach ($statuses as $status => $count) { |
|
417 | + if ($count > 0) { |
|
418 | 418 | $statusElements[] = |
419 | - $this->formatStatus( $status ) |
|
419 | + $this->formatStatus($status) |
|
420 | 420 | . ': ' |
421 | 421 | . $count; |
422 | 422 | } |
423 | 423 | } |
424 | 424 | |
425 | - return Html::rawElement( 'p', [], implode( ', ', $statusElements ) ); |
|
425 | + return Html::rawElement('p', [], implode(', ', $statusElements)); |
|
426 | 426 | } |
427 | 427 | |
428 | 428 | /** |
@@ -434,8 +434,8 @@ discard block |
||
434 | 434 | * |
435 | 435 | * @return string HTML |
436 | 436 | */ |
437 | - private function formatStatus( string $status ): string { |
|
438 | - $messageName = "wbqc-constraintreport-status-" . strtolower( $status ); |
|
437 | + private function formatStatus(string $status): string { |
|
438 | + $messageName = "wbqc-constraintreport-status-".strtolower($status); |
|
439 | 439 | $statusIcons = [ |
440 | 440 | CheckResult::STATUS_SUGGESTION => [ |
441 | 441 | 'icon' => 'suggestion-constraint-violation', |
@@ -452,25 +452,25 @@ discard block |
||
452 | 452 | ], |
453 | 453 | ]; |
454 | 454 | |
455 | - if ( array_key_exists( $status, $statusIcons ) ) { |
|
456 | - $iconWidget = new IconWidget( $statusIcons[$status] ); |
|
457 | - $iconHtml = $iconWidget->toString() . ' '; |
|
455 | + if (array_key_exists($status, $statusIcons)) { |
|
456 | + $iconWidget = new IconWidget($statusIcons[$status]); |
|
457 | + $iconHtml = $iconWidget->toString().' '; |
|
458 | 458 | } else { |
459 | 459 | $iconHtml = ''; |
460 | 460 | } |
461 | 461 | |
462 | - $labelWidget = new LabelWidget( [ |
|
463 | - 'label' => $this->msg( $messageName )->text(), |
|
464 | - ] ); |
|
462 | + $labelWidget = new LabelWidget([ |
|
463 | + 'label' => $this->msg($messageName)->text(), |
|
464 | + ]); |
|
465 | 465 | $labelHtml = $labelWidget->toString(); |
466 | 466 | |
467 | 467 | $formattedStatus = |
468 | 468 | Html::rawElement( |
469 | 469 | 'span', |
470 | 470 | [ |
471 | - 'class' => 'wbqc-status wbqc-status-' . $status, |
|
471 | + 'class' => 'wbqc-status wbqc-status-'.$status, |
|
472 | 472 | ], |
473 | - $iconHtml . $labelHtml |
|
473 | + $iconHtml.$labelHtml |
|
474 | 474 | ); |
475 | 475 | |
476 | 476 | return $formattedStatus; |
@@ -493,7 +493,7 @@ discard block |
||
493 | 493 | return Html::rawElement( |
494 | 494 | 'a', |
495 | 495 | [ |
496 | - 'href' => $this->getClaimUrl( $entityId, $propertyId ), |
|
496 | + 'href' => $this->getClaimUrl($entityId, $propertyId), |
|
497 | 497 | 'target' => '_blank', |
498 | 498 | ], |
499 | 499 | $text |
@@ -507,8 +507,8 @@ discard block |
||
507 | 507 | EntityId $entityId, |
508 | 508 | NumericPropertyId $propertyId |
509 | 509 | ): string { |
510 | - $title = $this->entityTitleLookup->getTitleForId( $entityId ); |
|
511 | - $entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() ); |
|
510 | + $title = $this->entityTitleLookup->getTitleForId($entityId); |
|
511 | + $entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization()); |
|
512 | 512 | |
513 | 513 | return $entityUrl; |
514 | 514 | } |
@@ -33,9 +33,9 @@ discard block |
||
33 | 33 | * |
34 | 34 | * @throws InvalidArgumentException |
35 | 35 | */ |
36 | - public function __construct( $content, $isSortable = false ) { |
|
37 | - Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' ); |
|
38 | - Assert::parameterType( 'boolean', $isSortable, '$isSortable' ); |
|
36 | + public function __construct($content, $isSortable = false) { |
|
37 | + Assert::parameterType(['string', HtmlArmor::class], $content, '$content'); |
|
38 | + Assert::parameterType('boolean', $isSortable, '$isSortable'); |
|
39 | 39 | |
40 | 40 | $this->content = $content; |
41 | 41 | $this->isSortable = $isSortable; |
@@ -45,7 +45,7 @@ discard block |
||
45 | 45 | * @return string HTML |
46 | 46 | */ |
47 | 47 | public function getContent() { |
48 | - return HtmlArmor::getHtml( $this->content ); |
|
48 | + return HtmlArmor::getHtml($this->content); |
|
49 | 49 | } |
50 | 50 | |
51 | 51 | /** |
@@ -61,13 +61,13 @@ discard block |
||
61 | 61 | * @return string HTML |
62 | 62 | */ |
63 | 63 | public function toHtml() { |
64 | - $attributes = [ 'role' => 'columnheader button' ]; |
|
64 | + $attributes = ['role' => 'columnheader button']; |
|
65 | 65 | |
66 | - if ( !$this->isSortable ) { |
|
66 | + if (!$this->isSortable) { |
|
67 | 67 | $attributes['class'] = 'unsortable'; |
68 | 68 | } |
69 | 69 | |
70 | - return Html::rawElement( 'th', $attributes, $this->getContent() ); |
|
70 | + return Html::rawElement('th', $attributes, $this->getContent()); |
|
71 | 71 | } |
72 | 72 | |
73 | 73 | } |
@@ -32,9 +32,9 @@ discard block |
||
32 | 32 | /** |
33 | 33 | * @param array $headers |
34 | 34 | */ |
35 | - public function __construct( array $headers ) { |
|
36 | - foreach ( $headers as $header ) { |
|
37 | - $this->addHeader( $header ); |
|
35 | + public function __construct(array $headers) { |
|
36 | + foreach ($headers as $header) { |
|
37 | + $this->addHeader($header); |
|
38 | 38 | } |
39 | 39 | } |
40 | 40 | |
@@ -43,16 +43,16 @@ discard block |
||
43 | 43 | * |
44 | 44 | * @throws InvalidArgumentException |
45 | 45 | */ |
46 | - private function addHeader( $header ) { |
|
47 | - Assert::parameterType( [ 'string', HtmlTableHeaderBuilder::class ], $header, '$header' ); |
|
46 | + private function addHeader($header) { |
|
47 | + Assert::parameterType(['string', HtmlTableHeaderBuilder::class], $header, '$header'); |
|
48 | 48 | |
49 | - if ( is_string( $header ) ) { |
|
50 | - $header = new HtmlTableHeaderBuilder( $header ); |
|
49 | + if (is_string($header)) { |
|
50 | + $header = new HtmlTableHeaderBuilder($header); |
|
51 | 51 | } |
52 | 52 | |
53 | 53 | $this->headers[] = $header; |
54 | 54 | |
55 | - if ( $header->getIsSortable() ) { |
|
55 | + if ($header->getIsSortable()) { |
|
56 | 56 | $this->isSortable = true; |
57 | 57 | } |
58 | 58 | } |
@@ -85,12 +85,12 @@ discard block |
||
85 | 85 | * |
86 | 86 | * @throws InvalidArgumentException |
87 | 87 | */ |
88 | - public function appendRow( array $cells ) { |
|
89 | - foreach ( $cells as $key => $cell ) { |
|
90 | - if ( is_string( $cell ) ) { |
|
91 | - $cells[$key] = new HtmlTableCellBuilder( $cell ); |
|
92 | - } elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) { |
|
93 | - throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' ); |
|
88 | + public function appendRow(array $cells) { |
|
89 | + foreach ($cells as $key => $cell) { |
|
90 | + if (is_string($cell)) { |
|
91 | + $cells[$key] = new HtmlTableCellBuilder($cell); |
|
92 | + } elseif (!($cell instanceof HtmlTableCellBuilder)) { |
|
93 | + throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.'); |
|
94 | 94 | } |
95 | 95 | } |
96 | 96 | |
@@ -104,13 +104,13 @@ discard block |
||
104 | 104 | * |
105 | 105 | * @throws InvalidArgumentException |
106 | 106 | */ |
107 | - public function appendRows( array $rows ) { |
|
108 | - foreach ( $rows as $cells ) { |
|
109 | - if ( !is_array( $cells ) ) { |
|
110 | - throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' ); |
|
107 | + public function appendRows(array $rows) { |
|
108 | + foreach ($rows as $cells) { |
|
109 | + if (!is_array($cells)) { |
|
110 | + throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.'); |
|
111 | 111 | } |
112 | 112 | |
113 | - $this->appendRow( $cells ); |
|
113 | + $this->appendRow($cells); |
|
114 | 114 | } |
115 | 115 | } |
116 | 116 | |
@@ -122,38 +122,38 @@ discard block |
||
122 | 122 | public function toHtml() { |
123 | 123 | // Open table |
124 | 124 | $tableClasses = 'wikitable'; |
125 | - if ( $this->isSortable ) { |
|
125 | + if ($this->isSortable) { |
|
126 | 126 | $tableClasses .= ' sortable'; |
127 | 127 | } |
128 | - $html = Html::openElement( 'table', [ 'class' => $tableClasses ] ); |
|
128 | + $html = Html::openElement('table', ['class' => $tableClasses]); |
|
129 | 129 | |
130 | 130 | // Write headers |
131 | - $html .= Html::openElement( 'thead' ); |
|
132 | - $html .= Html::openElement( 'tr' ); |
|
133 | - foreach ( $this->headers as $header ) { |
|
131 | + $html .= Html::openElement('thead'); |
|
132 | + $html .= Html::openElement('tr'); |
|
133 | + foreach ($this->headers as $header) { |
|
134 | 134 | $html .= $header->toHtml(); |
135 | 135 | } |
136 | - $html .= Html::closeElement( 'tr' ); |
|
137 | - $html .= Html::closeElement( 'thead' ); |
|
138 | - $html .= Html::openElement( 'tbody' ); |
|
136 | + $html .= Html::closeElement('tr'); |
|
137 | + $html .= Html::closeElement('thead'); |
|
138 | + $html .= Html::openElement('tbody'); |
|
139 | 139 | |
140 | 140 | // Write rows |
141 | - foreach ( $this->rows as $row ) { |
|
142 | - $html .= Html::openElement( 'tr' ); |
|
141 | + foreach ($this->rows as $row) { |
|
142 | + $html .= Html::openElement('tr'); |
|
143 | 143 | |
144 | 144 | /** |
145 | 145 | * @var HtmlTableCellBuilder $cell |
146 | 146 | */ |
147 | - foreach ( $row as $cell ) { |
|
147 | + foreach ($row as $cell) { |
|
148 | 148 | $html .= $cell->toHtml(); |
149 | 149 | } |
150 | 150 | |
151 | - $html .= Html::closeElement( 'tr' ); |
|
151 | + $html .= Html::closeElement('tr'); |
|
152 | 152 | } |
153 | 153 | |
154 | 154 | // Close table |
155 | - $html .= Html::closeElement( 'tbody' ); |
|
156 | - $html .= Html::closeElement( 'table' ); |
|
155 | + $html .= Html::closeElement('tbody'); |
|
156 | + $html .= Html::closeElement('table'); |
|
157 | 157 | |
158 | 158 | return $html; |
159 | 159 | } |
@@ -31,8 +31,8 @@ discard block |
||
31 | 31 | * |
32 | 32 | * @throws InvalidArgumentException |
33 | 33 | */ |
34 | - public function __construct( $content, array $attributes = [] ) { |
|
35 | - Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' ); |
|
34 | + public function __construct($content, array $attributes = []) { |
|
35 | + Assert::parameterType(['string', HtmlArmor::class], $content, '$content'); |
|
36 | 36 | |
37 | 37 | $this->content = $content; |
38 | 38 | $this->attributes = $attributes; |
@@ -42,7 +42,7 @@ discard block |
||
42 | 42 | * @return string HTML |
43 | 43 | */ |
44 | 44 | public function getContent() { |
45 | - return HtmlArmor::getHtml( $this->content ); |
|
45 | + return HtmlArmor::getHtml($this->content); |
|
46 | 46 | } |
47 | 47 | |
48 | 48 | /** |
@@ -56,7 +56,7 @@ discard block |
||
56 | 56 | * @return string HTML |
57 | 57 | */ |
58 | 58 | public function toHtml() { |
59 | - return Html::rawElement( 'td', $this->getAttributes(), $this->getContent() ); |
|
59 | + return Html::rawElement('td', $this->getAttributes(), $this->getContent()); |
|
60 | 60 | } |
61 | 61 | |
62 | 62 | } |
@@ -26,8 +26,8 @@ discard block |
||
26 | 26 | BeforePageDisplayHook |
27 | 27 | { |
28 | 28 | |
29 | - public static function onWikibaseChange( Change $change ) { |
|
30 | - if ( !( $change instanceof EntityChange ) ) { |
|
29 | + public static function onWikibaseChange(Change $change) { |
|
30 | + if (!($change instanceof EntityChange)) { |
|
31 | 31 | return; |
32 | 32 | } |
33 | 33 | /** @var EntityChange $change */ |
@@ -38,48 +38,48 @@ discard block |
||
38 | 38 | |
39 | 39 | // If jobs are enabled and the results would be stored in some way run a job. |
40 | 40 | if ( |
41 | - $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) && |
|
42 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) && |
|
41 | + $config->get('WBQualityConstraintsEnableConstraintsCheckJobs') && |
|
42 | + $config->get('WBQualityConstraintsCacheCheckConstraintsResults') && |
|
43 | 43 | self::isSelectedForJobRunBasedOnPercentage() |
44 | 44 | ) { |
45 | - $params = [ 'entityId' => $change->getEntityId()->getSerialization() ]; |
|
45 | + $params = ['entityId' => $change->getEntityId()->getSerialization()]; |
|
46 | 46 | $jobQueueGroup->lazyPush( |
47 | - new JobSpecification( CheckConstraintsJob::COMMAND, $params ) |
|
47 | + new JobSpecification(CheckConstraintsJob::COMMAND, $params) |
|
48 | 48 | ); |
49 | 49 | } |
50 | 50 | |
51 | - if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) && |
|
52 | - self::isConstraintStatementsChange( $config, $change ) |
|
51 | + if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') && |
|
52 | + self::isConstraintStatementsChange($config, $change) |
|
53 | 53 | ) { |
54 | - $params = [ 'propertyId' => $change->getEntityId()->getSerialization() ]; |
|
54 | + $params = ['propertyId' => $change->getEntityId()->getSerialization()]; |
|
55 | 55 | $metadata = $change->getMetadata(); |
56 | - if ( array_key_exists( 'rev_id', $metadata ) ) { |
|
56 | + if (array_key_exists('rev_id', $metadata)) { |
|
57 | 57 | $params['revisionId'] = $metadata['rev_id']; |
58 | 58 | } |
59 | 59 | $jobQueueGroup->push( |
60 | - new JobSpecification( 'constraintsTableUpdate', $params ) |
|
60 | + new JobSpecification('constraintsTableUpdate', $params) |
|
61 | 61 | ); |
62 | 62 | } |
63 | 63 | } |
64 | 64 | |
65 | 65 | private static function isSelectedForJobRunBasedOnPercentage() { |
66 | 66 | $config = MediaWikiServices::getInstance()->getMainConfig(); |
67 | - $percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' ); |
|
67 | + $percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio'); |
|
68 | 68 | |
69 | - return mt_rand( 1, 100 ) <= $percentage; |
|
69 | + return mt_rand(1, 100) <= $percentage; |
|
70 | 70 | } |
71 | 71 | |
72 | - public static function isConstraintStatementsChange( Config $config, Change $change ) { |
|
73 | - if ( !( $change instanceof EntityChange ) || |
|
72 | + public static function isConstraintStatementsChange(Config $config, Change $change) { |
|
73 | + if (!($change instanceof EntityChange) || |
|
74 | 74 | $change->getAction() !== EntityChange::UPDATE || |
75 | - !( $change->getEntityId() instanceof NumericPropertyId ) |
|
75 | + !($change->getEntityId() instanceof NumericPropertyId) |
|
76 | 76 | ) { |
77 | 77 | return false; |
78 | 78 | } |
79 | 79 | |
80 | 80 | $info = $change->getInfo(); |
81 | 81 | |
82 | - if ( !array_key_exists( 'compactDiff', $info ) ) { |
|
82 | + if (!array_key_exists('compactDiff', $info)) { |
|
83 | 83 | // the non-compact diff ($info['diff']) does not contain statement diffs (T110996), |
84 | 84 | // so we only know that the change *might* affect the constraint statements |
85 | 85 | return true; |
@@ -88,50 +88,50 @@ discard block |
||
88 | 88 | /** @var EntityDiffChangedAspects $aspects */ |
89 | 89 | $aspects = $info['compactDiff']; |
90 | 90 | |
91 | - $propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' ); |
|
92 | - return in_array( $propertyConstraintId, $aspects->getStatementChanges() ); |
|
91 | + $propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId'); |
|
92 | + return in_array($propertyConstraintId, $aspects->getStatementChanges()); |
|
93 | 93 | } |
94 | 94 | |
95 | - public function onArticlePurge( $wikiPage ) { |
|
95 | + public function onArticlePurge($wikiPage) { |
|
96 | 96 | $entityContentFactory = WikibaseRepo::getEntityContentFactory(); |
97 | - if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) { |
|
97 | + if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) { |
|
98 | 98 | $entityIdLookup = WikibaseRepo::getEntityIdLookup(); |
99 | - $entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() ); |
|
100 | - if ( $entityId !== null ) { |
|
99 | + $entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle()); |
|
100 | + if ($entityId !== null) { |
|
101 | 101 | $resultsCache = ResultsCache::getDefaultInstance(); |
102 | - $resultsCache->delete( $entityId ); |
|
102 | + $resultsCache->delete($entityId); |
|
103 | 103 | } |
104 | 104 | } |
105 | 105 | } |
106 | 106 | |
107 | - public function onBeforePageDisplay( $out, $skin ): void { |
|
107 | + public function onBeforePageDisplay($out, $skin): void { |
|
108 | 108 | $lookup = WikibaseRepo::getEntityNamespaceLookup(); |
109 | 109 | $title = $out->getTitle(); |
110 | - if ( $title === null ) { |
|
110 | + if ($title === null) { |
|
111 | 111 | return; |
112 | 112 | } |
113 | 113 | |
114 | - if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) { |
|
114 | + if (!$lookup->isNamespaceWithEntities($title->getNamespace())) { |
|
115 | 115 | return; |
116 | 116 | } |
117 | - if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) { |
|
117 | + if (empty($out->getJsConfigVars()['wbIsEditView'])) { |
|
118 | 118 | return; |
119 | 119 | } |
120 | 120 | |
121 | 121 | $services = MediaWikiServices::getInstance(); |
122 | 122 | $config = $services->getMainConfig(); |
123 | 123 | |
124 | - $isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) && |
|
125 | - $services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView(); |
|
126 | - if ( $isMobileView ) { |
|
124 | + $isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') && |
|
125 | + $services->getService('MobileFrontend.Context')->shouldDisplayMobileView(); |
|
126 | + if ($isMobileView) { |
|
127 | 127 | return; |
128 | 128 | } |
129 | 129 | |
130 | - $out->addModules( 'wikibase.quality.constraints.suggestions' ); |
|
130 | + $out->addModules('wikibase.quality.constraints.suggestions'); |
|
131 | 131 | |
132 | - if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' ) |
|
133 | - || $out->getUser()->isRegistered() ) { |
|
134 | - $out->addModules( 'wikibase.quality.constraints.gadget' ); |
|
132 | + if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers') |
|
133 | + || $out->getUser()->isRegistered()) { |
|
134 | + $out->addModules('wikibase.quality.constraints.gadget'); |
|
135 | 135 | } |
136 | 136 | } |
137 | 137 |
@@ -15,22 +15,22 @@ |
||
15 | 15 | /** |
16 | 16 | * @param DatabaseUpdater $updater |
17 | 17 | */ |
18 | - public function onLoadExtensionSchemaUpdates( $updater ) { |
|
19 | - $dir = dirname( __DIR__ ) . '/sql/'; |
|
18 | + public function onLoadExtensionSchemaUpdates($updater) { |
|
19 | + $dir = dirname(__DIR__).'/sql/'; |
|
20 | 20 | |
21 | 21 | $updater->addExtensionTable( |
22 | 22 | 'wbqc_constraints', |
23 | - $dir . "/{$updater->getDB()->getType()}/tables-generated.sql" |
|
23 | + $dir."/{$updater->getDB()->getType()}/tables-generated.sql" |
|
24 | 24 | ); |
25 | 25 | $updater->addExtensionField( |
26 | 26 | 'wbqc_constraints', |
27 | 27 | 'constraint_id', |
28 | - $dir . '/patch-wbqc_constraints-constraint_id.sql' |
|
28 | + $dir.'/patch-wbqc_constraints-constraint_id.sql' |
|
29 | 29 | ); |
30 | 30 | $updater->addExtensionIndex( |
31 | 31 | 'wbqc_constraints', |
32 | 32 | 'wbqc_constraints_guid_uniq', |
33 | - $dir . '/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql' |
|
33 | + $dir.'/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql' |
|
34 | 34 | ); |
35 | 35 | } |
36 | 36 |