Inspection of "Localisation updates from https://translatewiki.ne..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90c9bb...b00e4a )

unknown

created 2024-02-07 07:31 UTC

Status

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -76,18 +76,18 @@  discard block
 block discarded – undo
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
-		if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
+		if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
 
 			$separators = $this->constraintParameterParser->parseSeparatorsParameter(
 				$constraint->getConstraintParameters()
 			);
 
-			if ( $context->getType() === 'statement' ) {
+			if ($context->getType() === 'statement') {
 				$statement = $context->getSnakStatement();
 				'@phan-var Statement $statement';
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
@@ -96,9 +96,9 @@  discard block
 block discarded – undo
 				);
 			} else {
 				$snak = $context->getSnak();
-				if ( !$snak instanceof PropertyValueSnak ) {
+				if (!$snak instanceof PropertyValueSnak) {
 					// nothing to check
-					return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+					return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -111,32 +111,32 @@  discard block
 block discarded – undo
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/AllowedUnitsChecker.php 1 patch

Spacing +34 added lines, -35 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$unitsParameter = $this->constraintParameterParser
 			->parseUnitsParameter(
@@ -81,50 +81,49 @@  discard block
 block discarded – undo
 			);
 
 		$snak = $context->getSnak();
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
-		if ( !$dataValue instanceof UnboundedQuantityValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'quantity' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof UnboundedQuantityValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('quantity');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
-		if ( $dataValue->getUnit() === '1' ) {
-			return $this->checkUnitless( $context, $constraint, $unitsParameter, $snak );
+		if ($dataValue->getUnit() === '1') {
+			return $this->checkUnitless($context, $constraint, $unitsParameter, $snak);
 		}
 
 		$status = CheckResult::STATUS_VIOLATION;
-		$actualUnit = $this->standardize( $dataValue )->getUnit();
-		foreach ( $unitsParameter->getUnitQuantities() as $unitQuantity ) {
-			$allowedUnit = $this->standardize( $unitQuantity )->getUnit();
-			if ( $actualUnit === $allowedUnit ) {
+		$actualUnit = $this->standardize($dataValue)->getUnit();
+		foreach ($unitsParameter->getUnitQuantities() as $unitQuantity) {
+			$allowedUnit = $this->standardize($unitQuantity)->getUnit();
+			if ($actualUnit === $allowedUnit) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		if ( $status === CheckResult::STATUS_VIOLATION ) {
-			if ( $unitsParameter->getUnitItemIds() === [] ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-units-none' ) )
-					->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($status === CheckResult::STATUS_VIOLATION) {
+			if ($unitsParameter->getUnitItemIds() === []) {
+				$message = (new ViolationMessage('wbqc-violation-message-units-none'))
+					->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			} else {
 				$messageKey = $unitsParameter->getUnitlessAllowed() ?
-					'wbqc-violation-message-units-or-none' :
-					'wbqc-violation-message-units';
-				$message = ( new ViolationMessage( $messageKey ) )
-					->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
+					'wbqc-violation-message-units-or-none' : 'wbqc-violation-message-units';
+				$message = (new ViolationMessage($messageKey))
+					->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
 			}
 		} else {
 			$message = null;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	/**
@@ -140,17 +139,17 @@  discard block
 block discarded – undo
 		UnitsParameter $unitsParameter,
 		PropertyValueSnak $snak
 	) {
-		if ( $unitsParameter->getUnitlessAllowed() ) {
+		if ($unitsParameter->getUnitlessAllowed()) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-units' ) )
-				->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
+			$message = (new ViolationMessage('wbqc-violation-message-units'))
+				->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	/**
@@ -159,20 +158,20 @@  discard block
 block discarded – undo
 	 * @param UnboundedQuantityValue $value
 	 * @return UnboundedQuantityValue
 	 */
-	private function standardize( UnboundedQuantityValue $value ) {
-		if ( $this->unitConverter === null ) {
+	private function standardize(UnboundedQuantityValue $value) {
+		if ($this->unitConverter === null) {
 			return $value;
 		}
 
-		$standard = $this->unitConverter->toStandardUnits( $value );
-		if ( $standard !== null ) {
+		$standard = $this->unitConverter->toStandardUnits($value);
+		if ($standard !== null) {
 			return $standard;
 		} else {
 			return $value;
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -181,7 +180,7 @@  discard block
 block discarded – undo
 				$constraint->getConstraintTypeItemId(),
 				true
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ItemChecker.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -75,9 +75,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
@@ -112,21 +112,21 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/QualifierChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -44,16 +44,16 @@
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_QUALIFIER ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_QUALIFIER) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-qualifier' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-qualifier');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/PropertyScopeChecker.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
 			$constraintTypeItemId
 		);
 
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
+		if (in_array($context->getType(), $allowedContextTypes)) {
 			return new CheckResult(
 				$context->getCursor(),
 				$constraint,
@@ -66,15 +66,15 @@  discard block
 block discarded – undo
 				$context->getCursor(),
 				$constraint,
 				CheckResult::STATUS_VIOLATION,
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
-					->withEntityId( $context->getSnak()->getPropertyId() )
-					->withPropertyScope( $context->getType() )
-					->withPropertyScopeList( $allowedContextTypes )
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
+					->withEntityId($context->getSnak()->getPropertyId())
+					->withPropertyScope($context->getType())
+					->withPropertyScopeList($allowedContextTypes)
 			);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch

Spacing +15 added lines, -16 removed lines patch added patch discarded remove patch

@@ -64,9 +64,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
@@ -75,19 +75,19 @@  discard block
 block discarded – undo
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount > 1 ) {
-			$message = $this->getViolationMessage( $separators, $propertyId );
+		if ($propertyCount > 1) {
+			$message = $this->getViolationMessage($separators, $propertyId);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	/**
@@ -95,22 +95,21 @@  discard block
 block discarded – undo
 	 * @param PropertyId $propertyId
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
 		$messageKey = $separators === [] ?
-			'wbqc-violation-message-single-value' :
-			'wbqc-violation-message-single-value-separators';
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -33,16 +33,16 @@
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-reference');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -76,9 +76,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -97,22 +97,22 @@  discard block
 block discarded – undo
 
 		$statementList = $context->getEntity()
 			->getStatements()
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 
 		/*
 		 * 'Conflicts with' can be defined with
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$statementList,
 				$propertyId
 			);
-			if ( $offendingStatement !== null ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE );
+			if ($offendingStatement !== null) {
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -124,12 +124,12 @@  discard block
 block discarded – undo
 				$propertyId,
 				$items
 			);
-			if ( $offendingStatement !== null ) {
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE )
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
+			if ($offendingStatement !== null) {
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE)
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -137,10 +137,10 @@  discard block
 block discarded – undo
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/LabelInLanguageChecker.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 	 */
 	private $constraintParameterParser;
 
-	public function __construct( ConstraintParameterParser $constraintParameterParser ) {
+	public function __construct(ConstraintParameterParser $constraintParameterParser) {
 		$this->constraintParameterParser = $constraintParameterParser;
 	}
 
@@ -68,9 +68,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -81,26 +81,26 @@  discard block
 block discarded – undo
 		);
 
 		$status = CheckResult::STATUS_VIOLATION;
-		$message = ( new ViolationMessage( 'wbqc-violation-message-label-lacking' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-			->withLanguages( $languages );
+		$message = (new ViolationMessage('wbqc-violation-message-label-lacking'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+			->withLanguages($languages);
 
 		/** @var LabelsProvider $entity */
 		$entity = $context->getEntity();
 		'@phan-var LabelsProvider $entity';
 
-		foreach ( $languages as $language ) {
-			if ( $entity->getLabels()->hasTermForLanguage( $language ) ) {
+		foreach ($languages as $language) {
+			if ($entity->getLabels()->hasTermForLanguage($language)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId()
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

		@@ -76,18 +76,18 @@ discard block
		block discarded – undo
76	76	* @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
77	77	* @return CheckResult
78	78	*/
79		- public function checkConstraint( Context $context, Constraint $constraint ) {
80		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
81		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	79	+ public function checkConstraint(Context $context, Constraint $constraint) {
	80	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	81	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
82	82	}
83	83
84		- if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
	84	+ if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
85	85
86	86	$separators = $this->constraintParameterParser->parseSeparatorsParameter(
87	87	$constraint->getConstraintParameters()
88	88	);
89	89
90		- if ( $context->getType() === 'statement' ) {
	90	+ if ($context->getType() === 'statement') {
91	91	$statement = $context->getSnakStatement();
92	92	'@phan-var Statement $statement';
93	93	$result = $this->sparqlHelper->findEntitiesWithSameStatement(
		@@ -96,9 +96,9 @@ discard block
		block discarded – undo
96	96	);
97	97	} else {
98	98	$snak = $context->getSnak();
99		- if ( !$snak instanceof PropertyValueSnak ) {
	99	+ if (!$snak instanceof PropertyValueSnak) {
100	100	// nothing to check
101		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	101	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
102	102	}
103	103	$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
104	104	$context->getEntity()->getId(),
		@@ -111,32 +111,32 @@ discard block
		block discarded – undo
111	111	$otherEntities = $result->getArray();
112	112	$metadata = $result->getMetadata();
113	113
114		- if ( $otherEntities === [] ) {
	114	+ if ($otherEntities === []) {
115	115	$status = CheckResult::STATUS_COMPLIANCE;
116	116	$message = null;
117	117	} else {
118		- $otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
	118	+ $otherEntities = array_values(array_filter($otherEntities)); // remove nulls
119	119	$status = CheckResult::STATUS_VIOLATION;
120		- $message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
121		- ->withEntityIdList( $otherEntities, Role::SUBJECT );
	120	+ $message = (new ViolationMessage('wbqc-violation-message-unique-value'))
	121	+ ->withEntityIdList($otherEntities, Role::SUBJECT);
122	122	}
123	123	} else {
124	124	$status = CheckResult::STATUS_TODO;
125		- $message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
126		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
	125	+ $message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
	126	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
127	127	$metadata = Metadata::blank();
128	128	}
129	129
130		- return ( new CheckResult( $context, $constraint, $status, $message ) )
131		- ->withMetadata( $metadata );
	130	+ return (new CheckResult($context, $constraint, $status, $message))
	131	+ ->withMetadata($metadata);
132	132	}
133	133
134		- public function checkConstraintParameters( Constraint $constraint ) {
	134	+ public function checkConstraintParameters(Constraint $constraint) {
135	135	$constraintParameters = $constraint->getConstraintParameters();
136	136	$exceptions = [];
137	137	try {
138		- $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
139		- } catch ( ConstraintParameterException $e ) {
	138	+ $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
	139	+ } catch (ConstraintParameterException $e) {
140	140	$exceptions[] = $e;
141	141	}
142	142	return $exceptions;

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	* @throws ConstraintParameterException
73	73	* @return CheckResult
74	74	*/
75		- public function checkConstraint( Context $context, Constraint $constraint ) {
	75	+ public function checkConstraint(Context $context, Constraint $constraint) {
76	76	$constraintParameters = $constraint->getConstraintParameters();
77	77	$unitsParameter = $this->constraintParameterParser
78	78	->parseUnitsParameter(
		@@ -81,50 +81,49 @@ discard block
		block discarded – undo
81	81	);
82	82
83	83	$snak = $context->getSnak();
84		- if ( !$snak instanceof PropertyValueSnak ) {
	84	+ if (!$snak instanceof PropertyValueSnak) {
85	85	// nothing to check
86		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	86	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
87	87	}
88	88
89	89	$dataValue = $snak->getDataValue();
90		- if ( !$dataValue instanceof UnboundedQuantityValue ) {
91		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
92		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
93		- ->withDataValueType( 'quantity' );
94		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	90	+ if (!$dataValue instanceof UnboundedQuantityValue) {
	91	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	92	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	93	+ ->withDataValueType('quantity');
	94	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
95	95	}
96	96
97		- if ( $dataValue->getUnit() === '1' ) {
98		- return $this->checkUnitless( $context, $constraint, $unitsParameter, $snak );
	97	+ if ($dataValue->getUnit() === '1') {
	98	+ return $this->checkUnitless($context, $constraint, $unitsParameter, $snak);
99	99	}
100	100
101	101	$status = CheckResult::STATUS_VIOLATION;
102		- $actualUnit = $this->standardize( $dataValue )->getUnit();
103		- foreach ( $unitsParameter->getUnitQuantities() as $unitQuantity ) {
104		- $allowedUnit = $this->standardize( $unitQuantity )->getUnit();
105		- if ( $actualUnit === $allowedUnit ) {
	102	+ $actualUnit = $this->standardize($dataValue)->getUnit();
	103	+ foreach ($unitsParameter->getUnitQuantities() as $unitQuantity) {
	104	+ $allowedUnit = $this->standardize($unitQuantity)->getUnit();
	105	+ if ($actualUnit === $allowedUnit) {
106	106	$status = CheckResult::STATUS_COMPLIANCE;
107	107	break;
108	108	}
109	109	}
110	110
111		- if ( $status === CheckResult::STATUS_VIOLATION ) {
112		- if ( $unitsParameter->getUnitItemIds() === [] ) {
113		- $message = ( new ViolationMessage( 'wbqc-violation-message-units-none' ) )
114		- ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	111	+ if ($status === CheckResult::STATUS_VIOLATION) {
	112	+ if ($unitsParameter->getUnitItemIds() === []) {
	113	+ $message = (new ViolationMessage('wbqc-violation-message-units-none'))
	114	+ ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY);
115	115	} else {
116	116	$messageKey = $unitsParameter->getUnitlessAllowed() ?
117		- 'wbqc-violation-message-units-or-none' :
118		- 'wbqc-violation-message-units';
119		- $message = ( new ViolationMessage( $messageKey ) )
120		- ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
121		- ->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
	117	+ 'wbqc-violation-message-units-or-none' : 'wbqc-violation-message-units';
	118	+ $message = (new ViolationMessage($messageKey))
	119	+ ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	120	+ ->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
122	121	}
123	122	} else {
124	123	$message = null;
125	124	}
126	125
127		- return new CheckResult( $context, $constraint, $status, $message );
	126	+ return new CheckResult($context, $constraint, $status, $message);
128	127	}
129	128
130	129	/**
		@@ -140,17 +139,17 @@ discard block
		block discarded – undo
140	139	UnitsParameter $unitsParameter,
141	140	PropertyValueSnak $snak
142	141	) {
143		- if ( $unitsParameter->getUnitlessAllowed() ) {
	142	+ if ($unitsParameter->getUnitlessAllowed()) {
144	143	$message = null;
145	144	$status = CheckResult::STATUS_COMPLIANCE;
146	145	} else {
147		- $message = ( new ViolationMessage( 'wbqc-violation-message-units' ) )
148		- ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
149		- ->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
	146	+ $message = (new ViolationMessage('wbqc-violation-message-units'))
	147	+ ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	148	+ ->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
150	149	$status = CheckResult::STATUS_VIOLATION;
151	150	}
152	151
153		- return new CheckResult( $context, $constraint, $status, $message );
	152	+ return new CheckResult($context, $constraint, $status, $message);
154	153	}
155	154
156	155	/**
		@@ -159,20 +158,20 @@ discard block
		block discarded – undo
159	158	* @param UnboundedQuantityValue $value
160	159	* @return UnboundedQuantityValue
161	160	*/
162		- private function standardize( UnboundedQuantityValue $value ) {
163		- if ( $this->unitConverter === null ) {
	161	+ private function standardize(UnboundedQuantityValue $value) {
	162	+ if ($this->unitConverter === null) {
164	163	return $value;
165	164	}
166	165
167		- $standard = $this->unitConverter->toStandardUnits( $value );
168		- if ( $standard !== null ) {
	166	+ $standard = $this->unitConverter->toStandardUnits($value);
	167	+ if ($standard !== null) {
169	168	return $standard;
170	169	} else {
171	170	return $value;
172	171	}
173	172	}
174	173
175		- public function checkConstraintParameters( Constraint $constraint ) {
	174	+ public function checkConstraintParameters(Constraint $constraint) {
176	175	$constraintParameters = $constraint->getConstraintParameters();
177	176	$exceptions = [];
178	177	try {
		@@ -181,7 +180,7 @@ discard block
		block discarded – undo
181	180	$constraint->getConstraintTypeItemId(),
182	181	true
183	182	);
184		- } catch ( ConstraintParameterException $e ) {
	183	+ } catch (ConstraintParameterException $e) {
185	184	$exceptions[] = $e;
186	185	}
187	186	return $exceptions;

		@@ -75,9 +75,9 @@ discard block
		block discarded – undo
75	75	* @throws ConstraintParameterException
76	76	* @return CheckResult
77	77	*/
78		- public function checkConstraint( Context $context, Constraint $constraint ) {
79		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
80		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	78	+ public function checkConstraint(Context $context, Constraint $constraint) {
	79	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	80	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
81	81	}
82	82
83	83	$constraintParameters = $constraint->getConstraintParameters();
		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	* a) a property only
100	100	* b) a property and a number of items (each combination of property and item forming an individual claim)
101	101	*/
102		- if ( $items === [] ) {
	102	+ if ($items === []) {
103	103	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
104	104	$context->getEntity()->getStatements(),
105	105	$propertyId
		@@ -112,21 +112,21 @@ discard block
		block discarded – undo
112	112	);
113	113	}
114	114
115		- if ( $requiredStatement !== null ) {
	115	+ if ($requiredStatement !== null) {
116	116	$status = CheckResult::STATUS_COMPLIANCE;
117	117	$message = null;
118	118	} else {
119	119	$status = CheckResult::STATUS_VIOLATION;
120		- $message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
121		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
122		- ->withEntityId( $propertyId, Role::PREDICATE )
123		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	120	+ $message = (new ViolationMessage('wbqc-violation-message-item'))
	121	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	122	+ ->withEntityId($propertyId, Role::PREDICATE)
	123	+ ->withItemIdSnakValueList($items, Role::OBJECT);
124	124	}
125	125
126		- return new CheckResult( $context, $constraint, $status, $message );
	126	+ return new CheckResult($context, $constraint, $status, $message);
127	127	}
128	128
129		- public function checkConstraintParameters( Constraint $constraint ) {
	129	+ public function checkConstraintParameters(Constraint $constraint) {
130	130	$constraintParameters = $constraint->getConstraintParameters();
131	131	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
132	132	$exceptions = [];
		@@ -135,7 +135,7 @@ discard block
		block discarded – undo
135	135	$constraintParameters,
136	136	$constraintTypeItemId
137	137	);
138		- } catch ( ConstraintParameterException $e ) {
	138	+ } catch (ConstraintParameterException $e) {
139	139	$exceptions[] = $e;
140	140	}
141	141	try {
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	$constraintTypeItemId,
145	145	false
146	146	);
147		- } catch ( ConstraintParameterException $e ) {
	147	+ } catch (ConstraintParameterException $e) {
148	148	$exceptions[] = $e;
149	149	}
150	150	return $exceptions;

		@@ -44,16 +44,16 @@
		block discarded – undo
44	44	*
45	45	* @return CheckResult
46	46	*/
47		- public function checkConstraint( Context $context, Constraint $constraint ) {
48		- if ( $context->getType() === Context::TYPE_QUALIFIER ) {
49		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	47	+ public function checkConstraint(Context $context, Constraint $constraint) {
	48	+ if ($context->getType() === Context::TYPE_QUALIFIER) {
	49	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
50	50	} else {
51		- $message = new ViolationMessage( 'wbqc-violation-message-qualifier' );
52		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	51	+ $message = new ViolationMessage('wbqc-violation-message-qualifier');
	52	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
53	53	}
54	54	}
55	55
56		- public function checkConstraintParameters( Constraint $constraint ) {
	56	+ public function checkConstraintParameters(Constraint $constraint) {
57	57	// no parameters
58	58	return [];
59	59	}

		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46	return self::ALL_ENTITY_TYPES_SUPPORTED;
47	47	}
48	48
49		- public function checkConstraint( Context $context, Constraint $constraint ) {
	49	+ public function checkConstraint(Context $context, Constraint $constraint) {
50	50	$constraintParameters = $constraint->getConstraintParameters();
51	51	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
52	52
		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	$constraintTypeItemId
56	56	);
57	57
58		- if ( in_array( $context->getType(), $allowedContextTypes ) ) {
	58	+ if (in_array($context->getType(), $allowedContextTypes)) {
59	59	return new CheckResult(
60	60	$context->getCursor(),
61	61	$constraint,
		@@ -66,15 +66,15 @@ discard block
		block discarded – undo
66	66	$context->getCursor(),
67	67	$constraint,
68	68	CheckResult::STATUS_VIOLATION,
69		- ( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
70		- ->withEntityId( $context->getSnak()->getPropertyId() )
71		- ->withPropertyScope( $context->getType() )
72		- ->withPropertyScopeList( $allowedContextTypes )
	69	+ (new ViolationMessage('wbqc-violation-message-property-scope'))
	70	+ ->withEntityId($context->getSnak()->getPropertyId())
	71	+ ->withPropertyScope($context->getType())
	72	+ ->withPropertyScopeList($allowedContextTypes)
73	73	);
74	74	}
75	75	}
76	76
77		- public function checkConstraintParameters( Constraint $constraint ) {
	77	+ public function checkConstraintParameters(Constraint $constraint) {
78	78	$constraintParameters = $constraint->getConstraintParameters();
79	79	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
80	80	$exceptions = [];
		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	$constraintParameters,
84	84	$constraintTypeItemId
85	85	);
86		- } catch ( ConstraintParameterException $e ) {
	86	+ } catch (ConstraintParameterException $e) {
87	87	$exceptions[] = $e;
88	88	}
89	89	return $exceptions;

		@@ -64,9 +64,9 @@ discard block
		block discarded – undo
64	64	* @throws ConstraintParameterException
65	65	* @return CheckResult
66	66	*/
67		- public function checkConstraint( Context $context, Constraint $constraint ) {
68		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
69		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	67	+ public function checkConstraint(Context $context, Constraint $constraint) {
	68	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	69	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
70	70	}
71	71
72	72	$separators = $this->constraintParameterParser->parseSeparatorsParameter(
		@@ -75,19 +75,19 @@ discard block
		block discarded – undo
75	75
76	76	$propertyId = $context->getSnak()->getPropertyId();
77	77	$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
78		- $context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
	78	+ $context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
79	79	$propertyId
80	80	);
81	81
82		- if ( $propertyCount > 1 ) {
83		- $message = $this->getViolationMessage( $separators, $propertyId );
	82	+ if ($propertyCount > 1) {
	83	+ $message = $this->getViolationMessage($separators, $propertyId);
84	84	$status = CheckResult::STATUS_VIOLATION;
85	85	} else {
86	86	$message = null;
87	87	$status = CheckResult::STATUS_COMPLIANCE;
88	88	}
89	89
90		- return new CheckResult( $context, $constraint, $status, $message );
	90	+ return new CheckResult($context, $constraint, $status, $message);
91	91	}
92	92
93	93	/**
		@@ -95,22 +95,21 @@ discard block
		block discarded – undo
95	95	* @param PropertyId $propertyId
96	96	* @return ViolationMessage
97	97	*/
98		- private function getViolationMessage( array $separators, PropertyId $propertyId ) {
	98	+ private function getViolationMessage(array $separators, PropertyId $propertyId) {
99	99	$messageKey = $separators === [] ?
100		- 'wbqc-violation-message-single-value' :
101		- 'wbqc-violation-message-single-value-separators';
	100	+ 'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
102	101
103		- return ( new ViolationMessage( $messageKey ) )
104		- ->withEntityId( $propertyId )
105		- ->withEntityIdList( $separators );
	102	+ return (new ViolationMessage($messageKey))
	103	+ ->withEntityId($propertyId)
	104	+ ->withEntityIdList($separators);
106	105	}
107	106
108		- public function checkConstraintParameters( Constraint $constraint ) {
	107	+ public function checkConstraintParameters(Constraint $constraint) {
109	108	$constraintParameters = $constraint->getConstraintParameters();
110	109	$exceptions = [];
111	110	try {
112		- $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
113		- } catch ( ConstraintParameterException $e ) {
	111	+ $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
	112	+ } catch (ConstraintParameterException $e) {
114	113	$exceptions[] = $e;
115	114	}
116	115	return $exceptions;

		@@ -33,16 +33,16 @@
		block discarded – undo
33	33	return self::ALL_ENTITY_TYPES_SUPPORTED;
34	34	}
35	35
36		- public function checkConstraint( Context $context, Constraint $constraint ) {
37		- if ( $context->getType() === Context::TYPE_REFERENCE ) {
38		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	36	+ public function checkConstraint(Context $context, Constraint $constraint) {
	37	+ if ($context->getType() === Context::TYPE_REFERENCE) {
	38	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
39	39	} else {
40		- $message = new ViolationMessage( 'wbqc-violation-message-reference' );
41		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	40	+ $message = new ViolationMessage('wbqc-violation-message-reference');
	41	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
42	42	}
43	43	}
44	44
45		- public function checkConstraintParameters( Constraint $constraint ) {
	45	+ public function checkConstraintParameters(Constraint $constraint) {
46	46	// no parameters
47	47	return [];
48	48	}

		@@ -76,9 +76,9 @@ discard block
		block discarded – undo
76	76	* @throws ConstraintParameterException
77	77	* @return CheckResult
78	78	*/
79		- public function checkConstraint( Context $context, Constraint $constraint ) {
80		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
81		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	79	+ public function checkConstraint(Context $context, Constraint $constraint) {
	80	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	81	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
82	82	}
83	83
84	84	$constraintParameters = $constraint->getConstraintParameters();
		@@ -97,22 +97,22 @@ discard block
		block discarded – undo
97	97
98	98	$statementList = $context->getEntity()
99	99	->getStatements()
100		- ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
	100	+ ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
101	101
102	102	/*
103	103	* 'Conflicts with' can be defined with
104	104	* a) a property only
105	105	* b) a property and a number of items (each combination of property and item forming an individual claim)
106	106	*/
107		- if ( $items === [] ) {
	107	+ if ($items === []) {
108	108	$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
109	109	$statementList,
110	110	$propertyId
111	111	);
112		- if ( $offendingStatement !== null ) {
113		- $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
114		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
115		- ->withEntityId( $propertyId, Role::PREDICATE );
	112	+ if ($offendingStatement !== null) {
	113	+ $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
	114	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	115	+ ->withEntityId($propertyId, Role::PREDICATE);
116	116	$status = CheckResult::STATUS_VIOLATION;
117	117	} else {
118	118	$message = null;
		@@ -124,12 +124,12 @@ discard block
		block discarded – undo
124	124	$propertyId,
125	125	$items
126	126	);
127		- if ( $offendingStatement !== null ) {
128		- $offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
129		- $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
130		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
131		- ->withEntityId( $propertyId, Role::PREDICATE )
132		- ->withItemIdSnakValue( $offendingValue, Role::OBJECT );
	127	+ if ($offendingStatement !== null) {
	128	+ $offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
	129	+ $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
	130	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	131	+ ->withEntityId($propertyId, Role::PREDICATE)
	132	+ ->withItemIdSnakValue($offendingValue, Role::OBJECT);
133	133	$status = CheckResult::STATUS_VIOLATION;
134	134	} else {
135	135	$message = null;
		@@ -137,10 +137,10 @@ discard block
		block discarded – undo
137	137	}
138	138	}
139	139
140		- return new CheckResult( $context, $constraint, $status, $message );
	140	+ return new CheckResult($context, $constraint, $status, $message);
141	141	}
142	142
143		- public function checkConstraintParameters( Constraint $constraint ) {
	143	+ public function checkConstraintParameters(Constraint $constraint) {
144	144	$constraintParameters = $constraint->getConstraintParameters();
145	145	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
146	146	$exceptions = [];
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	$constraintParameters,
150	150	$constraintTypeItemId
151	151	);
152		- } catch ( ConstraintParameterException $e ) {
	152	+ } catch (ConstraintParameterException $e) {
153	153	$exceptions[] = $e;
154	154	}
155	155	try {
		@@ -158,7 +158,7 @@ discard block
		block discarded – undo
158	158	$constraintTypeItemId,
159	159	false
160	160	);
161		- } catch ( ConstraintParameterException $e ) {
	161	+ } catch (ConstraintParameterException $e) {
162	162	$exceptions[] = $e;
163	163	}
164	164	return $exceptions;

		@@ -22,7 +22,7 @@ discard block
		block discarded – undo
22	22	*/
23	23	private $constraintParameterParser;
24	24
25		- public function __construct( ConstraintParameterParser $constraintParameterParser ) {
	25	+ public function __construct(ConstraintParameterParser $constraintParameterParser) {
26	26	$this->constraintParameterParser = $constraintParameterParser;
27	27	}
28	28
		@@ -68,9 +68,9 @@ discard block
		block discarded – undo
68	68	* @throws ConstraintParameterException
69	69	* @return CheckResult
70	70	*/
71		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
72		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
73		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	71	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	72	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	73	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
74	74	}
75	75
76	76	$constraintParameters = $constraint->getConstraintParameters();
		@@ -81,26 +81,26 @@ discard block
		block discarded – undo
81	81	);
82	82
83	83	$status = CheckResult::STATUS_VIOLATION;
84		- $message = ( new ViolationMessage( 'wbqc-violation-message-label-lacking' ) )
85		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
86		- ->withLanguages( $languages );
	84	+ $message = (new ViolationMessage('wbqc-violation-message-label-lacking'))
	85	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
	86	+ ->withLanguages($languages);
87	87
88	88	/** @var LabelsProvider $entity */
89	89	$entity = $context->getEntity();
90	90	'@phan-var LabelsProvider $entity';
91	91
92		- foreach ( $languages as $language ) {
93		- if ( $entity->getLabels()->hasTermForLanguage( $language ) ) {
	92	+ foreach ($languages as $language) {
	93	+ if ($entity->getLabels()->hasTermForLanguage($language)) {
94	94	$message = null;
95	95	$status = CheckResult::STATUS_COMPLIANCE;
96	96	break;
97	97	}
98	98	}
99	99
100		- return new CheckResult( $context, $constraint, $status, $message );
	100	+ return new CheckResult($context, $constraint, $status, $message);
101	101	}
102	102
103		- public function checkConstraintParameters( Constraint $constraint ): array {
	103	+ public function checkConstraintParameters(Constraint $constraint): array {
104	104	$constraintParameters = $constraint->getConstraintParameters();
105	105	$exceptions = [];
106	106	try {
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	$constraintParameters,
109	109	$constraint->getConstraintTypeItemId()
110	110	);
111		- } catch ( ConstraintParameterException $e ) {
	111	+ } catch (ConstraintParameterException $e) {
112	112	$exceptions[] = $e;
113	113	}
114	114	return $exceptions;

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( 90c9bb...b00e4a )

Status

Category

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +34 added lines, -35 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch