@@ -21,7 +21,7 @@ discard block |
||
21 | 21 | Statement $statement, |
22 | 22 | Snak $snak |
23 | 23 | ) { |
24 | - parent::__construct( $entity, $snak ); |
|
24 | + parent::__construct($entity, $snak); |
|
25 | 25 | $this->statement = $statement; |
26 | 26 | } |
27 | 27 | |
@@ -29,7 +29,7 @@ discard block |
||
29 | 29 | return self::TYPE_QUALIFIER; |
30 | 30 | } |
31 | 31 | |
32 | - protected function &getMainArray( array &$container ) { |
|
32 | + protected function &getMainArray(array &$container) { |
|
33 | 33 | $statementArray = &$this->getStatementArray( |
34 | 34 | $container, |
35 | 35 | $this->entity->getId()->getSerialization(), |
@@ -37,25 +37,25 @@ discard block |
||
37 | 37 | $this->statement->getGuid() |
38 | 38 | ); |
39 | 39 | |
40 | - if ( !array_key_exists( 'qualifiers', $statementArray ) ) { |
|
40 | + if (!array_key_exists('qualifiers', $statementArray)) { |
|
41 | 41 | $statementArray['qualifiers'] = []; |
42 | 42 | } |
43 | 43 | $qualifiersArray = &$statementArray['qualifiers']; |
44 | 44 | |
45 | 45 | $propertyId = $this->getSnak()->getPropertyId()->getSerialization(); |
46 | - if ( !array_key_exists( $propertyId, $qualifiersArray ) ) { |
|
46 | + if (!array_key_exists($propertyId, $qualifiersArray)) { |
|
47 | 47 | $qualifiersArray[$propertyId] = []; |
48 | 48 | } |
49 | 49 | $propertyArray = &$qualifiersArray[$propertyId]; |
50 | 50 | |
51 | - foreach ( $propertyArray as &$potentialQualifierArray ) { |
|
52 | - if ( $potentialQualifierArray['hash'] === $this->getSnak()->getHash() ) { |
|
51 | + foreach ($propertyArray as &$potentialQualifierArray) { |
|
52 | + if ($potentialQualifierArray['hash'] === $this->getSnak()->getHash()) { |
|
53 | 53 | $qualifierArray = &$potentialQualifierArray; |
54 | 54 | break; |
55 | 55 | } |
56 | 56 | } |
57 | - if ( !isset( $qualifierArray ) ) { |
|
58 | - $qualifierArray = [ 'hash' => $this->getSnak()->getHash() ]; |
|
57 | + if (!isset($qualifierArray)) { |
|
58 | + $qualifierArray = ['hash' => $this->getSnak()->getHash()]; |
|
59 | 59 | $propertyArray[] = &$qualifierArray; |
60 | 60 | } |
61 | 61 |
@@ -28,7 +28,7 @@ discard block |
||
28 | 28 | Reference $reference, |
29 | 29 | Snak $snak |
30 | 30 | ) { |
31 | - parent::__construct( $entity, $snak ); |
|
31 | + parent::__construct($entity, $snak); |
|
32 | 32 | $this->statement = $statement; |
33 | 33 | $this->reference = $reference; |
34 | 34 | } |
@@ -37,7 +37,7 @@ discard block |
||
37 | 37 | return self::TYPE_REFERENCE; |
38 | 38 | } |
39 | 39 | |
40 | - protected function &getMainArray( array &$container ) { |
|
40 | + protected function &getMainArray(array &$container) { |
|
41 | 41 | $statementArray = &$this->getStatementArray( |
42 | 42 | $container, |
43 | 43 | $this->entity->getId()->getSerialization(), |
@@ -45,38 +45,38 @@ discard block |
||
45 | 45 | $this->statement->getGuid() |
46 | 46 | ); |
47 | 47 | |
48 | - if ( !array_key_exists( 'references', $statementArray ) ) { |
|
48 | + if (!array_key_exists('references', $statementArray)) { |
|
49 | 49 | $statementArray['references'] = []; |
50 | 50 | } |
51 | 51 | $referencesArray = &$statementArray['references']; |
52 | 52 | |
53 | - foreach ( $referencesArray as &$potentialReferenceArray ) { |
|
54 | - if ( $potentialReferenceArray['hash'] === $this->reference->getHash() ) { |
|
53 | + foreach ($referencesArray as &$potentialReferenceArray) { |
|
54 | + if ($potentialReferenceArray['hash'] === $this->reference->getHash()) { |
|
55 | 55 | $referenceArray = &$potentialReferenceArray; |
56 | 56 | break; |
57 | 57 | } |
58 | 58 | } |
59 | - if ( !isset( $referenceArray ) ) { |
|
60 | - $referenceArray = [ 'hash' => $this->reference->getHash(), 'snaks' => [] ]; |
|
59 | + if (!isset($referenceArray)) { |
|
60 | + $referenceArray = ['hash' => $this->reference->getHash(), 'snaks' => []]; |
|
61 | 61 | $referencesArray[] = &$referenceArray; |
62 | 62 | } |
63 | 63 | |
64 | 64 | $snaksArray = &$referenceArray['snaks']; |
65 | 65 | |
66 | 66 | $propertyId = $this->getSnak()->getPropertyId()->getSerialization(); |
67 | - if ( !array_key_exists( $propertyId, $snaksArray ) ) { |
|
67 | + if (!array_key_exists($propertyId, $snaksArray)) { |
|
68 | 68 | $snaksArray[$propertyId] = []; |
69 | 69 | } |
70 | 70 | $propertyArray = &$snaksArray[$propertyId]; |
71 | 71 | |
72 | - foreach ( $propertyArray as &$potentialSnakArray ) { |
|
73 | - if ( $potentialSnakArray['hash'] === $this->getSnak()->getHash() ) { |
|
72 | + foreach ($propertyArray as &$potentialSnakArray) { |
|
73 | + if ($potentialSnakArray['hash'] === $this->getSnak()->getHash()) { |
|
74 | 74 | $snakArray = &$potentialSnakArray; |
75 | 75 | break; |
76 | 76 | } |
77 | 77 | } |
78 | - if ( !isset( $snakArray ) ) { |
|
79 | - $snakArray = [ 'hash' => $this->getSnak()->getHash() ]; |
|
78 | + if (!isset($snakArray)) { |
|
79 | + $snakArray = ['hash' => $this->getSnak()->getHash()]; |
|
80 | 80 | $propertyArray[] = &$snakArray; |
81 | 81 | } |
82 | 82 |
@@ -25,22 +25,22 @@ |
||
25 | 25 | */ |
26 | 26 | const NULL_PROPERTY_ID = 'P2147483647'; |
27 | 27 | |
28 | - public function __construct( Context $context ) { |
|
28 | + public function __construct(Context $context) { |
|
29 | 29 | $constraint = new Constraint( |
30 | 30 | 'null', |
31 | - new PropertyId( self::NULL_PROPERTY_ID ), |
|
31 | + new PropertyId(self::NULL_PROPERTY_ID), |
|
32 | 32 | 'none', |
33 | 33 | [] |
34 | 34 | ); |
35 | - parent::__construct( $context, $constraint ); |
|
35 | + parent::__construct($context, $constraint); |
|
36 | 36 | } |
37 | 37 | |
38 | 38 | public function getConstraint() { |
39 | - throw new DomainException( 'NullResult holds no constraint' ); |
|
39 | + throw new DomainException('NullResult holds no constraint'); |
|
40 | 40 | } |
41 | 41 | |
42 | 42 | public function getConstraintId() { |
43 | - throw new DomainException( 'NullResult holds no constraint' ); |
|
43 | + throw new DomainException('NullResult holds no constraint'); |
|
44 | 44 | } |
45 | 45 | |
46 | 46 | } |
@@ -22,7 +22,7 @@ discard block |
||
22 | 22 | * @throws ConstraintParameterException if the constraint parameters are invalid |
23 | 23 | * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs |
24 | 24 | */ |
25 | - public function checkConstraint( Context $context, Constraint $constraint ); |
|
25 | + public function checkConstraint(Context $context, Constraint $constraint); |
|
26 | 26 | |
27 | 27 | /** |
28 | 28 | * Check if the constraint parameters of $constraint are valid. |
@@ -33,6 +33,6 @@ discard block |
||
33 | 33 | * |
34 | 34 | * @return ConstraintParameterException[] |
35 | 35 | */ |
36 | - public function checkConstraintParameters( Constraint $constraint ); |
|
36 | + public function checkConstraintParameters(Constraint $constraint); |
|
37 | 37 | |
38 | 38 | } |
@@ -28,16 +28,16 @@ |
||
28 | 28 | * |
29 | 29 | * @return CheckResult |
30 | 30 | */ |
31 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
32 | - if ( $context->getType() === Context::TYPE_QUALIFIER ) { |
|
33 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE, '' ); |
|
31 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
32 | + if ($context->getType() === Context::TYPE_QUALIFIER) { |
|
33 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE, ''); |
|
34 | 34 | } else { |
35 | - $message = wfMessage( 'wbqc-violation-message-qualifier' )->escaped(); |
|
36 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message ); |
|
35 | + $message = wfMessage('wbqc-violation-message-qualifier')->escaped(); |
|
36 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message); |
|
37 | 37 | } |
38 | 38 | } |
39 | 39 | |
40 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
40 | + public function checkConstraintParameters(Constraint $constraint) { |
|
41 | 41 | // no parameters |
42 | 42 | return []; |
43 | 43 | } |
@@ -10,7 +10,7 @@ |
||
10 | 10 | class SparqlHelperException extends RuntimeException { |
11 | 11 | |
12 | 12 | public function __construct() { |
13 | - parent::__construct( 'The SPARQL query endpoint returned an error.' ); |
|
13 | + parent::__construct('The SPARQL query endpoint returned an error.'); |
|
14 | 14 | } |
15 | 15 | |
16 | 16 | } |
@@ -16,8 +16,8 @@ |
||
16 | 16 | /** |
17 | 17 | * @param string $message HTML |
18 | 18 | */ |
19 | - public function __construct( $message ) { |
|
20 | - parent::__construct( $message ); |
|
19 | + public function __construct($message) { |
|
20 | + parent::__construct($message); |
|
21 | 21 | } |
22 | 22 | |
23 | 23 | } |
@@ -24,14 +24,14 @@ |
||
24 | 24 | * |
25 | 25 | * @return int[] |
26 | 26 | */ |
27 | - public function getPropertyCount( StatementList $statements ) { |
|
28 | - if ( !isset( $this->propertyCount ) ) { |
|
27 | + public function getPropertyCount(StatementList $statements) { |
|
28 | + if (!isset($this->propertyCount)) { |
|
29 | 29 | $this->propertyCount = []; |
30 | 30 | |
31 | 31 | /** @var Statement $statement */ |
32 | - foreach ( $statements as $statement ) { |
|
32 | + foreach ($statements as $statement) { |
|
33 | 33 | $counter = $statement->getRank() === Statement::RANK_DEPRECATED ? 0 : 1; |
34 | - if ( array_key_exists( $statement->getPropertyId()->getSerialization(), $this->propertyCount ) ) { |
|
34 | + if (array_key_exists($statement->getPropertyId()->getSerialization(), $this->propertyCount)) { |
|
35 | 35 | $this->propertyCount[$statement->getPropertyId()->getSerialization()] += $counter; |
36 | 36 | } else { |
37 | 37 | $this->propertyCount[$statement->getPropertyId()->getSerialization()] = $counter; |
@@ -48,8 +48,8 @@ discard block |
||
48 | 48 | $this->dataFactory = $dataFactory; |
49 | 49 | $this->logger = $logger; |
50 | 50 | $this->constraintCheckDurationLimits = [ |
51 | - 'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ), |
|
52 | - 'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ), |
|
51 | + 'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'), |
|
52 | + 'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'), |
|
53 | 53 | ]; |
54 | 54 | } |
55 | 55 | |
@@ -75,41 +75,41 @@ discard block |
||
75 | 75 | $durationSeconds, |
76 | 76 | $method |
77 | 77 | ) { |
78 | - $constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 ); |
|
78 | + $constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1); |
|
79 | 79 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
80 | 80 | |
81 | 81 | $this->dataFactory->timing( |
82 | - 'wikibase.quality.constraints.check.timing.' . |
|
83 | - $constraintTypeItemId . '-' . |
|
82 | + 'wikibase.quality.constraints.check.timing.'. |
|
83 | + $constraintTypeItemId.'-'. |
|
84 | 84 | $constraintCheckerClassShortName, |
85 | 85 | $durationSeconds * 1000 |
86 | 86 | ); |
87 | 87 | |
88 | 88 | // find the longest limit (and associated log level) that the duration exceeds |
89 | - foreach ( $this->constraintCheckDurationLimits as $level => $limit ) { |
|
89 | + foreach ($this->constraintCheckDurationLimits as $level => $limit) { |
|
90 | 90 | if ( |
91 | 91 | // duration exceeds this limit |
92 | - isset( $limit ) && $durationSeconds > $limit && |
|
92 | + isset($limit) && $durationSeconds > $limit && |
|
93 | 93 | // this limit is longer than previous longest limit |
94 | - ( !isset( $limitSeconds ) || $limit > $limitSeconds ) |
|
94 | + (!isset($limitSeconds) || $limit > $limitSeconds) |
|
95 | 95 | ) { |
96 | 96 | $limitSeconds = $limit; |
97 | 97 | $logLevel = $level; |
98 | 98 | } |
99 | 99 | } |
100 | 100 | |
101 | - if ( !isset( $limitSeconds ) ) { |
|
101 | + if (!isset($limitSeconds)) { |
|
102 | 102 | return; |
103 | 103 | } |
104 | - if ( $context->getType() !== Context::TYPE_STATEMENT ) { |
|
104 | + if ($context->getType() !== Context::TYPE_STATEMENT) { |
|
105 | 105 | // TODO log less details but still log something |
106 | 106 | return; |
107 | 107 | } |
108 | 108 | |
109 | 109 | $this->logger->log( |
110 | 110 | $logLevel, |
111 | - 'Constraint check with {constraintCheckerClassShortName} ' . |
|
112 | - 'took longer than {limitSeconds} second(s) ' . |
|
111 | + 'Constraint check with {constraintCheckerClassShortName} '. |
|
112 | + 'took longer than {limitSeconds} second(s) '. |
|
113 | 113 | '(duration: {durationSeconds} seconds).', |
114 | 114 | [ |
115 | 115 | 'method' => $method, |