wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/ConflictsWithChecker.php

Spacing +19 added lines, -19 removed lines

@@ -76,9 +76,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -97,22 +97,22 @@ 
 
 		$statementList = $context->getEntity()
 			->getStatements()
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 
 		/*
 		 * 'Conflicts with' can be defined with
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$statementList,
 				$propertyId
 			);
-			if ( $offendingStatement !== null ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE );
+			if ($offendingStatement !== null) {
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -124,12 +124,12 @@ 
 				$propertyId,
 				$items
 			);
-			if ( $offendingStatement !== null ) {
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE )
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
+			if ($offendingStatement !== null) {
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE)
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -137,10 +137,10 @@ 
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -149,7 +149,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -158,7 +158,7 @@ 
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/CommonsLinkChecker.php

Spacing +42 added lines, -42 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker;
 
@@ -74,26 +74,26 @@ 
 	 * @return array first element is the namespace number (default namespace for TitleParser),
 	 * second element is a string to prepend to the title before giving it to the TitleParser
 	 */
-	private function getCommonsNamespace( string $namespace ): array {
-		switch ( $namespace ) {
+	private function getCommonsNamespace(string $namespace): array {
+		switch ($namespace) {
 			case '':
-				return [ NS_MAIN, '' ];
+				return [NS_MAIN, ''];
 			// extra namespaces, see operations/mediawiki-config.git,
 			// wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey
 			case 'Creator':
-				return [ 100, '' ];
+				return [100, ''];
 			case 'TimedText':
-				return [ 102, '' ];
+				return [102, ''];
 			case 'Sequence':
-				return [ 104, '' ];
+				return [104, ''];
 			case 'Institution':
-				return [ 106, '' ];
+				return [106, ''];
 			// extension namespace, see mediawiki/extensions/JsonConfig.git,
 			// extension.json, 'namespaces' key, third element
 			case 'Data':
-				return [ 486, '' ];
+				return [486, ''];
 			default:
-				return [ NS_MAIN, $namespace . ':' ];
+				return [NS_MAIN, $namespace.':'];
 		}
 	}
 
@@ -102,7 +102,7 @@ 
 	 *
 	 * @throws ConstraintParameterException
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -113,9 +113,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -125,52 +125,52 @@ 
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
 		 *   parameter $namespace can be null, works for commons galleries
 		 */
-		if ( $dataValue->getType() !== 'string' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'string' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'string') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('string');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$commonsLink = $dataValue->getValue();
-		if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-				new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
+		if (!$this->commonsLinkIsWellFormed($commonsLink)) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+				new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
 		}
 
-		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty( $snak->getPropertyId() );
-		switch ( $dataType ) {
+		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty($snak->getPropertyId());
+		switch ($dataType) {
 			case 'geo-shape':
 			case 'tabular-data':
-				if ( strpos( $commonsLink, $namespace . ':' ) !== 0 ) {
-					return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-						new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
+				if (strpos($commonsLink, $namespace.':') !== 0) {
+					return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+						new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
 				}
 				$pageName = $commonsLink;
 				break;
 			default:
-				$pageName = $namespace ? $namespace . ':' . $commonsLink : $commonsLink;
+				$pageName = $namespace ? $namespace.':'.$commonsLink : $commonsLink;
 				break;
 		}
 
-		$prefix = $this->getCommonsNamespace( $namespace )[1];
+		$prefix = $this->getCommonsNamespace($namespace)[1];
 		$normalizedTitle = $this->pageNameNormalizer->normalizePageName(
 			$pageName,
 			'https://commons.wikimedia.org/w/api.php'
 		);
-		if ( $normalizedTitle === false ) {
-			if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
-				return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-					new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
+		if ($normalizedTitle === false) {
+			if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
+				return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+					new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
 			}
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-				new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ) );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+				new ViolationMessage('wbqc-violation-message-commons-link-no-existent'));
 		}
 
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE, null );
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE, null);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -179,15 +179,15 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
 	}
 
-	private function commonsLinkIsWellFormed( string $commonsLink ): bool {
-		$toReplace = [ "_", "%20" ];
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
+	private function commonsLinkIsWellFormed(string $commonsLink): bool {
+		$toReplace = ["_", "%20"];
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
 
 		return $commonsLink === $compareString;
 	}
@@ -196,9 +196,9 @@ 
 	 * Checks whether the value of the statement already includes the namespace.
 	 * This special case should be reported as “malformed title” instead of “title does not exist”.
 	 */
-	private function valueIncludesNamespace( string $value, string $namespace ): bool {
+	private function valueIncludesNamespace(string $value, string $namespace): bool {
 		return $namespace !== '' &&
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
 	}
 
 }

src/Html/HtmlTableBuilder.php

Spacing +33 added lines, -33 removed lines

@@ -32,9 +32,9 @@ 
 	/**
 	 * @param array $headers
 	 */
-	public function __construct( array $headers ) {
-		foreach ( $headers as $header ) {
-			$this->addHeader( $header );
+	public function __construct(array $headers) {
+		foreach ($headers as $header) {
+			$this->addHeader($header);
 		}
 	}
 
@@ -43,16 +43,16 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function addHeader( $header ) {
-		Assert::parameterType( [ 'string', HtmlTableHeaderBuilder::class ], $header, '$header' );
+	private function addHeader($header) {
+		Assert::parameterType(['string', HtmlTableHeaderBuilder::class], $header, '$header');
 
-		if ( is_string( $header ) ) {
-			$header = new HtmlTableHeaderBuilder( $header );
+		if (is_string($header)) {
+			$header = new HtmlTableHeaderBuilder($header);
 		}
 
 		$this->headers[] = $header;
 
-		if ( $header->getIsSortable() ) {
+		if ($header->getIsSortable()) {
 			$this->isSortable = true;
 		}
 	}
@@ -85,12 +85,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function appendRow( array $cells ) {
-		foreach ( $cells as $key => $cell ) {
-			if ( is_string( $cell ) ) {
-				$cells[$key] = new HtmlTableCellBuilder( $cell );
-			} elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) {
-				throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' );
+	public function appendRow(array $cells) {
+		foreach ($cells as $key => $cell) {
+			if (is_string($cell)) {
+				$cells[$key] = new HtmlTableCellBuilder($cell);
+			} elseif (!($cell instanceof HtmlTableCellBuilder)) {
+				throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.');
 			}
 		}
 
@@ -104,13 +104,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function appendRows( array $rows ) {
-		foreach ( $rows as $cells ) {
-			if ( !is_array( $cells ) ) {
-				throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' );
+	public function appendRows(array $rows) {
+		foreach ($rows as $cells) {
+			if (!is_array($cells)) {
+				throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.');
 			}
 
-			$this->appendRow( $cells );
+			$this->appendRow($cells);
 		}
 	}
 
@@ -122,38 +122,38 @@ 
 	public function toHtml() {
 		// Open table
 		$tableClasses = 'wikitable';
-		if ( $this->isSortable ) {
+		if ($this->isSortable) {
 			$tableClasses .= ' sortable';
 		}
-		$html = Html::openElement( 'table', [ 'class' => $tableClasses ] );
+		$html = Html::openElement('table', ['class' => $tableClasses]);
 
 		// Write headers
-		$html .= Html::openElement( 'thead' );
-		$html .= Html::openElement( 'tr' );
-		foreach ( $this->headers as $header ) {
+		$html .= Html::openElement('thead');
+		$html .= Html::openElement('tr');
+		foreach ($this->headers as $header) {
 			$html .= $header->toHtml();
 		}
-		$html .= Html::closeElement( 'tr' );
-		$html .= Html::closeElement( 'thead' );
-		$html .= Html::openElement( 'tbody' );
+		$html .= Html::closeElement('tr');
+		$html .= Html::closeElement('thead');
+		$html .= Html::openElement('tbody');
 
 		// Write rows
-		foreach ( $this->rows as $row ) {
-			$html .= Html::openElement( 'tr' );
+		foreach ($this->rows as $row) {
+			$html .= Html::openElement('tr');
 
 			/**
 			 * @var HtmlTableCellBuilder $cell
 			 */
-			foreach ( $row as $cell ) {
+			foreach ($row as $cell) {
 				$html .= $cell->toHtml();
 			}
 
-			$html .= Html::closeElement( 'tr' );
+			$html .= Html::closeElement('tr');
 		}
 
 		// Close table
-		$html .= Html::closeElement( 'tbody' );
-		$html .= Html::closeElement( 'table' );
+		$html .= Html::closeElement('tbody');
+		$html .= Html::closeElement('table');
 
 		return $html;
 	}

src/Html/HtmlTableCellBuilder.php

Spacing +4 added lines, -4 removed lines

@@ -31,8 +31,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, array $attributes = [] ) {
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
+	public function __construct($content, array $attributes = []) {
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
 
 		$this->content = $content;
 		$this->attributes = $attributes;
@@ -42,7 +42,7 @@ 
 	 * @return string HTML
 	 */
 	public function getContent() {
-		return HtmlArmor::getHtml( $this->content );
+		return HtmlArmor::getHtml($this->content);
 	}
 
 	/**
@@ -56,7 +56,7 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		return Html::rawElement( 'td', $this->getAttributes(), $this->getContent() );
+		return Html::rawElement('td', $this->getAttributes(), $this->getContent());
 	}
 
 }

src/WikibaseQualityConstraintsHooks.php

Spacing +35 added lines, -35 removed lines

@@ -26,8 +26,8 @@ 
 	BeforePageDisplayHook
 {
 
-	public static function onWikibaseChange( Change $change ) {
-		if ( !( $change instanceof EntityChange ) ) {
+	public static function onWikibaseChange(Change $change) {
+		if (!($change instanceof EntityChange)) {
 			return;
 		}
 		/** @var EntityChange $change */
@@ -38,48 +38,48 @@ 
 
 		// If jobs are enabled and the results would be stored in some way run a job.
 		if (
-			$config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) &&
-			$config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) &&
+			$config->get('WBQualityConstraintsEnableConstraintsCheckJobs') &&
+			$config->get('WBQualityConstraintsCacheCheckConstraintsResults') &&
 			self::isSelectedForJobRunBasedOnPercentage()
 		) {
-			$params = [ 'entityId' => $change->getEntityId()->getSerialization() ];
+			$params = ['entityId' => $change->getEntityId()->getSerialization()];
 			$jobQueueGroup->lazyPush(
-				new JobSpecification( CheckConstraintsJob::COMMAND, $params )
+				new JobSpecification(CheckConstraintsJob::COMMAND, $params)
 			);
 		}
 
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-			self::isConstraintStatementsChange( $config, $change )
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
+			self::isConstraintStatementsChange($config, $change)
 		) {
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
 			$metadata = $change->getMetadata();
-			if ( array_key_exists( 'rev_id', $metadata ) ) {
+			if (array_key_exists('rev_id', $metadata)) {
 				$params['revisionId'] = $metadata['rev_id'];
 			}
 			$jobQueueGroup->push(
-				new JobSpecification( 'constraintsTableUpdate', $params )
+				new JobSpecification('constraintsTableUpdate', $params)
 			);
 		}
 	}
 
 	private static function isSelectedForJobRunBasedOnPercentage() {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		$percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' );
+		$percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio');
 
-		return mt_rand( 1, 100 ) <= $percentage;
+		return mt_rand(1, 100) <= $percentage;
 	}
 
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
-		if ( !( $change instanceof EntityChange ) ||
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
+		if (!($change instanceof EntityChange) ||
 			 $change->getAction() !== EntityChange::UPDATE ||
-			 !( $change->getEntityId() instanceof NumericPropertyId )
+			 !($change->getEntityId() instanceof NumericPropertyId)
 		) {
 			return false;
 		}
 
 		$info = $change->getInfo();
 
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
+		if (!array_key_exists('compactDiff', $info)) {
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
 			// so we only know that the change *might* affect the constraint statements
 			return true;
@@ -88,50 +88,50 @@ 
 		/** @var EntityDiffChangedAspects $aspects */
 		$aspects = $info['compactDiff'];
 
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
 	}
 
-	public function onArticlePurge( $wikiPage ) {
+	public function onArticlePurge($wikiPage) {
 		$entityContentFactory = WikibaseRepo::getEntityContentFactory();
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
 			$entityIdLookup = WikibaseRepo::getEntityIdLookup();
-			$entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() );
-			if ( $entityId !== null ) {
+			$entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle());
+			if ($entityId !== null) {
 				$resultsCache = ResultsCache::getDefaultInstance();
-				$resultsCache->delete( $entityId );
+				$resultsCache->delete($entityId);
 			}
 		}
 	}
 
-	public function onBeforePageDisplay( $out, $skin ): void {
+	public function onBeforePageDisplay($out, $skin): void {
 		$lookup = WikibaseRepo::getEntityNamespaceLookup();
 		$title = $out->getTitle();
-		if ( $title === null ) {
+		if ($title === null) {
 			return;
 		}
 
-		if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) {
+		if (!$lookup->isNamespaceWithEntities($title->getNamespace())) {
 			return;
 		}
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
 			return;
 		}
 
 		$services = MediaWikiServices::getInstance();
 		$config = $services->getMainConfig();
 
-		$isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) &&
-			$services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView();
-		if ( $isMobileView ) {
+		$isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') &&
+			$services->getService('MobileFrontend.Context')->shouldDisplayMobileView();
+		if ($isMobileView) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
+		$out->addModules('wikibase.quality.constraints.suggestions');
 
-		if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' )
-			|| $out->getUser()->isRegistered() ) {
-				$out->addModules( 'wikibase.quality.constraints.gadget' );
+		if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers')
+			|| $out->getUser()->isRegistered()) {
+				$out->addModules('wikibase.quality.constraints.gadget');
 		}
 	}
 

src/ConstraintCheck/Checker/QualifiersChecker.php

Spacing +17 added lines, -17 removed lines

@@ -67,9 +67,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -84,33 +84,33 @@ 
 		$status = CheckResult::STATUS_COMPLIANCE;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
 			$allowedQualifier = false;
-			foreach ( $properties as $property ) {
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
+			foreach ($properties as $property) {
+				if ($qualifier->getPropertyId()->equals($property)) {
 					$allowedQualifier = true;
 					break;
 				}
 			}
-			if ( !$allowedQualifier ) {
-				if ( $properties === [] || $properties === [ '' ] ) {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+			if (!$allowedQualifier) {
+				if ($properties === [] || $properties === ['']) {
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 				} else {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
 				}
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -119,7 +119,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/Api/CheckConstraintParameters.php

Spacing +47 added lines, -47 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -79,9 +79,9 @@ 
 		StatementGuidParser $statementGuidParser,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->languageFallbackChainFactory = $languageFallbackChainFactory;
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
 		$this->violationMessageRendererFactory = $violationMessageRendererFactory;
@@ -97,39 +97,39 @@ 
 		$params = $this->extractRequestParams();
 		$result = $this->getResult();
 
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
 
-		$this->checkPropertyIds( $propertyIds, $result );
-		$this->checkConstraintIds( $constraintIds, $result );
+		$this->checkPropertyIds($propertyIds, $result);
+		$this->checkConstraintIds($constraintIds, $result);
 
-		$result->addValue( null, 'success', 1 );
+		$result->addValue(null, 'success', 1);
 	}
 
 	/**
 	 * @param array|null $propertyIdSerializations
 	 * @return NumericPropertyId[]
 	 */
-	private function parsePropertyIds( ?array $propertyIdSerializations ): array {
-		if ( $propertyIdSerializations === null ) {
+	private function parsePropertyIds(?array $propertyIdSerializations): array {
+		if ($propertyIdSerializations === null) {
 			return [];
-		} elseif ( $propertyIdSerializations === [] ) {
+		} elseif ($propertyIdSerializations === []) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $propertyIdSerialization ) {
+			function($propertyIdSerialization) {
 				try {
-					return new NumericPropertyId( $propertyIdSerialization );
-				} catch ( InvalidArgumentException $e ) {
+					return new NumericPropertyId($propertyIdSerialization);
+				} catch (InvalidArgumentException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid id: $propertyIdSerialization",
 						'invalid-property-id',
 						0, // default argument
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
 					);
 				}
 			},
@@ -141,35 +141,35 @@ 
 	 * @param array|null $constraintIds
 	 * @return string[]
 	 */
-	private function parseConstraintIds( ?array $constraintIds ): array {
-		if ( $constraintIds === null ) {
+	private function parseConstraintIds(?array $constraintIds): array {
+		if ($constraintIds === null) {
 			return [];
-		} elseif ( $constraintIds === [] ) {
+		} elseif ($constraintIds === []) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $constraintId ) {
+			function($constraintId) {
 				try {
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-					if ( !$propertyId instanceof NumericPropertyId ) {
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+					if (!$propertyId instanceof NumericPropertyId) {
 						$this->apiErrorReporter->dieError(
 							"Invalid property ID: {$propertyId->getSerialization()}",
 							'invalid-property-id',
 							0, // default argument
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
 						);
 					}
 					return $constraintId;
-				} catch ( StatementGuidParsingException $e ) {
+				} catch (StatementGuidParsingException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid statement GUID: $constraintId",
 						'invalid-guid',
 						0, // default argument
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
 					);
 				}
 			},
@@ -181,12 +181,12 @@ 
 	 * @param NumericPropertyId[] $propertyIds
 	 * @param ApiResult $result
 	 */
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ): void {
-		foreach ( $propertyIds as $propertyId ) {
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
+	private function checkPropertyIds(array $propertyIds, ApiResult $result): void {
+		foreach ($propertyIds as $propertyId) {
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
 			$allConstraintExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnPropertyId( $propertyId );
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
+				->checkConstraintParametersOnPropertyId($propertyId);
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
 				$this->addConstraintParameterExceptionsToResult(
 					$constraintId,
 					$constraintParameterExceptions,
@@ -200,15 +200,15 @@ 
 	 * @param string[] $constraintIds
 	 * @param ApiResult $result
 	 */
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ): void {
-		foreach ( $constraintIds as $constraintId ) {
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
+	private function checkConstraintIds(array $constraintIds, ApiResult $result): void {
+		foreach ($constraintIds as $constraintId) {
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
 				// already checked as part of checkPropertyIds()
 				continue;
 			}
 			$constraintParameterExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnConstraintId( $constraintId );
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+				->checkConstraintParametersOnConstraintId($constraintId);
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 		}
 	}
 
@@ -216,18 +216,18 @@ 
 	 * @param NumericPropertyId $propertyId
 	 * @return string[]
 	 */
-	private function getResultPathForPropertyId( NumericPropertyId $propertyId ): array {
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
+	private function getResultPathForPropertyId(NumericPropertyId $propertyId): array {
+		return [$this->getModuleName(), $propertyId->getSerialization()];
 	}
 
 	/**
 	 * @param string $constraintId
 	 * @return string[]
 	 */
-	private function getResultPathForConstraintId( string $constraintId ): array {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
+	private function getResultPathForConstraintId(string $constraintId): array {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
 		'@phan-var NumericPropertyId $propertyId';
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
 	}
 
 	/**
@@ -242,8 +242,8 @@ 
 		?array $constraintParameterExceptions,
 		ApiResult $result
 	): void {
-		$path = $this->getResultPathForConstraintId( $constraintId );
-		if ( $constraintParameterExceptions === null ) {
+		$path = $this->getResultPathForConstraintId($constraintId);
+		if ($constraintParameterExceptions === null) {
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
@@ -260,11 +260,11 @@ 
 			$violationMessageRenderer = $this->violationMessageRendererFactory
 				->getViolationMessageRenderer(
 					$language,
-					$this->languageFallbackChainFactory->newFromLanguage( $language ),
+					$this->languageFallbackChainFactory->newFromLanguage($language),
 					$this
 				);
 			$problems = [];
-			foreach ( $constraintParameterExceptions as $constraintParameterException ) {
+			foreach ($constraintParameterExceptions as $constraintParameterException) {
 				$problems[] = [
 					self::KEY_MESSAGE_HTML => $violationMessageRenderer->render(
 						$constraintParameterException->getViolationMessage() ),
@@ -303,8 +303,8 @@ 
 		return [
 			'action=wbcheckconstraintparameters&propertyid=P247'
 				=> 'apihelp-wbcheckconstraintparameters-example-propertyid-1',
-			'action=wbcheckconstraintparameters&' .
-			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' .
+			'action=wbcheckconstraintparameters&'.
+			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'.
 			'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f'
 				=> 'apihelp-wbcheckconstraintparameters-example-constraintid-2',
 		];

src/ConstraintCheck/Checker/RangeChecker.php

Spacing +34 added lines, -34 removed lines

@@ -81,30 +81,30 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
 
-		[ $min, $max ] = $this->parseRangeParameter(
+		[$min, $max] = $this->parseRangeParameter(
 			$constraintParameters,
 			$constraint->getConstraintTypeItemId(),
 			$dataValue->getType()
 		);
 
-		if ( $this->rangeCheckerHelper->getComparison( $min, $dataValue ) > 0 ||
-			 $this->rangeCheckerHelper->getComparison( $dataValue, $max ) > 0
+		if ($this->rangeCheckerHelper->getComparison($min, $dataValue) > 0 ||
+			 $this->rangeCheckerHelper->getComparison($dataValue, $max) > 0
 		) {
 			$message = $this->getViolationMessage(
 				$context->getSnak()->getPropertyId(),
@@ -120,16 +120,16 @@ 
 
 		if (
 			$dataValue instanceof TimeValue &&
-			( $min instanceof NowValue || $max instanceof NowValue ) &&
-			$this->rangeCheckerHelper->isFutureTime( $dataValue )
+			($min instanceof NowValue || $max instanceof NowValue) &&
+			$this->rangeCheckerHelper->isFutureTime($dataValue)
 		) {
-			$dependencyMetadata = DependencyMetadata::ofFutureTime( $dataValue );
+			$dependencyMetadata = DependencyMetadata::ofFutureTime($dataValue);
 		} else {
 			$dependencyMetadata = DependencyMetadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata( $dependencyMetadata ) );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata($dependencyMetadata));
 	}
 
 	/**
@@ -140,8 +140,8 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
 	 */
-	private function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) {
-		switch ( $type ) {
+	private function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) {
+		switch ($type) {
 			case 'quantity':
 				return $this->constraintParameterParser->parseQuantityRangeParameter(
 					$constraintParameters,
@@ -155,10 +155,10 @@ 
 		}
 
 		throw new ConstraintParameterException(
-			( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'quantity' )
-				->withDataValueType( 'time' )
+			(new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('quantity')
+				->withDataValueType('time')
 		);
 	}
 
@@ -170,7 +170,7 @@ 
 	 *
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( PropertyId $predicate, DataValue $value, $min, $max ) {
+	private function getViolationMessage(PropertyId $predicate, DataValue $value, $min, $max) {
 		// possible message keys:
 		// wbqc-violation-message-range-quantity-closed
 		// wbqc-violation-message-range-quantity-leftopen
@@ -183,39 +183,39 @@ 
 		// wbqc-violation-message-range-time-rightopen
 		// wbqc-violation-message-range-time-rightopen-leftnow
 		$messageKey = 'wbqc-violation-message-range';
-		$messageKey .= '-' . $value->getType();
+		$messageKey .= '-'.$value->getType();
 		// at least one of $min, $max is set, otherwise there could be no violation
-		$messageKey .= '-' . ( $min !== null ? ( $max !== null ? 'closed' : 'rightopen' ) : 'leftopen' );
-		if ( $min instanceof NowValue ) {
+		$messageKey .= '-'.($min !== null ? ($max !== null ? 'closed' : 'rightopen') : 'leftopen');
+		if ($min instanceof NowValue) {
 			$messageKey .= '-leftnow';
-		} elseif ( $max instanceof NowValue ) {
+		} elseif ($max instanceof NowValue) {
 			$messageKey .= '-rightnow';
 		}
-		$message = ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $predicate, Role::PREDICATE )
-			->withDataValue( $value, Role::OBJECT );
-		if ( $min !== null && !( $min instanceof NowValue ) ) {
-			$message = $message->withDataValue( $min, Role::OBJECT );
+		$message = (new ViolationMessage($messageKey))
+			->withEntityId($predicate, Role::PREDICATE)
+			->withDataValue($value, Role::OBJECT);
+		if ($min !== null && !($min instanceof NowValue)) {
+			$message = $message->withDataValue($min, Role::OBJECT);
 		}
-		if ( $max !== null && !( $max instanceof NowValue ) ) {
-			$message = $message->withDataValue( $max, Role::OBJECT );
+		if ($max !== null && !($max instanceof NowValue)) {
+			$message = $message->withDataValue($max, Role::OBJECT);
 		}
 		return $message;
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
 			// we don’t have a data value here, so get the type from the property instead
 			// (the distinction between data type and data value type is irrelevant for 'quantity' and 'time')
-			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty( $constraint->getPropertyId() );
+			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty($constraint->getPropertyId());
 			$this->parseRangeParameter(
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId(),
 				$type
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/DiffWithinRangeChecker.php

Spacing +36 added lines, -37 removed lines

@@ -73,8 +73,8 @@ 
 	 * @throws ConstraintParameterException
 	 * @return array [ DataValue|null $min, DataValue|null $max, NumericPropertyId $property ]
 	 */
-	private function parseConstraintParameters( Constraint $constraint ) {
-		[ $min, $max ] = $this->constraintParameterParser->parseQuantityRangeParameter(
+	private function parseConstraintParameters(Constraint $constraint) {
+		[$min, $max] = $this->constraintParameterParser->parseQuantityRangeParameter(
 			$constraint->getConstraintParameters(),
 			$constraint->getConstraintTypeItemId()
 		);
@@ -83,7 +83,7 @@ 
 			$constraint->getConstraintTypeItemId()
 		);
 
-		return [ $min, $max, $property ];
+		return [$min, $max, $property];
 	}
 
 	/**
@@ -93,13 +93,13 @@ 
 	 *
 	 * @return bool
 	 */
-	private function rangeInYears( $min, $max ) {
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
+	private function rangeInYears($min, $max) {
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
 
-		if ( $min !== null && $min->getUnit() === $yearUnit ) {
+		if ($min !== null && $min->getUnit() === $yearUnit) {
 			return true;
 		}
-		if ( $max !== null && $max->getUnit() === $yearUnit ) {
+		if ($max !== null && $max->getUnit() === $yearUnit) {
 			return true;
 		}
 
@@ -115,28 +115,28 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$minuend = $snak->getDataValue();
 		'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $minuend';
 
 		/** @var NumericPropertyId $property */
-		[ $min, $max, $property ] = $this->parseConstraintParameters( $constraint );
+		[$min, $max, $property] = $this->parseConstraintParameters($constraint);
 
 		// checks only the first occurrence of the referenced property
-		foreach ( $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ) as $otherSnak ) {
+		foreach ($context->getSnakGroup(Context::GROUP_NON_DEPRECATED) as $otherSnak) {
 			if (
-				!$property->equals( $otherSnak->getPropertyId() ) ||
+				!$property->equals($otherSnak->getPropertyId()) ||
 				!$otherSnak instanceof PropertyValueSnak
 			) {
 				continue;
@@ -144,30 +144,29 @@ 
 
 			$subtrahend = $otherSnak->getDataValue();
 			'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $subtrahend';
-			if ( $subtrahend->getType() === $minuend->getType() ) {
-				$diff = $this->rangeInYears( $min, $max ) && $minuend->getType() === 'time' ?
-					$this->rangeCheckerHelper->getDifferenceInYears( $minuend, $subtrahend ) :
-					$this->rangeCheckerHelper->getDifference( $minuend, $subtrahend );
+			if ($subtrahend->getType() === $minuend->getType()) {
+				$diff = $this->rangeInYears($min, $max) && $minuend->getType() === 'time' ?
+					$this->rangeCheckerHelper->getDifferenceInYears($minuend, $subtrahend) : $this->rangeCheckerHelper->getDifference($minuend, $subtrahend);
 
-				if ( $this->rangeCheckerHelper->getComparison( $min, $diff ) > 0 ||
-					$this->rangeCheckerHelper->getComparison( $diff, $max ) > 0
+				if ($this->rangeCheckerHelper->getComparison($min, $diff) > 0 ||
+					$this->rangeCheckerHelper->getComparison($diff, $max) > 0
 				) {
 					// at least one of $min, $max is set at this point, otherwise there could be no violation
-					$openness = $min !== null ? ( $max !== null ? '' : '-rightopen' ) : '-leftopen';
+					$openness = $min !== null ? ($max !== null ? '' : '-rightopen') : '-leftopen';
 					// possible message keys:
 					// wbqc-violation-message-diff-within-range
 					// wbqc-violation-message-diff-within-range-leftopen
 					// wbqc-violation-message-diff-within-range-rightopen
-					$message = ( new ViolationMessage( "wbqc-violation-message-diff-within-range$openness" ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $minuend, Role::OBJECT )
-						->withEntityId( $otherSnak->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $subtrahend, Role::OBJECT );
-					if ( $min !== null ) {
-						$message = $message->withDataValue( $min, Role::OBJECT );
+					$message = (new ViolationMessage("wbqc-violation-message-diff-within-range$openness"))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+						->withDataValue($minuend, Role::OBJECT)
+						->withEntityId($otherSnak->getPropertyId(), Role::PREDICATE)
+						->withDataValue($subtrahend, Role::OBJECT);
+					if ($min !== null) {
+						$message = $message->withDataValue($min, Role::OBJECT);
 					}
-					if ( $max !== null ) {
-						$message = $message->withDataValue( $max, Role::OBJECT );
+					if ($max !== null) {
+						$message = $message->withDataValue($max, Role::OBJECT);
 					}
 					$status = CheckResult::STATUS_VIOLATION;
 				} else {
@@ -175,17 +174,17 @@ 
 					$status = CheckResult::STATUS_COMPLIANCE;
 				}
 			} else {
-				$message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-must-have-equal-types' );
+				$message = new ViolationMessage('wbqc-violation-message-diff-within-range-must-have-equal-types');
 				$status = CheckResult::STATUS_VIOLATION;
 			}
 
-			return new CheckResult( $context, $constraint, $status, $message );
+			return new CheckResult($context, $constraint, $status, $message);
 		}
 
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -194,7 +193,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -202,7 +201,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;