@@ -62,9 +62,9 @@ discard block |
||
62 | 62 | * @throws ConstraintParameterException |
63 | 63 | * @return CheckResult |
64 | 64 | */ |
65 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
66 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
67 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
65 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
66 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
67 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
68 | 68 | } |
69 | 69 | |
70 | 70 | $parameters = []; |
@@ -75,26 +75,26 @@ discard block |
||
75 | 75 | $constraintParameters, |
76 | 76 | $constraintTypeItemId |
77 | 77 | ); |
78 | - $parameters['property'] = [ $propertyId ]; |
|
78 | + $parameters['property'] = [$propertyId]; |
|
79 | 79 | |
80 | - $message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) ) |
|
81 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
82 | - ->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE ); |
|
80 | + $message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier')) |
|
81 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
82 | + ->withEntityId($propertyId, Role::QUALIFIER_PREDICATE); |
|
83 | 83 | $status = CheckResult::STATUS_VIOLATION; |
84 | 84 | |
85 | 85 | /** @var Snak $qualifier */ |
86 | - foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) { |
|
87 | - if ( $propertyId->equals( $qualifier->getPropertyId() ) ) { |
|
86 | + foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) { |
|
87 | + if ($propertyId->equals($qualifier->getPropertyId())) { |
|
88 | 88 | $message = null; |
89 | 89 | $status = CheckResult::STATUS_COMPLIANCE; |
90 | 90 | break; |
91 | 91 | } |
92 | 92 | } |
93 | 93 | |
94 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
94 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
95 | 95 | } |
96 | 96 | |
97 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
97 | + public function checkConstraintParameters(Constraint $constraint) { |
|
98 | 98 | $constraintParameters = $constraint->getConstraintParameters(); |
99 | 99 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
100 | 100 | $exceptions = []; |
@@ -103,7 +103,7 @@ discard block |
||
103 | 103 | $constraintParameters, |
104 | 104 | $constraintTypeItemId |
105 | 105 | ); |
106 | - } catch ( ConstraintParameterException $e ) { |
|
106 | + } catch (ConstraintParameterException $e) { |
|
107 | 107 | $exceptions[] = $e; |
108 | 108 | } |
109 | 109 | return $exceptions; |
@@ -60,9 +60,9 @@ discard block |
||
60 | 60 | * @throws ConstraintParameterException |
61 | 61 | * @return CheckResult |
62 | 62 | */ |
63 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
64 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
65 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
63 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
64 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
65 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
66 | 66 | } |
67 | 67 | |
68 | 68 | $parameters = []; |
@@ -78,23 +78,23 @@ discard block |
||
78 | 78 | |
79 | 79 | $snak = $context->getSnak(); |
80 | 80 | |
81 | - $message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) ) |
|
82 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ) |
|
83 | - ->withItemIdSnakValueList( $items, Role::OBJECT ); |
|
81 | + $message = (new ViolationMessage('wbqc-violation-message-one-of')) |
|
82 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE) |
|
83 | + ->withItemIdSnakValueList($items, Role::OBJECT); |
|
84 | 84 | $status = CheckResult::STATUS_VIOLATION; |
85 | 85 | |
86 | - foreach ( $items as $item ) { |
|
87 | - if ( $item->matchesSnak( $snak ) ) { |
|
86 | + foreach ($items as $item) { |
|
87 | + if ($item->matchesSnak($snak)) { |
|
88 | 88 | $message = null; |
89 | 89 | $status = CheckResult::STATUS_COMPLIANCE; |
90 | 90 | break; |
91 | 91 | } |
92 | 92 | } |
93 | 93 | |
94 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
94 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
95 | 95 | } |
96 | 96 | |
97 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
97 | + public function checkConstraintParameters(Constraint $constraint) { |
|
98 | 98 | $constraintParameters = $constraint->getConstraintParameters(); |
99 | 99 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
100 | 100 | $exceptions = []; |
@@ -104,7 +104,7 @@ discard block |
||
104 | 104 | $constraintTypeItemId, |
105 | 105 | true |
106 | 106 | ); |
107 | - } catch ( ConstraintParameterException $e ) { |
|
107 | + } catch (ConstraintParameterException $e) { |
|
108 | 108 | $exceptions[] = $e; |
109 | 109 | } |
110 | 110 | return $exceptions; |
@@ -38,9 +38,9 @@ discard block |
||
38 | 38 | * |
39 | 39 | * @throws InvalidArgumentException |
40 | 40 | */ |
41 | - public function __construct( $content, array $attributes = [], $isRawContent = false ) { |
|
42 | - Assert::parameterType( 'string', $content, '$content' ); |
|
43 | - Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' ); |
|
41 | + public function __construct($content, array $attributes = [], $isRawContent = false) { |
|
42 | + Assert::parameterType('string', $content, '$content'); |
|
43 | + Assert::parameterType('boolean', $isRawContent, '$isRawContent'); |
|
44 | 44 | |
45 | 45 | $this->content = $content; |
46 | 46 | $this->attributes = $attributes; |
@@ -66,10 +66,10 @@ discard block |
||
66 | 66 | * @suppress SecurityCheck-DoubleEscaped |
67 | 67 | */ |
68 | 68 | public function toHtml() { |
69 | - if ( $this->isRawContent ) { |
|
70 | - return Html::rawElement( 'td', $this->getAttributes(), $this->content ); |
|
69 | + if ($this->isRawContent) { |
|
70 | + return Html::rawElement('td', $this->getAttributes(), $this->content); |
|
71 | 71 | } else { |
72 | - return Html::element( 'td', $this->getAttributes(), $this->content ); |
|
72 | + return Html::element('td', $this->getAttributes(), $this->content); |
|
73 | 73 | } |
74 | 74 | } |
75 | 75 |
@@ -41,10 +41,10 @@ discard block |
||
41 | 41 | * |
42 | 42 | * @throws InvalidArgumentException |
43 | 43 | */ |
44 | - public function __construct( $content, $isSortable = false, $isRawContent = false ) { |
|
45 | - Assert::parameterType( 'string', $content, '$content' ); |
|
46 | - Assert::parameterType( 'boolean', $isSortable, '$isSortable' ); |
|
47 | - Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' ); |
|
44 | + public function __construct($content, $isSortable = false, $isRawContent = false) { |
|
45 | + Assert::parameterType('string', $content, '$content'); |
|
46 | + Assert::parameterType('boolean', $isSortable, '$isSortable'); |
|
47 | + Assert::parameterType('boolean', $isRawContent, '$isRawContent'); |
|
48 | 48 | |
49 | 49 | $this->content = $content; |
50 | 50 | $this->isSortable = $isSortable; |
@@ -71,20 +71,20 @@ discard block |
||
71 | 71 | * @return string HTML |
72 | 72 | */ |
73 | 73 | public function toHtml() { |
74 | - $attributes = [ 'role' => 'columnheader button' ]; |
|
74 | + $attributes = ['role' => 'columnheader button']; |
|
75 | 75 | |
76 | - if ( !$this->isSortable ) { |
|
76 | + if (!$this->isSortable) { |
|
77 | 77 | $attributes['class'] = 'unsortable'; |
78 | 78 | } |
79 | 79 | |
80 | - if ( !$this->isRawContent ) { |
|
80 | + if (!$this->isRawContent) { |
|
81 | 81 | // @phan-suppress-next-line SecurityCheck-DoubleEscaped |
82 | - $content = htmlspecialchars( $this->content ); |
|
82 | + $content = htmlspecialchars($this->content); |
|
83 | 83 | } else { |
84 | 84 | $content = $this->content; |
85 | 85 | } |
86 | 86 | |
87 | - return Html::rawElement( 'th', $attributes, $content ); |
|
87 | + return Html::rawElement('th', $attributes, $content); |
|
88 | 88 | } |
89 | 89 | |
90 | 90 | } |
@@ -51,9 +51,9 @@ discard block |
||
51 | 51 | ]; |
52 | 52 | } |
53 | 53 | |
54 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
55 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
56 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
54 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
55 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
56 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
57 | 57 | } |
58 | 58 | |
59 | 59 | $constraintParameters = $constraint->getConstraintParameters(); |
@@ -65,10 +65,10 @@ discard block |
||
65 | 65 | 'item' => $entityTypes->getEntityTypes(), |
66 | 66 | ]; |
67 | 67 | |
68 | - if ( !in_array( $context->getEntity()->getType(), $entityTypes->getEntityTypes() ) ) { |
|
69 | - $message = ( new ViolationMessage( 'wbqc-violation-message-entityType' ) ) |
|
70 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
71 | - ->withEntityIdList( $entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE ); |
|
68 | + if (!in_array($context->getEntity()->getType(), $entityTypes->getEntityTypes())) { |
|
69 | + $message = (new ViolationMessage('wbqc-violation-message-entityType')) |
|
70 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
71 | + ->withEntityIdList($entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE); |
|
72 | 72 | |
73 | 73 | return new CheckResult( |
74 | 74 | $context, |
@@ -79,10 +79,10 @@ discard block |
||
79 | 79 | ); |
80 | 80 | } |
81 | 81 | |
82 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
82 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
83 | 83 | } |
84 | 84 | |
85 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
85 | + public function checkConstraintParameters(Constraint $constraint) { |
|
86 | 86 | $constraintParameters = $constraint->getConstraintParameters(); |
87 | 87 | $exceptions = []; |
88 | 88 | try { |
@@ -90,7 +90,7 @@ discard block |
||
90 | 90 | $constraintParameters, |
91 | 91 | $constraint->getConstraintTypeItemId() |
92 | 92 | ); |
93 | - } catch ( ConstraintParameterException $e ) { |
|
93 | + } catch (ConstraintParameterException $e) { |
|
94 | 94 | $exceptions[] = $e; |
95 | 95 | } |
96 | 96 | return $exceptions; |
@@ -74,9 +74,9 @@ discard block |
||
74 | 74 | * |
75 | 75 | * @return CheckResult |
76 | 76 | */ |
77 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
78 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
79 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
77 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
78 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
79 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
80 | 80 | } |
81 | 81 | |
82 | 82 | $parameters = []; |
@@ -84,9 +84,9 @@ discard block |
||
84 | 84 | $snak = $context->getSnak(); |
85 | 85 | $propertyId = $context->getSnak()->getPropertyId(); |
86 | 86 | |
87 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
87 | + if (!$snak instanceof PropertyValueSnak) { |
|
88 | 88 | // nothing to check |
89 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
89 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
90 | 90 | } |
91 | 91 | |
92 | 92 | $dataValue = $snak->getDataValue(); |
@@ -95,18 +95,18 @@ discard block |
||
95 | 95 | * error handling: |
96 | 96 | * type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid' |
97 | 97 | */ |
98 | - if ( !$dataValue instanceof EntityIdValue ) { |
|
99 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
100 | - ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM ) |
|
101 | - ->withDataValueType( 'wikibase-entityid' ); |
|
102 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
98 | + if (!$dataValue instanceof EntityIdValue) { |
|
99 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
100 | + ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM) |
|
101 | + ->withDataValueType('wikibase-entityid'); |
|
102 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
103 | 103 | } |
104 | 104 | |
105 | 105 | $targetEntityId = $dataValue->getEntityId(); |
106 | - $targetEntity = $this->entityLookup->getEntity( $targetEntityId ); |
|
107 | - if ( !$targetEntity instanceof StatementListProvider ) { |
|
108 | - $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' ); |
|
109 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
106 | + $targetEntity = $this->entityLookup->getEntity($targetEntityId); |
|
107 | + if (!$targetEntity instanceof StatementListProvider) { |
|
108 | + $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist'); |
|
109 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
110 | 110 | } |
111 | 111 | |
112 | 112 | $symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue( |
@@ -114,23 +114,23 @@ discard block |
||
114 | 114 | $propertyId, |
115 | 115 | $context->getEntity()->getId() |
116 | 116 | ); |
117 | - if ( $symmetricStatement !== null ) { |
|
117 | + if ($symmetricStatement !== null) { |
|
118 | 118 | $message = null; |
119 | 119 | $status = CheckResult::STATUS_COMPLIANCE; |
120 | 120 | } else { |
121 | - $message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) ) |
|
122 | - ->withEntityId( $targetEntityId, Role::SUBJECT ) |
|
123 | - ->withEntityId( $propertyId, Role::PREDICATE ) |
|
124 | - ->withEntityId( $context->getEntity()->getId(), Role::OBJECT ); |
|
121 | + $message = (new ViolationMessage('wbqc-violation-message-symmetric')) |
|
122 | + ->withEntityId($targetEntityId, Role::SUBJECT) |
|
123 | + ->withEntityId($propertyId, Role::PREDICATE) |
|
124 | + ->withEntityId($context->getEntity()->getId(), Role::OBJECT); |
|
125 | 125 | $status = CheckResult::STATUS_VIOLATION; |
126 | 126 | } |
127 | 127 | |
128 | - return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) ) |
|
129 | - ->withMetadata( Metadata::ofDependencyMetadata( |
|
130 | - DependencyMetadata::ofEntityId( $targetEntityId ) ) ); |
|
128 | + return (new CheckResult($context, $constraint, $parameters, $status, $message)) |
|
129 | + ->withMetadata(Metadata::ofDependencyMetadata( |
|
130 | + DependencyMetadata::ofEntityId($targetEntityId) )); |
|
131 | 131 | } |
132 | 132 | |
133 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
133 | + public function checkConstraintParameters(Constraint $constraint) { |
|
134 | 134 | // no parameters |
135 | 135 | return []; |
136 | 136 | } |
@@ -65,24 +65,24 @@ discard block |
||
65 | 65 | * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs |
66 | 66 | * @return CheckResult |
67 | 67 | */ |
68 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
69 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
70 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
68 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
69 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
70 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
71 | 71 | } |
72 | 72 | |
73 | 73 | $parameters = []; |
74 | 74 | |
75 | - if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) { |
|
76 | - if ( $context->getType() === 'statement' ) { |
|
75 | + if (!($this->sparqlHelper instanceof DummySparqlHelper)) { |
|
76 | + if ($context->getType() === 'statement') { |
|
77 | 77 | $result = $this->sparqlHelper->findEntitiesWithSameStatement( |
78 | 78 | $context->getSnakStatement(), |
79 | 79 | true // ignore deprecated statements |
80 | 80 | ); |
81 | 81 | } else { |
82 | 82 | $snak = $context->getSnak(); |
83 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
83 | + if (!$snak instanceof PropertyValueSnak) { |
|
84 | 84 | // nothing to check |
85 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE ); |
|
85 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE); |
|
86 | 86 | } |
87 | 87 | $result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference( |
88 | 88 | $context->getEntity()->getId(), |
@@ -95,27 +95,27 @@ discard block |
||
95 | 95 | $otherEntities = $result->getArray(); |
96 | 96 | $metadata = $result->getMetadata(); |
97 | 97 | |
98 | - if ( $otherEntities === [] ) { |
|
98 | + if ($otherEntities === []) { |
|
99 | 99 | $status = CheckResult::STATUS_COMPLIANCE; |
100 | 100 | $message = null; |
101 | 101 | } else { |
102 | - $otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls |
|
102 | + $otherEntities = array_values(array_filter($otherEntities)); // remove nulls |
|
103 | 103 | $status = CheckResult::STATUS_VIOLATION; |
104 | - $message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) ) |
|
105 | - ->withEntityIdList( $otherEntities, Role::SUBJECT ); |
|
104 | + $message = (new ViolationMessage('wbqc-violation-message-unique-value')) |
|
105 | + ->withEntityIdList($otherEntities, Role::SUBJECT); |
|
106 | 106 | } |
107 | 107 | } else { |
108 | 108 | $status = CheckResult::STATUS_TODO; |
109 | - $message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) ) |
|
110 | - ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM ); |
|
109 | + $message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented')) |
|
110 | + ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM); |
|
111 | 111 | $metadata = Metadata::blank(); |
112 | 112 | } |
113 | 113 | |
114 | - return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) ) |
|
115 | - ->withMetadata( $metadata ); |
|
114 | + return (new CheckResult($context, $constraint, $parameters, $status, $message)) |
|
115 | + ->withMetadata($metadata); |
|
116 | 116 | } |
117 | 117 | |
118 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
118 | + public function checkConstraintParameters(Constraint $constraint) { |
|
119 | 119 | // no parameters |
120 | 120 | return []; |
121 | 121 | } |
@@ -41,23 +41,22 @@ discard block |
||
41 | 41 | ]; |
42 | 42 | } |
43 | 43 | |
44 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
44 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
45 | 45 | $snak = $context->getSnak(); |
46 | 46 | |
47 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
47 | + if (!$snak instanceof PropertyValueSnak) { |
|
48 | 48 | // nothing to check |
49 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE ); |
|
49 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE); |
|
50 | 50 | } |
51 | 51 | |
52 | - $violationMessage = $this->checkSnak( $snak ); |
|
52 | + $violationMessage = $this->checkSnak($snak); |
|
53 | 53 | |
54 | 54 | return new CheckResult( |
55 | 55 | $context, |
56 | 56 | $constraint, |
57 | 57 | [], |
58 | 58 | $violationMessage === null ? |
59 | - CheckResult::STATUS_COMPLIANCE : |
|
60 | - CheckResult::STATUS_VIOLATION, |
|
59 | + CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION, |
|
61 | 60 | $violationMessage |
62 | 61 | ); |
63 | 62 | } |
@@ -66,23 +65,23 @@ discard block |
||
66 | 65 | * @param PropertyValueSnak $snak |
67 | 66 | * @return ViolationMessage|null |
68 | 67 | */ |
69 | - public function checkSnak( PropertyValueSnak $snak ) { |
|
68 | + public function checkSnak(PropertyValueSnak $snak) { |
|
70 | 69 | $dataValue = $snak->getDataValue(); |
71 | 70 | |
72 | - if ( $dataValue instanceof DecimalValue ) { |
|
73 | - if ( !$this->isInteger( $dataValue ) ) { |
|
74 | - return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak ); |
|
71 | + if ($dataValue instanceof DecimalValue) { |
|
72 | + if (!$this->isInteger($dataValue)) { |
|
73 | + return $this->getViolationMessage('wbqc-violation-message-integer', $snak); |
|
75 | 74 | } |
76 | - } elseif ( $dataValue instanceof UnboundedQuantityValue ) { |
|
77 | - if ( !$this->isInteger( $dataValue->getAmount() ) ) { |
|
78 | - return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak ); |
|
75 | + } elseif ($dataValue instanceof UnboundedQuantityValue) { |
|
76 | + if (!$this->isInteger($dataValue->getAmount())) { |
|
77 | + return $this->getViolationMessage('wbqc-violation-message-integer', $snak); |
|
79 | 78 | } elseif ( |
80 | 79 | $dataValue instanceof QuantityValue && ( |
81 | - !$this->isInteger( $dataValue->getLowerBound() ) || |
|
82 | - !$this->isInteger( $dataValue->getUpperBound() ) |
|
80 | + !$this->isInteger($dataValue->getLowerBound()) || |
|
81 | + !$this->isInteger($dataValue->getUpperBound()) |
|
83 | 82 | ) |
84 | 83 | ) { |
85 | - return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak ); |
|
84 | + return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak); |
|
86 | 85 | } |
87 | 86 | } |
88 | 87 | |
@@ -93,7 +92,7 @@ discard block |
||
93 | 92 | * @param DecimalValue $decimalValue |
94 | 93 | * @return bool |
95 | 94 | */ |
96 | - private function isInteger( DecimalValue $decimalValue ) { |
|
95 | + private function isInteger(DecimalValue $decimalValue) { |
|
97 | 96 | return $decimalValue->getTrimmed()->getFractionalPart() === ''; |
98 | 97 | } |
99 | 98 | |
@@ -102,13 +101,13 @@ discard block |
||
102 | 101 | * @param PropertyValueSnak $snak |
103 | 102 | * @return ViolationMessage |
104 | 103 | */ |
105 | - private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) { |
|
106 | - return ( new ViolationMessage( $messageKey ) ) |
|
107 | - ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
108 | - ->withDataValue( $snak->getDataValue() ); |
|
104 | + private function getViolationMessage($messageKey, PropertyValueSnak $snak) { |
|
105 | + return (new ViolationMessage($messageKey)) |
|
106 | + ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
107 | + ->withDataValue($snak->getDataValue()); |
|
109 | 108 | } |
110 | 109 | |
111 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
110 | + public function checkConstraintParameters(Constraint $constraint) { |
|
112 | 111 | // no parameters |
113 | 112 | return []; |
114 | 113 | } |
@@ -39,17 +39,17 @@ discard block |
||
39 | 39 | ]; |
40 | 40 | } |
41 | 41 | |
42 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
42 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
43 | 43 | $snak = $context->getSnak(); |
44 | 44 | |
45 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
45 | + if (!$snak instanceof PropertyValueSnak) { |
|
46 | 46 | // nothing to check |
47 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE ); |
|
47 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE); |
|
48 | 48 | } |
49 | 49 | |
50 | - if ( $snak->getDataValue() instanceof QuantityValue ) { |
|
51 | - $message = ( new ViolationMessage( 'wbqc-violation-message-noBounds' ) ) |
|
52 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ); |
|
50 | + if ($snak->getDataValue() instanceof QuantityValue) { |
|
51 | + $message = (new ViolationMessage('wbqc-violation-message-noBounds')) |
|
52 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY); |
|
53 | 53 | return new CheckResult( |
54 | 54 | $context, |
55 | 55 | $constraint, |
@@ -59,10 +59,10 @@ discard block |
||
59 | 59 | ); |
60 | 60 | } |
61 | 61 | |
62 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE ); |
|
62 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE); |
|
63 | 63 | } |
64 | 64 | |
65 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
65 | + public function checkConstraintParameters(Constraint $constraint) { |
|
66 | 66 | // no parameters |
67 | 67 | return []; |
68 | 68 | } |