@@ -122,12 +122,12 @@ discard block |
||
122 | 122 | $status = self::STATUS_TODO, |
123 | 123 | ViolationMessage $message = null |
124 | 124 | ) { |
125 | - if ( $contextCursor instanceof Context ) { |
|
125 | + if ($contextCursor instanceof Context) { |
|
126 | 126 | $context = $contextCursor; |
127 | 127 | $this->contextCursor = $context->getCursor(); |
128 | 128 | $this->snakType = $context->getSnak()->getType(); |
129 | 129 | $mainSnak = $context->getSnak(); |
130 | - if ( $mainSnak instanceof PropertyValueSnak ) { |
|
130 | + if ($mainSnak instanceof PropertyValueSnak) { |
|
131 | 131 | $this->dataValue = $mainSnak->getDataValue(); |
132 | 132 | } else { |
133 | 133 | $this->dataValue = null; |
@@ -190,7 +190,7 @@ discard block |
||
190 | 190 | * @param string $key |
191 | 191 | * @param string $value |
192 | 192 | */ |
193 | - public function addParameter( $key, $value ) { |
|
193 | + public function addParameter($key, $value) { |
|
194 | 194 | $this->parameters[$key][] = $value; |
195 | 195 | } |
196 | 196 | |
@@ -204,7 +204,7 @@ discard block |
||
204 | 204 | /** |
205 | 205 | * @param string $status |
206 | 206 | */ |
207 | - public function setStatus( $status ) { |
|
207 | + public function setStatus($status) { |
|
208 | 208 | $this->status = $status; |
209 | 209 | } |
210 | 210 | |
@@ -219,7 +219,7 @@ discard block |
||
219 | 219 | * @param Metadata $metadata |
220 | 220 | * @return self |
221 | 221 | */ |
222 | - public function withMetadata( Metadata $metadata ) { |
|
222 | + public function withMetadata(Metadata $metadata) { |
|
223 | 223 | $this->metadata = $metadata; |
224 | 224 | return $this; |
225 | 225 | } |
@@ -75,7 +75,7 @@ discard block |
||
75 | 75 | * @throws ConstraintParameterException |
76 | 76 | * @return CheckResult |
77 | 77 | */ |
78 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
78 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
79 | 79 | $parameters = []; |
80 | 80 | $constraintParameters = $constraint->getConstraintParameters(); |
81 | 81 | $unitsParameter = $this->constraintParameterParser |
@@ -85,50 +85,49 @@ discard block |
||
85 | 85 | ); |
86 | 86 | |
87 | 87 | $snak = $context->getSnak(); |
88 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
88 | + if (!$snak instanceof PropertyValueSnak) { |
|
89 | 89 | // nothing to check |
90 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
90 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
91 | 91 | } |
92 | 92 | |
93 | 93 | $dataValue = $snak->getDataValue(); |
94 | - if ( !$dataValue instanceof UnboundedQuantityValue ) { |
|
95 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
96 | - ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM ) |
|
97 | - ->withDataValueType( 'quantity' ); |
|
98 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
94 | + if (!$dataValue instanceof UnboundedQuantityValue) { |
|
95 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
96 | + ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM) |
|
97 | + ->withDataValueType('quantity'); |
|
98 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
99 | 99 | } |
100 | 100 | |
101 | - if ( $dataValue->getUnit() === '1' ) { |
|
102 | - return $this->checkUnitless( $context, $constraint, $unitsParameter, $snak ); |
|
101 | + if ($dataValue->getUnit() === '1') { |
|
102 | + return $this->checkUnitless($context, $constraint, $unitsParameter, $snak); |
|
103 | 103 | } |
104 | 104 | |
105 | 105 | $status = CheckResult::STATUS_VIOLATION; |
106 | - $actualUnit = $this->standardize( $dataValue )->getUnit(); |
|
107 | - foreach ( $unitsParameter->getUnitQuantities() as $unitQuantity ) { |
|
108 | - $allowedUnit = $this->standardize( $unitQuantity )->getUnit(); |
|
109 | - if ( $actualUnit === $allowedUnit ) { |
|
106 | + $actualUnit = $this->standardize($dataValue)->getUnit(); |
|
107 | + foreach ($unitsParameter->getUnitQuantities() as $unitQuantity) { |
|
108 | + $allowedUnit = $this->standardize($unitQuantity)->getUnit(); |
|
109 | + if ($actualUnit === $allowedUnit) { |
|
110 | 110 | $status = CheckResult::STATUS_COMPLIANCE; |
111 | 111 | break; |
112 | 112 | } |
113 | 113 | } |
114 | 114 | |
115 | - if ( $status === CheckResult::STATUS_VIOLATION ) { |
|
116 | - if ( $unitsParameter->getUnitItemIds() === [] ) { |
|
117 | - $message = ( new ViolationMessage( 'wbqc-violation-message-units-none' ) ) |
|
118 | - ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY ); |
|
115 | + if ($status === CheckResult::STATUS_VIOLATION) { |
|
116 | + if ($unitsParameter->getUnitItemIds() === []) { |
|
117 | + $message = (new ViolationMessage('wbqc-violation-message-units-none')) |
|
118 | + ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY); |
|
119 | 119 | } else { |
120 | 120 | $messageKey = $unitsParameter->getUnitlessAllowed() ? |
121 | - 'wbqc-violation-message-units-or-none' : |
|
122 | - 'wbqc-violation-message-units'; |
|
123 | - $message = ( new ViolationMessage( $messageKey ) ) |
|
124 | - ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
125 | - ->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE ); |
|
121 | + 'wbqc-violation-message-units-or-none' : 'wbqc-violation-message-units'; |
|
122 | + $message = (new ViolationMessage($messageKey)) |
|
123 | + ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
124 | + ->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE); |
|
126 | 125 | } |
127 | 126 | } else { |
128 | 127 | $message = null; |
129 | 128 | } |
130 | 129 | |
131 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
130 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
132 | 131 | } |
133 | 132 | |
134 | 133 | /** |
@@ -144,17 +143,17 @@ discard block |
||
144 | 143 | UnitsParameter $unitsParameter, |
145 | 144 | PropertyValueSnak $snak |
146 | 145 | ) { |
147 | - if ( $unitsParameter->getUnitlessAllowed() ) { |
|
146 | + if ($unitsParameter->getUnitlessAllowed()) { |
|
148 | 147 | $message = null; |
149 | 148 | $status = CheckResult::STATUS_COMPLIANCE; |
150 | 149 | } else { |
151 | - $message = ( new ViolationMessage( 'wbqc-violation-message-units' ) ) |
|
152 | - ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
153 | - ->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE ); |
|
150 | + $message = (new ViolationMessage('wbqc-violation-message-units')) |
|
151 | + ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
152 | + ->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE); |
|
154 | 153 | $status = CheckResult::STATUS_VIOLATION; |
155 | 154 | } |
156 | 155 | |
157 | - return new CheckResult( $context, $constraint, [], $status, $message ); |
|
156 | + return new CheckResult($context, $constraint, [], $status, $message); |
|
158 | 157 | } |
159 | 158 | |
160 | 159 | /** |
@@ -163,20 +162,20 @@ discard block |
||
163 | 162 | * @param UnboundedQuantityValue $value |
164 | 163 | * @return UnboundedQuantityValue |
165 | 164 | */ |
166 | - private function standardize( UnboundedQuantityValue $value ) { |
|
167 | - if ( $this->unitConverter === null ) { |
|
165 | + private function standardize(UnboundedQuantityValue $value) { |
|
166 | + if ($this->unitConverter === null) { |
|
168 | 167 | return $value; |
169 | 168 | } |
170 | 169 | |
171 | - $standard = $this->unitConverter->toStandardUnits( $value ); |
|
172 | - if ( $standard !== null ) { |
|
170 | + $standard = $this->unitConverter->toStandardUnits($value); |
|
171 | + if ($standard !== null) { |
|
173 | 172 | return $standard; |
174 | 173 | } else { |
175 | 174 | return $value; |
176 | 175 | } |
177 | 176 | } |
178 | 177 | |
179 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
178 | + public function checkConstraintParameters(Constraint $constraint) { |
|
180 | 179 | $constraintParameters = $constraint->getConstraintParameters(); |
181 | 180 | $exceptions = []; |
182 | 181 | try { |
@@ -185,7 +184,7 @@ discard block |
||
185 | 184 | $constraint->getConstraintTypeItemId(), |
186 | 185 | true |
187 | 186 | ); |
188 | - } catch ( ConstraintParameterException $e ) { |
|
187 | + } catch (ConstraintParameterException $e) { |
|
189 | 188 | $exceptions[] = $e; |
190 | 189 | } |
191 | 190 | return $exceptions; |
@@ -59,9 +59,9 @@ discard block |
||
59 | 59 | ]; |
60 | 60 | } |
61 | 61 | |
62 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
63 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
64 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
62 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
63 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
64 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
65 | 65 | } |
66 | 66 | |
67 | 67 | $constraintParameters = $constraint->getConstraintParameters(); |
@@ -71,10 +71,10 @@ discard block |
||
71 | 71 | ); |
72 | 72 | $parameters['item'] = $entityTypes->getEntityTypes(); |
73 | 73 | |
74 | - if ( !in_array( $context->getEntity()->getType(), $entityTypes->getEntityTypes() ) ) { |
|
75 | - $message = ( new ViolationMessage( 'wbqc-violation-message-entityType' ) ) |
|
76 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
77 | - ->withEntityIdList( $entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE ); |
|
74 | + if (!in_array($context->getEntity()->getType(), $entityTypes->getEntityTypes())) { |
|
75 | + $message = (new ViolationMessage('wbqc-violation-message-entityType')) |
|
76 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
77 | + ->withEntityIdList($entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE); |
|
78 | 78 | |
79 | 79 | return new CheckResult( |
80 | 80 | $context, |
@@ -85,10 +85,10 @@ discard block |
||
85 | 85 | ); |
86 | 86 | } |
87 | 87 | |
88 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
88 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
89 | 89 | } |
90 | 90 | |
91 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
91 | + public function checkConstraintParameters(Constraint $constraint) { |
|
92 | 92 | $constraintParameters = $constraint->getConstraintParameters(); |
93 | 93 | $exceptions = []; |
94 | 94 | try { |
@@ -96,7 +96,7 @@ discard block |
||
96 | 96 | $constraintParameters, |
97 | 97 | $constraint->getConstraintTypeItemId() |
98 | 98 | ); |
99 | - } catch ( ConstraintParameterException $e ) { |
|
99 | + } catch (ConstraintParameterException $e) { |
|
100 | 100 | $exceptions[] = $e; |
101 | 101 | } |
102 | 102 | return $exceptions; |
@@ -24,9 +24,9 @@ discard block |
||
24 | 24 | */ |
25 | 25 | private $statement; |
26 | 26 | |
27 | - public function __construct( EntityDocument $entity, Statement $statement ) { |
|
28 | - Assert::parameterType( StatementListProvider::class, $entity, '$entity' ); |
|
29 | - parent::__construct( $entity, $statement->getMainSnak() ); |
|
27 | + public function __construct(EntityDocument $entity, Statement $statement) { |
|
28 | + Assert::parameterType(StatementListProvider::class, $entity, '$entity'); |
|
29 | + parent::__construct($entity, $statement->getMainSnak()); |
|
30 | 30 | |
31 | 31 | $this->statement = $statement; |
32 | 32 | } |
@@ -43,21 +43,21 @@ discard block |
||
43 | 43 | return $this->statement; |
44 | 44 | } |
45 | 45 | |
46 | - public function getSnakGroup( $groupingMode, array $separators = [] ) { |
|
46 | + public function getSnakGroup($groupingMode, array $separators = []) { |
|
47 | 47 | /** @var StatementList $statements */ |
48 | 48 | $statements = $this->entity->getStatements(); |
49 | - switch ( $groupingMode ) { |
|
49 | + switch ($groupingMode) { |
|
50 | 50 | case Context::GROUP_NON_DEPRECATED: |
51 | - $statements = $statements->getByRank( [ |
|
51 | + $statements = $statements->getByRank([ |
|
52 | 52 | Statement::RANK_NORMAL, |
53 | 53 | Statement::RANK_PREFERRED, |
54 | - ] ); |
|
54 | + ]); |
|
55 | 55 | break; |
56 | 56 | case Context::GROUP_BEST_RANK: |
57 | - $statements = $this->getBestStatementsPerPropertyId( $statements ); |
|
57 | + $statements = $this->getBestStatementsPerPropertyId($statements); |
|
58 | 58 | break; |
59 | 59 | default: |
60 | - throw new LogicException( 'Unknown $groupingMode ' . $groupingMode ); |
|
60 | + throw new LogicException('Unknown $groupingMode '.$groupingMode); |
|
61 | 61 | } |
62 | 62 | return $this->getStatementsWithSameQualifiersForProperties( |
63 | 63 | $this->statement, |
@@ -66,13 +66,13 @@ discard block |
||
66 | 66 | )->getMainSnaks(); |
67 | 67 | } |
68 | 68 | |
69 | - private function getBestStatementsPerPropertyId( StatementList $statements ) { |
|
69 | + private function getBestStatementsPerPropertyId(StatementList $statements) { |
|
70 | 70 | $allBestStatements = new StatementList(); |
71 | - foreach ( $statements->getPropertyIds() as $propertyId ) { |
|
72 | - $bestStatements = $statements->getByPropertyId( $propertyId ) |
|
71 | + foreach ($statements->getPropertyIds() as $propertyId) { |
|
72 | + $bestStatements = $statements->getByPropertyId($propertyId) |
|
73 | 73 | ->getBestStatements(); |
74 | - foreach ( $bestStatements as $bestStatement ) { |
|
75 | - $allBestStatements->addStatement( $bestStatement ); |
|
74 | + foreach ($bestStatements as $bestStatement) { |
|
75 | + $allBestStatements->addStatement($bestStatement); |
|
76 | 76 | } |
77 | 77 | } |
78 | 78 | return $allBestStatements; |
@@ -94,20 +94,20 @@ discard block |
||
94 | 94 | array $qualifierPropertyIds |
95 | 95 | ) { |
96 | 96 | $similarStatements = new StatementList(); |
97 | - foreach ( $allStatements as $statement ) { |
|
98 | - if ( $statement === $currentStatement ) { |
|
97 | + foreach ($allStatements as $statement) { |
|
98 | + if ($statement === $currentStatement) { |
|
99 | 99 | // if the statement has an “unknown value” qualifier, |
100 | 100 | // it might be considered different from itself, |
101 | 101 | // so add it explicitly to ensure it’s always included |
102 | - $similarStatements->addStatement( $statement ); |
|
102 | + $similarStatements->addStatement($statement); |
|
103 | 103 | continue; |
104 | 104 | } |
105 | - foreach ( $qualifierPropertyIds as $qualifierPropertyId ) { |
|
106 | - if ( !$this->haveSameQualifiers( $currentStatement, $statement, $qualifierPropertyId ) ) { |
|
105 | + foreach ($qualifierPropertyIds as $qualifierPropertyId) { |
|
106 | + if (!$this->haveSameQualifiers($currentStatement, $statement, $qualifierPropertyId)) { |
|
107 | 107 | continue 2; |
108 | 108 | } |
109 | 109 | } |
110 | - $similarStatements->addStatement( $statement ); |
|
110 | + $similarStatements->addStatement($statement); |
|
111 | 111 | } |
112 | 112 | return $similarStatements; |
113 | 113 | } |
@@ -121,19 +121,19 @@ discard block |
||
121 | 121 | * @param PropertyId $propertyId |
122 | 122 | * @return bool |
123 | 123 | */ |
124 | - private function haveSameQualifiers( Statement $s1, Statement $s2, PropertyId $propertyId ) { |
|
125 | - $q1 = $this->getSnaksWithPropertyId( $s1->getQualifiers(), $propertyId ); |
|
126 | - $q2 = $this->getSnaksWithPropertyId( $s2->getQualifiers(), $propertyId ); |
|
124 | + private function haveSameQualifiers(Statement $s1, Statement $s2, PropertyId $propertyId) { |
|
125 | + $q1 = $this->getSnaksWithPropertyId($s1->getQualifiers(), $propertyId); |
|
126 | + $q2 = $this->getSnaksWithPropertyId($s2->getQualifiers(), $propertyId); |
|
127 | 127 | |
128 | - if ( $q1->count() !== $q2->count() ) { |
|
128 | + if ($q1->count() !== $q2->count()) { |
|
129 | 129 | return false; |
130 | 130 | } |
131 | 131 | |
132 | - foreach ( $q1 as $qualifier ) { |
|
133 | - switch ( $qualifier->getType() ) { |
|
132 | + foreach ($q1 as $qualifier) { |
|
133 | + switch ($qualifier->getType()) { |
|
134 | 134 | case 'value': |
135 | 135 | case 'novalue': |
136 | - if ( !$q2->hasSnak( $qualifier ) ) { |
|
136 | + if (!$q2->hasSnak($qualifier)) { |
|
137 | 137 | return false; |
138 | 138 | } |
139 | 139 | break; |
@@ -155,12 +155,12 @@ discard block |
||
155 | 155 | * @param PropertyId $propertyId |
156 | 156 | * @return SnakList |
157 | 157 | */ |
158 | - private function getSnaksWithPropertyId( SnakList $allSnaks, PropertyId $propertyId ) { |
|
158 | + private function getSnaksWithPropertyId(SnakList $allSnaks, PropertyId $propertyId) { |
|
159 | 159 | $snaks = new SnakList(); |
160 | 160 | /** @var Snak $snak */ |
161 | - foreach ( $allSnaks as $snak ) { |
|
162 | - if ( $snak->getPropertyId()->equals( $propertyId ) ) { |
|
163 | - $snaks->addSnak( $snak ); |
|
161 | + foreach ($allSnaks as $snak) { |
|
162 | + if ($snak->getPropertyId()->equals($propertyId)) { |
|
163 | + $snaks->addSnak($snak); |
|
164 | 164 | } |
165 | 165 | } |
166 | 166 | return $snaks; |
@@ -23,7 +23,7 @@ discard block |
||
23 | 23 | Statement $statement, |
24 | 24 | Snak $snak |
25 | 25 | ) { |
26 | - parent::__construct( $entity, $snak ); |
|
26 | + parent::__construct($entity, $snak); |
|
27 | 27 | $this->statement = $statement; |
28 | 28 | } |
29 | 29 | |
@@ -31,9 +31,9 @@ discard block |
||
31 | 31 | return self::TYPE_QUALIFIER; |
32 | 32 | } |
33 | 33 | |
34 | - public function getSnakGroup( $groupingMode, array $separators = [] ) { |
|
34 | + public function getSnakGroup($groupingMode, array $separators = []) { |
|
35 | 35 | $snaks = $this->statement->getQualifiers(); |
36 | - return array_values( $snaks->getArrayCopy() ); |
|
36 | + return array_values($snaks->getArrayCopy()); |
|
37 | 37 | } |
38 | 38 | |
39 | 39 | public function getCursor() { |
@@ -30,7 +30,7 @@ discard block |
||
30 | 30 | Reference $reference, |
31 | 31 | Snak $snak |
32 | 32 | ) { |
33 | - parent::__construct( $entity, $snak ); |
|
33 | + parent::__construct($entity, $snak); |
|
34 | 34 | $this->statement = $statement; |
35 | 35 | $this->reference = $reference; |
36 | 36 | } |
@@ -39,9 +39,9 @@ discard block |
||
39 | 39 | return self::TYPE_REFERENCE; |
40 | 40 | } |
41 | 41 | |
42 | - public function getSnakGroup( $groupingMode, array $separators = [] ) { |
|
42 | + public function getSnakGroup($groupingMode, array $separators = []) { |
|
43 | 43 | $snaks = $this->reference->getSnaks(); |
44 | - return array_values( $snaks->getArrayCopy() ); |
|
44 | + return array_values($snaks->getArrayCopy()); |
|
45 | 45 | } |
46 | 46 | |
47 | 47 | public function getCursor() { |
@@ -109,7 +109,7 @@ |
||
109 | 109 | * @return Snak[] not a SnakList because for a statement context, |
110 | 110 | * the returned value might contain the same snak several times. |
111 | 111 | */ |
112 | - public function getSnakGroup( $groupingMode, array $separators = [] ); |
|
112 | + public function getSnakGroup($groupingMode, array $separators = []); |
|
113 | 113 | |
114 | 114 | /** |
115 | 115 | * Get the cursor that can be used to address check results for this context. |
@@ -66,9 +66,9 @@ discard block |
||
66 | 66 | * |
67 | 67 | * @return CheckResult |
68 | 68 | */ |
69 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
70 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
71 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
69 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
70 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
71 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
72 | 72 | } |
73 | 73 | |
74 | 74 | $parameters = []; |
@@ -80,13 +80,13 @@ discard block |
||
80 | 80 | |
81 | 81 | $propertyId = $context->getSnak()->getPropertyId(); |
82 | 82 | $bestRankCount = $this->valueCountCheckerHelper->getPropertyCount( |
83 | - $context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ), |
|
83 | + $context->getSnakGroup(Context::GROUP_BEST_RANK, $separators), |
|
84 | 84 | $propertyId |
85 | 85 | ); |
86 | 86 | |
87 | - if ( $bestRankCount > 1 ) { |
|
87 | + if ($bestRankCount > 1) { |
|
88 | 88 | $nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount( |
89 | - $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ), |
|
89 | + $context->getSnakGroup(Context::GROUP_NON_DEPRECATED), |
|
90 | 90 | $propertyId |
91 | 91 | ); |
92 | 92 | $message = $this->getViolationMessage( |
@@ -101,15 +101,15 @@ discard block |
||
101 | 101 | $status = CheckResult::STATUS_COMPLIANCE; |
102 | 102 | } |
103 | 103 | |
104 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
104 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
105 | 105 | } |
106 | 106 | |
107 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
107 | + public function checkConstraintParameters(Constraint $constraint) { |
|
108 | 108 | $constraintParameters = $constraint->getConstraintParameters(); |
109 | 109 | $exceptions = []; |
110 | 110 | try { |
111 | - $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters ); |
|
112 | - } catch ( ConstraintParameterException $e ) { |
|
111 | + $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters); |
|
112 | + } catch (ConstraintParameterException $e) { |
|
113 | 113 | $exceptions[] = $e; |
114 | 114 | } |
115 | 115 | return $exceptions; |
@@ -128,23 +128,23 @@ discard block |
||
128 | 128 | $separators, |
129 | 129 | $propertyId |
130 | 130 | ) { |
131 | - if ( $bestRankCount === $nonDeprecatedCount ) { |
|
132 | - if ( $separators === [] ) { |
|
131 | + if ($bestRankCount === $nonDeprecatedCount) { |
|
132 | + if ($separators === []) { |
|
133 | 133 | $messageKey = 'wbqc-violation-message-single-best-value-no-preferred'; |
134 | 134 | } else { |
135 | 135 | $messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators'; |
136 | 136 | } |
137 | 137 | } else { |
138 | - if ( $separators === [] ) { |
|
138 | + if ($separators === []) { |
|
139 | 139 | $messageKey = 'wbqc-violation-message-single-best-value-multi-preferred'; |
140 | 140 | } else { |
141 | 141 | $messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators'; |
142 | 142 | } |
143 | 143 | } |
144 | 144 | |
145 | - return ( new ViolationMessage( $messageKey ) ) |
|
146 | - ->withEntityId( $propertyId ) |
|
147 | - ->withEntityIdList( $separators ); |
|
145 | + return (new ViolationMessage($messageKey)) |
|
146 | + ->withEntityId($propertyId) |
|
147 | + ->withEntityIdList($separators); |
|
148 | 148 | } |
149 | 149 | |
150 | 150 | } |
@@ -67,9 +67,9 @@ discard block |
||
67 | 67 | * @throws ConstraintParameterException |
68 | 68 | * @return CheckResult |
69 | 69 | */ |
70 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
71 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
72 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
70 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
71 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
72 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
73 | 73 | } |
74 | 74 | |
75 | 75 | $parameters = []; |
@@ -81,19 +81,19 @@ discard block |
||
81 | 81 | |
82 | 82 | $propertyId = $context->getSnak()->getPropertyId(); |
83 | 83 | $propertyCount = $this->valueCountCheckerHelper->getPropertyCount( |
84 | - $context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ), |
|
84 | + $context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators), |
|
85 | 85 | $propertyId |
86 | 86 | ); |
87 | 87 | |
88 | - if ( $propertyCount > 1 ) { |
|
89 | - $message = $this->getViolationMessage( $separators, $propertyId ); |
|
88 | + if ($propertyCount > 1) { |
|
89 | + $message = $this->getViolationMessage($separators, $propertyId); |
|
90 | 90 | $status = CheckResult::STATUS_VIOLATION; |
91 | 91 | } else { |
92 | 92 | $message = null; |
93 | 93 | $status = CheckResult::STATUS_COMPLIANCE; |
94 | 94 | } |
95 | 95 | |
96 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
96 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
97 | 97 | } |
98 | 98 | |
99 | 99 | /** |
@@ -101,22 +101,21 @@ discard block |
||
101 | 101 | * @param PropertyId $propertyId |
102 | 102 | * @return ViolationMessage |
103 | 103 | */ |
104 | - private function getViolationMessage( array $separators, PropertyId $propertyId ) { |
|
104 | + private function getViolationMessage(array $separators, PropertyId $propertyId) { |
|
105 | 105 | $messageKey = $separators === [] ? |
106 | - 'wbqc-violation-message-single-value' : |
|
107 | - 'wbqc-violation-message-single-value-separators'; |
|
106 | + 'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators'; |
|
108 | 107 | |
109 | - return ( new ViolationMessage( $messageKey ) ) |
|
110 | - ->withEntityId( $propertyId ) |
|
111 | - ->withEntityIdList( $separators ); |
|
108 | + return (new ViolationMessage($messageKey)) |
|
109 | + ->withEntityId($propertyId) |
|
110 | + ->withEntityIdList($separators); |
|
112 | 111 | } |
113 | 112 | |
114 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
113 | + public function checkConstraintParameters(Constraint $constraint) { |
|
115 | 114 | $constraintParameters = $constraint->getConstraintParameters(); |
116 | 115 | $exceptions = []; |
117 | 116 | try { |
118 | - $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters ); |
|
119 | - } catch ( ConstraintParameterException $e ) { |
|
117 | + $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters); |
|
118 | + } catch (ConstraintParameterException $e) { |
|
120 | 119 | $exceptions[] = $e; |
121 | 120 | } |
122 | 121 | return $exceptions; |