Completed
Push — master ( e29ba0...57089b )
by
unknown
02:41
created
src/ConstraintCheck/Message/MultilingualTextViolationMessageRenderer.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 		Config $config,
36 36
 		$maxListLength = 10
37 37
 	) {
38
-		parent::__construct( $entityIdFormatter, $dataValueFormatter, $config, $maxListLength );
38
+		parent::__construct($entityIdFormatter, $dataValueFormatter, $config, $maxListLength);
39 39
 
40 40
 		$this->alternativeMessageKeys = [
41 41
 			'wbqc-violation-message-format-clarification' => 'wbqc-violation-message-format',
@@ -47,37 +47,37 @@  discard block
 block discarded – undo
47 47
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
48 48
 	 * @return string
49 49
 	 */
50
-	public function render( $violationMessage ) {
51
-		if ( is_string( $violationMessage ) ) {
50
+	public function render($violationMessage) {
51
+		if (is_string($violationMessage)) {
52 52
 			// TODO remove this once all checkers produce ViolationMessage objects
53 53
 			return $violationMessage;
54 54
 		}
55 55
 
56
-		if ( !array_key_exists( $violationMessage->getMessageKey(), $this->alternativeMessageKeys ) ) {
57
-			return parent::render( $violationMessage );
56
+		if (!array_key_exists($violationMessage->getMessageKey(), $this->alternativeMessageKeys)) {
57
+			return parent::render($violationMessage);
58 58
 		}
59 59
 
60 60
 		$arguments = $violationMessage->getArguments();
61
-		$multilingualTextArgument = array_pop( $arguments );
61
+		$multilingualTextArgument = array_pop($arguments);
62 62
 		$multilingualTextParams = $this->renderMultilingualText(
63 63
 			$multilingualTextArgument['value'],
64 64
 			$multilingualTextArgument['role']
65 65
 		);
66 66
 
67
-		$paramsLists = [ [] ];
68
-		foreach ( $arguments as $argument ) {
69
-			$paramsLists[] = $this->renderArgument( $argument );
67
+		$paramsLists = [[]];
68
+		foreach ($arguments as $argument) {
69
+			$paramsLists[] = $this->renderArgument($argument);
70 70
 		}
71
-		$regularParams = call_user_func_array( 'array_merge', $paramsLists );
71
+		$regularParams = call_user_func_array('array_merge', $paramsLists);
72 72
 
73
-		if ( $multilingualTextParams === null ) {
74
-			return ( new Message( $this->alternativeMessageKeys[$violationMessage->getMessageKey()] ) )
75
-				->params( $regularParams )
73
+		if ($multilingualTextParams === null) {
74
+			return (new Message($this->alternativeMessageKeys[$violationMessage->getMessageKey()]))
75
+				->params($regularParams)
76 76
 				->escaped();
77 77
 		} else {
78
-			return ( new Message( $violationMessage->getMessageKey() ) )
79
-				->params( $regularParams )
80
-				->params( $multilingualTextParams )
78
+			return (new Message($violationMessage->getMessageKey()))
79
+				->params($regularParams)
80
+				->params($multilingualTextParams)
81 81
 				->escaped();
82 82
 		}
83 83
 	}
@@ -88,18 +88,18 @@  discard block
 block discarded – undo
88 88
 	 * @return array[]|null list of parameters as accepted by Message::params(),
89 89
 	 * or null if the text is not available in the user’s language
90 90
 	 */
91
-	protected function renderMultilingualText( MultilingualTextValue $text, $role ) {
91
+	protected function renderMultilingualText(MultilingualTextValue $text, $role) {
92 92
 		global $wgLang;
93 93
 		$languageCodes = $wgLang->getFallbackLanguages();
94
-		array_unshift( $languageCodes, $wgLang->getCode() );
94
+		array_unshift($languageCodes, $wgLang->getCode());
95 95
 
96 96
 		$texts = $text->getTexts();
97
-		foreach ( $languageCodes as $languageCode ) {
98
-			if ( array_key_exists( $languageCode, $texts ) ) {
99
-				return [ Message::rawParam( $this->addRole(
100
-					htmlspecialchars( $texts[$languageCode]->getText() ),
97
+		foreach ($languageCodes as $languageCode) {
98
+			if (array_key_exists($languageCode, $texts)) {
99
+				return [Message::rawParam($this->addRole(
100
+					htmlspecialchars($texts[$languageCode]->getText()),
101 101
 					$role
102
-				) ) ];
102
+				))];
103 103
 			}
104 104
 		}
105 105
 
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessage.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -110,17 +110,17 @@  discard block
 block discarded – undo
110 110
 	public function __construct(
111 111
 		$messageKey
112 112
 	) {
113
-		if ( strpos( $messageKey, self::MESSAGE_KEY_PREFIX ) !== 0 ) {
113
+		if (strpos($messageKey, self::MESSAGE_KEY_PREFIX) !== 0) {
114 114
 			throw new InvalidArgumentException(
115
-				'ViolationMessage key ⧼' .
116
-				$messageKey .
117
-				'⧽ should start with "' .
118
-				self::MESSAGE_KEY_PREFIX .
115
+				'ViolationMessage key ⧼'.
116
+				$messageKey.
117
+				'⧽ should start with "'.
118
+				self::MESSAGE_KEY_PREFIX.
119 119
 				'".'
120 120
 			);
121 121
 		}
122 122
 
123
-		$this->messageKeySuffix = substr( $messageKey, strlen( self::MESSAGE_KEY_PREFIX ) );
123
+		$this->messageKeySuffix = substr($messageKey, strlen(self::MESSAGE_KEY_PREFIX));
124 124
 		$this->arguments = [];
125 125
 	}
126 126
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	 * @return string
130 130
 	 */
131 131
 	public function getMessageKey() {
132
-		return self::MESSAGE_KEY_PREFIX . $this->messageKeySuffix;
132
+		return self::MESSAGE_KEY_PREFIX.$this->messageKeySuffix;
133 133
 	}
134 134
 
135 135
 	/**
@@ -149,9 +149,9 @@  discard block
 block discarded – undo
149 149
 	 * @param mixed $value the value, which should match the $type
150 150
 	 * @return ViolationMessage
151 151
 	 */
152
-	public function withArgument( $type, $role, $value ) {
152
+	public function withArgument($type, $role, $value) {
153 153
 		$ret = clone $this;
154
-		$ret->arguments[] = [ 'type' => $type, 'role' => $role, 'value' => $value ];
154
+		$ret->arguments[] = ['type' => $type, 'role' => $role, 'value' => $value];
155 155
 		return $ret;
156 156
 	}
157 157
 
@@ -163,8 +163,8 @@  discard block
 block discarded – undo
163 163
 	 * @param string|null $role one of the Role::* constants
164 164
 	 * @return ViolationMessage
165 165
 	 */
166
-	public function withEntityId( EntityId $entityId, $role = null ) {
167
-		return $this->withArgument( self::TYPE_ENTITY_ID, $role, $entityId );
166
+	public function withEntityId(EntityId $entityId, $role = null) {
167
+		return $this->withArgument(self::TYPE_ENTITY_ID, $role, $entityId);
168 168
 	}
169 169
 
170 170
 	/**
@@ -181,8 +181,8 @@  discard block
 block discarded – undo
181 181
 	 * @param string|null $role one of the Role::* constants
182 182
 	 * @return ViolationMessage
183 183
 	 */
184
-	public function withEntityIdList( array $entityIdList, $role = null ) {
185
-		return $this->withArgument( self::TYPE_ENTITY_ID_LIST, $role, $entityIdList );
184
+	public function withEntityIdList(array $entityIdList, $role = null) {
185
+		return $this->withArgument(self::TYPE_ENTITY_ID_LIST, $role, $entityIdList);
186 186
 	}
187 187
 
188 188
 	/**
@@ -193,8 +193,8 @@  discard block
 block discarded – undo
193 193
 	 * @param string|null $role one of the Role::* constants
194 194
 	 * @return ViolationMessage
195 195
 	 */
196
-	public function withItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
197
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value );
196
+	public function withItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
197
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value);
198 198
 	}
199 199
 
200 200
 	/**
@@ -211,8 +211,8 @@  discard block
 block discarded – undo
211 211
 	 * @param string|null $role one of the Role::* constants
212 212
 	 * @return ViolationMessage
213 213
 	 */
214
-	public function withItemIdSnakValueList( array $valueList, $role = null ) {
215
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList );
214
+	public function withItemIdSnakValueList(array $valueList, $role = null) {
215
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList);
216 216
 	}
217 217
 
218 218
 	/**
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
 	 * @param string|null $role one of the Role::* constants
224 224
 	 * @return ViolationMessage
225 225
 	 */
226
-	public function withDataValue( DataValue $dataValue, $role = null ) {
227
-		return $this->withArgument( self::TYPE_DATA_VALUE, $role, $dataValue );
226
+	public function withDataValue(DataValue $dataValue, $role = null) {
227
+		return $this->withArgument(self::TYPE_DATA_VALUE, $role, $dataValue);
228 228
 	}
229 229
 
230 230
 	/**
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
 	 * @param string|null $role one of the Role::* constants
240 240
 	 * @return ViolationMessage
241 241
 	 */
242
-	public function withDataValueType( $dataValueType, $role = null ) {
243
-		return $this->withArgument( self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType );
242
+	public function withDataValueType($dataValueType, $role = null) {
243
+		return $this->withArgument(self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType);
244 244
 	}
245 245
 
246 246
 	/**
@@ -251,8 +251,8 @@  discard block
 block discarded – undo
251 251
 	 * @param string|null $role one of the Role::* constants
252 252
 	 * @return ViolationMessage
253 253
 	 */
254
-	public function withInlineCode( $code, $role = null ) {
255
-		return $this->withArgument( self::TYPE_INLINE_CODE, $role, $code );
254
+	public function withInlineCode($code, $role = null) {
255
+		return $this->withArgument(self::TYPE_INLINE_CODE, $role, $code);
256 256
 	}
257 257
 
258 258
 	/**
@@ -263,8 +263,8 @@  discard block
 block discarded – undo
263 263
 	 * @param string|null $role one of the Role::* constants
264 264
 	 * @return ViolationMessage
265 265
 	 */
266
-	public function withConstraintScope( $scope, $role = null ) {
267
-		return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE, $role, $scope );
266
+	public function withConstraintScope($scope, $role = null) {
267
+		return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE, $role, $scope);
268 268
 	}
269 269
 
270 270
 	/**
@@ -275,8 +275,8 @@  discard block
 block discarded – undo
275 275
 	 * @param string|null $role one of the Role::* constants
276 276
 	 * @return ViolationMessage
277 277
 	 */
278
-	public function withConstraintScopeList( array $scopeList, $role = null ) {
279
-		return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList );
278
+	public function withConstraintScopeList(array $scopeList, $role = null) {
279
+		return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList);
280 280
 	}
281 281
 
282 282
 	/**
@@ -291,8 +291,8 @@  discard block
 block discarded – undo
291 291
 	 * @param string $languageCode
292 292
 	 * @return ViolationMessage
293 293
 	 */
294
-	public function withLanguage( $languageCode ) {
295
-		return $this->withArgument( self::TYPE_LANGUAGE, null, $languageCode );
294
+	public function withLanguage($languageCode) {
295
+		return $this->withArgument(self::TYPE_LANGUAGE, null, $languageCode);
296 296
 	}
297 297
 
298 298
 	/**
@@ -307,8 +307,8 @@  discard block
 block discarded – undo
307 307
 	 * @param string|null $role one of the Role::* constants
308 308
 	 * @return ViolationMessage
309 309
 	 */
310
-	public function withMultilingualText( MultilingualTextValue $text, $role = null ) {
311
-		return $this->withArgument( self::TYPE_MULTILINGUAL_TEXT, $role, $text );
310
+	public function withMultilingualText(MultilingualTextValue $text, $role = null) {
311
+		return $this->withArgument(self::TYPE_MULTILINGUAL_TEXT, $role, $text);
312 312
 	}
313 313
 
314 314
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessageRenderer.php 1 patch
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -69,21 +69,21 @@  discard block
 block discarded – undo
69 69
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
70 70
 	 * @return string
71 71
 	 */
72
-	public function render( $violationMessage ) {
73
-		if ( is_string( $violationMessage ) ) {
72
+	public function render($violationMessage) {
73
+		if (is_string($violationMessage)) {
74 74
 			// TODO remove this once all checkers produce ViolationMessage objects
75 75
 			return $violationMessage;
76 76
 		}
77 77
 
78 78
 		$messageKey = $violationMessage->getMessageKey();
79
-		$paramsLists = [ [] ];
80
-		foreach ( $violationMessage->getArguments() as $argument ) {
81
-			$params = $this->renderArgument( $argument );
79
+		$paramsLists = [[]];
80
+		foreach ($violationMessage->getArguments() as $argument) {
81
+			$params = $this->renderArgument($argument);
82 82
 			$paramsLists[] = $params;
83 83
 		}
84
-		$allParams = call_user_func_array( 'array_merge', $paramsLists );
85
-		return ( new Message( $messageKey ) )
86
-			->params( $allParams )
84
+		$allParams = call_user_func_array('array_merge', $paramsLists);
85
+		return (new Message($messageKey))
86
+			->params($allParams)
87 87
 			->escaped();
88 88
 	}
89 89
 
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
 	 * @param string|null $role one of the Role::* constants
93 93
 	 * @return string HTML
94 94
 	 */
95
-	protected function addRole( $value, $role ) {
96
-		if ( $role === null ) {
95
+	protected function addRole($value, $role) {
96
+		if ($role === null) {
97 97
 			return $value;
98 98
 		}
99 99
 
100
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
101
-			$value .
100
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
101
+			$value.
102 102
 			'</span>';
103 103
 	}
104 104
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	 * @param array $argument
107 107
 	 * @return array[] params (for Message::params)
108 108
 	 */
109
-	protected function renderArgument( array $argument ) {
109
+	protected function renderArgument(array $argument) {
110 110
 		$methods = [
111 111
 			ViolationMessage::TYPE_ENTITY_ID => 'renderEntityId',
112 112
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'renderEntityIdList',
@@ -124,12 +124,12 @@  discard block
 block discarded – undo
124 124
 		$value = $argument['value'];
125 125
 		$role = $argument['role'];
126 126
 
127
-		if ( array_key_exists( $type, $methods ) ) {
127
+		if (array_key_exists($type, $methods)) {
128 128
 			$method = $methods[$type];
129
-			$params = $this->$method( $value, $role );
129
+			$params = $this->$method($value, $role);
130 130
 		} else {
131 131
 			throw new InvalidArgumentException(
132
-				'Unknown ViolationMessage argument type ' . $type . '!'
132
+				'Unknown ViolationMessage argument type '.$type.'!'
133 133
 			);
134 134
 		}
135 135
 
@@ -143,46 +143,46 @@  discard block
 block discarded – undo
143 143
 	 * and return a single-element array with a raw message param (i. e. [ Message::rawParam( … ) ])
144 144
 	 * @return array[] list of parameters as accepted by Message::params()
145 145
 	 */
146
-	private function renderList( array $list, $role, callable $render ) {
147
-		if ( $list === [] ) {
146
+	private function renderList(array $list, $role, callable $render) {
147
+		if ($list === []) {
148 148
 			return [
149
-				Message::numParam( 0 ),
150
-				Message::rawParam( '<ul></ul>' ),
149
+				Message::numParam(0),
150
+				Message::rawParam('<ul></ul>'),
151 151
 			];
152 152
 		}
153 153
 
154
-		if ( count( $list ) > $this->maxListLength ) {
155
-			$list = array_slice( $list, 0, $this->maxListLength );
154
+		if (count($list) > $this->maxListLength) {
155
+			$list = array_slice($list, 0, $this->maxListLength);
156 156
 			$truncated = true;
157 157
 		}
158 158
 
159 159
 		$renderedParamsLists = array_map(
160 160
 			$render,
161 161
 			$list,
162
-			array_fill( 0, count( $list ), $role )
162
+			array_fill(0, count($list), $role)
163 163
 		);
164 164
 		$renderedParams = array_map(
165
-			function ( $params ) {
165
+			function($params) {
166 166
 				return $params[0];
167 167
 			},
168 168
 			$renderedParamsLists
169 169
 		);
170 170
 		$renderedElements = array_map(
171
-			function ( $param ) {
171
+			function($param) {
172 172
 				return $param['raw'];
173 173
 			},
174 174
 			$renderedParams
175 175
 		);
176
-		if ( isset( $truncated ) ) {
177
-			$renderedElements[] = wfMessage( 'ellipsis' )->escaped();
176
+		if (isset($truncated)) {
177
+			$renderedElements[] = wfMessage('ellipsis')->escaped();
178 178
 		}
179 179
 
180 180
 		return array_merge(
181 181
 			[
182
-				Message::numParam( count( $list ) ),
182
+				Message::numParam(count($list)),
183 183
 				Message::rawParam(
184
-					'<ul><li>' .
185
-					implode( '</li><li>', $renderedElements ) .
184
+					'<ul><li>'.
185
+					implode('</li><li>', $renderedElements).
186 186
 					'</li></ul>'
187 187
 				),
188 188
 			],
@@ -195,11 +195,11 @@  discard block
 block discarded – undo
195 195
 	 * @param string|null $role one of the Role::* constants
196 196
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
197 197
 	 */
198
-	private function renderEntityId( EntityId $entityId, $role ) {
199
-		return [ Message::rawParam( $this->addRole(
200
-			$this->entityIdFormatter->formatEntityId( $entityId ),
198
+	private function renderEntityId(EntityId $entityId, $role) {
199
+		return [Message::rawParam($this->addRole(
200
+			$this->entityIdFormatter->formatEntityId($entityId),
201 201
 			$role
202
-		) ) ];
202
+		))];
203 203
 	}
204 204
 
205 205
 	/**
@@ -207,8 +207,8 @@  discard block
 block discarded – undo
207 207
 	 * @param string|null $role one of the Role::* constants
208 208
 	 * @return array[] list of parameters as accepted by Message::params()
209 209
 	 */
210
-	private function renderEntityIdList( array $entityIdList, $role ) {
211
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
210
+	private function renderEntityIdList(array $entityIdList, $role) {
211
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
212 212
 	}
213 213
 
214 214
 	/**
@@ -216,24 +216,24 @@  discard block
 block discarded – undo
216 216
 	 * @param string|null $role one of the Role::* constants
217 217
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
218 218
 	 */
219
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, $role ) {
220
-		switch ( true ) {
219
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, $role) {
220
+		switch (true) {
221 221
 			case $value->isValue():
222
-				return $this->renderEntityId( $value->getItemId(), $role );
222
+				return $this->renderEntityId($value->getItemId(), $role);
223 223
 			case $value->isSomeValue():
224
-				return [ Message::rawParam( $this->addRole(
225
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
226
-						wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped() .
224
+				return [Message::rawParam($this->addRole(
225
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
226
+						wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped().
227 227
 						'</span>',
228 228
 					$role
229
-				) ) ];
229
+				))];
230 230
 			case $value->isNoValue():
231
-				return [ Message::rawParam( $this->addRole(
232
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
233
-						wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped() .
231
+				return [Message::rawParam($this->addRole(
232
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
233
+						wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped().
234 234
 						'</span>',
235 235
 					$role
236
-				) ) ];
236
+				))];
237 237
 			default:
238 238
 				// @codeCoverageIgnoreStart
239 239
 				throw new LogicException(
@@ -248,8 +248,8 @@  discard block
 block discarded – undo
248 248
 	 * @param string|null $role one of the Role::* constants
249 249
 	 * @return array[] list of parameters as accepted by Message::params()
250 250
 	 */
251
-	private function renderItemIdSnakValueList( array $valueList, $role ) {
252
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
251
+	private function renderItemIdSnakValueList(array $valueList, $role) {
252
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
253 253
 	}
254 254
 
255 255
 	/**
@@ -257,11 +257,11 @@  discard block
 block discarded – undo
257 257
 	 * @param string|null $role one of the Role::* constants
258 258
 	 * @return array[] list of parameters as accepted by Message::params()
259 259
 	 */
260
-	private function renderDataValue( DataValue $dataValue, $role ) {
261
-		return [ Message::rawParam( $this->addRole(
262
-			$this->dataValueFormatter->format( $dataValue ),
260
+	private function renderDataValue(DataValue $dataValue, $role) {
261
+		return [Message::rawParam($this->addRole(
262
+			$this->dataValueFormatter->format($dataValue),
263 263
 			$role
264
-		) ) ];
264
+		))];
265 265
 	}
266 266
 
267 267
 	/**
@@ -269,22 +269,22 @@  discard block
 block discarded – undo
269 269
 	 * @param string|null $role one of the Role::* constants
270 270
 	 * @return array[] list of parameters as accepted by Message::params()
271 271
 	 */
272
-	private function renderDataValueType( $dataValueType, $role ) {
272
+	private function renderDataValueType($dataValueType, $role) {
273 273
 		$messageKeys = [
274 274
 			'string' => 'datatypes-type-string',
275 275
 			'monolingualtext' => 'datatypes-monolingualtext',
276 276
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
277 277
 		];
278 278
 
279
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
280
-			return [ Message::rawParam( $this->addRole(
281
-				wfMessage( $messageKeys[$dataValueType] )->escaped(),
279
+		if (array_key_exists($dataValueType, $messageKeys)) {
280
+			return [Message::rawParam($this->addRole(
281
+				wfMessage($messageKeys[$dataValueType])->escaped(),
282 282
 				$role
283
-			) ) ];
283
+			))];
284 284
 		} else {
285 285
 			// @codeCoverageIgnoreStart
286 286
 			throw new LogicException(
287
-				'Unknown data value type ' . $dataValueType
287
+				'Unknown data value type '.$dataValueType
288 288
 			);
289 289
 			// @codeCoverageIgnoreEnd
290 290
 		}
@@ -295,11 +295,11 @@  discard block
 block discarded – undo
295 295
 	 * @param string|null $role one of the Role::* constants
296 296
 	 * @return array[] list of parameters as accepted by Message::params()
297 297
 	 */
298
-	private function renderInlineCode( $code, $role ) {
299
-		return [ Message::rawParam( $this->addRole(
300
-			'<code>' . htmlspecialchars( $code ) . '</code>',
298
+	private function renderInlineCode($code, $role) {
299
+		return [Message::rawParam($this->addRole(
300
+			'<code>'.htmlspecialchars($code).'</code>',
301 301
 			$role
302
-		) ) ];
302
+		))];
303 303
 	}
304 304
 
305 305
 	/**
@@ -307,8 +307,8 @@  discard block
 block discarded – undo
307 307
 	 * @param string|null $role one of the Role::* constants
308 308
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
309 309
 	 */
310
-	private function renderConstraintScope( $scope, $role ) {
311
-		switch ( $scope ) {
310
+	private function renderConstraintScope($scope, $role) {
311
+		switch ($scope) {
312 312
 			case Context::TYPE_STATEMENT:
313 313
 				$itemId = $this->config->get(
314 314
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -328,10 +328,10 @@  discard block
 block discarded – undo
328 328
 				// callers should never let this happen, but if it does happen,
329 329
 				// showing “unknown value” seems reasonable
330 330
 				// @codeCoverageIgnoreStart
331
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
331
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
332 332
 				// @codeCoverageIgnoreEnd
333 333
 		}
334
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
334
+		return $this->renderEntityId(new ItemId($itemId), $role);
335 335
 	}
336 336
 
337 337
 	/**
@@ -339,8 +339,8 @@  discard block
 block discarded – undo
339 339
 	 * @param string|null $role one of the Role::* constants
340 340
 	 * @return array[] list of parameters as accepted by Message::params()
341 341
 	 */
342
-	private function renderConstraintScopeList( array $scopeList, $role ) {
343
-		return $this->renderList( $scopeList, $role, [ $this, 'renderConstraintScope' ] );
342
+	private function renderConstraintScopeList(array $scopeList, $role) {
343
+		return $this->renderList($scopeList, $role, [$this, 'renderConstraintScope']);
344 344
 	}
345 345
 
346 346
 	/**
@@ -348,10 +348,10 @@  discard block
 block discarded – undo
348 348
 	 * @param string|null $role one of the Role::* constants
349 349
 	 * @return array[] list of parameters as accepted by Message::params()
350 350
 	 */
351
-	private function renderLanguage( $languageCode, $role ) {
351
+	private function renderLanguage($languageCode, $role) {
352 352
 		return [
353
-			Message::plaintextParam( Language::fetchLanguageName( $languageCode ) ),
354
-			Message::plaintextParam( $languageCode ),
353
+			Message::plaintextParam(Language::fetchLanguageName($languageCode)),
354
+			Message::plaintextParam($languageCode),
355 355
 		];
356 356
 	}
357 357
 
Please login to merge, or discard this patch.
src/Api/CheckConstraints.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -77,21 +77,21 @@  discard block
 block discarded – undo
77 77
 	 *
78 78
 	 * @return self
79 79
 	 */
80
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
80
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
81 81
 		$repo = WikibaseRepo::getDefaultInstance();
82 82
 
83 83
 		$language = $repo->getUserLanguage();
84 84
 		$formatterOptions = new FormatterOptions();
85
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
85
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
86 86
 		$valueFormatterFactory = $repo->getValueFormatterFactory();
87
-		$valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
87
+		$valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
88 88
 
89 89
 		$languageFallbackLabelDescriptionLookupFactory = $repo->getLanguageFallbackLabelDescriptionLookupFactory();
90
-		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup( $language );
90
+		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup($language);
91 91
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
92
-		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
92
+		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
93 93
 		$entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory();
94
-		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
94
+		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
95 95
 		$config = MediaWikiServices::getInstance()->getMainConfig();
96 96
 		$titleParser = MediaWikiServices::getInstance()->getTitleParser();
97 97
 		$unitConverter = $repo->getUnitConverter();
@@ -124,10 +124,10 @@  discard block
 block discarded – undo
124 124
 			$repo->getEntityTitleLookup(),
125 125
 			$entityIdLabelFormatter,
126 126
 			$constraintParameterRenderer,
127
-			new MultilingualTextViolationMessageRenderer( $entityIdHtmlLinkFormatter, $valueFormatter, $config ),
127
+			new MultilingualTextViolationMessageRenderer($entityIdHtmlLinkFormatter, $valueFormatter, $config),
128 128
 			$config
129 129
 		);
130
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
130
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
131 131
 			$wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
132 132
 				$repo->getEntityNamespaceLookup()
133 133
 			);
@@ -138,12 +138,12 @@  discard block
 block discarded – undo
138 138
 				ResultsCache::getDefaultInstance(),
139 139
 				$wikiPageEntityMetaDataAccessor,
140 140
 				$entityIdParser,
141
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
141
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
142 142
 				[
143
-					$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
144
-					$config->get( 'WBQualityConstraintsTypeConstraintId' ),
145
-					$config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
146
-					$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
143
+					$config->get('WBQualityConstraintsCommonsLinkConstraintId'),
144
+					$config->get('WBQualityConstraintsTypeConstraintId'),
145
+					$config->get('WBQualityConstraintsValueTypeConstraintId'),
146
+					$config->get('WBQualityConstraintsDistinctValuesConstraintId'),
147 147
 				],
148 148
 				$dataFactory
149 149
 			);
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 			$prefix,
156 156
 			$repo->getEntityIdParser(),
157 157
 			$repo->getStatementGuidValidator(),
158
-			$repo->getApiHelperFactory( RequestContext::getMain() ),
158
+			$repo->getApiHelperFactory(RequestContext::getMain()),
159 159
 			$resultsBuilder,
160 160
 			$dataFactory
161 161
 		);
@@ -181,11 +181,11 @@  discard block
 block discarded – undo
181 181
 		ResultsBuilder $resultsBuilder,
182 182
 		IBufferingStatsdDataFactory $dataFactory
183 183
 	) {
184
-		parent::__construct( $main, $name, $prefix );
184
+		parent::__construct($main, $name, $prefix);
185 185
 		$this->entityIdParser = $entityIdParser;
186 186
 		$this->statementGuidValidator = $statementGuidValidator;
187
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
188
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
187
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
188
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
189 189
 		$this->resultsBuilder = $resultsBuilder;
190 190
 		$this->dataFactory = $dataFactory;
191 191
 	}
@@ -200,9 +200,9 @@  discard block
 block discarded – undo
200 200
 
201 201
 		$params = $this->extractRequestParams();
202 202
 
203
-		$this->validateParameters( $params );
204
-		$entityIds = $this->parseEntityIds( $params );
205
-		$claimIds = $this->parseClaimIds( $params );
203
+		$this->validateParameters($params);
204
+		$entityIds = $this->parseEntityIds($params);
205
+		$claimIds = $this->parseClaimIds($params);
206 206
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
207 207
 		$statuses = $params[self::PARAM_STATUS];
208 208
 
@@ -217,13 +217,13 @@  discard block
 block discarded – undo
217 217
 			)->getArray()
218 218
 		);
219 219
 		// ensure that result contains the given entity IDs even if they have no statements
220
-		foreach ( $entityIds as $entityId ) {
220
+		foreach ($entityIds as $entityId) {
221 221
 			$this->getResult()->addArrayType(
222
-				[ $this->getModuleName(), $entityId->getSerialization() ],
222
+				[$this->getModuleName(), $entityId->getSerialization()],
223 223
 				'assoc'
224 224
 			);
225 225
 		}
226
-		$this->resultBuilder->markSuccess( 1 );
226
+		$this->resultBuilder->markSuccess(1);
227 227
 	}
228 228
 
229 229
 	/**
@@ -231,24 +231,24 @@  discard block
 block discarded – undo
231 231
 	 *
232 232
 	 * @return EntityId[]
233 233
 	 */
234
-	private function parseEntityIds( array $params ) {
234
+	private function parseEntityIds(array $params) {
235 235
 		$ids = $params[self::PARAM_ID];
236 236
 
237
-		if ( $ids === null ) {
237
+		if ($ids === null) {
238 238
 			return [];
239
-		} elseif ( $ids === [] ) {
239
+		} elseif ($ids === []) {
240 240
 			$this->errorReporter->dieError(
241
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
241
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
242 242
 		}
243 243
 
244
-		return array_map( function ( $id ) {
244
+		return array_map(function($id) {
245 245
 			try {
246
-				return $this->entityIdParser->parse( $id );
247
-			} catch ( EntityIdParsingException $e ) {
246
+				return $this->entityIdParser->parse($id);
247
+			} catch (EntityIdParsingException $e) {
248 248
 				$this->errorReporter->dieError(
249
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
249
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
250 250
 			}
251
-		}, $ids );
251
+		}, $ids);
252 252
 	}
253 253
 
254 254
 	/**
@@ -256,35 +256,35 @@  discard block
 block discarded – undo
256 256
 	 *
257 257
 	 * @return string[]
258 258
 	 */
259
-	private function parseClaimIds( array $params ) {
259
+	private function parseClaimIds(array $params) {
260 260
 		$ids = $params[self::PARAM_CLAIM_ID];
261 261
 
262
-		if ( $ids === null ) {
262
+		if ($ids === null) {
263 263
 			return [];
264
-		} elseif ( $ids === [] ) {
264
+		} elseif ($ids === []) {
265 265
 			$this->errorReporter->dieError(
266
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
266
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
267 267
 		}
268 268
 
269
-		foreach ( $ids as $id ) {
270
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
269
+		foreach ($ids as $id) {
270
+			if (!$this->statementGuidValidator->validate($id)) {
271 271
 				$this->errorReporter->dieError(
272
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
272
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
273 273
 			}
274 274
 		}
275 275
 
276 276
 		return $ids;
277 277
 	}
278 278
 
279
-	private function validateParameters( array $params ) {
280
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
281
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
279
+	private function validateParameters(array $params) {
280
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
281
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
282 282
 		) {
283 283
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
284 284
 			$this->errorReporter->dieError(
285 285
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
286 286
 		}
287
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
287
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
288 288
 			$paramId = self::PARAM_ID;
289 289
 			$paramClaimId = self::PARAM_CLAIM_ID;
290 290
 			$this->errorReporter->dieError(
Please login to merge, or discard this patch.