Inspection of "Merge "Use Language::factory( 'en' ) instead of ne..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7b7d2e...94ab99 )

unknown

created 2018-08-20 12:04 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -36,16 +36,16 @@
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-reference');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -71,40 +71,40 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
 		$status = CheckResult::STATUS_VIOLATION;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
+			if ($propertyId->equals($qualifier->getPropertyId())) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -71,53 +71,53 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$properties = $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$properties = $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$parameters['property'] = $properties;
 
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
 			$allowedQualifier = false;
-			foreach ( $properties as $property ) {
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
+			foreach ($properties as $property) {
+				if ($qualifier->getPropertyId()->equals($property)) {
 					$allowedQualifier = true;
 					break;
 				}
 			}
-			if ( !$allowedQualifier ) {
-				if ( empty( $properties ) || $properties === [ '' ] ) {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+			if (!$allowedQualifier) {
+				if (empty($properties) || $properties === ['']) {
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 				} else {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
 				}
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/UniqueValueChecker.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -74,22 +74,22 @@  discard block
 block discarded – undo
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
-		if ( $this->sparqlHelper !== null ) {
-			if ( $context->getType() === 'statement' ) {
+		if ($this->sparqlHelper !== null) {
+			if ($context->getType() === 'statement') {
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
 					$context->getSnakStatement(),
 					true // ignore deprecated statements
 				);
 			} else {
-				if ( $context->getSnak()->getType() !== 'value' ) {
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+				if ($context->getSnak()->getType() !== 'value') {
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -102,27 +102,27 @@  discard block
 block discarded – undo
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/OneOfChecker.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -68,41 +68,41 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
 		$parameters['item'] = $items;
 
 		$snak = $context->getSnak();
 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-			->withItemIdSnakValueList( $items, Role::OBJECT );
+		$message = (new ViolationMessage('wbqc-violation-message-one-of'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+			->withItemIdSnakValueList($items, Role::OBJECT);
 		$status = CheckResult::STATUS_VIOLATION;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ItemChecker.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -86,18 +86,18 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		/*
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
@@ -118,31 +118,31 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SymmetricChecker.php 1 patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -81,9 +81,9 @@  discard block
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
 		$snak = $context->getSnak();
 		$propertyId = $context->getSnak()->getPropertyId();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -102,19 +102,19 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( $targetEntity === null ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if ($targetEntity === null) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -122,23 +122,23 @@  discard block
 block discarded – undo
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $symmetricStatement !== null ) {
+		if ($symmetricStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php 1 patch

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -89,25 +89,25 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -116,19 +116,19 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( $targetEntity === null ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if ($targetEntity === null) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -149,33 +149,33 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/InverseChecker.php 1 patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -91,22 +91,22 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -115,19 +115,19 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( $targetEntity === null ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if ($targetEntity === null) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -135,28 +135,28 @@  discard block
 block discarded – undo
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $inverseStatement !== null ) {
+		if ($inverseStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-inverse'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

		@@ -86,18 +86,18 @@ discard block
		block discarded – undo
86	86	* @throws ConstraintParameterException
87	87	* @return CheckResult
88	88	*/
89		- public function checkConstraint( Context $context, Constraint $constraint ) {
90		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
91		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	89	+ public function checkConstraint(Context $context, Constraint $constraint) {
	90	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	91	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
92	92	}
93	93
94	94	$parameters = [];
95	95	$constraintParameters = $constraint->getConstraintParameters();
96	96
97		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
98		- $parameters['property'] = [ $propertyId ];
	97	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	98	+ $parameters['property'] = [$propertyId];
99	99
100		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
	100	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
101	101	$parameters['items'] = $items;
102	102
103	103	/*
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	* a) a property only
106	106	* b) a property and a number of items (each combination of property and item forming an individual claim)
107	107	*/
108		- if ( $items === [] ) {
	108	+ if ($items === []) {
109	109	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
110	110	$context->getEntity()->getStatements(),
111	111	$propertyId
		@@ -118,31 +118,31 @@ discard block
		block discarded – undo
118	118	);
119	119	}
120	120
121		- if ( $requiredStatement !== null ) {
	121	+ if ($requiredStatement !== null) {
122	122	$status = CheckResult::STATUS_COMPLIANCE;
123	123	$message = null;
124	124	} else {
125	125	$status = CheckResult::STATUS_VIOLATION;
126		- $message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
127		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
128		- ->withEntityId( $propertyId, Role::PREDICATE )
129		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	126	+ $message = (new ViolationMessage('wbqc-violation-message-item'))
	127	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	128	+ ->withEntityId($propertyId, Role::PREDICATE)
	129	+ ->withItemIdSnakValueList($items, Role::OBJECT);
130	130	}
131	131
132		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	132	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
133	133	}
134	134
135		- public function checkConstraintParameters( Constraint $constraint ) {
	135	+ public function checkConstraintParameters(Constraint $constraint) {
136	136	$constraintParameters = $constraint->getConstraintParameters();
137	137	$exceptions = [];
138	138	try {
139		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
140		- } catch ( ConstraintParameterException $e ) {
	139	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	140	+ } catch (ConstraintParameterException $e) {
141	141	$exceptions[] = $e;
142	142	}
143	143	try {
144		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
145		- } catch ( ConstraintParameterException $e ) {
	144	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
	145	+ } catch (ConstraintParameterException $e) {
146	146	$exceptions[] = $e;
147	147	}
148	148	return $exceptions;

		@@ -89,25 +89,25 @@ discard block
		block discarded – undo
89	89	* @throws ConstraintParameterException
90	90	* @return CheckResult
91	91	*/
92		- public function checkConstraint( Context $context, Constraint $constraint ) {
93		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
94		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	92	+ public function checkConstraint(Context $context, Constraint $constraint) {
	93	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	94	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
95	95	}
96	96
97	97	$parameters = [];
98	98	$constraintParameters = $constraint->getConstraintParameters();
99	99
100		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
101		- $parameters['property'] = [ $propertyId ];
	100	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	101	+ $parameters['property'] = [$propertyId];
102	102
103		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
	103	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
104	104	$parameters['items'] = $items;
105	105
106	106	$snak = $context->getSnak();
107	107
108		- if ( !$snak instanceof PropertyValueSnak ) {
	108	+ if (!$snak instanceof PropertyValueSnak) {
109	109	// nothing to check
110		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	110	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
111	111	}
112	112
113	113	$dataValue = $snak->getDataValue();
		@@ -116,19 +116,19 @@ discard block
		block discarded – undo
116	116	* error handling:
117	117	* type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
118	118	*/
119		- if ( $dataValue->getType() !== 'wikibase-entityid' ) {
120		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
121		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
122		- ->withDataValueType( 'wikibase-entityid' );
123		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	119	+ if ($dataValue->getType() !== 'wikibase-entityid') {
	120	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	121	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	122	+ ->withDataValueType('wikibase-entityid');
	123	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
124	124	}
125	125	/** @var EntityIdValue $dataValue */
126	126
127	127	$targetEntityId = $dataValue->getEntityId();
128		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
129		- if ( $targetEntity === null ) {
130		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
131		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	128	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	129	+ if ($targetEntity === null) {
	130	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	131	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
132	132	}
133	133
134	134	/*
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	* a) a property only
137	137	* b) a property and a number of items (each combination forming an individual claim)
138	138	*/
139		- if ( $items === [] ) {
	139	+ if ($items === []) {
140	140	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
141	141	$targetEntity->getStatements(),
142	142	$propertyId
		@@ -149,33 +149,33 @@ discard block
		block discarded – undo
149	149	);
150	150	}
151	151
152		- if ( $requiredStatement !== null ) {
	152	+ if ($requiredStatement !== null) {
153	153	$status = CheckResult::STATUS_COMPLIANCE;
154	154	$message = null;
155	155	} else {
156	156	$status = CheckResult::STATUS_VIOLATION;
157		- $message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
158		- ->withEntityId( $targetEntityId, Role::SUBJECT )
159		- ->withEntityId( $propertyId, Role::PREDICATE )
160		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	157	+ $message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
	158	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	159	+ ->withEntityId($propertyId, Role::PREDICATE)
	160	+ ->withItemIdSnakValueList($items, Role::OBJECT);
161	161	}
162	162
163		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
164		- ->withMetadata( Metadata::ofDependencyMetadata(
165		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	163	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	164	+ ->withMetadata(Metadata::ofDependencyMetadata(
	165	+ DependencyMetadata::ofEntityId($targetEntityId) ));
166	166	}
167	167
168		- public function checkConstraintParameters( Constraint $constraint ) {
	168	+ public function checkConstraintParameters(Constraint $constraint) {
169	169	$constraintParameters = $constraint->getConstraintParameters();
170	170	$exceptions = [];
171	171	try {
172		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
173		- } catch ( ConstraintParameterException $e ) {
	172	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	173	+ } catch (ConstraintParameterException $e) {
174	174	$exceptions[] = $e;
175	175	}
176	176	try {
177		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
178		- } catch ( ConstraintParameterException $e ) {
	177	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
	178	+ } catch (ConstraintParameterException $e) {
179	179	$exceptions[] = $e;
180	180	}
181	181	return $exceptions;

		@@ -91,22 +91,22 @@ discard block
		block discarded – undo
91	91	* @throws ConstraintParameterException
92	92	* @return CheckResult
93	93	*/
94		- public function checkConstraint( Context $context, Constraint $constraint ) {
95		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
96		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	94	+ public function checkConstraint(Context $context, Constraint $constraint) {
	95	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	96	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
97	97	}
98	98
99	99	$parameters = [];
100	100	$constraintParameters = $constraint->getConstraintParameters();
101	101
102		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
103		- $parameters['property'] = [ $propertyId ];
	102	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	103	+ $parameters['property'] = [$propertyId];
104	104
105	105	$snak = $context->getSnak();
106	106
107		- if ( !$snak instanceof PropertyValueSnak ) {
	107	+ if (!$snak instanceof PropertyValueSnak) {
108	108	// nothing to check
109		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	109	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
110	110	}
111	111
112	112	$dataValue = $snak->getDataValue();
		@@ -115,19 +115,19 @@ discard block
		block discarded – undo
115	115	* error handling:
116	116	* type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
117	117	*/
118		- if ( $dataValue->getType() !== 'wikibase-entityid' ) {
119		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
120		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
121		- ->withDataValueType( 'wikibase-entityid' );
122		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	118	+ if ($dataValue->getType() !== 'wikibase-entityid') {
	119	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	120	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	121	+ ->withDataValueType('wikibase-entityid');
	122	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
123	123	}
124	124	/** @var EntityIdValue $dataValue */
125	125
126	126	$targetEntityId = $dataValue->getEntityId();
127		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
128		- if ( $targetEntity === null ) {
129		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
130		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	127	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	128	+ if ($targetEntity === null) {
	129	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	130	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
131	131	}
132	132
133	133	$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
		@@ -135,28 +135,28 @@ discard block
		block discarded – undo
135	135	$propertyId,
136	136	$context->getEntity()->getId()
137	137	);
138		- if ( $inverseStatement !== null ) {
	138	+ if ($inverseStatement !== null) {
139	139	$message = null;
140	140	$status = CheckResult::STATUS_COMPLIANCE;
141	141	} else {
142		- $message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
143		- ->withEntityId( $targetEntityId, Role::SUBJECT )
144		- ->withEntityId( $propertyId, Role::PREDICATE )
145		- ->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
	142	+ $message = (new ViolationMessage('wbqc-violation-message-inverse'))
	143	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	144	+ ->withEntityId($propertyId, Role::PREDICATE)
	145	+ ->withEntityId($context->getEntity()->getId(), Role::OBJECT);
146	146	$status = CheckResult::STATUS_VIOLATION;
147	147	}
148	148
149		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
150		- ->withMetadata( Metadata::ofDependencyMetadata(
151		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	149	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	150	+ ->withMetadata(Metadata::ofDependencyMetadata(
	151	+ DependencyMetadata::ofEntityId($targetEntityId) ));
152	152	}
153	153
154		- public function checkConstraintParameters( Constraint $constraint ) {
	154	+ public function checkConstraintParameters(Constraint $constraint) {
155	155	$constraintParameters = $constraint->getConstraintParameters();
156	156	$exceptions = [];
157	157	try {
158		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
159		- } catch ( ConstraintParameterException $e ) {
	158	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	159	+ } catch (ConstraintParameterException $e) {
160	160	$exceptions[] = $e;
161	161	}
162	162	return $exceptions;

		@@ -36,16 +36,16 @@
		block discarded – undo
36	36	];
37	37	}
38	38
39		- public function checkConstraint( Context $context, Constraint $constraint ) {
40		- if ( $context->getType() === Context::TYPE_REFERENCE ) {
41		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	39	+ public function checkConstraint(Context $context, Constraint $constraint) {
	40	+ if ($context->getType() === Context::TYPE_REFERENCE) {
	41	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
42	42	} else {
43		- $message = new ViolationMessage( 'wbqc-violation-message-reference' );
44		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	43	+ $message = new ViolationMessage('wbqc-violation-message-reference');
	44	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
45	45	}
46	46	}
47	47
48		- public function checkConstraintParameters( Constraint $constraint ) {
	48	+ public function checkConstraintParameters(Constraint $constraint) {
49	49	// no parameters
50	50	return [];
51	51	}

		@@ -71,40 +71,40 @@
		block discarded – undo
71	71	* @throws ConstraintParameterException
72	72	* @return CheckResult
73	73	*/
74		- public function checkConstraint( Context $context, Constraint $constraint ) {
75		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	74	+ public function checkConstraint(Context $context, Constraint $constraint) {
	75	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	76	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77	77	}
78	78
79	79	$parameters = [];
80	80	$constraintParameters = $constraint->getConstraintParameters();
81	81
82		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
83		- $parameters['property'] = [ $propertyId ];
	82	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	83	+ $parameters['property'] = [$propertyId];
84	84
85		- $message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
86		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
87		- ->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
	85	+ $message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
	86	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	87	+ ->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
88	88	$status = CheckResult::STATUS_VIOLATION;
89	89
90	90	/** @var Snak $qualifier */
91		- foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
92		- if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
	91	+ foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
	92	+ if ($propertyId->equals($qualifier->getPropertyId())) {
93	93	$message = null;
94	94	$status = CheckResult::STATUS_COMPLIANCE;
95	95	break;
96	96	}
97	97	}
98	98
99		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	99	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
100	100	}
101	101
102		- public function checkConstraintParameters( Constraint $constraint ) {
	102	+ public function checkConstraintParameters(Constraint $constraint) {
103	103	$constraintParameters = $constraint->getConstraintParameters();
104	104	$exceptions = [];
105	105	try {
106		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
107		- } catch ( ConstraintParameterException $e ) {
	106	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	107	+ } catch (ConstraintParameterException $e) {
108	108	$exceptions[] = $e;
109	109	}
110	110	return $exceptions;

		@@ -71,53 +71,53 @@
		block discarded – undo
71	71	* @throws ConstraintParameterException
72	72	* @return CheckResult
73	73	*/
74		- public function checkConstraint( Context $context, Constraint $constraint ) {
75		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	74	+ public function checkConstraint(Context $context, Constraint $constraint) {
	75	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	76	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77	77	}
78	78
79	79	$parameters = [];
80	80	$constraintParameters = $constraint->getConstraintParameters();
81	81
82		- $properties = $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
	82	+ $properties = $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
83	83	$parameters['property'] = $properties;
84	84
85	85	$message = null;
86	86	$status = CheckResult::STATUS_COMPLIANCE;
87	87
88	88	/** @var Snak $qualifier */
89		- foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
	89	+ foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
90	90	$allowedQualifier = false;
91		- foreach ( $properties as $property ) {
92		- if ( $qualifier->getPropertyId()->equals( $property ) ) {
	91	+ foreach ($properties as $property) {
	92	+ if ($qualifier->getPropertyId()->equals($property)) {
93	93	$allowedQualifier = true;
94	94	break;
95	95	}
96	96	}
97		- if ( !$allowedQualifier ) {
98		- if ( empty( $properties ) \|\| $properties === [ '' ] ) {
99		- $message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
100		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	97	+ if (!$allowedQualifier) {
	98	+ if (empty($properties) \|\| $properties === ['']) {
	99	+ $message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
	100	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
101	101	} else {
102		- $message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
103		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
104		- ->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
105		- ->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
	102	+ $message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
	103	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	104	+ ->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
	105	+ ->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
106	106	}
107	107	$status = CheckResult::STATUS_VIOLATION;
108	108	break;
109	109	}
110	110	}
111	111
112		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	112	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
113	113	}
114	114
115		- public function checkConstraintParameters( Constraint $constraint ) {
	115	+ public function checkConstraintParameters(Constraint $constraint) {
116	116	$constraintParameters = $constraint->getConstraintParameters();
117	117	$exceptions = [];
118	118	try {
119		- $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
120		- } catch ( ConstraintParameterException $e ) {
	119	+ $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	120	+ } catch (ConstraintParameterException $e) {
121	121	$exceptions[] = $e;
122	122	}
123	123	return $exceptions;

		@@ -74,22 +74,22 @@ discard block
		block discarded – undo
74	74	* @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
75	75	* @return CheckResult
76	76	*/
77		- public function checkConstraint( Context $context, Constraint $constraint ) {
78		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
79		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	77	+ public function checkConstraint(Context $context, Constraint $constraint) {
	78	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	79	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
80	80	}
81	81
82	82	$parameters = [];
83	83
84		- if ( $this->sparqlHelper !== null ) {
85		- if ( $context->getType() === 'statement' ) {
	84	+ if ($this->sparqlHelper !== null) {
	85	+ if ($context->getType() === 'statement') {
86	86	$result = $this->sparqlHelper->findEntitiesWithSameStatement(
87	87	$context->getSnakStatement(),
88	88	true // ignore deprecated statements
89	89	);
90	90	} else {
91		- if ( $context->getSnak()->getType() !== 'value' ) {
92		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	91	+ if ($context->getSnak()->getType() !== 'value') {
	92	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
93	93	}
94	94	$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
95	95	$context->getEntity()->getId(),
		@@ -102,27 +102,27 @@ discard block
		block discarded – undo
102	102	$otherEntities = $result->getArray();
103	103	$metadata = $result->getMetadata();
104	104
105		- if ( $otherEntities === [] ) {
	105	+ if ($otherEntities === []) {
106	106	$status = CheckResult::STATUS_COMPLIANCE;
107	107	$message = null;
108	108	} else {
109		- $otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
	109	+ $otherEntities = array_values(array_filter($otherEntities)); // remove nulls
110	110	$status = CheckResult::STATUS_VIOLATION;
111		- $message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
112		- ->withEntityIdList( $otherEntities, Role::SUBJECT );
	111	+ $message = (new ViolationMessage('wbqc-violation-message-unique-value'))
	112	+ ->withEntityIdList($otherEntities, Role::SUBJECT);
113	113	}
114	114	} else {
115	115	$status = CheckResult::STATUS_TODO;
116		- $message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
117		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
	116	+ $message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
	117	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
118	118	$metadata = Metadata::blank();
119	119	}
120	120
121		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
122		- ->withMetadata( $metadata );
	121	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	122	+ ->withMetadata($metadata);
123	123	}
124	124
125		- public function checkConstraintParameters( Constraint $constraint ) {
	125	+ public function checkConstraintParameters(Constraint $constraint) {
126	126	// no parameters
127	127	return [];
128	128	}

		@@ -68,41 +68,41 @@
		block discarded – undo
68	68	* @throws ConstraintParameterException
69	69	* @return CheckResult
70	70	*/
71		- public function checkConstraint( Context $context, Constraint $constraint ) {
72		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
73		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	71	+ public function checkConstraint(Context $context, Constraint $constraint) {
	72	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	73	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
74	74	}
75	75
76	76	$parameters = [];
77	77	$constraintParameters = $constraint->getConstraintParameters();
78	78
79		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
	79	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
80	80	$parameters['item'] = $items;
81	81
82	82	$snak = $context->getSnak();
83	83
84		- $message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) )
85		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
86		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	84	+ $message = (new ViolationMessage('wbqc-violation-message-one-of'))
	85	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
	86	+ ->withItemIdSnakValueList($items, Role::OBJECT);
87	87	$status = CheckResult::STATUS_VIOLATION;
88	88
89		- foreach ( $items as $item ) {
90		- if ( $item->matchesSnak( $snak ) ) {
	89	+ foreach ($items as $item) {
	90	+ if ($item->matchesSnak($snak)) {
91	91	$message = null;
92	92	$status = CheckResult::STATUS_COMPLIANCE;
93	93	break;
94	94	}
95	95	}
96	96
97		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	97	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
98	98	}
99	99
100		- public function checkConstraintParameters( Constraint $constraint ) {
	100	+ public function checkConstraintParameters(Constraint $constraint) {
101	101	$constraintParameters = $constraint->getConstraintParameters();
102	102	$exceptions = [];
103	103	try {
104		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
105		- } catch ( ConstraintParameterException $e ) {
	104	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
	105	+ } catch (ConstraintParameterException $e) {
106	106	$exceptions[] = $e;
107	107	}
108	108	return $exceptions;

		@@ -81,9 +81,9 @@ discard block
		block discarded – undo
81	81	*
82	82	* @return CheckResult
83	83	*/
84		- public function checkConstraint( Context $context, Constraint $constraint ) {
85		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
86		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	84	+ public function checkConstraint(Context $context, Constraint $constraint) {
	85	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	86	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
87	87	}
88	88
89	89	$parameters = [];
		@@ -91,9 +91,9 @@ discard block
		block discarded – undo
91	91	$snak = $context->getSnak();
92	92	$propertyId = $context->getSnak()->getPropertyId();
93	93
94		- if ( !$snak instanceof PropertyValueSnak ) {
	94	+ if (!$snak instanceof PropertyValueSnak) {
95	95	// nothing to check
96		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	96	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
97	97	}
98	98
99	99	$dataValue = $snak->getDataValue();
		@@ -102,19 +102,19 @@ discard block
		block discarded – undo
102	102	* error handling:
103	103	* type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
104	104	*/
105		- if ( $dataValue->getType() !== 'wikibase-entityid' ) {
106		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
107		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
108		- ->withDataValueType( 'wikibase-entityid' );
109		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	105	+ if ($dataValue->getType() !== 'wikibase-entityid') {
	106	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	107	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	108	+ ->withDataValueType('wikibase-entityid');
	109	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
110	110	}
111	111	/** @var EntityIdValue $dataValue */
112	112
113	113	$targetEntityId = $dataValue->getEntityId();
114		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
115		- if ( $targetEntity === null ) {
116		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
117		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	114	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	115	+ if ($targetEntity === null) {
	116	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	117	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
118	118	}
119	119
120	120	$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
		@@ -122,23 +122,23 @@ discard block
		block discarded – undo
122	122	$propertyId,
123	123	$context->getEntity()->getId()
124	124	);
125		- if ( $symmetricStatement !== null ) {
	125	+ if ($symmetricStatement !== null) {
126	126	$message = null;
127	127	$status = CheckResult::STATUS_COMPLIANCE;
128	128	} else {
129		- $message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
130		- ->withEntityId( $targetEntityId, Role::SUBJECT )
131		- ->withEntityId( $propertyId, Role::PREDICATE )
132		- ->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
	129	+ $message = (new ViolationMessage('wbqc-violation-message-symmetric'))
	130	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	131	+ ->withEntityId($propertyId, Role::PREDICATE)
	132	+ ->withEntityId($context->getEntity()->getId(), Role::OBJECT);
133	133	$status = CheckResult::STATUS_VIOLATION;
134	134	}
135	135
136		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
137		- ->withMetadata( Metadata::ofDependencyMetadata(
138		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	136	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	137	+ ->withMetadata(Metadata::ofDependencyMetadata(
	138	+ DependencyMetadata::ofEntityId($targetEntityId) ));
139	139	}
140	140
141		- public function checkConstraintParameters( Constraint $constraint ) {
	141	+ public function checkConstraintParameters(Constraint $constraint) {
142	142	// no parameters
143	143	return [];
144	144	}

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( 7b7d2e...94ab99 )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch