@@ -60,9 +60,9 @@ discard block |
||
60 | 60 | * @throws ConstraintParameterException |
61 | 61 | * @return CheckResult |
62 | 62 | */ |
63 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
64 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
65 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
63 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
64 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
65 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
66 | 66 | } |
67 | 67 | |
68 | 68 | $parameters = []; |
@@ -78,23 +78,23 @@ discard block |
||
78 | 78 | |
79 | 79 | $snak = $context->getSnak(); |
80 | 80 | |
81 | - $message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) ) |
|
82 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ) |
|
83 | - ->withItemIdSnakValueList( $items, Role::OBJECT ); |
|
81 | + $message = (new ViolationMessage('wbqc-violation-message-one-of')) |
|
82 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE) |
|
83 | + ->withItemIdSnakValueList($items, Role::OBJECT); |
|
84 | 84 | $status = CheckResult::STATUS_VIOLATION; |
85 | 85 | |
86 | - foreach ( $items as $item ) { |
|
87 | - if ( $item->matchesSnak( $snak ) ) { |
|
86 | + foreach ($items as $item) { |
|
87 | + if ($item->matchesSnak($snak)) { |
|
88 | 88 | $message = null; |
89 | 89 | $status = CheckResult::STATUS_COMPLIANCE; |
90 | 90 | break; |
91 | 91 | } |
92 | 92 | } |
93 | 93 | |
94 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
94 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
95 | 95 | } |
96 | 96 | |
97 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
97 | + public function checkConstraintParameters(Constraint $constraint) { |
|
98 | 98 | $constraintParameters = $constraint->getConstraintParameters(); |
99 | 99 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
100 | 100 | $exceptions = []; |
@@ -104,7 +104,7 @@ discard block |
||
104 | 104 | $constraintTypeItemId, |
105 | 105 | true |
106 | 106 | ); |
107 | - } catch ( ConstraintParameterException $e ) { |
|
107 | + } catch (ConstraintParameterException $e) { |
|
108 | 108 | $exceptions[] = $e; |
109 | 109 | } |
110 | 110 | return $exceptions; |
@@ -81,9 +81,9 @@ discard block |
||
81 | 81 | * @throws ConstraintParameterException |
82 | 82 | * @return CheckResult |
83 | 83 | */ |
84 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
85 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
86 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
84 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
85 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
86 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
87 | 87 | } |
88 | 88 | |
89 | 89 | $parameters = []; |
@@ -94,7 +94,7 @@ discard block |
||
94 | 94 | $constraintParameters, |
95 | 95 | $constraintTypeItemId |
96 | 96 | ); |
97 | - $parameters['property'] = [ $propertyId ]; |
|
97 | + $parameters['property'] = [$propertyId]; |
|
98 | 98 | |
99 | 99 | $items = $this->constraintParameterParser->parseItemsParameter( |
100 | 100 | $constraintParameters, |
@@ -105,9 +105,9 @@ discard block |
||
105 | 105 | |
106 | 106 | $snak = $context->getSnak(); |
107 | 107 | |
108 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
108 | + if (!$snak instanceof PropertyValueSnak) { |
|
109 | 109 | // nothing to check |
110 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
110 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
111 | 111 | } |
112 | 112 | |
113 | 113 | $dataValue = $snak->getDataValue(); |
@@ -116,19 +116,19 @@ discard block |
||
116 | 116 | * error handling: |
117 | 117 | * type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid' |
118 | 118 | */ |
119 | - if ( $dataValue->getType() !== 'wikibase-entityid' ) { |
|
120 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
121 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
122 | - ->withDataValueType( 'wikibase-entityid' ); |
|
123 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
119 | + if ($dataValue->getType() !== 'wikibase-entityid') { |
|
120 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
121 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
122 | + ->withDataValueType('wikibase-entityid'); |
|
123 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
124 | 124 | } |
125 | 125 | /** @var EntityIdValue $dataValue */ |
126 | 126 | |
127 | 127 | $targetEntityId = $dataValue->getEntityId(); |
128 | - $targetEntity = $this->entityLookup->getEntity( $targetEntityId ); |
|
129 | - if ( $targetEntity === null ) { |
|
130 | - $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' ); |
|
131 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
128 | + $targetEntity = $this->entityLookup->getEntity($targetEntityId); |
|
129 | + if ($targetEntity === null) { |
|
130 | + $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist'); |
|
131 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
132 | 132 | } |
133 | 133 | |
134 | 134 | /* |
@@ -136,7 +136,7 @@ discard block |
||
136 | 136 | * a) a property only |
137 | 137 | * b) a property and a number of items (each combination forming an individual claim) |
138 | 138 | */ |
139 | - if ( $items === [] ) { |
|
139 | + if ($items === []) { |
|
140 | 140 | $requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty( |
141 | 141 | $targetEntity->getStatements(), |
142 | 142 | $propertyId |
@@ -149,23 +149,23 @@ discard block |
||
149 | 149 | ); |
150 | 150 | } |
151 | 151 | |
152 | - if ( $requiredStatement !== null ) { |
|
152 | + if ($requiredStatement !== null) { |
|
153 | 153 | $status = CheckResult::STATUS_COMPLIANCE; |
154 | 154 | $message = null; |
155 | 155 | } else { |
156 | 156 | $status = CheckResult::STATUS_VIOLATION; |
157 | - $message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) ) |
|
158 | - ->withEntityId( $targetEntityId, Role::SUBJECT ) |
|
159 | - ->withEntityId( $propertyId, Role::PREDICATE ) |
|
160 | - ->withItemIdSnakValueList( $items, Role::OBJECT ); |
|
157 | + $message = (new ViolationMessage('wbqc-violation-message-target-required-claim')) |
|
158 | + ->withEntityId($targetEntityId, Role::SUBJECT) |
|
159 | + ->withEntityId($propertyId, Role::PREDICATE) |
|
160 | + ->withItemIdSnakValueList($items, Role::OBJECT); |
|
161 | 161 | } |
162 | 162 | |
163 | - return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) ) |
|
164 | - ->withMetadata( Metadata::ofDependencyMetadata( |
|
165 | - DependencyMetadata::ofEntityId( $targetEntityId ) ) ); |
|
163 | + return (new CheckResult($context, $constraint, $parameters, $status, $message)) |
|
164 | + ->withMetadata(Metadata::ofDependencyMetadata( |
|
165 | + DependencyMetadata::ofEntityId($targetEntityId) )); |
|
166 | 166 | } |
167 | 167 | |
168 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
168 | + public function checkConstraintParameters(Constraint $constraint) { |
|
169 | 169 | $constraintParameters = $constraint->getConstraintParameters(); |
170 | 170 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
171 | 171 | $exceptions = []; |
@@ -174,7 +174,7 @@ discard block |
||
174 | 174 | $constraintParameters, |
175 | 175 | $constraintTypeItemId |
176 | 176 | ); |
177 | - } catch ( ConstraintParameterException $e ) { |
|
177 | + } catch (ConstraintParameterException $e) { |
|
178 | 178 | $exceptions[] = $e; |
179 | 179 | } |
180 | 180 | try { |
@@ -183,7 +183,7 @@ discard block |
||
183 | 183 | $constraintTypeItemId, |
184 | 184 | false |
185 | 185 | ); |
186 | - } catch ( ConstraintParameterException $e ) { |
|
186 | + } catch (ConstraintParameterException $e) { |
|
187 | 187 | $exceptions[] = $e; |
188 | 188 | } |
189 | 189 | return $exceptions; |
@@ -91,9 +91,9 @@ discard block |
||
91 | 91 | * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs |
92 | 92 | * @return CheckResult |
93 | 93 | */ |
94 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
95 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
96 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
94 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
95 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
96 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
97 | 97 | } |
98 | 98 | |
99 | 99 | $parameters = []; |
@@ -105,8 +105,8 @@ discard block |
||
105 | 105 | $constraintTypeItemId |
106 | 106 | ); |
107 | 107 | $parameters['class'] = array_map( |
108 | - function( $id ) { |
|
109 | - return new ItemId( $id ); |
|
108 | + function($id) { |
|
109 | + return new ItemId($id); |
|
110 | 110 | }, |
111 | 111 | $classes |
112 | 112 | ); |
@@ -116,19 +116,19 @@ discard block |
||
116 | 116 | $constraintTypeItemId |
117 | 117 | ); |
118 | 118 | $relationIds = []; |
119 | - if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) { |
|
120 | - $relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' ); |
|
119 | + if ($relation === 'instance' || $relation === 'instanceOrSubclass') { |
|
120 | + $relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId'); |
|
121 | 121 | } |
122 | - if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) { |
|
123 | - $relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' ); |
|
122 | + if ($relation === 'subclass' || $relation === 'instanceOrSubclass') { |
|
123 | + $relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId'); |
|
124 | 124 | } |
125 | - $parameters['relation'] = [ $relation ]; |
|
125 | + $parameters['relation'] = [$relation]; |
|
126 | 126 | |
127 | 127 | $snak = $context->getSnak(); |
128 | 128 | |
129 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
129 | + if (!$snak instanceof PropertyValueSnak) { |
|
130 | 130 | // nothing to check |
131 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
131 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
132 | 132 | } |
133 | 133 | |
134 | 134 | $dataValue = $snak->getDataValue(); |
@@ -137,24 +137,24 @@ discard block |
||
137 | 137 | * error handling: |
138 | 138 | * type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid' |
139 | 139 | */ |
140 | - if ( $dataValue->getType() !== 'wikibase-entityid' ) { |
|
141 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
142 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
143 | - ->withDataValueType( 'wikibase-entityid' ); |
|
144 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
140 | + if ($dataValue->getType() !== 'wikibase-entityid') { |
|
141 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
142 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
143 | + ->withDataValueType('wikibase-entityid'); |
|
144 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
145 | 145 | } |
146 | 146 | /** @var EntityIdValue $dataValue */ |
147 | 147 | |
148 | 148 | try { |
149 | - $item = $this->entityLookup->getEntity( $dataValue->getEntityId() ); |
|
150 | - } catch ( UnresolvedEntityRedirectException $e ) { |
|
149 | + $item = $this->entityLookup->getEntity($dataValue->getEntityId()); |
|
150 | + } catch (UnresolvedEntityRedirectException $e) { |
|
151 | 151 | // Edge case (double redirect): Pretend the entity doesn't exist |
152 | 152 | $item = null; |
153 | 153 | } |
154 | 154 | |
155 | - if ( !( $item instanceof StatementListProvider ) ) { |
|
156 | - $message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' ); |
|
157 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message ); |
|
155 | + if (!($item instanceof StatementListProvider)) { |
|
156 | + $message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist'); |
|
157 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message); |
|
158 | 158 | } |
159 | 159 | |
160 | 160 | $statements = $item->getStatements(); |
@@ -165,7 +165,7 @@ discard block |
||
165 | 165 | $classes |
166 | 166 | ); |
167 | 167 | |
168 | - if ( $result->getBool() ) { |
|
168 | + if ($result->getBool()) { |
|
169 | 169 | $message = null; |
170 | 170 | $status = CheckResult::STATUS_COMPLIANCE; |
171 | 171 | } else { |
@@ -179,11 +179,11 @@ discard block |
||
179 | 179 | $status = CheckResult::STATUS_VIOLATION; |
180 | 180 | } |
181 | 181 | |
182 | - return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) ) |
|
183 | - ->withMetadata( $result->getMetadata() ); |
|
182 | + return (new CheckResult($context, $constraint, $parameters, $status, $message)) |
|
183 | + ->withMetadata($result->getMetadata()); |
|
184 | 184 | } |
185 | 185 | |
186 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
186 | + public function checkConstraintParameters(Constraint $constraint) { |
|
187 | 187 | $constraintParameters = $constraint->getConstraintParameters(); |
188 | 188 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
189 | 189 | $exceptions = []; |
@@ -192,7 +192,7 @@ discard block |
||
192 | 192 | $constraintParameters, |
193 | 193 | $constraintTypeItemId |
194 | 194 | ); |
195 | - } catch ( ConstraintParameterException $e ) { |
|
195 | + } catch (ConstraintParameterException $e) { |
|
196 | 196 | $exceptions[] = $e; |
197 | 197 | } |
198 | 198 | try { |
@@ -200,7 +200,7 @@ discard block |
||
200 | 200 | $constraintParameters, |
201 | 201 | $constraintTypeItemId |
202 | 202 | ); |
203 | - } catch ( ConstraintParameterException $e ) { |
|
203 | + } catch (ConstraintParameterException $e) { |
|
204 | 204 | $exceptions[] = $e; |
205 | 205 | } |
206 | 206 | return $exceptions; |
@@ -76,8 +76,8 @@ discard block |
||
76 | 76 | * @throws ConstraintParameterException |
77 | 77 | * @return array [ DataValue|null $min, DataValue|null $max, PropertyId $property, array $parameters ] |
78 | 78 | */ |
79 | - private function parseConstraintParameters( Constraint $constraint ) { |
|
80 | - list( $min, $max ) = $this->constraintParameterParser->parseQuantityRangeParameter( |
|
79 | + private function parseConstraintParameters(Constraint $constraint) { |
|
80 | + list($min, $max) = $this->constraintParameterParser->parseQuantityRangeParameter( |
|
81 | 81 | $constraint->getConstraintParameters(), |
82 | 82 | $constraint->getConstraintTypeItemId() |
83 | 83 | ); |
@@ -86,15 +86,15 @@ discard block |
||
86 | 86 | $constraint->getConstraintTypeItemId() |
87 | 87 | ); |
88 | 88 | |
89 | - if ( $min !== null ) { |
|
90 | - $parameters['minimum_quantity'] = [ $min ]; |
|
89 | + if ($min !== null) { |
|
90 | + $parameters['minimum_quantity'] = [$min]; |
|
91 | 91 | } |
92 | - if ( $max !== null ) { |
|
93 | - $parameters['maximum_quantity'] = [ $max ]; |
|
92 | + if ($max !== null) { |
|
93 | + $parameters['maximum_quantity'] = [$max]; |
|
94 | 94 | } |
95 | - $parameters['property'] = [ $property ]; |
|
95 | + $parameters['property'] = [$property]; |
|
96 | 96 | |
97 | - return [ $min, $max, $property, $parameters ]; |
|
97 | + return [$min, $max, $property, $parameters]; |
|
98 | 98 | } |
99 | 99 | |
100 | 100 | /** |
@@ -104,13 +104,13 @@ discard block |
||
104 | 104 | * |
105 | 105 | * @return bool |
106 | 106 | */ |
107 | - private function rangeInYears( $min, $max ) { |
|
108 | - $yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
107 | + private function rangeInYears($min, $max) { |
|
108 | + $yearUnit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
109 | 109 | |
110 | - if ( $min !== null && $min->getUnit() === $yearUnit ) { |
|
110 | + if ($min !== null && $min->getUnit() === $yearUnit) { |
|
111 | 111 | return true; |
112 | 112 | } |
113 | - if ( $max !== null && $max->getUnit() === $yearUnit ) { |
|
113 | + if ($max !== null && $max->getUnit() === $yearUnit) { |
|
114 | 114 | return true; |
115 | 115 | } |
116 | 116 | |
@@ -126,59 +126,58 @@ discard block |
||
126 | 126 | * @throws ConstraintParameterException |
127 | 127 | * @return CheckResult |
128 | 128 | */ |
129 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
130 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
131 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
129 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
130 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
131 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
132 | 132 | } |
133 | 133 | |
134 | 134 | $parameters = []; |
135 | 135 | |
136 | 136 | $snak = $context->getSnak(); |
137 | 137 | |
138 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
138 | + if (!$snak instanceof PropertyValueSnak) { |
|
139 | 139 | // nothing to check |
140 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
140 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
141 | 141 | } |
142 | 142 | |
143 | 143 | $minuend = $snak->getDataValue(); |
144 | 144 | |
145 | 145 | /** @var PropertyId $property */ |
146 | - list( $min, $max, $property, $parameters ) = $this->parseConstraintParameters( $constraint ); |
|
146 | + list($min, $max, $property, $parameters) = $this->parseConstraintParameters($constraint); |
|
147 | 147 | |
148 | 148 | // checks only the first occurrence of the referenced property |
149 | - foreach ( $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ) as $otherSnak ) { |
|
149 | + foreach ($context->getSnakGroup(Context::GROUP_NON_DEPRECATED) as $otherSnak) { |
|
150 | 150 | if ( |
151 | - !$property->equals( $otherSnak->getPropertyId() ) || |
|
151 | + !$property->equals($otherSnak->getPropertyId()) || |
|
152 | 152 | !$otherSnak instanceof PropertyValueSnak |
153 | 153 | ) { |
154 | 154 | continue; |
155 | 155 | } |
156 | 156 | |
157 | 157 | $subtrahend = $otherSnak->getDataValue(); |
158 | - if ( $subtrahend->getType() === $minuend->getType() ) { |
|
159 | - $diff = $this->rangeInYears( $min, $max ) && $minuend->getType() === 'time' ? |
|
160 | - $this->rangeCheckerHelper->getDifferenceInYears( $minuend, $subtrahend ) : |
|
161 | - $this->rangeCheckerHelper->getDifference( $minuend, $subtrahend ); |
|
158 | + if ($subtrahend->getType() === $minuend->getType()) { |
|
159 | + $diff = $this->rangeInYears($min, $max) && $minuend->getType() === 'time' ? |
|
160 | + $this->rangeCheckerHelper->getDifferenceInYears($minuend, $subtrahend) : $this->rangeCheckerHelper->getDifference($minuend, $subtrahend); |
|
162 | 161 | |
163 | - if ( $this->rangeCheckerHelper->getComparison( $min, $diff ) > 0 || |
|
164 | - $this->rangeCheckerHelper->getComparison( $diff, $max ) > 0 |
|
162 | + if ($this->rangeCheckerHelper->getComparison($min, $diff) > 0 || |
|
163 | + $this->rangeCheckerHelper->getComparison($diff, $max) > 0 |
|
165 | 164 | ) { |
166 | 165 | // at least one of $min, $max is set at this point, otherwise there could be no violation |
167 | - $openness = $min !== null ? ( $max !== null ? '' : '-rightopen' ) : '-leftopen'; |
|
166 | + $openness = $min !== null ? ($max !== null ? '' : '-rightopen') : '-leftopen'; |
|
168 | 167 | // possible message keys: |
169 | 168 | // wbqc-violation-message-diff-within-range |
170 | 169 | // wbqc-violation-message-diff-within-range-leftopen |
171 | 170 | // wbqc-violation-message-diff-within-range-rightopen |
172 | - $message = ( new ViolationMessage( "wbqc-violation-message-diff-within-range$openness" ) ) |
|
173 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ) |
|
174 | - ->withDataValue( $minuend, Role::OBJECT ) |
|
175 | - ->withEntityId( $otherSnak->getPropertyId(), Role::PREDICATE ) |
|
176 | - ->withDataValue( $subtrahend, Role::OBJECT ); |
|
177 | - if ( $min !== null ) { |
|
178 | - $message = $message->withDataValue( $min, Role::OBJECT ); |
|
171 | + $message = (new ViolationMessage("wbqc-violation-message-diff-within-range$openness")) |
|
172 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE) |
|
173 | + ->withDataValue($minuend, Role::OBJECT) |
|
174 | + ->withEntityId($otherSnak->getPropertyId(), Role::PREDICATE) |
|
175 | + ->withDataValue($subtrahend, Role::OBJECT); |
|
176 | + if ($min !== null) { |
|
177 | + $message = $message->withDataValue($min, Role::OBJECT); |
|
179 | 178 | } |
180 | - if ( $max !== null ) { |
|
181 | - $message = $message->withDataValue( $max, Role::OBJECT ); |
|
179 | + if ($max !== null) { |
|
180 | + $message = $message->withDataValue($max, Role::OBJECT); |
|
182 | 181 | } |
183 | 182 | $status = CheckResult::STATUS_VIOLATION; |
184 | 183 | } else { |
@@ -186,17 +185,17 @@ discard block |
||
186 | 185 | $status = CheckResult::STATUS_COMPLIANCE; |
187 | 186 | } |
188 | 187 | } else { |
189 | - $message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-must-have-equal-types' ); |
|
188 | + $message = new ViolationMessage('wbqc-violation-message-diff-within-range-must-have-equal-types'); |
|
190 | 189 | $status = CheckResult::STATUS_VIOLATION; |
191 | 190 | } |
192 | 191 | |
193 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
192 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
194 | 193 | } |
195 | 194 | |
196 | - return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE ); |
|
195 | + return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE); |
|
197 | 196 | } |
198 | 197 | |
199 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
198 | + public function checkConstraintParameters(Constraint $constraint) { |
|
200 | 199 | $constraintParameters = $constraint->getConstraintParameters(); |
201 | 200 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
202 | 201 | $exceptions = []; |
@@ -205,7 +204,7 @@ discard block |
||
205 | 204 | $constraintParameters, |
206 | 205 | $constraintTypeItemId |
207 | 206 | ); |
208 | - } catch ( ConstraintParameterException $e ) { |
|
207 | + } catch (ConstraintParameterException $e) { |
|
209 | 208 | $exceptions[] = $e; |
210 | 209 | } |
211 | 210 | try { |
@@ -213,7 +212,7 @@ discard block |
||
213 | 212 | $constraintParameters, |
214 | 213 | $constraintTypeItemId |
215 | 214 | ); |
216 | - } catch ( ConstraintParameterException $e ) { |
|
215 | + } catch (ConstraintParameterException $e) { |
|
217 | 216 | $exceptions[] = $e; |
218 | 217 | } |
219 | 218 | return $exceptions; |
@@ -15,10 +15,10 @@ discard block |
||
15 | 15 | use Wikibase\Repo\WikibaseRepo; |
16 | 16 | |
17 | 17 | // @codeCoverageIgnoreStart |
18 | -$basePath = getenv( "MW_INSTALL_PATH" ) !== false |
|
19 | - ? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../.."; |
|
18 | +$basePath = getenv("MW_INSTALL_PATH") !== false |
|
19 | + ? getenv("MW_INSTALL_PATH") : __DIR__."/../../.."; |
|
20 | 20 | |
21 | -require_once $basePath . "/maintenance/Maintenance.php"; |
|
21 | +require_once $basePath."/maintenance/Maintenance.php"; |
|
22 | 22 | // @codeCoverageIgnoreEnd |
23 | 23 | |
24 | 24 | /** |
@@ -52,13 +52,13 @@ discard block |
||
52 | 52 | parent::__construct(); |
53 | 53 | |
54 | 54 | $this->addDescription( |
55 | - 'Import entities needed for constraint checks ' . |
|
55 | + 'Import entities needed for constraint checks '. |
|
56 | 56 | 'from Wikidata into the local repository.' |
57 | 57 | ); |
58 | 58 | $this->addOption( |
59 | 59 | 'config-format', |
60 | - 'The format in which the resulting configuration will be omitted: ' . |
|
61 | - '"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), ' . |
|
60 | + 'The format in which the resulting configuration will be omitted: '. |
|
61 | + '"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), '. |
|
62 | 62 | 'or "wgConf" for printing parts of arrays suitable for inclusion in $wgConf->settings.' |
63 | 63 | ); |
64 | 64 | $this->addOption( |
@@ -75,8 +75,8 @@ discard block |
||
75 | 75 | $this->entitySerializer = $repo->getAllTypesEntitySerializer(); |
76 | 76 | $this->entityDeserializer = $repo->getInternalFormatEntityDeserializer(); |
77 | 77 | $this->entityStore = $repo->getEntityStore(); |
78 | - if ( !$this->getOption( 'dry-run', false ) ) { |
|
79 | - $this->user = User::newSystemUser( 'WikibaseQualityConstraints importer' ); |
|
78 | + if (!$this->getOption('dry-run', false)) { |
|
79 | + $this->user = User::newSystemUser('WikibaseQualityConstraints importer'); |
|
80 | 80 | } |
81 | 81 | } |
82 | 82 | |
@@ -85,20 +85,20 @@ discard block |
||
85 | 85 | |
86 | 86 | $configUpdates = []; |
87 | 87 | |
88 | - $extensionJsonFile = __DIR__ . '/../extension.json'; |
|
89 | - $extensionJsonText = file_get_contents( $extensionJsonFile ); |
|
90 | - $extensionJson = json_decode( $extensionJsonText, /* assoc = */ true ); |
|
91 | - $wikidataEntityIds = $this->getEntitiesToImport( $extensionJson['config'], $this->getConfig() ); |
|
88 | + $extensionJsonFile = __DIR__.'/../extension.json'; |
|
89 | + $extensionJsonText = file_get_contents($extensionJsonFile); |
|
90 | + $extensionJson = json_decode($extensionJsonText, /* assoc = */ true); |
|
91 | + $wikidataEntityIds = $this->getEntitiesToImport($extensionJson['config'], $this->getConfig()); |
|
92 | 92 | |
93 | - foreach ( $wikidataEntityIds as $key => $wikidataEntityId ) { |
|
94 | - $localEntityId = $this->importEntityFromWikidata( $wikidataEntityId ); |
|
93 | + foreach ($wikidataEntityIds as $key => $wikidataEntityId) { |
|
94 | + $localEntityId = $this->importEntityFromWikidata($wikidataEntityId); |
|
95 | 95 | $configUpdates[$key] = [ |
96 | 96 | 'wikidata' => $wikidataEntityId, |
97 | 97 | 'local' => $localEntityId, |
98 | 98 | ]; |
99 | 99 | } |
100 | 100 | |
101 | - $this->outputConfigUpdates( $configUpdates ); |
|
101 | + $this->outputConfigUpdates($configUpdates); |
|
102 | 102 | } |
103 | 103 | |
104 | 104 | /** |
@@ -106,18 +106,18 @@ discard block |
||
106 | 106 | * @param Config $wikiConfig |
107 | 107 | * @return string[] |
108 | 108 | */ |
109 | - private function getEntitiesToImport( array $extensionJsonConfig, Config $wikiConfig ) { |
|
109 | + private function getEntitiesToImport(array $extensionJsonConfig, Config $wikiConfig) { |
|
110 | 110 | $wikidataEntityIds = []; |
111 | 111 | |
112 | - foreach ( $extensionJsonConfig as $key => $value ) { |
|
113 | - if ( !preg_match( '/Id$/', $key ) ) { |
|
112 | + foreach ($extensionJsonConfig as $key => $value) { |
|
113 | + if (!preg_match('/Id$/', $key)) { |
|
114 | 114 | continue; |
115 | 115 | } |
116 | 116 | |
117 | 117 | $wikidataEntityId = $value['value']; |
118 | - $localEntityId = $wikiConfig->get( $key ); |
|
118 | + $localEntityId = $wikiConfig->get($key); |
|
119 | 119 | |
120 | - if ( $localEntityId === $wikidataEntityId ) { |
|
120 | + if ($localEntityId === $wikidataEntityId) { |
|
121 | 121 | $wikidataEntityIds[$key] = $wikidataEntityId; |
122 | 122 | } |
123 | 123 | } |
@@ -129,10 +129,10 @@ discard block |
||
129 | 129 | * @param string $wikidataEntityId |
130 | 130 | * @return string local entity ID |
131 | 131 | */ |
132 | - private function importEntityFromWikidata( $wikidataEntityId ) { |
|
132 | + private function importEntityFromWikidata($wikidataEntityId) { |
|
133 | 133 | $wikidataEntityUrl = "https://www.wikidata.org/wiki/Special:EntityData/$wikidataEntityId.json"; |
134 | - $wikidataEntitiesJson = file_get_contents( $wikidataEntityUrl ); |
|
135 | - return $this->importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ); |
|
134 | + $wikidataEntitiesJson = file_get_contents($wikidataEntityUrl); |
|
135 | + return $this->importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson); |
|
136 | 136 | } |
137 | 137 | |
138 | 138 | /** |
@@ -140,23 +140,23 @@ discard block |
||
140 | 140 | * @param string $wikidataEntitiesJson |
141 | 141 | * @return string local entity ID |
142 | 142 | */ |
143 | - private function importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ) { |
|
144 | - $wikidataEntityArray = json_decode( $wikidataEntitiesJson, true )['entities'][$wikidataEntityId]; |
|
145 | - $wikidataEntity = $this->entityDeserializer->deserialize( $wikidataEntityArray ); |
|
143 | + private function importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson) { |
|
144 | + $wikidataEntityArray = json_decode($wikidataEntitiesJson, true)['entities'][$wikidataEntityId]; |
|
145 | + $wikidataEntity = $this->entityDeserializer->deserialize($wikidataEntityArray); |
|
146 | 146 | |
147 | - $wikidataEntity->setId( null ); |
|
147 | + $wikidataEntity->setId(null); |
|
148 | 148 | |
149 | - if ( $wikidataEntity instanceof StatementListProvider ) { |
|
149 | + if ($wikidataEntity instanceof StatementListProvider) { |
|
150 | 150 | $wikidataEntity->getStatements()->clear(); |
151 | 151 | } |
152 | 152 | |
153 | - if ( $wikidataEntity instanceof Item ) { |
|
154 | - $wikidataEntity->setSiteLinkList( new SiteLinkList() ); |
|
153 | + if ($wikidataEntity instanceof Item) { |
|
154 | + $wikidataEntity->setSiteLinkList(new SiteLinkList()); |
|
155 | 155 | } |
156 | 156 | |
157 | - if ( $this->getOption( 'dry-run', false ) ) { |
|
158 | - $wikidataEntityJson = json_encode( $this->entitySerializer->serialize( $wikidataEntity ) ); |
|
159 | - $this->output( $wikidataEntityJson . "\n" ); |
|
157 | + if ($this->getOption('dry-run', false)) { |
|
158 | + $wikidataEntityJson = json_encode($this->entitySerializer->serialize($wikidataEntity)); |
|
159 | + $this->output($wikidataEntityJson."\n"); |
|
160 | 160 | return "-$wikidataEntityId"; |
161 | 161 | } |
162 | 162 | |
@@ -169,12 +169,12 @@ discard block |
||
169 | 169 | )->getEntity(); |
170 | 170 | |
171 | 171 | return $localEntity->getId()->getSerialization(); |
172 | - } catch ( StorageException $storageException ) { |
|
173 | - return $this->storageExceptionToEntityId( $storageException ); |
|
172 | + } catch (StorageException $storageException) { |
|
173 | + return $this->storageExceptionToEntityId($storageException); |
|
174 | 174 | } |
175 | 175 | } |
176 | 176 | |
177 | - private function storageExceptionToEntityId( StorageException $storageException ) { |
|
177 | + private function storageExceptionToEntityId(StorageException $storageException) { |
|
178 | 178 | $message = $storageException->getMessage(); |
179 | 179 | // example messages: |
180 | 180 | // * Item [[Item:Q475|Q475]] already has label "as references" |
@@ -184,42 +184,42 @@ discard block |
||
184 | 184 | // * Property [[Property:P694|P694]] already has label "instance of" |
185 | 185 | // associated with language code en. |
186 | 186 | $pattern = '/[[|]([^][|]*)]] already has label .* associated with language code/'; |
187 | - if ( preg_match( $pattern, $message, $matches ) ) { |
|
187 | + if (preg_match($pattern, $message, $matches)) { |
|
188 | 188 | return $matches[1]; |
189 | 189 | } else { |
190 | 190 | throw $storageException; |
191 | 191 | } |
192 | 192 | } |
193 | 193 | |
194 | - private function outputConfigUpdates( array $configUpdates ) { |
|
195 | - $configFormat = $this->getOption( 'config-format', 'globals' ); |
|
196 | - switch ( $configFormat ) { |
|
194 | + private function outputConfigUpdates(array $configUpdates) { |
|
195 | + $configFormat = $this->getOption('config-format', 'globals'); |
|
196 | + switch ($configFormat) { |
|
197 | 197 | case 'globals': |
198 | - $this->outputConfigUpdatesGlobals( $configUpdates ); |
|
198 | + $this->outputConfigUpdatesGlobals($configUpdates); |
|
199 | 199 | break; |
200 | 200 | case 'wgConf': |
201 | - $this->outputConfigUpdatesWgConf( $configUpdates ); |
|
201 | + $this->outputConfigUpdatesWgConf($configUpdates); |
|
202 | 202 | break; |
203 | 203 | default: |
204 | - $this->error( "Invalid config format \"$configFormat\", using \"globals\"" ); |
|
205 | - $this->outputConfigUpdatesGlobals( $configUpdates ); |
|
204 | + $this->error("Invalid config format \"$configFormat\", using \"globals\""); |
|
205 | + $this->outputConfigUpdatesGlobals($configUpdates); |
|
206 | 206 | break; |
207 | 207 | } |
208 | 208 | } |
209 | 209 | |
210 | - private function outputConfigUpdatesGlobals( array $configUpdates ) { |
|
211 | - foreach ( $configUpdates as $key => $value ) { |
|
212 | - $localValueCode = var_export( $value['local'], true ); |
|
213 | - $this->output( "\$wg$key = $localValueCode;\n" ); |
|
210 | + private function outputConfigUpdatesGlobals(array $configUpdates) { |
|
211 | + foreach ($configUpdates as $key => $value) { |
|
212 | + $localValueCode = var_export($value['local'], true); |
|
213 | + $this->output("\$wg$key = $localValueCode;\n"); |
|
214 | 214 | } |
215 | 215 | } |
216 | 216 | |
217 | - private function outputConfigUpdatesWgConf( array $configUpdates ) { |
|
218 | - foreach ( $configUpdates as $key => $value ) { |
|
219 | - $keyCode = var_export( "wg$key", true ); |
|
220 | - $wikidataValueCode = var_export( $value['wikidata'], true ); |
|
221 | - $localValueCode = var_export( $value['local'], true ); |
|
222 | - $wikiIdCode = var_export( wfWikiID(), true ); |
|
217 | + private function outputConfigUpdatesWgConf(array $configUpdates) { |
|
218 | + foreach ($configUpdates as $key => $value) { |
|
219 | + $keyCode = var_export("wg$key", true); |
|
220 | + $wikidataValueCode = var_export($value['wikidata'], true); |
|
221 | + $localValueCode = var_export($value['local'], true); |
|
222 | + $wikiIdCode = var_export(wfWikiID(), true); |
|
223 | 223 | $block = <<< EOF |
224 | 224 | $keyCode => [ |
225 | 225 | 'default' => $wikidataValueCode, |
@@ -228,7 +228,7 @@ discard block |
||
228 | 228 | |
229 | 229 | |
230 | 230 | EOF; |
231 | - $this->output( $block ); |
|
231 | + $this->output($block); |
|
232 | 232 | } |
233 | 233 | } |
234 | 234 |