@@ -44,7 +44,7 @@ discard block |
||
| 44 | 44 | * @param ItemId $itemId |
| 45 | 45 | * @return self |
| 46 | 46 | */ |
| 47 | - public static function fromItemId( ItemId $itemId ) { |
|
| 47 | + public static function fromItemId(ItemId $itemId) { |
|
| 48 | 48 | $ret = new self; |
| 49 | 49 | $ret->itemId = $itemId; |
| 50 | 50 | return $ret; |
@@ -80,14 +80,14 @@ discard block |
||
| 80 | 80 | * @throws InvalidArgumentException |
| 81 | 81 | * @return self |
| 82 | 82 | */ |
| 83 | - public static function fromSnak( Snak $snak ) { |
|
| 84 | - switch ( true ) { |
|
| 83 | + public static function fromSnak(Snak $snak) { |
|
| 84 | + switch (true) { |
|
| 85 | 85 | case $snak instanceof PropertyValueSnak: |
| 86 | 86 | $dataValue = $snak->getDataValue(); |
| 87 | - if ( $dataValue instanceof EntityIdValue ) { |
|
| 87 | + if ($dataValue instanceof EntityIdValue) { |
|
| 88 | 88 | $itemId = $dataValue->getEntityId(); |
| 89 | - if ( $itemId instanceof ItemId ) { |
|
| 90 | - return self::fromItemId( $itemId ); |
|
| 89 | + if ($itemId instanceof ItemId) { |
|
| 90 | + return self::fromItemId($itemId); |
|
| 91 | 91 | } |
| 92 | 92 | } |
| 93 | 93 | break; |
@@ -97,7 +97,7 @@ discard block |
||
| 97 | 97 | return self::noValue(); |
| 98 | 98 | } |
| 99 | 99 | |
| 100 | - throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' ); |
|
| 100 | + throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak'); |
|
| 101 | 101 | } |
| 102 | 102 | |
| 103 | 103 | /** |
@@ -135,8 +135,8 @@ discard block |
||
| 135 | 135 | * @return ItemId |
| 136 | 136 | */ |
| 137 | 137 | public function getItemId() { |
| 138 | - if ( !$this->isValue() ) { |
|
| 139 | - throw new DomainException( 'This value does not contain an item ID.' ); |
|
| 138 | + if (!$this->isValue()) { |
|
| 139 | + throw new DomainException('This value does not contain an item ID.'); |
|
| 140 | 140 | } |
| 141 | 141 | return $this->itemId; |
| 142 | 142 | } |
@@ -148,14 +148,14 @@ discard block |
||
| 148 | 148 | * @param Snak $snak |
| 149 | 149 | * @return bool |
| 150 | 150 | */ |
| 151 | - public function matchesSnak( Snak $snak ) { |
|
| 152 | - switch ( true ) { |
|
| 151 | + public function matchesSnak(Snak $snak) { |
|
| 152 | + switch (true) { |
|
| 153 | 153 | case $snak instanceof PropertyValueSnak: |
| 154 | 154 | $dataValue = $snak->getDataValue(); |
| 155 | 155 | return $this->isValue() && |
| 156 | 156 | $dataValue instanceof EntityIdValue && |
| 157 | 157 | $dataValue->getEntityId() instanceof ItemId && |
| 158 | - $dataValue->getEntityId()->equals( $this->getItemId() ); |
|
| 158 | + $dataValue->getEntityId()->equals($this->getItemId()); |
|
| 159 | 159 | case $snak instanceof PropertySomeValueSnak: |
| 160 | 160 | return $this->isSomeValue(); |
| 161 | 161 | case $snak instanceof PropertyNoValueSnak: |
@@ -47,7 +47,7 @@ discard block |
||
| 47 | 47 | EntityIdLookup $entityIdLookup, |
| 48 | 48 | RdfVocabulary $rdfVocabulary |
| 49 | 49 | ) { |
| 50 | - parent::__construct( $page, $context ); |
|
| 50 | + parent::__construct($page, $context); |
|
| 51 | 51 | $this->resultsSource = $resultsSource; |
| 52 | 52 | $this->entityIdLookup = $entityIdLookup; |
| 53 | 53 | $this->rdfVocabulary = $rdfVocabulary; |
@@ -108,8 +108,8 @@ discard block |
||
| 108 | 108 | * @param string $guid |
| 109 | 109 | * @return string |
| 110 | 110 | */ |
| 111 | - private function cleanupGuid( $guid ) { |
|
| 112 | - return preg_replace( '/[^\w-]/', '-', $guid ); |
|
| 111 | + private function cleanupGuid($guid) { |
|
| 112 | + return preg_replace('/[^\w-]/', '-', $guid); |
|
| 113 | 113 | } |
| 114 | 114 | |
| 115 | 115 | /** |
@@ -121,60 +121,60 @@ discard block |
||
| 121 | 121 | $response = $this->getRequest()->response(); |
| 122 | 122 | $this->getOutput()->disable(); |
| 123 | 123 | |
| 124 | - if ( !$this->resultsSource instanceof CachingResultsSource ) { |
|
| 124 | + if (!$this->resultsSource instanceof CachingResultsSource) { |
|
| 125 | 125 | // TODO: make configurable whether only cached results are returned |
| 126 | - $response->statusHeader( 501 ); // Not Implemented |
|
| 126 | + $response->statusHeader(501); // Not Implemented |
|
| 127 | 127 | return null; |
| 128 | 128 | } |
| 129 | 129 | |
| 130 | - $entityId = $this->entityIdLookup->getEntityIdForTitle( $this->getTitle() ); |
|
| 131 | - if ( $entityId === null ) { |
|
| 132 | - $response->statusHeader( 404 ); // Not Found |
|
| 130 | + $entityId = $this->entityIdLookup->getEntityIdForTitle($this->getTitle()); |
|
| 131 | + if ($entityId === null) { |
|
| 132 | + $response->statusHeader(404); // Not Found |
|
| 133 | 133 | return null; |
| 134 | 134 | } |
| 135 | - $revId = $this->getRequest()->getInt( 'revision' ); |
|
| 135 | + $revId = $this->getRequest()->getInt('revision'); |
|
| 136 | 136 | |
| 137 | - $results = $this->resultsSource->getStoredResults( $entityId, $revId ); |
|
| 138 | - if ( $results === null ) { |
|
| 139 | - $response->statusHeader( 204 ); // No Content |
|
| 137 | + $results = $this->resultsSource->getStoredResults($entityId, $revId); |
|
| 138 | + if ($results === null) { |
|
| 139 | + $response->statusHeader(204); // No Content |
|
| 140 | 140 | return null; |
| 141 | 141 | } |
| 142 | 142 | |
| 143 | 143 | $format = 'ttl'; // TODO: make format an option |
| 144 | 144 | |
| 145 | 145 | $writerFactory = new RdfWriterFactory(); |
| 146 | - $formatName = $writerFactory->getFormatName( $format ); |
|
| 147 | - $contentType = $writerFactory->getMimeTypes( $formatName )[0]; |
|
| 146 | + $formatName = $writerFactory->getFormatName($format); |
|
| 147 | + $contentType = $writerFactory->getMimeTypes($formatName)[0]; |
|
| 148 | 148 | |
| 149 | - $writer = $writerFactory->getWriter( $formatName ); |
|
| 150 | - foreach ( [ RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY ] as $ns ) { |
|
| 151 | - $writer->prefix( $ns, $this->rdfVocabulary->getNamespaceURI( $ns ) ); |
|
| 149 | + $writer = $writerFactory->getWriter($formatName); |
|
| 150 | + foreach ([RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY] as $ns) { |
|
| 151 | + $writer->prefix($ns, $this->rdfVocabulary->getNamespaceURI($ns)); |
|
| 152 | 152 | } |
| 153 | 153 | $writer->start(); |
| 154 | 154 | $writtenAny = false; |
| 155 | 155 | |
| 156 | - foreach ( $results->getArray() as $checkResult ) { |
|
| 157 | - if ( $checkResult instanceof NullResult ) { |
|
| 156 | + foreach ($results->getArray() as $checkResult) { |
|
| 157 | + if ($checkResult instanceof NullResult) { |
|
| 158 | 158 | continue; |
| 159 | 159 | } |
| 160 | - if ( $checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS ) { |
|
| 160 | + if ($checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS) { |
|
| 161 | 161 | continue; |
| 162 | 162 | } |
| 163 | 163 | $writtenAny = true; |
| 164 | - $writer->about( RdfVocabulary::NS_STATEMENT, |
|
| 165 | - $this->cleanupGuid( $checkResult->getContextCursor()->getStatementGuid() ) ) |
|
| 166 | - ->say( RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint' ) |
|
| 167 | - ->is( RdfVocabulary::NS_STATEMENT, |
|
| 168 | - $this->cleanupGuid( $checkResult->getConstraint()->getConstraintId() ) ); |
|
| 164 | + $writer->about(RdfVocabulary::NS_STATEMENT, |
|
| 165 | + $this->cleanupGuid($checkResult->getContextCursor()->getStatementGuid())) |
|
| 166 | + ->say(RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint') |
|
| 167 | + ->is(RdfVocabulary::NS_STATEMENT, |
|
| 168 | + $this->cleanupGuid($checkResult->getConstraint()->getConstraintId())); |
|
| 169 | 169 | } |
| 170 | 170 | $writer->finish(); |
| 171 | - if ( $writtenAny ) { |
|
| 172 | - $response->header( "Content-Type: $contentType; charset=UTF-8" ); |
|
| 171 | + if ($writtenAny) { |
|
| 172 | + $response->header("Content-Type: $contentType; charset=UTF-8"); |
|
| 173 | 173 | echo $writer->drain(); |
| 174 | 174 | } else { |
| 175 | 175 | // Do not output RDF if we haven't written any actual statements. Output 204 instead |
| 176 | 176 | $writer->drain(); |
| 177 | - $response->statusHeader( 204 ); // No Content |
|
| 177 | + $response->statusHeader(204); // No Content |
|
| 178 | 178 | } |
| 179 | 179 | return null; |
| 180 | 180 | } |
@@ -37,25 +37,25 @@ discard block |
||
| 37 | 37 | * @param Title $title |
| 38 | 38 | * @param string[] $params should contain 'entityId' => 'Q1234' |
| 39 | 39 | */ |
| 40 | - public function __construct( Title $title, array $params ) { |
|
| 41 | - parent::__construct( self::COMMAND, $title, $params ); |
|
| 40 | + public function __construct(Title $title, array $params) { |
|
| 41 | + parent::__construct(self::COMMAND, $title, $params); |
|
| 42 | 42 | $this->removeDuplicates = true; |
| 43 | 43 | |
| 44 | - Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' ); |
|
| 44 | + Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']'); |
|
| 45 | 45 | |
| 46 | - $resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() ); |
|
| 46 | + $resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance()); |
|
| 47 | 47 | '@phan-var CachingResultsSource $resultSource'; |
| 48 | 48 | // This job should only ever be used when caching result sources are used. |
| 49 | - $this->setResultsSource( $resultSource ); |
|
| 49 | + $this->setResultsSource($resultSource); |
|
| 50 | 50 | |
| 51 | - $this->setEntityIdParser( WikibaseRepo::getEntityIdParser() ); |
|
| 51 | + $this->setEntityIdParser(WikibaseRepo::getEntityIdParser()); |
|
| 52 | 52 | } |
| 53 | 53 | |
| 54 | - public function setResultsSource( CachingResultsSource $resultsSource ) { |
|
| 54 | + public function setResultsSource(CachingResultsSource $resultsSource) { |
|
| 55 | 55 | $this->resultsSource = $resultsSource; |
| 56 | 56 | } |
| 57 | 57 | |
| 58 | - public function setEntityIdParser( EntityIdParser $parser ) { |
|
| 58 | + public function setEntityIdParser(EntityIdParser $parser) { |
|
| 59 | 59 | $this->entityIdParser = $parser; |
| 60 | 60 | } |
| 61 | 61 | |
@@ -66,19 +66,19 @@ discard block |
||
| 66 | 66 | */ |
| 67 | 67 | public function run() { |
| 68 | 68 | try { |
| 69 | - $entityId = $this->entityIdParser->parse( $this->params['entityId'] ); |
|
| 70 | - } catch ( EntityIdParsingException $e ) { |
|
| 69 | + $entityId = $this->entityIdParser->parse($this->params['entityId']); |
|
| 70 | + } catch (EntityIdParsingException $e) { |
|
| 71 | 71 | return false; |
| 72 | 72 | } |
| 73 | 73 | |
| 74 | - $this->checkConstraints( $entityId ); |
|
| 74 | + $this->checkConstraints($entityId); |
|
| 75 | 75 | |
| 76 | 76 | return true; |
| 77 | 77 | } |
| 78 | 78 | |
| 79 | - private function checkConstraints( EntityId $entityId ) { |
|
| 79 | + private function checkConstraints(EntityId $entityId) { |
|
| 80 | 80 | $this->resultsSource->getResults( |
| 81 | - [ $entityId ], |
|
| 81 | + [$entityId], |
|
| 82 | 82 | [], |
| 83 | 83 | null, |
| 84 | 84 | [] |
@@ -38,87 +38,87 @@ |
||
| 38 | 38 | public const RESULTS_SOURCE = 'WBQC_ResultsSource'; |
| 39 | 39 | public const EXPIRY_LOCK = 'WBQC_ExpiryLock'; |
| 40 | 40 | |
| 41 | - private static function getService( ?MediaWikiServices $services, $name ) { |
|
| 42 | - if ( $services === null ) { |
|
| 41 | + private static function getService(?MediaWikiServices $services, $name) { |
|
| 42 | + if ($services === null) { |
|
| 43 | 43 | $services = MediaWikiServices::getInstance(); |
| 44 | 44 | } |
| 45 | - return $services->getService( $name ); |
|
| 45 | + return $services->getService($name); |
|
| 46 | 46 | } |
| 47 | 47 | |
| 48 | - public static function getLoggingHelper( MediaWikiServices $services = null ): LoggingHelper { |
|
| 49 | - return self::getService( $services, self::LOGGING_HELPER ); |
|
| 48 | + public static function getLoggingHelper(MediaWikiServices $services = null): LoggingHelper { |
|
| 49 | + return self::getService($services, self::LOGGING_HELPER); |
|
| 50 | 50 | } |
| 51 | 51 | |
| 52 | 52 | public static function getConstraintStore( |
| 53 | 53 | MediaWikiServices $services = null |
| 54 | 54 | ): ConstraintStore { |
| 55 | - return self::getService( $services, self::CONSTRAINT_STORE ); |
|
| 55 | + return self::getService($services, self::CONSTRAINT_STORE); |
|
| 56 | 56 | } |
| 57 | 57 | |
| 58 | - public static function getConstraintLookup( MediaWikiServices $services = null ): ConstraintLookup { |
|
| 59 | - return self::getService( $services, self::CONSTRAINT_LOOKUP ); |
|
| 58 | + public static function getConstraintLookup(MediaWikiServices $services = null): ConstraintLookup { |
|
| 59 | + return self::getService($services, self::CONSTRAINT_LOOKUP); |
|
| 60 | 60 | } |
| 61 | 61 | |
| 62 | 62 | public static function getCheckResultSerializer( |
| 63 | 63 | MediaWikiServices $services = null |
| 64 | 64 | ): CheckResultSerializer { |
| 65 | - return self::getService( $services, self::CHECK_RESULT_SERIALIZER ); |
|
| 65 | + return self::getService($services, self::CHECK_RESULT_SERIALIZER); |
|
| 66 | 66 | } |
| 67 | 67 | |
| 68 | 68 | public static function getCheckResultDeserializer( |
| 69 | 69 | MediaWikiServices $services = null |
| 70 | 70 | ): CheckResultDeserializer { |
| 71 | - return self::getService( $services, self::CHECK_RESULT_DESERIALIZER ); |
|
| 71 | + return self::getService($services, self::CHECK_RESULT_DESERIALIZER); |
|
| 72 | 72 | } |
| 73 | 73 | |
| 74 | 74 | public static function getViolationMessageSerializer( |
| 75 | 75 | MediaWikiServices $services = null |
| 76 | 76 | ): ViolationMessageSerializer { |
| 77 | - return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER ); |
|
| 77 | + return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER); |
|
| 78 | 78 | } |
| 79 | 79 | |
| 80 | 80 | public static function getViolationMessageDeserializer( |
| 81 | 81 | MediaWikiServices $services = null |
| 82 | 82 | ): ViolationMessageDeserializer { |
| 83 | - return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER ); |
|
| 83 | + return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER); |
|
| 84 | 84 | } |
| 85 | 85 | |
| 86 | 86 | public static function getConstraintParameterParser( |
| 87 | 87 | MediaWikiServices $services = null |
| 88 | 88 | ): ConstraintParameterParser { |
| 89 | - return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER ); |
|
| 89 | + return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER); |
|
| 90 | 90 | } |
| 91 | 91 | |
| 92 | 92 | public static function getConnectionCheckerHelper( |
| 93 | 93 | MediaWikiServices $services = null |
| 94 | 94 | ): ConnectionCheckerHelper { |
| 95 | - return self::getService( $services, self::CONNECTION_CHECKER_HELPER ); |
|
| 95 | + return self::getService($services, self::CONNECTION_CHECKER_HELPER); |
|
| 96 | 96 | } |
| 97 | 97 | |
| 98 | - public static function getRangeCheckerHelper( MediaWikiServices $services = null ): RangeCheckerHelper { |
|
| 99 | - return self::getService( $services, self::RANGE_CHECKER_HELPER ); |
|
| 98 | + public static function getRangeCheckerHelper(MediaWikiServices $services = null): RangeCheckerHelper { |
|
| 99 | + return self::getService($services, self::RANGE_CHECKER_HELPER); |
|
| 100 | 100 | } |
| 101 | 101 | |
| 102 | - public static function getSparqlHelper( MediaWikiServices $services = null ): SparqlHelper { |
|
| 103 | - return self::getService( $services, self::SPARQL_HELPER ); |
|
| 102 | + public static function getSparqlHelper(MediaWikiServices $services = null): SparqlHelper { |
|
| 103 | + return self::getService($services, self::SPARQL_HELPER); |
|
| 104 | 104 | } |
| 105 | 105 | |
| 106 | - public static function getTypeCheckerHelper( MediaWikiServices $services = null ): TypeCheckerHelper { |
|
| 107 | - return self::getService( $services, self::TYPE_CHECKER_HELPER ); |
|
| 106 | + public static function getTypeCheckerHelper(MediaWikiServices $services = null): TypeCheckerHelper { |
|
| 107 | + return self::getService($services, self::TYPE_CHECKER_HELPER); |
|
| 108 | 108 | } |
| 109 | 109 | |
| 110 | 110 | public static function getDelegatingConstraintChecker( |
| 111 | 111 | MediaWikiServices $services = null |
| 112 | 112 | ): DelegatingConstraintChecker { |
| 113 | - return self::getService( $services, self::DELEGATING_CONSTRAINT_CHECKER ); |
|
| 113 | + return self::getService($services, self::DELEGATING_CONSTRAINT_CHECKER); |
|
| 114 | 114 | } |
| 115 | 115 | |
| 116 | - public static function getResultsSource( MediaWikiServices $services = null ): ResultsSource { |
|
| 117 | - return self::getService( $services, self::RESULTS_SOURCE ); |
|
| 116 | + public static function getResultsSource(MediaWikiServices $services = null): ResultsSource { |
|
| 117 | + return self::getService($services, self::RESULTS_SOURCE); |
|
| 118 | 118 | } |
| 119 | 119 | |
| 120 | - public static function getExpiryLock( MediaWikiServices $services = null ): ExpiryLock { |
|
| 121 | - return self::getService( $services, self::EXPIRY_LOCK ); |
|
| 120 | + public static function getExpiryLock(MediaWikiServices $services = null): ExpiryLock { |
|
| 121 | + return self::getService($services, self::EXPIRY_LOCK); |
|
| 122 | 122 | } |
| 123 | 123 | |
| 124 | 124 | } |
@@ -20,35 +20,35 @@ |
||
| 20 | 20 | public const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup'; |
| 21 | 21 | public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache'; |
| 22 | 22 | |
| 23 | - private static function getService( ?MediaWikiServices $services, $name ) { |
|
| 24 | - if ( $services === null ) { |
|
| 23 | + private static function getService(?MediaWikiServices $services, $name) { |
|
| 24 | + if ($services === null) { |
|
| 25 | 25 | $services = MediaWikiServices::getInstance(); |
| 26 | 26 | } |
| 27 | - return $services->getService( $name ); |
|
| 27 | + return $services->getService($name); |
|
| 28 | 28 | } |
| 29 | 29 | |
| 30 | 30 | /** |
| 31 | 31 | * @param MediaWikiServices|null $services |
| 32 | 32 | * @return EntityLookup |
| 33 | 33 | */ |
| 34 | - public static function getEntityLookup( MediaWikiServices $services = null ) { |
|
| 35 | - return self::getService( $services, self::ENTITY_LOOKUP ); |
|
| 34 | + public static function getEntityLookup(MediaWikiServices $services = null) { |
|
| 35 | + return self::getService($services, self::ENTITY_LOOKUP); |
|
| 36 | 36 | } |
| 37 | 37 | |
| 38 | 38 | /** |
| 39 | 39 | * @param MediaWikiServices|null $services |
| 40 | 40 | * @return PropertyDataTypeLookup |
| 41 | 41 | */ |
| 42 | - public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) { |
|
| 43 | - return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP ); |
|
| 42 | + public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) { |
|
| 43 | + return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP); |
|
| 44 | 44 | } |
| 45 | 45 | |
| 46 | 46 | /** |
| 47 | 47 | * @param MediaWikiServices|null $services |
| 48 | 48 | * @return EntityLookup |
| 49 | 49 | */ |
| 50 | - public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ) { |
|
| 51 | - return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE ); |
|
| 50 | + public static function getEntityLookupWithoutCache(MediaWikiServices $services = null) { |
|
| 51 | + return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE); |
|
| 52 | 52 | } |
| 53 | 53 | |
| 54 | 54 | } |
@@ -54,13 +54,13 @@ discard block |
||
| 54 | 54 | * @param ViolationMessage $violationMessage |
| 55 | 55 | * @return string |
| 56 | 56 | */ |
| 57 | - public function render( ViolationMessage $violationMessage ) { |
|
| 58 | - if ( !array_key_exists( $violationMessage->getMessageKey(), $this->alternativeMessageKeys ) ) { |
|
| 59 | - return parent::render( $violationMessage ); |
|
| 57 | + public function render(ViolationMessage $violationMessage) { |
|
| 58 | + if (!array_key_exists($violationMessage->getMessageKey(), $this->alternativeMessageKeys)) { |
|
| 59 | + return parent::render($violationMessage); |
|
| 60 | 60 | } |
| 61 | 61 | |
| 62 | 62 | $arguments = $violationMessage->getArguments(); |
| 63 | - $multilingualTextArgument = array_pop( $arguments ); |
|
| 63 | + $multilingualTextArgument = array_pop($arguments); |
|
| 64 | 64 | $multilingualTextParams = $this->renderMultilingualText( |
| 65 | 65 | // @phan-suppress-next-line PhanTypeArraySuspiciousNullable TODO Ensure this is not an actual issue |
| 66 | 66 | $multilingualTextArgument['value'], |
@@ -68,22 +68,22 @@ discard block |
||
| 68 | 68 | $multilingualTextArgument['role'] |
| 69 | 69 | ); |
| 70 | 70 | |
| 71 | - $paramsLists = [ [] ]; |
|
| 72 | - foreach ( $arguments as $argument ) { |
|
| 73 | - $paramsLists[] = $this->renderArgument( $argument ); |
|
| 71 | + $paramsLists = [[]]; |
|
| 72 | + foreach ($arguments as $argument) { |
|
| 73 | + $paramsLists[] = $this->renderArgument($argument); |
|
| 74 | 74 | } |
| 75 | - $regularParams = call_user_func_array( 'array_merge', $paramsLists ); |
|
| 75 | + $regularParams = call_user_func_array('array_merge', $paramsLists); |
|
| 76 | 76 | |
| 77 | - if ( $multilingualTextParams === null ) { |
|
| 77 | + if ($multilingualTextParams === null) { |
|
| 78 | 78 | return $this->messageLocalizer |
| 79 | - ->msg( $this->alternativeMessageKeys[$violationMessage->getMessageKey()] ) |
|
| 80 | - ->params( $regularParams ) |
|
| 79 | + ->msg($this->alternativeMessageKeys[$violationMessage->getMessageKey()]) |
|
| 80 | + ->params($regularParams) |
|
| 81 | 81 | ->escaped(); |
| 82 | 82 | } else { |
| 83 | 83 | return $this->messageLocalizer |
| 84 | - ->msg( $violationMessage->getMessageKey() ) |
|
| 85 | - ->params( $regularParams ) |
|
| 86 | - ->params( $multilingualTextParams ) |
|
| 84 | + ->msg($violationMessage->getMessageKey()) |
|
| 85 | + ->params($regularParams) |
|
| 86 | + ->params($multilingualTextParams) |
|
| 87 | 87 | ->escaped(); |
| 88 | 88 | } |
| 89 | 89 | } |
@@ -94,18 +94,18 @@ discard block |
||
| 94 | 94 | * @return array[]|null list of parameters as accepted by Message::params(), |
| 95 | 95 | * or null if the text is not available in the user’s language |
| 96 | 96 | */ |
| 97 | - protected function renderMultilingualText( MultilingualTextValue $text, $role ) { |
|
| 97 | + protected function renderMultilingualText(MultilingualTextValue $text, $role) { |
|
| 98 | 98 | global $wgLang; |
| 99 | 99 | $languageCodes = $wgLang->getFallbackLanguages(); |
| 100 | - array_unshift( $languageCodes, $wgLang->getCode() ); |
|
| 100 | + array_unshift($languageCodes, $wgLang->getCode()); |
|
| 101 | 101 | |
| 102 | 102 | $texts = $text->getTexts(); |
| 103 | - foreach ( $languageCodes as $languageCode ) { |
|
| 104 | - if ( array_key_exists( $languageCode, $texts ) ) { |
|
| 105 | - return [ Message::rawParam( $this->addRole( |
|
| 106 | - htmlspecialchars( $texts[$languageCode]->getText() ), |
|
| 103 | + foreach ($languageCodes as $languageCode) { |
|
| 104 | + if (array_key_exists($languageCode, $texts)) { |
|
| 105 | + return [Message::rawParam($this->addRole( |
|
| 106 | + htmlspecialchars($texts[$languageCode]->getText()), |
|
| 107 | 107 | $role |
| 108 | - ) ) ]; |
|
| 108 | + ))]; |
|
| 109 | 109 | } |
| 110 | 110 | } |
| 111 | 111 | |
@@ -36,7 +36,7 @@ discard block |
||
| 36 | 36 | * @param WANObjectCache $cache |
| 37 | 37 | * @param string $formatVersion The version of the API response format. |
| 38 | 38 | */ |
| 39 | - public function __construct( WANObjectCache $cache, $formatVersion ) { |
|
| 39 | + public function __construct(WANObjectCache $cache, $formatVersion) { |
|
| 40 | 40 | $this->cache = $cache; |
| 41 | 41 | $this->formatVersion = $formatVersion; |
| 42 | 42 | } |
@@ -45,7 +45,7 @@ discard block |
||
| 45 | 45 | * @param EntityId $entityId |
| 46 | 46 | * @return string cache key |
| 47 | 47 | */ |
| 48 | - public function makeKey( EntityId $entityId ) { |
|
| 48 | + public function makeKey(EntityId $entityId) { |
|
| 49 | 49 | return $this->cache->makeKey( |
| 50 | 50 | 'WikibaseQualityConstraints', // extension |
| 51 | 51 | 'checkConstraints', // action |
@@ -61,8 +61,8 @@ discard block |
||
| 61 | 61 | * @param mixed|null &$info |
| 62 | 62 | * @return mixed |
| 63 | 63 | */ |
| 64 | - public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$info = null ) { |
|
| 65 | - return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $info ); |
|
| 64 | + public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$info = null) { |
|
| 65 | + return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $info); |
|
| 66 | 66 | } |
| 67 | 67 | |
| 68 | 68 | /** |
@@ -72,16 +72,16 @@ discard block |
||
| 72 | 72 | * @param array $opts |
| 73 | 73 | * @return bool |
| 74 | 74 | */ |
| 75 | - public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) { |
|
| 76 | - return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts ); |
|
| 75 | + public function set(EntityId $key, $value, $ttl = 0, array $opts = []) { |
|
| 76 | + return $this->cache->set($this->makeKey($key), $value, $ttl, $opts); |
|
| 77 | 77 | } |
| 78 | 78 | |
| 79 | 79 | /** |
| 80 | 80 | * @param EntityId $key |
| 81 | 81 | * @return bool |
| 82 | 82 | */ |
| 83 | - public function delete( EntityId $key ) { |
|
| 84 | - return $this->cache->delete( $this->makeKey( $key ) ); |
|
| 83 | + public function delete(EntityId $key) { |
|
| 84 | + return $this->cache->delete($this->makeKey($key)); |
|
| 85 | 85 | } |
| 86 | 86 | |
| 87 | 87 | } |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\Api; |
| 6 | 6 | |
@@ -33,13 +33,13 @@ discard block |
||
| 33 | 33 | $this->violationMessageRendererFactory = $violationMessageRendererFactory; |
| 34 | 34 | } |
| 35 | 35 | |
| 36 | - public function getCheckResultsRenderer( Language $language ): CheckResultsRenderer { |
|
| 36 | + public function getCheckResultsRenderer(Language $language): CheckResultsRenderer { |
|
| 37 | 37 | return new CheckResultsRenderer( |
| 38 | 38 | $this->entityTitleLookup, |
| 39 | 39 | $this->entityIdLabelFormatterFactory |
| 40 | - ->getEntityIdFormatter( $language ), |
|
| 40 | + ->getEntityIdFormatter($language), |
|
| 41 | 41 | $this->violationMessageRendererFactory |
| 42 | - ->getViolationMessageRenderer( $language ) |
|
| 42 | + ->getViolationMessageRenderer($language) |
|
| 43 | 43 | ); |
| 44 | 44 | } |
| 45 | 45 | |
@@ -116,11 +116,11 @@ discard block |
||
| 116 | 116 | CheckResultsRendererFactory $checkResultsRendererFactory, |
| 117 | 117 | IBufferingStatsdDataFactory $dataFactory |
| 118 | 118 | ) { |
| 119 | - parent::__construct( $main, $name ); |
|
| 119 | + parent::__construct($main, $name); |
|
| 120 | 120 | $this->entityIdParser = $entityIdParser; |
| 121 | 121 | $this->statementGuidValidator = $statementGuidValidator; |
| 122 | - $this->resultBuilder = $apiHelperFactory->getResultBuilder( $this ); |
|
| 123 | - $this->errorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
| 122 | + $this->resultBuilder = $apiHelperFactory->getResultBuilder($this); |
|
| 123 | + $this->errorReporter = $apiHelperFactory->getErrorReporter($this); |
|
| 124 | 124 | $this->resultsSource = $resultsSource; |
| 125 | 125 | $this->checkResultsRendererFactory = $checkResultsRendererFactory; |
| 126 | 126 | $this->dataFactory = $dataFactory; |
@@ -136,14 +136,14 @@ discard block |
||
| 136 | 136 | |
| 137 | 137 | $params = $this->extractRequestParams(); |
| 138 | 138 | |
| 139 | - $this->validateParameters( $params ); |
|
| 140 | - $entityIds = $this->parseEntityIds( $params ); |
|
| 141 | - $claimIds = $this->parseClaimIds( $params ); |
|
| 139 | + $this->validateParameters($params); |
|
| 140 | + $entityIds = $this->parseEntityIds($params); |
|
| 141 | + $claimIds = $this->parseClaimIds($params); |
|
| 142 | 142 | $constraintIDs = $params[self::PARAM_CONSTRAINT_ID]; |
| 143 | 143 | $statuses = $params[self::PARAM_STATUS]; |
| 144 | 144 | |
| 145 | 145 | $checkResultsRenderer = $this->checkResultsRendererFactory |
| 146 | - ->getCheckResultsRenderer( $this->getLanguage() ); |
|
| 146 | + ->getCheckResultsRenderer($this->getLanguage()); |
|
| 147 | 147 | |
| 148 | 148 | $this->getResult()->addValue( |
| 149 | 149 | null, |
@@ -157,7 +157,7 @@ discard block |
||
| 157 | 157 | ) |
| 158 | 158 | )->getArray() |
| 159 | 159 | ); |
| 160 | - $this->resultBuilder->markSuccess( 1 ); |
|
| 160 | + $this->resultBuilder->markSuccess(1); |
|
| 161 | 161 | } |
| 162 | 162 | |
| 163 | 163 | /** |
@@ -165,24 +165,24 @@ discard block |
||
| 165 | 165 | * |
| 166 | 166 | * @return EntityId[] |
| 167 | 167 | */ |
| 168 | - private function parseEntityIds( array $params ) { |
|
| 168 | + private function parseEntityIds(array $params) { |
|
| 169 | 169 | $ids = $params[self::PARAM_ID]; |
| 170 | 170 | |
| 171 | - if ( $ids === null ) { |
|
| 171 | + if ($ids === null) { |
|
| 172 | 172 | return []; |
| 173 | - } elseif ( $ids === [] ) { |
|
| 173 | + } elseif ($ids === []) { |
|
| 174 | 174 | $this->errorReporter->dieError( |
| 175 | - 'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
| 175 | + 'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
| 176 | 176 | } |
| 177 | 177 | |
| 178 | - return array_map( function ( $id ) { |
|
| 178 | + return array_map(function($id) { |
|
| 179 | 179 | try { |
| 180 | - return $this->entityIdParser->parse( $id ); |
|
| 181 | - } catch ( EntityIdParsingException $e ) { |
|
| 180 | + return $this->entityIdParser->parse($id); |
|
| 181 | + } catch (EntityIdParsingException $e) { |
|
| 182 | 182 | $this->errorReporter->dieError( |
| 183 | - "Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] ); |
|
| 183 | + "Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] ); |
|
| 184 | 184 | } |
| 185 | - }, $ids ); |
|
| 185 | + }, $ids); |
|
| 186 | 186 | } |
| 187 | 187 | |
| 188 | 188 | /** |
@@ -190,35 +190,35 @@ discard block |
||
| 190 | 190 | * |
| 191 | 191 | * @return string[] |
| 192 | 192 | */ |
| 193 | - private function parseClaimIds( array $params ) { |
|
| 193 | + private function parseClaimIds(array $params) { |
|
| 194 | 194 | $ids = $params[self::PARAM_CLAIM_ID]; |
| 195 | 195 | |
| 196 | - if ( $ids === null ) { |
|
| 196 | + if ($ids === null) { |
|
| 197 | 197 | return []; |
| 198 | - } elseif ( $ids === [] ) { |
|
| 198 | + } elseif ($ids === []) { |
|
| 199 | 199 | $this->errorReporter->dieError( |
| 200 | - 'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
| 200 | + 'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
| 201 | 201 | } |
| 202 | 202 | |
| 203 | - foreach ( $ids as $id ) { |
|
| 204 | - if ( !$this->statementGuidValidator->validate( $id ) ) { |
|
| 203 | + foreach ($ids as $id) { |
|
| 204 | + if (!$this->statementGuidValidator->validate($id)) { |
|
| 205 | 205 | $this->errorReporter->dieError( |
| 206 | - "Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] ); |
|
| 206 | + "Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] ); |
|
| 207 | 207 | } |
| 208 | 208 | } |
| 209 | 209 | |
| 210 | 210 | return $ids; |
| 211 | 211 | } |
| 212 | 212 | |
| 213 | - private function validateParameters( array $params ) { |
|
| 214 | - if ( $params[self::PARAM_CONSTRAINT_ID] !== null |
|
| 215 | - && empty( $params[self::PARAM_CONSTRAINT_ID] ) |
|
| 213 | + private function validateParameters(array $params) { |
|
| 214 | + if ($params[self::PARAM_CONSTRAINT_ID] !== null |
|
| 215 | + && empty($params[self::PARAM_CONSTRAINT_ID]) |
|
| 216 | 216 | ) { |
| 217 | 217 | $paramConstraintId = self::PARAM_CONSTRAINT_ID; |
| 218 | 218 | $this->errorReporter->dieError( |
| 219 | 219 | "If $paramConstraintId is specified, it must be nonempty.", 'no-data' ); |
| 220 | 220 | } |
| 221 | - if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) { |
|
| 221 | + if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) { |
|
| 222 | 222 | $paramId = self::PARAM_ID; |
| 223 | 223 | $paramClaimId = self::PARAM_CLAIM_ID; |
| 224 | 224 | $this->errorReporter->dieError( |
@@ -259,7 +259,7 @@ discard block |
||
| 259 | 259 | ], |
| 260 | 260 | ApiBase::PARAM_ISMULTI => true, |
| 261 | 261 | ApiBase::PARAM_ALL => true, |
| 262 | - ApiBase::PARAM_DFLT => implode( '|', CachingResultsSource::CACHED_STATUSES ), |
|
| 262 | + ApiBase::PARAM_DFLT => implode('|', CachingResultsSource::CACHED_STATUSES), |
|
| 263 | 263 | ApiBase::PARAM_HELP_MSG_PER_VALUE => [], |
| 264 | 264 | ], |
| 265 | 265 | ]; |