View GitHub Repository mediawiki-extensions-WikibaseQualityConstraints

Schedule Inspection
Subscribe
Completed
Push — master ( 73771e...5d3823 )
by
unknown
58s queued 14s
created
Status
Category
Toggle Patches
src/ConstraintCheck/Checker/NoneOfChecker.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,9 @@  discard block
 
 block discarded – undo
60 60 
 	 * @throws ConstraintParameterException
61 61 
 	 * @return CheckResult
62 62 
 	 */
63 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
64 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
65 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
63 
+	public function checkConstraint(Context $context, Constraint $constraint) {
64 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
65 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
66 66 
 		}
67 67
68 68 
 		$parameters = [];
 
@@ -81,20 +81,20 @@  discard block
 
 block discarded – undo
81 81 
 		$message = null;
82 82 
 		$status = CheckResult::STATUS_COMPLIANCE;
83 83
84 
-		foreach ( $items as $item ) {
85 
-			if ( $item->matchesSnak( $snak ) ) {
86 
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
87 
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
88 
-					->withItemIdSnakValueList( $items, Role::OBJECT );
84 
+		foreach ($items as $item) {
85 
+			if ($item->matchesSnak($snak)) {
86 
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
87 
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
88 
+					->withItemIdSnakValueList($items, Role::OBJECT);
89 89 
 				$status = CheckResult::STATUS_VIOLATION;
90 90 
 				break;
91 91 
 			}
92 92 
 		}
93 93
94 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94 
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95 
 	}
96 96
97 
-	public function checkConstraintParameters( Constraint $constraint ) {
97 
+	public function checkConstraintParameters(Constraint $constraint) {
98 98 
 		$constraintParameters = $constraint->getConstraintParameters();
99 99 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100 
 		$exceptions = [];
 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
 				$constraintTypeItemId,
105 105 
 				true
106 106 
 			);
107 
-		} catch ( ConstraintParameterException $e ) {
107 
+		} catch (ConstraintParameterException $e) {
108 108 
 			$exceptions[] = $e;
109 109 
 		}
110 110 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ItemChecker.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -78,9 +78,9 @@  discard block
 
 block discarded – undo
78 78 
 	 * @throws ConstraintParameterException
79 79 
 	 * @return CheckResult
80 80 
 	 */
81 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
82 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
83 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
81 
+	public function checkConstraint(Context $context, Constraint $constraint) {
82 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
83 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
84 84 
 		}
85 85
86 86 
 		$parameters = [];
 
@@ -91,7 +91,7 @@  discard block
 
 block discarded – undo
91 91 
 			$constraintParameters,
92 92 
 			$constraintTypeItemId
93 93 
 		);
94 
-		$parameters['property'] = [ $propertyId ];
94 
+		$parameters['property'] = [$propertyId];
95 95
96 96 
 		$items = $this->constraintParameterParser->parseItemsParameter(
97 97 
 			$constraintParameters,
 
@@ -105,7 +105,7 @@  discard block
 
 block discarded – undo
105 105 
 		 *   a) a property only
106 106 
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
107 107 
 		 */
108 
-		if ( $items === [] ) {
108 
+		if ($items === []) {
109 109 
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
110 110 
 				$context->getEntity()->getStatements(),
111 111 
 				$propertyId
 
@@ -118,21 +118,21 @@  discard block
 
 block discarded – undo
118 118 
 			);
119 119 
 		}
120 120
121 
-		if ( $requiredStatement !== null ) {
121 
+		if ($requiredStatement !== null) {
122 122 
 			$status = CheckResult::STATUS_COMPLIANCE;
123 123 
 			$message = null;
124 124 
 		} else {
125 125 
 			$status = CheckResult::STATUS_VIOLATION;
126 
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
127 
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
128 
-				->withEntityId( $propertyId, Role::PREDICATE )
129 
-				->withItemIdSnakValueList( $items, Role::OBJECT );
126 
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
127 
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
128 
+				->withEntityId($propertyId, Role::PREDICATE)
129 
+				->withItemIdSnakValueList($items, Role::OBJECT);
130 130 
 		}
131 131
132 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
132 
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
133 133 
 	}
134 134
135 
-	public function checkConstraintParameters( Constraint $constraint ) {
135 
+	public function checkConstraintParameters(Constraint $constraint) {
136 136 
 		$constraintParameters = $constraint->getConstraintParameters();
137 137 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
138 138 
 		$exceptions = [];
 
@@ -141,7 +141,7 @@  discard block
 
 block discarded – undo
141 141 
 				$constraintParameters,
142 142 
 				$constraintTypeItemId
143 143 
 			);
144 
-		} catch ( ConstraintParameterException $e ) {
144 
+		} catch (ConstraintParameterException $e) {
145 145 
 			$exceptions[] = $e;
146 146 
 		}
147 147 
 		try {
 
@@ -150,7 +150,7 @@  discard block
 
 block discarded – undo
150 150 
 				$constraintTypeItemId,
151 151 
 				false
152 152 
 			);
153 
-		} catch ( ConstraintParameterException $e ) {
153 
+		} catch (ConstraintParameterException $e) {
154 154 
 			$exceptions[] = $e;
155 155 
 		}
156 156 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch 
@@ -62,9 +62,9 @@  discard block
 
 block discarded – undo
62 62 
 	 * @throws ConstraintParameterException
63 63 
 	 * @return CheckResult
64 64 
 	 */
65 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
66 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
67 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
65 
+	public function checkConstraint(Context $context, Constraint $constraint) {
66 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
67 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
68 68 
 		}
69 69
70 70 
 		$parameters = [];
 
@@ -81,33 +81,33 @@  discard block
 
 block discarded – undo
81 81 
 		$status = CheckResult::STATUS_COMPLIANCE;
82 82
83 83 
 		/** @var Snak $qualifier */
84 
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
84 
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
85 85 
 			$allowedQualifier = false;
86 
-			foreach ( $properties as $property ) {
87 
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
86 
+			foreach ($properties as $property) {
87 
+				if ($qualifier->getPropertyId()->equals($property)) {
88 88 
 					$allowedQualifier = true;
89 89 
 					break;
90 90 
 				}
91 91 
 			}
92 
-			if ( !$allowedQualifier ) {
93 
-				if ( empty( $properties ) || $properties === [ '' ] ) {
94 
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
95 
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
92 
+			if (!$allowedQualifier) {
93 
+				if (empty($properties) || $properties === ['']) {
94 
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
95 
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
96 96 
 				} else {
97 
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
98 
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
99 
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
100 
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
97 
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
98 
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
99 
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
100 
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
101 101 
 				}
102 102 
 				$status = CheckResult::STATUS_VIOLATION;
103 103 
 				break;
104 104 
 			}
105 105 
 		}
106 106
107 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
107 
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
108 108 
 	}
109 109
110 
-	public function checkConstraintParameters( Constraint $constraint ) {
110 
+	public function checkConstraintParameters(Constraint $constraint) {
111 111 
 		$constraintParameters = $constraint->getConstraintParameters();
112 112 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
113 113 
 		$exceptions = [];
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
 				$constraintParameters,
117 117 
 				$constraintTypeItemId
118 118 
 			);
119 
-		} catch ( ConstraintParameterException $e ) {
119 
+		} catch (ConstraintParameterException $e) {
120 120 
 			$exceptions[] = $e;
121 121 
 		}
122 122 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch 
@@ -62,9 +62,9 @@  discard block
 
 block discarded – undo
62 62 
 	 * @throws ConstraintParameterException
63 63 
 	 * @return CheckResult
64 64 
 	 */
65 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
66 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
67 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
65 
+	public function checkConstraint(Context $context, Constraint $constraint) {
66 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
67 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
68 68 
 		}
69 69
70 70 
 		$parameters = [];
 
@@ -75,26 +75,26 @@  discard block
 
 block discarded – undo
75 75 
 			$constraintParameters,
76 76 
 			$constraintTypeItemId
77 77 
 		);
78 
-		$parameters['property'] = [ $propertyId ];
78 
+		$parameters['property'] = [$propertyId];
79 79
80 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
81 
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
82 
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
80 
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
81 
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
82 
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
83 83 
 		$status = CheckResult::STATUS_VIOLATION;
84 84
85 85 
 		/** @var Snak $qualifier */
86 
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
87 
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
86 
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
87 
+			if ($propertyId->equals($qualifier->getPropertyId())) {
88 88 
 				$message = null;
89 89 
 				$status = CheckResult::STATUS_COMPLIANCE;
90 90 
 				break;
91 91 
 			}
92 92 
 		}
93 93
94 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94 
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95 
 	}
96 96
97 
-	public function checkConstraintParameters( Constraint $constraint ) {
97 
+	public function checkConstraintParameters(Constraint $constraint) {
98 98 
 		$constraintParameters = $constraint->getConstraintParameters();
99 99 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100 
 		$exceptions = [];
 
@@ -103,7 +103,7 @@  discard block
 
 block discarded – undo
103 103 
 				$constraintParameters,
104 104 
 				$constraintTypeItemId
105 105 
 			);
106 
-		} catch ( ConstraintParameterException $e ) {
106 
+		} catch (ConstraintParameterException $e) {
107 107 
 			$exceptions[] = $e;
108 108 
 		}
109 109 
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/OneOfChecker.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,9 @@  discard block
 
 block discarded – undo
60 60 
 	 * @throws ConstraintParameterException
61 61 
 	 * @return CheckResult
62 62 
 	 */
63 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
64 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
65 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
63 
+	public function checkConstraint(Context $context, Constraint $constraint) {
64 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
65 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
66 66 
 		}
67 67
68 68 
 		$parameters = [];
 
@@ -78,23 +78,23 @@  discard block
 
 block discarded – undo
78 78
79 79 
 		$snak = $context->getSnak();
80 80
81 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) )
82 
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
83 
-			->withItemIdSnakValueList( $items, Role::OBJECT );
81 
+		$message = (new ViolationMessage('wbqc-violation-message-one-of'))
82 
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
83 
+			->withItemIdSnakValueList($items, Role::OBJECT);
84 84 
 		$status = CheckResult::STATUS_VIOLATION;
85 85
86 
-		foreach ( $items as $item ) {
87 
-			if ( $item->matchesSnak( $snak ) ) {
86 
+		foreach ($items as $item) {
87 
+			if ($item->matchesSnak($snak)) {
88 88 
 				$message = null;
89 89 
 				$status = CheckResult::STATUS_COMPLIANCE;
90 90 
 				break;
91 91 
 			}
92 92 
 		}
93 93
94 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94 
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95 
 	}
96 96
97 
-	public function checkConstraintParameters( Constraint $constraint ) {
97 
+	public function checkConstraintParameters(Constraint $constraint) {
98 98 
 		$constraintParameters = $constraint->getConstraintParameters();
99 99 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100 
 		$exceptions = [];
 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
 				$constraintTypeItemId,
105 105 
 				true
106 106 
 			);
107 
-		} catch ( ConstraintParameterException $e ) {
107 
+		} catch (ConstraintParameterException $e) {
108 108 
 			$exceptions[] = $e;
109 109 
 		}
110 110 
 		return $exceptions;
Please login to merge, or discard this patch.
src/Html/HtmlTableCellBuilder.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -38,9 +38,9 @@  discard block
 
 block discarded – undo
38 38 
 	 *
39 39 
 	 * @throws InvalidArgumentException
40 40 
 	 */
41 
-	public function __construct( $content, array $attributes = [], $isRawContent = false ) {
42 
-		Assert::parameterType( 'string', $content, '$content' );
43 
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
41 
+	public function __construct($content, array $attributes = [], $isRawContent = false) {
42 
+		Assert::parameterType('string', $content, '$content');
43 
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
44 44
45 45 
 		$this->content = $content;
46 46 
 		$this->attributes = $attributes;
 
@@ -66,10 +66,10 @@  discard block
 
 block discarded – undo
66 66 
 	 * @suppress SecurityCheck-DoubleEscaped
67 67 
 	 */
68 68 
 	public function toHtml() {
69 
-		if ( $this->isRawContent ) {
70 
-			return Html::rawElement( 'td', $this->getAttributes(), $this->content );
69 
+		if ($this->isRawContent) {
70 
+			return Html::rawElement('td', $this->getAttributes(), $this->content);
71 71 
 		} else {
72 
-			return Html::element( 'td', $this->getAttributes(), $this->content );
72 
+			return Html::element('td', $this->getAttributes(), $this->content);
73 73 
 		}
74 74 
 	}
75 75
Please login to merge, or discard this patch.
src/Html/HtmlTableHeaderBuilder.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -41,10 +41,10 @@  discard block
 
 block discarded – undo
41 41 
 	 *
42 42 
 	 * @throws InvalidArgumentException
43 43 
 	 */
44 
-	public function __construct( $content, $isSortable = false, $isRawContent = false ) {
45 
-		Assert::parameterType( 'string', $content, '$content' );
46 
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
47 
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
44 
+	public function __construct($content, $isSortable = false, $isRawContent = false) {
45 
+		Assert::parameterType('string', $content, '$content');
46 
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
47 
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
48 48
49 49 
 		$this->content = $content;
50 50 
 		$this->isSortable = $isSortable;
 
@@ -71,20 +71,20 @@  discard block
 
 block discarded – undo
71 71 
 	 * @return string HTML
72 72 
 	 */
73 73 
 	public function toHtml() {
74 
-		$attributes = [ 'role' => 'columnheader button' ];
74 
+		$attributes = ['role' => 'columnheader button'];
75 75
76 
-		if ( !$this->isSortable ) {
76 
+		if (!$this->isSortable) {
77 77 
 			$attributes['class'] = 'unsortable';
78 78 
 		}
79 79
80 
-		if ( !$this->isRawContent ) {
80 
+		if (!$this->isRawContent) {
81 81 
 			// @phan-suppress-next-line SecurityCheck-DoubleEscaped
82 
-			$content = htmlspecialchars( $this->content );
82 
+			$content = htmlspecialchars($this->content);
83 83 
 		} else {
84 84 
 			$content = $this->content;
85 85 
 		}
86 86
87 
-		return Html::rawElement( 'th', $attributes, $content );
87 
+		return Html::rawElement('th', $attributes, $content);
88 88 
 	}
89 89
90 90 
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SymmetricChecker.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch 
@@ -74,9 +74,9 @@  discard block
 
 block discarded – undo
74 74 
 	 *
75 75 
 	 * @return CheckResult
76 76 
 	 */
77 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
78 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
79 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
77 
+	public function checkConstraint(Context $context, Constraint $constraint) {
78 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
79 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
80 80 
 		}
81 81
82 82 
 		$parameters = [];
 
@@ -84,9 +84,9 @@  discard block
 
 block discarded – undo
84 84 
 		$snak = $context->getSnak();
85 85 
 		$propertyId = $context->getSnak()->getPropertyId();
86 86
87 
-		if ( !$snak instanceof PropertyValueSnak ) {
87 
+		if (!$snak instanceof PropertyValueSnak) {
88 88 
 			// nothing to check
89 
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
89 
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
90 90 
 		}
91 91
92 92 
 		$dataValue = $snak->getDataValue();
 
@@ -95,18 +95,18 @@  discard block
 
 block discarded – undo
95 95 
 		 * error handling:
96 96 
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
97 97 
 		 */
98 
-		if ( !$dataValue instanceof EntityIdValue ) {
99 
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
100 
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
101 
-				->withDataValueType( 'wikibase-entityid' );
102 
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
98 
+		if (!$dataValue instanceof EntityIdValue) {
99 
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
100 
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
101 
+				->withDataValueType('wikibase-entityid');
102 
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
103 103 
 		}
104 104
105 105 
 		$targetEntityId = $dataValue->getEntityId();
106 
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
107 
-		if ( !$targetEntity instanceof StatementListProvider ) {
108 
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
109 
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
106 
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
107 
+		if (!$targetEntity instanceof StatementListProvider) {
108 
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
109 
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
110 110 
 		}
111 111
112 112 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
 
@@ -114,23 +114,23 @@  discard block
 
 block discarded – undo
114 114 
 			$propertyId,
115 115 
 			$context->getEntity()->getId()
116 116 
 		);
117 
-		if ( $symmetricStatement !== null ) {
117 
+		if ($symmetricStatement !== null) {
118 118 
 			$message = null;
119 119 
 			$status = CheckResult::STATUS_COMPLIANCE;
120 120 
 		} else {
121 
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
122 
-				->withEntityId( $targetEntityId, Role::SUBJECT )
123 
-				->withEntityId( $propertyId, Role::PREDICATE )
124 
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
121 
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
122 
+				->withEntityId($targetEntityId, Role::SUBJECT)
123 
+				->withEntityId($propertyId, Role::PREDICATE)
124 
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
125 125 
 			$status = CheckResult::STATUS_VIOLATION;
126 126 
 		}
127 127
128 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
129 
-			->withMetadata( Metadata::ofDependencyMetadata(
130 
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
128 
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
129 
+			->withMetadata(Metadata::ofDependencyMetadata(
130 
+				DependencyMetadata::ofEntityId($targetEntityId) ));
131 131 
 	}
132 132
133 
-	public function checkConstraintParameters( Constraint $constraint ) {
133 
+	public function checkConstraintParameters(Constraint $constraint) {
134 134 
 		// no parameters
135 135 
 		return [];
136 136 
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/InverseChecker.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch 
@@ -84,9 +84,9 @@  discard block
 
 block discarded – undo
84 84 
 	 * @throws ConstraintParameterException
85 85 
 	 * @return CheckResult
86 86 
 	 */
87 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
88 
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
89 
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
87 
+	public function checkConstraint(Context $context, Constraint $constraint) {
88 
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
89 
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
90 90 
 		}
91 91
92 92 
 		$parameters = [];
 
@@ -97,13 +97,13 @@  discard block
 
 block discarded – undo
97 97 
 			$constraintParameters,
98 98 
 			$constraintTypeItemId
99 99 
 		);
100 
-		$parameters['property'] = [ $propertyId ];
100 
+		$parameters['property'] = [$propertyId];
101 101
102 102 
 		$snak = $context->getSnak();
103 103
104 
-		if ( !$snak instanceof PropertyValueSnak ) {
104 
+		if (!$snak instanceof PropertyValueSnak) {
105 105 
 			// nothing to check
106 
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
106 
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
107 107 
 		}
108 108
109 109 
 		$dataValue = $snak->getDataValue();
 
@@ -112,18 +112,18 @@  discard block
 
 block discarded – undo
112 112 
 		 * error handling:
113 113 
 		 *   type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
114 114 
 		 */
115 
-		if ( !$dataValue instanceof EntityIdValue ) {
116 
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
117 
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
118 
-				->withDataValueType( 'wikibase-entityid' );
119 
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
115 
+		if (!$dataValue instanceof EntityIdValue) {
116 
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
117 
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
118 
+				->withDataValueType('wikibase-entityid');
119 
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
120 120 
 		}
121 121
122 122 
 		$targetEntityId = $dataValue->getEntityId();
123 
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
124 
-		if ( !$targetEntity instanceof StatementListProvider ) {
125 
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
126 
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
123 
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
124 
+		if (!$targetEntity instanceof StatementListProvider) {
125 
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
126 
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
127 127 
 		}
128 128
129 129 
 		$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
 
@@ -131,23 +131,23 @@  discard block
 
 block discarded – undo
131 131 
 			$propertyId,
132 132 
 			$context->getEntity()->getId()
133 133 
 		);
134 
-		if ( $inverseStatement !== null ) {
134 
+		if ($inverseStatement !== null) {
135 135 
 			$message = null;
136 136 
 			$status = CheckResult::STATUS_COMPLIANCE;
137 137 
 		} else {
138 
-			$message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
139 
-				->withEntityId( $targetEntityId, Role::SUBJECT )
140 
-				->withEntityId( $propertyId, Role::PREDICATE )
141 
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
138 
+			$message = (new ViolationMessage('wbqc-violation-message-inverse'))
139 
+				->withEntityId($targetEntityId, Role::SUBJECT)
140 
+				->withEntityId($propertyId, Role::PREDICATE)
141 
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
142 142 
 			$status = CheckResult::STATUS_VIOLATION;
143 143 
 		}
144 144
145 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
146 
-			->withMetadata( Metadata::ofDependencyMetadata(
147 
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
145 
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
146 
+			->withMetadata(Metadata::ofDependencyMetadata(
147 
+				DependencyMetadata::ofEntityId($targetEntityId) ));
148 148 
 	}
149 149
150 
-	public function checkConstraintParameters( Constraint $constraint ) {
150 
+	public function checkConstraintParameters(Constraint $constraint) {
151 151 
 		$constraintParameters = $constraint->getConstraintParameters();
152 152 
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
153 153 
 		$exceptions = [];
 
@@ -156,7 +156,7 @@  discard block
 
 block discarded – undo
156 156 
 				$constraintParameters,
157 157 
 				$constraintTypeItemId
158 158 
 			);
159 
-		} catch ( ConstraintParameterException $e ) {
159 
+		} catch (ConstraintParameterException $e) {
160 160 
 			$exceptions[] = $e;
161 161 
 		}
162 162 
 		return $exceptions;
Please login to merge, or discard this patch.