wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintSerializer.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
 	/**
 	 * @param bool $serializeConstraintParameters Whether to serialize constraint parameters or not.
 	 */
-	public function __construct( $serializeConstraintParameters = true ) {
+	public function __construct($serializeConstraintParameters = true) {
 		$this->serializeConstraintParameters = $serializeConstraintParameters;
 	}
 
@@ -24,13 +24,13 @@ 
 	 * @param Constraint $constraint
 	 * @return array
 	 */
-	public function serialize( Constraint $constraint ) {
+	public function serialize(Constraint $constraint) {
 		$serialization = [
 			'id' => $constraint->getConstraintId(),
 			'pid' => $constraint->getPropertyId()->getSerialization(),
 			'qid' => $constraint->getConstraintTypeItemId(),
 		];
-		if ( $this->serializeConstraintParameters ) {
+		if ($this->serializeConstraintParameters) {
 			$serialization['params'] = $constraint->getConstraintParameters();
 		}
 		return $serialization;

src/ConstraintDeserializer.php

Spacing +4 added lines, -5 removed lines

@@ -10,14 +10,13 @@
  */
 class ConstraintDeserializer {
 
-	public function deserialize( array $serialization ) {
+	public function deserialize(array $serialization) {
 		return new Constraint(
 			$serialization['id'],
-			new PropertyId( $serialization['pid'] ),
+			new PropertyId($serialization['pid']),
 			$serialization['qid'],
-			array_key_exists( 'params', $serialization ) ?
-				$serialization['params'] :
-				[]
+			array_key_exists('params', $serialization) ?
+				$serialization['params'] : []
 		);
 	}
 

src/ConstraintCheck/Cache/DependencyMetadata.php

Spacing +12 added lines, -12 removed lines

@@ -37,7 +37,7 @@ 
 	 * @param EntityId $entityId An entity ID from which the value was derived.
 	 * @return self Indication that a value was derived from the entity with the given ID.
 	 */
-	public static function ofEntityId( EntityId $entityId ) {
+	public static function ofEntityId(EntityId $entityId) {
 		$ret = new self;
 		$ret->entityIds[] = $entityId;
 		return $ret;
@@ -49,7 +49,7 @@ 
 	 * @return self Indication that a value will only remain valid
 	 * as long as the given time value is in the future, not in the past.
 	 */
-	public static function ofFutureTime( TimeValue $timeValue ) {
+	public static function ofFutureTime(TimeValue $timeValue) {
 		$ret = new self;
 		$ret->timeValue = $timeValue;
 		return $ret;
@@ -59,17 +59,17 @@ 
 	 * @param self[] $metadatas
 	 * @return self
 	 */
-	public static function merge( array $metadatas ) {
-		Assert::parameterElementType( self::class, $metadatas, '$metadatas' );
+	public static function merge(array $metadatas) {
+		Assert::parameterElementType(self::class, $metadatas, '$metadatas');
 		$ret = new self;
 		$entityIds = [];
-		foreach ( $metadatas as $metadata ) {
-			foreach ( $metadata->entityIds as $entityId ) {
+		foreach ($metadatas as $metadata) {
+			foreach ($metadata->entityIds as $entityId) {
 				$entityIds[$entityId->getSerialization()] = $entityId;
 			}
-			$ret->timeValue = self::minTimeValue( $ret->timeValue, $metadata->timeValue );
+			$ret->timeValue = self::minTimeValue($ret->timeValue, $metadata->timeValue);
 		}
-		$ret->entityIds = array_values( $entityIds );
+		$ret->entityIds = array_values($entityIds);
 		return $ret;
 	}
 
@@ -78,14 +78,14 @@ 
 	 * @param TimeValue|null $t2
 	 * @return TimeValue|null
 	 */
-	private static function minTimeValue( TimeValue $t1 = null, TimeValue $t2 = null ) {
-		if ( $t1 === null ) {
+	private static function minTimeValue(TimeValue $t1 = null, TimeValue $t2 = null) {
+		if ($t1 === null) {
 			return $t2;
 		}
-		if ( $t2 === null ) {
+		if ($t2 === null) {
 			return $t1;
 		}
-		return ( new TimeValueComparer() )->getMinimum( $t1, $t2 );
+		return (new TimeValueComparer())->getMinimum($t1, $t2);
 	}
 
 	/**

src/ConstraintCheck/Context/ContextCursor.php

Spacing +1 added lines, -1 removed lines

@@ -86,6 +86,6 @@
 	 * @param array|null $result
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container );
+	public function storeCheckResultInArray(array $result = null, array &$container);
 
 }

src/ConstraintCheck/Context/ReferenceContextCursor.php

Spacing +12 added lines, -12 removed lines

@@ -92,43 +92,43 @@
 		return $this->referenceHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
-		$statementArray = &$this->getStatementArray( $container );
+	protected function &getMainArray(array &$container) {
+		$statementArray = &$this->getStatementArray($container);
 
-		if ( !array_key_exists( 'references', $statementArray ) ) {
+		if (!array_key_exists('references', $statementArray)) {
 			$statementArray['references'] = [];
 		}
 		$referencesArray = &$statementArray['references'];
 
 		$referenceHash = $this->getReferenceHash();
-		foreach ( $referencesArray as &$potentialReferenceArray ) {
-			if ( $potentialReferenceArray['hash'] === $referenceHash ) {
+		foreach ($referencesArray as &$potentialReferenceArray) {
+			if ($potentialReferenceArray['hash'] === $referenceHash) {
 				$referenceArray = &$potentialReferenceArray;
 				break;
 			}
 		}
-		if ( !isset( $referenceArray ) ) {
-			$referenceArray = [ 'hash' => $referenceHash, 'snaks' => [] ];
+		if (!isset($referenceArray)) {
+			$referenceArray = ['hash' => $referenceHash, 'snaks' => []];
 			$referencesArray[] = &$referenceArray;
 		}
 
 		$snaksArray = &$referenceArray['snaks'];
 
 		$snakPropertyId = $this->getSnakPropertyId();
-		if ( !array_key_exists( $snakPropertyId, $snaksArray ) ) {
+		if (!array_key_exists($snakPropertyId, $snaksArray)) {
 			$snaksArray[$snakPropertyId] = [];
 		}
 		$propertyArray = &$snaksArray[$snakPropertyId];
 
 		$snakHash = $this->getSnakHash();
-		foreach ( $propertyArray as &$potentialSnakArray ) {
-			if ( $potentialSnakArray['hash'] === $snakHash ) {
+		foreach ($propertyArray as &$potentialSnakArray) {
+			if ($potentialSnakArray['hash'] === $snakHash) {
 				$snakArray = &$potentialSnakArray;
 				break;
 			}
 		}
-		if ( !isset( $snakArray ) ) {
-			$snakArray = [ 'hash' => $snakHash ];
+		if (!isset($snakArray)) {
+			$snakArray = ['hash' => $snakHash];
 			$propertyArray[] = &$snakArray;
 		}
 

src/ConstraintCheck/Context/QualifierContextCursor.php

Spacing +8 added lines, -8 removed lines

@@ -80,29 +80,29 @@
 		return $this->snakHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
-		$statementArray = &$this->getStatementArray( $container );
+	protected function &getMainArray(array &$container) {
+		$statementArray = &$this->getStatementArray($container);
 
-		if ( !array_key_exists( 'qualifiers', $statementArray ) ) {
+		if (!array_key_exists('qualifiers', $statementArray)) {
 			$statementArray['qualifiers'] = [];
 		}
 		$qualifiersArray = &$statementArray['qualifiers'];
 
 		$snakPropertyId = $this->getSnakPropertyId();
-		if ( !array_key_exists( $snakPropertyId, $qualifiersArray ) ) {
+		if (!array_key_exists($snakPropertyId, $qualifiersArray)) {
 			$qualifiersArray[$snakPropertyId] = [];
 		}
 		$propertyArray = &$qualifiersArray[$snakPropertyId];
 
 		$snakHash = $this->getSnakHash();
-		foreach ( $propertyArray as &$potentialQualifierArray ) {
-			if ( $potentialQualifierArray['hash'] === $snakHash ) {
+		foreach ($propertyArray as &$potentialQualifierArray) {
+			if ($potentialQualifierArray['hash'] === $snakHash) {
 				$qualifierArray = &$potentialQualifierArray;
 				break;
 			}
 		}
-		if ( !isset( $qualifierArray ) ) {
-			$qualifierArray = [ 'hash' => $snakHash ];
+		if (!isset($qualifierArray)) {
+			$qualifierArray = ['hash' => $snakHash];
 			$propertyArray[] = &$qualifierArray;
 		}
 

src/ConstraintCheck/Context/MainSnakContextCursor.php

Spacing +4 added lines, -4 removed lines

@@ -72,12 +72,12 @@
 		return $this->snakHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
-		$statementArray = &$this->getStatementArray( $container );
+	protected function &getMainArray(array &$container) {
+		$statementArray = &$this->getStatementArray($container);
 
-		if ( !array_key_exists( 'mainsnak', $statementArray ) ) {
+		if (!array_key_exists('mainsnak', $statementArray)) {
 			$snakHash = $this->getSnakHash();
-			$statementArray['mainsnak'] = [ 'hash' => $snakHash ];
+			$statementArray['mainsnak'] = ['hash' => $snakHash];
 		}
 		$mainsnakArray = &$statementArray['mainsnak'];
 

src/ConstraintCheck/Context/ContextCursorDeserializer.php

Spacing +3 added lines, -3 removed lines

@@ -11,8 +11,8 @@ 
  */
 class ContextCursorDeserializer {
 
-	public function deserialize( array $serialization ) {
-		switch ( $serialization['t'] ) {
+	public function deserialize(array $serialization) {
+		switch ($serialization['t']) {
 			case Context::TYPE_STATEMENT:
 				return new MainSnakContextCursor(
 					$serialization['i'],
@@ -39,7 +39,7 @@ 
 				);
 			default:
 				throw new InvalidArgumentException(
-					'Unknown serialization type ' . $serialization['t']
+					'Unknown serialization type '.$serialization['t']
 				);
 		}
 	}

src/ConstraintCheck/Checker/RangeChecker.php

Spacing +38 added lines, -38 removed lines

@@ -92,9 +92,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -102,28 +102,28 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
 
-		list( $min, $max ) = $this->parseRangeParameter(
+		list($min, $max) = $this->parseRangeParameter(
 			$constraintParameters,
 			$constraint->getConstraintTypeItemId(),
 			$dataValue->getType()
 		);
 		$parameterKey = $dataValue->getType() === 'quantity' ? 'quantity' : 'date';
-		if ( $min !== null ) {
-			$parameters['minimum_' . $parameterKey] = [ $min ];
+		if ($min !== null) {
+			$parameters['minimum_'.$parameterKey] = [$min];
 		}
-		if ( $max !== null ) {
-			$parameters['maximum_' . $parameterKey] = [ $max ];
+		if ($max !== null) {
+			$parameters['maximum_'.$parameterKey] = [$max];
 		}
 
-		if ( $this->rangeCheckerHelper->getComparison( $min, $dataValue ) > 0 ||
-			 $this->rangeCheckerHelper->getComparison( $dataValue, $max ) > 0
+		if ($this->rangeCheckerHelper->getComparison($min, $dataValue) > 0 ||
+			 $this->rangeCheckerHelper->getComparison($dataValue, $max) > 0
 		) {
 			$message = $this->getViolationMessage(
 				$context->getSnak()->getPropertyId(),
@@ -139,16 +139,16 @@ 
 
 		if (
 			$dataValue instanceof  TimeValue &&
-			( $min instanceof NowValue || $max instanceof NowValue ) &&
-			$this->rangeCheckerHelper->isFutureTime( $dataValue )
+			($min instanceof NowValue || $max instanceof NowValue) &&
+			$this->rangeCheckerHelper->isFutureTime($dataValue)
 		) {
-			$dependencyMetadata = DependencyMetadata::ofFutureTime( $dataValue );
+			$dependencyMetadata = DependencyMetadata::ofFutureTime($dataValue);
 		} else {
 			$dependencyMetadata = DependencyMetadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata( $dependencyMetadata ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata($dependencyMetadata));
 	}
 
 	/**
@@ -159,8 +159,8 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
 	 */
-	private function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) {
-		switch ( $type ) {
+	private function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) {
+		switch ($type) {
 			case 'quantity':
 				return $this->constraintParameterParser->parseQuantityRangeParameter(
 					$constraintParameters,
@@ -174,10 +174,10 @@ 
 		}
 
 		throw new ConstraintParameterException(
-			( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'quantity' )
-				->withDataValueType( 'time' )
+			(new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('quantity')
+				->withDataValueType('time')
 		);
 	}
 
@@ -189,7 +189,7 @@ 
 	 *
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( PropertyId $predicate, DataValue $value, $min, $max ) {
+	private function getViolationMessage(PropertyId $predicate, DataValue $value, $min, $max) {
 		// possible message keys:
 		// wbqc-violation-message-range-quantity-closed
 		// wbqc-violation-message-range-quantity-leftopen
@@ -202,39 +202,39 @@ 
 		// wbqc-violation-message-range-time-rightopen
 		// wbqc-violation-message-range-time-rightopen-leftnow
 		$messageKey = 'wbqc-violation-message-range';
-		$messageKey .= '-' . $value->getType();
+		$messageKey .= '-'.$value->getType();
 		// at least one of $min, $max is set, otherwise there could be no violation
-		$messageKey .= '-' . ( $min !== null ? ( $max !== null ? 'closed' : 'rightopen' ) : 'leftopen' );
-		if ( $min instanceof NowValue ) {
+		$messageKey .= '-'.($min !== null ? ($max !== null ? 'closed' : 'rightopen') : 'leftopen');
+		if ($min instanceof NowValue) {
 			$messageKey .= '-leftnow';
-		} elseif ( $max instanceof  NowValue ) {
+		} elseif ($max instanceof  NowValue) {
 			$messageKey .= '-rightnow';
 		}
-		$message = ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $predicate, Role::PREDICATE )
-			->withDataValue( $value, Role::OBJECT );
-		if ( $min !== null && !( $min instanceof NowValue ) ) {
-			$message = $message->withDataValue( $min, Role::OBJECT );
+		$message = (new ViolationMessage($messageKey))
+			->withEntityId($predicate, Role::PREDICATE)
+			->withDataValue($value, Role::OBJECT);
+		if ($min !== null && !($min instanceof NowValue)) {
+			$message = $message->withDataValue($min, Role::OBJECT);
 		}
-		if ( $max !== null && !( $max instanceof  NowValue ) ) {
-			$message = $message->withDataValue( $max, Role::OBJECT );
+		if ($max !== null && !($max instanceof  NowValue)) {
+			$message = $message->withDataValue($max, Role::OBJECT);
 		}
 		return $message;
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
 			// we don’t have a data value here, so get the type from the property instead
 			// (the distinction between data type and data value type is irrelevant for 'quantity' and 'time')
-			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty( $constraint->getPropertyId() );
+			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty($constraint->getPropertyId());
 			$this->parseRangeParameter(
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId(),
 				$type
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;