wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/QualifierContext.php

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -25,7 +25,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -33,16 +33,16 @@ 
 		return self::TYPE_QUALIFIER;
 	}
 
-	public function getSnakGroup( string $groupingMode, array $separators = [] ): array {
+	public function getSnakGroup(string $groupingMode, array $separators = []): array {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor(): ContextCursor {
 		return new QualifierContextCursor(
 			$this->entity->getId()->getSerialization(),
 			$this->statement->getPropertyId()->getSerialization(),
-			$this->getStatementGuid( $this->statement ),
+			$this->getStatementGuid($this->statement),
 			$this->snak->getHash(),
 			$this->snak->getPropertyId()->getSerialization()
 		);

src/ConstraintCheck/Checker/UniqueValueChecker.php

Spacing +18 added lines, -18 removed lines

@@ -76,20 +76,20 @@ 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 		$parameters = [];
 
-		if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
+		if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
 
 			$separators = $this->constraintParameterParser->parseSeparatorsParameter(
 				$constraint->getConstraintParameters()
 			);
 			$parameters['separator'] = $separators;
 
-			if ( $context->getType() === 'statement' ) {
+			if ($context->getType() === 'statement') {
 				$statement = $context->getSnakStatement();
 				'@phan-var Statement $statement';
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
@@ -98,9 +98,9 @@ 
 				);
 			} else {
 				$snak = $context->getSnak();
-				if ( !$snak instanceof PropertyValueSnak ) {
+				if (!$snak instanceof PropertyValueSnak) {
 					// nothing to check
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -113,32 +113,32 @@ 
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/Html/HtmlTableHeaderBuilder.php

Spacing +9 added lines, -9 removed lines

@@ -41,10 +41,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, $isSortable = false, $isRawContent = false ) {
-		Assert::parameterType( 'string', $content, '$content' );
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
+	public function __construct($content, $isSortable = false, $isRawContent = false) {
+		Assert::parameterType('string', $content, '$content');
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -71,19 +71,19 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
-		if ( !$this->isRawContent ) {
-			$content = htmlspecialchars( $this->content );
+		if (!$this->isRawContent) {
+			$content = htmlspecialchars($this->content);
 		} else {
 			$content = $this->content;
 		}
 
-		return Html::rawElement( 'th', $attributes, $content );
+		return Html::rawElement('th', $attributes, $content);
 	}
 
 }

src/ConstraintParameterRenderer.php

Spacing +28 added lines, -28 removed lines

@@ -71,20 +71,20 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatValue( $value ) {
-		if ( is_string( $value ) ) {
+	public function formatValue($value) {
+		if (is_string($value)) {
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
 			// strings
-			return htmlspecialchars( $value );
-		} elseif ( $value instanceof EntityId ) {
+			return htmlspecialchars($value);
+		} elseif ($value instanceof EntityId) {
 			// Cases like 'Conflicts with' 'property', to which we can link
-			return $this->formatEntityId( $value );
-		} elseif ( $value instanceof ItemIdSnakValue ) {
+			return $this->formatEntityId($value);
+		} elseif ($value instanceof ItemIdSnakValue) {
 			// Cases like EntityId but can also be somevalue or novalue
-			return $this->formatItemIdSnakValue( $value );
+			return $this->formatItemIdSnakValue($value);
 		} else {
 			// Cases where we format a DataValue
-			return $this->formatDataValue( $value );
+			return $this->formatDataValue($value);
 		}
 	}
 
@@ -95,19 +95,19 @@ 
 	 *
 	 * @return string|null HTML
 	 */
-	public function formatParameters( $parameters ) {
-		if ( $parameters === null || $parameters === [] ) {
+	public function formatParameters($parameters) {
+		if ($parameters === null || $parameters === []) {
 			return null;
 		}
 
 		$formattedParameters = [];
-		foreach ( $parameters as $parameterName => $parameterValue ) {
-			$formattedParameterValues = implode( ', ',
-				$this->limitArrayLength( array_map( [ $this, 'formatValue' ], $parameterValue ) ) );
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
+		foreach ($parameters as $parameterName => $parameterValue) {
+			$formattedParameterValues = implode(', ',
+				$this->limitArrayLength(array_map([$this, 'formatValue'], $parameterValue)));
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
 		}
 
-		return implode( '; ', $formattedParameters );
+		return implode('; ', $formattedParameters);
 	}
 
 	/**
@@ -117,10 +117,10 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function limitArrayLength( array $array ) {
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
-			array_push( $array, '...' );
+	private function limitArrayLength(array $array) {
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
+			array_push($array, '...');
 		}
 
 		return $array;
@@ -130,16 +130,16 @@ 
 	 * @param DataValue $value
 	 * @return string HTML
 	 */
-	public function formatDataValue( DataValue $value ) {
-		return $this->dataValueFormatter->format( $value );
+	public function formatDataValue(DataValue $value) {
+		return $this->dataValueFormatter->format($value);
 	}
 
 	/**
 	 * @param EntityId $entityId
 	 * @return string HTML
 	 */
-	public function formatEntityId( EntityId $entityId ) {
-		return $this->entityIdLabelFormatter->formatEntityId( $entityId );
+	public function formatEntityId(EntityId $entityId) {
+		return $this->entityIdLabelFormatter->formatEntityId($entityId);
 	}
 
 	/**
@@ -148,17 +148,17 @@ 
 	 * @param ItemIdSnakValue $value
 	 * @return string HTML
 	 */
-	public function formatItemIdSnakValue( ItemIdSnakValue $value ) {
-		switch ( true ) {
+	public function formatItemIdSnakValue(ItemIdSnakValue $value) {
+		switch (true) {
 			case $value->isValue():
-				return $this->formatEntityId( $value->getItemId() );
+				return $this->formatEntityId($value->getItemId());
 			case $value->isSomeValue():
 				return $this->messageLocalizer
-					->msg( 'wikibase-snakview-snaktypeselector-somevalue' )
+					->msg('wikibase-snakview-snaktypeselector-somevalue')
 					->escaped();
 			case $value->isNoValue():
 				return $this->messageLocalizer
-					->msg( 'wikibase-snakview-snaktypeselector-novalue' )
+					->msg('wikibase-snakview-snaktypeselector-novalue')
 					->escaped();
 		}
 	}

src/ConstraintCheck/Context/AbstractContext.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -21,7 +21,7 @@ 
 
 	protected Snak $snak;
 
-	public function __construct( StatementListProvidingEntity $entity, Snak $snak ) {
+	public function __construct(StatementListProvidingEntity $entity, Snak $snak) {
 		$this->entity = $entity;
 		$this->snak = $snak;
 	}
@@ -47,15 +47,15 @@ 
 	// unimplemented: getCursor
 
 	/** Helper function for {@link getCursor()} implementations. */
-	protected function getStatementGuid( Statement $statement ): string {
+	protected function getStatementGuid(Statement $statement): string {
 		$guid = $statement->getGuid();
-		if ( $guid === null ) {
-			if ( defined( 'MW_PHPUNIT_TEST' ) ) {
+		if ($guid === null) {
+			if (defined('MW_PHPUNIT_TEST')) {
 				// let unit tests get away with not specifying a statement GUID:
 				// much more convenient to fake it here than to add one to all tests
 				return 'Q0$DEADBEEF-DEAD-BEEF-DEAD-BEEFDEADBEEF';
 			} else {
-				throw new InvalidArgumentException( 'Statement for Context must have a GUID' );
+				throw new InvalidArgumentException('Statement for Context must have a GUID');
 			}
 		}
 		return $guid;

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +32 added lines, -32 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -21,8 +21,8 @@ 
 
 	private Statement $statement;
 
-	public function __construct( StatementListProvidingEntity $entity, Statement $statement ) {
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(StatementListProvidingEntity $entity, Statement $statement) {
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -39,21 +39,21 @@ 
 		return $this->statement;
 	}
 
-	public function getSnakGroup( string $groupingMode, array $separators = [] ): array {
+	public function getSnakGroup(string $groupingMode, array $separators = []): array {
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
-		switch ( $groupingMode ) {
+		switch ($groupingMode) {
 			case Context::GROUP_NON_DEPRECATED:
-				$statements = $statements->getByRank( [
+				$statements = $statements->getByRank([
 					Statement::RANK_NORMAL,
 					Statement::RANK_PREFERRED,
-				] );
+				]);
 				break;
 			case Context::GROUP_BEST_RANK:
-				$statements = $this->getBestStatementsPerPropertyId( $statements );
+				$statements = $this->getBestStatementsPerPropertyId($statements);
 				break;
 			default:
-				throw new LogicException( 'Unknown $groupingMode ' . $groupingMode );
+				throw new LogicException('Unknown $groupingMode '.$groupingMode);
 		}
 		return $this->getStatementsWithSameQualifiersForProperties(
 			$this->statement,
@@ -62,13 +62,13 @@ 
 		)->getMainSnaks();
 	}
 
-	private function getBestStatementsPerPropertyId( StatementList $statements ): StatementList {
+	private function getBestStatementsPerPropertyId(StatementList $statements): StatementList {
 		$allBestStatements = new StatementList();
-		foreach ( $statements->getPropertyIds() as $propertyId ) {
-			$bestStatements = $statements->getByPropertyId( $propertyId )
+		foreach ($statements->getPropertyIds() as $propertyId) {
+			$bestStatements = $statements->getByPropertyId($propertyId)
 				->getBestStatements();
-			foreach ( $bestStatements as $bestStatement ) {
-				$allBestStatements->addStatement( $bestStatement );
+			foreach ($bestStatements as $bestStatement) {
+				$allBestStatements->addStatement($bestStatement);
 			}
 		}
 		return $allBestStatements;
@@ -90,20 +90,20 @@ 
 		array $qualifierPropertyIds
 	): StatementList {
 		$similarStatements = new StatementList();
-		foreach ( $allStatements as $statement ) {
-			if ( $statement === $currentStatement ) {
+		foreach ($allStatements as $statement) {
+			if ($statement === $currentStatement) {
 				// if the statement has an “unknown value” qualifier,
 				// it might be considered different from itself,
 				// so add it explicitly to ensure it’s always included
-				$similarStatements->addStatement( $statement );
+				$similarStatements->addStatement($statement);
 				continue;
 			}
-			foreach ( $qualifierPropertyIds as $qualifierPropertyId ) {
-				if ( !$this->haveSameQualifiers( $currentStatement, $statement, $qualifierPropertyId ) ) {
+			foreach ($qualifierPropertyIds as $qualifierPropertyId) {
+				if (!$this->haveSameQualifiers($currentStatement, $statement, $qualifierPropertyId)) {
 					continue 2;
 				}
 			}
-			$similarStatements->addStatement( $statement );
+			$similarStatements->addStatement($statement);
 		}
 		return $similarStatements;
 	}
@@ -112,19 +112,19 @@ 
 	 * Tests whether two statements have the same qualifiers with a certain property ID.
 	 * “unknown value” qualifiers are considered different from each other.
 	 */
-	private function haveSameQualifiers( Statement $s1, Statement $s2, PropertyId $propertyId ): bool {
-		$q1 = $this->getSnaksWithPropertyId( $s1->getQualifiers(), $propertyId );
-		$q2 = $this->getSnaksWithPropertyId( $s2->getQualifiers(), $propertyId );
+	private function haveSameQualifiers(Statement $s1, Statement $s2, PropertyId $propertyId): bool {
+		$q1 = $this->getSnaksWithPropertyId($s1->getQualifiers(), $propertyId);
+		$q2 = $this->getSnaksWithPropertyId($s2->getQualifiers(), $propertyId);
 
-		if ( $q1->count() !== $q2->count() ) {
+		if ($q1->count() !== $q2->count()) {
 			return false;
 		}
 
-		foreach ( $q1 as $qualifier ) {
-			switch ( $qualifier->getType() ) {
+		foreach ($q1 as $qualifier) {
+			switch ($qualifier->getType()) {
 				case 'value':
 				case 'novalue':
-					if ( !$q2->hasSnak( $qualifier ) ) {
+					if (!$q2->hasSnak($qualifier)) {
 						return false;
 					}
 					break;
@@ -142,12 +142,12 @@ 
 	/**
 	 * Returns the snaks of the given snak list with the specified property ID.
 	 */
-	private function getSnaksWithPropertyId( SnakList $allSnaks, PropertyId $propertyId ): SnakList {
+	private function getSnaksWithPropertyId(SnakList $allSnaks, PropertyId $propertyId): SnakList {
 		$snaks = new SnakList();
 		/** @var Snak $snak */
-		foreach ( $allSnaks as $snak ) {
-			if ( $snak->getPropertyId()->equals( $propertyId ) ) {
-				$snaks->addSnak( $snak );
+		foreach ($allSnaks as $snak) {
+			if ($snak->getPropertyId()->equals($propertyId)) {
+				$snaks->addSnak($snak);
 			}
 		}
 		return $snaks;
@@ -157,7 +157,7 @@ 
 		return new MainSnakContextCursor(
 			$this->entity->getId()->getSerialization(),
 			$this->statement->getPropertyId()->getSerialization(),
-			$this->getStatementGuid( $this->statement ),
+			$this->getStatementGuid($this->statement),
 			$this->statement->getMainSnak()->getHash()
 		);
 	}

src/ConstraintsServices.php

Spacing +26 added lines, -26 removed lines

@@ -40,93 +40,93 @@
 	public const EXPIRY_LOCK = 'WBQC_ExpiryLock';
 	public const VIOLATION_MESSAGE_RENDERER_FACTORY = 'WBQC_ViolationMessageRendererFactory';
 
-	private static function getService( ?MediaWikiServices $services, $name ) {
-		if ( $services === null ) {
+	private static function getService(?MediaWikiServices $services, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
-	public static function getLoggingHelper( MediaWikiServices $services = null ): LoggingHelper {
-		return self::getService( $services, self::LOGGING_HELPER );
+	public static function getLoggingHelper(MediaWikiServices $services = null): LoggingHelper {
+		return self::getService($services, self::LOGGING_HELPER);
 	}
 
 	public static function getConstraintStore(
 		MediaWikiServices $services = null
 	): ConstraintStore {
-		return self::getService( $services, self::CONSTRAINT_STORE );
+		return self::getService($services, self::CONSTRAINT_STORE);
 	}
 
-	public static function getConstraintLookup( MediaWikiServices $services = null ): ConstraintLookup {
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
+	public static function getConstraintLookup(MediaWikiServices $services = null): ConstraintLookup {
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
 	}
 
 	public static function getCheckResultSerializer(
 		MediaWikiServices $services = null
 	): CheckResultSerializer {
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
 	}
 
 	public static function getCheckResultDeserializer(
 		MediaWikiServices $services = null
 	): CheckResultDeserializer {
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
 	}
 
 	public static function getViolationMessageSerializer(
 		MediaWikiServices $services = null
 	): ViolationMessageSerializer {
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
 	}
 
 	public static function getViolationMessageDeserializer(
 		MediaWikiServices $services = null
 	): ViolationMessageDeserializer {
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
 	}
 
 	public static function getConstraintParameterParser(
 		MediaWikiServices $services = null
 	): ConstraintParameterParser {
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
 	}
 
 	public static function getConnectionCheckerHelper(
 		MediaWikiServices $services = null
 	): ConnectionCheckerHelper {
-		return self::getService( $services, self::CONNECTION_CHECKER_HELPER );
+		return self::getService($services, self::CONNECTION_CHECKER_HELPER);
 	}
 
-	public static function getRangeCheckerHelper( MediaWikiServices $services = null ): RangeCheckerHelper {
-		return self::getService( $services, self::RANGE_CHECKER_HELPER );
+	public static function getRangeCheckerHelper(MediaWikiServices $services = null): RangeCheckerHelper {
+		return self::getService($services, self::RANGE_CHECKER_HELPER);
 	}
 
-	public static function getSparqlHelper( MediaWikiServices $services = null ): SparqlHelper {
-		return self::getService( $services, self::SPARQL_HELPER );
+	public static function getSparqlHelper(MediaWikiServices $services = null): SparqlHelper {
+		return self::getService($services, self::SPARQL_HELPER);
 	}
 
-	public static function getTypeCheckerHelper( MediaWikiServices $services = null ): TypeCheckerHelper {
-		return self::getService( $services, self::TYPE_CHECKER_HELPER );
+	public static function getTypeCheckerHelper(MediaWikiServices $services = null): TypeCheckerHelper {
+		return self::getService($services, self::TYPE_CHECKER_HELPER);
 	}
 
 	public static function getDelegatingConstraintChecker(
 		MediaWikiServices $services = null
 	): DelegatingConstraintChecker {
-		return self::getService( $services, self::DELEGATING_CONSTRAINT_CHECKER );
+		return self::getService($services, self::DELEGATING_CONSTRAINT_CHECKER);
 	}
 
-	public static function getResultsSource( MediaWikiServices $services = null ): ResultsSource {
-		return self::getService( $services, self::RESULTS_SOURCE );
+	public static function getResultsSource(MediaWikiServices $services = null): ResultsSource {
+		return self::getService($services, self::RESULTS_SOURCE);
 	}
 
-	public static function getExpiryLock( MediaWikiServices $services = null ): ExpiryLock {
-		return self::getService( $services, self::EXPIRY_LOCK );
+	public static function getExpiryLock(MediaWikiServices $services = null): ExpiryLock {
+		return self::getService($services, self::EXPIRY_LOCK);
 	}
 
 	public static function getViolationMessageRendererFactory(
 		MediaWikiServices $services = null
 	): ViolationMessageRendererFactory {
-		return self::getService( $services, self::VIOLATION_MESSAGE_RENDERER_FACTORY );
+		return self::getService($services, self::VIOLATION_MESSAGE_RENDERER_FACTORY);
 	}
 
 }

src/ConstraintCheck/Message/ViolationMessageRenderer.php

Spacing +87 added lines, -87 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -62,17 +62,17 @@ 
 		$this->maxListLength = $maxListLength;
 	}
 
-	public function render( ViolationMessage $violationMessage ): string {
+	public function render(ViolationMessage $violationMessage): string {
 		$messageKey = $violationMessage->getMessageKey();
-		$paramsLists = [ [] ];
-		foreach ( $violationMessage->getArguments() as $argument ) {
-			$params = $this->renderArgument( $argument );
+		$paramsLists = [[]];
+		foreach ($violationMessage->getArguments() as $argument) {
+			$params = $this->renderArgument($argument);
 			$paramsLists[] = $params;
 		}
-		$allParams = call_user_func_array( 'array_merge', $paramsLists );
+		$allParams = call_user_func_array('array_merge', $paramsLists);
 		return $this->messageLocalizer
-			->msg( $messageKey )
-			->params( $allParams )
+			->msg($messageKey)
+			->params($allParams)
 			->escaped();
 	}
 
@@ -81,13 +81,13 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return string HTML
 	 */
-	protected function addRole( string $value, ?string $role ): string {
-		if ( $role === null ) {
+	protected function addRole(string $value, ?string $role): string {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
-			$value .
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
+			$value.
 			'</span>';
 	}
 
@@ -95,15 +95,15 @@ 
 	 * @param string $key message key
 	 * @return string HTML
 	 */
-	protected function msgEscaped( string $key ): string {
-		return $this->messageLocalizer->msg( $key )->escaped();
+	protected function msgEscaped(string $key): string {
+		return $this->messageLocalizer->msg($key)->escaped();
 	}
 
 	/**
 	 * @param array $argument
 	 * @return array[] params (for Message::params)
 	 */
-	protected function renderArgument( array $argument ): array {
+	protected function renderArgument(array $argument): array {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'renderEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'renderEntityIdList',
@@ -124,12 +124,12 @@ 
 		$value = $argument['value'];
 		$role = $argument['role'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$params = $this->$method( $value, $role );
+			$params = $this->$method($value, $role);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
@@ -143,36 +143,36 @@ 
 	 * and return a single-element array with a raw message param (i. e. [ Message::rawParam( … ) ])
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderList( array $list, ?string $role, callable $render ): array {
-		if ( $list === [] ) {
+	private function renderList(array $list, ?string $role, callable $render): array {
+		if ($list === []) {
 			return [
-				Message::numParam( 0 ),
-				Message::rawParam( '<ul></ul>' ),
+				Message::numParam(0),
+				Message::rawParam('<ul></ul>'),
 			];
 		}
 
-		if ( count( $list ) > $this->maxListLength ) {
-			$list = array_slice( $list, 0, $this->maxListLength );
+		if (count($list) > $this->maxListLength) {
+			$list = array_slice($list, 0, $this->maxListLength);
 			$truncated = true;
 		}
 
 		$renderedParamsLists = array_map(
 			$render,
 			$list,
-			array_fill( 0, count( $list ), $role )
+			array_fill(0, count($list), $role)
 		);
-		$renderedParams = array_column( $renderedParamsLists, 0 );
-		$renderedElements = array_column( $renderedParams, 'raw' );
-		if ( isset( $truncated ) ) {
-			$renderedElements[] = $this->msgEscaped( 'ellipsis' );
+		$renderedParams = array_column($renderedParamsLists, 0);
+		$renderedElements = array_column($renderedParams, 'raw');
+		if (isset($truncated)) {
+			$renderedElements[] = $this->msgEscaped('ellipsis');
 		}
 
 		return array_merge(
 			[
-				Message::numParam( count( $list ) ),
+				Message::numParam(count($list)),
 				Message::rawParam(
-					'<ul><li>' .
-					implode( '</li><li>', $renderedElements ) .
+					'<ul><li>'.
+					implode('</li><li>', $renderedElements).
 					'</li></ul>'
 				),
 			],
@@ -185,11 +185,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderEntityId( EntityId $entityId, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			$this->entityIdFormatter->formatEntityId( $entityId ),
+	private function renderEntityId(EntityId $entityId, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			$this->entityIdFormatter->formatEntityId($entityId),
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -197,8 +197,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderEntityIdList( array $entityIdList, ?string $role ): array {
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
+	private function renderEntityIdList(array $entityIdList, ?string $role): array {
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
 	}
 
 	/**
@@ -206,24 +206,24 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, ?string $role ): array {
-		switch ( true ) {
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, ?string $role): array {
+		switch (true) {
 			case $value->isValue():
-				return $this->renderEntityId( $value->getItemId(), $role );
+				return $this->renderEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return [ Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
-						$this->msgEscaped( 'wikibase-snakview-snaktypeselector-somevalue' ) .
+				return [Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
+						$this->msgEscaped('wikibase-snakview-snaktypeselector-somevalue').
 						'</span>',
 					$role
-				) ) ];
+				))];
 			case $value->isNoValue():
-				return [ Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
-					$this->msgEscaped( 'wikibase-snakview-snaktypeselector-novalue' ) .
+				return [Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
+					$this->msgEscaped('wikibase-snakview-snaktypeselector-novalue').
 						'</span>',
 					$role
-				) ) ];
+				))];
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
@@ -238,8 +238,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderItemIdSnakValueList( array $valueList, ?string $role ): array {
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
+	private function renderItemIdSnakValueList(array $valueList, ?string $role): array {
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
 	}
 
 	/**
@@ -247,11 +247,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderDataValue( DataValue $dataValue, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			$this->dataValueFormatter->format( $dataValue ),
+	private function renderDataValue(DataValue $dataValue, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			$this->dataValueFormatter->format($dataValue),
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -259,7 +259,7 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderDataValueType( string $dataValueType, ?string $role ): array {
+	private function renderDataValueType(string $dataValueType, ?string $role): array {
 		$messageKeys = [
 			'string' => 'datatypes-type-string',
 			'monolingualtext' => 'datatypes-type-monolingualtext',
@@ -268,15 +268,15 @@ 
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
 		];
 
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
-			return [ Message::rawParam( $this->addRole(
-				$this->msgEscaped( $messageKeys[$dataValueType] ),
+		if (array_key_exists($dataValueType, $messageKeys)) {
+			return [Message::rawParam($this->addRole(
+				$this->msgEscaped($messageKeys[$dataValueType]),
 				$role
-			) ) ];
+			))];
 		} else {
 			// @codeCoverageIgnoreStart
 			throw new LogicException(
-				'Unknown data value type ' . $dataValueType
+				'Unknown data value type '.$dataValueType
 			);
 			// @codeCoverageIgnoreEnd
 		}
@@ -287,11 +287,11 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderInlineCode( string $code, ?string $role ): array {
-		return [ Message::rawParam( $this->addRole(
-			'<code>' . htmlspecialchars( $code ) . '</code>',
+	private function renderInlineCode(string $code, ?string $role): array {
+		return [Message::rawParam($this->addRole(
+			'<code>'.htmlspecialchars($code).'</code>',
 			$role
-		) ) ];
+		))];
 	}
 
 	/**
@@ -299,8 +299,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderConstraintScope( string $scope, ?string $role ): array {
-		switch ( $scope ) {
+	private function renderConstraintScope(string $scope, ?string $role): array {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
 				$itemId = $this->config->get(
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -320,10 +320,10 @@ 
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
+		return $this->renderEntityId(new ItemId($itemId), $role);
 	}
 
 	/**
@@ -331,8 +331,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderConstraintScopeList( array $scopeList, ?string $role ): array {
-		return $this->renderList( $scopeList, $role, [ $this, 'renderConstraintScope' ] );
+	private function renderConstraintScopeList(array $scopeList, ?string $role): array {
+		return $this->renderList($scopeList, $role, [$this, 'renderConstraintScope']);
 	}
 
 	/**
@@ -340,25 +340,25 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
 	 */
-	private function renderPropertyScope( string $scope, ?string $role ): array {
-		switch ( $scope ) {
+	private function renderPropertyScope(string $scope, ?string $role): array {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsMainValueId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsMainValueId');
 				break;
 			case Context::TYPE_QUALIFIER:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsQualifiersId');
 				break;
 			case Context::TYPE_REFERENCE:
-				$itemId = $this->config->get( 'WBQualityConstraintsAsReferencesId' );
+				$itemId = $this->config->get('WBQualityConstraintsAsReferencesId');
 				break;
 			default:
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
+		return $this->renderEntityId(new ItemId($itemId), $role);
 	}
 
 	/**
@@ -366,8 +366,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderPropertyScopeList( array $scopeList, ?string $role ): array {
-		return $this->renderList( $scopeList, $role, [ $this, 'renderPropertyScope' ] );
+	private function renderPropertyScopeList(array $scopeList, ?string $role): array {
+		return $this->renderList($scopeList, $role, [$this, 'renderPropertyScope']);
 	}
 
 	/**
@@ -375,14 +375,14 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderLanguage( string $languageCode, ?string $role ): array {
+	private function renderLanguage(string $languageCode, ?string $role): array {
 		return [
 			// ::renderList (through ::renderLanguageList) requires 'raw' parameter
 			// so we effectively build Message::plaintextParam here
-			Message::rawParam( htmlspecialchars(
-				$this->languageNameUtils->getLanguageName( $languageCode, $this->userLanguageCode )
-			) ),
-			Message::plaintextParam( $languageCode ),
+			Message::rawParam(htmlspecialchars(
+				$this->languageNameUtils->getLanguageName($languageCode, $this->userLanguageCode)
+			)),
+			Message::plaintextParam($languageCode),
 		];
 	}
 
@@ -391,8 +391,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return array[] list of parameters as accepted by Message::params()
 	 */
-	private function renderLanguageList( array $languageCodes, ?string $role ): array {
-		return $this->renderList( $languageCodes, $role, [ $this, 'renderLanguage' ] );
+	private function renderLanguageList(array $languageCodes, ?string $role): array {
+		return $this->renderList($languageCodes, $role, [$this, 'renderLanguage']);
 	}
 
 }

src/WikibaseQualityConstraintsHooks.php

Spacing +40 added lines, -40 removed lines

@@ -28,27 +28,27 @@ 
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
-		$dir = dirname( __DIR__ ) . '/sql/';
+	public static function onCreateSchema(DatabaseUpdater $updater) {
+		$dir = dirname(__DIR__).'/sql/';
 
 		$updater->addExtensionTable(
 			'wbqc_constraints',
-			$dir . "/{$updater->getDB()->getType()}/tables-generated.sql"
+			$dir."/{$updater->getDB()->getType()}/tables-generated.sql"
 		);
 		$updater->addExtensionField(
 			'wbqc_constraints',
 			'constraint_id',
-			$dir . '/patch-wbqc_constraints-constraint_id.sql'
+			$dir.'/patch-wbqc_constraints-constraint_id.sql'
 		);
 		$updater->addExtensionIndex(
 			'wbqc_constraints',
 			'wbqc_constraints_guid_uniq',
-			$dir . '/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
+			$dir.'/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
 		);
 	}
 
-	public static function onWikibaseChange( Change $change ) {
-		if ( !( $change instanceof EntityChange ) ) {
+	public static function onWikibaseChange(Change $change) {
+		if (!($change instanceof EntityChange)) {
 			return;
 		}
 		/** @var EntityChange $change */
@@ -59,48 +59,48 @@ 
 
 		// If jobs are enabled and the results would be stored in some way run a job.
 		if (
-			$config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) &&
-			$config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) &&
+			$config->get('WBQualityConstraintsEnableConstraintsCheckJobs') &&
+			$config->get('WBQualityConstraintsCacheCheckConstraintsResults') &&
 			self::isSelectedForJobRunBasedOnPercentage()
 		) {
-			$params = [ 'entityId' => $change->getEntityId()->getSerialization() ];
+			$params = ['entityId' => $change->getEntityId()->getSerialization()];
 			$jobQueueGroup->lazyPush(
-				new JobSpecification( CheckConstraintsJob::COMMAND, $params )
+				new JobSpecification(CheckConstraintsJob::COMMAND, $params)
 			);
 		}
 
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-			self::isConstraintStatementsChange( $config, $change )
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
+			self::isConstraintStatementsChange($config, $change)
 		) {
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
 			$metadata = $change->getMetadata();
-			if ( array_key_exists( 'rev_id', $metadata ) ) {
+			if (array_key_exists('rev_id', $metadata)) {
 				$params['revisionId'] = $metadata['rev_id'];
 			}
 			$jobQueueGroup->push(
-				new JobSpecification( 'constraintsTableUpdate', $params )
+				new JobSpecification('constraintsTableUpdate', $params)
 			);
 		}
 	}
 
 	private static function isSelectedForJobRunBasedOnPercentage() {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		$percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' );
+		$percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio');
 
-		return mt_rand( 1, 100 ) <= $percentage;
+		return mt_rand(1, 100) <= $percentage;
 	}
 
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
-		if ( !( $change instanceof EntityChange ) ||
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
+		if (!($change instanceof EntityChange) ||
 			 $change->getAction() !== EntityChange::UPDATE ||
-			 !( $change->getEntityId() instanceof NumericPropertyId )
+			 !($change->getEntityId() instanceof NumericPropertyId)
 		) {
 			return false;
 		}
 
 		$info = $change->getInfo();
 
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
+		if (!array_key_exists('compactDiff', $info)) {
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
 			// so we only know that the change *might* affect the constraint statements
 			return true;
@@ -109,50 +109,50 @@ 
 		/** @var EntityDiffChangedAspects $aspects */
 		$aspects = $info['compactDiff'];
 
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
 	}
 
-	public static function onArticlePurge( WikiPage $wikiPage ) {
+	public static function onArticlePurge(WikiPage $wikiPage) {
 		$entityContentFactory = WikibaseRepo::getEntityContentFactory();
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
 			$entityIdLookup = WikibaseRepo::getEntityIdLookup();
-			$entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() );
-			if ( $entityId !== null ) {
+			$entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle());
+			if ($entityId !== null) {
 				$resultsCache = ResultsCache::getDefaultInstance();
-				$resultsCache->delete( $entityId );
+				$resultsCache->delete($entityId);
 			}
 		}
 	}
 
-	public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
+	public static function onBeforePageDisplay(OutputPage $out, Skin $skin) {
 		$lookup = WikibaseRepo::getEntityNamespaceLookup();
 		$title = $out->getTitle();
-		if ( $title === null ) {
+		if ($title === null) {
 			return;
 		}
 
-		if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) {
+		if (!$lookup->isNamespaceWithEntities($title->getNamespace())) {
 			return;
 		}
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
 			return;
 		}
 
 		$services = MediaWikiServices::getInstance();
 		$config = $services->getMainConfig();
 
-		$isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) &&
-			$services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView();
-		if ( $isMobileView ) {
+		$isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') &&
+			$services->getService('MobileFrontend.Context')->shouldDisplayMobileView();
+		if ($isMobileView) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
+		$out->addModules('wikibase.quality.constraints.suggestions');
 
-		if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' )
-			|| $out->getUser()->isRegistered() ) {
-				$out->addModules( 'wikibase.quality.constraints.gadget' );
+		if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers')
+			|| $out->getUser()->isRegistered()) {
+				$out->addModules('wikibase.quality.constraints.gadget');
 		}
 	}