Completed
Pull Request — master (#67)
by
unknown
19s
created
src/ConstraintCheck/Checker/SymmetricChecker.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -74,9 +74,9 @@  discard block
 block discarded – undo
74 74
 	 *
75 75
 	 * @return CheckResult
76 76
 	 */
77
-	public function checkConstraint( Context $context, Constraint $constraint ) {
78
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
79
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
77
+	public function checkConstraint(Context $context, Constraint $constraint) {
78
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
79
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
80 80
 		}
81 81
 
82 82
 		$parameters = [];
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 		$snak = $context->getSnak();
85 85
 		$propertyId = $context->getSnak()->getPropertyId();
86 86
 
87
-		if ( !$snak instanceof PropertyValueSnak ) {
87
+		if (!$snak instanceof PropertyValueSnak) {
88 88
 			// nothing to check
89
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
89
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
90 90
 		}
91 91
 
92 92
 		$dataValue = $snak->getDataValue();
@@ -95,18 +95,18 @@  discard block
 block discarded – undo
95 95
 		 * error handling:
96 96
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
97 97
 		 */
98
-		if ( !$dataValue instanceof EntityIdValue ) {
99
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
100
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
101
-				->withDataValueType( 'wikibase-entityid' );
102
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
98
+		if (!$dataValue instanceof EntityIdValue) {
99
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
100
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
101
+				->withDataValueType('wikibase-entityid');
102
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
103 103
 		}
104 104
 
105 105
 		$targetEntityId = $dataValue->getEntityId();
106
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
107
-		if ( !$targetEntity instanceof StatementListProvider ) {
108
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
109
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
106
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
107
+		if (!$targetEntity instanceof StatementListProvider) {
108
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
109
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
110 110
 		}
111 111
 
112 112
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -114,23 +114,23 @@  discard block
 block discarded – undo
114 114
 			$propertyId,
115 115
 			$context->getEntity()->getId()
116 116
 		);
117
-		if ( $symmetricStatement !== null ) {
117
+		if ($symmetricStatement !== null) {
118 118
 			$message = null;
119 119
 			$status = CheckResult::STATUS_COMPLIANCE;
120 120
 		} else {
121
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
122
-				->withEntityId( $targetEntityId, Role::SUBJECT )
123
-				->withEntityId( $propertyId, Role::PREDICATE )
124
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
121
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
122
+				->withEntityId($targetEntityId, Role::SUBJECT)
123
+				->withEntityId($propertyId, Role::PREDICATE)
124
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
125 125
 			$status = CheckResult::STATUS_VIOLATION;
126 126
 		}
127 127
 
128
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
129
-			->withMetadata( Metadata::ofDependencyMetadata(
130
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
128
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
129
+			->withMetadata(Metadata::ofDependencyMetadata(
130
+				DependencyMetadata::ofEntityId($targetEntityId) ));
131 131
 	}
132 132
 
133
-	public function checkConstraintParameters( Constraint $constraint ) {
133
+	public function checkConstraintParameters(Constraint $constraint) {
134 134
 		// no parameters
135 135
 		return [];
136 136
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/InverseChecker.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 	 * @throws ConstraintParameterException
85 85
 	 * @return CheckResult
86 86
 	 */
87
-	public function checkConstraint( Context $context, Constraint $constraint ) {
88
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
89
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
87
+	public function checkConstraint(Context $context, Constraint $constraint) {
88
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
89
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
90 90
 		}
91 91
 
92 92
 		$parameters = [];
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
 			$constraintParameters,
98 98
 			$constraintTypeItemId
99 99
 		);
100
-		$parameters['property'] = [ $propertyId ];
100
+		$parameters['property'] = [$propertyId];
101 101
 
102 102
 		$snak = $context->getSnak();
103 103
 
104
-		if ( !$snak instanceof PropertyValueSnak ) {
104
+		if (!$snak instanceof PropertyValueSnak) {
105 105
 			// nothing to check
106
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
106
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
107 107
 		}
108 108
 
109 109
 		$dataValue = $snak->getDataValue();
@@ -112,18 +112,18 @@  discard block
 block discarded – undo
112 112
 		 * error handling:
113 113
 		 *   type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
114 114
 		 */
115
-		if ( !$dataValue instanceof EntityIdValue ) {
116
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
117
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
118
-				->withDataValueType( 'wikibase-entityid' );
119
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
115
+		if (!$dataValue instanceof EntityIdValue) {
116
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
117
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
118
+				->withDataValueType('wikibase-entityid');
119
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
120 120
 		}
121 121
 
122 122
 		$targetEntityId = $dataValue->getEntityId();
123
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
124
-		if ( !$targetEntity instanceof StatementListProvider ) {
125
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
126
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
123
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
124
+		if (!$targetEntity instanceof StatementListProvider) {
125
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
126
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
127 127
 		}
128 128
 
129 129
 		$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -131,23 +131,23 @@  discard block
 block discarded – undo
131 131
 			$propertyId,
132 132
 			$context->getEntity()->getId()
133 133
 		);
134
-		if ( $inverseStatement !== null ) {
134
+		if ($inverseStatement !== null) {
135 135
 			$message = null;
136 136
 			$status = CheckResult::STATUS_COMPLIANCE;
137 137
 		} else {
138
-			$message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
139
-				->withEntityId( $targetEntityId, Role::SUBJECT )
140
-				->withEntityId( $propertyId, Role::PREDICATE )
141
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
138
+			$message = (new ViolationMessage('wbqc-violation-message-inverse'))
139
+				->withEntityId($targetEntityId, Role::SUBJECT)
140
+				->withEntityId($propertyId, Role::PREDICATE)
141
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
142 142
 			$status = CheckResult::STATUS_VIOLATION;
143 143
 		}
144 144
 
145
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
146
-			->withMetadata( Metadata::ofDependencyMetadata(
147
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
145
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
146
+			->withMetadata(Metadata::ofDependencyMetadata(
147
+				DependencyMetadata::ofEntityId($targetEntityId) ));
148 148
 	}
149 149
 
150
-	public function checkConstraintParameters( Constraint $constraint ) {
150
+	public function checkConstraintParameters(Constraint $constraint) {
151 151
 		$constraintParameters = $constraint->getConstraintParameters();
152 152
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
153 153
 		$exceptions = [];
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 				$constraintParameters,
157 157
 				$constraintTypeItemId
158 158
 			);
159
-		} catch ( ConstraintParameterException $e ) {
159
+		} catch (ConstraintParameterException $e) {
160 160
 			$exceptions[] = $e;
161 161
 		}
162 162
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -82,9 +82,9 @@  discard block
 block discarded – undo
82 82
 	 * @throws ConstraintParameterException
83 83
 	 * @return CheckResult
84 84
 	 */
85
-	public function checkConstraint( Context $context, Constraint $constraint ) {
86
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
87
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
85
+	public function checkConstraint(Context $context, Constraint $constraint) {
86
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
87
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
88 88
 		}
89 89
 
90 90
 		$parameters = [];
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 			$constraintParameters,
96 96
 			$constraintTypeItemId
97 97
 		);
98
-		$parameters['property'] = [ $propertyId ];
98
+		$parameters['property'] = [$propertyId];
99 99
 
100 100
 		$items = $this->constraintParameterParser->parseItemsParameter(
101 101
 			$constraintParameters,
@@ -106,9 +106,9 @@  discard block
 block discarded – undo
106 106
 
107 107
 		$snak = $context->getSnak();
108 108
 
109
-		if ( !$snak instanceof PropertyValueSnak ) {
109
+		if (!$snak instanceof PropertyValueSnak) {
110 110
 			// nothing to check
111
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
111
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
112 112
 		}
113 113
 
114 114
 		$dataValue = $snak->getDataValue();
@@ -117,18 +117,18 @@  discard block
 block discarded – undo
117 117
 		 * error handling:
118 118
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
119 119
 		 */
120
-		if ( !$dataValue instanceof EntityIdValue ) {
121
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
122
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
123
-				->withDataValueType( 'wikibase-entityid' );
124
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
120
+		if (!$dataValue instanceof EntityIdValue) {
121
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
122
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
123
+				->withDataValueType('wikibase-entityid');
124
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
125 125
 		}
126 126
 
127 127
 		$targetEntityId = $dataValue->getEntityId();
128
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
129
-		if ( !$targetEntity instanceof StatementListProvider ) {
130
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
131
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
128
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
129
+		if (!$targetEntity instanceof StatementListProvider) {
130
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
131
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
132 132
 		}
133 133
 
134 134
 		/*
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 		 *   a) a property only
137 137
 		 *   b) a property and a number of items (each combination forming an individual claim)
138 138
 		 */
139
-		if ( $items === [] ) {
139
+		if ($items === []) {
140 140
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
141 141
 				$targetEntity->getStatements(),
142 142
 				$propertyId
@@ -149,23 +149,23 @@  discard block
 block discarded – undo
149 149
 			);
150 150
 		}
151 151
 
152
-		if ( $requiredStatement !== null ) {
152
+		if ($requiredStatement !== null) {
153 153
 			$status = CheckResult::STATUS_COMPLIANCE;
154 154
 			$message = null;
155 155
 		} else {
156 156
 			$status = CheckResult::STATUS_VIOLATION;
157
-			$message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
158
-				->withEntityId( $targetEntityId, Role::SUBJECT )
159
-				->withEntityId( $propertyId, Role::PREDICATE )
160
-				->withItemIdSnakValueList( $items, Role::OBJECT );
157
+			$message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
158
+				->withEntityId($targetEntityId, Role::SUBJECT)
159
+				->withEntityId($propertyId, Role::PREDICATE)
160
+				->withItemIdSnakValueList($items, Role::OBJECT);
161 161
 		}
162 162
 
163
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
164
-			->withMetadata( Metadata::ofDependencyMetadata(
165
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
163
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
164
+			->withMetadata(Metadata::ofDependencyMetadata(
165
+				DependencyMetadata::ofEntityId($targetEntityId) ));
166 166
 	}
167 167
 
168
-	public function checkConstraintParameters( Constraint $constraint ) {
168
+	public function checkConstraintParameters(Constraint $constraint) {
169 169
 		$constraintParameters = $constraint->getConstraintParameters();
170 170
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
171 171
 		$exceptions = [];
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 				$constraintParameters,
175 175
 				$constraintTypeItemId
176 176
 			);
177
-		} catch ( ConstraintParameterException $e ) {
177
+		} catch (ConstraintParameterException $e) {
178 178
 			$exceptions[] = $e;
179 179
 		}
180 180
 		try {
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 				$constraintTypeItemId,
184 184
 				false
185 185
 			);
186
-		} catch ( ConstraintParameterException $e ) {
186
+		} catch (ConstraintParameterException $e) {
187 187
 			$exceptions[] = $e;
188 188
 		}
189 189
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
 	 * @throws ConstraintParameterException
72 72
 	 * @return CheckResult
73 73
 	 */
74
-	public function checkConstraint( Context $context, Constraint $constraint ) {
75
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
74
+	public function checkConstraint(Context $context, Constraint $constraint) {
75
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
76
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77 77
 		}
78 78
 
79 79
 		$parameters = [];
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			$constraintParameters,
85 85
 			$constraintTypeItemId
86 86
 		);
87
-		$parameters['property'] = [ $propertyId ];
87
+		$parameters['property'] = [$propertyId];
88 88
 
89 89
 		$items = $this->constraintParameterParser->parseItemsParameter(
90 90
 			$constraintParameters,
@@ -95,22 +95,22 @@  discard block
 block discarded – undo
95 95
 
96 96
 		$statementList = $context->getEntity()
97 97
 			->getStatements()
98
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
98
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
99 99
 
100 100
 		/*
101 101
 		 * 'Conflicts with' can be defined with
102 102
 		 *   a) a property only
103 103
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
104 104
 		 */
105
-		if ( $items === [] ) {
105
+		if ($items === []) {
106 106
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
107 107
 				$statementList,
108 108
 				$propertyId
109 109
 			);
110
-			if ( $offendingStatement !== null ) {
111
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
112
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
113
-					->withEntityId( $propertyId, Role::PREDICATE );
110
+			if ($offendingStatement !== null) {
111
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
112
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
113
+					->withEntityId($propertyId, Role::PREDICATE);
114 114
 				$status = CheckResult::STATUS_VIOLATION;
115 115
 			} else {
116 116
 				$message = null;
@@ -122,12 +122,12 @@  discard block
 block discarded – undo
122 122
 				$propertyId,
123 123
 				$items
124 124
 			);
125
-			if ( $offendingStatement !== null ) {
126
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
127
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
128
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
129
-					->withEntityId( $propertyId, Role::PREDICATE )
130
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
125
+			if ($offendingStatement !== null) {
126
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
127
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
128
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
129
+					->withEntityId($propertyId, Role::PREDICATE)
130
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
131 131
 				$status = CheckResult::STATUS_VIOLATION;
132 132
 			} else {
133 133
 				$message = null;
@@ -135,10 +135,10 @@  discard block
 block discarded – undo
135 135
 			}
136 136
 		}
137 137
 
138
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
138
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
139 139
 	}
140 140
 
141
-	public function checkConstraintParameters( Constraint $constraint ) {
141
+	public function checkConstraintParameters(Constraint $constraint) {
142 142
 		$constraintParameters = $constraint->getConstraintParameters();
143 143
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
144 144
 		$exceptions = [];
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 				$constraintParameters,
148 148
 				$constraintTypeItemId
149 149
 			);
150
-		} catch ( ConstraintParameterException $e ) {
150
+		} catch (ConstraintParameterException $e) {
151 151
 			$exceptions[] = $e;
152 152
 		}
153 153
 		try {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 				$constraintTypeItemId,
157 157
 				false
158 158
 			);
159
-		} catch ( ConstraintParameterException $e ) {
159
+		} catch (ConstraintParameterException $e) {
160 160
 			$exceptions[] = $e;
161 161
 		}
162 162
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessageDeserializer.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -39,23 +39,23 @@  discard block
 block discarded – undo
39 39
 		$this->dataValueFactory = $dataValueFactory;
40 40
 	}
41 41
 
42
-	public function unabbreviateViolationMessageKey( $messageKeySuffix ) {
43
-		return ViolationMessage::MESSAGE_KEY_PREFIX . $messageKeySuffix;
42
+	public function unabbreviateViolationMessageKey($messageKeySuffix) {
43
+		return ViolationMessage::MESSAGE_KEY_PREFIX.$messageKeySuffix;
44 44
 	}
45 45
 
46 46
 	/**
47 47
 	 * @param array $serialization
48 48
 	 * @return ViolationMessage
49 49
 	 */
50
-	public function deserialize( $serialization ) {
51
-		Assert::parameterType( 'array', $serialization, '$serialization' );
50
+	public function deserialize($serialization) {
51
+		Assert::parameterType('array', $serialization, '$serialization');
52 52
 
53 53
 		$message = new ViolationMessage(
54
-			$this->unabbreviateViolationMessageKey( $serialization['k'] )
54
+			$this->unabbreviateViolationMessageKey($serialization['k'])
55 55
 		);
56 56
 
57
-		foreach ( $serialization['a'] as $serializedArgument ) {
58
-			$message = $this->deserializeArgument( $message, $serializedArgument );
57
+		foreach ($serialization['a'] as $serializedArgument) {
58
+			$message = $this->deserializeArgument($message, $serializedArgument);
59 59
 		}
60 60
 
61 61
 		return $message;
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * @param array $serializedArgument [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
67 67
 	 * @return ViolationMessage $message with the deserialized argument appended
68 68
 	 */
69
-	private function deserializeArgument( ViolationMessage $message, array $serializedArgument ) {
69
+	private function deserializeArgument(ViolationMessage $message, array $serializedArgument) {
70 70
 		$methods = [
71 71
 			ViolationMessage::TYPE_ENTITY_ID => 'deserializeEntityId',
72 72
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'deserializeEntityIdList',
@@ -87,23 +87,23 @@  discard block
 block discarded – undo
87 87
 		$serializedValue = $serializedArgument['v'];
88 88
 		$role = $serializedArgument['r'];
89 89
 
90
-		if ( array_key_exists( $type, $methods ) ) {
90
+		if (array_key_exists($type, $methods)) {
91 91
 			$method = $methods[$type];
92
-			$value = $this->$method( $serializedValue );
92
+			$value = $this->$method($serializedValue);
93 93
 		} else {
94 94
 			throw new InvalidArgumentException(
95
-				'Unknown ViolationMessage argument type ' . $type . '!'
95
+				'Unknown ViolationMessage argument type '.$type.'!'
96 96
 			);
97 97
 		}
98 98
 
99
-		return $message->withArgument( $type, $role, $value );
99
+		return $message->withArgument($type, $role, $value);
100 100
 	}
101 101
 
102 102
 	/**
103 103
 	 * @param string $string any value that shall simply be deserialized into itself
104 104
 	 * @return string that same value, unchanged
105 105
 	 */
106
-	private function deserializeStringByIdentity( $string ) {
106
+	private function deserializeStringByIdentity($string) {
107 107
 		return $string;
108 108
 	}
109 109
 
@@ -111,32 +111,32 @@  discard block
 block discarded – undo
111 111
 	 * @param string $entityIdSerialization entity ID serialization
112 112
 	 * @return EntityId
113 113
 	 */
114
-	private function deserializeEntityId( $entityIdSerialization ) {
115
-		return $this->entityIdParser->parse( $entityIdSerialization );
114
+	private function deserializeEntityId($entityIdSerialization) {
115
+		return $this->entityIdParser->parse($entityIdSerialization);
116 116
 	}
117 117
 
118 118
 	/**
119 119
 	 * @param string[] $entityIdSerializations entity ID serializations
120 120
 	 * @return EntityId[]
121 121
 	 */
122
-	private function deserializeEntityIdList( array $entityIdSerializations ) {
123
-		return array_map( [ $this, 'deserializeEntityId' ], $entityIdSerializations );
122
+	private function deserializeEntityIdList(array $entityIdSerializations) {
123
+		return array_map([$this, 'deserializeEntityId'], $entityIdSerializations);
124 124
 	}
125 125
 
126 126
 	/**
127 127
 	 * @param string $valueSerialization entity ID serialization, '::somevalue' or '::novalue'
128 128
 	 * @return ItemIdSnakValue
129 129
 	 */
130
-	private function deserializeItemIdSnakValue( $valueSerialization ) {
131
-		switch ( $valueSerialization ) {
130
+	private function deserializeItemIdSnakValue($valueSerialization) {
131
+		switch ($valueSerialization) {
132 132
 			case '::somevalue':
133 133
 				return ItemIdSnakValue::someValue();
134 134
 			case '::novalue':
135 135
 				return ItemIdSnakValue::noValue();
136 136
 			default:
137
-				$itemId = $this->deserializeEntityId( $valueSerialization );
137
+				$itemId = $this->deserializeEntityId($valueSerialization);
138 138
 				'@phan-var \Wikibase\DataModel\Entity\ItemId $itemId';
139
-				return ItemIdSnakValue::fromItemId( $itemId );
139
+				return ItemIdSnakValue::fromItemId($itemId);
140 140
 		}
141 141
 	}
142 142
 
@@ -144,24 +144,24 @@  discard block
 block discarded – undo
144 144
 	 * @param string[] $valueSerializations entity ID serializations, '::somevalue's or '::novalue's
145 145
 	 * @return ItemIdSnakValue[]
146 146
 	 */
147
-	private function deserializeItemIdSnakValueList( $valueSerializations ) {
148
-		return array_map( [ $this, 'deserializeItemIdSnakValue' ], $valueSerializations );
147
+	private function deserializeItemIdSnakValueList($valueSerializations) {
148
+		return array_map([$this, 'deserializeItemIdSnakValue'], $valueSerializations);
149 149
 	}
150 150
 
151 151
 	/**
152 152
 	 * @param array $dataValueSerialization the data value in array form
153 153
 	 * @return DataValue
154 154
 	 */
155
-	private function deserializeDataValue( array $dataValueSerialization ) {
156
-		return $this->dataValueFactory->newFromArray( $dataValueSerialization );
155
+	private function deserializeDataValue(array $dataValueSerialization) {
156
+		return $this->dataValueFactory->newFromArray($dataValueSerialization);
157 157
 	}
158 158
 
159 159
 	/**
160 160
 	 * @param string $contextTypeAbbreviation
161 161
 	 * @return string one of the Context::TYPE_* constants
162 162
 	 */
163
-	private function deserializeContextType( $contextTypeAbbreviation ) {
164
-		switch ( $contextTypeAbbreviation ) {
163
+	private function deserializeContextType($contextTypeAbbreviation) {
164
+		switch ($contextTypeAbbreviation) {
165 165
 			case 's':
166 166
 				return Context::TYPE_STATEMENT;
167 167
 			case 'q':
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			default:
172 172
 				// @codeCoverageIgnoreStart
173 173
 				throw new LogicException(
174
-					'Unknown context type abbreviation ' . $contextTypeAbbreviation
174
+					'Unknown context type abbreviation '.$contextTypeAbbreviation
175 175
 				);
176 176
 				// @codeCoverageIgnoreEnd
177 177
 		}
@@ -181,16 +181,16 @@  discard block
 block discarded – undo
181 181
 	 * @param string[] $contextTypeAbbreviations
182 182
 	 * @return string[] Context::TYPE_* constants
183 183
 	 */
184
-	private function deserializeContextTypeList( array $contextTypeAbbreviations ) {
185
-		return array_map( [ $this, 'deserializeContextType' ], $contextTypeAbbreviations );
184
+	private function deserializeContextTypeList(array $contextTypeAbbreviations) {
185
+		return array_map([$this, 'deserializeContextType'], $contextTypeAbbreviations);
186 186
 	}
187 187
 
188 188
 	/**
189 189
 	 * @param mixed $textSerialization {@see MultilingualTextValue::getArrayValue}
190 190
 	 * @return MultilingualTextValue
191 191
 	 */
192
-	private function deserializeMultilingualText( $textSerialization ) {
193
-		return MultilingualTextValue::newFromArray( $textSerialization );
192
+	private function deserializeMultilingualText($textSerialization) {
193
+		return MultilingualTextValue::newFromArray($textSerialization);
194 194
 	}
195 195
 
196 196
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/RangeCheckerHelper.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 		$this->config = $config;
54 54
 		$this->timeParser = new IsoTimestampParser();
55 55
 		$this->timeCalculator = new TimeValueCalculator();
56
-		$this->timeValueComparer = new TimeValueComparer( $this->timeCalculator );
56
+		$this->timeValueComparer = new TimeValueComparer($this->timeCalculator);
57 57
 		$this->unitConverter = $unitConverter;
58 58
 	}
59 59
 
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
 	 * @param UnboundedQuantityValue $value
62 62
 	 * @return UnboundedQuantityValue $value converted to standard units if possible, otherwise unchanged $value.
63 63
 	 */
64
-	private function standardize( UnboundedQuantityValue $value ) {
65
-		if ( $this->unitConverter !== null ) {
66
-			$standard = $this->unitConverter->toStandardUnits( $value );
67
-			if ( $standard !== null ) {
64
+	private function standardize(UnboundedQuantityValue $value) {
65
+		if ($this->unitConverter !== null) {
66
+			$standard = $this->unitConverter->toStandardUnits($value);
67
+			if ($standard !== null) {
68 68
 				return $standard;
69 69
 			} else {
70 70
 				return $value;
@@ -86,33 +86,33 @@  discard block
 block discarded – undo
86 86
 	 *                 when $lhs is respectively less than, equal to, or greater than $rhs.
87 87
 	 *                 (In other words, just like the “spaceship” operator <=>.)
88 88
 	 */
89
-	public function getComparison( DataValue $lhs = null, DataValue $rhs = null ) {
90
-		if ( $lhs === null || $rhs === null ) {
89
+	public function getComparison(DataValue $lhs = null, DataValue $rhs = null) {
90
+		if ($lhs === null || $rhs === null) {
91 91
 			return 0;
92 92
 		}
93 93
 
94
-		if ( $lhs->getType() !== $rhs->getType() ) {
95
-			throw new InvalidArgumentException( 'Different data value types' );
94
+		if ($lhs->getType() !== $rhs->getType()) {
95
+			throw new InvalidArgumentException('Different data value types');
96 96
 		}
97 97
 
98
-		switch ( $lhs->getType() ) {
98
+		switch ($lhs->getType()) {
99 99
 			case 'time':
100 100
 				/** @var TimeValue $lhs */
101 101
 				/** @var TimeValue $rhs */
102 102
 				'@phan-var TimeValue $lhs';
103 103
 				'@phan-var TimeValue $rhs';
104
-				return $this->timeValueComparer->getComparison( $lhs, $rhs );
104
+				return $this->timeValueComparer->getComparison($lhs, $rhs);
105 105
 			case 'quantity':
106 106
 				/** @var QuantityValue|UnboundedQuantityValue $lhs */
107 107
 				/** @var QuantityValue|UnboundedQuantityValue $rhs */
108 108
 				'@phan-var QuantityValue|UnboundedQuantityValue $lhs';
109 109
 				'@phan-var QuantityValue|UnboundedQuantityValue $rhs';
110
-				$lhsStandard = $this->standardize( $lhs );
111
-				$rhsStandard = $this->standardize( $rhs );
112
-				return $lhsStandard->getAmount()->compare( $rhsStandard->getAmount() );
110
+				$lhsStandard = $this->standardize($lhs);
111
+				$rhsStandard = $this->standardize($rhs);
112
+				return $lhsStandard->getAmount()->compare($rhsStandard->getAmount());
113 113
 		}
114 114
 
115
-		throw new InvalidArgumentException( 'Unsupported data value type' );
115
+		throw new InvalidArgumentException('Unsupported data value type');
116 116
 	}
117 117
 
118 118
 	/**
@@ -127,71 +127,71 @@  discard block
 block discarded – undo
127 127
 	 * @throws InvalidArgumentException if the values do not both have the same, supported data value type
128 128
 	 * @return UnboundedQuantityValue
129 129
 	 */
130
-	public function getDifference( DataValue $minuend, DataValue $subtrahend ) {
131
-		if ( $minuend->getType() === 'time' && $subtrahend->getType() === 'time' ) {
132
-			$minuendSeconds = $this->timeCalculator->getTimestamp( $minuend );
133
-			$subtrahendSeconds = $this->timeCalculator->getTimestamp( $subtrahend );
130
+	public function getDifference(DataValue $minuend, DataValue $subtrahend) {
131
+		if ($minuend->getType() === 'time' && $subtrahend->getType() === 'time') {
132
+			$minuendSeconds = $this->timeCalculator->getTimestamp($minuend);
133
+			$subtrahendSeconds = $this->timeCalculator->getTimestamp($subtrahend);
134 134
 			return UnboundedQuantityValue::newFromNumber(
135 135
 				$minuendSeconds - $subtrahendSeconds,
136
-				$this->config->get( 'WBQualityConstraintsSecondUnit' )
136
+				$this->config->get('WBQualityConstraintsSecondUnit')
137 137
 			);
138 138
 		}
139
-		if ( $minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity' ) {
140
-			$minuendStandard = $this->standardize( $minuend );
141
-			$subtrahendStandard = $this->standardize( $subtrahend );
139
+		if ($minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity') {
140
+			$minuendStandard = $this->standardize($minuend);
141
+			$subtrahendStandard = $this->standardize($subtrahend);
142 142
 			$minuendValue = $minuendStandard->getAmount()->getValueFloat();
143 143
 			$subtrahendValue = $subtrahendStandard->getAmount()->getValueFloat();
144 144
 			$diff = $minuendValue - $subtrahendValue;
145 145
 			// we don’t check whether both quantities have the same standard unit –
146 146
 			// that’s the job of a different constraint type, Units (T164372)
147
-			return UnboundedQuantityValue::newFromNumber( $diff, $minuendStandard->getUnit() );
147
+			return UnboundedQuantityValue::newFromNumber($diff, $minuendStandard->getUnit());
148 148
 		}
149 149
 
150
-		throw new InvalidArgumentException( 'Unsupported or different data value types' );
150
+		throw new InvalidArgumentException('Unsupported or different data value types');
151 151
 	}
152 152
 
153
-	public function getDifferenceInYears( TimeValue $minuend, TimeValue $subtrahend ) {
154
-		if ( !preg_match( '/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches ) ||
155
-			!preg_match( '/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches )
153
+	public function getDifferenceInYears(TimeValue $minuend, TimeValue $subtrahend) {
154
+		if (!preg_match('/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches) ||
155
+			!preg_match('/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches)
156 156
 		) {
157
-			throw new InvalidArgumentException( 'TimeValue::getTime() did not match expected format' );
157
+			throw new InvalidArgumentException('TimeValue::getTime() did not match expected format');
158 158
 		}
159
-		$minuendYear = (float)$minuendMatches[1];
160
-		$subtrahendYear = (float)$subtrahendMatches[1];
159
+		$minuendYear = (float) $minuendMatches[1];
160
+		$subtrahendYear = (float) $subtrahendMatches[1];
161 161
 		$minuendRest = $minuendMatches[2];
162 162
 		$subtrahendRest = $subtrahendMatches[2];
163 163
 
164 164
 		// calculate difference of years
165 165
 		$diff = $minuendYear - $subtrahendYear;
166
-		if ( $minuendYear > 0.0 && $subtrahendYear < 0.0 ) {
166
+		if ($minuendYear > 0.0 && $subtrahendYear < 0.0) {
167 167
 			$diff -= 1.0; // there is no year 0, remove it from difference
168
-		} elseif ( $minuendYear < 0.0 && $subtrahendYear > 0.0 ) {
168
+		} elseif ($minuendYear < 0.0 && $subtrahendYear > 0.0) {
169 169
 			$diff -= -1.0; // there is no year 0, remove it from negative difference
170 170
 		}
171 171
 
172 172
 		// adjust for date within year by parsing the month-day part within the same year
173
-		$minuendDateValue = $this->timeParser->parse( '+0000000000001970-' . $minuendRest );
174
-		$subtrahendDateValue = $this->timeParser->parse( '+0000000000001970-' . $subtrahendRest );
175
-		$minuendDateSeconds = $this->timeCalculator->getTimestamp( $minuendDateValue );
176
-		$subtrahendDateSeconds = $this->timeCalculator->getTimestamp( $subtrahendDateValue );
177
-		if ( $minuendDateSeconds < $subtrahendDateSeconds ) {
173
+		$minuendDateValue = $this->timeParser->parse('+0000000000001970-'.$minuendRest);
174
+		$subtrahendDateValue = $this->timeParser->parse('+0000000000001970-'.$subtrahendRest);
175
+		$minuendDateSeconds = $this->timeCalculator->getTimestamp($minuendDateValue);
176
+		$subtrahendDateSeconds = $this->timeCalculator->getTimestamp($subtrahendDateValue);
177
+		if ($minuendDateSeconds < $subtrahendDateSeconds) {
178 178
 			// difference in the last year is actually less than one full year
179 179
 			// e. g. 1975-03-01 - 1974-09-01 is just six months
180 180
 			// (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough)
181 181
 			$diff -= 0.5;
182
-		} elseif ( $minuendDateSeconds > $subtrahendDateSeconds ) {
182
+		} elseif ($minuendDateSeconds > $subtrahendDateSeconds) {
183 183
 			// difference in the last year is actually more than one full year
184 184
 			// e. g. 1975-09-01 - 1974-03-01 is 18 months
185 185
 			// (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough)
186 186
 			$diff += 0.5;
187 187
 		}
188 188
 
189
-		$unit = $this->config->get( 'WBQualityConstraintsYearUnit' );
190
-		return UnboundedQuantityValue::newFromNumber( $diff, $unit );
189
+		$unit = $this->config->get('WBQualityConstraintsYearUnit');
190
+		return UnboundedQuantityValue::newFromNumber($diff, $unit);
191 191
 	}
192 192
 
193
-	public function isFutureTime( TimeValue $timeValue ) {
194
-		return $this->timeValueComparer->isFutureTime( $timeValue );
193
+	public function isFutureTime(TimeValue $timeValue) {
194
+		return $this->timeValueComparer->isFutureTime($timeValue);
195 195
 	}
196 196
 
197 197
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/ContextCursorSerializer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@  discard block
 block discarded – undo
13 13
 	 * @param ContextCursor $cursor
14 14
 	 * @return array
15 15
 	 */
16
-	public function serialize( ContextCursor $cursor ) {
17
-		if ( $cursor instanceof EntityContextCursor ) {
16
+	public function serialize(ContextCursor $cursor) {
17
+		if ($cursor instanceof EntityContextCursor) {
18 18
 			return [
19 19
 				't' => '\entity',
20 20
 				'i' => $cursor->getEntityId(),
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 			'h' => $cursor->getSnakHash(),
31 31
 		];
32 32
 
33
-		if ( $type === Context::TYPE_QUALIFIER || $type === Context::TYPE_REFERENCE ) {
33
+		if ($type === Context::TYPE_QUALIFIER || $type === Context::TYPE_REFERENCE) {
34 34
 			$serialization['P'] = $cursor->getSnakPropertyId();
35
-			if ( $type === Context::TYPE_REFERENCE ) {
35
+			if ($type === Context::TYPE_REFERENCE) {
36 36
 				/** @var ReferenceContextCursor $cursor */
37 37
 				'@phan-var ReferenceContextCursor $cursor';
38 38
 				$serialization['r'] = $cursor->getReferenceHash();
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/RangeChecker.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 	 * @throws ConstraintParameterException
85 85
 	 * @return CheckResult
86 86
 	 */
87
-	public function checkConstraint( Context $context, Constraint $constraint ) {
88
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
89
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
87
+	public function checkConstraint(Context $context, Constraint $constraint) {
88
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
89
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
90 90
 		}
91 91
 
92 92
 		$parameters = [];
@@ -94,28 +94,28 @@  discard block
 block discarded – undo
94 94
 
95 95
 		$snak = $context->getSnak();
96 96
 
97
-		if ( !$snak instanceof PropertyValueSnak ) {
97
+		if (!$snak instanceof PropertyValueSnak) {
98 98
 			// nothing to check
99
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
99
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
100 100
 		}
101 101
 
102 102
 		$dataValue = $snak->getDataValue();
103 103
 
104
-		list( $min, $max ) = $this->parseRangeParameter(
104
+		list($min, $max) = $this->parseRangeParameter(
105 105
 			$constraintParameters,
106 106
 			$constraint->getConstraintTypeItemId(),
107 107
 			$dataValue->getType()
108 108
 		);
109 109
 		$parameterKey = $dataValue->getType() === 'quantity' ? 'quantity' : 'date';
110
-		if ( $min !== null ) {
111
-			$parameters['minimum_' . $parameterKey] = [ $min ];
110
+		if ($min !== null) {
111
+			$parameters['minimum_'.$parameterKey] = [$min];
112 112
 		}
113
-		if ( $max !== null ) {
114
-			$parameters['maximum_' . $parameterKey] = [ $max ];
113
+		if ($max !== null) {
114
+			$parameters['maximum_'.$parameterKey] = [$max];
115 115
 		}
116 116
 
117
-		if ( $this->rangeCheckerHelper->getComparison( $min, $dataValue ) > 0 ||
118
-			 $this->rangeCheckerHelper->getComparison( $dataValue, $max ) > 0
117
+		if ($this->rangeCheckerHelper->getComparison($min, $dataValue) > 0 ||
118
+			 $this->rangeCheckerHelper->getComparison($dataValue, $max) > 0
119 119
 		) {
120 120
 			$message = $this->getViolationMessage(
121 121
 				$context->getSnak()->getPropertyId(),
@@ -131,16 +131,16 @@  discard block
 block discarded – undo
131 131
 
132 132
 		if (
133 133
 			$dataValue instanceof TimeValue &&
134
-			( $min instanceof NowValue || $max instanceof NowValue ) &&
135
-			$this->rangeCheckerHelper->isFutureTime( $dataValue )
134
+			($min instanceof NowValue || $max instanceof NowValue) &&
135
+			$this->rangeCheckerHelper->isFutureTime($dataValue)
136 136
 		) {
137
-			$dependencyMetadata = DependencyMetadata::ofFutureTime( $dataValue );
137
+			$dependencyMetadata = DependencyMetadata::ofFutureTime($dataValue);
138 138
 		} else {
139 139
 			$dependencyMetadata = DependencyMetadata::blank();
140 140
 		}
141 141
 
142
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
143
-			->withMetadata( Metadata::ofDependencyMetadata( $dependencyMetadata ) );
142
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
143
+			->withMetadata(Metadata::ofDependencyMetadata($dependencyMetadata));
144 144
 	}
145 145
 
146 146
 	/**
@@ -151,8 +151,8 @@  discard block
 block discarded – undo
151 151
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
152 152
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
153 153
 	 */
154
-	private function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) {
155
-		switch ( $type ) {
154
+	private function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) {
155
+		switch ($type) {
156 156
 			case 'quantity':
157 157
 				return $this->constraintParameterParser->parseQuantityRangeParameter(
158 158
 					$constraintParameters,
@@ -166,10 +166,10 @@  discard block
 block discarded – undo
166 166
 		}
167 167
 
168 168
 		throw new ConstraintParameterException(
169
-			( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
170
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
171
-				->withDataValueType( 'quantity' )
172
-				->withDataValueType( 'time' )
169
+			(new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
170
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
171
+				->withDataValueType('quantity')
172
+				->withDataValueType('time')
173 173
 		);
174 174
 	}
175 175
 
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 	 *
182 182
 	 * @return ViolationMessage
183 183
 	 */
184
-	private function getViolationMessage( PropertyId $predicate, DataValue $value, $min, $max ) {
184
+	private function getViolationMessage(PropertyId $predicate, DataValue $value, $min, $max) {
185 185
 		// possible message keys:
186 186
 		// wbqc-violation-message-range-quantity-closed
187 187
 		// wbqc-violation-message-range-quantity-leftopen
@@ -194,39 +194,39 @@  discard block
 block discarded – undo
194 194
 		// wbqc-violation-message-range-time-rightopen
195 195
 		// wbqc-violation-message-range-time-rightopen-leftnow
196 196
 		$messageKey = 'wbqc-violation-message-range';
197
-		$messageKey .= '-' . $value->getType();
197
+		$messageKey .= '-'.$value->getType();
198 198
 		// at least one of $min, $max is set, otherwise there could be no violation
199
-		$messageKey .= '-' . ( $min !== null ? ( $max !== null ? 'closed' : 'rightopen' ) : 'leftopen' );
200
-		if ( $min instanceof NowValue ) {
199
+		$messageKey .= '-'.($min !== null ? ($max !== null ? 'closed' : 'rightopen') : 'leftopen');
200
+		if ($min instanceof NowValue) {
201 201
 			$messageKey .= '-leftnow';
202
-		} elseif ( $max instanceof NowValue ) {
202
+		} elseif ($max instanceof NowValue) {
203 203
 			$messageKey .= '-rightnow';
204 204
 		}
205
-		$message = ( new ViolationMessage( $messageKey ) )
206
-			->withEntityId( $predicate, Role::PREDICATE )
207
-			->withDataValue( $value, Role::OBJECT );
208
-		if ( $min !== null && !( $min instanceof NowValue ) ) {
209
-			$message = $message->withDataValue( $min, Role::OBJECT );
205
+		$message = (new ViolationMessage($messageKey))
206
+			->withEntityId($predicate, Role::PREDICATE)
207
+			->withDataValue($value, Role::OBJECT);
208
+		if ($min !== null && !($min instanceof NowValue)) {
209
+			$message = $message->withDataValue($min, Role::OBJECT);
210 210
 		}
211
-		if ( $max !== null && !( $max instanceof NowValue ) ) {
212
-			$message = $message->withDataValue( $max, Role::OBJECT );
211
+		if ($max !== null && !($max instanceof NowValue)) {
212
+			$message = $message->withDataValue($max, Role::OBJECT);
213 213
 		}
214 214
 		return $message;
215 215
 	}
216 216
 
217
-	public function checkConstraintParameters( Constraint $constraint ) {
217
+	public function checkConstraintParameters(Constraint $constraint) {
218 218
 		$constraintParameters = $constraint->getConstraintParameters();
219 219
 		$exceptions = [];
220 220
 		try {
221 221
 			// we don’t have a data value here, so get the type from the property instead
222 222
 			// (the distinction between data type and data value type is irrelevant for 'quantity' and 'time')
223
-			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty( $constraint->getPropertyId() );
223
+			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty($constraint->getPropertyId());
224 224
 			$this->parseRangeParameter(
225 225
 				$constraintParameters,
226 226
 				$constraint->getConstraintTypeItemId(),
227 227
 				$type
228 228
 			);
229
-		} catch ( ConstraintParameterException $e ) {
229
+		} catch (ConstraintParameterException $e) {
230 230
 			$exceptions[] = $e;
231 231
 		}
232 232
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/ContextCursor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,6 +65,6 @@
 block discarded – undo
65 65
 	 * @param ?array $result
66 66
 	 * @param array[] &$container
67 67
 	 */
68
-	public function storeCheckResultInArray( ?array $result, array &$container );
68
+	public function storeCheckResultInArray(?array $result, array &$container);
69 69
 
70 70
 }
Please login to merge, or discard this patch.