wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintParameterRenderer.php

Spacing +97 added lines, -97 removed lines

@@ -64,20 +64,20 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatValue( $value ) {
-		if ( is_string( $value ) ) {
+	public function formatValue($value) {
+		if (is_string($value)) {
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
 			// strings
-			return htmlspecialchars( $value );
-		} elseif ( $value instanceof EntityId ) {
+			return htmlspecialchars($value);
+		} elseif ($value instanceof EntityId) {
 			// Cases like 'Conflicts with' 'property', to which we can link
-			return $this->formatEntityId( $value );
-		} elseif ( $value instanceof ItemIdSnakValue ) {
+			return $this->formatEntityId($value);
+		} elseif ($value instanceof ItemIdSnakValue) {
 			// Cases like EntityId but can also be somevalue or novalue
-			return $this->formatItemIdSnakValue( $value );
+			return $this->formatItemIdSnakValue($value);
 		} else {
 			// Cases where we format a DataValue
-			return $this->formatDataValue( $value );
+			return $this->formatDataValue($value);
 		}
 	}
 
@@ -88,23 +88,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatParameters( $parameters ) {
-		if ( $parameters === null || count( $parameters ) == 0 ) {
+	public function formatParameters($parameters) {
+		if ($parameters === null || count($parameters) == 0) {
 			return null;
 		}
 
-		$valueFormatter = function ( $value ) {
-			return $this->formatValue( $value );
+		$valueFormatter = function($value) {
+			return $this->formatValue($value);
 		};
 
 		$formattedParameters = [];
-		foreach ( $parameters as $parameterName => $parameterValue ) {
-			$formattedParameterValues = implode( ', ',
-				$this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) );
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
+		foreach ($parameters as $parameterName => $parameterValue) {
+			$formattedParameterValues = implode(', ',
+				$this->limitArrayLength(array_map($valueFormatter, $parameterValue)));
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
 		}
 
-		return implode( '; ', $formattedParameters );
+		return implode('; ', $formattedParameters);
 	}
 
 	/**
@@ -114,10 +114,10 @@ 
 	 *
 	 * @return array
 	 */
-	private function limitArrayLength( array $array ) {
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
-			array_push( $array, '...' );
+	private function limitArrayLength(array $array) {
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
+			array_push($array, '...');
 		}
 
 		return $array;
@@ -130,12 +130,12 @@ 
 	 * @param string $value HTML
 	 * @return string HTML
 	 */
-	public static function formatByRole( $role, $value ) {
-		if ( $role === null ) {
+	public static function formatByRole($role, $value) {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">'
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'
 			. $value
 			. '</span>';
 	}
@@ -145,9 +145,9 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatDataValue( DataValue $value, $role = null ) {
-		return self::formatByRole( $role,
-			$this->dataValueFormatter->format( $value ) );
+	public function formatDataValue(DataValue $value, $role = null) {
+		return self::formatByRole($role,
+			$this->dataValueFormatter->format($value));
 	}
 
 	/**
@@ -155,9 +155,9 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatEntityId( EntityId $entityId, $role = null ) {
-		return self::formatByRole( $role,
-			$this->entityIdLabelFormatter->formatEntityId( $entityId ) );
+	public function formatEntityId(EntityId $entityId, $role = null) {
+		return self::formatByRole($role,
+			$this->entityIdLabelFormatter->formatEntityId($entityId));
 	}
 
 	/**
@@ -169,18 +169,18 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatPropertyId( $propertyId, $role = null ) {
-		if ( $propertyId instanceof PropertyId ) {
-			return $this->formatEntityId( $propertyId, $role );
-		} elseif ( is_string( $propertyId ) ) {
+	public function formatPropertyId($propertyId, $role = null) {
+		if ($propertyId instanceof PropertyId) {
+			return $this->formatEntityId($propertyId, $role);
+		} elseif (is_string($propertyId)) {
 			try {
-				return $this->formatEntityId( new PropertyId( $propertyId ), $role );
-			} catch ( InvalidArgumentException $e ) {
-				return self::formatByRole( $role,
-					htmlspecialchars( $propertyId ) );
+				return $this->formatEntityId(new PropertyId($propertyId), $role);
+			} catch (InvalidArgumentException $e) {
+				return self::formatByRole($role,
+					htmlspecialchars($propertyId));
 			}
 		} else {
-			throw new InvalidArgumentException( '$propertyId must be either PropertyId or string' );
+			throw new InvalidArgumentException('$propertyId must be either PropertyId or string');
 		}
 	}
 
@@ -193,18 +193,18 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatItemId( $itemId, $role = null ) {
-		if ( $itemId instanceof ItemId ) {
-			return $this->formatEntityId( $itemId, $role );
-		} elseif ( is_string( $itemId ) ) {
+	public function formatItemId($itemId, $role = null) {
+		if ($itemId instanceof ItemId) {
+			return $this->formatEntityId($itemId, $role);
+		} elseif (is_string($itemId)) {
 			try {
-				return $this->formatEntityId( new ItemId( $itemId ), $role );
-			} catch ( InvalidArgumentException $e ) {
-				return self::formatByRole( $role,
-					htmlspecialchars( $itemId ) );
+				return $this->formatEntityId(new ItemId($itemId), $role);
+			} catch (InvalidArgumentException $e) {
+				return self::formatByRole($role,
+					htmlspecialchars($itemId));
 			}
 		} else {
-			throw new InvalidArgumentException( '$itemId must be either ItemId or string' );
+			throw new InvalidArgumentException('$itemId must be either ItemId or string');
 		}
 	}
 
@@ -215,20 +215,20 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
-		switch ( true ) {
+	public function formatItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
+		switch (true) {
 			case $value->isValue():
-				return $this->formatEntityId( $value->getItemId(), $role );
+				return $this->formatEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return self::formatByRole( $role,
+				return self::formatByRole($role,
 					'<span class="wikibase-snakview-variation-somevaluesnak">'
-						. wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped()
-						. '</span>' );
+						. wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped()
+						. '</span>');
 			case $value->isNoValue():
-				return self::formatByRole( $role,
+				return self::formatByRole($role,
 					'<span class="wikibase-snakview-variation-novaluesnak">'
-						. wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped()
-						. '</span>' );
+						. wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped()
+						. '</span>');
 		}
 	}
 
@@ -239,8 +239,8 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatConstraintScope( $scope, $role = null ) {
-		switch ( $scope ) {
+	public function formatConstraintScope($scope, $role = null) {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
 				$itemId = $this->config->get(
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -260,10 +260,10 @@ 
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->formatItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->formatItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->formatItemId( $itemId, $role );
+		return $this->formatItemId($itemId, $role);
 	}
 
 	/**
@@ -276,15 +276,15 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatPropertyIdList( array $propertyIds, $role = null ) {
-		if ( empty( $propertyIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatPropertyIdList(array $propertyIds, $role = null) {
+		if (empty($propertyIds)) {
+			return ['<ul></ul>'];
 		}
-		$propertyIds = $this->limitArrayLength( $propertyIds );
-		$formattedPropertyIds = array_map( [ $this, "formatPropertyId" ], $propertyIds, array_fill( 0, count( $propertyIds ), $role ) );
+		$propertyIds = $this->limitArrayLength($propertyIds);
+		$formattedPropertyIds = array_map([$this, "formatPropertyId"], $propertyIds, array_fill(0, count($propertyIds), $role));
 		array_unshift(
 			$formattedPropertyIds,
-			'<ul><li>' . implode( '</li><li>', $formattedPropertyIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedPropertyIds).'</li></ul>'
 		);
 		return $formattedPropertyIds;
 	}
@@ -299,15 +299,15 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatItemIdList( array $itemIds, $role = null ) {
-		if ( empty( $itemIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatItemIdList(array $itemIds, $role = null) {
+		if (empty($itemIds)) {
+			return ['<ul></ul>'];
 		}
-		$itemIds = $this->limitArrayLength( $itemIds );
-		$formattedItemIds = array_map( [ $this, "formatItemId" ], $itemIds, array_fill( 0, count( $itemIds ), $role ) );
+		$itemIds = $this->limitArrayLength($itemIds);
+		$formattedItemIds = array_map([$this, "formatItemId"], $itemIds, array_fill(0, count($itemIds), $role));
 		array_unshift(
 			$formattedItemIds,
-			'<ul><li>' . implode( '</li><li>', $formattedItemIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedItemIds).'</li></ul>'
 		);
 		return $formattedItemIds;
 	}
@@ -322,23 +322,23 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatEntityIdList( array $entityIds, $role = null ) {
-		if ( empty( $entityIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatEntityIdList(array $entityIds, $role = null) {
+		if (empty($entityIds)) {
+			return ['<ul></ul>'];
 		}
 		$formattedEntityIds = [];
-		foreach ( $entityIds as $entityId ) {
-			if ( count( $formattedEntityIds ) >= self::MAX_PARAMETER_ARRAY_LENGTH ) {
+		foreach ($entityIds as $entityId) {
+			if (count($formattedEntityIds) >= self::MAX_PARAMETER_ARRAY_LENGTH) {
 				$formattedEntityIds[] = '...';
 				break;
 			}
-			if ( $entityId !== null ) {
-				$formattedEntityIds[] = $this->formatEntityId( $entityId, $role );
+			if ($entityId !== null) {
+				$formattedEntityIds[] = $this->formatEntityId($entityId, $role);
 			}
 		}
 		array_unshift(
 			$formattedEntityIds,
-			'<ul><li>' . implode( '</li><li>', $formattedEntityIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedEntityIds).'</li></ul>'
 		);
 		return $formattedEntityIds;
 	}
@@ -353,24 +353,24 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatItemIdSnakValueList( array $values, $role = null ) {
-		if ( empty( $values ) ) {
-			return [ '<ul></ul>' ];
+	public function formatItemIdSnakValueList(array $values, $role = null) {
+		if (empty($values)) {
+			return ['<ul></ul>'];
 		}
-		$values = $this->limitArrayLength( $values );
+		$values = $this->limitArrayLength($values);
 		$formattedValues = array_map(
-			function( $value ) use ( $role ) {
-				if ( $value === '...' ) {
+			function($value) use ($role) {
+				if ($value === '...') {
 					return '...';
 				} else {
-					return $this->formatItemIdSnakValue( $value, $role );
+					return $this->formatItemIdSnakValue($value, $role);
 				}
 			},
 			$values
 		);
 		array_unshift(
 			$formattedValues,
-			'<ul><li>' . implode( '</li><li>', $formattedValues ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedValues).'</li></ul>'
 		);
 		return $formattedValues;
 	}
@@ -385,24 +385,24 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatConstraintScopeList( array $scopes, $role = null ) {
-		if ( empty( $scopes ) ) {
-			return [ '<ul></ul>' ];
+	public function formatConstraintScopeList(array $scopes, $role = null) {
+		if (empty($scopes)) {
+			return ['<ul></ul>'];
 		}
-		$scopes = $this->limitArrayLength( $scopes );
+		$scopes = $this->limitArrayLength($scopes);
 		$formattedScopes = array_map(
-			function( $scope ) use ( $role ) {
-				if ( $scope === '...' ) {
+			function($scope) use ($role) {
+				if ($scope === '...') {
 					return '...';
 				} else {
-					return $this->formatConstraintScope( $scope, $role );
+					return $this->formatConstraintScope($scope, $role);
 				}
 			},
 			$scopes
 		);
 		array_unshift(
 			$formattedScopes,
-			'<ul><li>' . implode( '</li><li>', $formattedScopes ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedScopes).'</li></ul>'
 		);
 		return $formattedScopes;
 	}

src/ConstraintCheck/ItemIdSnakValue.php

Spacing +11 added lines, -11 removed lines

@@ -44,7 +44,7 @@ 
 	 * @param ItemId $itemId
 	 * @return self
 	 */
-	public static function fromItemId( ItemId $itemId ) {
+	public static function fromItemId(ItemId $itemId) {
 		$ret = new self;
 		$ret->itemId = $itemId;
 		return $ret;
@@ -80,14 +80,14 @@ 
 	 * @throws InvalidArgumentException
 	 * @return self
 	 */
-	public static function fromSnak( Snak $snak ) {
-		switch ( true ) {
+	public static function fromSnak(Snak $snak) {
+		switch (true) {
 			case $snak instanceof PropertyValueSnak:
 				$dataValue = $snak->getDataValue();
-				if ( $dataValue instanceof EntityIdValue
+				if ($dataValue instanceof EntityIdValue
 					&& $dataValue->getEntityId() instanceof ItemId
 				) {
-					return self::fromItemId( $dataValue->getEntityId() );
+					return self::fromItemId($dataValue->getEntityId());
 				}
 				break;
 			case $snak instanceof PropertySomeValueSnak:
@@ -96,7 +96,7 @@ 
 				return self::noValue();
 		}
 
-		throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' );
+		throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak');
 	}
 
 	/**
@@ -133,8 +133,8 @@ 
 	 * @return ItemId
 	 */
 	public function getItemId() {
-		if ( ! $this->isValue() ) {
-			throw new DomainException( 'This value does not contain an item ID.' );
+		if (!$this->isValue()) {
+			throw new DomainException('This value does not contain an item ID.');
 		}
 		return $this->itemId;
 	}
@@ -146,13 +146,13 @@ 
 	 * @param Snak $snak
 	 * @return bool
 	 */
-	public function matchesSnak( Snak $snak ) {
-		switch ( true ) {
+	public function matchesSnak(Snak $snak) {
+		switch (true) {
 			case $snak instanceof PropertyValueSnak:
 				return $this->isValue() &&
 					$snak->getDataValue() instanceof EntityIdValue &&
 					$snak->getDataValue()->getEntityId() instanceof ItemId &&
-					$snak->getDataValue()->getEntityId()->equals( $this->getItemId() );
+					$snak->getDataValue()->getEntityId()->equals($this->getItemId());
 			case $snak instanceof PropertySomeValueSnak:
 				return $this->isSomeValue();
 			case $snak instanceof PropertyNoValueSnak:

src/ConstraintCheck/Helper/ConnectionCheckerHelper.php

Spacing +11 added lines, -11 removed lines

@@ -30,8 +30,8 @@ 
 		StatementList $statementList,
 		PropertyId $propertyId
 	) {
-		$statementListByPropertyId = $statementList->getByPropertyId( $propertyId );
-		if ( $statementListByPropertyId->isEmpty() ) {
+		$statementListByPropertyId = $statementList->getByPropertyId($propertyId);
+		if ($statementListByPropertyId->isEmpty()) {
 			return null;
 		} else {
 			return $statementListByPropertyId->toArray()[0];
@@ -52,14 +52,14 @@ 
 		PropertyId $propertyId,
 		EntityId $value
 	) {
-		$statementListByPropertyId = $statementList->getByPropertyId( $propertyId );
+		$statementListByPropertyId = $statementList->getByPropertyId($propertyId);
 		/** @var Statement $statement */
-		foreach ( $statementListByPropertyId as $statement ) {
+		foreach ($statementListByPropertyId as $statement) {
 			$snak = $statement->getMainSnak();
-			if ( $snak instanceof PropertyValueSnak ) {
+			if ($snak instanceof PropertyValueSnak) {
 				$dataValue = $snak->getDataValue();
-				if ( $dataValue instanceof EntityIdValue &&
-					$dataValue->getEntityId()->equals( $value )
+				if ($dataValue instanceof EntityIdValue &&
+					$dataValue->getEntityId()->equals($value)
 				) {
 					return $statement;
 				}
@@ -82,12 +82,12 @@ 
 		PropertyId $propertyId,
 		array $values
 	) {
-		$statementListByPropertyId = $statementList->getByPropertyId( $propertyId );
+		$statementListByPropertyId = $statementList->getByPropertyId($propertyId);
 		/** @var Statement $statement */
-		foreach ( $statementListByPropertyId as $statement ) {
+		foreach ($statementListByPropertyId as $statement) {
 			$snak = $statement->getMainSnak();
-			foreach ( $values as $value ) {
-				if ( $value->matchesSnak( $snak ) ) {
+			foreach ($values as $value) {
+				if ($value->matchesSnak($snak)) {
 					return $statement;
 				}
 			}

src/UpdateConstraintsTableJob.php

Spacing +18 added lines, -18 removed lines

@@ -26,8 +26,8 @@ 
 
 	const BATCH_SIZE = 10;
 
-	public static function newFromGlobalState( Title $title, array $params ) {
-		Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' );
+	public static function newFromGlobalState(Title $title, array $params) {
+		Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]');
 		$repo = WikibaseRepo::getDefaultInstance();
 		return new UpdateConstraintsTableJob(
 			$title,
@@ -83,7 +83,7 @@ 
 		EntityLookup $entityLookup,
 		Serializer $snakSerializer
 	) {
-		parent::__construct( 'constraintsTableUpdate', $title, $params );
+		parent::__construct('constraintsTableUpdate', $title, $params);
 
 		$this->propertyId = $propertyId;
 		$this->config = $config;
@@ -92,11 +92,11 @@ 
 		$this->snakSerializer = $snakSerializer;
 	}
 
-	public function extractParametersFromQualifiers( SnakList $qualifiers ) {
+	public function extractParametersFromQualifiers(SnakList $qualifiers) {
 		$parameters = [];
-		foreach ( $qualifiers as $qualifier ) {
+		foreach ($qualifiers as $qualifier) {
 			$qualifierId = $qualifier->getPropertyId()->getSerialization();
-			$paramSerialization = $this->snakSerializer->serialize( $qualifier );
+			$paramSerialization = $this->snakSerializer->serialize($qualifier);
 			$parameters[$qualifierId][] = $paramSerialization;
 		}
 		return $parameters;
@@ -108,7 +108,7 @@ 
 	) {
 		$constraintId = $constraintStatement->getGuid();
 		$constraintTypeQid = $constraintStatement->getMainSnak()->getDataValue()->getEntityId()->getSerialization();
-		$parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() );
+		$parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers());
 		return new Constraint(
 			$constraintId,
 			$propertyId,
@@ -123,17 +123,17 @@ 
 		PropertyId $propertyConstraintPropertyId
 	) {
 		$constraintsStatements = $property->getStatements()
-			->getByPropertyId( $propertyConstraintPropertyId )
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByPropertyId($propertyConstraintPropertyId)
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 		$constraints = [];
-		foreach ( $constraintsStatements->getIterator() as $constraintStatement ) {
-			$constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement );
-			if ( count( $constraints ) >= self::BATCH_SIZE ) {
-				$constraintRepo->insertBatch( $constraints );
+		foreach ($constraintsStatements->getIterator() as $constraintStatement) {
+			$constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement);
+			if (count($constraints) >= self::BATCH_SIZE) {
+				$constraintRepo->insertBatch($constraints);
 				$constraints = [];
 			}
 		}
-		$constraintRepo->insertBatch( $constraints );
+		$constraintRepo->insertBatch($constraints);
 	}
 
 	/**
@@ -144,15 +144,15 @@ 
 	public function run() {
 		// TODO in the future: only touch constraints affected by the edit (requires T163465)
 
-		$propertyId = new PropertyId( $this->propertyId );
-		$this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId( $propertyId );
+		$propertyId = new PropertyId($this->propertyId);
+		$this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId($propertyId);
 
 		/** @var Property $property */
-		$property = $this->entityLookup->getEntity( $propertyId );
+		$property = $this->entityLookup->getEntity($propertyId);
 		$this->importConstraintsForProperty(
 			$property,
 			$this->constraintRepo,
-			new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) )
+			new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId'))
 		);
 
 		return true;

src/Api/CachingResultsBuilder.php

Spacing +50 added lines, -51 removed lines

@@ -134,11 +134,11 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
 					$this->dataFactory->increment(
 						'wikibase.quality.constraints.cache.entity.hit'
 					);
@@ -147,20 +147,20 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
+		if ($entityIds !== [] || $claimIds !== []) {
 			$this->dataFactory->updateCount(
 				'wikibase.quality.constraints.cache.entity.miss',
-				count( $entityIds )
+				count($entityIds)
 			);
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses);
 			$results += $response->getArray();
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckConstraintsResponse(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -189,13 +189,13 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		if ( $claimIds !== [] ) {
+		if ($claimIds !== []) {
 			return false;
 		}
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( $statuses != $this->cachedStatuses ) {
+		if ($statuses != $this->cachedStatuses) {
 			return false;
 		}
 		return true;
@@ -214,17 +214,17 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		$results = $this->resultsBuilder->getResults( $entityIds, $claimIds, $constraintIds, $statuses );
+		$results = $this->resultsBuilder->getResults($entityIds, $claimIds, $constraintIds, $statuses);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
-			foreach ( $entityIds as $entityId ) {
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) {
+			foreach ($entityIds as $entityId) {
 				$value = [
 					'results' => $results->getArray()[$entityId->getSerialization()],
 					'latestRevisionIds' => $this->getLatestRevisionIds(
 						$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 					),
 				];
-				$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+				$this->cache->set($entityId, $value, $this->ttlInSeconds);
 			}
 		}
 
@@ -256,10 +256,10 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( $statuses != $this->cachedStatuses ) {
+		if ($statuses != $this->cachedStatuses) {
 			return false;
 		}
 		return true;
@@ -272,45 +272,44 @@ 
 	public function getStoredResults(
 		EntityId $entityId
 	) {
-		$value = $this->cache->get( $entityId, $curTTL, [], $asOf );
-		$now = call_user_func( $this->microtime, true );
+		$value = $this->cache->get($entityId, $curTTL, [], $asOf);
+		$now = call_user_func($this->microtime, true);
 
-		if ( $value === false ) {
+		if ($value === false) {
 			return null;
 		}
 
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
-		if ( is_array( $value['results'] ) ) {
-			array_walk( $value['results'], [ $this, 'updateCachingMetadata' ], $cachingMetadata );
+		if (is_array($value['results'])) {
+			array_walk($value['results'], [$this, 'updateCachingMetadata'], $cachingMetadata);
 		}
 
 		return new CachedCheckConstraintsResponse(
-			[ $entityId->getSerialization() => $value['results'] ],
+			[$entityId->getSerialization() => $value['results']],
 			array_reduce(
 				$dependedEntityIds,
-				function( Metadata $metadata, EntityId $entityId ) {
-					return Metadata::merge( [
+				function(Metadata $metadata, EntityId $entityId) {
+					return Metadata::merge([
 						$metadata,
 						Metadata::ofDependencyMetadata(
-							DependencyMetadata::ofEntityId( $entityId )
+							DependencyMetadata::ofEntityId($entityId)
 						)
-					] );
+					]);
 				},
-				Metadata::ofCachingMetadata( $cachingMetadata )
+				Metadata::ofCachingMetadata($cachingMetadata)
 			)
 		);
 	}
@@ -319,39 +318,39 @@ 
 	 * @param EntityId[] $entityIds
 	 * @return int[]
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
+	private function getLatestRevisionIds(array $entityIds) {
 		$revisionInformations = $this->wikiPageEntityMetaDataAccessor->loadRevisionInformation(
 			$entityIds,
 			EntityRevisionLookup::LATEST_FROM_REPLICA
 		);
 		$latestRevisionIds = [];
-		foreach ( $revisionInformations as $serialization => $revisionInformation ) {
+		foreach ($revisionInformations as $serialization => $revisionInformation) {
 			$latestRevisionIds[$serialization] = $revisionInformation->page_latest;
 		}
 		return $latestRevisionIds;
 	}
 
-	public function updateCachingMetadata( &$element, $key, CachingMetadata $cachingMetadata ) {
-		if ( $key === 'cached' ) {
-			$element = CachingMetadata::merge( [
+	public function updateCachingMetadata(&$element, $key, CachingMetadata $cachingMetadata) {
+		if ($key === 'cached') {
+			$element = CachingMetadata::merge([
 				$cachingMetadata,
-				CachingMetadata::ofArray( $element ),
-			] )->toArray();
+				CachingMetadata::ofArray($element),
+			])->toArray();
 		}
 		if (
-			is_array( $element ) &&
-			array_key_exists( 'constraint', $element ) &&
-			in_array( $element['constraint']['type'], $this->possiblyStaleConstraintTypes, true )
+			is_array($element) &&
+			array_key_exists('constraint', $element) &&
+			in_array($element['constraint']['type'], $this->possiblyStaleConstraintTypes, true)
 		) {
-			$element['cached'] = CachingMetadata::merge( [
+			$element['cached'] = CachingMetadata::merge([
 				$cachingMetadata,
 				CachingMetadata::ofArray(
-					array_key_exists( 'cached', $element ) ? $element['cached'] : null
+					array_key_exists('cached', $element) ? $element['cached'] : null
 				),
-			] )->toArray();
+			])->toArray();
 		}
-		if ( is_array( $element ) ) {
-			array_walk( $element, [ $this, __FUNCTION__ ], $cachingMetadata );
+		if (is_array($element)) {
+			array_walk($element, [$this, __FUNCTION__], $cachingMetadata);
 		}
 	}
 
@@ -360,7 +359,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/ConstraintCheck/Context/AbstractContext.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 	 */
 	protected $snak;
 
-	public function __construct( EntityDocument $entity, Snak $snak ) {
+	public function __construct(EntityDocument $entity, Snak $snak) {
 		$this->entity = $entity;
 		$this->snak = $snak;
 	}

src/ConstraintCheck/Context/QualifierContext.php

Spacing +9 added lines, -9 removed lines

@@ -23,7 +23,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -33,10 +33,10 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -44,25 +44,25 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'qualifiers', $statementArray ) ) {
+		if (!array_key_exists('qualifiers', $statementArray)) {
 			$statementArray['qualifiers'] = [];
 		}
 		$qualifiersArray = &$statementArray['qualifiers'];
 
 		$propertyId = $this->getSnak()->getPropertyId()->getSerialization();
-		if ( !array_key_exists( $propertyId, $qualifiersArray ) ) {
+		if (!array_key_exists($propertyId, $qualifiersArray)) {
 			$qualifiersArray[$propertyId] = [];
 		}
 		$propertyArray = &$qualifiersArray[$propertyId];
 
-		foreach ( $propertyArray as &$potentialQualifierArray ) {
-			if ( $potentialQualifierArray['hash'] === $this->getSnak()->getHash() ) {
+		foreach ($propertyArray as &$potentialQualifierArray) {
+			if ($potentialQualifierArray['hash'] === $this->getSnak()->getHash()) {
 				$qualifierArray = &$potentialQualifierArray;
 				break;
 			}
 		}
-		if ( !isset( $qualifierArray ) ) {
-			$qualifierArray = [ 'hash' => $this->getSnak()->getHash() ];
+		if (!isset($qualifierArray)) {
+			$qualifierArray = ['hash' => $this->getSnak()->getHash()];
 			$propertyArray[] = &$qualifierArray;
 		}
 

src/ConstraintCheck/Context/ReferenceContext.php

Spacing +13 added lines, -13 removed lines

@@ -30,7 +30,7 @@ 
 		Reference $reference,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 		$this->reference = $reference;
 	}
@@ -41,10 +41,10 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->reference->getSnaks();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -52,38 +52,38 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'references', $statementArray ) ) {
+		if (!array_key_exists('references', $statementArray)) {
 			$statementArray['references'] = [];
 		}
 		$referencesArray = &$statementArray['references'];
 
-		foreach ( $referencesArray as &$potentialReferenceArray ) {
-			if ( $potentialReferenceArray['hash'] === $this->reference->getHash() ) {
+		foreach ($referencesArray as &$potentialReferenceArray) {
+			if ($potentialReferenceArray['hash'] === $this->reference->getHash()) {
 				$referenceArray = &$potentialReferenceArray;
 				break;
 			}
 		}
-		if ( !isset( $referenceArray ) ) {
-			$referenceArray = [ 'hash' => $this->reference->getHash(), 'snaks' => [] ];
+		if (!isset($referenceArray)) {
+			$referenceArray = ['hash' => $this->reference->getHash(), 'snaks' => []];
 			$referencesArray[] = &$referenceArray;
 		}
 
 		$snaksArray = &$referenceArray['snaks'];
 
 		$propertyId = $this->getSnak()->getPropertyId()->getSerialization();
-		if ( !array_key_exists( $propertyId, $snaksArray ) ) {
+		if (!array_key_exists($propertyId, $snaksArray)) {
 			$snaksArray[$propertyId] = [];
 		}
 		$propertyArray = &$snaksArray[$propertyId];
 
-		foreach ( $propertyArray as &$potentialSnakArray ) {
-			if ( $potentialSnakArray['hash'] === $this->getSnak()->getHash() ) {
+		foreach ($propertyArray as &$potentialSnakArray) {
+			if ($potentialSnakArray['hash'] === $this->getSnak()->getHash()) {
 				$snakArray = &$potentialSnakArray;
 				break;
 			}
 		}
-		if ( !isset( $snakArray ) ) {
-			$snakArray = [ 'hash' => $this->getSnak()->getHash() ];
+		if (!isset($snakArray)) {
+			$snakArray = ['hash' => $this->getSnak()->getHash()];
 			$propertyArray[] = &$snakArray;
 		}
 

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +7 added lines, -7 removed lines

@@ -20,9 +20,9 @@ 
 	 */
 	private $statement;
 
-	public function __construct( EntityDocument $entity, Statement $statement ) {
-		Assert::parameterType( StatementListProvider::class, $entity, '$entity' );
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(EntityDocument $entity, Statement $statement) {
+		Assert::parameterType(StatementListProvider::class, $entity, '$entity');
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -43,11 +43,11 @@ 
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
 		return $statements
-			->getByRank( [ Statement::RANK_NORMAL, Statement::RANK_PREFERRED ] )
+			->getByRank([Statement::RANK_NORMAL, Statement::RANK_PREFERRED])
 			->getMainSnaks();
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -55,8 +55,8 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'mainsnak', $statementArray ) ) {
-			$statementArray['mainsnak'] = [ 'hash' => $this->statement->getMainSnak()->getHash() ];
+		if (!array_key_exists('mainsnak', $statementArray)) {
+			$statementArray['mainsnak'] = ['hash' => $this->statement->getMainSnak()->getHash()];
 		}
 		$mainsnakArray = &$statementArray['mainsnak'];