wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/TypeChecker.php

Spacing +22 added lines, -22 removed lines

@@ -83,34 +83,34 @@ 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE );
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$classes = $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$classes = $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$parameters['class'] = array_map(
-			function( $id ) {
-				return new ItemId( $id );
+			function($id) {
+				return new ItemId($id);
 			},
 			$classes
 		);
 
-		$relation = $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$relation = $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$relationIds = [];
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
 		}
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
 		}
-		$parameters['relation'] = [ $relation ];
+		$parameters['relation'] = [$relation];
 
 		$result = $this->typeCheckerHelper->hasClassInRelation(
 			$context->getEntity()->getStatements(),
@@ -118,7 +118,7 @@ 
 			$classes
 		);
 
-		if ( $result->getBool() ) {
+		if ($result->getBool()) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
@@ -132,21 +132,21 @@ 
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $result->getMetadata() );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($result->getMetadata());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/QualifierChecker.php

Spacing +6 added lines, -6 removed lines

@@ -47,16 +47,16 @@
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_QUALIFIER ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_QUALIFIER) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-qualifier' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-qualifier');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/MultiValueChecker.php

Spacing +7 added lines, -7 removed lines

@@ -55,9 +55,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$propertyId = $context->getSnak()->getPropertyId();
@@ -69,18 +69,18 @@ 
 			$propertyId
 		);
 
-		if ( $propertyCount <= 1 ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-multi-value' );
+		if ($propertyCount <= 1) {
+			$message = new ViolationMessage('wbqc-violation-message-multi-value');
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/ValueOnlyChecker.php

Spacing +6 added lines, -6 removed lines

@@ -36,16 +36,16 @@
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_STATEMENT ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_STATEMENT) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-valueOnly');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/ReferenceChecker.php

Spacing +6 added lines, -6 removed lines

@@ -36,16 +36,16 @@
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-reference');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/SingleValueChecker.php

Spacing +7 added lines, -7 removed lines

@@ -55,9 +55,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$propertyId = $context->getSnak()->getPropertyId();
@@ -69,18 +69,18 @@ 
 			$propertyId
 		);
 
-		if ( $propertyCount > 1 ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-single-value' );
+		if ($propertyCount > 1) {
+			$message = new ViolationMessage('wbqc-violation-message-single-value');
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php

Spacing +14 added lines, -14 removed lines

@@ -71,40 +71,40 @@
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
 		$status = CheckResult::STATUS_VIOLATION;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
+			if ($propertyId->equals($qualifier->getPropertyId())) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/QualifiersChecker.php

Spacing +19 added lines, -19 removed lines

@@ -71,53 +71,53 @@
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$properties = $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$properties = $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$parameters['property'] = $properties;
 
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
 			$allowedQualifier = false;
-			foreach ( $properties as $property ) {
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
+			foreach ($properties as $property) {
+				if ($qualifier->getPropertyId()->equals($property)) {
 					$allowedQualifier = true;
 					break;
 				}
 			}
-			if ( !$allowedQualifier ) {
-				if ( empty( $properties ) || $properties === [ '' ] ) {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+			if (!$allowedQualifier) {
+				if (empty($properties) || $properties === ['']) {
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 				} else {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
 				}
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/UniqueValueChecker.php

Spacing +16 added lines, -16 removed lines

@@ -74,22 +74,22 @@ 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
-		if ( $this->sparqlHelper !== null ) {
-			if ( $context->getType() === 'statement' ) {
+		if ($this->sparqlHelper !== null) {
+			if ($context->getType() === 'statement') {
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
 					$context->getSnakStatement(),
 					true // ignore deprecated statements
 				);
 			} else {
-				if ( $context->getSnak()->getType() !== 'value' ) {
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+				if ($context->getSnak()->getType() !== 'value') {
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -102,27 +102,27 @@ 
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}