Completed
Push — master ( d689cc...634f91 )
by
unknown
02:42
created
src/Api/CheckConstraintsRdf.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -39,13 +39,13 @@  discard block
 block discarded – undo
39 39
 		EntityIdLookup $entityIdLookup,
40 40
 		RdfVocabulary $rdfVocabulary
41 41
 	) {
42
-		parent::__construct( $page, $context );
42
+		parent::__construct($page, $context);
43 43
 		$this->resultsSource = $resultsSource;
44 44
 		$this->entityIdLookup = $entityIdLookup;
45 45
 		$this->rdfVocabulary = $rdfVocabulary;
46 46
 	}
47 47
 
48
-	public static function newFromGlobalState( Page $page, IContextSource $context = null ) {
48
+	public static function newFromGlobalState(Page $page, IContextSource $context = null) {
49 49
 		$repo = WikibaseRepo::getDefaultInstance();
50 50
 		$constraintReportFactory = ConstraintReportFactory::getDefaultInstance();
51 51
 
@@ -84,8 +84,8 @@  discard block
 block discarded – undo
84 84
 	 * @param string $guid
85 85
 	 * @return string
86 86
 	 */
87
-	private function cleanupGuid( $guid ) {
88
-		return preg_replace( '/[^\w-]/', '-', $guid );
87
+	private function cleanupGuid($guid) {
88
+		return preg_replace('/[^\w-]/', '-', $guid);
89 89
 	}
90 90
 
91 91
 	/**
@@ -97,51 +97,51 @@  discard block
 block discarded – undo
97 97
 		$response = $this->getRequest()->response();
98 98
 		$this->getOutput()->disable();
99 99
 
100
-		if ( !$this->resultsSource instanceof CachingResultsSource ) {
100
+		if (!$this->resultsSource instanceof CachingResultsSource) {
101 101
 			// TODO: make configurable whether only cached results are returned
102
-			$response->statusHeader( 501 ); // Not Implemented
102
+			$response->statusHeader(501); // Not Implemented
103 103
 			return null;
104 104
 		}
105 105
 
106
-		$entityId = $this->entityIdLookup->getEntityIdForTitle( $this->getTitle() );
107
-		if ( $entityId === null ) {
108
-			$response->statusHeader( 404 ); // Not Found
106
+		$entityId = $this->entityIdLookup->getEntityIdForTitle($this->getTitle());
107
+		if ($entityId === null) {
108
+			$response->statusHeader(404); // Not Found
109 109
 			return null;
110 110
 		}
111 111
 
112
-		$results = $this->resultsSource->getStoredResults( $entityId );
113
-		if ( $results === null ) {
114
-			$response->statusHeader( 204 ); // No Content
112
+		$results = $this->resultsSource->getStoredResults($entityId);
113
+		if ($results === null) {
114
+			$response->statusHeader(204); // No Content
115 115
 			return null;
116 116
 		}
117 117
 
118 118
 		$format = 'ttl'; // TODO: make format an option
119 119
 
120 120
 		$writerFactory = new RdfWriterFactory();
121
-		$formatName = $writerFactory->getFormatName( $format );
122
-		$contentType = $writerFactory->getMimeTypes( $formatName )[0];
121
+		$formatName = $writerFactory->getFormatName($format);
122
+		$contentType = $writerFactory->getMimeTypes($formatName)[0];
123 123
 
124
-		$response->header( "Content-Type: $contentType; charset=UTF-8" );
124
+		$response->header("Content-Type: $contentType; charset=UTF-8");
125 125
 
126
-		$writer = $writerFactory->getWriter( $formatName );
127
-		foreach ( [ RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY ] as $ns ) {
128
-			$writer->prefix( $ns, $this->rdfVocabulary->getNamespaceURI( $ns ) );
126
+		$writer = $writerFactory->getWriter($formatName);
127
+		foreach ([RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY] as $ns) {
128
+			$writer->prefix($ns, $this->rdfVocabulary->getNamespaceURI($ns));
129 129
 		}
130 130
 		$writer->start();
131 131
 
132
-		foreach ( $results->getArray() as $checkResult ) {
133
-			if ( $checkResult instanceof NullResult ) {
132
+		foreach ($results->getArray() as $checkResult) {
133
+			if ($checkResult instanceof NullResult) {
134 134
 				continue;
135 135
 			}
136
-			if ( $checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS ) {
136
+			if ($checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS) {
137 137
 				continue;
138 138
 			}
139 139
 
140
-			$writer->about( RdfVocabulary::NS_STATEMENT,
141
-				$this->cleanupGuid( $checkResult->getContextCursor()->getStatementGuid() ) )
142
-				->say( RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint' )
143
-				->is( RdfVocabulary::NS_STATEMENT,
144
-					$this->cleanupGuid( $checkResult->getConstraint()->getConstraintId() ) );
140
+			$writer->about(RdfVocabulary::NS_STATEMENT,
141
+				$this->cleanupGuid($checkResult->getContextCursor()->getStatementGuid()))
142
+				->say(RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint')
143
+				->is(RdfVocabulary::NS_STATEMENT,
144
+					$this->cleanupGuid($checkResult->getConstraint()->getConstraintId()));
145 145
 		}
146 146
 		$writer->finish();
147 147
 		echo $writer->drain();
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/SparqlHelper.php 1 patch
Spacing   +134 added lines, -136 removed lines patch added patch discarded remove patch
@@ -107,18 +107,18 @@  discard block
 block discarded – undo
107 107
 		$this->violationMessageDeserializer = $violationMessageDeserializer;
108 108
 		$this->dataFactory = $dataFactory;
109 109
 
110
-		$this->entityPrefix = $rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ENTITY );
110
+		$this->entityPrefix = $rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ENTITY);
111 111
 		$this->prefixes = <<<EOT
112
-PREFIX wd: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ENTITY )}>
113
-PREFIX wds: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_STATEMENT )}>
114
-PREFIX wdt: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_DIRECT_CLAIM )}>
115
-PREFIX wdv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_VALUE )}>
116
-PREFIX p: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_CLAIM )}>
117
-PREFIX ps: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_CLAIM_STATEMENT )}>
118
-PREFIX pq: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_QUALIFIER )}>
119
-PREFIX pqv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_QUALIFIER_VALUE )}>
120
-PREFIX pr: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_REFERENCE )}>
121
-PREFIX prv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_REFERENCE_VALUE )}>
112
+PREFIX wd: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ENTITY)}>
113
+PREFIX wds: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_STATEMENT)}>
114
+PREFIX wdt: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_DIRECT_CLAIM)}>
115
+PREFIX wdv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_VALUE)}>
116
+PREFIX p: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_CLAIM)}>
117
+PREFIX ps: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_CLAIM_STATEMENT)}>
118
+PREFIX pq: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_QUALIFIER)}>
119
+PREFIX pqv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_QUALIFIER_VALUE)}>
120
+PREFIX pr: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_REFERENCE)}>
121
+PREFIX prv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_REFERENCE_VALUE)}>
122 122
 PREFIX wikibase: <http://wikiba.se/ontology#>
123 123
 PREFIX wikibase-beta: <http://wikiba.se/ontology-beta#>
124 124
 EOT;
@@ -133,21 +133,21 @@  discard block
 block discarded – undo
133 133
 	 * @return CachedBool
134 134
 	 * @throws SparqlHelperException if the query times out or some other error occurs
135 135
 	 */
136
-	public function hasType( $id, array $classes, $withInstance ) {
137
-		$instanceOfId = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
138
-		$subclassOfId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
136
+	public function hasType($id, array $classes, $withInstance) {
137
+		$instanceOfId = $this->config->get('WBQualityConstraintsInstanceOfId');
138
+		$subclassOfId = $this->config->get('WBQualityConstraintsSubclassOfId');
139 139
 
140
-		$path = ( $withInstance ? "wdt:$instanceOfId/" : "" ) . "wdt:$subclassOfId*";
140
+		$path = ($withInstance ? "wdt:$instanceOfId/" : "")."wdt:$subclassOfId*";
141 141
 
142 142
 		$metadatas = [];
143 143
 
144
-		foreach ( array_chunk( $classes, 20 ) as $classesChunk ) {
145
-			$classesValues = implode( ' ', array_map(
146
-				function( $class ) {
147
-					return 'wd:' . $class;
144
+		foreach (array_chunk($classes, 20) as $classesChunk) {
145
+			$classesValues = implode(' ', array_map(
146
+				function($class) {
147
+					return 'wd:'.$class;
148 148
 				},
149 149
 				$classesChunk
150
-			) );
150
+			));
151 151
 
152 152
 			$query = <<<EOF
153 153
 ASK {
@@ -158,19 +158,19 @@  discard block
 block discarded – undo
158 158
 EOF;
159 159
 			// TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually
160 160
 
161
-			$result = $this->runQuery( $query );
161
+			$result = $this->runQuery($query);
162 162
 			$metadatas[] = $result->getMetadata();
163
-			if ( $result->getArray()['boolean'] ) {
163
+			if ($result->getArray()['boolean']) {
164 164
 				return new CachedBool(
165 165
 					true,
166
-					Metadata::merge( $metadatas )
166
+					Metadata::merge($metadatas)
167 167
 				);
168 168
 			}
169 169
 		}
170 170
 
171 171
 		return new CachedBool(
172 172
 			false,
173
-			Metadata::merge( $metadatas )
173
+			Metadata::merge($metadatas)
174 174
 		);
175 175
 	}
176 176
 
@@ -186,10 +186,10 @@  discard block
 block discarded – undo
186 186
 		$ignoreDeprecatedStatements
187 187
 	) {
188 188
 		$pid = $statement->getPropertyId()->serialize();
189
-		$guid = str_replace( '$', '-', $statement->getGuid() );
189
+		$guid = str_replace('$', '-', $statement->getGuid());
190 190
 
191 191
 		$deprecatedFilter = '';
192
-		if ( $ignoreDeprecatedStatements ) {
192
+		if ($ignoreDeprecatedStatements) {
193 193
 			$deprecatedFilter .= 'MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. }';
194 194
 			$deprecatedFilter .= 'MINUS { ?otherStatement wikibase-beta:rank wikibase-beta:DeprecatedRank. }';
195 195
 		}
@@ -209,9 +209,9 @@  discard block
 block discarded – undo
209 209
 LIMIT 10
210 210
 EOF;
211 211
 
212
-		$result = $this->runQuery( $query );
212
+		$result = $this->runQuery($query);
213 213
 
214
-		return $this->getOtherEntities( $result );
214
+		return $this->getOtherEntities($result);
215 215
 	}
216 216
 
217 217
 	/**
@@ -236,16 +236,15 @@  discard block
 block discarded – undo
236 236
 		$dataType = $this->propertyDataTypeLookup->getDataTypeIdForProperty(
237 237
 			$snak->getPropertyId()
238 238
 		);
239
-		list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType, $dataValue );
240
-		if ( $isFullValue ) {
239
+		list($value, $isFullValue) = $this->getRdfLiteral($dataType, $dataValue);
240
+		if ($isFullValue) {
241 241
 			$prefix .= 'v';
242 242
 		}
243 243
 		$path = $type === Context::TYPE_QUALIFIER ?
244
-			"$prefix:$pid" :
245
-			"prov:wasDerivedFrom/$prefix:$pid";
244
+			"$prefix:$pid" : "prov:wasDerivedFrom/$prefix:$pid";
246 245
 
247 246
 		$deprecatedFilter = '';
248
-		if ( $ignoreDeprecatedStatements ) {
247
+		if ($ignoreDeprecatedStatements) {
249 248
 			$deprecatedFilter = <<< EOF
250 249
   MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. }
251 250
   MINUS { ?otherStatement wikibase-beta:rank wikibase-beta:DeprecatedRank. }
@@ -266,9 +265,9 @@  discard block
 block discarded – undo
266 265
 LIMIT 10
267 266
 EOF;
268 267
 
269
-		$result = $this->runQuery( $query );
268
+		$result = $this->runQuery($query);
270 269
 
271
-		return $this->getOtherEntities( $result );
270
+		return $this->getOtherEntities($result);
272 271
 	}
273 272
 
274 273
 	/**
@@ -278,8 +277,8 @@  discard block
 block discarded – undo
278 277
 	 *
279 278
 	 * @return string
280 279
 	 */
281
-	private function stringLiteral( $text ) {
282
-		return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"';
280
+	private function stringLiteral($text) {
281
+		return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"';
283 282
 	}
284 283
 
285 284
 	/**
@@ -289,17 +288,17 @@  discard block
 block discarded – undo
289 288
 	 *
290 289
 	 * @return CachedEntityIds
291 290
 	 */
292
-	private function getOtherEntities( CachedQueryResults $results ) {
293
-		return new CachedEntityIds( array_map(
294
-			function ( $resultBindings ) {
291
+	private function getOtherEntities(CachedQueryResults $results) {
292
+		return new CachedEntityIds(array_map(
293
+			function($resultBindings) {
295 294
 				$entityIRI = $resultBindings['otherEntity']['value'];
296
-				$entityPrefixLength = strlen( $this->entityPrefix );
297
-				if ( substr( $entityIRI, 0, $entityPrefixLength ) === $this->entityPrefix ) {
295
+				$entityPrefixLength = strlen($this->entityPrefix);
296
+				if (substr($entityIRI, 0, $entityPrefixLength) === $this->entityPrefix) {
298 297
 					try {
299 298
 						return $this->entityIdParser->parse(
300
-							substr( $entityIRI, $entityPrefixLength )
299
+							substr($entityIRI, $entityPrefixLength)
301 300
 						);
302
-					} catch ( EntityIdParsingException $e ) {
301
+					} catch (EntityIdParsingException $e) {
303 302
 						// fall through
304 303
 					}
305 304
 				}
@@ -307,7 +306,7 @@  discard block
 block discarded – undo
307 306
 				return null;
308 307
 			},
309 308
 			$results->getArray()['results']['bindings']
310
-		), $results->getMetadata() );
309
+		), $results->getMetadata());
311 310
 	}
312 311
 
313 312
 	// @codingStandardsIgnoreStart cyclomatic complexity of this function is too high
@@ -320,47 +319,47 @@  discard block
 block discarded – undo
320 319
 	 * @return array the literal or IRI as a string in SPARQL syntax,
321 320
 	 * and a boolean indicating whether it refers to a full value node or not
322 321
 	 */
323
-	private function getRdfLiteral( $dataType, DataValue $dataValue ) {
324
-		switch ( $dataType ) {
322
+	private function getRdfLiteral($dataType, DataValue $dataValue) {
323
+		switch ($dataType) {
325 324
 			case 'string':
326 325
 			case 'external-id':
327
-				return [ $this->stringLiteral( $dataValue->getValue() ), false ];
326
+				return [$this->stringLiteral($dataValue->getValue()), false];
328 327
 			case 'commonsMedia':
329
-				$url = $this->rdfVocabulary->getMediaFileURI( $dataValue->getValue() );
330
-				return [ '<' . $url . '>', false ];
328
+				$url = $this->rdfVocabulary->getMediaFileURI($dataValue->getValue());
329
+				return ['<'.$url.'>', false];
331 330
 			case 'geo-shape':
332
-				$url = $this->rdfVocabulary->getGeoShapeURI( $dataValue->getValue() );
333
-				return [ '<' . $url . '>', false ];
331
+				$url = $this->rdfVocabulary->getGeoShapeURI($dataValue->getValue());
332
+				return ['<'.$url.'>', false];
334 333
 			case 'tabular-data':
335
-				$url = $this->rdfVocabulary->getTabularDataURI( $dataValue->getValue() );
336
-				return [ '<' . $url . '>', false ];
334
+				$url = $this->rdfVocabulary->getTabularDataURI($dataValue->getValue());
335
+				return ['<'.$url.'>', false];
337 336
 			case 'url':
338 337
 				$url = $dataValue->getValue();
339
-				if ( !preg_match( '/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url ) ) {
338
+				if (!preg_match('/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url)) {
340 339
 					// not a valid URL for SPARQL (see SPARQL spec, production 139 IRIREF)
341 340
 					// such an URL should never reach us, so just throw
342
-					throw new InvalidArgumentException( 'invalid URL: ' . $url );
341
+					throw new InvalidArgumentException('invalid URL: '.$url);
343 342
 				}
344
-				return [ '<' . $url . '>', false ];
343
+				return ['<'.$url.'>', false];
345 344
 			case 'wikibase-item':
346 345
 			case 'wikibase-property':
347 346
 				/** @var EntityIdValue $dataValue */
348
-				return [ 'wd:' . $dataValue->getEntityId()->getSerialization(), false ];
347
+				return ['wd:'.$dataValue->getEntityId()->getSerialization(), false];
349 348
 			case 'monolingualtext':
350 349
 				/** @var MonolingualTextValue $dataValue */
351 350
 				$lang = $dataValue->getLanguageCode();
352
-				if ( !preg_match( '/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang ) ) {
351
+				if (!preg_match('/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang)) {
353 352
 					// not a valid language tag for SPARQL (see SPARQL spec, production 145 LANGTAG)
354 353
 					// such a language tag should never reach us, so just throw
355
-					throw new InvalidArgumentException( 'invalid language tag: ' . $lang );
354
+					throw new InvalidArgumentException('invalid language tag: '.$lang);
356 355
 				}
357
-				return [ $this->stringLiteral( $dataValue->getText() ) . '@' . $lang, false ];
356
+				return [$this->stringLiteral($dataValue->getText()).'@'.$lang, false];
358 357
 			case 'globe-coordinate':
359 358
 			case 'quantity':
360 359
 			case 'time':
361
-				return [ 'wdv:' . $dataValue->getHash(), true ];
360
+				return ['wdv:'.$dataValue->getHash(), true];
362 361
 			default:
363
-				throw new InvalidArgumentException( 'unknown data type: ' . $dataType );
362
+				throw new InvalidArgumentException('unknown data type: '.$dataType);
364 363
 		}
365 364
 	}
366 365
 	// @codingStandardsIgnoreEnd
@@ -373,44 +372,44 @@  discard block
 block discarded – undo
373 372
 	 * @throws SparqlHelperException if the query times out or some other error occurs
374 373
 	 * @throws ConstraintParameterException if the $regex is invalid
375 374
 	 */
376
-	public function matchesRegularExpression( $text, $regex ) {
375
+	public function matchesRegularExpression($text, $regex) {
377 376
 		// caching wrapper around matchesRegularExpressionWithSparql
378 377
 
379
-		$textHash = hash( 'sha256', $text );
378
+		$textHash = hash('sha256', $text);
380 379
 		$cacheKey = $this->cache->makeKey(
381 380
 			'WikibaseQualityConstraints', // extension
382 381
 			'regex', // action
383 382
 			'WDQS-Java', // regex flavor
384
-			hash( 'sha256', $regex )
383
+			hash('sha256', $regex)
385 384
 		);
386
-		$cacheMapSize = $this->config->get( 'WBQualityConstraintsFormatCacheMapSize' );
385
+		$cacheMapSize = $this->config->get('WBQualityConstraintsFormatCacheMapSize');
387 386
 
388 387
 		$cacheMapArray = $this->cache->getWithSetCallback(
389 388
 			$cacheKey,
390 389
 			WANObjectCache::TTL_DAY,
391
-			function( $cacheMapArray ) use ( $text, $regex, $textHash, $cacheMapSize ) {
390
+			function($cacheMapArray) use ($text, $regex, $textHash, $cacheMapSize) {
392 391
 				// Initialize the cache map if not set
393
-				if ( $cacheMapArray === false ) {
392
+				if ($cacheMapArray === false) {
394 393
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.init';
395
-					$this->dataFactory->increment( $key );
394
+					$this->dataFactory->increment($key);
396 395
 					return [];
397 396
 				}
398 397
 
399 398
 				$key = 'wikibase.quality.constraints.regex.cache.refresh';
400
-				$this->dataFactory->increment( $key );
401
-				$cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $cacheMapSize );
402
-				if ( $cacheMap->has( $textHash ) ) {
399
+				$this->dataFactory->increment($key);
400
+				$cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $cacheMapSize);
401
+				if ($cacheMap->has($textHash)) {
403 402
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.hit';
404
-					$this->dataFactory->increment( $key );
405
-					$cacheMap->get( $textHash ); // ping cache
403
+					$this->dataFactory->increment($key);
404
+					$cacheMap->get($textHash); // ping cache
406 405
 				} else {
407 406
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.miss';
408
-					$this->dataFactory->increment( $key );
407
+					$this->dataFactory->increment($key);
409 408
 					try {
410
-						$matches = $this->matchesRegularExpressionWithSparql( $text, $regex );
411
-					} catch ( ConstraintParameterException $e ) {
412
-						$matches = $this->serializeConstraintParameterException( $e );
413
-					} catch ( SparqlHelperException $e ) {
409
+						$matches = $this->matchesRegularExpressionWithSparql($text, $regex);
410
+					} catch (ConstraintParameterException $e) {
411
+						$matches = $this->serializeConstraintParameterException($e);
412
+					} catch (SparqlHelperException $e) {
414 413
 						// don’t cache this
415 414
 						return $cacheMap->toArray();
416 415
 					}
@@ -434,42 +433,42 @@  discard block
 block discarded – undo
434 433
 			]
435 434
 		);
436 435
 
437
-		if ( isset( $cacheMapArray[$textHash] ) ) {
436
+		if (isset($cacheMapArray[$textHash])) {
438 437
 			$key = 'wikibase.quality.constraints.regex.cache.hit';
439
-			$this->dataFactory->increment( $key );
438
+			$this->dataFactory->increment($key);
440 439
 			$matches = $cacheMapArray[$textHash];
441
-			if ( is_bool( $matches ) ) {
440
+			if (is_bool($matches)) {
442 441
 				return $matches;
443
-			} elseif ( is_array( $matches ) &&
444
-				$matches['type'] == ConstraintParameterException::class ) {
445
-				throw $this->deserializeConstraintParameterException( $matches );
442
+			} elseif (is_array($matches) &&
443
+				$matches['type'] == ConstraintParameterException::class) {
444
+				throw $this->deserializeConstraintParameterException($matches);
446 445
 			} else {
447 446
 				throw new MWException(
448
-					'Value of unknown type in object cache (' .
449
-					'cache key: ' . $cacheKey . ', ' .
450
-					'cache map key: ' . $textHash . ', ' .
451
-					'value type: ' . gettype( $matches ) . ')'
447
+					'Value of unknown type in object cache ('.
448
+					'cache key: '.$cacheKey.', '.
449
+					'cache map key: '.$textHash.', '.
450
+					'value type: '.gettype($matches).')'
452 451
 				);
453 452
 			}
454 453
 		} else {
455 454
 			$key = 'wikibase.quality.constraints.regex.cache.miss';
456
-			$this->dataFactory->increment( $key );
457
-			return $this->matchesRegularExpressionWithSparql( $text, $regex );
455
+			$this->dataFactory->increment($key);
456
+			return $this->matchesRegularExpressionWithSparql($text, $regex);
458 457
 		}
459 458
 	}
460 459
 
461
-	private function serializeConstraintParameterException( ConstraintParameterException $cpe ) {
460
+	private function serializeConstraintParameterException(ConstraintParameterException $cpe) {
462 461
 		return [
463 462
 			'type' => ConstraintParameterException::class,
464
-			'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ),
463
+			'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()),
465 464
 		];
466 465
 	}
467 466
 
468
-	private function deserializeConstraintParameterException( array $serialization ) {
467
+	private function deserializeConstraintParameterException(array $serialization) {
469 468
 		$message = $this->violationMessageDeserializer->deserialize(
470 469
 			$serialization['violationMessage']
471 470
 		);
472
-		return new ConstraintParameterException( $message );
471
+		return new ConstraintParameterException($message);
473 472
 	}
474 473
 
475 474
 	/**
@@ -483,25 +482,25 @@  discard block
 block discarded – undo
483 482
 	 * @throws SparqlHelperException if the query times out or some other error occurs
484 483
 	 * @throws ConstraintParameterException if the $regex is invalid
485 484
 	 */
486
-	public function matchesRegularExpressionWithSparql( $text, $regex ) {
487
-		$textStringLiteral = $this->stringLiteral( $text );
488
-		$regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' );
485
+	public function matchesRegularExpressionWithSparql($text, $regex) {
486
+		$textStringLiteral = $this->stringLiteral($text);
487
+		$regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$');
489 488
 
490 489
 		$query = <<<EOF
491 490
 SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {}
492 491
 EOF;
493 492
 
494
-		$result = $this->runQuery( $query );
493
+		$result = $this->runQuery($query);
495 494
 
496 495
 		$vars = $result->getArray()['results']['bindings'][0];
497
-		if ( array_key_exists( 'matches', $vars ) ) {
496
+		if (array_key_exists('matches', $vars)) {
498 497
 			// true or false ⇒ regex okay, text matches or not
499 498
 			return $vars['matches']['value'] === 'true';
500 499
 		} else {
501 500
 			// empty result: regex broken
502 501
 			throw new ConstraintParameterException(
503
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
504
-					->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE )
502
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
503
+					->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE)
505 504
 			);
506 505
 		}
507 506
 	}
@@ -513,14 +512,14 @@  discard block
 block discarded – undo
513 512
 	 *
514 513
 	 * @return boolean
515 514
 	 */
516
-	public function isTimeout( $responseContent ) {
517
-		$timeoutRegex = implode( '|', array_map(
518
-			function ( $fqn ) {
519
-				return preg_quote( $fqn, '/' );
515
+	public function isTimeout($responseContent) {
516
+		$timeoutRegex = implode('|', array_map(
517
+			function($fqn) {
518
+				return preg_quote($fqn, '/');
520 519
 			},
521
-			$this->config->get( 'WBQualityConstraintsSparqlTimeoutExceptionClasses' )
522
-		) );
523
-		return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent );
520
+			$this->config->get('WBQualityConstraintsSparqlTimeoutExceptionClasses')
521
+		));
522
+		return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent);
524 523
 	}
525 524
 
526 525
 	/**
@@ -532,17 +531,17 @@  discard block
 block discarded – undo
532 531
 	 * @return integer|boolean the max-age (in seconds)
533 532
 	 * or a plain boolean if no max-age can be determined
534 533
 	 */
535
-	public function getCacheMaxAge( $responseHeaders ) {
534
+	public function getCacheMaxAge($responseHeaders) {
536 535
 		if (
537
-			array_key_exists( 'x-cache-status', $responseHeaders ) &&
538
-			preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] )
536
+			array_key_exists('x-cache-status', $responseHeaders) &&
537
+			preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0])
539 538
 		) {
540 539
 			$maxage = [];
541 540
 			if (
542
-				array_key_exists( 'cache-control', $responseHeaders ) &&
543
-				preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage )
541
+				array_key_exists('cache-control', $responseHeaders) &&
542
+				preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage)
544 543
 			) {
545
-				return intval( $maxage[1] );
544
+				return intval($maxage[1]);
546 545
 			} else {
547 546
 				return true;
548 547
 			}
@@ -560,59 +559,58 @@  discard block
 block discarded – undo
560 559
 	 *
561 560
 	 * @throws SparqlHelperException if the query times out or some other error occurs
562 561
 	 */
563
-	public function runQuery( $query ) {
562
+	public function runQuery($query) {
564 563
 
565
-		$endpoint = $this->config->get( 'WBQualityConstraintsSparqlEndpoint' );
566
-		$maxQueryTimeMillis = $this->config->get( 'WBQualityConstraintsSparqlMaxMillis' );
567
-		$url = $endpoint . '?' . http_build_query(
564
+		$endpoint = $this->config->get('WBQualityConstraintsSparqlEndpoint');
565
+		$maxQueryTimeMillis = $this->config->get('WBQualityConstraintsSparqlMaxMillis');
566
+		$url = $endpoint.'?'.http_build_query(
568 567
 			[
569
-				'query' => "#wbqc\n" . $this->prefixes . $query,
568
+				'query' => "#wbqc\n".$this->prefixes.$query,
570 569
 				'format' => 'json',
571 570
 				'maxQueryTimeMillis' => $maxQueryTimeMillis,
572 571
 			],
573
-			null, ini_get( 'arg_separator.output' ),
572
+			null, ini_get('arg_separator.output'),
574 573
 			// encode spaces with %20, not +
575 574
 			PHP_QUERY_RFC3986
576 575
 		);
577 576
 
578 577
 		$options = [
579 578
 			'method' => 'GET',
580
-			'timeout' => (int)round( ( $maxQueryTimeMillis + 1000 ) / 1000 ),
579
+			'timeout' => (int) round(($maxQueryTimeMillis + 1000) / 1000),
581 580
 			'connectTimeout' => 'default',
582 581
 		];
583
-		$request = MWHttpRequest::factory( $url, $options );
584
-		$startTime = microtime( true );
582
+		$request = MWHttpRequest::factory($url, $options);
583
+		$startTime = microtime(true);
585 584
 		$status = $request->execute();
586
-		$endTime = microtime( true );
585
+		$endTime = microtime(true);
587 586
 		$this->dataFactory->timing(
588 587
 			'wikibase.quality.constraints.sparql.timing',
589
-			( $endTime - $startTime ) * 1000
588
+			($endTime - $startTime) * 1000
590 589
 		);
591 590
 
592
-		$maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() );
593
-		if ( $maxAge ) {
594
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.cached' );
591
+		$maxAge = $this->getCacheMaxAge($request->getResponseHeaders());
592
+		if ($maxAge) {
593
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.cached');
595 594
 		}
596 595
 
597
-		if ( $status->isOK() ) {
596
+		if ($status->isOK()) {
598 597
 			$json = $request->getContent();
599
-			$arr = json_decode( $json, true );
598
+			$arr = json_decode($json, true);
600 599
 			return new CachedQueryResults(
601 600
 				$arr,
602 601
 				Metadata::ofCachingMetadata(
603 602
 					$maxAge ?
604
-						CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) :
605
-						CachingMetadata::fresh()
603
+						CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh()
606 604
 				)
607 605
 			);
608 606
 		} else {
609
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.error' );
607
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.error');
610 608
 
611 609
 			$this->dataFactory->increment(
612 610
 				"wikibase.quality.constraints.sparql.error.http.{$request->getStatus()}"
613 611
 			);
614 612
 
615
-			if ( $this->isTimeout( $request->getContent() ) ) {
613
+			if ($this->isTimeout($request->getContent())) {
616 614
 				$this->dataFactory->increment(
617 615
 					'wikibase.quality.constraints.sparql.error.timeout'
618 616
 				);
Please login to merge, or discard this patch.
src/ConstraintParameterRenderer.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -71,20 +71,20 @@  discard block
 block discarded – undo
71 71
 	 *
72 72
 	 * @return string HTML
73 73
 	 */
74
-	public function formatValue( $value ) {
75
-		if ( is_string( $value ) ) {
74
+	public function formatValue($value) {
75
+		if (is_string($value)) {
76 76
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
77 77
 			// strings
78
-			return htmlspecialchars( $value );
79
-		} elseif ( $value instanceof EntityId ) {
78
+			return htmlspecialchars($value);
79
+		} elseif ($value instanceof EntityId) {
80 80
 			// Cases like 'Conflicts with' 'property', to which we can link
81
-			return $this->formatEntityId( $value );
82
-		} elseif ( $value instanceof ItemIdSnakValue ) {
81
+			return $this->formatEntityId($value);
82
+		} elseif ($value instanceof ItemIdSnakValue) {
83 83
 			// Cases like EntityId but can also be somevalue or novalue
84
-			return $this->formatItemIdSnakValue( $value );
84
+			return $this->formatItemIdSnakValue($value);
85 85
 		} else {
86 86
 			// Cases where we format a DataValue
87
-			return $this->formatDataValue( $value );
87
+			return $this->formatDataValue($value);
88 88
 		}
89 89
 	}
90 90
 
@@ -95,23 +95,23 @@  discard block
 block discarded – undo
95 95
 	 *
96 96
 	 * @return string HTML
97 97
 	 */
98
-	public function formatParameters( $parameters ) {
99
-		if ( $parameters === null || $parameters === [] ) {
98
+	public function formatParameters($parameters) {
99
+		if ($parameters === null || $parameters === []) {
100 100
 			return null;
101 101
 		}
102 102
 
103
-		$valueFormatter = function ( $value ) {
104
-			return $this->formatValue( $value );
103
+		$valueFormatter = function($value) {
104
+			return $this->formatValue($value);
105 105
 		};
106 106
 
107 107
 		$formattedParameters = [];
108
-		foreach ( $parameters as $parameterName => $parameterValue ) {
109
-			$formattedParameterValues = implode( ', ',
110
-				$this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) );
111
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
108
+		foreach ($parameters as $parameterName => $parameterValue) {
109
+			$formattedParameterValues = implode(', ',
110
+				$this->limitArrayLength(array_map($valueFormatter, $parameterValue)));
111
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
112 112
 		}
113 113
 
114
-		return implode( '; ', $formattedParameters );
114
+		return implode('; ', $formattedParameters);
115 115
 	}
116 116
 
117 117
 	/**
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
121 121
 	 *
122 122
 	 * @return array
123 123
 	 */
124
-	private function limitArrayLength( array $array ) {
125
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
126
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
127
-			array_push( $array, '...' );
124
+	private function limitArrayLength(array $array) {
125
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
126
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
127
+			array_push($array, '...');
128 128
 		}
129 129
 
130 130
 		return $array;
@@ -134,16 +134,16 @@  discard block
 block discarded – undo
134 134
 	 * @param DataValue $value
135 135
 	 * @return string HTML
136 136
 	 */
137
-	public function formatDataValue( DataValue $value ) {
138
-		return $this->dataValueFormatter->format( $value );
137
+	public function formatDataValue(DataValue $value) {
138
+		return $this->dataValueFormatter->format($value);
139 139
 	}
140 140
 
141 141
 	/**
142 142
 	 * @param EntityId $entityId
143 143
 	 * @return string HTML
144 144
 	 */
145
-	public function formatEntityId( EntityId $entityId ) {
146
-		return $this->entityIdLabelFormatter->formatEntityId( $entityId );
145
+	public function formatEntityId(EntityId $entityId) {
146
+		return $this->entityIdLabelFormatter->formatEntityId($entityId);
147 147
 	}
148 148
 
149 149
 	/**
@@ -152,17 +152,17 @@  discard block
 block discarded – undo
152 152
 	 * @param ItemIdSnakValue $value
153 153
 	 * @return string HTML
154 154
 	 */
155
-	public function formatItemIdSnakValue( ItemIdSnakValue $value ) {
156
-		switch ( true ) {
155
+	public function formatItemIdSnakValue(ItemIdSnakValue $value) {
156
+		switch (true) {
157 157
 			case $value->isValue():
158
-				return $this->formatEntityId( $value->getItemId() );
158
+				return $this->formatEntityId($value->getItemId());
159 159
 			case $value->isSomeValue():
160 160
 				return $this->messageLocalizer
161
-					->msg( 'wikibase-snakview-snaktypeselector-somevalue' )
161
+					->msg('wikibase-snakview-snaktypeselector-somevalue')
162 162
 					->escaped();
163 163
 			case $value->isNoValue():
164 164
 				return $this->messageLocalizer
165
-					->msg( 'wikibase-snakview-snaktypeselector-novalue' )
165
+					->msg('wikibase-snakview-snaktypeselector-novalue')
166 166
 					->escaped();
167 167
 		}
168 168
 	}
Please login to merge, or discard this patch.
src/ServiceWiring.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -15,24 +15,24 @@  discard block
 block discarded – undo
15 15
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
16 16
 
17 17
 return [
18
-	ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) {
18
+	ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) {
19 19
 		return new LoggingHelper(
20 20
 			$services->getStatsdDataFactory(),
21
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
21
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
22 22
 			$services->getMainConfig()
23 23
 		);
24 24
 	},
25 25
 
26
-	ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) {
26
+	ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) {
27 27
 		return new ConstraintRepository();
28 28
 	},
29 29
 
30
-	ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) {
31
-		$constraintRepository = ConstraintsServices::getConstraintRepository( $services );
32
-		return new CachingConstraintLookup( $constraintRepository );
30
+	ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) {
31
+		$constraintRepository = ConstraintsServices::getConstraintRepository($services);
32
+		return new CachingConstraintLookup($constraintRepository);
33 33
 	},
34 34
 
35
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) {
35
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) {
36 36
 		return new CheckResultSerializer(
37 37
 			new ConstraintSerializer(
38 38
 				false // constraint parameters are not exposed
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 		);
44 44
 	},
45 45
 
46
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) {
46
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) {
47 47
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
48 48
 		$repo = WikibaseRepo::getDefaultInstance();
49 49
 		$entityIdParser = $repo->getEntityIdParser();
@@ -60,11 +60,11 @@  discard block
 block discarded – undo
60 60
 		);
61 61
 	},
62 62
 
63
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) {
63
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) {
64 64
 		return new ViolationMessageSerializer();
65 65
 	},
66 66
 
67
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) {
67
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) {
68 68
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
69 69
 		$repo = WikibaseRepo::getDefaultInstance();
70 70
 		$entityIdParser = $repo->getEntityIdParser();
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 		);
77 77
 	},
78 78
 
79
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) {
79
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) {
80 80
 		// TODO in the future, get DeserializerFactory and concept base URIs from $services?
81 81
 		$repo = WikibaseRepo::getDefaultInstance();
82 82
 		$deserializerFactory = $repo->getBaseDataModelDeserializerFactory();
Please login to merge, or discard this patch.
src/ConstraintsServices.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -24,75 +24,75 @@
 block discarded – undo
24 24
 	const VIOLATION_MESSAGE_DESERIALIZER = 'WBQC_ViolationMessageDeserializer';
25 25
 	const CONSTRAINT_PARAMETER_PARSER = 'WBQC_ConstraintParameterParser';
26 26
 
27
-	private static function getService( MediaWikiServices $services = null, $name ) {
28
-		if ( $services === null ) {
27
+	private static function getService(MediaWikiServices $services = null, $name) {
28
+		if ($services === null) {
29 29
 			$services = MediaWikiServices::getInstance();
30 30
 		}
31
-		return $services->getService( $name );
31
+		return $services->getService($name);
32 32
 	}
33 33
 
34 34
 	/**
35 35
 	 * @param MediaWikiServices|null $services
36 36
 	 * @return LoggingHelper
37 37
 	 */
38
-	public static function getLoggingHelper( MediaWikiServices $services = null ) {
39
-		return self::getService( $services, self::LOGGING_HELPER );
38
+	public static function getLoggingHelper(MediaWikiServices $services = null) {
39
+		return self::getService($services, self::LOGGING_HELPER);
40 40
 	}
41 41
 
42 42
 	/**
43 43
 	 * @param MediaWikiServices|null $services
44 44
 	 * @return ConstraintRepository
45 45
 	 */
46
-	public static function getConstraintRepository( MediaWikiServices $services = null ) {
47
-		return self::getService( $services, self::CONSTRAINT_REPOSITORY );
46
+	public static function getConstraintRepository(MediaWikiServices $services = null) {
47
+		return self::getService($services, self::CONSTRAINT_REPOSITORY);
48 48
 	}
49 49
 
50 50
 	/**
51 51
 	 * @param MediaWikiServices|null $services
52 52
 	 * @return ConstraintLookup
53 53
 	 */
54
-	public static function getConstraintLookup( MediaWikiServices $services = null ) {
55
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
54
+	public static function getConstraintLookup(MediaWikiServices $services = null) {
55
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
56 56
 	}
57 57
 
58 58
 	/**
59 59
 	 * @param MediaWikiServices|null $services
60 60
 	 * @return CheckResultSerializer
61 61
 	 */
62
-	public static function getCheckResultSerializer( MediaWikiServices $services = null ) {
63
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
62
+	public static function getCheckResultSerializer(MediaWikiServices $services = null) {
63
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
64 64
 	}
65 65
 
66 66
 	/**
67 67
 	 * @param MediaWikiServices|null $services
68 68
 	 * @return CheckResultDeserializer
69 69
 	 */
70
-	public static function getCheckResultDeserializer( MediaWikiServices $services = null ) {
71
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
70
+	public static function getCheckResultDeserializer(MediaWikiServices $services = null) {
71
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
72 72
 	}
73 73
 
74 74
 	/**
75 75
 	 * @param MediaWikiServices|null $services
76 76
 	 * @return ViolationMessageSerializer
77 77
 	 */
78
-	public static function getViolationMessageSerializer( MediaWikiServices $services = null ) {
79
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
78
+	public static function getViolationMessageSerializer(MediaWikiServices $services = null) {
79
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
80 80
 	}
81 81
 
82 82
 	/**
83 83
 	 * @param MediaWikiServices|null $services
84 84
 	 * @return ViolationMessageDeserializer
85 85
 	 */
86
-	public static function getViolationMessageDeserializer( MediaWikiServices $services = null ) {
87
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
86
+	public static function getViolationMessageDeserializer(MediaWikiServices $services = null) {
87
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
88 88
 	}
89 89
 
90 90
 	/**
91 91
 	 * @param MediaWikiServices|null $services
92 92
 	 * @return ConstraintParameterParser
93 93
 	 */
94
-	public static function getConstraintParameterParser( MediaWikiServices $services = null ) {
95
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
94
+	public static function getConstraintParameterParser(MediaWikiServices $services = null) {
95
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
96 96
 	}
97 97
 
98 98
 }
Please login to merge, or discard this patch.
src/Api/ResultsCache.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	 * @param WANObjectCache $cache
37 37
 	 * @param string $formatVersion The version of the API response format.
38 38
 	 */
39
-	public function __construct( WANObjectCache $cache, $formatVersion ) {
39
+	public function __construct(WANObjectCache $cache, $formatVersion) {
40 40
 		$this->cache = $cache;
41 41
 		$this->formatVersion = $formatVersion;
42 42
 	}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 * @param EntityId $entityId
46 46
 	 * @return string cache key
47 47
 	 */
48
-	public function makeKey( EntityId $entityId ) {
48
+	public function makeKey(EntityId $entityId) {
49 49
 		return $this->cache->makeKey(
50 50
 			'WikibaseQualityConstraints', // extension
51 51
 			'checkConstraints', // action
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	 * @param float &$asOf UNIX timestamp of cached value; null on failure [returned]
62 62
 	 * @return mixed
63 63
 	 */
64
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null ) {
65
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $asOf );
64
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null) {
65
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $asOf);
66 66
 	}
67 67
 
68 68
 	/**
@@ -72,16 +72,16 @@  discard block
 block discarded – undo
72 72
 	 * @param array $opts
73 73
 	 * @return bool
74 74
 	 */
75
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
76
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
75
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
76
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
77 77
 	}
78 78
 
79 79
 	/**
80 80
 	 * @param EntityId $key
81 81
 	 * @return bool
82 82
 	 */
83
-	public function delete( EntityId $key ) {
84
-		return $this->cache->delete( $this->makeKey( $key ) );
83
+	public function delete(EntityId $key) {
84
+		return $this->cache->delete($this->makeKey($key));
85 85
 	}
86 86
 
87 87
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessageRenderer.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -352,7 +352,6 @@  discard block
 block discarded – undo
352 352
 	}
353 353
 
354 354
 	/**
355
-	 * @param string[] $text Context::TYPE_* constants
356 355
 	 * @param string|null $role one of the Role::* constants
357 356
 	 * @return array[] list of parameters as accepted by Message::params()
358 357
 	 */
@@ -387,7 +386,6 @@  discard block
 block discarded – undo
387 386
 	}
388 387
 
389 388
 	/**
390
-	 * @param string[] $text Context::TYPE_* constants
391 389
 	 * @param string|null $role one of the Role::* constants
392 390
 	 * @return array[] list of parameters as accepted by Message::params()
393 391
 	 */
Please login to merge, or discard this patch.
Spacing   +82 added lines, -82 removed lines patch added patch discarded remove patch
@@ -78,17 +78,17 @@  discard block
 block discarded – undo
78 78
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
79 79
 	 * @return string
80 80
 	 */
81
-	public function render( ViolationMessage $violationMessage ) {
81
+	public function render(ViolationMessage $violationMessage) {
82 82
 		$messageKey = $violationMessage->getMessageKey();
83
-		$paramsLists = [ [] ];
84
-		foreach ( $violationMessage->getArguments() as $argument ) {
85
-			$params = $this->renderArgument( $argument );
83
+		$paramsLists = [[]];
84
+		foreach ($violationMessage->getArguments() as $argument) {
85
+			$params = $this->renderArgument($argument);
86 86
 			$paramsLists[] = $params;
87 87
 		}
88
-		$allParams = call_user_func_array( 'array_merge', $paramsLists );
88
+		$allParams = call_user_func_array('array_merge', $paramsLists);
89 89
 		return $this->messageLocalizer
90
-			->msg( $messageKey )
91
-			->params( $allParams )
90
+			->msg($messageKey)
91
+			->params($allParams)
92 92
 			->escaped();
93 93
 	}
94 94
 
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
 	 * @param string|null $role one of the Role::* constants
98 98
 	 * @return string HTML
99 99
 	 */
100
-	protected function addRole( $value, $role ) {
101
-		if ( $role === null ) {
100
+	protected function addRole($value, $role) {
101
+		if ($role === null) {
102 102
 			return $value;
103 103
 		}
104 104
 
105
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
106
-			$value .
105
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
106
+			$value.
107 107
 			'</span>';
108 108
 	}
109 109
 
@@ -111,15 +111,15 @@  discard block
 block discarded – undo
111 111
 	 * @param string $key message key
112 112
 	 * @return string HTML
113 113
 	 */
114
-	protected function msgEscaped( $key ) {
115
-		return $this->messageLocalizer->msg( $key )->escaped();
114
+	protected function msgEscaped($key) {
115
+		return $this->messageLocalizer->msg($key)->escaped();
116 116
 	}
117 117
 
118 118
 	/**
119 119
 	 * @param array $argument
120 120
 	 * @return array[] params (for Message::params)
121 121
 	 */
122
-	protected function renderArgument( array $argument ) {
122
+	protected function renderArgument(array $argument) {
123 123
 		$methods = [
124 124
 			ViolationMessage::TYPE_ENTITY_ID => 'renderEntityId',
125 125
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'renderEntityIdList',
@@ -139,12 +139,12 @@  discard block
 block discarded – undo
139 139
 		$value = $argument['value'];
140 140
 		$role = $argument['role'];
141 141
 
142
-		if ( array_key_exists( $type, $methods ) ) {
142
+		if (array_key_exists($type, $methods)) {
143 143
 			$method = $methods[$type];
144
-			$params = $this->$method( $value, $role );
144
+			$params = $this->$method($value, $role);
145 145
 		} else {
146 146
 			throw new InvalidArgumentException(
147
-				'Unknown ViolationMessage argument type ' . $type . '!'
147
+				'Unknown ViolationMessage argument type '.$type.'!'
148 148
 			);
149 149
 		}
150 150
 
@@ -158,46 +158,46 @@  discard block
 block discarded – undo
158 158
 	 * and return a single-element array with a raw message param (i. e. [ Message::rawParam( … ) ])
159 159
 	 * @return array[] list of parameters as accepted by Message::params()
160 160
 	 */
161
-	private function renderList( array $list, $role, callable $render ) {
162
-		if ( $list === [] ) {
161
+	private function renderList(array $list, $role, callable $render) {
162
+		if ($list === []) {
163 163
 			return [
164
-				Message::numParam( 0 ),
165
-				Message::rawParam( '<ul></ul>' ),
164
+				Message::numParam(0),
165
+				Message::rawParam('<ul></ul>'),
166 166
 			];
167 167
 		}
168 168
 
169
-		if ( count( $list ) > $this->maxListLength ) {
170
-			$list = array_slice( $list, 0, $this->maxListLength );
169
+		if (count($list) > $this->maxListLength) {
170
+			$list = array_slice($list, 0, $this->maxListLength);
171 171
 			$truncated = true;
172 172
 		}
173 173
 
174 174
 		$renderedParamsLists = array_map(
175 175
 			$render,
176 176
 			$list,
177
-			array_fill( 0, count( $list ), $role )
177
+			array_fill(0, count($list), $role)
178 178
 		);
179 179
 		$renderedParams = array_map(
180
-			function ( $params ) {
180
+			function($params) {
181 181
 				return $params[0];
182 182
 			},
183 183
 			$renderedParamsLists
184 184
 		);
185 185
 		$renderedElements = array_map(
186
-			function ( $param ) {
186
+			function($param) {
187 187
 				return $param['raw'];
188 188
 			},
189 189
 			$renderedParams
190 190
 		);
191
-		if ( isset( $truncated ) ) {
192
-			$renderedElements[] = $this->msgEscaped( 'ellipsis' );
191
+		if (isset($truncated)) {
192
+			$renderedElements[] = $this->msgEscaped('ellipsis');
193 193
 		}
194 194
 
195 195
 		return array_merge(
196 196
 			[
197
-				Message::numParam( count( $list ) ),
197
+				Message::numParam(count($list)),
198 198
 				Message::rawParam(
199
-					'<ul><li>' .
200
-					implode( '</li><li>', $renderedElements ) .
199
+					'<ul><li>'.
200
+					implode('</li><li>', $renderedElements).
201 201
 					'</li></ul>'
202 202
 				),
203 203
 			],
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 	 * @param string|null $role one of the Role::* constants
211 211
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
212 212
 	 */
213
-	private function renderEntityId( EntityId $entityId, $role ) {
214
-		return [ Message::rawParam( $this->addRole(
215
-			$this->entityIdFormatter->formatEntityId( $entityId ),
213
+	private function renderEntityId(EntityId $entityId, $role) {
214
+		return [Message::rawParam($this->addRole(
215
+			$this->entityIdFormatter->formatEntityId($entityId),
216 216
 			$role
217
-		) ) ];
217
+		))];
218 218
 	}
219 219
 
220 220
 	/**
@@ -222,8 +222,8 @@  discard block
 block discarded – undo
222 222
 	 * @param string|null $role one of the Role::* constants
223 223
 	 * @return array[] list of parameters as accepted by Message::params()
224 224
 	 */
225
-	private function renderEntityIdList( array $entityIdList, $role ) {
226
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
225
+	private function renderEntityIdList(array $entityIdList, $role) {
226
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
227 227
 	}
228 228
 
229 229
 	/**
@@ -231,24 +231,24 @@  discard block
 block discarded – undo
231 231
 	 * @param string|null $role one of the Role::* constants
232 232
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
233 233
 	 */
234
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, $role ) {
235
-		switch ( true ) {
234
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, $role) {
235
+		switch (true) {
236 236
 			case $value->isValue():
237
-				return $this->renderEntityId( $value->getItemId(), $role );
237
+				return $this->renderEntityId($value->getItemId(), $role);
238 238
 			case $value->isSomeValue():
239
-				return [ Message::rawParam( $this->addRole(
240
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
241
-						$this->msgEscaped( 'wikibase-snakview-snaktypeselector-somevalue' ) .
239
+				return [Message::rawParam($this->addRole(
240
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
241
+						$this->msgEscaped('wikibase-snakview-snaktypeselector-somevalue').
242 242
 						'</span>',
243 243
 					$role
244
-				) ) ];
244
+				))];
245 245
 			case $value->isNoValue():
246
-				return [ Message::rawParam( $this->addRole(
247
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
248
-					$this->msgEscaped( 'wikibase-snakview-snaktypeselector-novalue' ) .
246
+				return [Message::rawParam($this->addRole(
247
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
248
+					$this->msgEscaped('wikibase-snakview-snaktypeselector-novalue').
249 249
 						'</span>',
250 250
 					$role
251
-				) ) ];
251
+				))];
252 252
 			default:
253 253
 				// @codeCoverageIgnoreStart
254 254
 				throw new LogicException(
@@ -263,8 +263,8 @@  discard block
 block discarded – undo
263 263
 	 * @param string|null $role one of the Role::* constants
264 264
 	 * @return array[] list of parameters as accepted by Message::params()
265 265
 	 */
266
-	private function renderItemIdSnakValueList( array $valueList, $role ) {
267
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
266
+	private function renderItemIdSnakValueList(array $valueList, $role) {
267
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
268 268
 	}
269 269
 
270 270
 	/**
@@ -272,11 +272,11 @@  discard block
 block discarded – undo
272 272
 	 * @param string|null $role one of the Role::* constants
273 273
 	 * @return array[] list of parameters as accepted by Message::params()
274 274
 	 */
275
-	private function renderDataValue( DataValue $dataValue, $role ) {
276
-		return [ Message::rawParam( $this->addRole(
277
-			$this->dataValueFormatter->format( $dataValue ),
275
+	private function renderDataValue(DataValue $dataValue, $role) {
276
+		return [Message::rawParam($this->addRole(
277
+			$this->dataValueFormatter->format($dataValue),
278 278
 			$role
279
-		) ) ];
279
+		))];
280 280
 	}
281 281
 
282 282
 	/**
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 	 * @param string|null $role one of the Role::* constants
285 285
 	 * @return array[] list of parameters as accepted by Message::params()
286 286
 	 */
287
-	private function renderDataValueType( $dataValueType, $role ) {
287
+	private function renderDataValueType($dataValueType, $role) {
288 288
 		$messageKeys = [
289 289
 			'string' => 'datatypes-type-string',
290 290
 			'monolingualtext' => 'datatypes-type-monolingualtext',
@@ -293,15 +293,15 @@  discard block
 block discarded – undo
293 293
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
294 294
 		];
295 295
 
296
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
297
-			return [ Message::rawParam( $this->addRole(
298
-				$this->msgEscaped( $messageKeys[$dataValueType] ),
296
+		if (array_key_exists($dataValueType, $messageKeys)) {
297
+			return [Message::rawParam($this->addRole(
298
+				$this->msgEscaped($messageKeys[$dataValueType]),
299 299
 				$role
300
-			) ) ];
300
+			))];
301 301
 		} else {
302 302
 			// @codeCoverageIgnoreStart
303 303
 			throw new LogicException(
304
-				'Unknown data value type ' . $dataValueType
304
+				'Unknown data value type '.$dataValueType
305 305
 			);
306 306
 			// @codeCoverageIgnoreEnd
307 307
 		}
@@ -312,11 +312,11 @@  discard block
 block discarded – undo
312 312
 	 * @param string|null $role one of the Role::* constants
313 313
 	 * @return array[] list of parameters as accepted by Message::params()
314 314
 	 */
315
-	private function renderInlineCode( $code, $role ) {
316
-		return [ Message::rawParam( $this->addRole(
317
-			'<code>' . htmlspecialchars( $code ) . '</code>',
315
+	private function renderInlineCode($code, $role) {
316
+		return [Message::rawParam($this->addRole(
317
+			'<code>'.htmlspecialchars($code).'</code>',
318 318
 			$role
319
-		) ) ];
319
+		))];
320 320
 	}
321 321
 
322 322
 	/**
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
 	 * @param string|null $role one of the Role::* constants
325 325
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
326 326
 	 */
327
-	private function renderConstraintScope( $scope, $role ) {
328
-		switch ( $scope ) {
327
+	private function renderConstraintScope($scope, $role) {
328
+		switch ($scope) {
329 329
 			case Context::TYPE_STATEMENT:
330 330
 				$itemId = $this->config->get(
331 331
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -345,10 +345,10 @@  discard block
 block discarded – undo
345 345
 				// callers should never let this happen, but if it does happen,
346 346
 				// showing “unknown value” seems reasonable
347 347
 				// @codeCoverageIgnoreStart
348
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
348
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
349 349
 				// @codeCoverageIgnoreEnd
350 350
 		}
351
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
351
+		return $this->renderEntityId(new ItemId($itemId), $role);
352 352
 	}
353 353
 
354 354
 	/**
@@ -356,8 +356,8 @@  discard block
 block discarded – undo
356 356
 	 * @param string|null $role one of the Role::* constants
357 357
 	 * @return array[] list of parameters as accepted by Message::params()
358 358
 	 */
359
-	private function renderConstraintScopeList( array $scopeList, $role ) {
360
-		return $this->renderList( $scopeList, $role, [ $this, 'renderConstraintScope' ] );
359
+	private function renderConstraintScopeList(array $scopeList, $role) {
360
+		return $this->renderList($scopeList, $role, [$this, 'renderConstraintScope']);
361 361
 	}
362 362
 
363 363
 	/**
@@ -365,25 +365,25 @@  discard block
 block discarded – undo
365 365
 	 * @param string|null $role one of the Role::* constants
366 366
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
367 367
 	 */
368
-	private function renderPropertyScope( $scope, $role ) {
369
-		switch ( $scope ) {
368
+	private function renderPropertyScope($scope, $role) {
369
+		switch ($scope) {
370 370
 			case Context::TYPE_STATEMENT:
371
-				$itemId = $this->config->get( 'WBQualityConstraintsAsMainValueId' );
371
+				$itemId = $this->config->get('WBQualityConstraintsAsMainValueId');
372 372
 				break;
373 373
 			case Context::TYPE_QUALIFIER:
374
-				$itemId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' );
374
+				$itemId = $this->config->get('WBQualityConstraintsAsQualifiersId');
375 375
 				break;
376 376
 			case Context::TYPE_REFERENCE:
377
-				$itemId = $this->config->get( 'WBQualityConstraintsAsReferencesId' );
377
+				$itemId = $this->config->get('WBQualityConstraintsAsReferencesId');
378 378
 				break;
379 379
 			default:
380 380
 				// callers should never let this happen, but if it does happen,
381 381
 				// showing “unknown value” seems reasonable
382 382
 				// @codeCoverageIgnoreStart
383
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
383
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
384 384
 				// @codeCoverageIgnoreEnd
385 385
 		}
386
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
386
+		return $this->renderEntityId(new ItemId($itemId), $role);
387 387
 	}
388 388
 
389 389
 	/**
@@ -391,8 +391,8 @@  discard block
 block discarded – undo
391 391
 	 * @param string|null $role one of the Role::* constants
392 392
 	 * @return array[] list of parameters as accepted by Message::params()
393 393
 	 */
394
-	private function renderPropertyScopeList( array $scopeList, $role ) {
395
-		return $this->renderList( $scopeList, $role, [ $this, 'renderPropertyScope' ] );
394
+	private function renderPropertyScopeList(array $scopeList, $role) {
395
+		return $this->renderList($scopeList, $role, [$this, 'renderPropertyScope']);
396 396
 	}
397 397
 
398 398
 	/**
@@ -400,10 +400,10 @@  discard block
 block discarded – undo
400 400
 	 * @param string|null $role one of the Role::* constants
401 401
 	 * @return array[] list of parameters as accepted by Message::params()
402 402
 	 */
403
-	private function renderLanguage( $languageCode, $role ) {
403
+	private function renderLanguage($languageCode, $role) {
404 404
 		return [
405
-			Message::plaintextParam( Language::fetchLanguageName( $languageCode ) ),
406
-			Message::plaintextParam( $languageCode ),
405
+			Message::plaintextParam(Language::fetchLanguageName($languageCode)),
406
+			Message::plaintextParam($languageCode),
407 407
 		];
408 408
 	}
409 409
 
Please login to merge, or discard this patch.
src/ConstraintReportFactory.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	public static function getDefaultInstance() {
153 153
 		static $instance = null;
154 154
 
155
-		if ( $instance === null ) {
155
+		if ($instance === null) {
156 156
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
157 157
 			$config = MediaWikiServices::getInstance()->getMainConfig();
158 158
 			$titleParser = MediaWikiServices::getInstance()->getTitleParser();
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 	 * @return DelegatingConstraintChecker
205 205
 	 */
206 206
 	public function getConstraintChecker() {
207
-		if ( $this->delegatingConstraintChecker === null ) {
207
+		if ($this->delegatingConstraintChecker === null) {
208 208
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
209 209
 				$this->lookup,
210 210
 				$this->getConstraintCheckerMap(),
@@ -212,9 +212,9 @@  discard block
 block discarded – undo
212 212
 				ConstraintsServices::getConstraintParameterParser(),
213 213
 				$this->statementGuidParser,
214 214
 				ConstraintsServices::getLoggingHelper(),
215
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
216
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
217
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
215
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
216
+				$this->config->get('WBQualityConstraintsCheckReferences'),
217
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
218 218
 			);
219 219
 		}
220 220
 
@@ -225,10 +225,10 @@  discard block
 block discarded – undo
225 225
 	 * @return ConstraintChecker[]
226 226
 	 */
227 227
 	private function getConstraintCheckerMap() {
228
-		if ( $this->constraintCheckerMap === null ) {
228
+		if ($this->constraintCheckerMap === null) {
229 229
 			$connectionCheckerHelper = new ConnectionCheckerHelper();
230
-			$rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
231
-			if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
230
+			$rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
231
+			if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
232 232
 				$sparqlHelper = new SparqlHelper(
233 233
 					$this->config,
234 234
 					$this->rdfVocabulary,
@@ -250,120 +250,120 @@  discard block
 block discarded – undo
250 250
 			);
251 251
 
252 252
 			$this->constraintCheckerMap = [
253
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
253
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
254 254
 					=> new ConflictsWithChecker(
255 255
 						$this->lookup,
256 256
 						ConstraintsServices::getConstraintParameterParser(),
257 257
 						$connectionCheckerHelper
258 258
 					),
259
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
259
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
260 260
 					=> new ItemChecker(
261 261
 						$this->lookup,
262 262
 						ConstraintsServices::getConstraintParameterParser(),
263 263
 						$connectionCheckerHelper
264 264
 					),
265
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
265
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
266 266
 					=> new TargetRequiredClaimChecker(
267 267
 						$this->lookup,
268 268
 						ConstraintsServices::getConstraintParameterParser(),
269 269
 						$connectionCheckerHelper
270 270
 					),
271
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
271
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
272 272
 					=> new SymmetricChecker(
273 273
 						$this->lookup,
274 274
 						$connectionCheckerHelper
275 275
 					),
276
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
276
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
277 277
 					=> new InverseChecker(
278 278
 						$this->lookup,
279 279
 						ConstraintsServices::getConstraintParameterParser(),
280 280
 						$connectionCheckerHelper
281 281
 					),
282
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
282
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
283 283
 					=> new QualifierChecker(),
284
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
284
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
285 285
 					=> new QualifiersChecker(
286 286
 						ConstraintsServices::getConstraintParameterParser()
287 287
 					),
288
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
288
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
289 289
 					=> new MandatoryQualifiersChecker(
290 290
 						ConstraintsServices::getConstraintParameterParser()
291 291
 					),
292
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
292
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
293 293
 					=> new RangeChecker(
294 294
 						$this->propertyDataTypeLookup,
295 295
 						ConstraintsServices::getConstraintParameterParser(),
296 296
 						$rangeCheckerHelper
297 297
 					),
298
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
298
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
299 299
 					=> new DiffWithinRangeChecker(
300 300
 						ConstraintsServices::getConstraintParameterParser(),
301 301
 						$rangeCheckerHelper,
302 302
 						$this->config
303 303
 					),
304
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
304
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
305 305
 					=> new TypeChecker(
306 306
 						$this->lookup,
307 307
 						ConstraintsServices::getConstraintParameterParser(),
308 308
 						$typeCheckerHelper,
309 309
 						$this->config
310 310
 					),
311
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
311
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
312 312
 					=> new ValueTypeChecker(
313 313
 						$this->lookup,
314 314
 						ConstraintsServices::getConstraintParameterParser(),
315 315
 						$typeCheckerHelper,
316 316
 						$this->config
317 317
 					),
318
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
319
-					=> new SingleValueChecker( ConstraintsServices::getConstraintParameterParser() ),
320
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
321
-					=> new MultiValueChecker( ConstraintsServices::getConstraintParameterParser() ),
322
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
318
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
319
+					=> new SingleValueChecker(ConstraintsServices::getConstraintParameterParser()),
320
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
321
+					=> new MultiValueChecker(ConstraintsServices::getConstraintParameterParser()),
322
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
323 323
 					=> new UniqueValueChecker(
324 324
 						$sparqlHelper
325 325
 					),
326
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
326
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
327 327
 					=> new FormatChecker(
328 328
 						ConstraintsServices::getConstraintParameterParser(),
329 329
 						$this->config,
330 330
 						$sparqlHelper
331 331
 					),
332
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
332
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
333 333
 					=> new CommonsLinkChecker(
334 334
 						ConstraintsServices::getConstraintParameterParser(),
335 335
 						$this->titleParser
336 336
 					),
337
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
337
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
338 338
 					=> new OneOfChecker(
339 339
 						ConstraintsServices::getConstraintParameterParser()
340 340
 					),
341
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
341
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
342 342
 					=> new ValueOnlyChecker(),
343
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
343
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
344 344
 					=> new ReferenceChecker(),
345
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
345
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
346 346
 					=> new NoBoundsChecker(),
347
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
347
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
348 348
 					=> new AllowedUnitsChecker(
349 349
 						ConstraintsServices::getConstraintParameterParser(),
350 350
 						$this->unitConverter
351 351
 					),
352
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
353
-					=> new SingleBestValueChecker( ConstraintsServices::getConstraintParameterParser() ),
354
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
352
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
353
+					=> new SingleBestValueChecker(ConstraintsServices::getConstraintParameterParser()),
354
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
355 355
 					=> new EntityTypeChecker(
356 356
 						ConstraintsServices::getConstraintParameterParser()
357 357
 					),
358
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
358
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
359 359
 					=> new NoneOfChecker(
360 360
 						ConstraintsServices::getConstraintParameterParser()
361 361
 					),
362
-				$this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
362
+				$this->config->get('WBQualityConstraintsIntegerConstraintId')
363 363
 					=> new IntegerChecker(),
364
-				$this->config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
364
+				$this->config->get('WBQualityConstraintsCitationNeededConstraintId')
365 365
 					=> new CitationNeededChecker(),
366
-				$this->config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
366
+				$this->config->get('WBQualityConstraintsPropertyScopeConstraintId')
367 367
 					=> new PropertyScopeChecker(
368 368
 						ConstraintsServices::getConstraintParameterParser()
369 369
 					),
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 	 * @return WikiPageEntityMetaDataAccessor
378 378
 	 */
379 379
 	public function getWikiPageEntityMetaDataAccessor() {
380
-		if ( $this->wikiPageEntityMetaDataAccessor === null ) {
380
+		if ($this->wikiPageEntityMetaDataAccessor === null) {
381 381
 			$this->wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
382 382
 				$this->entityNamespaceLookup
383 383
 			);
@@ -390,12 +390,12 @@  discard block
 block discarded – undo
390 390
 	 * @return ResultsSource
391 391
 	 */
392 392
 	public function getResultsSource() {
393
-		if ( $this->resultsSource === null ) {
393
+		if ($this->resultsSource === null) {
394 394
 			$this->resultsSource = new CheckingResultsSource(
395 395
 				$this->getConstraintChecker()
396 396
 			);
397 397
 
398
-			if ( $this->config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
398
+			if ($this->config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
399 399
 				$this->resultsSource = new CachingResultsSource(
400 400
 					$this->resultsSource,
401 401
 					ResultsCache::getDefaultInstance(),
@@ -403,9 +403,9 @@  discard block
 block discarded – undo
403 403
 					ConstraintsServices::getCheckResultDeserializer(),
404 404
 					$this->getWikiPageEntityMetaDataAccessor(),
405 405
 					$this->entityIdParser,
406
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
406
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
407 407
 					$this->getPossiblyStaleConstraintTypes(),
408
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
408
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
409 409
 					ConstraintsServices::getLoggingHelper()
410 410
 				);
411 411
 			}
@@ -419,10 +419,10 @@  discard block
 block discarded – undo
419 419
 	 */
420 420
 	public function getPossiblyStaleConstraintTypes() {
421 421
 		return [
422
-			$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
423
-			$this->config->get( 'WBQualityConstraintsTypeConstraintId' ),
424
-			$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
425
-			$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
422
+			$this->config->get('WBQualityConstraintsCommonsLinkConstraintId'),
423
+			$this->config->get('WBQualityConstraintsTypeConstraintId'),
424
+			$this->config->get('WBQualityConstraintsValueTypeConstraintId'),
425
+			$this->config->get('WBQualityConstraintsDistinctValuesConstraintId'),
426 426
 		];
427 427
 	}
428 428
 
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/PropertyScopeChecker.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 		];
50 50
 	}
51 51
 
52
-	public function checkConstraint( Context $context, Constraint $constraint ) {
52
+	public function checkConstraint(Context $context, Constraint $constraint) {
53 53
 		$constraintParameters = $constraint->getConstraintParameters();
54 54
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
55 55
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 			$constraintTypeItemId
59 59
 		);
60 60
 
61
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
61
+		if (in_array($context->getType(), $allowedContextTypes)) {
62 62
 			return new CheckResult(
63 63
 				$context->getCursor(),
64 64
 				$constraint,
@@ -71,15 +71,15 @@  discard block
 block discarded – undo
71 71
 				$constraint,
72 72
 				[],
73 73
 				CheckResult::STATUS_VIOLATION,
74
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
75
-					->withEntityId( $context->getSnak()->getPropertyId() )
76
-					->withPropertyScope( $context->getType() )
77
-					->withPropertyScopeList( $allowedContextTypes )
74
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
75
+					->withEntityId($context->getSnak()->getPropertyId())
76
+					->withPropertyScope($context->getType())
77
+					->withPropertyScopeList($allowedContextTypes)
78 78
 			);
79 79
 		}
80 80
 	}
81 81
 
82
-	public function checkConstraintParameters( Constraint $constraint ) {
82
+	public function checkConstraintParameters(Constraint $constraint) {
83 83
 		$constraintParameters = $constraint->getConstraintParameters();
84 84
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
85 85
 		$exceptions = [];
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 				$constraintParameters,
89 89
 				$constraintTypeItemId
90 90
 			);
91
-		} catch ( ConstraintParameterException $e ) {
91
+		} catch (ConstraintParameterException $e) {
92 92
 			$exceptions[] = $e;
93 93
 		}
94 94
 		return $exceptions;
Please login to merge, or discard this patch.