Completed
Push — master ( e81170...f6b8f0 )
by
unknown
29s queued 15s
created
src/ConstraintCheck/Checker/CommonsLinkChecker.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker;
6 6
 
@@ -74,26 +74,26 @@  discard block
 block discarded – undo
74 74
 	 * @return array first element is the namespace number (default namespace for TitleParser),
75 75
 	 * second element is a string to prepend to the title before giving it to the TitleParser
76 76
 	 */
77
-	private function getCommonsNamespace( string $namespace ): array {
78
-		switch ( $namespace ) {
77
+	private function getCommonsNamespace(string $namespace): array {
78
+		switch ($namespace) {
79 79
 			case '':
80
-				return [ NS_MAIN, '' ];
80
+				return [NS_MAIN, ''];
81 81
 			// extra namespaces, see operations/mediawiki-config.git,
82 82
 			// wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey
83 83
 			case 'Creator':
84
-				return [ 100, '' ];
84
+				return [100, ''];
85 85
 			case 'TimedText':
86
-				return [ 102, '' ];
86
+				return [102, ''];
87 87
 			case 'Sequence':
88
-				return [ 104, '' ];
88
+				return [104, ''];
89 89
 			case 'Institution':
90
-				return [ 106, '' ];
90
+				return [106, ''];
91 91
 			// extension namespace, see mediawiki/extensions/JsonConfig.git,
92 92
 			// extension.json, 'namespaces' key, third element
93 93
 			case 'Data':
94
-				return [ 486, '' ];
94
+				return [486, ''];
95 95
 			default:
96
-				return [ NS_MAIN, $namespace . ':' ];
96
+				return [NS_MAIN, $namespace.':'];
97 97
 		}
98 98
 	}
99 99
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 *
103 103
 	 * @throws ConstraintParameterException
104 104
 	 */
105
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
105
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
106 106
 		$constraintParameters = $constraint->getConstraintParameters();
107 107
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
108 108
 
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
 
114 114
 		$snak = $context->getSnak();
115 115
 
116
-		if ( !$snak instanceof PropertyValueSnak ) {
116
+		if (!$snak instanceof PropertyValueSnak) {
117 117
 			// nothing to check
118
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
118
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
119 119
 		}
120 120
 
121 121
 		$dataValue = $snak->getDataValue();
@@ -125,52 +125,52 @@  discard block
 block discarded – undo
125 125
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
126 126
 		 *   parameter $namespace can be null, works for commons galleries
127 127
 		 */
128
-		if ( $dataValue->getType() !== 'string' ) {
129
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
130
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
131
-				->withDataValueType( 'string' );
132
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
128
+		if ($dataValue->getType() !== 'string') {
129
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
130
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
131
+				->withDataValueType('string');
132
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
133 133
 		}
134 134
 
135 135
 		$commonsLink = $dataValue->getValue();
136
-		if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
137
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
138
-				new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
136
+		if (!$this->commonsLinkIsWellFormed($commonsLink)) {
137
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
138
+				new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
139 139
 		}
140 140
 
141
-		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty( $snak->getPropertyId() );
142
-		switch ( $dataType ) {
141
+		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty($snak->getPropertyId());
142
+		switch ($dataType) {
143 143
 			case 'geo-shape':
144 144
 			case 'tabular-data':
145
-				if ( strpos( $commonsLink, $namespace . ':' ) !== 0 ) {
146
-					return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
147
-						new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
145
+				if (strpos($commonsLink, $namespace.':') !== 0) {
146
+					return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
147
+						new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
148 148
 				}
149 149
 				$pageName = $commonsLink;
150 150
 				break;
151 151
 			default:
152
-				$pageName = $namespace ? $namespace . ':' . $commonsLink : $commonsLink;
152
+				$pageName = $namespace ? $namespace.':'.$commonsLink : $commonsLink;
153 153
 				break;
154 154
 		}
155 155
 
156
-		$prefix = $this->getCommonsNamespace( $namespace )[1];
156
+		$prefix = $this->getCommonsNamespace($namespace)[1];
157 157
 		$normalizedTitle = $this->pageNameNormalizer->normalizePageName(
158 158
 			$pageName,
159 159
 			'https://commons.wikimedia.org/w/api.php'
160 160
 		);
161
-		if ( $normalizedTitle === false ) {
162
-			if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
163
-				return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
164
-					new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
161
+		if ($normalizedTitle === false) {
162
+			if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
163
+				return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
164
+					new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
165 165
 			}
166
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
167
-				new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ) );
166
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
167
+				new ViolationMessage('wbqc-violation-message-commons-link-no-existent'));
168 168
 		}
169 169
 
170
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE, null );
170
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE, null);
171 171
 	}
172 172
 
173
-	public function checkConstraintParameters( Constraint $constraint ): array {
173
+	public function checkConstraintParameters(Constraint $constraint): array {
174 174
 		$constraintParameters = $constraint->getConstraintParameters();
175 175
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
176 176
 		$exceptions = [];
@@ -179,15 +179,15 @@  discard block
 block discarded – undo
179 179
 				$constraintParameters,
180 180
 				$constraintTypeItemId
181 181
 			);
182
-		} catch ( ConstraintParameterException $e ) {
182
+		} catch (ConstraintParameterException $e) {
183 183
 			$exceptions[] = $e;
184 184
 		}
185 185
 		return $exceptions;
186 186
 	}
187 187
 
188
-	private function commonsLinkIsWellFormed( string $commonsLink ): bool {
189
-		$toReplace = [ "_", "%20" ];
190
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
188
+	private function commonsLinkIsWellFormed(string $commonsLink): bool {
189
+		$toReplace = ["_", "%20"];
190
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
191 191
 
192 192
 		return $commonsLink === $compareString;
193 193
 	}
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
196 196
 	 * Checks whether the value of the statement already includes the namespace.
197 197
 	 * This special case should be reported as “malformed title” instead of “title does not exist”.
198 198
 	 */
199
-	private function valueIncludesNamespace( string $value, string $namespace ): bool {
199
+	private function valueIncludesNamespace(string $value, string $namespace): bool {
200 200
 		return $namespace !== '' &&
201
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
201
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
202 202
 	}
203 203
 
204 204
 }
Please login to merge, or discard this patch.
src/Specials/SpecialConstraintReport.php 1 patch
Spacing   +82 added lines, -82 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\Specials;
6 6
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 		Config $config,
91 91
 		IBufferingStatsdDataFactory $dataFactory
92 92
 	) {
93
-		parent::__construct( 'ConstraintReport' );
93
+		parent::__construct('ConstraintReport');
94 94
 
95 95
 		$this->entityLookup = $entityLookup;
96 96
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
112 112
 			$language,
113
-			$languageFallbackChainFactory->newFromLanguage( $language ),
113
+			$languageFallbackChainFactory->newFromLanguage($language),
114 114
 			$this->getContext()
115 115
 		);
116 116
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * @inheritDoc
145 145
 	 */
146 146
 	public function getDescription() {
147
-		return $this->msg( 'wbqc-constraintreport' );
147
+		return $this->msg('wbqc-constraintreport');
148 148
 	}
149 149
 
150 150
 	/**
@@ -156,43 +156,43 @@  discard block
 block discarded – undo
156 156
 	 * @throws EntityIdParsingException
157 157
 	 * @throws UnexpectedValueException
158 158
 	 */
159
-	public function execute( $subPage ) {
159
+	public function execute($subPage) {
160 160
 		$out = $this->getOutput();
161 161
 
162
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
163
-		if ( $postRequest ) {
164
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
162
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
163
+		if ($postRequest) {
164
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
165 165
 			return;
166 166
 		}
167 167
 
168 168
 		$out->enableOOUI();
169
-		$out->addModules( $this->getModules() );
169
+		$out->addModules($this->getModules());
170 170
 
171 171
 		$this->setHeaders();
172 172
 
173
-		$out->addHTML( $this->getExplanationText() );
173
+		$out->addHTML($this->getExplanationText());
174 174
 		$this->buildEntityIdForm();
175 175
 
176
-		if ( !$subPage ) {
176
+		if (!$subPage) {
177 177
 			return;
178 178
 		}
179 179
 
180
-		if ( !is_string( $subPage ) ) {
181
-			throw new InvalidArgumentException( '$subPage must be string.' );
180
+		if (!is_string($subPage)) {
181
+			throw new InvalidArgumentException('$subPage must be string.');
182 182
 		}
183 183
 
184 184
 		try {
185
-			$entityId = $this->entityIdParser->parse( $subPage );
186
-		} catch ( EntityIdParsingException $e ) {
185
+			$entityId = $this->entityIdParser->parse($subPage);
186
+		} catch (EntityIdParsingException $e) {
187 187
 			$out->addHTML(
188
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
188
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
189 189
 			);
190 190
 			return;
191 191
 		}
192 192
 
193
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
193
+		if (!$this->entityLookup->hasEntity($entityId)) {
194 194
 			$out->addHTML(
195
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
195
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
196 196
 			);
197 197
 			return;
198 198
 		}
@@ -200,18 +200,18 @@  discard block
 block discarded – undo
200 200
 		$this->dataFactory->increment(
201 201
 			'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck'
202 202
 		);
203
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
203
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
204 204
 
205
-		if ( $results !== [] ) {
205
+		if ($results !== []) {
206 206
 			$out->addHTML(
207
-				$this->buildResultHeader( $entityId )
208
-				. $this->buildSummary( $results )
209
-				. $this->buildResultTable( $entityId, $results )
207
+				$this->buildResultHeader($entityId)
208
+				. $this->buildSummary($results)
209
+				. $this->buildResultTable($entityId, $results)
210 210
 			);
211 211
 		} else {
212 212
 			$out->addHTML(
213
-				$this->buildResultHeader( $entityId )
214
-				. $this->buildNotice( 'wbqc-constraintreport-empty-result' )
213
+				$this->buildResultHeader($entityId)
214
+				. $this->buildNotice('wbqc-constraintreport-empty-result')
215 215
 			);
216 216
 		}
217 217
 	}
@@ -227,15 +227,15 @@  discard block
 block discarded – undo
227 227
 				'name' => 'entityid',
228 228
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
229 229
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
230
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped(),
230
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped(),
231 231
 			],
232 232
 		];
233
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' );
234
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() );
235
-		$htmlForm->setSubmitCallback( static function () {
233
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form');
234
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped());
235
+		$htmlForm->setSubmitCallback(static function() {
236 236
 			return false;
237 237
 		} );
238
-		$htmlForm->setMethod( 'post' );
238
+		$htmlForm->setMethod('post');
239 239
 		$htmlForm->show();
240 240
 	}
241 241
 
@@ -249,9 +249,9 @@  discard block
 block discarded – undo
249 249
 	 *
250 250
 	 * @return string HTML
251 251
 	 */
252
-	private function buildNotice( string $messageKey, bool $error = false ): string {
252
+	private function buildNotice(string $messageKey, bool $error = false): string {
253 253
 		$cssClasses = 'wbqc-constraintreport-notice';
254
-		if ( $error ) {
254
+		if ($error) {
255 255
 			$cssClasses .= ' wbqc-constraintreport-notice-error';
256 256
 		}
257 257
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
 				[
261 261
 					'class' => $cssClasses,
262 262
 				],
263
-				$this->msg( $messageKey )->escaped()
263
+				$this->msg($messageKey)->escaped()
264 264
 			);
265 265
 	}
266 266
 
@@ -270,16 +270,16 @@  discard block
 block discarded – undo
270 270
 	private function getExplanationText(): string {
271 271
 		return Html::rawElement(
272 272
 			'div',
273
-			[ 'class' => 'wbqc-explanation' ],
273
+			['class' => 'wbqc-explanation'],
274 274
 			Html::rawElement(
275 275
 				'p',
276 276
 				[],
277
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped()
277
+				$this->msg('wbqc-constraintreport-explanation-part-one')->escaped()
278 278
 			)
279 279
 			. Html::rawElement(
280 280
 				'p',
281 281
 				[],
282
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped()
282
+				$this->msg('wbqc-constraintreport-explanation-part-two')->escaped()
283 283
 			)
284 284
 		);
285 285
 	}
@@ -290,31 +290,31 @@  discard block
 block discarded – undo
290 290
 	 *
291 291
 	 * @return string HTML
292 292
 	 */
293
-	private function buildResultTable( EntityId $entityId, array $results ): string {
293
+	private function buildResultTable(EntityId $entityId, array $results): string {
294 294
 		// Set table headers
295 295
 		$table = new HtmlTableBuilder(
296 296
 			[
297 297
 				new HtmlTableHeaderBuilder(
298
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(),
298
+					$this->msg('wbqc-constraintreport-result-table-header-status')->text(),
299 299
 					true
300 300
 				),
301 301
 				new HtmlTableHeaderBuilder(
302
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(),
302
+					$this->msg('wbqc-constraintreport-result-table-header-property')->text(),
303 303
 					true
304 304
 				),
305 305
 				new HtmlTableHeaderBuilder(
306
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(),
306
+					$this->msg('wbqc-constraintreport-result-table-header-message')->text(),
307 307
 					true
308 308
 				),
309 309
 				new HtmlTableHeaderBuilder(
310
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(),
310
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->text(),
311 311
 					true
312 312
 				),
313 313
 			]
314 314
 		);
315 315
 
316
-		foreach ( $results as $result ) {
317
-			$table = $this->appendToResultTable( $table, $entityId, $result );
316
+		foreach ($results as $result) {
317
+			$table = $this->appendToResultTable($table, $entityId, $result);
318 318
 		}
319 319
 
320 320
 		return $table->toHtml();
@@ -326,35 +326,35 @@  discard block
 block discarded – undo
326 326
 		CheckResult $result
327 327
 	): HtmlTableBuilder {
328 328
 		$message = $result->getMessage();
329
-		if ( $message === null ) {
329
+		if ($message === null) {
330 330
 			// no row for this result
331 331
 			return $table;
332 332
 		}
333 333
 
334 334
 		// Status column
335
-		$statusColumn = $this->formatStatus( $result->getStatus() );
335
+		$statusColumn = $this->formatStatus($result->getStatus());
336 336
 
337 337
 		// Property column
338
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
338
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
339 339
 		$propertyColumn = $this->getClaimLink(
340 340
 			$entityId,
341 341
 			$propertyId,
342
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
342
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
343 343
 		);
344 344
 
345 345
 		// Message column
346
-		$messageColumn = $this->violationMessageRenderer->render( $message );
346
+		$messageColumn = $this->violationMessageRenderer->render($message);
347 347
 
348 348
 		// Constraint column
349 349
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
350 350
 		try {
351
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
352
-		} catch ( InvalidArgumentException $e ) {
353
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
351
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
352
+		} catch (InvalidArgumentException $e) {
353
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
354 354
 		}
355 355
 		$constraintColumn = $this->getClaimLink(
356 356
 			$propertyId,
357
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
357
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
358 358
 			$constraintTypeLabel
359 359
 		);
360 360
 
@@ -362,16 +362,16 @@  discard block
 block discarded – undo
362 362
 		$table->appendRow(
363 363
 			[
364 364
 				new HtmlTableCellBuilder(
365
-					new HtmlArmor( $statusColumn )
365
+					new HtmlArmor($statusColumn)
366 366
 				),
367 367
 				new HtmlTableCellBuilder(
368
-					new HtmlArmor( $propertyColumn )
368
+					new HtmlArmor($propertyColumn)
369 369
 				),
370 370
 				new HtmlTableCellBuilder(
371
-					new HtmlArmor( $messageColumn )
371
+					new HtmlArmor($messageColumn)
372 372
 				),
373 373
 				new HtmlTableCellBuilder(
374
-					new HtmlArmor( $constraintColumn )
374
+					new HtmlArmor($constraintColumn)
375 375
 				),
376 376
 			]
377 377
 		);
@@ -386,15 +386,15 @@  discard block
 block discarded – undo
386 386
 	 *
387 387
 	 * @return string HTML
388 388
 	 */
389
-	protected function buildResultHeader( EntityId $entityId ): string {
390
-		$entityLink = sprintf( '%s (%s)',
391
-							   $this->entityIdLinkFormatter->formatEntityId( $entityId ),
392
-							   htmlspecialchars( $entityId->getSerialization() ) );
389
+	protected function buildResultHeader(EntityId $entityId): string {
390
+		$entityLink = sprintf('%s (%s)',
391
+							   $this->entityIdLinkFormatter->formatEntityId($entityId),
392
+							   htmlspecialchars($entityId->getSerialization()));
393 393
 
394 394
 		return Html::rawElement(
395 395
 			'h3',
396 396
 			[],
397
-			sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink )
397
+			sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink)
398 398
 		);
399 399
 	}
400 400
 
@@ -405,24 +405,24 @@  discard block
 block discarded – undo
405 405
 	 *
406 406
 	 * @return string HTML
407 407
 	 */
408
-	protected function buildSummary( array $results ): string {
408
+	protected function buildSummary(array $results): string {
409 409
 		$statuses = [];
410
-		foreach ( $results as $result ) {
411
-			$status = strtolower( $result->getStatus() );
412
-			$statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1;
410
+		foreach ($results as $result) {
411
+			$status = strtolower($result->getStatus());
412
+			$statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1;
413 413
 		}
414 414
 
415 415
 		$statusElements = [];
416
-		foreach ( $statuses as $status => $count ) {
417
-			if ( $count > 0 ) {
416
+		foreach ($statuses as $status => $count) {
417
+			if ($count > 0) {
418 418
 				$statusElements[] =
419
-					$this->formatStatus( $status )
419
+					$this->formatStatus($status)
420 420
 					. ': '
421 421
 					. $count;
422 422
 			}
423 423
 		}
424 424
 
425
-		return Html::rawElement( 'p', [], implode( ', ', $statusElements ) );
425
+		return Html::rawElement('p', [], implode(', ', $statusElements));
426 426
 	}
427 427
 
428 428
 	/**
@@ -434,8 +434,8 @@  discard block
 block discarded – undo
434 434
 	 *
435 435
 	 * @return string HTML
436 436
 	 */
437
-	private function formatStatus( string $status ): string {
438
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
437
+	private function formatStatus(string $status): string {
438
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
439 439
 		$statusIcons = [
440 440
 			CheckResult::STATUS_SUGGESTION => [
441 441
 				'icon' => 'suggestion-constraint-violation',
@@ -452,25 +452,25 @@  discard block
 block discarded – undo
452 452
 			],
453 453
 		];
454 454
 
455
-		if ( array_key_exists( $status, $statusIcons ) ) {
456
-			$iconWidget = new IconWidget( $statusIcons[$status] );
457
-			$iconHtml = $iconWidget->toString() . ' ';
455
+		if (array_key_exists($status, $statusIcons)) {
456
+			$iconWidget = new IconWidget($statusIcons[$status]);
457
+			$iconHtml = $iconWidget->toString().' ';
458 458
 		} else {
459 459
 			$iconHtml = '';
460 460
 		}
461 461
 
462
-		$labelWidget = new LabelWidget( [
463
-			'label' => $this->msg( $messageName )->text(),
464
-		] );
462
+		$labelWidget = new LabelWidget([
463
+			'label' => $this->msg($messageName)->text(),
464
+		]);
465 465
 		$labelHtml = $labelWidget->toString();
466 466
 
467 467
 		$formattedStatus =
468 468
 			Html::rawElement(
469 469
 				'span',
470 470
 				[
471
-					'class' => 'wbqc-status wbqc-status-' . $status,
471
+					'class' => 'wbqc-status wbqc-status-'.$status,
472 472
 				],
473
-				$iconHtml . $labelHtml
473
+				$iconHtml.$labelHtml
474 474
 			);
475 475
 
476 476
 		return $formattedStatus;
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 		return Html::rawElement(
494 494
 			'a',
495 495
 			[
496
-				'href' => $this->getClaimUrl( $entityId, $propertyId ),
496
+				'href' => $this->getClaimUrl($entityId, $propertyId),
497 497
 				'target' => '_blank',
498 498
 			],
499 499
 			$text
@@ -507,8 +507,8 @@  discard block
 block discarded – undo
507 507
 		EntityId $entityId,
508 508
 		NumericPropertyId $propertyId
509 509
 	): string {
510
-		$title = $this->entityTitleLookup->getTitleForId( $entityId );
511
-		$entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() );
510
+		$title = $this->entityTitleLookup->getTitleForId($entityId);
511
+		$entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization());
512 512
 
513 513
 		return $entityUrl;
514 514
 	}
Please login to merge, or discard this patch.
src/Html/HtmlTableHeaderBuilder.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @throws InvalidArgumentException
35 35
 	 */
36
-	public function __construct( $content, $isSortable = false ) {
37
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
38
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
36
+	public function __construct($content, $isSortable = false) {
37
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
38
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
39 39
 
40 40
 		$this->content = $content;
41 41
 		$this->isSortable = $isSortable;
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 * @return string HTML
46 46
 	 */
47 47
 	public function getContent() {
48
-		return HtmlArmor::getHtml( $this->content );
48
+		return HtmlArmor::getHtml($this->content);
49 49
 	}
50 50
 
51 51
 	/**
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
 	 * @return string HTML
62 62
 	 */
63 63
 	public function toHtml() {
64
-		$attributes = [ 'role' => 'columnheader button' ];
64
+		$attributes = ['role' => 'columnheader button'];
65 65
 
66
-		if ( !$this->isSortable ) {
66
+		if (!$this->isSortable) {
67 67
 			$attributes['class'] = 'unsortable';
68 68
 		}
69 69
 
70
-		return Html::rawElement( 'th', $attributes, $this->getContent() );
70
+		return Html::rawElement('th', $attributes, $this->getContent());
71 71
 	}
72 72
 
73 73
 }
Please login to merge, or discard this patch.
src/Html/HtmlTableBuilder.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @param array $headers
34 34
 	 */
35
-	public function __construct( array $headers ) {
36
-		foreach ( $headers as $header ) {
37
-			$this->addHeader( $header );
35
+	public function __construct(array $headers) {
36
+		foreach ($headers as $header) {
37
+			$this->addHeader($header);
38 38
 		}
39 39
 	}
40 40
 
@@ -43,16 +43,16 @@  discard block
 block discarded – undo
43 43
 	 *
44 44
 	 * @throws InvalidArgumentException
45 45
 	 */
46
-	private function addHeader( $header ) {
47
-		Assert::parameterType( [ 'string', HtmlTableHeaderBuilder::class ], $header, '$header' );
46
+	private function addHeader($header) {
47
+		Assert::parameterType(['string', HtmlTableHeaderBuilder::class], $header, '$header');
48 48
 
49
-		if ( is_string( $header ) ) {
50
-			$header = new HtmlTableHeaderBuilder( $header );
49
+		if (is_string($header)) {
50
+			$header = new HtmlTableHeaderBuilder($header);
51 51
 		}
52 52
 
53 53
 		$this->headers[] = $header;
54 54
 
55
-		if ( $header->getIsSortable() ) {
55
+		if ($header->getIsSortable()) {
56 56
 			$this->isSortable = true;
57 57
 		}
58 58
 	}
@@ -85,12 +85,12 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @throws InvalidArgumentException
87 87
 	 */
88
-	public function appendRow( array $cells ) {
89
-		foreach ( $cells as $key => $cell ) {
90
-			if ( is_string( $cell ) ) {
91
-				$cells[$key] = new HtmlTableCellBuilder( $cell );
92
-			} elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) {
93
-				throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' );
88
+	public function appendRow(array $cells) {
89
+		foreach ($cells as $key => $cell) {
90
+			if (is_string($cell)) {
91
+				$cells[$key] = new HtmlTableCellBuilder($cell);
92
+			} elseif (!($cell instanceof HtmlTableCellBuilder)) {
93
+				throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.');
94 94
 			}
95 95
 		}
96 96
 
@@ -104,13 +104,13 @@  discard block
 block discarded – undo
104 104
 	 *
105 105
 	 * @throws InvalidArgumentException
106 106
 	 */
107
-	public function appendRows( array $rows ) {
108
-		foreach ( $rows as $cells ) {
109
-			if ( !is_array( $cells ) ) {
110
-				throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' );
107
+	public function appendRows(array $rows) {
108
+		foreach ($rows as $cells) {
109
+			if (!is_array($cells)) {
110
+				throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.');
111 111
 			}
112 112
 
113
-			$this->appendRow( $cells );
113
+			$this->appendRow($cells);
114 114
 		}
115 115
 	}
116 116
 
@@ -122,38 +122,38 @@  discard block
 block discarded – undo
122 122
 	public function toHtml() {
123 123
 		// Open table
124 124
 		$tableClasses = 'wikitable';
125
-		if ( $this->isSortable ) {
125
+		if ($this->isSortable) {
126 126
 			$tableClasses .= ' sortable';
127 127
 		}
128
-		$html = Html::openElement( 'table', [ 'class' => $tableClasses ] );
128
+		$html = Html::openElement('table', ['class' => $tableClasses]);
129 129
 
130 130
 		// Write headers
131
-		$html .= Html::openElement( 'thead' );
132
-		$html .= Html::openElement( 'tr' );
133
-		foreach ( $this->headers as $header ) {
131
+		$html .= Html::openElement('thead');
132
+		$html .= Html::openElement('tr');
133
+		foreach ($this->headers as $header) {
134 134
 			$html .= $header->toHtml();
135 135
 		}
136
-		$html .= Html::closeElement( 'tr' );
137
-		$html .= Html::closeElement( 'thead' );
138
-		$html .= Html::openElement( 'tbody' );
136
+		$html .= Html::closeElement('tr');
137
+		$html .= Html::closeElement('thead');
138
+		$html .= Html::openElement('tbody');
139 139
 
140 140
 		// Write rows
141
-		foreach ( $this->rows as $row ) {
142
-			$html .= Html::openElement( 'tr' );
141
+		foreach ($this->rows as $row) {
142
+			$html .= Html::openElement('tr');
143 143
 
144 144
 			/**
145 145
 			 * @var HtmlTableCellBuilder $cell
146 146
 			 */
147
-			foreach ( $row as $cell ) {
147
+			foreach ($row as $cell) {
148 148
 				$html .= $cell->toHtml();
149 149
 			}
150 150
 
151
-			$html .= Html::closeElement( 'tr' );
151
+			$html .= Html::closeElement('tr');
152 152
 		}
153 153
 
154 154
 		// Close table
155
-		$html .= Html::closeElement( 'tbody' );
156
-		$html .= Html::closeElement( 'table' );
155
+		$html .= Html::closeElement('tbody');
156
+		$html .= Html::closeElement('table');
157 157
 
158 158
 		return $html;
159 159
 	}
Please login to merge, or discard this patch.
src/Html/HtmlTableCellBuilder.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
 	 *
32 32
 	 * @throws InvalidArgumentException
33 33
 	 */
34
-	public function __construct( $content, array $attributes = [] ) {
35
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
34
+	public function __construct($content, array $attributes = []) {
35
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
36 36
 
37 37
 		$this->content = $content;
38 38
 		$this->attributes = $attributes;
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 	 * @return string HTML
43 43
 	 */
44 44
 	public function getContent() {
45
-		return HtmlArmor::getHtml( $this->content );
45
+		return HtmlArmor::getHtml($this->content);
46 46
 	}
47 47
 
48 48
 	/**
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	 * @return string HTML
57 57
 	 */
58 58
 	public function toHtml() {
59
-		return Html::rawElement( 'td', $this->getAttributes(), $this->getContent() );
59
+		return Html::rawElement('td', $this->getAttributes(), $this->getContent());
60 60
 	}
61 61
 
62 62
 }
Please login to merge, or discard this patch.
src/WikibaseQualityConstraintsHooks.php 1 patch
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
 	BeforePageDisplayHook
27 27
 {
28 28
 
29
-	public static function onWikibaseChange( Change $change ) {
30
-		if ( !( $change instanceof EntityChange ) ) {
29
+	public static function onWikibaseChange(Change $change) {
30
+		if (!($change instanceof EntityChange)) {
31 31
 			return;
32 32
 		}
33 33
 		/** @var EntityChange $change */
@@ -38,48 +38,48 @@  discard block
 block discarded – undo
38 38
 
39 39
 		// If jobs are enabled and the results would be stored in some way run a job.
40 40
 		if (
41
-			$config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) &&
42
-			$config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) &&
41
+			$config->get('WBQualityConstraintsEnableConstraintsCheckJobs') &&
42
+			$config->get('WBQualityConstraintsCacheCheckConstraintsResults') &&
43 43
 			self::isSelectedForJobRunBasedOnPercentage()
44 44
 		) {
45
-			$params = [ 'entityId' => $change->getEntityId()->getSerialization() ];
45
+			$params = ['entityId' => $change->getEntityId()->getSerialization()];
46 46
 			$jobQueueGroup->lazyPush(
47
-				new JobSpecification( CheckConstraintsJob::COMMAND, $params )
47
+				new JobSpecification(CheckConstraintsJob::COMMAND, $params)
48 48
 			);
49 49
 		}
50 50
 
51
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
52
-			self::isConstraintStatementsChange( $config, $change )
51
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
52
+			self::isConstraintStatementsChange($config, $change)
53 53
 		) {
54
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
54
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
55 55
 			$metadata = $change->getMetadata();
56
-			if ( array_key_exists( 'rev_id', $metadata ) ) {
56
+			if (array_key_exists('rev_id', $metadata)) {
57 57
 				$params['revisionId'] = $metadata['rev_id'];
58 58
 			}
59 59
 			$jobQueueGroup->push(
60
-				new JobSpecification( 'constraintsTableUpdate', $params )
60
+				new JobSpecification('constraintsTableUpdate', $params)
61 61
 			);
62 62
 		}
63 63
 	}
64 64
 
65 65
 	private static function isSelectedForJobRunBasedOnPercentage() {
66 66
 		$config = MediaWikiServices::getInstance()->getMainConfig();
67
-		$percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' );
67
+		$percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio');
68 68
 
69
-		return mt_rand( 1, 100 ) <= $percentage;
69
+		return mt_rand(1, 100) <= $percentage;
70 70
 	}
71 71
 
72
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
73
-		if ( !( $change instanceof EntityChange ) ||
72
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
73
+		if (!($change instanceof EntityChange) ||
74 74
 			 $change->getAction() !== EntityChange::UPDATE ||
75
-			 !( $change->getEntityId() instanceof NumericPropertyId )
75
+			 !($change->getEntityId() instanceof NumericPropertyId)
76 76
 		) {
77 77
 			return false;
78 78
 		}
79 79
 
80 80
 		$info = $change->getInfo();
81 81
 
82
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
82
+		if (!array_key_exists('compactDiff', $info)) {
83 83
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
84 84
 			// so we only know that the change *might* affect the constraint statements
85 85
 			return true;
@@ -88,50 +88,50 @@  discard block
 block discarded – undo
88 88
 		/** @var EntityDiffChangedAspects $aspects */
89 89
 		$aspects = $info['compactDiff'];
90 90
 
91
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
92
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
91
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
92
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
93 93
 	}
94 94
 
95
-	public function onArticlePurge( $wikiPage ) {
95
+	public function onArticlePurge($wikiPage) {
96 96
 		$entityContentFactory = WikibaseRepo::getEntityContentFactory();
97
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
97
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
98 98
 			$entityIdLookup = WikibaseRepo::getEntityIdLookup();
99
-			$entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() );
100
-			if ( $entityId !== null ) {
99
+			$entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle());
100
+			if ($entityId !== null) {
101 101
 				$resultsCache = ResultsCache::getDefaultInstance();
102
-				$resultsCache->delete( $entityId );
102
+				$resultsCache->delete($entityId);
103 103
 			}
104 104
 		}
105 105
 	}
106 106
 
107
-	public function onBeforePageDisplay( $out, $skin ): void {
107
+	public function onBeforePageDisplay($out, $skin): void {
108 108
 		$lookup = WikibaseRepo::getEntityNamespaceLookup();
109 109
 		$title = $out->getTitle();
110
-		if ( $title === null ) {
110
+		if ($title === null) {
111 111
 			return;
112 112
 		}
113 113
 
114
-		if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) {
114
+		if (!$lookup->isNamespaceWithEntities($title->getNamespace())) {
115 115
 			return;
116 116
 		}
117
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
117
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
118 118
 			return;
119 119
 		}
120 120
 
121 121
 		$services = MediaWikiServices::getInstance();
122 122
 		$config = $services->getMainConfig();
123 123
 
124
-		$isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) &&
125
-			$services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView();
126
-		if ( $isMobileView ) {
124
+		$isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') &&
125
+			$services->getService('MobileFrontend.Context')->shouldDisplayMobileView();
126
+		if ($isMobileView) {
127 127
 			return;
128 128
 		}
129 129
 
130
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
130
+		$out->addModules('wikibase.quality.constraints.suggestions');
131 131
 
132
-		if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' )
133
-			|| $out->getUser()->isRegistered() ) {
134
-				$out->addModules( 'wikibase.quality.constraints.gadget' );
132
+		if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers')
133
+			|| $out->getUser()->isRegistered()) {
134
+				$out->addModules('wikibase.quality.constraints.gadget');
135 135
 		}
136 136
 	}
137 137
 
Please login to merge, or discard this patch.
src/WikibaseQualityConstraintsSchemaHooks.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -15,22 +15,22 @@
 block discarded – undo
15 15
 	/**
16 16
 	 * @param DatabaseUpdater $updater
17 17
 	 */
18
-	public function onLoadExtensionSchemaUpdates( $updater ) {
19
-		$dir = dirname( __DIR__ ) . '/sql/';
18
+	public function onLoadExtensionSchemaUpdates($updater) {
19
+		$dir = dirname(__DIR__).'/sql/';
20 20
 
21 21
 		$updater->addExtensionTable(
22 22
 			'wbqc_constraints',
23
-			$dir . "/{$updater->getDB()->getType()}/tables-generated.sql"
23
+			$dir."/{$updater->getDB()->getType()}/tables-generated.sql"
24 24
 		);
25 25
 		$updater->addExtensionField(
26 26
 			'wbqc_constraints',
27 27
 			'constraint_id',
28
-			$dir . '/patch-wbqc_constraints-constraint_id.sql'
28
+			$dir.'/patch-wbqc_constraints-constraint_id.sql'
29 29
 		);
30 30
 		$updater->addExtensionIndex(
31 31
 			'wbqc_constraints',
32 32
 			'wbqc_constraints_guid_uniq',
33
-			$dir . '/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
33
+			$dir.'/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
34 34
 		);
35 35
 	}
36 36
 
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
 	 * @throws ConstraintParameterException
68 68
 	 * @return CheckResult
69 69
 	 */
70
-	public function checkConstraint( Context $context, Constraint $constraint ) {
71
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
70
+	public function checkConstraint(Context $context, Constraint $constraint) {
71
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
72
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
73 73
 		}
74 74
 
75 75
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -84,33 +84,33 @@  discard block
 block discarded – undo
84 84
 		$status = CheckResult::STATUS_COMPLIANCE;
85 85
 
86 86
 		/** @var Snak $qualifier */
87
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
87
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
88 88
 			$allowedQualifier = false;
89
-			foreach ( $properties as $property ) {
90
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
89
+			foreach ($properties as $property) {
90
+				if ($qualifier->getPropertyId()->equals($property)) {
91 91
 					$allowedQualifier = true;
92 92
 					break;
93 93
 				}
94 94
 			}
95
-			if ( !$allowedQualifier ) {
96
-				if ( $properties === [] || $properties === [ '' ] ) {
97
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
98
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
95
+			if (!$allowedQualifier) {
96
+				if ($properties === [] || $properties === ['']) {
97
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
98
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
99 99
 				} else {
100
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
101
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
102
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
103
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
100
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
101
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
102
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
103
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
104 104
 				}
105 105
 				$status = CheckResult::STATUS_VIOLATION;
106 106
 				break;
107 107
 			}
108 108
 		}
109 109
 
110
-		return new CheckResult( $context, $constraint, $status, $message );
110
+		return new CheckResult($context, $constraint, $status, $message);
111 111
 	}
112 112
 
113
-	public function checkConstraintParameters( Constraint $constraint ) {
113
+	public function checkConstraintParameters(Constraint $constraint) {
114 114
 		$constraintParameters = $constraint->getConstraintParameters();
115 115
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
116 116
 		$exceptions = [];
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 				$constraintParameters,
120 120
 				$constraintTypeItemId
121 121
 			);
122
-		} catch ( ConstraintParameterException $e ) {
122
+		} catch (ConstraintParameterException $e) {
123 123
 			$exceptions[] = $e;
124 124
 		}
125 125
 		return $exceptions;
Please login to merge, or discard this patch.
src/Api/CheckConstraintParameters.php 1 patch
Spacing   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\Api;
6 6
 
@@ -79,9 +79,9 @@  discard block
 block discarded – undo
79 79
 		StatementGuidParser $statementGuidParser,
80 80
 		IBufferingStatsdDataFactory $dataFactory
81 81
 	) {
82
-		parent::__construct( $main, $name );
82
+		parent::__construct($main, $name);
83 83
 
84
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
84
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
85 85
 		$this->languageFallbackChainFactory = $languageFallbackChainFactory;
86 86
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
87 87
 		$this->violationMessageRendererFactory = $violationMessageRendererFactory;
@@ -97,39 +97,39 @@  discard block
 block discarded – undo
97 97
 		$params = $this->extractRequestParams();
98 98
 		$result = $this->getResult();
99 99
 
100
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
101
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
100
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
101
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
102 102
 
103
-		$this->checkPropertyIds( $propertyIds, $result );
104
-		$this->checkConstraintIds( $constraintIds, $result );
103
+		$this->checkPropertyIds($propertyIds, $result);
104
+		$this->checkConstraintIds($constraintIds, $result);
105 105
 
106
-		$result->addValue( null, 'success', 1 );
106
+		$result->addValue(null, 'success', 1);
107 107
 	}
108 108
 
109 109
 	/**
110 110
 	 * @param array|null $propertyIdSerializations
111 111
 	 * @return NumericPropertyId[]
112 112
 	 */
113
-	private function parsePropertyIds( ?array $propertyIdSerializations ): array {
114
-		if ( $propertyIdSerializations === null ) {
113
+	private function parsePropertyIds(?array $propertyIdSerializations): array {
114
+		if ($propertyIdSerializations === null) {
115 115
 			return [];
116
-		} elseif ( $propertyIdSerializations === [] ) {
116
+		} elseif ($propertyIdSerializations === []) {
117 117
 			$this->apiErrorReporter->dieError(
118
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
118
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
119 119
 				'no-data'
120 120
 			);
121 121
 		}
122 122
 
123 123
 		return array_map(
124
-			function ( $propertyIdSerialization ) {
124
+			function($propertyIdSerialization) {
125 125
 				try {
126
-					return new NumericPropertyId( $propertyIdSerialization );
127
-				} catch ( InvalidArgumentException $e ) {
126
+					return new NumericPropertyId($propertyIdSerialization);
127
+				} catch (InvalidArgumentException $e) {
128 128
 					$this->apiErrorReporter->dieError(
129 129
 						"Invalid id: $propertyIdSerialization",
130 130
 						'invalid-property-id',
131 131
 						0, // default argument
132
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
132
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
133 133
 					);
134 134
 				}
135 135
 			},
@@ -141,35 +141,35 @@  discard block
 block discarded – undo
141 141
 	 * @param array|null $constraintIds
142 142
 	 * @return string[]
143 143
 	 */
144
-	private function parseConstraintIds( ?array $constraintIds ): array {
145
-		if ( $constraintIds === null ) {
144
+	private function parseConstraintIds(?array $constraintIds): array {
145
+		if ($constraintIds === null) {
146 146
 			return [];
147
-		} elseif ( $constraintIds === [] ) {
147
+		} elseif ($constraintIds === []) {
148 148
 			$this->apiErrorReporter->dieError(
149
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
149
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
150 150
 				'no-data'
151 151
 			);
152 152
 		}
153 153
 
154 154
 		return array_map(
155
-			function ( $constraintId ) {
155
+			function($constraintId) {
156 156
 				try {
157
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
158
-					if ( !$propertyId instanceof NumericPropertyId ) {
157
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
158
+					if (!$propertyId instanceof NumericPropertyId) {
159 159
 						$this->apiErrorReporter->dieError(
160 160
 							"Invalid property ID: {$propertyId->getSerialization()}",
161 161
 							'invalid-property-id',
162 162
 							0, // default argument
163
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
163
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
164 164
 						);
165 165
 					}
166 166
 					return $constraintId;
167
-				} catch ( StatementGuidParsingException $e ) {
167
+				} catch (StatementGuidParsingException $e) {
168 168
 					$this->apiErrorReporter->dieError(
169 169
 						"Invalid statement GUID: $constraintId",
170 170
 						'invalid-guid',
171 171
 						0, // default argument
172
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
172
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
173 173
 					);
174 174
 				}
175 175
 			},
@@ -181,12 +181,12 @@  discard block
 block discarded – undo
181 181
 	 * @param NumericPropertyId[] $propertyIds
182 182
 	 * @param ApiResult $result
183 183
 	 */
184
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ): void {
185
-		foreach ( $propertyIds as $propertyId ) {
186
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
184
+	private function checkPropertyIds(array $propertyIds, ApiResult $result): void {
185
+		foreach ($propertyIds as $propertyId) {
186
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
187 187
 			$allConstraintExceptions = $this->delegatingConstraintChecker
188
-				->checkConstraintParametersOnPropertyId( $propertyId );
189
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
188
+				->checkConstraintParametersOnPropertyId($propertyId);
189
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
190 190
 				$this->addConstraintParameterExceptionsToResult(
191 191
 					$constraintId,
192 192
 					$constraintParameterExceptions,
@@ -200,15 +200,15 @@  discard block
 block discarded – undo
200 200
 	 * @param string[] $constraintIds
201 201
 	 * @param ApiResult $result
202 202
 	 */
203
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ): void {
204
-		foreach ( $constraintIds as $constraintId ) {
205
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
203
+	private function checkConstraintIds(array $constraintIds, ApiResult $result): void {
204
+		foreach ($constraintIds as $constraintId) {
205
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
206 206
 				// already checked as part of checkPropertyIds()
207 207
 				continue;
208 208
 			}
209 209
 			$constraintParameterExceptions = $this->delegatingConstraintChecker
210
-				->checkConstraintParametersOnConstraintId( $constraintId );
211
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
210
+				->checkConstraintParametersOnConstraintId($constraintId);
211
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
212 212
 		}
213 213
 	}
214 214
 
@@ -216,18 +216,18 @@  discard block
 block discarded – undo
216 216
 	 * @param NumericPropertyId $propertyId
217 217
 	 * @return string[]
218 218
 	 */
219
-	private function getResultPathForPropertyId( NumericPropertyId $propertyId ): array {
220
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
219
+	private function getResultPathForPropertyId(NumericPropertyId $propertyId): array {
220
+		return [$this->getModuleName(), $propertyId->getSerialization()];
221 221
 	}
222 222
 
223 223
 	/**
224 224
 	 * @param string $constraintId
225 225
 	 * @return string[]
226 226
 	 */
227
-	private function getResultPathForConstraintId( string $constraintId ): array {
228
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
227
+	private function getResultPathForConstraintId(string $constraintId): array {
228
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
229 229
 		'@phan-var NumericPropertyId $propertyId';
230
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
230
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
231 231
 	}
232 232
 
233 233
 	/**
@@ -242,8 +242,8 @@  discard block
 block discarded – undo
242 242
 		?array $constraintParameterExceptions,
243 243
 		ApiResult $result
244 244
 	): void {
245
-		$path = $this->getResultPathForConstraintId( $constraintId );
246
-		if ( $constraintParameterExceptions === null ) {
245
+		$path = $this->getResultPathForConstraintId($constraintId);
246
+		if ($constraintParameterExceptions === null) {
247 247
 			$result->addValue(
248 248
 				$path,
249 249
 				self::KEY_STATUS,
@@ -260,11 +260,11 @@  discard block
 block discarded – undo
260 260
 			$violationMessageRenderer = $this->violationMessageRendererFactory
261 261
 				->getViolationMessageRenderer(
262 262
 					$language,
263
-					$this->languageFallbackChainFactory->newFromLanguage( $language ),
263
+					$this->languageFallbackChainFactory->newFromLanguage($language),
264 264
 					$this
265 265
 				);
266 266
 			$problems = [];
267
-			foreach ( $constraintParameterExceptions as $constraintParameterException ) {
267
+			foreach ($constraintParameterExceptions as $constraintParameterException) {
268 268
 				$problems[] = [
269 269
 					self::KEY_MESSAGE_HTML => $violationMessageRenderer->render(
270 270
 						$constraintParameterException->getViolationMessage() ),
@@ -303,8 +303,8 @@  discard block
 block discarded – undo
303 303
 		return [
304 304
 			'action=wbcheckconstraintparameters&propertyid=P247'
305 305
 				=> 'apihelp-wbcheckconstraintparameters-example-propertyid-1',
306
-			'action=wbcheckconstraintparameters&' .
307
-			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' .
306
+			'action=wbcheckconstraintparameters&'.
307
+			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'.
308 308
 			'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f'
309 309
 				=> 'apihelp-wbcheckconstraintparameters-example-constraintid-2',
310 310
 		];
Please login to merge, or discard this patch.