Completed
Push — master ( 6a6753...32d7a5 )
by
unknown
02:18
created
src/Specials/SpecialConstraintReport.php 1 patch
Spacing   +105 added lines, -105 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 		Config $config,
137 137
 		IBufferingStatsdDataFactory $dataFactory
138 138
 	) {
139
-		parent::__construct( 'ConstraintReport' );
139
+		parent::__construct('ConstraintReport');
140 140
 
141 141
 		$this->entityLookup = $entityLookup;
142 142
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -145,13 +145,13 @@  discard block
 block discarded – undo
145 145
 		$language = $this->getLanguage();
146 146
 
147 147
 		$formatterOptions = new FormatterOptions();
148
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
148
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
149 149
 		$this->dataValueFormatter = $valueFormatterFactory->getValueFormatter(
150 150
 			SnakFormatter::FORMAT_HTML,
151 151
 			$formatterOptions
152 152
 		);
153 153
 
154
-		$labelLookup = $fallbackLabelDescLookupFactory->newLabelDescriptionLookup( $language );
154
+		$labelLookup = $fallbackLabelDescLookupFactory->newLabelDescriptionLookup($language);
155 155
 
156 156
 		$this->entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter(
157 157
 			$labelLookup
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 	 * @return string
208 208
 	 */
209 209
 	public function getDescription() {
210
-		return $this->msg( 'wbqc-constraintreport' )->escaped();
210
+		return $this->msg('wbqc-constraintreport')->escaped();
211 211
 	}
212 212
 
213 213
 	/**
@@ -219,43 +219,43 @@  discard block
 block discarded – undo
219 219
 	 * @throws EntityIdParsingException
220 220
 	 * @throws UnexpectedValueException
221 221
 	 */
222
-	public function execute( $subPage ) {
222
+	public function execute($subPage) {
223 223
 		$out = $this->getOutput();
224 224
 
225
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
226
-		if ( $postRequest ) {
227
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
225
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
226
+		if ($postRequest) {
227
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
228 228
 			return;
229 229
 		}
230 230
 
231 231
 		$out->enableOOUI();
232
-		$out->addModules( $this->getModules() );
232
+		$out->addModules($this->getModules());
233 233
 
234 234
 		$this->setHeaders();
235 235
 
236
-		$out->addHTML( $this->getExplanationText() );
236
+		$out->addHTML($this->getExplanationText());
237 237
 		$this->buildEntityIdForm();
238 238
 
239
-		if ( !$subPage ) {
239
+		if (!$subPage) {
240 240
 			return;
241 241
 		}
242 242
 
243
-		if ( !is_string( $subPage ) ) {
244
-			throw new InvalidArgumentException( '$subPage must be string.' );
243
+		if (!is_string($subPage)) {
244
+			throw new InvalidArgumentException('$subPage must be string.');
245 245
 		}
246 246
 
247 247
 		try {
248
-			$entityId = $this->entityIdParser->parse( $subPage );
249
-		} catch ( EntityIdParsingException $e ) {
248
+			$entityId = $this->entityIdParser->parse($subPage);
249
+		} catch (EntityIdParsingException $e) {
250 250
 			$out->addHTML(
251
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
251
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
252 252
 			);
253 253
 			return;
254 254
 		}
255 255
 
256
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
256
+		if (!$this->entityLookup->hasEntity($entityId)) {
257 257
 			$out->addHTML(
258
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
258
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
259 259
 			);
260 260
 			return;
261 261
 		}
@@ -263,18 +263,18 @@  discard block
 block discarded – undo
263 263
 		$this->dataFactory->increment(
264 264
 			'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck'
265 265
 		);
266
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
266
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
267 267
 
268
-		if ( $results !== [] ) {
268
+		if ($results !== []) {
269 269
 			$out->addHTML(
270
-				$this->buildResultHeader( $entityId )
271
-				. $this->buildSummary( $results )
272
-				. $this->buildResultTable( $entityId, $results )
270
+				$this->buildResultHeader($entityId)
271
+				. $this->buildSummary($results)
272
+				. $this->buildResultTable($entityId, $results)
273 273
 			);
274 274
 		} else {
275 275
 			$out->addHTML(
276
-				$this->buildResultHeader( $entityId )
277
-				. $this->buildNotice( 'wbqc-constraintreport-empty-result' )
276
+				$this->buildResultHeader($entityId)
277
+				. $this->buildNotice('wbqc-constraintreport-empty-result')
278 278
 			);
279 279
 		}
280 280
 	}
@@ -290,15 +290,15 @@  discard block
 block discarded – undo
290 290
 				'name' => 'entityid',
291 291
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
292 292
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
293
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped()
293
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped()
294 294
 			]
295 295
 		];
296
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' );
297
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() );
298
-		$htmlForm->setSubmitCallback( function() {
296
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form');
297
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped());
298
+		$htmlForm->setSubmitCallback(function() {
299 299
 			return false;
300 300
 		} );
301
-		$htmlForm->setMethod( 'post' );
301
+		$htmlForm->setMethod('post');
302 302
 		$htmlForm->show();
303 303
 	}
304 304
 
@@ -312,16 +312,16 @@  discard block
 block discarded – undo
312 312
 	 *
313 313
 	 * @return string HTML
314 314
 	 */
315
-	private function buildNotice( $messageKey, $error = false ) {
316
-		if ( !is_string( $messageKey ) ) {
317
-			throw new InvalidArgumentException( '$message must be string.' );
315
+	private function buildNotice($messageKey, $error = false) {
316
+		if (!is_string($messageKey)) {
317
+			throw new InvalidArgumentException('$message must be string.');
318 318
 		}
319
-		if ( !is_bool( $error ) ) {
320
-			throw new InvalidArgumentException( '$error must be bool.' );
319
+		if (!is_bool($error)) {
320
+			throw new InvalidArgumentException('$error must be bool.');
321 321
 		}
322 322
 
323 323
 		$cssClasses = 'wbqc-constraintreport-notice';
324
-		if ( $error ) {
324
+		if ($error) {
325 325
 			$cssClasses .= ' wbqc-constraintreport-notice-error';
326 326
 		}
327 327
 
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
 				[
331 331
 					'class' => $cssClasses
332 332
 				],
333
-				$this->msg( $messageKey )->escaped()
333
+				$this->msg($messageKey)->escaped()
334 334
 			);
335 335
 	}
336 336
 
@@ -340,16 +340,16 @@  discard block
 block discarded – undo
340 340
 	private function getExplanationText() {
341 341
 		return Html::rawElement(
342 342
 			'div',
343
-			[ 'class' => 'wbqc-explanation' ],
343
+			['class' => 'wbqc-explanation'],
344 344
 			Html::rawElement(
345 345
 				'p',
346 346
 				[],
347
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped()
347
+				$this->msg('wbqc-constraintreport-explanation-part-one')->escaped()
348 348
 			)
349 349
 			. Html::rawElement(
350 350
 				'p',
351 351
 				[],
352
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped()
352
+				$this->msg('wbqc-constraintreport-explanation-part-two')->escaped()
353 353
 			)
354 354
 		);
355 355
 	}
@@ -360,72 +360,72 @@  discard block
 block discarded – undo
360 360
 	 *
361 361
 	 * @return string HTML
362 362
 	 */
363
-	private function buildResultTable( EntityId $entityId, array $results ) {
363
+	private function buildResultTable(EntityId $entityId, array $results) {
364 364
 		// Set table headers
365 365
 		$table = new HtmlTableBuilder(
366 366
 			[
367 367
 				new HtmlTableHeaderBuilder(
368
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->escaped(),
368
+					$this->msg('wbqc-constraintreport-result-table-header-status')->escaped(),
369 369
 					true
370 370
 				),
371 371
 				new HtmlTableHeaderBuilder(
372
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->escaped(),
372
+					$this->msg('wbqc-constraintreport-result-table-header-property')->escaped(),
373 373
 					true
374 374
 				),
375 375
 				new HtmlTableHeaderBuilder(
376
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->escaped(),
376
+					$this->msg('wbqc-constraintreport-result-table-header-message')->escaped(),
377 377
 					true
378 378
 				),
379 379
 				new HtmlTableHeaderBuilder(
380
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->escaped(),
380
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->escaped(),
381 381
 					true
382 382
 				)
383 383
 			]
384 384
 		);
385 385
 
386
-		foreach ( $results as $result ) {
387
-			$table = $this->appendToResultTable( $table, $entityId, $result );
386
+		foreach ($results as $result) {
387
+			$table = $this->appendToResultTable($table, $entityId, $result);
388 388
 		}
389 389
 
390 390
 		return $table->toHtml();
391 391
 	}
392 392
 
393
-	private function appendToResultTable( HtmlTableBuilder $table, EntityId $entityId, CheckResult $result ) {
393
+	private function appendToResultTable(HtmlTableBuilder $table, EntityId $entityId, CheckResult $result) {
394 394
 		$message = $result->getMessage();
395
-		if ( $message === null ) {
395
+		if ($message === null) {
396 396
 			// no row for this result
397 397
 			return $table;
398 398
 		}
399 399
 
400 400
 		// Status column
401
-		$statusColumn = $this->formatStatus( $result->getStatus() );
401
+		$statusColumn = $this->formatStatus($result->getStatus());
402 402
 
403 403
 		// Property column
404
-		$propertyId = new PropertyId( $result->getContextCursor()->getSnakPropertyId() );
404
+		$propertyId = new PropertyId($result->getContextCursor()->getSnakPropertyId());
405 405
 		$propertyColumn = $this->getClaimLink(
406 406
 			$entityId,
407 407
 			$propertyId,
408
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
408
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
409 409
 		);
410 410
 
411 411
 		// Message column
412
-		$messageColumn = $this->violationMessageRenderer->render( $message );
412
+		$messageColumn = $this->violationMessageRenderer->render($message);
413 413
 
414 414
 		// Constraint column
415 415
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
416 416
 		try {
417
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
418
-		} catch ( InvalidArgumentException $e ) {
419
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
417
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
418
+		} catch (InvalidArgumentException $e) {
419
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
420 420
 		}
421 421
 		$constraintLink = $this->getClaimLink(
422 422
 			$propertyId,
423
-			new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
423
+			new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
424 424
 			$constraintTypeLabel
425 425
 		);
426 426
 		$constraintColumn = $this->buildExpandableElement(
427 427
 			$constraintLink,
428
-			$this->constraintParameterRenderer->formatParameters( $result->getParameters() ),
428
+			$this->constraintParameterRenderer->formatParameters($result->getParameters()),
429 429
 			'[...]'
430 430
 		);
431 431
 
@@ -465,15 +465,15 @@  discard block
 block discarded – undo
465 465
 	 *
466 466
 	 * @return string HTML
467 467
 	 */
468
-	protected function buildResultHeader( EntityId $entityId ) {
469
-		$entityLink = sprintf( '%s (%s)',
470
-							   $this->entityIdLinkFormatter->formatEntityId( $entityId ),
471
-							   htmlspecialchars( $entityId->getSerialization() ) );
468
+	protected function buildResultHeader(EntityId $entityId) {
469
+		$entityLink = sprintf('%s (%s)',
470
+							   $this->entityIdLinkFormatter->formatEntityId($entityId),
471
+							   htmlspecialchars($entityId->getSerialization()));
472 472
 
473 473
 		return Html::rawElement(
474 474
 			'h3',
475 475
 			[],
476
-			sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink )
476
+			sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink)
477 477
 		);
478 478
 	}
479 479
 
@@ -484,24 +484,24 @@  discard block
 block discarded – undo
484 484
 	 *
485 485
 	 * @return string HTML
486 486
 	 */
487
-	protected function buildSummary( array $results ) {
487
+	protected function buildSummary(array $results) {
488 488
 		$statuses = [];
489
-		foreach ( $results as $result ) {
490
-			$status = strtolower( $result->getStatus() );
491
-			$statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1;
489
+		foreach ($results as $result) {
490
+			$status = strtolower($result->getStatus());
491
+			$statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1;
492 492
 		}
493 493
 
494 494
 		$statusElements = [];
495
-		foreach ( $statuses as $status => $count ) {
496
-			if ( $count > 0 ) {
495
+		foreach ($statuses as $status => $count) {
496
+			if ($count > 0) {
497 497
 				$statusElements[] =
498
-					$this->formatStatus( $status )
498
+					$this->formatStatus($status)
499 499
 					. ': '
500 500
 					. $count;
501 501
 			}
502 502
 		}
503 503
 
504
-		return Html::rawElement( 'p', [], implode( ', ', $statusElements ) );
504
+		return Html::rawElement('p', [], implode(', ', $statusElements));
505 505
 	}
506 506
 
507 507
 	/**
@@ -516,15 +516,15 @@  discard block
 block discarded – undo
516 516
 	 *
517 517
 	 * @return string HTML
518 518
 	 */
519
-	protected function buildExpandableElement( $content, $expandableContent, $indicator ) {
520
-		if ( !is_string( $content ) ) {
521
-			throw new InvalidArgumentException( '$content has to be string.' );
519
+	protected function buildExpandableElement($content, $expandableContent, $indicator) {
520
+		if (!is_string($content)) {
521
+			throw new InvalidArgumentException('$content has to be string.');
522 522
 		}
523
-		if ( $expandableContent && ( !is_string( $expandableContent ) ) ) {
524
-			throw new InvalidArgumentException( '$tooltipContent, if provided, has to be string.' );
523
+		if ($expandableContent && (!is_string($expandableContent))) {
524
+			throw new InvalidArgumentException('$tooltipContent, if provided, has to be string.');
525 525
 		}
526 526
 
527
-		if ( empty( $expandableContent ) ) {
527
+		if (empty($expandableContent)) {
528 528
 			return $content;
529 529
 		}
530 530
 
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
 			$expandableContent
545 545
 		);
546 546
 
547
-		return sprintf( '%s %s %s', $content, $tooltipIndicator, $expandableContent );
547
+		return sprintf('%s %s %s', $content, $tooltipIndicator, $expandableContent);
548 548
 	}
549 549
 
550 550
 	/**
@@ -556,8 +556,8 @@  discard block
 block discarded – undo
556 556
 	 *
557 557
 	 * @return string HTML
558 558
 	 */
559
-	private function formatStatus( $status ) {
560
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
559
+	private function formatStatus($status) {
560
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
561 561
 		$statusIcons = [
562 562
 			CheckResult::STATUS_WARNING => [
563 563
 				'icon' => 'non-mandatory-constraint-violation',
@@ -571,25 +571,25 @@  discard block
 block discarded – undo
571 571
 			],
572 572
 		];
573 573
 
574
-		if ( array_key_exists( $status, $statusIcons ) ) {
575
-			$iconWidget = new IconWidget( $statusIcons[$status] );
576
-			$iconHtml = $iconWidget->toString() . ' ';
574
+		if (array_key_exists($status, $statusIcons)) {
575
+			$iconWidget = new IconWidget($statusIcons[$status]);
576
+			$iconHtml = $iconWidget->toString().' ';
577 577
 		} else {
578 578
 			$iconHtml = '';
579 579
 		}
580 580
 
581
-		$labelWidget = new LabelWidget( [
582
-			'label' => $this->msg( $messageName )->text(),
583
-		] );
581
+		$labelWidget = new LabelWidget([
582
+			'label' => $this->msg($messageName)->text(),
583
+		]);
584 584
 		$labelHtml = $labelWidget->toString();
585 585
 
586 586
 		$formattedStatus =
587 587
 			Html::rawElement(
588 588
 				'span',
589 589
 				[
590
-					'class' => 'wbqc-status wbqc-status-' . $status
590
+					'class' => 'wbqc-status wbqc-status-'.$status
591 591
 				],
592
-				$iconHtml . $labelHtml
592
+				$iconHtml.$labelHtml
593 593
 			);
594 594
 
595 595
 		return $formattedStatus;
@@ -605,26 +605,26 @@  discard block
 block discarded – undo
605 605
 	 *
606 606
 	 * @return string HTML
607 607
 	 */
608
-	protected function formatDataValues( $dataValues, $separator = ', ' ) {
609
-		if ( $dataValues instanceof DataValue ) {
610
-			$dataValues = [ $dataValues ];
611
-		} elseif ( !is_array( $dataValues ) ) {
612
-			throw new InvalidArgumentException( '$dataValues has to be instance of DataValue or an array of DataValues.' );
608
+	protected function formatDataValues($dataValues, $separator = ', ') {
609
+		if ($dataValues instanceof DataValue) {
610
+			$dataValues = [$dataValues];
611
+		} elseif (!is_array($dataValues)) {
612
+			throw new InvalidArgumentException('$dataValues has to be instance of DataValue or an array of DataValues.');
613 613
 		}
614 614
 
615 615
 		$formattedDataValues = [];
616
-		foreach ( $dataValues as $dataValue ) {
617
-			if ( !( $dataValue instanceof DataValue ) ) {
618
-				throw new InvalidArgumentException( '$dataValues has to be instance of DataValue or an array of DataValues.' );
616
+		foreach ($dataValues as $dataValue) {
617
+			if (!($dataValue instanceof DataValue)) {
618
+				throw new InvalidArgumentException('$dataValues has to be instance of DataValue or an array of DataValues.');
619 619
 			}
620
-			if ( $dataValue instanceof EntityIdValue ) {
621
-				$formattedDataValues[ ] = $this->entityIdLabelFormatter->formatEntityId( $dataValue->getEntityId() );
620
+			if ($dataValue instanceof EntityIdValue) {
621
+				$formattedDataValues[] = $this->entityIdLabelFormatter->formatEntityId($dataValue->getEntityId());
622 622
 			} else {
623
-				$formattedDataValues[ ] = $this->dataValueFormatter->format( $dataValue );
623
+				$formattedDataValues[] = $this->dataValueFormatter->format($dataValue);
624 624
 			}
625 625
 		}
626 626
 
627
-		return implode( $separator, $formattedDataValues );
627
+		return implode($separator, $formattedDataValues);
628 628
 	}
629 629
 
630 630
 	/**
@@ -636,11 +636,11 @@  discard block
 block discarded – undo
636 636
 	 *
637 637
 	 * @return string HTML
638 638
 	 */
639
-	private function getClaimLink( EntityId $entityId, PropertyId $propertyId, $text ) {
639
+	private function getClaimLink(EntityId $entityId, PropertyId $propertyId, $text) {
640 640
 		return Html::rawElement(
641 641
 			'a',
642 642
 			[
643
-				'href' => $this->getClaimUrl( $entityId, $propertyId ),
643
+				'href' => $this->getClaimUrl($entityId, $propertyId),
644 644
 				'target' => '_blank'
645 645
 			],
646 646
 			$text
@@ -655,9 +655,9 @@  discard block
 block discarded – undo
655 655
 	 *
656 656
 	 * @return string
657 657
 	 */
658
-	private function getClaimUrl( EntityId $entityId, PropertyId $propertyId ) {
659
-		$title = $this->entityTitleLookup->getTitleForId( $entityId );
660
-		$entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() );
658
+	private function getClaimUrl(EntityId $entityId, PropertyId $propertyId) {
659
+		$title = $this->entityTitleLookup->getTitleForId($entityId);
660
+		$entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization());
661 661
 
662 662
 		return $entityUrl;
663 663
 	}
Please login to merge, or discard this patch.
src/ServiceWiring.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -15,24 +15,24 @@  discard block
 block discarded – undo
15 15
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
16 16
 
17 17
 return [
18
-	ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) {
18
+	ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) {
19 19
 		return new LoggingHelper(
20 20
 			$services->getStatsdDataFactory(),
21
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
21
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
22 22
 			$services->getMainConfig()
23 23
 		);
24 24
 	},
25 25
 
26
-	ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) {
26
+	ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) {
27 27
 		return new ConstraintRepository();
28 28
 	},
29 29
 
30
-	ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) {
31
-		$constraintRepository = ConstraintsServices::getConstraintRepository( $services );
32
-		return new CachingConstraintLookup( $constraintRepository );
30
+	ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) {
31
+		$constraintRepository = ConstraintsServices::getConstraintRepository($services);
32
+		return new CachingConstraintLookup($constraintRepository);
33 33
 	},
34 34
 
35
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) {
35
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) {
36 36
 		return new CheckResultSerializer(
37 37
 			new ConstraintSerializer(
38 38
 				false // constraint parameters are not exposed
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 		);
44 44
 	},
45 45
 
46
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) {
46
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) {
47 47
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
48 48
 		$repo = WikibaseRepo::getDefaultInstance();
49 49
 		$entityIdParser = $repo->getEntityIdParser();
@@ -60,11 +60,11 @@  discard block
 block discarded – undo
60 60
 		);
61 61
 	},
62 62
 
63
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) {
63
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) {
64 64
 		return new ViolationMessageSerializer();
65 65
 	},
66 66
 
67
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) {
67
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) {
68 68
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
69 69
 		$repo = WikibaseRepo::getDefaultInstance();
70 70
 		$entityIdParser = $repo->getEntityIdParser();
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 		);
77 77
 	},
78 78
 
79
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) {
79
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) {
80 80
 		// TODO in the future, get DeserializerFactory and concept base URIs from $services?
81 81
 		$repo = WikibaseRepo::getDefaultInstance();
82 82
 		$deserializerFactory = $repo->getBaseDataModelDeserializerFactory();
Please login to merge, or discard this patch.
src/ConstraintsServices.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -24,75 +24,75 @@
 block discarded – undo
24 24
 	const VIOLATION_MESSAGE_DESERIALIZER = 'WBQC_ViolationMessageDeserializer';
25 25
 	const CONSTRAINT_PARAMETER_PARSER = 'WBQC_ConstraintParameterParser';
26 26
 
27
-	private static function getService( MediaWikiServices $services = null, $name ) {
28
-		if ( $services === null ) {
27
+	private static function getService(MediaWikiServices $services = null, $name) {
28
+		if ($services === null) {
29 29
 			$services = MediaWikiServices::getInstance();
30 30
 		}
31
-		return $services->getService( $name );
31
+		return $services->getService($name);
32 32
 	}
33 33
 
34 34
 	/**
35 35
 	 * @param MediaWikiServices|null $services
36 36
 	 * @return LoggingHelper
37 37
 	 */
38
-	public static function getLoggingHelper( MediaWikiServices $services = null ) {
39
-		return self::getService( $services, self::LOGGING_HELPER );
38
+	public static function getLoggingHelper(MediaWikiServices $services = null) {
39
+		return self::getService($services, self::LOGGING_HELPER);
40 40
 	}
41 41
 
42 42
 	/**
43 43
 	 * @param MediaWikiServices|null $services
44 44
 	 * @return ConstraintRepository
45 45
 	 */
46
-	public static function getConstraintRepository( MediaWikiServices $services = null ) {
47
-		return self::getService( $services, self::CONSTRAINT_REPOSITORY );
46
+	public static function getConstraintRepository(MediaWikiServices $services = null) {
47
+		return self::getService($services, self::CONSTRAINT_REPOSITORY);
48 48
 	}
49 49
 
50 50
 	/**
51 51
 	 * @param MediaWikiServices|null $services
52 52
 	 * @return ConstraintLookup
53 53
 	 */
54
-	public static function getConstraintLookup( MediaWikiServices $services = null ) {
55
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
54
+	public static function getConstraintLookup(MediaWikiServices $services = null) {
55
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
56 56
 	}
57 57
 
58 58
 	/**
59 59
 	 * @param MediaWikiServices|null $services
60 60
 	 * @return CheckResultSerializer
61 61
 	 */
62
-	public static function getCheckResultSerializer( MediaWikiServices $services = null ) {
63
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
62
+	public static function getCheckResultSerializer(MediaWikiServices $services = null) {
63
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
64 64
 	}
65 65
 
66 66
 	/**
67 67
 	 * @param MediaWikiServices|null $services
68 68
 	 * @return CheckResultDeserializer
69 69
 	 */
70
-	public static function getCheckResultDeserializer( MediaWikiServices $services = null ) {
71
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
70
+	public static function getCheckResultDeserializer(MediaWikiServices $services = null) {
71
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
72 72
 	}
73 73
 
74 74
 	/**
75 75
 	 * @param MediaWikiServices|null $services
76 76
 	 * @return ViolationMessageSerializer
77 77
 	 */
78
-	public static function getViolationMessageSerializer( MediaWikiServices $services = null ) {
79
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
78
+	public static function getViolationMessageSerializer(MediaWikiServices $services = null) {
79
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
80 80
 	}
81 81
 
82 82
 	/**
83 83
 	 * @param MediaWikiServices|null $services
84 84
 	 * @return ViolationMessageDeserializer
85 85
 	 */
86
-	public static function getViolationMessageDeserializer( MediaWikiServices $services = null ) {
87
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
86
+	public static function getViolationMessageDeserializer(MediaWikiServices $services = null) {
87
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
88 88
 	}
89 89
 
90 90
 	/**
91 91
 	 * @param MediaWikiServices|null $services
92 92
 	 * @return ConstraintParameterParser
93 93
 	 */
94
-	public static function getConstraintParameterParser( MediaWikiServices $services = null ) {
95
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
94
+	public static function getConstraintParameterParser(MediaWikiServices $services = null) {
95
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
96 96
 	}
97 97
 
98 98
 }
Please login to merge, or discard this patch.
src/Api/ResultsCache.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	 * @param WANObjectCache $cache
37 37
 	 * @param string $formatVersion The version of the API response format.
38 38
 	 */
39
-	public function __construct( WANObjectCache $cache, $formatVersion ) {
39
+	public function __construct(WANObjectCache $cache, $formatVersion) {
40 40
 		$this->cache = $cache;
41 41
 		$this->formatVersion = $formatVersion;
42 42
 	}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 * @param EntityId $entityId
46 46
 	 * @return string cache key
47 47
 	 */
48
-	public function makeKey( EntityId $entityId ) {
48
+	public function makeKey(EntityId $entityId) {
49 49
 		return $this->cache->makeKey(
50 50
 			'WikibaseQualityConstraints', // extension
51 51
 			'checkConstraints', // action
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	 * @param float &$asOf UNIX timestamp of cached value; null on failure [returned]
62 62
 	 * @return mixed
63 63
 	 */
64
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null ) {
65
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $asOf );
64
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null) {
65
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $asOf);
66 66
 	}
67 67
 
68 68
 	/**
@@ -72,16 +72,16 @@  discard block
 block discarded – undo
72 72
 	 * @param array $opts
73 73
 	 * @return bool
74 74
 	 */
75
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
76
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
75
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
76
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
77 77
 	}
78 78
 
79 79
 	/**
80 80
 	 * @param EntityId $key
81 81
 	 * @return bool
82 82
 	 */
83
-	public function delete( EntityId $key ) {
84
-		return $this->cache->delete( $this->makeKey( $key ) );
83
+	public function delete(EntityId $key) {
84
+		return $this->cache->delete($this->makeKey($key));
85 85
 	}
86 86
 
87 87
 }
Please login to merge, or discard this patch.
src/ConstraintReportFactory.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	public static function getDefaultInstance() {
153 153
 		static $instance = null;
154 154
 
155
-		if ( $instance === null ) {
155
+		if ($instance === null) {
156 156
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
157 157
 			$config = MediaWikiServices::getInstance()->getMainConfig();
158 158
 			$titleParser = MediaWikiServices::getInstance()->getTitleParser();
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 	 * @return DelegatingConstraintChecker
205 205
 	 */
206 206
 	public function getConstraintChecker() {
207
-		if ( $this->delegatingConstraintChecker === null ) {
207
+		if ($this->delegatingConstraintChecker === null) {
208 208
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
209 209
 				$this->lookup,
210 210
 				$this->getConstraintCheckerMap(),
@@ -212,9 +212,9 @@  discard block
 block discarded – undo
212 212
 				ConstraintsServices::getConstraintParameterParser(),
213 213
 				$this->statementGuidParser,
214 214
 				ConstraintsServices::getLoggingHelper(),
215
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
216
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
217
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
215
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
216
+				$this->config->get('WBQualityConstraintsCheckReferences'),
217
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
218 218
 			);
219 219
 		}
220 220
 
@@ -225,10 +225,10 @@  discard block
 block discarded – undo
225 225
 	 * @return ConstraintChecker[]
226 226
 	 */
227 227
 	private function getConstraintCheckerMap() {
228
-		if ( $this->constraintCheckerMap === null ) {
228
+		if ($this->constraintCheckerMap === null) {
229 229
 			$connectionCheckerHelper = new ConnectionCheckerHelper();
230
-			$rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
231
-			if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
230
+			$rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
231
+			if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
232 232
 				$sparqlHelper = new SparqlHelper(
233 233
 					$this->config,
234 234
 					$this->rdfVocabulary,
@@ -250,120 +250,120 @@  discard block
 block discarded – undo
250 250
 			);
251 251
 
252 252
 			$this->constraintCheckerMap = [
253
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
253
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
254 254
 					=> new ConflictsWithChecker(
255 255
 						$this->lookup,
256 256
 						ConstraintsServices::getConstraintParameterParser(),
257 257
 						$connectionCheckerHelper
258 258
 					),
259
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
259
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
260 260
 					=> new ItemChecker(
261 261
 						$this->lookup,
262 262
 						ConstraintsServices::getConstraintParameterParser(),
263 263
 						$connectionCheckerHelper
264 264
 					),
265
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
265
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
266 266
 					=> new TargetRequiredClaimChecker(
267 267
 						$this->lookup,
268 268
 						ConstraintsServices::getConstraintParameterParser(),
269 269
 						$connectionCheckerHelper
270 270
 					),
271
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
271
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
272 272
 					=> new SymmetricChecker(
273 273
 						$this->lookup,
274 274
 						$connectionCheckerHelper
275 275
 					),
276
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
276
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
277 277
 					=> new InverseChecker(
278 278
 						$this->lookup,
279 279
 						ConstraintsServices::getConstraintParameterParser(),
280 280
 						$connectionCheckerHelper
281 281
 					),
282
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
282
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
283 283
 					=> new QualifierChecker(),
284
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
284
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
285 285
 					=> new QualifiersChecker(
286 286
 						ConstraintsServices::getConstraintParameterParser()
287 287
 					),
288
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
288
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
289 289
 					=> new MandatoryQualifiersChecker(
290 290
 						ConstraintsServices::getConstraintParameterParser()
291 291
 					),
292
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
292
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
293 293
 					=> new RangeChecker(
294 294
 						$this->propertyDataTypeLookup,
295 295
 						ConstraintsServices::getConstraintParameterParser(),
296 296
 						$rangeCheckerHelper
297 297
 					),
298
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
298
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
299 299
 					=> new DiffWithinRangeChecker(
300 300
 						ConstraintsServices::getConstraintParameterParser(),
301 301
 						$rangeCheckerHelper,
302 302
 						$this->config
303 303
 					),
304
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
304
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
305 305
 					=> new TypeChecker(
306 306
 						$this->lookup,
307 307
 						ConstraintsServices::getConstraintParameterParser(),
308 308
 						$typeCheckerHelper,
309 309
 						$this->config
310 310
 					),
311
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
311
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
312 312
 					=> new ValueTypeChecker(
313 313
 						$this->lookup,
314 314
 						ConstraintsServices::getConstraintParameterParser(),
315 315
 						$typeCheckerHelper,
316 316
 						$this->config
317 317
 					),
318
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
319
-					=> new SingleValueChecker( ConstraintsServices::getConstraintParameterParser() ),
320
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
321
-					=> new MultiValueChecker( ConstraintsServices::getConstraintParameterParser() ),
322
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
318
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
319
+					=> new SingleValueChecker(ConstraintsServices::getConstraintParameterParser()),
320
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
321
+					=> new MultiValueChecker(ConstraintsServices::getConstraintParameterParser()),
322
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
323 323
 					=> new UniqueValueChecker(
324 324
 						$sparqlHelper
325 325
 					),
326
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
326
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
327 327
 					=> new FormatChecker(
328 328
 						ConstraintsServices::getConstraintParameterParser(),
329 329
 						$this->config,
330 330
 						$sparqlHelper
331 331
 					),
332
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
332
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
333 333
 					=> new CommonsLinkChecker(
334 334
 						ConstraintsServices::getConstraintParameterParser(),
335 335
 						$this->titleParser
336 336
 					),
337
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
337
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
338 338
 					=> new OneOfChecker(
339 339
 						ConstraintsServices::getConstraintParameterParser()
340 340
 					),
341
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
341
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
342 342
 					=> new ValueOnlyChecker(),
343
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
343
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
344 344
 					=> new ReferenceChecker(),
345
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
345
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
346 346
 					=> new NoBoundsChecker(),
347
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
347
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
348 348
 					=> new AllowedUnitsChecker(
349 349
 						ConstraintsServices::getConstraintParameterParser(),
350 350
 						$this->unitConverter
351 351
 					),
352
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
353
-					=> new SingleBestValueChecker( ConstraintsServices::getConstraintParameterParser() ),
354
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
352
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
353
+					=> new SingleBestValueChecker(ConstraintsServices::getConstraintParameterParser()),
354
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
355 355
 					=> new EntityTypeChecker(
356 356
 						ConstraintsServices::getConstraintParameterParser()
357 357
 					),
358
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
358
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
359 359
 					=> new NoneOfChecker(
360 360
 						ConstraintsServices::getConstraintParameterParser()
361 361
 					),
362
-				$this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
362
+				$this->config->get('WBQualityConstraintsIntegerConstraintId')
363 363
 					=> new IntegerChecker(),
364
-				$this->config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
364
+				$this->config->get('WBQualityConstraintsCitationNeededConstraintId')
365 365
 					=> new CitationNeededChecker(),
366
-				$this->config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
366
+				$this->config->get('WBQualityConstraintsPropertyScopeConstraintId')
367 367
 					=> new PropertyScopeChecker(
368 368
 						ConstraintsServices::getConstraintParameterParser()
369 369
 					),
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 	 * @return WikiPageEntityMetaDataAccessor
378 378
 	 */
379 379
 	public function getWikiPageEntityMetaDataAccessor() {
380
-		if ( $this->wikiPageEntityMetaDataAccessor === null ) {
380
+		if ($this->wikiPageEntityMetaDataAccessor === null) {
381 381
 			$this->wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
382 382
 				$this->entityNamespaceLookup
383 383
 			);
@@ -390,12 +390,12 @@  discard block
 block discarded – undo
390 390
 	 * @return ResultsSource
391 391
 	 */
392 392
 	public function getResultsSource() {
393
-		if ( $this->resultsSource === null ) {
393
+		if ($this->resultsSource === null) {
394 394
 			$this->resultsSource = new CheckingResultsSource(
395 395
 				$this->getConstraintChecker()
396 396
 			);
397 397
 
398
-			if ( $this->config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
398
+			if ($this->config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
399 399
 				$this->resultsSource = new CachingResultsSource(
400 400
 					$this->resultsSource,
401 401
 					ResultsCache::getDefaultInstance(),
@@ -403,9 +403,9 @@  discard block
 block discarded – undo
403 403
 					ConstraintsServices::getCheckResultDeserializer(),
404 404
 					$this->getWikiPageEntityMetaDataAccessor(),
405 405
 					$this->entityIdParser,
406
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
406
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
407 407
 					$this->getPossiblyStaleConstraintTypes(),
408
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
408
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
409 409
 					ConstraintsServices::getLoggingHelper()
410 410
 				);
411 411
 			}
@@ -419,10 +419,10 @@  discard block
 block discarded – undo
419 419
 	 */
420 420
 	public function getPossiblyStaleConstraintTypes() {
421 421
 		return [
422
-			$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
423
-			$this->config->get( 'WBQualityConstraintsTypeConstraintId' ),
424
-			$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
425
-			$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
422
+			$this->config->get('WBQualityConstraintsCommonsLinkConstraintId'),
423
+			$this->config->get('WBQualityConstraintsTypeConstraintId'),
424
+			$this->config->get('WBQualityConstraintsValueTypeConstraintId'),
425
+			$this->config->get('WBQualityConstraintsDistinctValuesConstraintId'),
426 426
 		];
427 427
 	}
428 428
 
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/PropertyScopeChecker.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 		];
50 50
 	}
51 51
 
52
-	public function checkConstraint( Context $context, Constraint $constraint ) {
52
+	public function checkConstraint(Context $context, Constraint $constraint) {
53 53
 		$constraintParameters = $constraint->getConstraintParameters();
54 54
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
55 55
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 			$constraintTypeItemId
59 59
 		);
60 60
 
61
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
61
+		if (in_array($context->getType(), $allowedContextTypes)) {
62 62
 			return new CheckResult(
63 63
 				$context->getCursor(),
64 64
 				$constraint,
@@ -71,15 +71,15 @@  discard block
 block discarded – undo
71 71
 				$constraint,
72 72
 				[],
73 73
 				CheckResult::STATUS_VIOLATION,
74
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
75
-					->withEntityId( $context->getSnak()->getPropertyId() )
76
-					->withPropertyScope( $context->getType() )
77
-					->withPropertyScopeList( $allowedContextTypes )
74
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
75
+					->withEntityId($context->getSnak()->getPropertyId())
76
+					->withPropertyScope($context->getType())
77
+					->withPropertyScopeList($allowedContextTypes)
78 78
 			);
79 79
 		}
80 80
 	}
81 81
 
82
-	public function checkConstraintParameters( Constraint $constraint ) {
82
+	public function checkConstraintParameters(Constraint $constraint) {
83 83
 		$constraintParameters = $constraint->getConstraintParameters();
84 84
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
85 85
 		$exceptions = [];
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 				$constraintParameters,
89 89
 				$constraintTypeItemId
90 90
 			);
91
-		} catch ( ConstraintParameterException $e ) {
91
+		} catch (ConstraintParameterException $e) {
92 92
 			$exceptions[] = $e;
93 93
 		}
94 94
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessage.php 1 patch
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -122,17 +122,17 @@  discard block
 block discarded – undo
122 122
 	public function __construct(
123 123
 		$messageKey
124 124
 	) {
125
-		if ( strpos( $messageKey, self::MESSAGE_KEY_PREFIX ) !== 0 ) {
125
+		if (strpos($messageKey, self::MESSAGE_KEY_PREFIX) !== 0) {
126 126
 			throw new InvalidArgumentException(
127
-				'ViolationMessage key ⧼' .
128
-				$messageKey .
129
-				'⧽ should start with "' .
130
-				self::MESSAGE_KEY_PREFIX .
127
+				'ViolationMessage key ⧼'.
128
+				$messageKey.
129
+				'⧽ should start with "'.
130
+				self::MESSAGE_KEY_PREFIX.
131 131
 				'".'
132 132
 			);
133 133
 		}
134 134
 
135
-		$this->messageKeySuffix = substr( $messageKey, strlen( self::MESSAGE_KEY_PREFIX ) );
135
+		$this->messageKeySuffix = substr($messageKey, strlen(self::MESSAGE_KEY_PREFIX));
136 136
 		$this->arguments = [];
137 137
 	}
138 138
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 	 * @return string
142 142
 	 */
143 143
 	public function getMessageKey() {
144
-		return self::MESSAGE_KEY_PREFIX . $this->messageKeySuffix;
144
+		return self::MESSAGE_KEY_PREFIX.$this->messageKeySuffix;
145 145
 	}
146 146
 
147 147
 	/**
@@ -161,9 +161,9 @@  discard block
 block discarded – undo
161 161
 	 * @param mixed $value the value, which should match the $type
162 162
 	 * @return ViolationMessage
163 163
 	 */
164
-	public function withArgument( $type, $role, $value ) {
164
+	public function withArgument($type, $role, $value) {
165 165
 		$ret = clone $this;
166
-		$ret->arguments[] = [ 'type' => $type, 'role' => $role, 'value' => $value ];
166
+		$ret->arguments[] = ['type' => $type, 'role' => $role, 'value' => $value];
167 167
 		return $ret;
168 168
 	}
169 169
 
@@ -175,8 +175,8 @@  discard block
 block discarded – undo
175 175
 	 * @param string|null $role one of the Role::* constants
176 176
 	 * @return ViolationMessage
177 177
 	 */
178
-	public function withEntityId( EntityId $entityId, $role = null ) {
179
-		return $this->withArgument( self::TYPE_ENTITY_ID, $role, $entityId );
178
+	public function withEntityId(EntityId $entityId, $role = null) {
179
+		return $this->withArgument(self::TYPE_ENTITY_ID, $role, $entityId);
180 180
 	}
181 181
 
182 182
 	/**
@@ -193,8 +193,8 @@  discard block
 block discarded – undo
193 193
 	 * @param string|null $role one of the Role::* constants
194 194
 	 * @return ViolationMessage
195 195
 	 */
196
-	public function withEntityIdList( array $entityIdList, $role = null ) {
197
-		return $this->withArgument( self::TYPE_ENTITY_ID_LIST, $role, $entityIdList );
196
+	public function withEntityIdList(array $entityIdList, $role = null) {
197
+		return $this->withArgument(self::TYPE_ENTITY_ID_LIST, $role, $entityIdList);
198 198
 	}
199 199
 
200 200
 	/**
@@ -205,8 +205,8 @@  discard block
 block discarded – undo
205 205
 	 * @param string|null $role one of the Role::* constants
206 206
 	 * @return ViolationMessage
207 207
 	 */
208
-	public function withItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
209
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value );
208
+	public function withItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
209
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value);
210 210
 	}
211 211
 
212 212
 	/**
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
 	 * @param string|null $role one of the Role::* constants
224 224
 	 * @return ViolationMessage
225 225
 	 */
226
-	public function withItemIdSnakValueList( array $valueList, $role = null ) {
227
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList );
226
+	public function withItemIdSnakValueList(array $valueList, $role = null) {
227
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList);
228 228
 	}
229 229
 
230 230
 	/**
@@ -235,8 +235,8 @@  discard block
 block discarded – undo
235 235
 	 * @param string|null $role one of the Role::* constants
236 236
 	 * @return ViolationMessage
237 237
 	 */
238
-	public function withDataValue( DataValue $dataValue, $role = null ) {
239
-		return $this->withArgument( self::TYPE_DATA_VALUE, $role, $dataValue );
238
+	public function withDataValue(DataValue $dataValue, $role = null) {
239
+		return $this->withArgument(self::TYPE_DATA_VALUE, $role, $dataValue);
240 240
 	}
241 241
 
242 242
 	/**
@@ -251,8 +251,8 @@  discard block
 block discarded – undo
251 251
 	 * @param string|null $role one of the Role::* constants
252 252
 	 * @return ViolationMessage
253 253
 	 */
254
-	public function withDataValueType( $dataValueType, $role = null ) {
255
-		return $this->withArgument( self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType );
254
+	public function withDataValueType($dataValueType, $role = null) {
255
+		return $this->withArgument(self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType);
256 256
 	}
257 257
 
258 258
 	/**
@@ -263,8 +263,8 @@  discard block
 block discarded – undo
263 263
 	 * @param string|null $role one of the Role::* constants
264 264
 	 * @return ViolationMessage
265 265
 	 */
266
-	public function withInlineCode( $code, $role = null ) {
267
-		return $this->withArgument( self::TYPE_INLINE_CODE, $role, $code );
266
+	public function withInlineCode($code, $role = null) {
267
+		return $this->withArgument(self::TYPE_INLINE_CODE, $role, $code);
268 268
 	}
269 269
 
270 270
 	/**
@@ -275,8 +275,8 @@  discard block
 block discarded – undo
275 275
 	 * @param string|null $role one of the Role::* constants
276 276
 	 * @return ViolationMessage
277 277
 	 */
278
-	public function withConstraintScope( $scope, $role = null ) {
279
-		return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE, $role, $scope );
278
+	public function withConstraintScope($scope, $role = null) {
279
+		return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE, $role, $scope);
280 280
 	}
281 281
 
282 282
 	/**
@@ -287,8 +287,8 @@  discard block
 block discarded – undo
287 287
 	 * @param string|null $role one of the Role::* constants
288 288
 	 * @return ViolationMessage
289 289
 	 */
290
-	public function withConstraintScopeList( array $scopeList, $role = null ) {
291
-		return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList );
290
+	public function withConstraintScopeList(array $scopeList, $role = null) {
291
+		return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList);
292 292
 	}
293 293
 
294 294
 	/**
@@ -299,8 +299,8 @@  discard block
 block discarded – undo
299 299
 	 * @param string|null $role one of the Role::* constants
300 300
 	 * @return ViolationMessage
301 301
 	 */
302
-	public function withPropertyScope( $scope, $role = null ) {
303
-		return $this->withArgument( self::TYPE_PROPERTY_SCOPE, $role, $scope );
302
+	public function withPropertyScope($scope, $role = null) {
303
+		return $this->withArgument(self::TYPE_PROPERTY_SCOPE, $role, $scope);
304 304
 	}
305 305
 
306 306
 	/**
@@ -311,8 +311,8 @@  discard block
 block discarded – undo
311 311
 	 * @param string|null $role one of the Role::* constants
312 312
 	 * @return ViolationMessage
313 313
 	 */
314
-	public function withPropertyScopeList( array $scopeList, $role = null ) {
315
-		return $this->withArgument( self::TYPE_PROPERTY_SCOPE_LIST, $role, $scopeList );
314
+	public function withPropertyScopeList(array $scopeList, $role = null) {
315
+		return $this->withArgument(self::TYPE_PROPERTY_SCOPE_LIST, $role, $scopeList);
316 316
 	}
317 317
 
318 318
 	/**
@@ -327,8 +327,8 @@  discard block
 block discarded – undo
327 327
 	 * @param string $languageCode
328 328
 	 * @return ViolationMessage
329 329
 	 */
330
-	public function withLanguage( $languageCode ) {
331
-		return $this->withArgument( self::TYPE_LANGUAGE, null, $languageCode );
330
+	public function withLanguage($languageCode) {
331
+		return $this->withArgument(self::TYPE_LANGUAGE, null, $languageCode);
332 332
 	}
333 333
 
334 334
 	/**
@@ -343,8 +343,8 @@  discard block
 block discarded – undo
343 343
 	 * @param string|null $role one of the Role::* constants
344 344
 	 * @return ViolationMessage
345 345
 	 */
346
-	public function withMultilingualText( MultilingualTextValue $text, $role = null ) {
347
-		return $this->withArgument( self::TYPE_MULTILINGUAL_TEXT, $role, $text );
346
+	public function withMultilingualText(MultilingualTextValue $text, $role = null) {
347
+		return $this->withArgument(self::TYPE_MULTILINGUAL_TEXT, $role, $text);
348 348
 	}
349 349
 
350 350
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessageRenderer.php 1 patch
Spacing   +82 added lines, -82 removed lines patch added patch discarded remove patch
@@ -78,17 +78,17 @@  discard block
 block discarded – undo
78 78
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
79 79
 	 * @return string
80 80
 	 */
81
-	public function render( ViolationMessage $violationMessage ) {
81
+	public function render(ViolationMessage $violationMessage) {
82 82
 		$messageKey = $violationMessage->getMessageKey();
83
-		$paramsLists = [ [] ];
84
-		foreach ( $violationMessage->getArguments() as $argument ) {
85
-			$params = $this->renderArgument( $argument );
83
+		$paramsLists = [[]];
84
+		foreach ($violationMessage->getArguments() as $argument) {
85
+			$params = $this->renderArgument($argument);
86 86
 			$paramsLists[] = $params;
87 87
 		}
88
-		$allParams = call_user_func_array( 'array_merge', $paramsLists );
88
+		$allParams = call_user_func_array('array_merge', $paramsLists);
89 89
 		return $this->messageLocalizer
90
-			->msg( $messageKey )
91
-			->params( $allParams )
90
+			->msg($messageKey)
91
+			->params($allParams)
92 92
 			->escaped();
93 93
 	}
94 94
 
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
 	 * @param string|null $role one of the Role::* constants
98 98
 	 * @return string HTML
99 99
 	 */
100
-	protected function addRole( $value, $role ) {
101
-		if ( $role === null ) {
100
+	protected function addRole($value, $role) {
101
+		if ($role === null) {
102 102
 			return $value;
103 103
 		}
104 104
 
105
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
106
-			$value .
105
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
106
+			$value.
107 107
 			'</span>';
108 108
 	}
109 109
 
@@ -111,15 +111,15 @@  discard block
 block discarded – undo
111 111
 	 * @param string $key message key
112 112
 	 * @return string HTML
113 113
 	 */
114
-	protected function msgEscaped( $key ) {
115
-		return $this->messageLocalizer->msg( $key )->escaped();
114
+	protected function msgEscaped($key) {
115
+		return $this->messageLocalizer->msg($key)->escaped();
116 116
 	}
117 117
 
118 118
 	/**
119 119
 	 * @param array $argument
120 120
 	 * @return array[] params (for Message::params)
121 121
 	 */
122
-	protected function renderArgument( array $argument ) {
122
+	protected function renderArgument(array $argument) {
123 123
 		$methods = [
124 124
 			ViolationMessage::TYPE_ENTITY_ID => 'renderEntityId',
125 125
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'renderEntityIdList',
@@ -139,12 +139,12 @@  discard block
 block discarded – undo
139 139
 		$value = $argument['value'];
140 140
 		$role = $argument['role'];
141 141
 
142
-		if ( array_key_exists( $type, $methods ) ) {
142
+		if (array_key_exists($type, $methods)) {
143 143
 			$method = $methods[$type];
144
-			$params = $this->$method( $value, $role );
144
+			$params = $this->$method($value, $role);
145 145
 		} else {
146 146
 			throw new InvalidArgumentException(
147
-				'Unknown ViolationMessage argument type ' . $type . '!'
147
+				'Unknown ViolationMessage argument type '.$type.'!'
148 148
 			);
149 149
 		}
150 150
 
@@ -158,46 +158,46 @@  discard block
 block discarded – undo
158 158
 	 * and return a single-element array with a raw message param (i. e. [ Message::rawParam( … ) ])
159 159
 	 * @return array[] list of parameters as accepted by Message::params()
160 160
 	 */
161
-	private function renderList( array $list, $role, callable $render ) {
162
-		if ( $list === [] ) {
161
+	private function renderList(array $list, $role, callable $render) {
162
+		if ($list === []) {
163 163
 			return [
164
-				Message::numParam( 0 ),
165
-				Message::rawParam( '<ul></ul>' ),
164
+				Message::numParam(0),
165
+				Message::rawParam('<ul></ul>'),
166 166
 			];
167 167
 		}
168 168
 
169
-		if ( count( $list ) > $this->maxListLength ) {
170
-			$list = array_slice( $list, 0, $this->maxListLength );
169
+		if (count($list) > $this->maxListLength) {
170
+			$list = array_slice($list, 0, $this->maxListLength);
171 171
 			$truncated = true;
172 172
 		}
173 173
 
174 174
 		$renderedParamsLists = array_map(
175 175
 			$render,
176 176
 			$list,
177
-			array_fill( 0, count( $list ), $role )
177
+			array_fill(0, count($list), $role)
178 178
 		);
179 179
 		$renderedParams = array_map(
180
-			function ( $params ) {
180
+			function($params) {
181 181
 				return $params[0];
182 182
 			},
183 183
 			$renderedParamsLists
184 184
 		);
185 185
 		$renderedElements = array_map(
186
-			function ( $param ) {
186
+			function($param) {
187 187
 				return $param['raw'];
188 188
 			},
189 189
 			$renderedParams
190 190
 		);
191
-		if ( isset( $truncated ) ) {
192
-			$renderedElements[] = $this->msgEscaped( 'ellipsis' );
191
+		if (isset($truncated)) {
192
+			$renderedElements[] = $this->msgEscaped('ellipsis');
193 193
 		}
194 194
 
195 195
 		return array_merge(
196 196
 			[
197
-				Message::numParam( count( $list ) ),
197
+				Message::numParam(count($list)),
198 198
 				Message::rawParam(
199
-					'<ul><li>' .
200
-					implode( '</li><li>', $renderedElements ) .
199
+					'<ul><li>'.
200
+					implode('</li><li>', $renderedElements).
201 201
 					'</li></ul>'
202 202
 				),
203 203
 			],
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 	 * @param string|null $role one of the Role::* constants
211 211
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
212 212
 	 */
213
-	private function renderEntityId( EntityId $entityId, $role ) {
214
-		return [ Message::rawParam( $this->addRole(
215
-			$this->entityIdFormatter->formatEntityId( $entityId ),
213
+	private function renderEntityId(EntityId $entityId, $role) {
214
+		return [Message::rawParam($this->addRole(
215
+			$this->entityIdFormatter->formatEntityId($entityId),
216 216
 			$role
217
-		) ) ];
217
+		))];
218 218
 	}
219 219
 
220 220
 	/**
@@ -222,8 +222,8 @@  discard block
 block discarded – undo
222 222
 	 * @param string|null $role one of the Role::* constants
223 223
 	 * @return array[] list of parameters as accepted by Message::params()
224 224
 	 */
225
-	private function renderEntityIdList( array $entityIdList, $role ) {
226
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
225
+	private function renderEntityIdList(array $entityIdList, $role) {
226
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
227 227
 	}
228 228
 
229 229
 	/**
@@ -231,24 +231,24 @@  discard block
 block discarded – undo
231 231
 	 * @param string|null $role one of the Role::* constants
232 232
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
233 233
 	 */
234
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, $role ) {
235
-		switch ( true ) {
234
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, $role) {
235
+		switch (true) {
236 236
 			case $value->isValue():
237
-				return $this->renderEntityId( $value->getItemId(), $role );
237
+				return $this->renderEntityId($value->getItemId(), $role);
238 238
 			case $value->isSomeValue():
239
-				return [ Message::rawParam( $this->addRole(
240
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
241
-						$this->msgEscaped( 'wikibase-snakview-snaktypeselector-somevalue' ) .
239
+				return [Message::rawParam($this->addRole(
240
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
241
+						$this->msgEscaped('wikibase-snakview-snaktypeselector-somevalue').
242 242
 						'</span>',
243 243
 					$role
244
-				) ) ];
244
+				))];
245 245
 			case $value->isNoValue():
246
-				return [ Message::rawParam( $this->addRole(
247
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
248
-					$this->msgEscaped( 'wikibase-snakview-snaktypeselector-novalue' ) .
246
+				return [Message::rawParam($this->addRole(
247
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
248
+					$this->msgEscaped('wikibase-snakview-snaktypeselector-novalue').
249 249
 						'</span>',
250 250
 					$role
251
-				) ) ];
251
+				))];
252 252
 			default:
253 253
 				// @codeCoverageIgnoreStart
254 254
 				throw new LogicException(
@@ -263,8 +263,8 @@  discard block
 block discarded – undo
263 263
 	 * @param string|null $role one of the Role::* constants
264 264
 	 * @return array[] list of parameters as accepted by Message::params()
265 265
 	 */
266
-	private function renderItemIdSnakValueList( array $valueList, $role ) {
267
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
266
+	private function renderItemIdSnakValueList(array $valueList, $role) {
267
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
268 268
 	}
269 269
 
270 270
 	/**
@@ -272,11 +272,11 @@  discard block
 block discarded – undo
272 272
 	 * @param string|null $role one of the Role::* constants
273 273
 	 * @return array[] list of parameters as accepted by Message::params()
274 274
 	 */
275
-	private function renderDataValue( DataValue $dataValue, $role ) {
276
-		return [ Message::rawParam( $this->addRole(
277
-			$this->dataValueFormatter->format( $dataValue ),
275
+	private function renderDataValue(DataValue $dataValue, $role) {
276
+		return [Message::rawParam($this->addRole(
277
+			$this->dataValueFormatter->format($dataValue),
278 278
 			$role
279
-		) ) ];
279
+		))];
280 280
 	}
281 281
 
282 282
 	/**
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 	 * @param string|null $role one of the Role::* constants
285 285
 	 * @return array[] list of parameters as accepted by Message::params()
286 286
 	 */
287
-	private function renderDataValueType( $dataValueType, $role ) {
287
+	private function renderDataValueType($dataValueType, $role) {
288 288
 		$messageKeys = [
289 289
 			'string' => 'datatypes-type-string',
290 290
 			'monolingualtext' => 'datatypes-type-monolingualtext',
@@ -293,15 +293,15 @@  discard block
 block discarded – undo
293 293
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
294 294
 		];
295 295
 
296
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
297
-			return [ Message::rawParam( $this->addRole(
298
-				$this->msgEscaped( $messageKeys[$dataValueType] ),
296
+		if (array_key_exists($dataValueType, $messageKeys)) {
297
+			return [Message::rawParam($this->addRole(
298
+				$this->msgEscaped($messageKeys[$dataValueType]),
299 299
 				$role
300
-			) ) ];
300
+			))];
301 301
 		} else {
302 302
 			// @codeCoverageIgnoreStart
303 303
 			throw new LogicException(
304
-				'Unknown data value type ' . $dataValueType
304
+				'Unknown data value type '.$dataValueType
305 305
 			);
306 306
 			// @codeCoverageIgnoreEnd
307 307
 		}
@@ -312,11 +312,11 @@  discard block
 block discarded – undo
312 312
 	 * @param string|null $role one of the Role::* constants
313 313
 	 * @return array[] list of parameters as accepted by Message::params()
314 314
 	 */
315
-	private function renderInlineCode( $code, $role ) {
316
-		return [ Message::rawParam( $this->addRole(
317
-			'<code>' . htmlspecialchars( $code ) . '</code>',
315
+	private function renderInlineCode($code, $role) {
316
+		return [Message::rawParam($this->addRole(
317
+			'<code>'.htmlspecialchars($code).'</code>',
318 318
 			$role
319
-		) ) ];
319
+		))];
320 320
 	}
321 321
 
322 322
 	/**
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
 	 * @param string|null $role one of the Role::* constants
325 325
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
326 326
 	 */
327
-	private function renderConstraintScope( $scope, $role ) {
328
-		switch ( $scope ) {
327
+	private function renderConstraintScope($scope, $role) {
328
+		switch ($scope) {
329 329
 			case Context::TYPE_STATEMENT:
330 330
 				$itemId = $this->config->get(
331 331
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -345,10 +345,10 @@  discard block
 block discarded – undo
345 345
 				// callers should never let this happen, but if it does happen,
346 346
 				// showing “unknown value” seems reasonable
347 347
 				// @codeCoverageIgnoreStart
348
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
348
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
349 349
 				// @codeCoverageIgnoreEnd
350 350
 		}
351
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
351
+		return $this->renderEntityId(new ItemId($itemId), $role);
352 352
 	}
353 353
 
354 354
 	/**
@@ -356,8 +356,8 @@  discard block
 block discarded – undo
356 356
 	 * @param string|null $role one of the Role::* constants
357 357
 	 * @return array[] list of parameters as accepted by Message::params()
358 358
 	 */
359
-	private function renderConstraintScopeList( array $scopeList, $role ) {
360
-		return $this->renderList( $scopeList, $role, [ $this, 'renderConstraintScope' ] );
359
+	private function renderConstraintScopeList(array $scopeList, $role) {
360
+		return $this->renderList($scopeList, $role, [$this, 'renderConstraintScope']);
361 361
 	}
362 362
 
363 363
 	/**
@@ -365,25 +365,25 @@  discard block
 block discarded – undo
365 365
 	 * @param string|null $role one of the Role::* constants
366 366
 	 * @return array[] list of a single raw message param (i. e. [ Message::rawParam( … ) ])
367 367
 	 */
368
-	private function renderPropertyScope( $scope, $role ) {
369
-		switch ( $scope ) {
368
+	private function renderPropertyScope($scope, $role) {
369
+		switch ($scope) {
370 370
 			case Context::TYPE_STATEMENT:
371
-				$itemId = $this->config->get( 'WBQualityConstraintsAsMainValueId' );
371
+				$itemId = $this->config->get('WBQualityConstraintsAsMainValueId');
372 372
 				break;
373 373
 			case Context::TYPE_QUALIFIER:
374
-				$itemId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' );
374
+				$itemId = $this->config->get('WBQualityConstraintsAsQualifiersId');
375 375
 				break;
376 376
 			case Context::TYPE_REFERENCE:
377
-				$itemId = $this->config->get( 'WBQualityConstraintsAsReferencesId' );
377
+				$itemId = $this->config->get('WBQualityConstraintsAsReferencesId');
378 378
 				break;
379 379
 			default:
380 380
 				// callers should never let this happen, but if it does happen,
381 381
 				// showing “unknown value” seems reasonable
382 382
 				// @codeCoverageIgnoreStart
383
-				return $this->renderItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
383
+				return $this->renderItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
384 384
 				// @codeCoverageIgnoreEnd
385 385
 		}
386
-		return $this->renderEntityId( new ItemId( $itemId ), $role );
386
+		return $this->renderEntityId(new ItemId($itemId), $role);
387 387
 	}
388 388
 
389 389
 	/**
@@ -391,8 +391,8 @@  discard block
 block discarded – undo
391 391
 	 * @param string|null $role one of the Role::* constants
392 392
 	 * @return array[] list of parameters as accepted by Message::params()
393 393
 	 */
394
-	private function renderPropertyScopeList( array $scopeList, $role ) {
395
-		return $this->renderList( $scopeList, $role, [ $this, 'renderPropertyScope' ] );
394
+	private function renderPropertyScopeList(array $scopeList, $role) {
395
+		return $this->renderList($scopeList, $role, [$this, 'renderPropertyScope']);
396 396
 	}
397 397
 
398 398
 	/**
@@ -400,10 +400,10 @@  discard block
 block discarded – undo
400 400
 	 * @param string|null $role one of the Role::* constants
401 401
 	 * @return array[] list of parameters as accepted by Message::params()
402 402
 	 */
403
-	private function renderLanguage( $languageCode, $role ) {
403
+	private function renderLanguage($languageCode, $role) {
404 404
 		return [
405
-			Message::plaintextParam( Language::fetchLanguageName( $languageCode ) ),
406
-			Message::plaintextParam( $languageCode ),
405
+			Message::plaintextParam(Language::fetchLanguageName($languageCode)),
406
+			Message::plaintextParam($languageCode),
407 407
 		];
408 408
 	}
409 409
 
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessageDeserializer.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -39,23 +39,23 @@  discard block
 block discarded – undo
39 39
 		$this->dataValueFactory = $dataValueFactory;
40 40
 	}
41 41
 
42
-	public function unabbreviateViolationMessageKey( $messageKeySuffix ) {
43
-		return ViolationMessage::MESSAGE_KEY_PREFIX . $messageKeySuffix;
42
+	public function unabbreviateViolationMessageKey($messageKeySuffix) {
43
+		return ViolationMessage::MESSAGE_KEY_PREFIX.$messageKeySuffix;
44 44
 	}
45 45
 
46 46
 	/**
47 47
 	 * @param array $serialization
48 48
 	 * @return ViolationMessage
49 49
 	 */
50
-	public function deserialize( $serialization ) {
51
-		Assert::parameterType( 'array', $serialization, '$serialization' );
50
+	public function deserialize($serialization) {
51
+		Assert::parameterType('array', $serialization, '$serialization');
52 52
 
53 53
 		$message = new ViolationMessage(
54
-			$this->unabbreviateViolationMessageKey( $serialization['k'] )
54
+			$this->unabbreviateViolationMessageKey($serialization['k'])
55 55
 		);
56 56
 
57
-		foreach ( $serialization['a'] as $serializedArgument ) {
58
-			$message = $this->deserializeArgument( $message, $serializedArgument );
57
+		foreach ($serialization['a'] as $serializedArgument) {
58
+			$message = $this->deserializeArgument($message, $serializedArgument);
59 59
 		}
60 60
 
61 61
 		return $message;
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * @param array $serializedArgument [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
67 67
 	 * @return ViolationMessage $message with the deserialized argument appended
68 68
 	 */
69
-	private function deserializeArgument( ViolationMessage $message, array $serializedArgument ) {
69
+	private function deserializeArgument(ViolationMessage $message, array $serializedArgument) {
70 70
 		$methods = [
71 71
 			ViolationMessage::TYPE_ENTITY_ID => 'deserializeEntityId',
72 72
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'deserializeEntityIdList',
@@ -87,23 +87,23 @@  discard block
 block discarded – undo
87 87
 		$serializedValue = $serializedArgument['v'];
88 88
 		$role = $serializedArgument['r'];
89 89
 
90
-		if ( array_key_exists( $type, $methods ) ) {
90
+		if (array_key_exists($type, $methods)) {
91 91
 			$method = $methods[$type];
92
-			$value = $this->$method( $serializedValue );
92
+			$value = $this->$method($serializedValue);
93 93
 		} else {
94 94
 			throw new InvalidArgumentException(
95
-				'Unknown ViolationMessage argument type ' . $type . '!'
95
+				'Unknown ViolationMessage argument type '.$type.'!'
96 96
 			);
97 97
 		}
98 98
 
99
-		return $message->withArgument( $type, $role, $value );
99
+		return $message->withArgument($type, $role, $value);
100 100
 	}
101 101
 
102 102
 	/**
103 103
 	 * @param string $string any value that shall simply be deserialized into itself
104 104
 	 * @return string that same value, unchanged
105 105
 	 */
106
-	private function deserializeStringByIdentity( $string ) {
106
+	private function deserializeStringByIdentity($string) {
107 107
 		return $string;
108 108
 	}
109 109
 
@@ -111,30 +111,30 @@  discard block
 block discarded – undo
111 111
 	 * @param string $entityIdSerialization entity ID serialization
112 112
 	 * @return EntityId
113 113
 	 */
114
-	private function deserializeEntityId( $entityIdSerialization ) {
115
-		return $this->entityIdParser->parse( $entityIdSerialization );
114
+	private function deserializeEntityId($entityIdSerialization) {
115
+		return $this->entityIdParser->parse($entityIdSerialization);
116 116
 	}
117 117
 
118 118
 	/**
119 119
 	 * @param string[] $entityIdSerializations entity ID serializations
120 120
 	 * @return EntityId[]
121 121
 	 */
122
-	private function deserializeEntityIdList( array $entityIdSerializations ) {
123
-		return array_map( [ $this, 'deserializeEntityId' ], $entityIdSerializations );
122
+	private function deserializeEntityIdList(array $entityIdSerializations) {
123
+		return array_map([$this, 'deserializeEntityId'], $entityIdSerializations);
124 124
 	}
125 125
 
126 126
 	/**
127 127
 	 * @param string $valueSerialization entity ID serialization, '::somevalue' or '::novalue'
128 128
 	 * @return ItemIdSnakValue
129 129
 	 */
130
-	private function deserializeItemIdSnakValue( $valueSerialization ) {
131
-		switch ( $valueSerialization ) {
130
+	private function deserializeItemIdSnakValue($valueSerialization) {
131
+		switch ($valueSerialization) {
132 132
 			case '::somevalue':
133 133
 				return ItemIdSnakValue::someValue();
134 134
 			case '::novalue':
135 135
 				return ItemIdSnakValue::noValue();
136 136
 			default:
137
-				return ItemIdSnakValue::fromItemId( $this->deserializeEntityId( $valueSerialization ) );
137
+				return ItemIdSnakValue::fromItemId($this->deserializeEntityId($valueSerialization));
138 138
 		}
139 139
 	}
140 140
 
@@ -142,24 +142,24 @@  discard block
 block discarded – undo
142 142
 	 * @param string[] $valueSerializations entity ID serializations, '::somevalue's or '::novalue's
143 143
 	 * @return ItemIdSnakValue[]
144 144
 	 */
145
-	private function deserializeItemIdSnakValueList( $valueSerializations ) {
146
-		return array_map( [ $this, 'deserializeItemIdSnakValue' ], $valueSerializations );
145
+	private function deserializeItemIdSnakValueList($valueSerializations) {
146
+		return array_map([$this, 'deserializeItemIdSnakValue'], $valueSerializations);
147 147
 	}
148 148
 
149 149
 	/**
150 150
 	 * @param array $dataValueSerialization the data value in array form
151 151
 	 * @return DataValue
152 152
 	 */
153
-	private function deserializeDataValue( array $dataValueSerialization ) {
154
-		return $this->dataValueFactory->newFromArray( $dataValueSerialization );
153
+	private function deserializeDataValue(array $dataValueSerialization) {
154
+		return $this->dataValueFactory->newFromArray($dataValueSerialization);
155 155
 	}
156 156
 
157 157
 	/**
158 158
 	 * @param string $contextTypeAbbreviation
159 159
 	 * @return string one of the Context::TYPE_* constants
160 160
 	 */
161
-	private function deserializeContextType( $contextTypeAbbreviation ) {
162
-		switch ( $contextTypeAbbreviation ) {
161
+	private function deserializeContextType($contextTypeAbbreviation) {
162
+		switch ($contextTypeAbbreviation) {
163 163
 			case 's':
164 164
 				return Context::TYPE_STATEMENT;
165 165
 			case 'q':
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 			default:
170 170
 				// @codeCoverageIgnoreStart
171 171
 				throw new LogicException(
172
-					'Unknown context type abbreviation ' . $contextTypeAbbreviation
172
+					'Unknown context type abbreviation '.$contextTypeAbbreviation
173 173
 				);
174 174
 				// @codeCoverageIgnoreEnd
175 175
 		}
@@ -179,16 +179,16 @@  discard block
 block discarded – undo
179 179
 	 * @param string[] $contextTypeAbbreviations
180 180
 	 * @return string[] Context::TYPE_* constants
181 181
 	 */
182
-	private function deserializeContextTypeList( array $contextTypeAbbreviations ) {
183
-		return array_map( [ $this, 'deserializeContextType' ], $contextTypeAbbreviations );
182
+	private function deserializeContextTypeList(array $contextTypeAbbreviations) {
183
+		return array_map([$this, 'deserializeContextType'], $contextTypeAbbreviations);
184 184
 	}
185 185
 
186 186
 	/**
187 187
 	 * @param mixed $textSerialization {@see MultilingualTextValue::getArrayValue}
188 188
 	 * @return MultilingualTextValue
189 189
 	 */
190
-	private function deserializeMultilingualText( $textSerialization ) {
191
-		return MultilingualTextValue::newFromArray( $textSerialization );
190
+	private function deserializeMultilingualText($textSerialization) {
191
+		return MultilingualTextValue::newFromArray($textSerialization);
192 192
 	}
193 193
 
194 194
 }
Please login to merge, or discard this patch.