Completed
Push — master ( 84189d...a53e2d )
by
unknown
01:39
created
src/ConstraintCheck/Checker/NoneOfChecker.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
 	 * @throws ConstraintParameterException
61 61
 	 * @return CheckResult
62 62
 	 */
63
-	public function checkConstraint( Context $context, Constraint $constraint ) {
64
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
65
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
63
+	public function checkConstraint(Context $context, Constraint $constraint) {
64
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
65
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
66 66
 		}
67 67
 
68 68
 		$parameters = [];
@@ -81,20 +81,20 @@  discard block
 block discarded – undo
81 81
 		$message = null;
82 82
 		$status = CheckResult::STATUS_COMPLIANCE;
83 83
 
84
-		foreach ( $items as $item ) {
85
-			if ( $item->matchesSnak( $snak ) ) {
86
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
87
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
88
-					->withItemIdSnakValueList( $items, Role::OBJECT );
84
+		foreach ($items as $item) {
85
+			if ($item->matchesSnak($snak)) {
86
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
87
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
88
+					->withItemIdSnakValueList($items, Role::OBJECT);
89 89
 				$status = CheckResult::STATUS_VIOLATION;
90 90
 				break;
91 91
 			}
92 92
 		}
93 93
 
94
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95
 	}
96 96
 
97
-	public function checkConstraintParameters( Constraint $constraint ) {
97
+	public function checkConstraintParameters(Constraint $constraint) {
98 98
 		$constraintParameters = $constraint->getConstraintParameters();
99 99
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100
 		$exceptions = [];
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 				$constraintTypeItemId,
105 105
 				true
106 106
 			);
107
-		} catch ( ConstraintParameterException $e ) {
107
+		} catch (ConstraintParameterException $e) {
108 108
 			$exceptions[] = $e;
109 109
 		}
110 110
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/FormatChecker.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 * @throws ConstraintParameterException
86 86
 	 * @return CheckResult
87 87
 	 */
88
-	public function checkConstraint( Context $context, Constraint $constraint ) {
88
+	public function checkConstraint(Context $context, Constraint $constraint) {
89 89
 		$parameters = [];
90 90
 		$constraintParameters = $constraint->getConstraintParameters();
91 91
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 			$constraintParameters,
95 95
 			$constraintTypeItemId
96 96
 		);
97
-		$parameters['pattern'] = [ $format ];
97
+		$parameters['pattern'] = [$format];
98 98
 
99 99
 		$syntaxClarifications = $this->constraintParameterParser->parseSyntaxClarificationParameter(
100 100
 			$constraintParameters
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
 
103 103
 		$snak = $context->getSnak();
104 104
 
105
-		if ( !$snak instanceof PropertyValueSnak ) {
105
+		if (!$snak instanceof PropertyValueSnak) {
106 106
 			// nothing to check
107
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
107
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
108 108
 		}
109 109
 
110 110
 		$dataValue = $snak->getDataValue();
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 		 * error handling:
114 114
 		 *   type of $dataValue for properties with 'Format' constraint has to be 'string' or 'monolingualtext'
115 115
 		 */
116
-		switch ( $dataValue->getType() ) {
116
+		switch ($dataValue->getType()) {
117 117
 			case 'string':
118 118
 				$text = $dataValue->getValue();
119 119
 				break;
@@ -122,37 +122,37 @@  discard block
 block discarded – undo
122 122
 				$text = $dataValue->getText();
123 123
 				break;
124 124
 			default:
125
-				$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
126
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
127
-					->withDataValueType( 'string' )
128
-					->withDataValueType( 'monolingualtext' );
129
-				return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
125
+				$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
126
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
127
+					->withDataValueType('string')
128
+					->withDataValueType('monolingualtext');
129
+				return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
130 130
 		}
131 131
 
132 132
 		if (
133
-			!( $this->sparqlHelper instanceof DummySparqlHelper ) &&
134
-			$this->config->get( 'WBQualityConstraintsCheckFormatConstraint' )
133
+			!($this->sparqlHelper instanceof DummySparqlHelper) &&
134
+			$this->config->get('WBQualityConstraintsCheckFormatConstraint')
135 135
 		) {
136
-			if ( $this->sparqlHelper->matchesRegularExpression( $text, $format ) ) {
136
+			if ($this->sparqlHelper->matchesRegularExpression($text, $format)) {
137 137
 				$message = null;
138 138
 				$status = CheckResult::STATUS_COMPLIANCE;
139 139
 			} else {
140
-				$message = ( new ViolationMessage( 'wbqc-violation-message-format-clarification' ) )
141
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
142
-					->withDataValue( new StringValue( $text ), Role::OBJECT )
143
-					->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE )
144
-					->withMultilingualText( $syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE );
140
+				$message = (new ViolationMessage('wbqc-violation-message-format-clarification'))
141
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
142
+					->withDataValue(new StringValue($text), Role::OBJECT)
143
+					->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE)
144
+					->withMultilingualText($syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE);
145 145
 				$status = CheckResult::STATUS_VIOLATION;
146 146
 			}
147 147
 		} else {
148
-			$message = ( new ViolationMessage( 'wbqc-violation-message-security-reason' ) )
149
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM );
148
+			$message = (new ViolationMessage('wbqc-violation-message-security-reason'))
149
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM);
150 150
 			$status = CheckResult::STATUS_TODO;
151 151
 		}
152
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
152
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
153 153
 	}
154 154
 
155
-	public function checkConstraintParameters( Constraint $constraint ) {
155
+	public function checkConstraintParameters(Constraint $constraint) {
156 156
 		$constraintParameters = $constraint->getConstraintParameters();
157 157
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
158 158
 		$exceptions = [];
@@ -161,14 +161,14 @@  discard block
 block discarded – undo
161 161
 				$constraintParameters,
162 162
 				$constraintTypeItemId
163 163
 			);
164
-		} catch ( ConstraintParameterException $e ) {
164
+		} catch (ConstraintParameterException $e) {
165 165
 			$exceptions[] = $e;
166 166
 		}
167 167
 		try {
168 168
 			$this->constraintParameterParser->parseSyntaxClarificationParameter(
169 169
 				$constraintParameters
170 170
 			);
171
-		} catch ( ConstraintParameterException $e ) {
171
+		} catch (ConstraintParameterException $e) {
172 172
 			$exceptions[] = $e;
173 173
 		}
174 174
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ItemChecker.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -78,9 +78,9 @@  discard block
 block discarded – undo
78 78
 	 * @throws ConstraintParameterException
79 79
 	 * @return CheckResult
80 80
 	 */
81
-	public function checkConstraint( Context $context, Constraint $constraint ) {
82
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
83
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
81
+	public function checkConstraint(Context $context, Constraint $constraint) {
82
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
83
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
84 84
 		}
85 85
 
86 86
 		$parameters = [];
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 			$constraintParameters,
92 92
 			$constraintTypeItemId
93 93
 		);
94
-		$parameters['property'] = [ $propertyId ];
94
+		$parameters['property'] = [$propertyId];
95 95
 
96 96
 		$items = $this->constraintParameterParser->parseItemsParameter(
97 97
 			$constraintParameters,
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 		 *   a) a property only
106 106
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
107 107
 		 */
108
-		if ( $items === [] ) {
108
+		if ($items === []) {
109 109
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
110 110
 				$context->getEntity()->getStatements(),
111 111
 				$propertyId
@@ -118,21 +118,21 @@  discard block
 block discarded – undo
118 118
 			);
119 119
 		}
120 120
 
121
-		if ( $requiredStatement !== null ) {
121
+		if ($requiredStatement !== null) {
122 122
 			$status = CheckResult::STATUS_COMPLIANCE;
123 123
 			$message = null;
124 124
 		} else {
125 125
 			$status = CheckResult::STATUS_VIOLATION;
126
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
127
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
128
-				->withEntityId( $propertyId, Role::PREDICATE )
129
-				->withItemIdSnakValueList( $items, Role::OBJECT );
126
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
127
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
128
+				->withEntityId($propertyId, Role::PREDICATE)
129
+				->withItemIdSnakValueList($items, Role::OBJECT);
130 130
 		}
131 131
 
132
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
132
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
133 133
 	}
134 134
 
135
-	public function checkConstraintParameters( Constraint $constraint ) {
135
+	public function checkConstraintParameters(Constraint $constraint) {
136 136
 		$constraintParameters = $constraint->getConstraintParameters();
137 137
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
138 138
 		$exceptions = [];
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 				$constraintParameters,
142 142
 				$constraintTypeItemId
143 143
 			);
144
-		} catch ( ConstraintParameterException $e ) {
144
+		} catch (ConstraintParameterException $e) {
145 145
 			$exceptions[] = $e;
146 146
 		}
147 147
 		try {
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 				$constraintTypeItemId,
151 151
 				false
152 152
 			);
153
-		} catch ( ConstraintParameterException $e ) {
153
+		} catch (ConstraintParameterException $e) {
154 154
 			$exceptions[] = $e;
155 155
 		}
156 156
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/CommonsLinkChecker.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -70,26 +70,26 @@  discard block
 block discarded – undo
70 70
 	 * @return array first element is the namespace number (default namespace for TitleParser),
71 71
 	 * second element is a string to prepend to the title before giving it to the TitleParser
72 72
 	 */
73
-	private function getCommonsNamespace( $namespace ) {
74
-		switch ( $namespace ) {
73
+	private function getCommonsNamespace($namespace) {
74
+		switch ($namespace) {
75 75
 			case '':
76
-				return [ NS_MAIN, '' ];
76
+				return [NS_MAIN, ''];
77 77
 			// extra namespaces, see operations/mediawiki-config.git,
78 78
 			// wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey
79 79
 			case 'Creator':
80
-				return [ 100, '' ];
80
+				return [100, ''];
81 81
 			case 'TimedText':
82
-				return [ 102, '' ];
82
+				return [102, ''];
83 83
 			case 'Sequence':
84
-				return [ 104, '' ];
84
+				return [104, ''];
85 85
 			case 'Institution':
86
-				return [ 106, '' ];
86
+				return [106, ''];
87 87
 			// extension namespace, see mediawiki/extensions/JsonConfig.git,
88 88
 			// extension.json, 'namespaces' key, third element
89 89
 			case 'Data':
90
-				return [ 486, '' ];
90
+				return [486, ''];
91 91
 			default:
92
-				return [ NS_MAIN, $namespace . ':' ];
92
+				return [NS_MAIN, $namespace.':'];
93 93
 		}
94 94
 	}
95 95
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 * @throws ConstraintParameterException
103 103
 	 * @return CheckResult
104 104
 	 */
105
-	public function checkConstraint( Context $context, Constraint $constraint ) {
105
+	public function checkConstraint(Context $context, Constraint $constraint) {
106 106
 		$parameters = [];
107 107
 		$constraintParameters = $constraint->getConstraintParameters();
108 108
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
@@ -111,13 +111,13 @@  discard block
 block discarded – undo
111 111
 			$constraintParameters,
112 112
 			$constraintTypeItemId
113 113
 		);
114
-		$parameters['namespace'] = [ $namespace ];
114
+		$parameters['namespace'] = [$namespace];
115 115
 
116 116
 		$snak = $context->getSnak();
117 117
 
118
-		if ( !$snak instanceof PropertyValueSnak ) {
118
+		if (!$snak instanceof PropertyValueSnak) {
119 119
 			// nothing to check
120
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
120
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
121 121
 		}
122 122
 
123 123
 		$dataValue = $snak->getDataValue();
@@ -127,46 +127,46 @@  discard block
 block discarded – undo
127 127
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
128 128
 		 *   parameter $namespace can be null, works for commons galleries
129 129
 		 */
130
-		if ( $dataValue->getType() !== 'string' ) {
131
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
132
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
133
-				->withDataValueType( 'string' );
134
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
130
+		if ($dataValue->getType() !== 'string') {
131
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
132
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
133
+				->withDataValueType('string');
134
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
135 135
 		}
136 136
 
137 137
 		$commonsLink = $dataValue->getValue();
138 138
 
139 139
 		try {
140
-			if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
141
-				throw new MalformedTitleException( 'caught below', $commonsLink );
140
+			if (!$this->commonsLinkIsWellFormed($commonsLink)) {
141
+				throw new MalformedTitleException('caught below', $commonsLink);
142 142
 			}
143 143
 
144
-			$prefix = $this->getCommonsNamespace( $namespace )[1];
144
+			$prefix = $this->getCommonsNamespace($namespace)[1];
145 145
 			$normalizedTitle = $this->pageNameNormalizer->normalizePageName(
146
-				$prefix . $commonsLink,
146
+				$prefix.$commonsLink,
147 147
 				'https://commons.wikimedia.org/w/api.php'
148 148
 			);
149 149
 
150
-			if ( $normalizedTitle === false ) {
151
-				if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
152
-					throw new MalformedTitleException( 'caught below', $commonsLink );
150
+			if ($normalizedTitle === false) {
151
+				if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
152
+					throw new MalformedTitleException('caught below', $commonsLink);
153 153
 				} else {
154
-					$message = new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' );
154
+					$message = new ViolationMessage('wbqc-violation-message-commons-link-no-existent');
155 155
 					$status = CheckResult::STATUS_VIOLATION;
156 156
 				}
157 157
 			} else {
158 158
 				$message = null;
159 159
 				$status = CheckResult::STATUS_COMPLIANCE;
160 160
 			}
161
-		} catch ( MalformedTitleException $e ) {
162
-			$message = new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' );
161
+		} catch (MalformedTitleException $e) {
162
+			$message = new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed');
163 163
 			$status = CheckResult::STATUS_VIOLATION;
164 164
 		}
165 165
 
166
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
166
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
167 167
 	}
168 168
 
169
-	public function checkConstraintParameters( Constraint $constraint ) {
169
+	public function checkConstraintParameters(Constraint $constraint) {
170 170
 		$constraintParameters = $constraint->getConstraintParameters();
171 171
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
172 172
 		$exceptions = [];
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 				$constraintParameters,
176 176
 				$constraintTypeItemId
177 177
 			);
178
-		} catch ( ConstraintParameterException $e ) {
178
+		} catch (ConstraintParameterException $e) {
179 179
 			$exceptions[] = $e;
180 180
 		}
181 181
 		return $exceptions;
@@ -186,9 +186,9 @@  discard block
 block discarded – undo
186 186
 	 *
187 187
 	 * @return bool
188 188
 	 */
189
-	private function commonsLinkIsWellFormed( $commonsLink ) {
190
-		$toReplace = [ "_", "%20" ];
191
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
189
+	private function commonsLinkIsWellFormed($commonsLink) {
190
+		$toReplace = ["_", "%20"];
191
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
192 192
 
193 193
 		return $commonsLink === $compareString;
194 194
 	}
@@ -202,9 +202,9 @@  discard block
 block discarded – undo
202 202
 	 *
203 203
 	 * @return bool
204 204
 	 */
205
-	private function valueIncludesNamespace( $value, $namespace ) {
205
+	private function valueIncludesNamespace($value, $namespace) {
206 206
 		return $namespace !== '' &&
207
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
207
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
208 208
 	}
209 209
 
210 210
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
 	 * @throws ConstraintParameterException
63 63
 	 * @return CheckResult
64 64
 	 */
65
-	public function checkConstraint( Context $context, Constraint $constraint ) {
66
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
67
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
65
+	public function checkConstraint(Context $context, Constraint $constraint) {
66
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
67
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
68 68
 		}
69 69
 
70 70
 		$parameters = [];
@@ -81,33 +81,33 @@  discard block
 block discarded – undo
81 81
 		$status = CheckResult::STATUS_COMPLIANCE;
82 82
 
83 83
 		/** @var Snak $qualifier */
84
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
84
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
85 85
 			$allowedQualifier = false;
86
-			foreach ( $properties as $property ) {
87
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
86
+			foreach ($properties as $property) {
87
+				if ($qualifier->getPropertyId()->equals($property)) {
88 88
 					$allowedQualifier = true;
89 89
 					break;
90 90
 				}
91 91
 			}
92
-			if ( !$allowedQualifier ) {
93
-				if ( empty( $properties ) || $properties === [ '' ] ) {
94
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
95
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
92
+			if (!$allowedQualifier) {
93
+				if (empty($properties) || $properties === ['']) {
94
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
95
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
96 96
 				} else {
97
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
98
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
99
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
100
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
97
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
98
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
99
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
100
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
101 101
 				}
102 102
 				$status = CheckResult::STATUS_VIOLATION;
103 103
 				break;
104 104
 			}
105 105
 		}
106 106
 
107
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
107
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
108 108
 	}
109 109
 
110
-	public function checkConstraintParameters( Constraint $constraint ) {
110
+	public function checkConstraintParameters(Constraint $constraint) {
111 111
 		$constraintParameters = $constraint->getConstraintParameters();
112 112
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
113 113
 		$exceptions = [];
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 				$constraintParameters,
117 117
 				$constraintTypeItemId
118 118
 			);
119
-		} catch ( ConstraintParameterException $e ) {
119
+		} catch (ConstraintParameterException $e) {
120 120
 			$exceptions[] = $e;
121 121
 		}
122 122
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
 	 * @throws ConstraintParameterException
63 63
 	 * @return CheckResult
64 64
 	 */
65
-	public function checkConstraint( Context $context, Constraint $constraint ) {
66
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
67
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
65
+	public function checkConstraint(Context $context, Constraint $constraint) {
66
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
67
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
68 68
 		}
69 69
 
70 70
 		$parameters = [];
@@ -75,26 +75,26 @@  discard block
 block discarded – undo
75 75
 			$constraintParameters,
76 76
 			$constraintTypeItemId
77 77
 		);
78
-		$parameters['property'] = [ $propertyId ];
78
+		$parameters['property'] = [$propertyId];
79 79
 
80
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
81
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
82
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
80
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
81
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
82
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
83 83
 		$status = CheckResult::STATUS_VIOLATION;
84 84
 
85 85
 		/** @var Snak $qualifier */
86
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
87
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
86
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
87
+			if ($propertyId->equals($qualifier->getPropertyId())) {
88 88
 				$message = null;
89 89
 				$status = CheckResult::STATUS_COMPLIANCE;
90 90
 				break;
91 91
 			}
92 92
 		}
93 93
 
94
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95
 	}
96 96
 
97
-	public function checkConstraintParameters( Constraint $constraint ) {
97
+	public function checkConstraintParameters(Constraint $constraint) {
98 98
 		$constraintParameters = $constraint->getConstraintParameters();
99 99
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100
 		$exceptions = [];
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 				$constraintParameters,
104 104
 				$constraintTypeItemId
105 105
 			);
106
-		} catch ( ConstraintParameterException $e ) {
106
+		} catch (ConstraintParameterException $e) {
107 107
 			$exceptions[] = $e;
108 108
 		}
109 109
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/OneOfChecker.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
 	 * @throws ConstraintParameterException
61 61
 	 * @return CheckResult
62 62
 	 */
63
-	public function checkConstraint( Context $context, Constraint $constraint ) {
64
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
65
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
63
+	public function checkConstraint(Context $context, Constraint $constraint) {
64
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
65
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
66 66
 		}
67 67
 
68 68
 		$parameters = [];
@@ -78,23 +78,23 @@  discard block
 block discarded – undo
78 78
 
79 79
 		$snak = $context->getSnak();
80 80
 
81
-		$message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) )
82
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
83
-			->withItemIdSnakValueList( $items, Role::OBJECT );
81
+		$message = (new ViolationMessage('wbqc-violation-message-one-of'))
82
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
83
+			->withItemIdSnakValueList($items, Role::OBJECT);
84 84
 		$status = CheckResult::STATUS_VIOLATION;
85 85
 
86
-		foreach ( $items as $item ) {
87
-			if ( $item->matchesSnak( $snak ) ) {
86
+		foreach ($items as $item) {
87
+			if ($item->matchesSnak($snak)) {
88 88
 				$message = null;
89 89
 				$status = CheckResult::STATUS_COMPLIANCE;
90 90
 				break;
91 91
 			}
92 92
 		}
93 93
 
94
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95
 	}
96 96
 
97
-	public function checkConstraintParameters( Constraint $constraint ) {
97
+	public function checkConstraintParameters(Constraint $constraint) {
98 98
 		$constraintParameters = $constraint->getConstraintParameters();
99 99
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100
 		$exceptions = [];
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 				$constraintTypeItemId,
105 105
 				true
106 106
 			);
107
-		} catch ( ConstraintParameterException $e ) {
107
+		} catch (ConstraintParameterException $e) {
108 108
 			$exceptions[] = $e;
109 109
 		}
110 110
 		return $exceptions;
Please login to merge, or discard this patch.
src/Html/HtmlTableCellBuilder.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -38,9 +38,9 @@  discard block
 block discarded – undo
38 38
 	 *
39 39
 	 * @throws InvalidArgumentException
40 40
 	 */
41
-	public function __construct( $content, array $attributes = [], $isRawContent = false ) {
42
-		Assert::parameterType( 'string', $content, '$content' );
43
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
41
+	public function __construct($content, array $attributes = [], $isRawContent = false) {
42
+		Assert::parameterType('string', $content, '$content');
43
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
44 44
 
45 45
 		$this->content = $content;
46 46
 		$this->attributes = $attributes;
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
 	 * @suppress SecurityCheck-DoubleEscaped
67 67
 	 */
68 68
 	public function toHtml() {
69
-		if ( $this->isRawContent ) {
70
-			return Html::rawElement( 'td', $this->getAttributes(), $this->content );
69
+		if ($this->isRawContent) {
70
+			return Html::rawElement('td', $this->getAttributes(), $this->content);
71 71
 		} else {
72
-			return Html::element( 'td', $this->getAttributes(), $this->content );
72
+			return Html::element('td', $this->getAttributes(), $this->content);
73 73
 		}
74 74
 	}
75 75
 
Please login to merge, or discard this patch.
src/Html/HtmlTableHeaderBuilder.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
 	 *
42 42
 	 * @throws InvalidArgumentException
43 43
 	 */
44
-	public function __construct( $content, $isSortable = false, $isRawContent = false ) {
45
-		Assert::parameterType( 'string', $content, '$content' );
46
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
47
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
44
+	public function __construct($content, $isSortable = false, $isRawContent = false) {
45
+		Assert::parameterType('string', $content, '$content');
46
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
47
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
48 48
 
49 49
 		$this->content = $content;
50 50
 		$this->isSortable = $isSortable;
@@ -71,20 +71,20 @@  discard block
 block discarded – undo
71 71
 	 * @return string HTML
72 72
 	 */
73 73
 	public function toHtml() {
74
-		$attributes = [ 'role' => 'columnheader button' ];
74
+		$attributes = ['role' => 'columnheader button'];
75 75
 
76
-		if ( !$this->isSortable ) {
76
+		if (!$this->isSortable) {
77 77
 			$attributes['class'] = 'unsortable';
78 78
 		}
79 79
 
80
-		if ( !$this->isRawContent ) {
80
+		if (!$this->isRawContent) {
81 81
 			// @phan-suppress-next-line SecurityCheck-DoubleEscaped
82
-			$content = htmlspecialchars( $this->content );
82
+			$content = htmlspecialchars($this->content);
83 83
 		} else {
84 84
 			$content = $this->content;
85 85
 		}
86 86
 
87
-		return Html::rawElement( 'th', $attributes, $content );
87
+		return Html::rawElement('th', $attributes, $content);
88 88
 	}
89 89
 
90 90
 }
Please login to merge, or discard this patch.