Inspection of "Merge "Add support for entity ID lists to Violatio..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bfeacc...2d81b2 )

unknown

created 2018-01-31 09:04 UTC

Status

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -83,34 +83,34 @@  discard block
 block discarded – undo
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE );
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$classes = $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$classes = $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$parameters['class'] = array_map(
-			function( $id ) {
-				return new ItemId( $id );
+			function($id) {
+				return new ItemId($id);
 			},
 			$classes
 		);
 
-		$relation = $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$relation = $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$relationIds = [];
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
 		}
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
 		}
-		$parameters['relation'] = [ $relation ];
+		$parameters['relation'] = [$relation];
 
 		$result = $this->typeCheckerHelper->hasClassInRelation(
 			$context->getEntity()->getStatements(),
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
 			$classes
 		);
 
-		if ( $result->getBool() ) {
+		if ($result->getBool()) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
@@ -132,21 +132,21 @@  discard block
 block discarded – undo
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $result->getMetadata() );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($result->getMetadata());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ItemChecker.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -85,18 +85,18 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		/*
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
@@ -117,35 +117,35 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = wfMessage( 'wbqc-violation-message-item' );
+			$message = wfMessage('wbqc-violation-message-item');
 			$message->rawParams(
-				$this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ),
-				$this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE )
+				$this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY),
+				$this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE)
 			);
-			$message->numParams( count( $items ) );
-			$message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
+			$message->numParams(count($items));
+			$message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
 			$message = $message->escaped();
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/OneOfChecker.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -67,43 +67,43 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
 		$parameters['item'] = $items;
 
 		$snak = $context->getSnak();
 
-		$message = wfMessage( 'wbqc-violation-message-one-of' );
-		$message->rawParams( $this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ) );
-		$message->numParams( count( $items ) );
-		$message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
+		$message = wfMessage('wbqc-violation-message-one-of');
+		$message->rawParams($this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE));
+		$message->numParams(count($items));
+		$message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
 		$message = $message->escaped();
 		$status = CheckResult::STATUS_VIOLATION;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ValueTypeChecker.php 1 patch

Spacing +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -98,37 +98,37 @@  discard block
 block discarded – undo
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$classes = $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$classes = $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$parameters['class'] = array_map(
-			function( $id ) {
-				return new ItemId( $id );
+			function($id) {
+				return new ItemId($id);
 			},
 			$classes
 		);
 
-		$relation = $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$relation = $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$relationIds = [];
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
 		}
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
 		}
-		$parameters['relation'] = [ $relation ];
+		$parameters['relation'] = [$relation];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -137,22 +137,22 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = wfMessage( "wbqc-violation-message-value-needed-of-type" )
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = wfMessage("wbqc-violation-message-value-needed-of-type")
 				->rawParams(
-					$this->constraintParameterRenderer->formatItemId( $constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM ),
+					$this->constraintParameterRenderer->formatItemId($constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM),
 					'wikibase-entityid' // TODO is there a message for this type so we can localize it?
 				)
 				->escaped();
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
-		$item = $this->entityLookup->getEntity( $dataValue->getEntityId() );
+		$item = $this->entityLookup->getEntity($dataValue->getEntityId());
 
-		if ( !( $item instanceof StatementListProvider ) ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!($item instanceof StatementListProvider)) {
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$statements = $item->getStatements();
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
 			$classes
 		);
 
-		if ( $result->getBool() ) {
+		if ($result->getBool()) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
@@ -177,21 +177,21 @@  discard block
 block discarded – undo
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $result->getMetadata() );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($result->getMetadata());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/QualifierChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -47,16 +47,16 @@
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_QUALIFIER ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_QUALIFIER) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-qualifier' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-qualifier');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/MultiValueChecker.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -55,9 +55,9 @@  discard block
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$propertyId = $context->getSnak()->getPropertyId();
@@ -69,18 +69,18 @@  discard block
 block discarded – undo
 			$propertyId
 		);
 
-		if ( $propertyCount <= 1 ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-multi-value' );
+		if ($propertyCount <= 1) {
+			$message = new ViolationMessage('wbqc-violation-message-multi-value');
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ValueOnlyChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -36,16 +36,16 @@
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_STATEMENT ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_STATEMENT) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-valueOnly');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php 1 patch

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -88,25 +88,25 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -115,22 +115,22 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = wfMessage( "wbqc-violation-message-value-needed-of-type" )
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = wfMessage("wbqc-violation-message-value-needed-of-type")
 				->rawParams(
-					$this->constraintParameterRenderer->formatItemId( $constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM ),
+					$this->constraintParameterRenderer->formatItemId($constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM),
 					'wikibase-entityid' // TODO is there a message for this type so we can localize it?
 				)
 				->escaped();
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( $targetEntity === null ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if ($targetEntity === null) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -151,37 +151,37 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = wfMessage( 'wbqc-violation-message-target-required-claim' );
+			$message = wfMessage('wbqc-violation-message-target-required-claim');
 			$message->rawParams(
-				$this->constraintParameterRenderer->formatEntityId( $targetEntityId, Role::SUBJECT ),
-				$this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE )
+				$this->constraintParameterRenderer->formatEntityId($targetEntityId, Role::SUBJECT),
+				$this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE)
 			);
-			$message->numParams( count( $items ) );
-			$message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
+			$message->numParams(count($items));
+			$message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
 			$message = $message->escaped();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -36,16 +36,16 @@
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-reference');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

		@@ -83,34 +83,34 @@ discard block
		block discarded – undo
83	83	* @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
84	84	* @return CheckResult
85	85	*/
86		- public function checkConstraint( Context $context, Constraint $constraint ) {
87		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
88		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	86	+ public function checkConstraint(Context $context, Constraint $constraint) {
	87	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	88	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
89	89	}
90		- if ( $context->getType() === Context::TYPE_REFERENCE ) {
91		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE );
	90	+ if ($context->getType() === Context::TYPE_REFERENCE) {
	91	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE);
92	92	}
93	93
94	94	$parameters = [];
95	95	$constraintParameters = $constraint->getConstraintParameters();
96	96
97		- $classes = $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
	97	+ $classes = $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
98	98	$parameters['class'] = array_map(
99		- function( $id ) {
100		- return new ItemId( $id );
	99	+ function($id) {
	100	+ return new ItemId($id);
101	101	},
102	102	$classes
103	103	);
104	104
105		- $relation = $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
	105	+ $relation = $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
106	106	$relationIds = [];
107		- if ( $relation === 'instance' \|\| $relation === 'instanceOrSubclass' ) {
108		- $relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
	107	+ if ($relation === 'instance' \|\| $relation === 'instanceOrSubclass') {
	108	+ $relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
109	109	}
110		- if ( $relation === 'subclass' \|\| $relation === 'instanceOrSubclass' ) {
111		- $relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
	110	+ if ($relation === 'subclass' \|\| $relation === 'instanceOrSubclass') {
	111	+ $relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
112	112	}
113		- $parameters['relation'] = [ $relation ];
	113	+ $parameters['relation'] = [$relation];
114	114
115	115	$result = $this->typeCheckerHelper->hasClassInRelation(
116	116	$context->getEntity()->getStatements(),
		@@ -118,7 +118,7 @@ discard block
		block discarded – undo
118	118	$classes
119	119	);
120	120
121		- if ( $result->getBool() ) {
	121	+ if ($result->getBool()) {
122	122	$message = null;
123	123	$status = CheckResult::STATUS_COMPLIANCE;
124	124	} else {
		@@ -132,21 +132,21 @@ discard block
		block discarded – undo
132	132	$status = CheckResult::STATUS_VIOLATION;
133	133	}
134	134
135		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
136		- ->withMetadata( $result->getMetadata() );
	135	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	136	+ ->withMetadata($result->getMetadata());
137	137	}
138	138
139		- public function checkConstraintParameters( Constraint $constraint ) {
	139	+ public function checkConstraintParameters(Constraint $constraint) {
140	140	$constraintParameters = $constraint->getConstraintParameters();
141	141	$exceptions = [];
142	142	try {
143		- $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
144		- } catch ( ConstraintParameterException $e ) {
	143	+ $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	144	+ } catch (ConstraintParameterException $e) {
145	145	$exceptions[] = $e;
146	146	}
147	147	try {
148		- $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
149		- } catch ( ConstraintParameterException $e ) {
	148	+ $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	149	+ } catch (ConstraintParameterException $e) {
150	150	$exceptions[] = $e;
151	151	}
152	152	return $exceptions;

		@@ -85,18 +85,18 @@ discard block
		block discarded – undo
85	85	* @throws ConstraintParameterException
86	86	* @return CheckResult
87	87	*/
88		- public function checkConstraint( Context $context, Constraint $constraint ) {
89		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
90		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	88	+ public function checkConstraint(Context $context, Constraint $constraint) {
	89	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	90	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
91	91	}
92	92
93	93	$parameters = [];
94	94	$constraintParameters = $constraint->getConstraintParameters();
95	95
96		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
97		- $parameters['property'] = [ $propertyId ];
	96	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	97	+ $parameters['property'] = [$propertyId];
98	98
99		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
	99	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
100	100	$parameters['items'] = $items;
101	101
102	102	/*
		@@ -104,7 +104,7 @@ discard block
		block discarded – undo
104	104	* a) a property only
105	105	* b) a property and a number of items (each combination of property and item forming an individual claim)
106	106	*/
107		- if ( $items === [] ) {
	107	+ if ($items === []) {
108	108	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
109	109	$context->getEntity()->getStatements(),
110	110	$propertyId
		@@ -117,35 +117,35 @@ discard block
		block discarded – undo
117	117	);
118	118	}
119	119
120		- if ( $requiredStatement !== null ) {
	120	+ if ($requiredStatement !== null) {
121	121	$status = CheckResult::STATUS_COMPLIANCE;
122	122	$message = null;
123	123	} else {
124	124	$status = CheckResult::STATUS_VIOLATION;
125		- $message = wfMessage( 'wbqc-violation-message-item' );
	125	+ $message = wfMessage('wbqc-violation-message-item');
126	126	$message->rawParams(
127		- $this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ),
128		- $this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE )
	127	+ $this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY),
	128	+ $this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE)
129	129	);
130		- $message->numParams( count( $items ) );
131		- $message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
	130	+ $message->numParams(count($items));
	131	+ $message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
132	132	$message = $message->escaped();
133	133	}
134	134
135		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	135	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
136	136	}
137	137
138		- public function checkConstraintParameters( Constraint $constraint ) {
	138	+ public function checkConstraintParameters(Constraint $constraint) {
139	139	$constraintParameters = $constraint->getConstraintParameters();
140	140	$exceptions = [];
141	141	try {
142		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
143		- } catch ( ConstraintParameterException $e ) {
	142	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	143	+ } catch (ConstraintParameterException $e) {
144	144	$exceptions[] = $e;
145	145	}
146	146	try {
147		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
148		- } catch ( ConstraintParameterException $e ) {
	147	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
	148	+ } catch (ConstraintParameterException $e) {
149	149	$exceptions[] = $e;
150	150	}
151	151	return $exceptions;

		@@ -67,43 +67,43 @@
		block discarded – undo
67	67	* @throws ConstraintParameterException
68	68	* @return CheckResult
69	69	*/
70		- public function checkConstraint( Context $context, Constraint $constraint ) {
71		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	70	+ public function checkConstraint(Context $context, Constraint $constraint) {
	71	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	72	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
73	73	}
74	74
75	75	$parameters = [];
76	76	$constraintParameters = $constraint->getConstraintParameters();
77	77
78		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
	78	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
79	79	$parameters['item'] = $items;
80	80
81	81	$snak = $context->getSnak();
82	82
83		- $message = wfMessage( 'wbqc-violation-message-one-of' );
84		- $message->rawParams( $this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ) );
85		- $message->numParams( count( $items ) );
86		- $message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
	83	+ $message = wfMessage('wbqc-violation-message-one-of');
	84	+ $message->rawParams($this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE));
	85	+ $message->numParams(count($items));
	86	+ $message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
87	87	$message = $message->escaped();
88	88	$status = CheckResult::STATUS_VIOLATION;
89	89
90		- foreach ( $items as $item ) {
91		- if ( $item->matchesSnak( $snak ) ) {
	90	+ foreach ($items as $item) {
	91	+ if ($item->matchesSnak($snak)) {
92	92	$message = null;
93	93	$status = CheckResult::STATUS_COMPLIANCE;
94	94	break;
95	95	}
96	96	}
97	97
98		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	98	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
99	99	}
100	100
101		- public function checkConstraintParameters( Constraint $constraint ) {
	101	+ public function checkConstraintParameters(Constraint $constraint) {
102	102	$constraintParameters = $constraint->getConstraintParameters();
103	103	$exceptions = [];
104	104	try {
105		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
106		- } catch ( ConstraintParameterException $e ) {
	105	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
	106	+ } catch (ConstraintParameterException $e) {
107	107	$exceptions[] = $e;
108	108	}
109	109	return $exceptions;

		@@ -98,37 +98,37 @@ discard block
		block discarded – undo
98	98	* @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
99	99	* @return CheckResult
100	100	*/
101		- public function checkConstraint( Context $context, Constraint $constraint ) {
102		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
103		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	101	+ public function checkConstraint(Context $context, Constraint $constraint) {
	102	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	103	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
104	104	}
105	105
106	106	$parameters = [];
107	107	$constraintParameters = $constraint->getConstraintParameters();
108	108
109		- $classes = $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
	109	+ $classes = $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
110	110	$parameters['class'] = array_map(
111		- function( $id ) {
112		- return new ItemId( $id );
	111	+ function($id) {
	112	+ return new ItemId($id);
113	113	},
114	114	$classes
115	115	);
116	116
117		- $relation = $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
	117	+ $relation = $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
118	118	$relationIds = [];
119		- if ( $relation === 'instance' \|\| $relation === 'instanceOrSubclass' ) {
120		- $relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
	119	+ if ($relation === 'instance' \|\| $relation === 'instanceOrSubclass') {
	120	+ $relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
121	121	}
122		- if ( $relation === 'subclass' \|\| $relation === 'instanceOrSubclass' ) {
123		- $relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
	122	+ if ($relation === 'subclass' \|\| $relation === 'instanceOrSubclass') {
	123	+ $relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
124	124	}
125		- $parameters['relation'] = [ $relation ];
	125	+ $parameters['relation'] = [$relation];
126	126
127	127	$snak = $context->getSnak();
128	128
129		- if ( !$snak instanceof PropertyValueSnak ) {
	129	+ if (!$snak instanceof PropertyValueSnak) {
130	130	// nothing to check
131		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	131	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
132	132	}
133	133
134	134	$dataValue = $snak->getDataValue();
		@@ -137,22 +137,22 @@ discard block
		block discarded – undo
137	137	* error handling:
138	138	* type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid'
139	139	*/
140		- if ( $dataValue->getType() !== 'wikibase-entityid' ) {
141		- $message = wfMessage( "wbqc-violation-message-value-needed-of-type" )
	140	+ if ($dataValue->getType() !== 'wikibase-entityid') {
	141	+ $message = wfMessage("wbqc-violation-message-value-needed-of-type")
142	142	->rawParams(
143		- $this->constraintParameterRenderer->formatItemId( $constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM ),
	143	+ $this->constraintParameterRenderer->formatItemId($constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM),
144	144	'wikibase-entityid' // TODO is there a message for this type so we can localize it?
145	145	)
146	146	->escaped();
147		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	147	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
148	148	}
149	149	/** @var EntityIdValue $dataValue */
150	150
151		- $item = $this->entityLookup->getEntity( $dataValue->getEntityId() );
	151	+ $item = $this->entityLookup->getEntity($dataValue->getEntityId());
152	152
153		- if ( !( $item instanceof StatementListProvider ) ) {
154		- $message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
155		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	153	+ if (!($item instanceof StatementListProvider)) {
	154	+ $message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
	155	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
156	156	}
157	157
158	158	$statements = $item->getStatements();
		@@ -163,7 +163,7 @@ discard block
		block discarded – undo
163	163	$classes
164	164	);
165	165
166		- if ( $result->getBool() ) {
	166	+ if ($result->getBool()) {
167	167	$message = null;
168	168	$status = CheckResult::STATUS_COMPLIANCE;
169	169	} else {
		@@ -177,21 +177,21 @@ discard block
		block discarded – undo
177	177	$status = CheckResult::STATUS_VIOLATION;
178	178	}
179	179
180		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
181		- ->withMetadata( $result->getMetadata() );
	180	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	181	+ ->withMetadata($result->getMetadata());
182	182	}
183	183
184		- public function checkConstraintParameters( Constraint $constraint ) {
	184	+ public function checkConstraintParameters(Constraint $constraint) {
185	185	$constraintParameters = $constraint->getConstraintParameters();
186	186	$exceptions = [];
187	187	try {
188		- $this->constraintParameterParser->parseClassParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
189		- } catch ( ConstraintParameterException $e ) {
	188	+ $this->constraintParameterParser->parseClassParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	189	+ } catch (ConstraintParameterException $e) {
190	190	$exceptions[] = $e;
191	191	}
192	192	try {
193		- $this->constraintParameterParser->parseRelationParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
194		- } catch ( ConstraintParameterException $e ) {
	193	+ $this->constraintParameterParser->parseRelationParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	194	+ } catch (ConstraintParameterException $e) {
195	195	$exceptions[] = $e;
196	196	}
197	197	return $exceptions;

		@@ -47,16 +47,16 @@
		block discarded – undo
47	47	*
48	48	* @return CheckResult
49	49	*/
50		- public function checkConstraint( Context $context, Constraint $constraint ) {
51		- if ( $context->getType() === Context::TYPE_QUALIFIER ) {
52		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	50	+ public function checkConstraint(Context $context, Constraint $constraint) {
	51	+ if ($context->getType() === Context::TYPE_QUALIFIER) {
	52	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
53	53	} else {
54		- $message = new ViolationMessage( 'wbqc-violation-message-qualifier' );
55		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	54	+ $message = new ViolationMessage('wbqc-violation-message-qualifier');
	55	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
56	56	}
57	57	}
58	58
59		- public function checkConstraintParameters( Constraint $constraint ) {
	59	+ public function checkConstraintParameters(Constraint $constraint) {
60	60	// no parameters
61	61	return [];
62	62	}

		@@ -55,9 +55,9 @@ discard block
		block discarded – undo
55	55	*
56	56	* @return CheckResult
57	57	*/
58		- public function checkConstraint( Context $context, Constraint $constraint ) {
59		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
60		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	58	+ public function checkConstraint(Context $context, Constraint $constraint) {
	59	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	60	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
61	61	}
62	62
63	63	$propertyId = $context->getSnak()->getPropertyId();
		@@ -69,18 +69,18 @@ discard block
		block discarded – undo
69	69	$propertyId
70	70	);
71	71
72		- if ( $propertyCount <= 1 ) {
73		- $message = new ViolationMessage( 'wbqc-violation-message-multi-value' );
	72	+ if ($propertyCount <= 1) {
	73	+ $message = new ViolationMessage('wbqc-violation-message-multi-value');
74	74	$status = CheckResult::STATUS_VIOLATION;
75	75	} else {
76	76	$message = null;
77	77	$status = CheckResult::STATUS_COMPLIANCE;
78	78	}
79	79
80		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	80	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
81	81	}
82	82
83		- public function checkConstraintParameters( Constraint $constraint ) {
	83	+ public function checkConstraintParameters(Constraint $constraint) {
84	84	// no parameters
85	85	return [];
86	86	}

		@@ -36,16 +36,16 @@
		block discarded – undo
36	36	];
37	37	}
38	38
39		- public function checkConstraint( Context $context, Constraint $constraint ) {
40		- if ( $context->getType() === Context::TYPE_STATEMENT ) {
41		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	39	+ public function checkConstraint(Context $context, Constraint $constraint) {
	40	+ if ($context->getType() === Context::TYPE_STATEMENT) {
	41	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
42	42	} else {
43		- $message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
44		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	43	+ $message = new ViolationMessage('wbqc-violation-message-valueOnly');
	44	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
45	45	}
46	46	}
47	47
48		- public function checkConstraintParameters( Constraint $constraint ) {
	48	+ public function checkConstraintParameters(Constraint $constraint) {
49	49	// no parameters
50	50	return [];
51	51	}

		@@ -88,25 +88,25 @@ discard block
		block discarded – undo
88	88	* @throws ConstraintParameterException
89	89	* @return CheckResult
90	90	*/
91		- public function checkConstraint( Context $context, Constraint $constraint ) {
92		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
93		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	91	+ public function checkConstraint(Context $context, Constraint $constraint) {
	92	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	93	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
94	94	}
95	95
96	96	$parameters = [];
97	97	$constraintParameters = $constraint->getConstraintParameters();
98	98
99		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
100		- $parameters['property'] = [ $propertyId ];
	99	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	100	+ $parameters['property'] = [$propertyId];
101	101
102		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
	102	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
103	103	$parameters['items'] = $items;
104	104
105	105	$snak = $context->getSnak();
106	106
107		- if ( !$snak instanceof PropertyValueSnak ) {
	107	+ if (!$snak instanceof PropertyValueSnak) {
108	108	// nothing to check
109		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	109	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
110	110	}
111	111
112	112	$dataValue = $snak->getDataValue();
		@@ -115,22 +115,22 @@ discard block
		block discarded – undo
115	115	* error handling:
116	116	* type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
117	117	*/
118		- if ( $dataValue->getType() !== 'wikibase-entityid' ) {
119		- $message = wfMessage( "wbqc-violation-message-value-needed-of-type" )
	118	+ if ($dataValue->getType() !== 'wikibase-entityid') {
	119	+ $message = wfMessage("wbqc-violation-message-value-needed-of-type")
120	120	->rawParams(
121		- $this->constraintParameterRenderer->formatItemId( $constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM ),
	121	+ $this->constraintParameterRenderer->formatItemId($constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM),
122	122	'wikibase-entityid' // TODO is there a message for this type so we can localize it?
123	123	)
124	124	->escaped();
125		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	125	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
126	126	}
127	127	/** @var EntityIdValue $dataValue */
128	128
129	129	$targetEntityId = $dataValue->getEntityId();
130		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
131		- if ( $targetEntity === null ) {
132		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
133		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	130	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	131	+ if ($targetEntity === null) {
	132	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	133	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
134	134	}
135	135
136	136	/*
		@@ -138,7 +138,7 @@ discard block
		block discarded – undo
138	138	* a) a property only
139	139	* b) a property and a number of items (each combination forming an individual claim)
140	140	*/
141		- if ( $items === [] ) {
	141	+ if ($items === []) {
142	142	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
143	143	$targetEntity->getStatements(),
144	144	$propertyId
		@@ -151,37 +151,37 @@ discard block
		block discarded – undo
151	151	);
152	152	}
153	153
154		- if ( $requiredStatement !== null ) {
	154	+ if ($requiredStatement !== null) {
155	155	$status = CheckResult::STATUS_COMPLIANCE;
156	156	$message = null;
157	157	} else {
158	158	$status = CheckResult::STATUS_VIOLATION;
159		- $message = wfMessage( 'wbqc-violation-message-target-required-claim' );
	159	+ $message = wfMessage('wbqc-violation-message-target-required-claim');
160	160	$message->rawParams(
161		- $this->constraintParameterRenderer->formatEntityId( $targetEntityId, Role::SUBJECT ),
162		- $this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE )
	161	+ $this->constraintParameterRenderer->formatEntityId($targetEntityId, Role::SUBJECT),
	162	+ $this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE)
163	163	);
164		- $message->numParams( count( $items ) );
165		- $message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
	164	+ $message->numParams(count($items));
	165	+ $message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
166	166	$message = $message->escaped();
167	167	}
168	168
169		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
170		- ->withMetadata( Metadata::ofDependencyMetadata(
171		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	169	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	170	+ ->withMetadata(Metadata::ofDependencyMetadata(
	171	+ DependencyMetadata::ofEntityId($targetEntityId) ));
172	172	}
173	173
174		- public function checkConstraintParameters( Constraint $constraint ) {
	174	+ public function checkConstraintParameters(Constraint $constraint) {
175	175	$constraintParameters = $constraint->getConstraintParameters();
176	176	$exceptions = [];
177	177	try {
178		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
179		- } catch ( ConstraintParameterException $e ) {
	178	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	179	+ } catch (ConstraintParameterException $e) {
180	180	$exceptions[] = $e;
181	181	}
182	182	try {
183		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
184		- } catch ( ConstraintParameterException $e ) {
	183	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
	184	+ } catch (ConstraintParameterException $e) {
185	185	$exceptions[] = $e;
186	186	}
187	187	return $exceptions;

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( bfeacc...2d81b2 )

Status

Category

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +30 added lines, -30 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch