wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/ApiV2Context.php

Spacing +12 added lines, -12 removed lines

@@ -36,29 +36,29 @@ 
 		$propertyId,
 		$statementGuid
 	) {
-		if ( !array_key_exists( $entityId, $container ) ) {
+		if (!array_key_exists($entityId, $container)) {
 			$container[$entityId] = [];
 		}
 		$entityContainer = &$container[$entityId];
 
-		if ( !array_key_exists( 'claims', $entityContainer ) ) {
+		if (!array_key_exists('claims', $entityContainer)) {
 			$entityContainer['claims'] = [];
 		}
 		$claimsContainer = &$entityContainer['claims'];
 
-		if ( !array_key_exists( $propertyId, $claimsContainer ) ) {
+		if (!array_key_exists($propertyId, $claimsContainer)) {
 			$claimsContainer[$propertyId] = [];
 		}
 		$propertyContainer = &$claimsContainer[$propertyId];
 
-		foreach ( $propertyContainer as &$statement ) {
-			if ( $statement['id'] === $statementGuid ) {
+		foreach ($propertyContainer as &$statement) {
+			if ($statement['id'] === $statementGuid) {
 				$statementArray = &$statement;
 				break;
 			}
 		}
-		if ( !isset( $statementArray ) ) {
-			$statementArray = [ 'id' => $statementGuid ];
+		if (!isset($statementArray)) {
+			$statementArray = ['id' => $statementGuid];
 			$propertyContainer[] = &$statementArray;
 		}
 
@@ -73,19 +73,19 @@ 
 	 * @param array[] &$container
 	 * @return array
 	 */
-	abstract protected function &getMainArray( array &$container );
+	abstract protected function &getMainArray(array &$container);
 
 	/**
 	 * @param array|null $result
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container ) {
-		$mainArray = &$this->getMainArray( $container );
-		if ( !array_key_exists( 'results', $mainArray ) ) {
+	public function storeCheckResultInArray(array $result = null, array &$container) {
+		$mainArray = &$this->getMainArray($container);
+		if (!array_key_exists('results', $mainArray)) {
 			$mainArray['results'] = [];
 		}
 
-		if ( $result !== null ) {
+		if ($result !== null) {
 			$mainArray['results'][] = $result;
 		}
 	}

src/ConstraintCheck/Cache/CachingMetadata.php

Spacing +11 added lines, -12 removed lines

@@ -29,9 +29,9 @@ 
 	 * @param int $maxAge The maximum age of the cached value (in seconds).
 	 * @return self Indication that a value is possibly outdated by up to this many seconds.
 	 */
-	public static function ofMaximumAgeInSeconds( $maxAge ) {
-		Assert::parameterType( 'integer', $maxAge, '$maxAge' );
-		Assert::parameter( $maxAge > 0, '$maxAge', '$maxage > 0' );
+	public static function ofMaximumAgeInSeconds($maxAge) {
+		Assert::parameterType('integer', $maxAge, '$maxAge');
+		Assert::parameter($maxAge > 0, '$maxAge', '$maxage > 0');
 		$ret = new self;
 		$ret->maxAge = $maxAge;
 		return $ret;
@@ -42,9 +42,9 @@ 
 	 * @param array|null $array As returned by toArray.
 	 * @return self
 	 */
-	public static function ofArray( array $array = null ) {
+	public static function ofArray(array $array = null) {
 		$ret = new self;
-		if ( $array !== null ) {
+		if ($array !== null) {
 			$ret->maxAge = $array['maximumAgeInSeconds'];
 		}
 		return $ret;
@@ -54,11 +54,11 @@ 
 	 * @param self[] $metadatas
 	 * @return self
 	 */
-	public static function merge( array $metadatas ) {
-		Assert::parameterElementType( self::class, $metadatas, '$metadatas' );
+	public static function merge(array $metadatas) {
+		Assert::parameterElementType(self::class, $metadatas, '$metadatas');
 		$ret = new self;
-		foreach ( $metadatas as $metadata ) {
-			$ret->maxAge = max( $ret->maxAge, $metadata->maxAge );
+		foreach ($metadatas as $metadata) {
+			$ret->maxAge = max($ret->maxAge, $metadata->maxAge);
 		}
 		return $ret;
 	}
@@ -76,7 +76,7 @@ 
 	 * For a fresh value, returns 0.
 	 */
 	public function getMaximumAgeInSeconds() {
-		if ( is_int( $this->maxAge ) ) {
+		if (is_int($this->maxAge)) {
 			return $this->maxAge;
 		} else {
 			return 0;
@@ -91,8 +91,7 @@ 
 		return $this->isCached() ?
 			[
 				'maximumAgeInSeconds' => $this->maxAge,
-			] :
-			null;
+			] : null;
 	}
 
 }

src/ConstraintParameterRenderer.php

Spacing +97 added lines, -97 removed lines

@@ -64,20 +64,20 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatValue( $value ) {
-		if ( is_string( $value ) ) {
+	public function formatValue($value) {
+		if (is_string($value)) {
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
 			// strings
-			return htmlspecialchars( $value );
-		} elseif ( $value instanceof EntityId ) {
+			return htmlspecialchars($value);
+		} elseif ($value instanceof EntityId) {
 			// Cases like 'Conflicts with' 'property', to which we can link
-			return $this->formatEntityId( $value );
-		} elseif ( $value instanceof ItemIdSnakValue ) {
+			return $this->formatEntityId($value);
+		} elseif ($value instanceof ItemIdSnakValue) {
 			// Cases like EntityId but can also be somevalue or novalue
-			return $this->formatItemIdSnakValue( $value );
+			return $this->formatItemIdSnakValue($value);
 		} else {
 			// Cases where we format a DataValue
-			return $this->formatDataValue( $value );
+			return $this->formatDataValue($value);
 		}
 	}
 
@@ -88,23 +88,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatParameters( $parameters ) {
-		if ( $parameters === null || count( $parameters ) == 0 ) {
+	public function formatParameters($parameters) {
+		if ($parameters === null || count($parameters) == 0) {
 			return null;
 		}
 
-		$valueFormatter = function ( $value ) {
-			return $this->formatValue( $value );
+		$valueFormatter = function($value) {
+			return $this->formatValue($value);
 		};
 
 		$formattedParameters = [];
-		foreach ( $parameters as $parameterName => $parameterValue ) {
-			$formattedParameterValues = implode( ', ',
-				$this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) );
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
+		foreach ($parameters as $parameterName => $parameterValue) {
+			$formattedParameterValues = implode(', ',
+				$this->limitArrayLength(array_map($valueFormatter, $parameterValue)));
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
 		}
 
-		return implode( '; ', $formattedParameters );
+		return implode('; ', $formattedParameters);
 	}
 
 	/**
@@ -114,10 +114,10 @@ 
 	 *
 	 * @return array
 	 */
-	private function limitArrayLength( array $array ) {
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
-			array_push( $array, '...' );
+	private function limitArrayLength(array $array) {
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
+			array_push($array, '...');
 		}
 
 		return $array;
@@ -130,12 +130,12 @@ 
 	 * @param string $value HTML
 	 * @return string HTML
 	 */
-	public static function formatByRole( $role, $value ) {
-		if ( $role === null ) {
+	public static function formatByRole($role, $value) {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">'
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'
 			. $value
 			. '</span>';
 	}
@@ -145,9 +145,9 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatDataValue( DataValue $value, $role = null ) {
-		return self::formatByRole( $role,
-			$this->dataValueFormatter->format( $value ) );
+	public function formatDataValue(DataValue $value, $role = null) {
+		return self::formatByRole($role,
+			$this->dataValueFormatter->format($value));
 	}
 
 	/**
@@ -155,9 +155,9 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatEntityId( EntityId $entityId, $role = null ) {
-		return self::formatByRole( $role,
-			$this->entityIdLabelFormatter->formatEntityId( $entityId ) );
+	public function formatEntityId(EntityId $entityId, $role = null) {
+		return self::formatByRole($role,
+			$this->entityIdLabelFormatter->formatEntityId($entityId));
 	}
 
 	/**
@@ -169,18 +169,18 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatPropertyId( $propertyId, $role = null ) {
-		if ( $propertyId instanceof PropertyId ) {
-			return $this->formatEntityId( $propertyId, $role );
-		} elseif ( is_string( $propertyId ) ) {
+	public function formatPropertyId($propertyId, $role = null) {
+		if ($propertyId instanceof PropertyId) {
+			return $this->formatEntityId($propertyId, $role);
+		} elseif (is_string($propertyId)) {
 			try {
-				return $this->formatEntityId( new PropertyId( $propertyId ), $role );
-			} catch ( InvalidArgumentException $e ) {
-				return self::formatByRole( $role,
-					htmlspecialchars( $propertyId ) );
+				return $this->formatEntityId(new PropertyId($propertyId), $role);
+			} catch (InvalidArgumentException $e) {
+				return self::formatByRole($role,
+					htmlspecialchars($propertyId));
 			}
 		} else {
-			throw new InvalidArgumentException( '$propertyId must be either PropertyId or string' );
+			throw new InvalidArgumentException('$propertyId must be either PropertyId or string');
 		}
 	}
 
@@ -193,18 +193,18 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatItemId( $itemId, $role = null ) {
-		if ( $itemId instanceof ItemId ) {
-			return $this->formatEntityId( $itemId, $role );
-		} elseif ( is_string( $itemId ) ) {
+	public function formatItemId($itemId, $role = null) {
+		if ($itemId instanceof ItemId) {
+			return $this->formatEntityId($itemId, $role);
+		} elseif (is_string($itemId)) {
 			try {
-				return $this->formatEntityId( new ItemId( $itemId ), $role );
-			} catch ( InvalidArgumentException $e ) {
-				return self::formatByRole( $role,
-					htmlspecialchars( $itemId ) );
+				return $this->formatEntityId(new ItemId($itemId), $role);
+			} catch (InvalidArgumentException $e) {
+				return self::formatByRole($role,
+					htmlspecialchars($itemId));
 			}
 		} else {
-			throw new InvalidArgumentException( '$itemId must be either ItemId or string' );
+			throw new InvalidArgumentException('$itemId must be either ItemId or string');
 		}
 	}
 
@@ -215,20 +215,20 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
-		switch ( true ) {
+	public function formatItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
+		switch (true) {
 			case $value->isValue():
-				return $this->formatEntityId( $value->getItemId(), $role );
+				return $this->formatEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return self::formatByRole( $role,
+				return self::formatByRole($role,
 					'<span class="wikibase-snakview-variation-somevaluesnak">'
-						. wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped()
-						. '</span>' );
+						. wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped()
+						. '</span>');
 			case $value->isNoValue():
-				return self::formatByRole( $role,
+				return self::formatByRole($role,
 					'<span class="wikibase-snakview-variation-novaluesnak">'
-						. wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped()
-						. '</span>' );
+						. wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped()
+						. '</span>');
 		}
 	}
 
@@ -239,8 +239,8 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatConstraintScope( $scope, $role = null ) {
-		switch ( $scope ) {
+	public function formatConstraintScope($scope, $role = null) {
+		switch ($scope) {
 			case Context::TYPE_STATEMENT:
 				$itemId = $this->config->get(
 					'WBQualityConstraintsConstraintCheckedOnMainValueId'
@@ -260,10 +260,10 @@ 
 				// callers should never let this happen, but if it does happen,
 				// showing “unknown value” seems reasonable
 				// @codeCoverageIgnoreStart
-				return $this->formatItemIdSnakValue( ItemIdSnakValue::someValue(), $role );
+				return $this->formatItemIdSnakValue(ItemIdSnakValue::someValue(), $role);
 				// @codeCoverageIgnoreEnd
 		}
-		return $this->formatItemId( $itemId, $role );
+		return $this->formatItemId($itemId, $role);
 	}
 
 	/**
@@ -276,15 +276,15 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatPropertyIdList( array $propertyIds, $role = null ) {
-		if ( empty( $propertyIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatPropertyIdList(array $propertyIds, $role = null) {
+		if (empty($propertyIds)) {
+			return ['<ul></ul>'];
 		}
-		$propertyIds = $this->limitArrayLength( $propertyIds );
-		$formattedPropertyIds = array_map( [ $this, "formatPropertyId" ], $propertyIds, array_fill( 0, count( $propertyIds ), $role ) );
+		$propertyIds = $this->limitArrayLength($propertyIds);
+		$formattedPropertyIds = array_map([$this, "formatPropertyId"], $propertyIds, array_fill(0, count($propertyIds), $role));
 		array_unshift(
 			$formattedPropertyIds,
-			'<ul><li>' . implode( '</li><li>', $formattedPropertyIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedPropertyIds).'</li></ul>'
 		);
 		return $formattedPropertyIds;
 	}
@@ -299,15 +299,15 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatItemIdList( array $itemIds, $role = null ) {
-		if ( empty( $itemIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatItemIdList(array $itemIds, $role = null) {
+		if (empty($itemIds)) {
+			return ['<ul></ul>'];
 		}
-		$itemIds = $this->limitArrayLength( $itemIds );
-		$formattedItemIds = array_map( [ $this, "formatItemId" ], $itemIds, array_fill( 0, count( $itemIds ), $role ) );
+		$itemIds = $this->limitArrayLength($itemIds);
+		$formattedItemIds = array_map([$this, "formatItemId"], $itemIds, array_fill(0, count($itemIds), $role));
 		array_unshift(
 			$formattedItemIds,
-			'<ul><li>' . implode( '</li><li>', $formattedItemIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedItemIds).'</li></ul>'
 		);
 		return $formattedItemIds;
 	}
@@ -322,23 +322,23 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatEntityIdList( array $entityIds, $role = null ) {
-		if ( empty( $entityIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatEntityIdList(array $entityIds, $role = null) {
+		if (empty($entityIds)) {
+			return ['<ul></ul>'];
 		}
 		$formattedEntityIds = [];
-		foreach ( $entityIds as $entityId ) {
-			if ( count( $formattedEntityIds ) >= self::MAX_PARAMETER_ARRAY_LENGTH ) {
+		foreach ($entityIds as $entityId) {
+			if (count($formattedEntityIds) >= self::MAX_PARAMETER_ARRAY_LENGTH) {
 				$formattedEntityIds[] = '...';
 				break;
 			}
-			if ( $entityId !== null ) {
-				$formattedEntityIds[] = $this->formatEntityId( $entityId, $role );
+			if ($entityId !== null) {
+				$formattedEntityIds[] = $this->formatEntityId($entityId, $role);
 			}
 		}
 		array_unshift(
 			$formattedEntityIds,
-			'<ul><li>' . implode( '</li><li>', $formattedEntityIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedEntityIds).'</li></ul>'
 		);
 		return $formattedEntityIds;
 	}
@@ -353,24 +353,24 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatItemIdSnakValueList( array $values, $role = null ) {
-		if ( empty( $values ) ) {
-			return [ '<ul></ul>' ];
+	public function formatItemIdSnakValueList(array $values, $role = null) {
+		if (empty($values)) {
+			return ['<ul></ul>'];
 		}
-		$values = $this->limitArrayLength( $values );
+		$values = $this->limitArrayLength($values);
 		$formattedValues = array_map(
-			function( $value ) use ( $role ) {
-				if ( $value === '...' ) {
+			function($value) use ($role) {
+				if ($value === '...') {
 					return '...';
 				} else {
-					return $this->formatItemIdSnakValue( $value, $role );
+					return $this->formatItemIdSnakValue($value, $role);
 				}
 			},
 			$values
 		);
 		array_unshift(
 			$formattedValues,
-			'<ul><li>' . implode( '</li><li>', $formattedValues ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedValues).'</li></ul>'
 		);
 		return $formattedValues;
 	}
@@ -385,24 +385,24 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatConstraintScopeList( array $scopes, $role = null ) {
-		if ( empty( $scopes ) ) {
-			return [ '<ul></ul>' ];
+	public function formatConstraintScopeList(array $scopes, $role = null) {
+		if (empty($scopes)) {
+			return ['<ul></ul>'];
 		}
-		$scopes = $this->limitArrayLength( $scopes );
+		$scopes = $this->limitArrayLength($scopes);
 		$formattedScopes = array_map(
-			function( $scope ) use ( $role ) {
-				if ( $scope === '...' ) {
+			function($scope) use ($role) {
+				if ($scope === '...') {
 					return '...';
 				} else {
-					return $this->formatConstraintScope( $scope, $role );
+					return $this->formatConstraintScope($scope, $role);
 				}
 			},
 			$scopes
 		);
 		array_unshift(
 			$formattedScopes,
-			'<ul><li>' . implode( '</li><li>', $formattedScopes ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedScopes).'</li></ul>'
 		);
 		return $formattedScopes;
 	}

src/ConstraintCheck/ItemIdSnakValue.php

Spacing +11 added lines, -11 removed lines

@@ -44,7 +44,7 @@ 
 	 * @param ItemId $itemId
 	 * @return self
 	 */
-	public static function fromItemId( ItemId $itemId ) {
+	public static function fromItemId(ItemId $itemId) {
 		$ret = new self;
 		$ret->itemId = $itemId;
 		return $ret;
@@ -80,14 +80,14 @@ 
 	 * @throws InvalidArgumentException
 	 * @return self
 	 */
-	public static function fromSnak( Snak $snak ) {
-		switch ( true ) {
+	public static function fromSnak(Snak $snak) {
+		switch (true) {
 			case $snak instanceof PropertyValueSnak:
 				$dataValue = $snak->getDataValue();
-				if ( $dataValue instanceof EntityIdValue
+				if ($dataValue instanceof EntityIdValue
 					&& $dataValue->getEntityId() instanceof ItemId
 				) {
-					return self::fromItemId( $dataValue->getEntityId() );
+					return self::fromItemId($dataValue->getEntityId());
 				}
 				break;
 			case $snak instanceof PropertySomeValueSnak:
@@ -96,7 +96,7 @@ 
 				return self::noValue();
 		}
 
-		throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' );
+		throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak');
 	}
 
 	/**
@@ -133,8 +133,8 @@ 
 	 * @return ItemId
 	 */
 	public function getItemId() {
-		if ( ! $this->isValue() ) {
-			throw new DomainException( 'This value does not contain an item ID.' );
+		if (!$this->isValue()) {
+			throw new DomainException('This value does not contain an item ID.');
 		}
 		return $this->itemId;
 	}
@@ -146,13 +146,13 @@ 
 	 * @param Snak $snak
 	 * @return bool
 	 */
-	public function matchesSnak( Snak $snak ) {
-		switch ( true ) {
+	public function matchesSnak(Snak $snak) {
+		switch (true) {
 			case $snak instanceof PropertyValueSnak:
 				return $this->isValue() &&
 					$snak->getDataValue() instanceof EntityIdValue &&
 					$snak->getDataValue()->getEntityId() instanceof ItemId &&
-					$snak->getDataValue()->getEntityId()->equals( $this->getItemId() );
+					$snak->getDataValue()->getEntityId()->equals($this->getItemId());
 			case $snak instanceof PropertySomeValueSnak:
 				return $this->isSomeValue();
 			case $snak instanceof PropertyNoValueSnak:

src/ConstraintCheck/Helper/ConnectionCheckerHelper.php

Spacing +11 added lines, -11 removed lines

@@ -30,8 +30,8 @@ 
 		StatementList $statementList,
 		PropertyId $propertyId
 	) {
-		$statementListByPropertyId = $statementList->getByPropertyId( $propertyId );
-		if ( $statementListByPropertyId->isEmpty() ) {
+		$statementListByPropertyId = $statementList->getByPropertyId($propertyId);
+		if ($statementListByPropertyId->isEmpty()) {
 			return null;
 		} else {
 			return $statementListByPropertyId->toArray()[0];
@@ -52,14 +52,14 @@ 
 		PropertyId $propertyId,
 		EntityId $value
 	) {
-		$statementListByPropertyId = $statementList->getByPropertyId( $propertyId );
+		$statementListByPropertyId = $statementList->getByPropertyId($propertyId);
 		/** @var Statement $statement */
-		foreach ( $statementListByPropertyId as $statement ) {
+		foreach ($statementListByPropertyId as $statement) {
 			$snak = $statement->getMainSnak();
-			if ( $snak instanceof PropertyValueSnak ) {
+			if ($snak instanceof PropertyValueSnak) {
 				$dataValue = $snak->getDataValue();
-				if ( $dataValue instanceof EntityIdValue &&
-					$dataValue->getEntityId()->equals( $value )
+				if ($dataValue instanceof EntityIdValue &&
+					$dataValue->getEntityId()->equals($value)
 				) {
 					return $statement;
 				}
@@ -82,12 +82,12 @@ 
 		PropertyId $propertyId,
 		array $values
 	) {
-		$statementListByPropertyId = $statementList->getByPropertyId( $propertyId );
+		$statementListByPropertyId = $statementList->getByPropertyId($propertyId);
 		/** @var Statement $statement */
-		foreach ( $statementListByPropertyId as $statement ) {
+		foreach ($statementListByPropertyId as $statement) {
 			$snak = $statement->getMainSnak();
-			foreach ( $values as $value ) {
-				if ( $value->matchesSnak( $snak ) ) {
+			foreach ($values as $value) {
+				if ($value->matchesSnak($snak)) {
 					return $statement;
 				}
 			}

src/UpdateConstraintsTableJob.php

Spacing +18 added lines, -18 removed lines

@@ -26,8 +26,8 @@ 
 
 	const BATCH_SIZE = 10;
 
-	public static function newFromGlobalState( Title $title, array $params ) {
-		Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' );
+	public static function newFromGlobalState(Title $title, array $params) {
+		Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]');
 		$repo = WikibaseRepo::getDefaultInstance();
 		return new UpdateConstraintsTableJob(
 			$title,
@@ -83,7 +83,7 @@ 
 		EntityLookup $entityLookup,
 		Serializer $snakSerializer
 	) {
-		parent::__construct( 'constraintsTableUpdate', $title, $params );
+		parent::__construct('constraintsTableUpdate', $title, $params);
 
 		$this->propertyId = $propertyId;
 		$this->config = $config;
@@ -92,11 +92,11 @@ 
 		$this->snakSerializer = $snakSerializer;
 	}
 
-	public function extractParametersFromQualifiers( SnakList $qualifiers ) {
+	public function extractParametersFromQualifiers(SnakList $qualifiers) {
 		$parameters = [];
-		foreach ( $qualifiers as $qualifier ) {
+		foreach ($qualifiers as $qualifier) {
 			$qualifierId = $qualifier->getPropertyId()->getSerialization();
-			$paramSerialization = $this->snakSerializer->serialize( $qualifier );
+			$paramSerialization = $this->snakSerializer->serialize($qualifier);
 			$parameters[$qualifierId][] = $paramSerialization;
 		}
 		return $parameters;
@@ -108,7 +108,7 @@ 
 	) {
 		$constraintId = $constraintStatement->getGuid();
 		$constraintTypeQid = $constraintStatement->getMainSnak()->getDataValue()->getEntityId()->getSerialization();
-		$parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() );
+		$parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers());
 		return new Constraint(
 			$constraintId,
 			$propertyId,
@@ -123,17 +123,17 @@ 
 		PropertyId $propertyConstraintPropertyId
 	) {
 		$constraintsStatements = $property->getStatements()
-			->getByPropertyId( $propertyConstraintPropertyId )
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByPropertyId($propertyConstraintPropertyId)
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 		$constraints = [];
-		foreach ( $constraintsStatements->getIterator() as $constraintStatement ) {
-			$constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement );
-			if ( count( $constraints ) >= self::BATCH_SIZE ) {
-				$constraintRepo->insertBatch( $constraints );
+		foreach ($constraintsStatements->getIterator() as $constraintStatement) {
+			$constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement);
+			if (count($constraints) >= self::BATCH_SIZE) {
+				$constraintRepo->insertBatch($constraints);
 				$constraints = [];
 			}
 		}
-		$constraintRepo->insertBatch( $constraints );
+		$constraintRepo->insertBatch($constraints);
 	}
 
 	/**
@@ -144,15 +144,15 @@ 
 	public function run() {
 		// TODO in the future: only touch constraints affected by the edit (requires T163465)
 
-		$propertyId = new PropertyId( $this->propertyId );
-		$this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId( $propertyId );
+		$propertyId = new PropertyId($this->propertyId);
+		$this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId($propertyId);
 
 		/** @var Property $property */
-		$property = $this->entityLookup->getEntity( $propertyId );
+		$property = $this->entityLookup->getEntity($propertyId);
 		$this->importConstraintsForProperty(
 			$property,
 			$this->constraintRepo,
-			new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) )
+			new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId'))
 		);
 
 		return true;

src/Api/CachingResultsBuilder.php

Spacing +50 added lines, -51 removed lines

@@ -134,11 +134,11 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
 					$this->dataFactory->increment(
 						'wikibase.quality.constraints.cache.entity.hit'
 					);
@@ -147,20 +147,20 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
+		if ($entityIds !== [] || $claimIds !== []) {
 			$this->dataFactory->updateCount(
 				'wikibase.quality.constraints.cache.entity.miss',
-				count( $entityIds )
+				count($entityIds)
 			);
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses);
 			$results += $response->getArray();
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckConstraintsResponse(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -189,13 +189,13 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		if ( $claimIds !== [] ) {
+		if ($claimIds !== []) {
 			return false;
 		}
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( $statuses != $this->cachedStatuses ) {
+		if ($statuses != $this->cachedStatuses) {
 			return false;
 		}
 		return true;
@@ -214,17 +214,17 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		$results = $this->resultsBuilder->getResults( $entityIds, $claimIds, $constraintIds, $statuses );
+		$results = $this->resultsBuilder->getResults($entityIds, $claimIds, $constraintIds, $statuses);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
-			foreach ( $entityIds as $entityId ) {
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) {
+			foreach ($entityIds as $entityId) {
 				$value = [
 					'results' => $results->getArray()[$entityId->getSerialization()],
 					'latestRevisionIds' => $this->getLatestRevisionIds(
 						$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 					),
 				];
-				$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+				$this->cache->set($entityId, $value, $this->ttlInSeconds);
 			}
 		}
 
@@ -256,10 +256,10 @@ 
 		array $constraintIds = null,
 		array $statuses
 	) {
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( $statuses != $this->cachedStatuses ) {
+		if ($statuses != $this->cachedStatuses) {
 			return false;
 		}
 		return true;
@@ -272,45 +272,44 @@ 
 	public function getStoredResults(
 		EntityId $entityId
 	) {
-		$value = $this->cache->get( $entityId, $curTTL, [], $asOf );
-		$now = call_user_func( $this->microtime, true );
+		$value = $this->cache->get($entityId, $curTTL, [], $asOf);
+		$now = call_user_func($this->microtime, true);
 
-		if ( $value === false ) {
+		if ($value === false) {
 			return null;
 		}
 
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
-		if ( is_array( $value['results'] ) ) {
-			array_walk( $value['results'], [ $this, 'updateCachingMetadata' ], $cachingMetadata );
+		if (is_array($value['results'])) {
+			array_walk($value['results'], [$this, 'updateCachingMetadata'], $cachingMetadata);
 		}
 
 		return new CachedCheckConstraintsResponse(
-			[ $entityId->getSerialization() => $value['results'] ],
+			[$entityId->getSerialization() => $value['results']],
 			array_reduce(
 				$dependedEntityIds,
-				function( Metadata $metadata, EntityId $entityId ) {
-					return Metadata::merge( [
+				function(Metadata $metadata, EntityId $entityId) {
+					return Metadata::merge([
 						$metadata,
 						Metadata::ofDependencyMetadata(
-							DependencyMetadata::ofEntityId( $entityId )
+							DependencyMetadata::ofEntityId($entityId)
 						)
-					] );
+					]);
 				},
-				Metadata::ofCachingMetadata( $cachingMetadata )
+				Metadata::ofCachingMetadata($cachingMetadata)
 			)
 		);
 	}
@@ -319,39 +318,39 @@ 
 	 * @param EntityId[] $entityIds
 	 * @return int[]
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
+	private function getLatestRevisionIds(array $entityIds) {
 		$revisionInformations = $this->wikiPageEntityMetaDataAccessor->loadRevisionInformation(
 			$entityIds,
 			EntityRevisionLookup::LATEST_FROM_REPLICA
 		);
 		$latestRevisionIds = [];
-		foreach ( $revisionInformations as $serialization => $revisionInformation ) {
+		foreach ($revisionInformations as $serialization => $revisionInformation) {
 			$latestRevisionIds[$serialization] = $revisionInformation->page_latest;
 		}
 		return $latestRevisionIds;
 	}
 
-	public function updateCachingMetadata( &$element, $key, CachingMetadata $cachingMetadata ) {
-		if ( $key === 'cached' ) {
-			$element = CachingMetadata::merge( [
+	public function updateCachingMetadata(&$element, $key, CachingMetadata $cachingMetadata) {
+		if ($key === 'cached') {
+			$element = CachingMetadata::merge([
 				$cachingMetadata,
-				CachingMetadata::ofArray( $element ),
-			] )->toArray();
+				CachingMetadata::ofArray($element),
+			])->toArray();
 		}
 		if (
-			is_array( $element ) &&
-			array_key_exists( 'constraint', $element ) &&
-			in_array( $element['constraint']['type'], $this->possiblyStaleConstraintTypes, true )
+			is_array($element) &&
+			array_key_exists('constraint', $element) &&
+			in_array($element['constraint']['type'], $this->possiblyStaleConstraintTypes, true)
 		) {
-			$element['cached'] = CachingMetadata::merge( [
+			$element['cached'] = CachingMetadata::merge([
 				$cachingMetadata,
 				CachingMetadata::ofArray(
-					array_key_exists( 'cached', $element ) ? $element['cached'] : null
+					array_key_exists('cached', $element) ? $element['cached'] : null
 				),
-			] )->toArray();
+			])->toArray();
 		}
-		if ( is_array( $element ) ) {
-			array_walk( $element, [ $this, __FUNCTION__ ], $cachingMetadata );
+		if (is_array($element)) {
+			array_walk($element, [$this, __FUNCTION__], $cachingMetadata);
 		}
 	}
 
@@ -360,7 +359,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/ConstraintCheck/Helper/SparqlHelper.php

Spacing +130 added lines, -132 removed lines

@@ -91,18 +91,18 @@ 
 		$this->cache = $cache;
 		$this->dataFactory = $dataFactory;
 
-		$this->entityPrefix = $rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ENTITY );
+		$this->entityPrefix = $rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ENTITY);
 		$this->prefixes = <<<EOT
-PREFIX wd: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ENTITY )}>
-PREFIX wds: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_STATEMENT )}>
-PREFIX wdt: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_DIRECT_CLAIM )}>
-PREFIX wdv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_VALUE )}>
-PREFIX p: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_CLAIM )}>
-PREFIX ps: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_CLAIM_STATEMENT )}>
-PREFIX pq: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_QUALIFIER )}>
-PREFIX pqv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_QUALIFIER_VALUE )}>
-PREFIX pr: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_REFERENCE )}>
-PREFIX prv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NSP_REFERENCE_VALUE )}>
+PREFIX wd: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ENTITY)}>
+PREFIX wds: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_STATEMENT)}>
+PREFIX wdt: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_DIRECT_CLAIM)}>
+PREFIX wdv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_VALUE)}>
+PREFIX p: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_CLAIM)}>
+PREFIX ps: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_CLAIM_STATEMENT)}>
+PREFIX pq: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_QUALIFIER)}>
+PREFIX pqv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_QUALIFIER_VALUE)}>
+PREFIX pr: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_REFERENCE)}>
+PREFIX prv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NSP_REFERENCE_VALUE)}>
 PREFIX wikibase: <http://wikiba.se/ontology#>
 PREFIX wikibase-beta: <http://wikiba.se/ontology-beta#>
 EOT;
@@ -117,21 +117,21 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function hasType( $id, array $classes, $withInstance ) {
-		$instanceOfId = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
-		$subclassOfId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+	public function hasType($id, array $classes, $withInstance) {
+		$instanceOfId = $this->config->get('WBQualityConstraintsInstanceOfId');
+		$subclassOfId = $this->config->get('WBQualityConstraintsSubclassOfId');
 
-		$path = ( $withInstance ? "wdt:$instanceOfId/" : "" ) . "wdt:$subclassOfId*";
+		$path = ($withInstance ? "wdt:$instanceOfId/" : "")."wdt:$subclassOfId*";
 
 		$metadatas = [];
 
-		foreach ( array_chunk( $classes, 20 ) as $classesChunk ) {
-			$classesValues = implode( ' ', array_map(
-				function( $class ) {
-					return 'wd:' . $class;
+		foreach (array_chunk($classes, 20) as $classesChunk) {
+			$classesValues = implode(' ', array_map(
+				function($class) {
+					return 'wd:'.$class;
 				},
 				$classesChunk
-			) );
+			));
 
 			$query = <<<EOF
 ASK {
@@ -142,19 +142,19 @@ 
 EOF;
 			// TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually
 
-			$result = $this->runQuery( $query );
+			$result = $this->runQuery($query);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getArray()['boolean'] ) {
+			if ($result->getArray()['boolean']) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -170,10 +170,10 @@ 
 		$ignoreDeprecatedStatements
 	) {
 		$pid = $statement->getPropertyId()->serialize();
-		$guid = str_replace( '$', '-', $statement->getGuid() );
+		$guid = str_replace('$', '-', $statement->getGuid());
 
 		$deprecatedFilter = '';
-		if ( $ignoreDeprecatedStatements ) {
+		if ($ignoreDeprecatedStatements) {
 			$deprecatedFilter .= 'MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. }';
 			$deprecatedFilter .= 'MINUS { ?otherStatement wikibase-beta:rank wikibase-beta:DeprecatedRank. }';
 		}
@@ -193,9 +193,9 @@ 
 LIMIT 10
 EOF;
 
-		$result = $this->runQuery( $query );
+		$result = $this->runQuery($query);
 
-		return $this->getOtherEntities( $result );
+		return $this->getOtherEntities($result);
 	}
 
 	/**
@@ -220,16 +220,15 @@ 
 		$dataType = $this->propertyDataTypeLookup->getDataTypeIdForProperty(
 			$snak->getPropertyId()
 		);
-		list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType, $dataValue );
-		if ( $isFullValue ) {
+		list($value, $isFullValue) = $this->getRdfLiteral($dataType, $dataValue);
+		if ($isFullValue) {
 			$prefix .= 'v';
 		}
 		$path = $type === Context::TYPE_QUALIFIER ?
-			"$prefix:$pid" :
-			"prov:wasDerivedFrom/$prefix:$pid";
+			"$prefix:$pid" : "prov:wasDerivedFrom/$prefix:$pid";
 
 		$deprecatedFilter = '';
-		if ( $ignoreDeprecatedStatements ) {
+		if ($ignoreDeprecatedStatements) {
 			$deprecatedFilter = <<< EOF
   MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. }
   MINUS { ?otherStatement wikibase-beta:rank wikibase-beta:DeprecatedRank. }
@@ -250,9 +249,9 @@ 
 LIMIT 10
 EOF;
 
-		$result = $this->runQuery( $query );
+		$result = $this->runQuery($query);
 
-		return $this->getOtherEntities( $result );
+		return $this->getOtherEntities($result);
 	}
 
 	/**
@@ -262,8 +261,8 @@ 
 	 *
 	 * @return string
 	 */
-	private function stringLiteral( $text ) {
-		return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"';
+	private function stringLiteral($text) {
+		return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"';
 	}
 
 	/**
@@ -273,17 +272,17 @@ 
 	 *
 	 * @return CachedEntityIds
 	 */
-	private function getOtherEntities( CachedQueryResults $results ) {
-		return new CachedEntityIds( array_map(
-			function ( $resultBindings ) {
+	private function getOtherEntities(CachedQueryResults $results) {
+		return new CachedEntityIds(array_map(
+			function($resultBindings) {
 				$entityIRI = $resultBindings['otherEntity']['value'];
-				$entityPrefixLength = strlen( $this->entityPrefix );
-				if ( substr( $entityIRI, 0, $entityPrefixLength ) === $this->entityPrefix ) {
+				$entityPrefixLength = strlen($this->entityPrefix);
+				if (substr($entityIRI, 0, $entityPrefixLength) === $this->entityPrefix) {
 					try {
 						return $this->entityIdParser->parse(
-							substr( $entityIRI, $entityPrefixLength )
+							substr($entityIRI, $entityPrefixLength)
 						);
-					} catch ( EntityIdParsingException $e ) {
+					} catch (EntityIdParsingException $e) {
 						// fall through
 					}
 				}
@@ -291,7 +290,7 @@ 
 				return null;
 			},
 			$results->getArray()['results']['bindings']
-		), $results->getMetadata() );
+		), $results->getMetadata());
 	}
 
 	// @codingStandardsIgnoreStart cyclomatic complexity of this function is too high
@@ -304,47 +303,47 @@ 
 	 * @return array the literal or IRI as a string in SPARQL syntax,
 	 * and a boolean indicating whether it refers to a full value node or not
 	 */
-	private function getRdfLiteral( $dataType, DataValue $dataValue ) {
-		switch ( $dataType ) {
+	private function getRdfLiteral($dataType, DataValue $dataValue) {
+		switch ($dataType) {
 			case 'string':
 			case 'external-id':
-				return [ $this->stringLiteral( $dataValue->getValue() ), false ];
+				return [$this->stringLiteral($dataValue->getValue()), false];
 			case 'commonsMedia':
-				$url = $this->rdfVocabulary->getMediaFileURI( $dataValue->getValue() );
-				return [ '<' . $url . '>', false ];
+				$url = $this->rdfVocabulary->getMediaFileURI($dataValue->getValue());
+				return ['<'.$url.'>', false];
 			case 'geo-shape':
-				$url = $this->rdfVocabulary->getGeoShapeURI( $dataValue->getValue() );
-				return [ '<' . $url . '>', false ];
+				$url = $this->rdfVocabulary->getGeoShapeURI($dataValue->getValue());
+				return ['<'.$url.'>', false];
 			case 'tabular-data':
-				$url = $this->rdfVocabulary->getTabularDataURI( $dataValue->getValue() );
-				return [ '<' . $url . '>', false ];
+				$url = $this->rdfVocabulary->getTabularDataURI($dataValue->getValue());
+				return ['<'.$url.'>', false];
 			case 'url':
 				$url = $dataValue->getValue();
-				if ( !preg_match( '/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url ) ) {
+				if (!preg_match('/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url)) {
 					// not a valid URL for SPARQL (see SPARQL spec, production 139 IRIREF)
 					// such an URL should never reach us, so just throw
-					throw new InvalidArgumentException( 'invalid URL: ' . $url );
+					throw new InvalidArgumentException('invalid URL: '.$url);
 				}
-				return [ '<' . $url . '>', false ];
+				return ['<'.$url.'>', false];
 			case 'wikibase-item':
 			case 'wikibase-property':
 				/** @var EntityIdValue $dataValue */
-				return [ 'wd:' . $dataValue->getEntityId()->getSerialization(), false ];
+				return ['wd:'.$dataValue->getEntityId()->getSerialization(), false];
 			case 'monolingualtext':
 				/** @var MonolingualTextValue $dataValue */
 				$lang = $dataValue->getLanguageCode();
-				if ( !preg_match( '/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang ) ) {
+				if (!preg_match('/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang)) {
 					// not a valid language tag for SPARQL (see SPARQL spec, production 145 LANGTAG)
 					// such a language tag should never reach us, so just throw
-					throw new InvalidArgumentException( 'invalid language tag: ' . $lang );
+					throw new InvalidArgumentException('invalid language tag: '.$lang);
 				}
-				return [ $this->stringLiteral( $dataValue->getText() ) . '@' . $lang, false ];
+				return [$this->stringLiteral($dataValue->getText()).'@'.$lang, false];
 			case 'globe-coordinate':
 			case 'quantity':
 			case 'time':
-				return [ 'wdv:' . $dataValue->getHash(), true ];
+				return ['wdv:'.$dataValue->getHash(), true];
 			default:
-				throw new InvalidArgumentException( 'unknown data type: ' . $dataType );
+				throw new InvalidArgumentException('unknown data type: '.$dataType);
 		}
 	}
 	// @codingStandardsIgnoreEnd
@@ -357,47 +356,47 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpression( $text, $regex ) {
+	public function matchesRegularExpression($text, $regex) {
 		// caching wrapper around matchesRegularExpressionWithSparql
 
-		$textHash = hash( 'sha256', $text );
+		$textHash = hash('sha256', $text);
 		$cacheKey = $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'regex', // action
 			'WDQS-Java', // regex flavor
-			hash( 'sha256', $regex )
+			hash('sha256', $regex)
 		);
-		$cacheMapSize = $this->config->get( 'WBQualityConstraintsFormatCacheMapSize' );
+		$cacheMapSize = $this->config->get('WBQualityConstraintsFormatCacheMapSize');
 
 		$cacheMapArray = $this->cache->getWithSetCallback(
 			$cacheKey,
 			WANObjectCache::TTL_DAY,
-			function( $cacheMapArray ) use ( $text, $regex, $textHash, $cacheMapSize ) {
+			function($cacheMapArray) use ($text, $regex, $textHash, $cacheMapSize) {
 				// Initialize the cache map if not set
-				if ( $cacheMapArray === false ) {
+				if ($cacheMapArray === false) {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.init';
-					$this->dataFactory->increment( $key );
+					$this->dataFactory->increment($key);
 					return [];
 				}
 
 				$key = 'wikibase.quality.constraints.regex.cache.refresh';
-				$this->dataFactory->increment( $key );
-				$cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $cacheMapSize );
-				if ( $cacheMap->has( $textHash ) ) {
+				$this->dataFactory->increment($key);
+				$cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $cacheMapSize);
+				if ($cacheMap->has($textHash)) {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.hit';
-					$this->dataFactory->increment( $key );
-					$cacheMap->get( $textHash ); // ping cache
+					$this->dataFactory->increment($key);
+					$cacheMap->get($textHash); // ping cache
 				} else {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.miss';
-					$this->dataFactory->increment( $key );
+					$this->dataFactory->increment($key);
 					try {
-						$matches = $this->matchesRegularExpressionWithSparql( $text, $regex );
-					} catch ( ConstraintParameterException $e ) {
+						$matches = $this->matchesRegularExpressionWithSparql($text, $regex);
+					} catch (ConstraintParameterException $e) {
 						$matches = [
 							'type' => ConstraintParameterException::class,
 							'message' => $e->getMessage(),
 						];
-					} catch ( SparqlHelperException $e ) {
+					} catch (SparqlHelperException $e) {
 						// don’t cache this
 						return $cacheMap->toArray();
 					}
@@ -421,27 +420,27 @@ 
 			]
 		);
 
-		if ( isset( $cacheMapArray[$textHash] ) ) {
+		if (isset($cacheMapArray[$textHash])) {
 			$key = 'wikibase.quality.constraints.regex.cache.hit';
-			$this->dataFactory->increment( $key );
+			$this->dataFactory->increment($key);
 			$matches = $cacheMapArray[$textHash];
-			if ( is_bool( $matches ) ) {
+			if (is_bool($matches)) {
 				return $matches;
-			} elseif ( is_array( $matches ) &&
-				$matches['type'] == ConstraintParameterException::class ) {
-				throw new ConstraintParameterException( $matches['message'] );
+			} elseif (is_array($matches) &&
+				$matches['type'] == ConstraintParameterException::class) {
+				throw new ConstraintParameterException($matches['message']);
 			} else {
 				throw new MWException(
-					'Value of unknown type in object cache (' .
-					'cache key: ' . $cacheKey . ', ' .
-					'cache map key: ' . $textHash . ', ' .
-					'value type: ' . gettype( $matches ) . ')'
+					'Value of unknown type in object cache ('.
+					'cache key: '.$cacheKey.', '.
+					'cache map key: '.$textHash.', '.
+					'value type: '.gettype($matches).')'
 				);
 			}
 		} else {
 			$key = 'wikibase.quality.constraints.regex.cache.miss';
-			$this->dataFactory->increment( $key );
-			return $this->matchesRegularExpressionWithSparql( $text, $regex );
+			$this->dataFactory->increment($key);
+			return $this->matchesRegularExpressionWithSparql($text, $regex);
 		}
 	}
 
@@ -456,26 +455,26 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpressionWithSparql( $text, $regex ) {
-		$textStringLiteral = $this->stringLiteral( $text );
-		$regexStringLiteral = $this->stringLiteral( '^' . $regex . '$' );
+	public function matchesRegularExpressionWithSparql($text, $regex) {
+		$textStringLiteral = $this->stringLiteral($text);
+		$regexStringLiteral = $this->stringLiteral('^'.$regex.'$');
 
 		$query = <<<EOF
 SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {}
 EOF;
 
-		$result = $this->runQuery( $query );
+		$result = $this->runQuery($query);
 
 		$vars = $result->getArray()['results']['bindings'][0];
-		if ( array_key_exists( 'matches', $vars ) ) {
+		if (array_key_exists('matches', $vars)) {
 			// true or false ⇒ regex okay, text matches or not
 			return $vars['matches']['value'] === 'true';
 		} else {
 			// empty result: regex broken
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-regex' )
-					->rawParams( ConstraintParameterRenderer::formatByRole( Role::CONSTRAINT_PARAMETER_VALUE,
-						'<code><nowiki>' . htmlspecialchars( $regex ) . '</nowiki></code>' ) )
+				wfMessage('wbqc-violation-message-parameter-regex')
+					->rawParams(ConstraintParameterRenderer::formatByRole(Role::CONSTRAINT_PARAMETER_VALUE,
+						'<code><nowiki>'.htmlspecialchars($regex).'</nowiki></code>'))
 					->escaped()
 			);
 		}
@@ -488,14 +487,14 @@ 
 	 *
 	 * @return boolean
 	 */
-	public function isTimeout( $responseContent ) {
-		$timeoutRegex = implode( '|', array_map(
-			function ( $fqn ) {
-				return preg_quote( $fqn, '/' );
+	public function isTimeout($responseContent) {
+		$timeoutRegex = implode('|', array_map(
+			function($fqn) {
+				return preg_quote($fqn, '/');
 			},
-			$this->config->get( 'WBQualityConstraintsSparqlTimeoutExceptionClasses' )
-		) );
-		return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent );
+			$this->config->get('WBQualityConstraintsSparqlTimeoutExceptionClasses')
+		));
+		return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent);
 	}
 
 	/**
@@ -507,17 +506,17 @@ 
 	 * @return integer|boolean the max-age (in seconds)
 	 * or a plain boolean if no max-age can be determined
 	 */
-	public function getCacheMaxAge( $responseHeaders ) {
+	public function getCacheMaxAge($responseHeaders) {
 		if (
-			array_key_exists( 'x-cache-status', $responseHeaders ) &&
-			preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] )
+			array_key_exists('x-cache-status', $responseHeaders) &&
+			preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0])
 		) {
 			$maxage = [];
 			if (
-				array_key_exists( 'cache-control', $responseHeaders ) &&
-				preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage )
+				array_key_exists('cache-control', $responseHeaders) &&
+				preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage)
 			) {
-				return intval( $maxage[1] );
+				return intval($maxage[1]);
 			} else {
 				return true;
 			}
@@ -535,59 +534,58 @@ 
 	 *
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function runQuery( $query ) {
+	public function runQuery($query) {
 
-		$endpoint = $this->config->get( 'WBQualityConstraintsSparqlEndpoint' );
-		$maxQueryTimeMillis = $this->config->get( 'WBQualityConstraintsSparqlMaxMillis' );
-		$url = $endpoint . '?' . http_build_query(
+		$endpoint = $this->config->get('WBQualityConstraintsSparqlEndpoint');
+		$maxQueryTimeMillis = $this->config->get('WBQualityConstraintsSparqlMaxMillis');
+		$url = $endpoint.'?'.http_build_query(
 			[
-				'query' => "#wbqc\n" . $this->prefixes . $query,
+				'query' => "#wbqc\n".$this->prefixes.$query,
 				'format' => 'json',
 				'maxQueryTimeMillis' => $maxQueryTimeMillis,
 			],
-			null, ini_get( 'arg_separator.output' ),
+			null, ini_get('arg_separator.output'),
 			// encode spaces with %20, not +
 			PHP_QUERY_RFC3986
 		);
 
 		$options = [
 			'method' => 'GET',
-			'timeout' => (int)round( ( $maxQueryTimeMillis + 1000 ) / 1000 ),
+			'timeout' => (int) round(($maxQueryTimeMillis + 1000) / 1000),
 			'connectTimeout' => 'default',
 		];
-		$request = MWHttpRequest::factory( $url, $options );
-		$startTime = microtime( true );
+		$request = MWHttpRequest::factory($url, $options);
+		$startTime = microtime(true);
 		$status = $request->execute();
-		$endTime = microtime( true );
+		$endTime = microtime(true);
 		$this->dataFactory->timing(
 			'wikibase.quality.constraints.sparql.timing',
-			( $endTime - $startTime ) * 1000
+			($endTime - $startTime) * 1000
 		);
 
-		$maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() );
-		if ( $maxAge ) {
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.cached' );
+		$maxAge = $this->getCacheMaxAge($request->getResponseHeaders());
+		if ($maxAge) {
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.cached');
 		}
 
-		if ( $status->isOK() ) {
+		if ($status->isOK()) {
 			$json = $request->getContent();
-			$arr = json_decode( $json, true );
+			$arr = json_decode($json, true);
 			return new CachedQueryResults(
 				$arr,
 				Metadata::ofCachingMetadata(
 					$maxAge ?
-						CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) :
-						CachingMetadata::fresh()
+						CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh()
 				)
 			);
 		} else {
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.error' );
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.error');
 
 			$this->dataFactory->increment(
 				"wikibase.quality.constraints.sparql.error.http.{$request->getStatus()}"
 			);
 
-			if ( $this->isTimeout( $request->getContent() ) ) {
+			if ($this->isTimeout($request->getContent())) {
 				$this->dataFactory->increment(
 					'wikibase.quality.constraints.sparql.error.timeout'
 				);

src/ConstraintCheck/Context/AbstractContext.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 	 */
 	protected $snak;
 
-	public function __construct( EntityDocument $entity, Snak $snak ) {
+	public function __construct(EntityDocument $entity, Snak $snak) {
 		$this->entity = $entity;
 		$this->snak = $snak;
 	}