@@ -80,7 +80,7 @@ discard block |
||
80 | 80 | * @codeCoverageIgnore This method is purely declarative. |
81 | 81 | */ |
82 | 82 | public function getDefaultContextTypes() { |
83 | - return [ Context::TYPE_STATEMENT ]; |
|
83 | + return [Context::TYPE_STATEMENT]; |
|
84 | 84 | } |
85 | 85 | |
86 | 86 | /** @codeCoverageIgnore This method is purely declarative. */ |
@@ -97,31 +97,31 @@ discard block |
||
97 | 97 | * @return CheckResult |
98 | 98 | * @throws ConfigException |
99 | 99 | */ |
100 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
101 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
102 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED ); |
|
100 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
101 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
102 | + return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED); |
|
103 | 103 | } |
104 | 104 | $snak = $context->getSnak(); |
105 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
105 | + if (!$snak instanceof PropertyValueSnak) { |
|
106 | 106 | // nothing to check |
107 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
107 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
108 | 108 | } |
109 | 109 | |
110 | 110 | $dataValue = $snak->getDataValue(); |
111 | - if ( !$dataValue instanceof EntityIdValue ) { |
|
111 | + if (!$dataValue instanceof EntityIdValue) { |
|
112 | 112 | // wrong data type |
113 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
114 | - ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM ) |
|
115 | - ->withDataValueType( 'wikibase-entityid' ); |
|
116 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
113 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
114 | + ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM) |
|
115 | + ->withDataValueType('wikibase-entityid'); |
|
116 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
117 | 117 | } |
118 | 118 | |
119 | 119 | $objectId = $dataValue->getEntityId(); |
120 | - $objectItem = $this->entityLookup->getEntity( $objectId ); |
|
121 | - if ( !( $objectItem instanceof StatementListProvider ) ) { |
|
120 | + $objectItem = $this->entityLookup->getEntity($objectId); |
|
121 | + if (!($objectItem instanceof StatementListProvider)) { |
|
122 | 122 | // object was deleted/doesn't exist |
123 | - $message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' ); |
|
124 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
123 | + $message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist'); |
|
124 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
125 | 125 | } |
126 | 126 | /** @var Statement[] $objectStatements */ |
127 | 127 | $objectStatements = $objectItem->getStatements()->toArray(); |
@@ -129,9 +129,9 @@ discard block |
||
129 | 129 | $subjectId = $context->getEntity()->getId(); |
130 | 130 | $subjectStatements = $context->getEntity()->getStatements()->toArray(); |
131 | 131 | /** @var String[] $startPropertyIds */ |
132 | - $startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS ); |
|
132 | + $startPropertyIds = $this->config->get(self::CONFIG_VARIABLE_START_PROPERTY_IDS); |
|
133 | 133 | /** @var String[] $endPropertyIds */ |
134 | - $endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS ); |
|
134 | + $endPropertyIds = $this->config->get(self::CONFIG_VARIABLE_END_PROPERTY_IDS); |
|
135 | 135 | $subjectStartValue = $this->getExtremeValue( |
136 | 136 | $startPropertyIds, |
137 | 137 | $subjectStatements, |
@@ -153,15 +153,15 @@ discard block |
||
153 | 153 | 'end' |
154 | 154 | ); |
155 | 155 | if ( |
156 | - $this->rangeCheckerHelper->getComparison( $subjectStartValue, $subjectEndValue ) <= 0 && |
|
157 | - $this->rangeCheckerHelper->getComparison( $objectStartValue, $objectEndValue ) <= 0 && ( |
|
158 | - $this->rangeCheckerHelper->getComparison( $subjectEndValue, $objectStartValue ) < 0 || |
|
159 | - $this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectStartValue ) < 0 |
|
156 | + $this->rangeCheckerHelper->getComparison($subjectStartValue, $subjectEndValue) <= 0 && |
|
157 | + $this->rangeCheckerHelper->getComparison($objectStartValue, $objectEndValue) <= 0 && ( |
|
158 | + $this->rangeCheckerHelper->getComparison($subjectEndValue, $objectStartValue) < 0 || |
|
159 | + $this->rangeCheckerHelper->getComparison($objectEndValue, $subjectStartValue) < 0 |
|
160 | 160 | ) |
161 | 161 | ) { |
162 | 162 | if ( |
163 | 163 | $subjectEndValue == null || |
164 | - $this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectEndValue ) < 0 |
|
164 | + $this->rangeCheckerHelper->getComparison($objectEndValue, $subjectEndValue) < 0 |
|
165 | 165 | ) { |
166 | 166 | $earlierEntityId = $objectId; |
167 | 167 | $minEndValue = $objectEndValue; |
@@ -186,7 +186,7 @@ discard block |
||
186 | 186 | $message = null; |
187 | 187 | $status = CheckResult::STATUS_COMPLIANCE; |
188 | 188 | } |
189 | - return new CheckResult( $context, $constraint, $status, $message ); |
|
189 | + return new CheckResult($context, $constraint, $status, $message); |
|
190 | 190 | } |
191 | 191 | |
192 | 192 | /** |
@@ -196,19 +196,19 @@ discard block |
||
196 | 196 | * |
197 | 197 | * @return DataValue|null |
198 | 198 | */ |
199 | - private function getExtremeValue( $extremePropertyIds, $statements, $startOrEnd ) { |
|
200 | - if ( $startOrEnd !== 'start' && $startOrEnd !== 'end' ) { |
|
201 | - throw new \InvalidArgumentException( '$startOrEnd must be \'start\' or \'end\'.' ); |
|
199 | + private function getExtremeValue($extremePropertyIds, $statements, $startOrEnd) { |
|
200 | + if ($startOrEnd !== 'start' && $startOrEnd !== 'end') { |
|
201 | + throw new \InvalidArgumentException('$startOrEnd must be \'start\' or \'end\'.'); |
|
202 | 202 | } |
203 | 203 | $extremeValue = null; |
204 | - foreach ( $extremePropertyIds as $extremePropertyId ) { |
|
205 | - $statementList = new StatementList( ...$statements ); |
|
206 | - $extremeStatements = $statementList->getByPropertyId( new NumericPropertyId( $extremePropertyId ) ); |
|
204 | + foreach ($extremePropertyIds as $extremePropertyId) { |
|
205 | + $statementList = new StatementList(...$statements); |
|
206 | + $extremeStatements = $statementList->getByPropertyId(new NumericPropertyId($extremePropertyId)); |
|
207 | 207 | /** @var Statement $extremeStatement */ |
208 | - foreach ( $extremeStatements as $extremeStatement ) { |
|
209 | - if ( $extremeStatement->getRank() !== Statement::RANK_DEPRECATED ) { |
|
208 | + foreach ($extremeStatements as $extremeStatement) { |
|
209 | + if ($extremeStatement->getRank() !== Statement::RANK_DEPRECATED) { |
|
210 | 210 | $snak = $extremeStatement->getMainSnak(); |
211 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
211 | + if (!$snak instanceof PropertyValueSnak) { |
|
212 | 212 | return null; |
213 | 213 | } else { |
214 | 214 | $comparison = $this->rangeCheckerHelper->getComparison( |
@@ -217,8 +217,8 @@ discard block |
||
217 | 217 | ); |
218 | 218 | if ( |
219 | 219 | $extremeValue === null || |
220 | - ( $startOrEnd === 'start' && $comparison < 0 ) || |
|
221 | - ( $startOrEnd === 'end' && $comparison > 0 ) |
|
220 | + ($startOrEnd === 'start' && $comparison < 0) || |
|
221 | + ($startOrEnd === 'end' && $comparison > 0) |
|
222 | 222 | ) { |
223 | 223 | $extremeValue = $snak->getDataValue(); |
224 | 224 | } |
@@ -248,17 +248,16 @@ discard block |
||
248 | 248 | DataValue $maxStartValue |
249 | 249 | ) { |
250 | 250 | $messageKey = $earlierEntityId === $subjectId ? |
251 | - 'wbqc-violation-message-contemporary-subject-earlier' : |
|
252 | - 'wbqc-violation-message-contemporary-value-earlier'; |
|
253 | - return ( new ViolationMessage( $messageKey ) ) |
|
254 | - ->withEntityId( $subjectId, Role::SUBJECT ) |
|
255 | - ->withEntityId( $propertyId, Role::PREDICATE ) |
|
256 | - ->withEntityId( $objectId, Role::OBJECT ) |
|
257 | - ->withDataValue( $minEndValue, Role::OBJECT ) |
|
258 | - ->withDataValue( $maxStartValue, Role::OBJECT ); |
|
251 | + 'wbqc-violation-message-contemporary-subject-earlier' : 'wbqc-violation-message-contemporary-value-earlier'; |
|
252 | + return (new ViolationMessage($messageKey)) |
|
253 | + ->withEntityId($subjectId, Role::SUBJECT) |
|
254 | + ->withEntityId($propertyId, Role::PREDICATE) |
|
255 | + ->withEntityId($objectId, Role::OBJECT) |
|
256 | + ->withDataValue($minEndValue, Role::OBJECT) |
|
257 | + ->withDataValue($maxStartValue, Role::OBJECT); |
|
259 | 258 | } |
260 | 259 | |
261 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
260 | + public function checkConstraintParameters(Constraint $constraint) { |
|
262 | 261 | // no parameters |
263 | 262 | return []; |
264 | 263 | } |
@@ -81,26 +81,26 @@ discard block |
||
81 | 81 | * @return bool |
82 | 82 | * @throws OverflowException if $entitiesChecked exceeds the configured limit |
83 | 83 | */ |
84 | - private function isSubclassOf( EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0 ) { |
|
85 | - $maxEntities = $this->config->get( 'WBQualityConstraintsTypeCheckMaxEntities' ); |
|
84 | + private function isSubclassOf(EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0) { |
|
85 | + $maxEntities = $this->config->get('WBQualityConstraintsTypeCheckMaxEntities'); |
|
86 | 86 | if ( ++$entitiesChecked > $maxEntities ) { |
87 | - throw new OverflowException( 'Too many entities to check' ); |
|
87 | + throw new OverflowException('Too many entities to check'); |
|
88 | 88 | } |
89 | 89 | |
90 | - $item = $this->entityLookup->getEntity( $comparativeClass ); |
|
91 | - if ( !( $item instanceof StatementListProvider ) ) { |
|
90 | + $item = $this->entityLookup->getEntity($comparativeClass); |
|
91 | + if (!($item instanceof StatementListProvider)) { |
|
92 | 92 | return false; // lookup failed, probably because item doesn't exist |
93 | 93 | } |
94 | 94 | |
95 | - $subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfId' ); |
|
95 | + $subclassId = $this->config->get('WBQualityConstraintsSubclassOfId'); |
|
96 | 96 | $statements = $item->getStatements() |
97 | - ->getByPropertyId( new NumericPropertyId( $subclassId ) ) |
|
97 | + ->getByPropertyId(new NumericPropertyId($subclassId)) |
|
98 | 98 | ->getBestStatements(); |
99 | 99 | /** @var Statement $statement */ |
100 | - foreach ( $statements as $statement ) { |
|
100 | + foreach ($statements as $statement) { |
|
101 | 101 | $mainSnak = $statement->getMainSnak(); |
102 | 102 | |
103 | - if ( !$this->hasCorrectType( $mainSnak ) ) { |
|
103 | + if (!$this->hasCorrectType($mainSnak)) { |
|
104 | 104 | continue; |
105 | 105 | } |
106 | 106 | /** @var PropertyValueSnak $mainSnak */ |
@@ -110,11 +110,11 @@ discard block |
||
110 | 110 | '@phan-var EntityIdValue $dataValue'; |
111 | 111 | $comparativeClass = $dataValue->getEntityId(); |
112 | 112 | |
113 | - if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) { |
|
113 | + if (in_array($comparativeClass->getSerialization(), $classesToCheck)) { |
|
114 | 114 | return true; |
115 | 115 | } |
116 | 116 | |
117 | - if ( $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ) ) { |
|
117 | + if ($this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked)) { |
|
118 | 118 | return true; |
119 | 119 | } |
120 | 120 | } |
@@ -135,40 +135,40 @@ discard block |
||
135 | 135 | * @return CachedBool |
136 | 136 | * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs |
137 | 137 | */ |
138 | - public function isSubclassOfWithSparqlFallback( EntityId $comparativeClass, array $classesToCheck ) { |
|
139 | - $timing = $this->statsFactory->getTiming( 'isSubclassOf_duration_seconds' ) |
|
140 | - ->setLabel( 'result', 'success' ) |
|
141 | - ->setLabel( 'TypeCheckerImplementation', 'php' ) |
|
142 | - ->copyToStatsdAt( 'wikibase.quality.constraints.type.php.success.timing' ); |
|
138 | + public function isSubclassOfWithSparqlFallback(EntityId $comparativeClass, array $classesToCheck) { |
|
139 | + $timing = $this->statsFactory->getTiming('isSubclassOf_duration_seconds') |
|
140 | + ->setLabel('result', 'success') |
|
141 | + ->setLabel('TypeCheckerImplementation', 'php') |
|
142 | + ->copyToStatsdAt('wikibase.quality.constraints.type.php.success.timing'); |
|
143 | 143 | $timing->start(); |
144 | 144 | |
145 | 145 | try { |
146 | 146 | $entitiesChecked = 0; |
147 | - $isSubclass = $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ); |
|
147 | + $isSubclass = $this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked); |
|
148 | 148 | $timing->stop(); |
149 | 149 | |
150 | 150 | // not really a timing, but works like one (we want percentiles etc.) |
151 | 151 | // TODO: probably a good candidate for T348796 |
152 | - $this->statsFactory->getTiming( 'isSubclassOf_entities_total' ) |
|
153 | - ->setLabel( 'TypeCheckerImplementation', 'php' ) |
|
154 | - ->setLabel( 'result', 'success' ) |
|
155 | - ->copyToStatsdAt( 'wikibase.quality.constraints.type.php.success.entities' ) |
|
156 | - ->observe( $entitiesChecked ); |
|
157 | - |
|
158 | - return new CachedBool( $isSubclass, Metadata::blank() ); |
|
159 | - } catch ( OverflowException $e ) { |
|
160 | - $timing->setLabel( 'result', 'overflow' ) |
|
161 | - ->copyToStatsdAt( 'wikibase.quality.constraints.type.php.overflow.timing' ) |
|
152 | + $this->statsFactory->getTiming('isSubclassOf_entities_total') |
|
153 | + ->setLabel('TypeCheckerImplementation', 'php') |
|
154 | + ->setLabel('result', 'success') |
|
155 | + ->copyToStatsdAt('wikibase.quality.constraints.type.php.success.entities') |
|
156 | + ->observe($entitiesChecked); |
|
157 | + |
|
158 | + return new CachedBool($isSubclass, Metadata::blank()); |
|
159 | + } catch (OverflowException $e) { |
|
160 | + $timing->setLabel('result', 'overflow') |
|
161 | + ->copyToStatsdAt('wikibase.quality.constraints.type.php.overflow.timing') |
|
162 | 162 | ->stop(); |
163 | 163 | |
164 | - if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) { |
|
165 | - $this->statsFactory->getCounter( 'sparql_typeFallback_total' ) |
|
166 | - ->copyToStatsdAt( 'wikibase.quality.constraints.sparql.typeFallback' ) |
|
164 | + if (!($this->sparqlHelper instanceof DummySparqlHelper)) { |
|
165 | + $this->statsFactory->getCounter('sparql_typeFallback_total') |
|
166 | + ->copyToStatsdAt('wikibase.quality.constraints.sparql.typeFallback') |
|
167 | 167 | ->increment(); |
168 | 168 | |
169 | - $timing->setLabel( 'TypeCheckerImplementation', 'sparql' ) |
|
170 | - ->setLabel( 'result', 'success' ) |
|
171 | - ->copyToStatsdAt( 'wikibase.quality.constraints.type.sparql.success.timing' ) |
|
169 | + $timing->setLabel('TypeCheckerImplementation', 'sparql') |
|
170 | + ->setLabel('result', 'success') |
|
171 | + ->copyToStatsdAt('wikibase.quality.constraints.type.sparql.success.timing') |
|
172 | 172 | ->start(); |
173 | 173 | |
174 | 174 | $hasType = $this->sparqlHelper->hasType( |
@@ -180,7 +180,7 @@ discard block |
||
180 | 180 | |
181 | 181 | return $hasType; |
182 | 182 | } else { |
183 | - return new CachedBool( false, Metadata::blank() ); |
|
183 | + return new CachedBool(false, Metadata::blank()); |
|
184 | 184 | } |
185 | 185 | } |
186 | 186 | } |
@@ -198,13 +198,13 @@ discard block |
||
198 | 198 | * @return CachedBool |
199 | 199 | * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs |
200 | 200 | */ |
201 | - public function hasClassInRelation( StatementList $statements, array $relationIds, array $classesToCheck ) { |
|
201 | + public function hasClassInRelation(StatementList $statements, array $relationIds, array $classesToCheck) { |
|
202 | 202 | $metadatas = []; |
203 | 203 | |
204 | - foreach ( $this->getBestStatementsByPropertyIds( $statements, $relationIds ) as $statement ) { |
|
204 | + foreach ($this->getBestStatementsByPropertyIds($statements, $relationIds) as $statement) { |
|
205 | 205 | $mainSnak = $statement->getMainSnak(); |
206 | 206 | |
207 | - if ( !$this->hasCorrectType( $mainSnak ) ) { |
|
207 | + if (!$this->hasCorrectType($mainSnak)) { |
|
208 | 208 | continue; |
209 | 209 | } |
210 | 210 | /** @var PropertyValueSnak $mainSnak */ |
@@ -214,24 +214,24 @@ discard block |
||
214 | 214 | '@phan-var EntityIdValue $dataValue'; |
215 | 215 | $comparativeClass = $dataValue->getEntityId(); |
216 | 216 | |
217 | - if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) { |
|
217 | + if (in_array($comparativeClass->getSerialization(), $classesToCheck)) { |
|
218 | 218 | // discard $metadatas, we know this is fresh |
219 | - return new CachedBool( true, Metadata::blank() ); |
|
219 | + return new CachedBool(true, Metadata::blank()); |
|
220 | 220 | } |
221 | 221 | |
222 | - $result = $this->isSubclassOfWithSparqlFallback( $comparativeClass, $classesToCheck ); |
|
222 | + $result = $this->isSubclassOfWithSparqlFallback($comparativeClass, $classesToCheck); |
|
223 | 223 | $metadatas[] = $result->getMetadata(); |
224 | - if ( $result->getBool() ) { |
|
224 | + if ($result->getBool()) { |
|
225 | 225 | return new CachedBool( |
226 | 226 | true, |
227 | - Metadata::merge( $metadatas ) |
|
227 | + Metadata::merge($metadatas) |
|
228 | 228 | ); |
229 | 229 | } |
230 | 230 | } |
231 | 231 | |
232 | 232 | return new CachedBool( |
233 | 233 | false, |
234 | - Metadata::merge( $metadatas ) |
|
234 | + Metadata::merge($metadatas) |
|
235 | 235 | ); |
236 | 236 | } |
237 | 237 | |
@@ -240,7 +240,7 @@ discard block |
||
240 | 240 | * @return bool |
241 | 241 | * @phan-assert PropertyValueSnak $mainSnak |
242 | 242 | */ |
243 | - private function hasCorrectType( Snak $mainSnak ) { |
|
243 | + private function hasCorrectType(Snak $mainSnak) { |
|
244 | 244 | return $mainSnak instanceof PropertyValueSnak |
245 | 245 | && $mainSnak->getDataValue()->getType() === 'wikibase-entityid'; |
246 | 246 | } |
@@ -257,15 +257,15 @@ discard block |
||
257 | 257 | ) { |
258 | 258 | $statementArrays = []; |
259 | 259 | |
260 | - foreach ( $propertyIdSerializations as $propertyIdSerialization ) { |
|
261 | - $propertyId = new NumericPropertyId( $propertyIdSerialization ); |
|
260 | + foreach ($propertyIdSerializations as $propertyIdSerialization) { |
|
261 | + $propertyId = new NumericPropertyId($propertyIdSerialization); |
|
262 | 262 | $statementArrays[] = $statements |
263 | - ->getByPropertyId( $propertyId ) |
|
263 | + ->getByPropertyId($propertyId) |
|
264 | 264 | ->getBestStatements() |
265 | 265 | ->toArray(); |
266 | 266 | } |
267 | 267 | |
268 | - return call_user_func_array( 'array_merge', $statementArrays ); |
|
268 | + return call_user_func_array('array_merge', $statementArrays); |
|
269 | 269 | } |
270 | 270 | |
271 | 271 | /** |
@@ -285,8 +285,8 @@ discard block |
||
285 | 285 | $relation |
286 | 286 | ) { |
287 | 287 | $classes = array_map( |
288 | - static function ( $itemIdSerialization ) { |
|
289 | - return new ItemId( $itemIdSerialization ); |
|
288 | + static function($itemIdSerialization) { |
|
289 | + return new ItemId($itemIdSerialization); |
|
290 | 290 | }, |
291 | 291 | $classes |
292 | 292 | ); |
@@ -298,10 +298,10 @@ discard block |
||
298 | 298 | // wbqc-violation-message-valueType-instance |
299 | 299 | // wbqc-violation-message-valueType-subclass |
300 | 300 | // wbqc-violation-message-valueType-instanceOrSubclass |
301 | - return ( new ViolationMessage( 'wbqc-violation-message-' . $checker . '-' . $relation ) ) |
|
302 | - ->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY ) |
|
303 | - ->withEntityId( $entityId, Role::SUBJECT ) |
|
304 | - ->withEntityIdList( $classes, Role::OBJECT ); |
|
301 | + return (new ViolationMessage('wbqc-violation-message-'.$checker.'-'.$relation)) |
|
302 | + ->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY) |
|
303 | + ->withEntityId($entityId, Role::SUBJECT) |
|
304 | + ->withEntityIdList($classes, Role::OBJECT); |
|
305 | 305 | } |
306 | 306 | |
307 | 307 | } |
@@ -10,20 +10,20 @@ |
||
10 | 10 | use Wikibase\Repo\WikibaseRepo; |
11 | 11 | |
12 | 12 | return [ |
13 | - WikibaseServices::ENTITY_LOOKUP => static function ( MediaWikiServices $services ): EntityLookup { |
|
13 | + WikibaseServices::ENTITY_LOOKUP => static function(MediaWikiServices $services): EntityLookup { |
|
14 | 14 | return new ExceptionIgnoringEntityLookup( |
15 | - WikibaseRepo::getEntityLookup( $services ) |
|
15 | + WikibaseRepo::getEntityLookup($services) |
|
16 | 16 | ); |
17 | 17 | }, |
18 | 18 | |
19 | - WikibaseServices::ENTITY_LOOKUP_WITHOUT_CACHE => static function ( MediaWikiServices $services ): EntityLookup { |
|
19 | + WikibaseServices::ENTITY_LOOKUP_WITHOUT_CACHE => static function(MediaWikiServices $services): EntityLookup { |
|
20 | 20 | return new ExceptionIgnoringEntityLookup( |
21 | - WikibaseRepo::getStore( $services ) |
|
22 | - ->getEntityLookup( Store::LOOKUP_CACHING_RETRIEVE_ONLY ) |
|
21 | + WikibaseRepo::getStore($services) |
|
22 | + ->getEntityLookup(Store::LOOKUP_CACHING_RETRIEVE_ONLY) |
|
23 | 23 | ); |
24 | 24 | }, |
25 | 25 | |
26 | - WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => static function ( MediaWikiServices $services ): PropertyDataTypeLookup { |
|
27 | - return WikibaseRepo::getPropertyDataTypeLookup( $services ); |
|
26 | + WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => static function(MediaWikiServices $services): PropertyDataTypeLookup { |
|
27 | + return WikibaseRepo::getPropertyDataTypeLookup($services); |
|
28 | 28 | }, |
29 | 29 | ]; |
@@ -38,216 +38,216 @@ |
||
38 | 38 | use WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\ValueTypeChecker; |
39 | 39 | |
40 | 40 | return [ |
41 | - ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => static function ( MediaWikiServices $services ): ConflictsWithChecker { |
|
41 | + ConstraintCheckerServices::CONFLICTS_WITH_CHECKER => static function(MediaWikiServices $services): ConflictsWithChecker { |
|
42 | 42 | return new ConflictsWithChecker( |
43 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
44 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
43 | + ConstraintsServices::getConstraintParameterParser($services), |
|
44 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
45 | 45 | ); |
46 | 46 | }, |
47 | 47 | |
48 | - ConstraintCheckerServices::ITEM_CHECKER => static function ( MediaWikiServices $services ): ItemChecker { |
|
48 | + ConstraintCheckerServices::ITEM_CHECKER => static function(MediaWikiServices $services): ItemChecker { |
|
49 | 49 | return new ItemChecker( |
50 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
51 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
50 | + ConstraintsServices::getConstraintParameterParser($services), |
|
51 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
52 | 52 | ); |
53 | 53 | }, |
54 | 54 | |
55 | - ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => static function ( |
|
55 | + ConstraintCheckerServices::TARGET_REQUIRED_CLAIM_CHECKER => static function( |
|
56 | 56 | MediaWikiServices $services |
57 | 57 | ): TargetRequiredClaimChecker { |
58 | 58 | return new TargetRequiredClaimChecker( |
59 | - WikibaseServices::getEntityLookup( $services ), |
|
60 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
61 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
59 | + WikibaseServices::getEntityLookup($services), |
|
60 | + ConstraintsServices::getConstraintParameterParser($services), |
|
61 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
62 | 62 | ); |
63 | 63 | }, |
64 | 64 | |
65 | - ConstraintCheckerServices::SYMMETRIC_CHECKER => static function ( MediaWikiServices $services ): SymmetricChecker { |
|
65 | + ConstraintCheckerServices::SYMMETRIC_CHECKER => static function(MediaWikiServices $services): SymmetricChecker { |
|
66 | 66 | return new SymmetricChecker( |
67 | - WikibaseServices::getEntityLookupWithoutCache( $services ), |
|
68 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
67 | + WikibaseServices::getEntityLookupWithoutCache($services), |
|
68 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
69 | 69 | ); |
70 | 70 | }, |
71 | 71 | |
72 | - ConstraintCheckerServices::INVERSE_CHECKER => static function ( MediaWikiServices $services ): InverseChecker { |
|
72 | + ConstraintCheckerServices::INVERSE_CHECKER => static function(MediaWikiServices $services): InverseChecker { |
|
73 | 73 | return new InverseChecker( |
74 | - WikibaseServices::getEntityLookup( $services ), |
|
75 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
76 | - ConstraintsServices::getConnectionCheckerHelper( $services ) |
|
74 | + WikibaseServices::getEntityLookup($services), |
|
75 | + ConstraintsServices::getConstraintParameterParser($services), |
|
76 | + ConstraintsServices::getConnectionCheckerHelper($services) |
|
77 | 77 | ); |
78 | 78 | }, |
79 | 79 | |
80 | - ConstraintCheckerServices::QUALIFIER_CHECKER => static function ( MediaWikiServices $services ): QualifierChecker { |
|
80 | + ConstraintCheckerServices::QUALIFIER_CHECKER => static function(MediaWikiServices $services): QualifierChecker { |
|
81 | 81 | return new QualifierChecker(); |
82 | 82 | }, |
83 | 83 | |
84 | - ConstraintCheckerServices::QUALIFIERS_CHECKER => static function ( MediaWikiServices $services ): QualifiersChecker { |
|
84 | + ConstraintCheckerServices::QUALIFIERS_CHECKER => static function(MediaWikiServices $services): QualifiersChecker { |
|
85 | 85 | return new QualifiersChecker( |
86 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
86 | + ConstraintsServices::getConstraintParameterParser($services) |
|
87 | 87 | ); |
88 | 88 | }, |
89 | 89 | |
90 | - ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => static function ( |
|
90 | + ConstraintCheckerServices::MANDATORY_QUALIFIERS_CHECKER => static function( |
|
91 | 91 | MediaWikiServices $services |
92 | 92 | ): MandatoryQualifiersChecker { |
93 | 93 | return new MandatoryQualifiersChecker( |
94 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
94 | + ConstraintsServices::getConstraintParameterParser($services) |
|
95 | 95 | ); |
96 | 96 | }, |
97 | 97 | |
98 | - ConstraintCheckerServices::RANGE_CHECKER => static function ( MediaWikiServices $services ): RangeChecker { |
|
98 | + ConstraintCheckerServices::RANGE_CHECKER => static function(MediaWikiServices $services): RangeChecker { |
|
99 | 99 | return new RangeChecker( |
100 | - WikibaseServices::getPropertyDataTypeLookup( $services ), |
|
101 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
102 | - ConstraintsServices::getRangeCheckerHelper( $services ) |
|
100 | + WikibaseServices::getPropertyDataTypeLookup($services), |
|
101 | + ConstraintsServices::getConstraintParameterParser($services), |
|
102 | + ConstraintsServices::getRangeCheckerHelper($services) |
|
103 | 103 | ); |
104 | 104 | }, |
105 | 105 | |
106 | - ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => static function ( |
|
106 | + ConstraintCheckerServices::DIFF_WITHIN_RANGE_CHECKER => static function( |
|
107 | 107 | MediaWikiServices $services |
108 | 108 | ): DiffWithinRangeChecker { |
109 | 109 | return new DiffWithinRangeChecker( |
110 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
111 | - ConstraintsServices::getRangeCheckerHelper( $services ), |
|
110 | + ConstraintsServices::getConstraintParameterParser($services), |
|
111 | + ConstraintsServices::getRangeCheckerHelper($services), |
|
112 | 112 | $services->getMainConfig() |
113 | 113 | ); |
114 | 114 | }, |
115 | 115 | |
116 | - ConstraintCheckerServices::TYPE_CHECKER => static function ( MediaWikiServices $services ): TypeChecker { |
|
116 | + ConstraintCheckerServices::TYPE_CHECKER => static function(MediaWikiServices $services): TypeChecker { |
|
117 | 117 | return new TypeChecker( |
118 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
119 | - ConstraintsServices::getTypeCheckerHelper( $services ), |
|
118 | + ConstraintsServices::getConstraintParameterParser($services), |
|
119 | + ConstraintsServices::getTypeCheckerHelper($services), |
|
120 | 120 | $services->getMainConfig() |
121 | 121 | ); |
122 | 122 | }, |
123 | 123 | |
124 | - ConstraintCheckerServices::VALUE_TYPE_CHECKER => static function ( MediaWikiServices $services ): ValueTypeChecker { |
|
124 | + ConstraintCheckerServices::VALUE_TYPE_CHECKER => static function(MediaWikiServices $services): ValueTypeChecker { |
|
125 | 125 | return new ValueTypeChecker( |
126 | - WikibaseServices::getEntityLookup( $services ), |
|
127 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
128 | - ConstraintsServices::getTypeCheckerHelper( $services ), |
|
126 | + WikibaseServices::getEntityLookup($services), |
|
127 | + ConstraintsServices::getConstraintParameterParser($services), |
|
128 | + ConstraintsServices::getTypeCheckerHelper($services), |
|
129 | 129 | $services->getMainConfig() |
130 | 130 | ); |
131 | 131 | }, |
132 | 132 | |
133 | - ConstraintCheckerServices::SINGLE_VALUE_CHECKER => static function ( MediaWikiServices $services ): SingleValueChecker { |
|
133 | + ConstraintCheckerServices::SINGLE_VALUE_CHECKER => static function(MediaWikiServices $services): SingleValueChecker { |
|
134 | 134 | return new SingleValueChecker( |
135 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
135 | + ConstraintsServices::getConstraintParameterParser($services) |
|
136 | 136 | ); |
137 | 137 | }, |
138 | 138 | |
139 | - ConstraintCheckerServices::MULTI_VALUE_CHECKER => static function ( MediaWikiServices $services ): MultiValueChecker { |
|
139 | + ConstraintCheckerServices::MULTI_VALUE_CHECKER => static function(MediaWikiServices $services): MultiValueChecker { |
|
140 | 140 | return new MultiValueChecker( |
141 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
141 | + ConstraintsServices::getConstraintParameterParser($services) |
|
142 | 142 | ); |
143 | 143 | }, |
144 | 144 | |
145 | - ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => static function ( MediaWikiServices $services ): UniqueValueChecker { |
|
145 | + ConstraintCheckerServices::UNIQUE_VALUE_CHECKER => static function(MediaWikiServices $services): UniqueValueChecker { |
|
146 | 146 | // TODO return a different, dummy implementation if SPARQL is not available |
147 | 147 | return new UniqueValueChecker( |
148 | - ConstraintsServices::getSparqlHelper( $services ), |
|
149 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
148 | + ConstraintsServices::getSparqlHelper($services), |
|
149 | + ConstraintsServices::getConstraintParameterParser($services) |
|
150 | 150 | ); |
151 | 151 | }, |
152 | 152 | |
153 | - ConstraintCheckerServices::FORMAT_CHECKER => static function ( MediaWikiServices $services ): FormatChecker { |
|
153 | + ConstraintCheckerServices::FORMAT_CHECKER => static function(MediaWikiServices $services): FormatChecker { |
|
154 | 154 | // TODO return a different, dummy implementation if SPARQL is not available |
155 | 155 | return new FormatChecker( |
156 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
156 | + ConstraintsServices::getConstraintParameterParser($services), |
|
157 | 157 | $services->getMainConfig(), |
158 | - ConstraintsServices::getSparqlHelper( $services ), |
|
158 | + ConstraintsServices::getSparqlHelper($services), |
|
159 | 159 | $services->getShellboxClientFactory() |
160 | 160 | ); |
161 | 161 | }, |
162 | 162 | |
163 | - ConstraintCheckerServices::COMMONS_LINK_CHECKER => static function ( MediaWikiServices $services ): CommonsLinkChecker { |
|
163 | + ConstraintCheckerServices::COMMONS_LINK_CHECKER => static function(MediaWikiServices $services): CommonsLinkChecker { |
|
164 | 164 | $pageNameNormalizer = new MediaWikiPageNameNormalizer(); |
165 | 165 | return new CommonsLinkChecker( |
166 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
166 | + ConstraintsServices::getConstraintParameterParser($services), |
|
167 | 167 | $pageNameNormalizer, |
168 | - WikibaseRepo::getPropertyDataTypeLookup( $services ) |
|
168 | + WikibaseRepo::getPropertyDataTypeLookup($services) |
|
169 | 169 | ); |
170 | 170 | }, |
171 | 171 | |
172 | - ConstraintCheckerServices::ONE_OF_CHECKER => static function ( MediaWikiServices $services ): OneOfChecker { |
|
172 | + ConstraintCheckerServices::ONE_OF_CHECKER => static function(MediaWikiServices $services): OneOfChecker { |
|
173 | 173 | return new OneOfChecker( |
174 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
174 | + ConstraintsServices::getConstraintParameterParser($services) |
|
175 | 175 | ); |
176 | 176 | }, |
177 | 177 | |
178 | - ConstraintCheckerServices::VALUE_ONLY_CHECKER => static function ( MediaWikiServices $services ): ValueOnlyChecker { |
|
178 | + ConstraintCheckerServices::VALUE_ONLY_CHECKER => static function(MediaWikiServices $services): ValueOnlyChecker { |
|
179 | 179 | return new ValueOnlyChecker(); |
180 | 180 | }, |
181 | 181 | |
182 | - ConstraintCheckerServices::REFERENCE_CHECKER => static function ( MediaWikiServices $services ): ReferenceChecker { |
|
182 | + ConstraintCheckerServices::REFERENCE_CHECKER => static function(MediaWikiServices $services): ReferenceChecker { |
|
183 | 183 | return new ReferenceChecker(); |
184 | 184 | }, |
185 | 185 | |
186 | - ConstraintCheckerServices::NO_BOUNDS_CHECKER => static function ( MediaWikiServices $services ): NoBoundsChecker { |
|
186 | + ConstraintCheckerServices::NO_BOUNDS_CHECKER => static function(MediaWikiServices $services): NoBoundsChecker { |
|
187 | 187 | return new NoBoundsChecker(); |
188 | 188 | }, |
189 | 189 | |
190 | - ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => static function ( MediaWikiServices $services ): AllowedUnitsChecker { |
|
190 | + ConstraintCheckerServices::ALLOWED_UNITS_CHECKER => static function(MediaWikiServices $services): AllowedUnitsChecker { |
|
191 | 191 | return new AllowedUnitsChecker( |
192 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
193 | - WikibaseRepo::getUnitConverter( $services ) |
|
192 | + ConstraintsServices::getConstraintParameterParser($services), |
|
193 | + WikibaseRepo::getUnitConverter($services) |
|
194 | 194 | ); |
195 | 195 | }, |
196 | 196 | |
197 | - ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => static function ( |
|
197 | + ConstraintCheckerServices::SINGLE_BEST_VALUE_CHECKER => static function( |
|
198 | 198 | MediaWikiServices $services |
199 | 199 | ): SingleBestValueChecker { |
200 | 200 | return new SingleBestValueChecker( |
201 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
201 | + ConstraintsServices::getConstraintParameterParser($services) |
|
202 | 202 | ); |
203 | 203 | }, |
204 | 204 | |
205 | - ConstraintCheckerServices::ENTITY_TYPE_CHECKER => static function ( MediaWikiServices $services ): EntityTypeChecker { |
|
205 | + ConstraintCheckerServices::ENTITY_TYPE_CHECKER => static function(MediaWikiServices $services): EntityTypeChecker { |
|
206 | 206 | return new EntityTypeChecker( |
207 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
207 | + ConstraintsServices::getConstraintParameterParser($services) |
|
208 | 208 | ); |
209 | 209 | }, |
210 | 210 | |
211 | - ConstraintCheckerServices::NONE_OF_CHECKER => static function ( MediaWikiServices $services ): NoneOfChecker { |
|
211 | + ConstraintCheckerServices::NONE_OF_CHECKER => static function(MediaWikiServices $services): NoneOfChecker { |
|
212 | 212 | return new NoneOfChecker( |
213 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
213 | + ConstraintsServices::getConstraintParameterParser($services) |
|
214 | 214 | ); |
215 | 215 | }, |
216 | 216 | |
217 | - ConstraintCheckerServices::INTEGER_CHECKER => static function ( MediaWikiServices $services ): IntegerChecker { |
|
217 | + ConstraintCheckerServices::INTEGER_CHECKER => static function(MediaWikiServices $services): IntegerChecker { |
|
218 | 218 | return new IntegerChecker(); |
219 | 219 | }, |
220 | 220 | |
221 | - ConstraintCheckerServices::CITATION_NEEDED_CHECKER => static function ( MediaWikiServices $services ): CitationNeededChecker { |
|
221 | + ConstraintCheckerServices::CITATION_NEEDED_CHECKER => static function(MediaWikiServices $services): CitationNeededChecker { |
|
222 | 222 | return new CitationNeededChecker(); |
223 | 223 | }, |
224 | 224 | |
225 | - ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => static function ( MediaWikiServices $services ): PropertyScopeChecker { |
|
225 | + ConstraintCheckerServices::PROPERTY_SCOPE_CHECKER => static function(MediaWikiServices $services): PropertyScopeChecker { |
|
226 | 226 | return new PropertyScopeChecker( |
227 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
227 | + ConstraintsServices::getConstraintParameterParser($services) |
|
228 | 228 | ); |
229 | 229 | }, |
230 | 230 | |
231 | - ConstraintCheckerServices::CONTEMPORARY_CHECKER => static function ( MediaWikiServices $services ): ContemporaryChecker { |
|
231 | + ConstraintCheckerServices::CONTEMPORARY_CHECKER => static function(MediaWikiServices $services): ContemporaryChecker { |
|
232 | 232 | return new ContemporaryChecker( |
233 | - WikibaseServices::getEntityLookup( $services ), |
|
234 | - ConstraintsServices::getRangeCheckerHelper( $services ), |
|
233 | + WikibaseServices::getEntityLookup($services), |
|
234 | + ConstraintsServices::getRangeCheckerHelper($services), |
|
235 | 235 | $services->getMainConfig() |
236 | 236 | ); |
237 | 237 | }, |
238 | 238 | |
239 | - ConstraintCheckerServices::LEXEME_LANGUAGE_CHECKER => static function ( MediaWikiServices $services ): LanguageChecker { |
|
239 | + ConstraintCheckerServices::LEXEME_LANGUAGE_CHECKER => static function(MediaWikiServices $services): LanguageChecker { |
|
240 | 240 | return new LanguageChecker( |
241 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
242 | - WikibaseServices::getEntityLookup( $services ) |
|
241 | + ConstraintsServices::getConstraintParameterParser($services), |
|
242 | + WikibaseServices::getEntityLookup($services) |
|
243 | 243 | ); |
244 | 244 | }, |
245 | 245 | |
246 | - ConstraintCheckerServices::LABEL_IN_LANGUAGE_CHECKER => static function ( |
|
246 | + ConstraintCheckerServices::LABEL_IN_LANGUAGE_CHECKER => static function( |
|
247 | 247 | MediaWikiServices $services |
248 | 248 | ): LabelInLanguageChecker { |
249 | 249 | return new LabelInLanguageChecker( |
250 | - ConstraintsServices::getConstraintParameterParser( $services ) |
|
250 | + ConstraintsServices::getConstraintParameterParser($services) |
|
251 | 251 | ); |
252 | 252 | }, |
253 | 253 | ]; |
@@ -26,7 +26,7 @@ discard block |
||
26 | 26 | /** |
27 | 27 | * @param BagOStuff $cache |
28 | 28 | */ |
29 | - public function __construct( BagOStuff $cache ) { |
|
29 | + public function __construct(BagOStuff $cache) { |
|
30 | 30 | $this->cache = $cache; |
31 | 31 | } |
32 | 32 | |
@@ -37,17 +37,17 @@ discard block |
||
37 | 37 | * |
38 | 38 | * @throws \Wikimedia\Assert\ParameterTypeException |
39 | 39 | */ |
40 | - private function makeKey( $id ) { |
|
41 | - if ( trim( $id ) === '' ) { |
|
42 | - throw new ParameterTypeException( '$id', 'non-empty string' ); |
|
40 | + private function makeKey($id) { |
|
41 | + if (trim($id) === '') { |
|
42 | + throw new ParameterTypeException('$id', 'non-empty string'); |
|
43 | 43 | } |
44 | 44 | |
45 | - Assert::parameterType( 'string', $id, '$id' ); |
|
45 | + Assert::parameterType('string', $id, '$id'); |
|
46 | 46 | |
47 | 47 | return $this->cache->makeKey( |
48 | 48 | 'WikibaseQualityConstraints', |
49 | 49 | 'ExpiryLock', |
50 | - (string)$id |
|
50 | + (string) $id |
|
51 | 51 | ); |
52 | 52 | } |
53 | 53 | |
@@ -59,15 +59,15 @@ discard block |
||
59 | 59 | * |
60 | 60 | * @throws \Wikimedia\Assert\ParameterTypeException |
61 | 61 | */ |
62 | - public function lock( $id, ConvertibleTimestamp $expiryTimestamp ) { |
|
62 | + public function lock($id, ConvertibleTimestamp $expiryTimestamp) { |
|
63 | 63 | |
64 | - $cacheId = $this->makeKey( $id ); |
|
64 | + $cacheId = $this->makeKey($id); |
|
65 | 65 | |
66 | - if ( !$this->isLockedInternal( $cacheId ) ) { |
|
66 | + if (!$this->isLockedInternal($cacheId)) { |
|
67 | 67 | return $this->cache->set( |
68 | 68 | $cacheId, |
69 | - $expiryTimestamp->getTimestamp( TS_UNIX ), |
|
70 | - (int)$expiryTimestamp->getTimestamp( TS_UNIX ) |
|
69 | + $expiryTimestamp->getTimestamp(TS_UNIX), |
|
70 | + (int) $expiryTimestamp->getTimestamp(TS_UNIX) |
|
71 | 71 | ); |
72 | 72 | } else { |
73 | 73 | return false; |
@@ -81,20 +81,20 @@ discard block |
||
81 | 81 | * |
82 | 82 | * @throws \Wikimedia\Assert\ParameterTypeException |
83 | 83 | */ |
84 | - private function isLockedInternal( $cacheId ) { |
|
85 | - $expiryTime = $this->cache->get( $cacheId ); |
|
86 | - if ( !$expiryTime ) { |
|
84 | + private function isLockedInternal($cacheId) { |
|
85 | + $expiryTime = $this->cache->get($cacheId); |
|
86 | + if (!$expiryTime) { |
|
87 | 87 | return false; |
88 | 88 | } |
89 | 89 | |
90 | 90 | try { |
91 | - $lockExpiryTimeStamp = new ConvertibleTimestamp( $expiryTime ); |
|
92 | - } catch ( TimestampException $exception ) { |
|
91 | + $lockExpiryTimeStamp = new ConvertibleTimestamp($expiryTime); |
|
92 | + } catch (TimestampException $exception) { |
|
93 | 93 | return false; |
94 | 94 | } |
95 | 95 | |
96 | 96 | $now = new ConvertibleTimestamp(); |
97 | - if ( $now->timestamp < $lockExpiryTimeStamp->timestamp ) { |
|
97 | + if ($now->timestamp < $lockExpiryTimeStamp->timestamp) { |
|
98 | 98 | return true; |
99 | 99 | } else { |
100 | 100 | return false; |
@@ -108,8 +108,8 @@ discard block |
||
108 | 108 | * |
109 | 109 | * @throws \Wikimedia\Assert\ParameterTypeException |
110 | 110 | */ |
111 | - public function isLocked( $id ) { |
|
112 | - return $this->isLockedInternal( $this->makeKey( $id ) ); |
|
111 | + public function isLocked($id) { |
|
112 | + return $this->isLockedInternal($this->makeKey($id)); |
|
113 | 113 | } |
114 | 114 | |
115 | 115 | } |
@@ -53,12 +53,12 @@ discard block |
||
53 | 53 | $this->dataFactory = $dataFactory; |
54 | 54 | $this->logger = $logger; |
55 | 55 | $this->constraintCheckDurationLimits = [ |
56 | - 'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ), |
|
57 | - 'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ), |
|
56 | + 'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'), |
|
57 | + 'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'), |
|
58 | 58 | ]; |
59 | 59 | $this->constraintCheckOnEntityDurationLimits = [ |
60 | - 'info' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationInfoSeconds' ), |
|
61 | - 'warning' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationWarningSeconds' ), |
|
60 | + 'info' => $config->get('WBQualityConstraintsCheckOnEntityDurationInfoSeconds'), |
|
61 | + 'warning' => $config->get('WBQualityConstraintsCheckOnEntityDurationWarningSeconds'), |
|
62 | 62 | ]; |
63 | 63 | } |
64 | 64 | |
@@ -69,23 +69,23 @@ discard block |
||
69 | 69 | * @param float $durationSeconds |
70 | 70 | * @return array [ $limitSeconds, $logLevel ] |
71 | 71 | */ |
72 | - private function findLimit( $limits, $durationSeconds ) { |
|
72 | + private function findLimit($limits, $durationSeconds) { |
|
73 | 73 | $limitSeconds = null; |
74 | 74 | $logLevel = null; |
75 | 75 | |
76 | - foreach ( $limits as $level => $limit ) { |
|
76 | + foreach ($limits as $level => $limit) { |
|
77 | 77 | if ( |
78 | 78 | // duration exceeds this limit |
79 | 79 | $limit !== null && $durationSeconds > $limit && |
80 | 80 | // this limit is longer than previous longest limit |
81 | - ( $limitSeconds === null || $limit > $limitSeconds ) |
|
81 | + ($limitSeconds === null || $limit > $limitSeconds) |
|
82 | 82 | ) { |
83 | 83 | $limitSeconds = $limit; |
84 | 84 | $logLevel = $level; |
85 | 85 | } |
86 | 86 | } |
87 | 87 | |
88 | - return [ $limitSeconds, $logLevel ]; |
|
88 | + return [$limitSeconds, $logLevel]; |
|
89 | 89 | } |
90 | 90 | |
91 | 91 | /** |
@@ -110,31 +110,31 @@ discard block |
||
110 | 110 | $durationSeconds, |
111 | 111 | $method |
112 | 112 | ) { |
113 | - $constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 ); |
|
113 | + $constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1); |
|
114 | 114 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
115 | 115 | |
116 | 116 | $this->dataFactory->timing( |
117 | - 'wikibase.quality.constraints.check.timing.' . |
|
118 | - $constraintTypeItemId . '-' . |
|
117 | + 'wikibase.quality.constraints.check.timing.'. |
|
118 | + $constraintTypeItemId.'-'. |
|
119 | 119 | $constraintCheckerClassShortName, |
120 | 120 | $durationSeconds * 1000 |
121 | 121 | ); |
122 | 122 | |
123 | 123 | // find the longest limit (and associated log level) that the duration exceeds |
124 | - [ $limitSeconds, $logLevel ] = $this->findLimit( |
|
124 | + [$limitSeconds, $logLevel] = $this->findLimit( |
|
125 | 125 | $this->constraintCheckDurationLimits, |
126 | 126 | $durationSeconds |
127 | 127 | ); |
128 | - if ( $limitSeconds === null ) { |
|
128 | + if ($limitSeconds === null) { |
|
129 | 129 | return; |
130 | 130 | } |
131 | - if ( $context->getType() !== Context::TYPE_STATEMENT ) { |
|
131 | + if ($context->getType() !== Context::TYPE_STATEMENT) { |
|
132 | 132 | // TODO log less details but still log something |
133 | 133 | return; |
134 | 134 | } |
135 | 135 | |
136 | 136 | $resultMessage = $result->getMessage(); |
137 | - if ( $resultMessage !== null ) { |
|
137 | + if ($resultMessage !== null) { |
|
138 | 138 | $resultMessageKey = $resultMessage->getMessageKey(); |
139 | 139 | } else { |
140 | 140 | $resultMessageKey = null; |
@@ -142,8 +142,8 @@ discard block |
||
142 | 142 | |
143 | 143 | $this->logger->log( |
144 | 144 | $logLevel, |
145 | - 'Constraint check with {constraintCheckerClassShortName} ' . |
|
146 | - 'took longer than {limitSeconds} second(s) ' . |
|
145 | + 'Constraint check with {constraintCheckerClassShortName} '. |
|
146 | + 'took longer than {limitSeconds} second(s) '. |
|
147 | 147 | '(duration: {durationSeconds} seconds).', |
148 | 148 | [ |
149 | 149 | 'method' => $method, |
@@ -153,7 +153,7 @@ discard block |
||
153 | 153 | 'constraintId' => $constraint->getConstraintId(), |
154 | 154 | 'constraintPropertyId' => $constraint->getPropertyId()->getSerialization(), |
155 | 155 | 'constraintTypeItemId' => $constraintTypeItemId, |
156 | - 'constraintParameters' => json_encode( $constraint->getConstraintParameters() ), |
|
156 | + 'constraintParameters' => json_encode($constraint->getConstraintParameters()), |
|
157 | 157 | 'constraintCheckerClass' => $constraintCheckerClass, |
158 | 158 | 'constraintCheckerClassShortName' => $constraintCheckerClassShortName, |
159 | 159 | 'entityId' => $context->getEntity()->getId()->getSerialization(), |
@@ -188,18 +188,18 @@ discard block |
||
188 | 188 | ); |
189 | 189 | |
190 | 190 | // find the longest limit (and associated log level) that the duration exceeds |
191 | - [ $limitSeconds, $logLevel ] = $this->findLimit( |
|
191 | + [$limitSeconds, $logLevel] = $this->findLimit( |
|
192 | 192 | $this->constraintCheckOnEntityDurationLimits, |
193 | 193 | $durationSeconds |
194 | 194 | ); |
195 | - if ( $limitSeconds === null ) { |
|
195 | + if ($limitSeconds === null) { |
|
196 | 196 | return; |
197 | 197 | } |
198 | 198 | |
199 | 199 | $this->logger->log( |
200 | 200 | $logLevel, |
201 | - 'Full constraint check on {entityId} ' . |
|
202 | - 'took longer than {limitSeconds} second(s) ' . |
|
201 | + 'Full constraint check on {entityId} '. |
|
202 | + 'took longer than {limitSeconds} second(s) '. |
|
203 | 203 | '(duration: {durationSeconds} seconds).', |
204 | 204 | [ |
205 | 205 | 'method' => $method, |
@@ -217,7 +217,7 @@ discard block |
||
217 | 217 | * |
218 | 218 | * @param EntityId $entityId |
219 | 219 | */ |
220 | - public function logCheckConstraintsCacheHit( EntityId $entityId ) { |
|
220 | + public function logCheckConstraintsCacheHit(EntityId $entityId) { |
|
221 | 221 | $this->dataFactory->increment( |
222 | 222 | 'wikibase.quality.constraints.cache.entity.hit' |
223 | 223 | ); |
@@ -228,10 +228,10 @@ discard block |
||
228 | 228 | * |
229 | 229 | * @param EntityId[] $entityIds |
230 | 230 | */ |
231 | - public function logCheckConstraintsCacheMisses( array $entityIds ) { |
|
231 | + public function logCheckConstraintsCacheMisses(array $entityIds) { |
|
232 | 232 | $this->dataFactory->updateCount( |
233 | 233 | 'wikibase.quality.constraints.cache.entity.miss', |
234 | - count( $entityIds ) |
|
234 | + count($entityIds) |
|
235 | 235 | ); |
236 | 236 | } |
237 | 237 | |
@@ -258,17 +258,17 @@ discard block |
||
258 | 258 | * @param EntityId[] $entityIds |
259 | 259 | * @param int $maxRevisionIds |
260 | 260 | */ |
261 | - public function logHugeDependencyMetadata( array $entityIds, $maxRevisionIds ) { |
|
261 | + public function logHugeDependencyMetadata(array $entityIds, $maxRevisionIds) { |
|
262 | 262 | $this->logger->log( |
263 | 263 | 'warning', |
264 | - 'Dependency metadata for constraint check result has huge set of entity IDs ' . |
|
265 | - '(count ' . count( $entityIds ) . ', limit ' . $maxRevisionIds . '); ' . |
|
264 | + 'Dependency metadata for constraint check result has huge set of entity IDs '. |
|
265 | + '(count '.count($entityIds).', limit '.$maxRevisionIds.'); '. |
|
266 | 266 | 'caching disabled for this check result.', |
267 | 267 | [ |
268 | 268 | 'loggingMethod' => __METHOD__, |
269 | 269 | 'entityIds' => json_encode( |
270 | 270 | array_map( |
271 | - static function ( EntityId $entityId ) { |
|
271 | + static function(EntityId $entityId) { |
|
272 | 272 | return $entityId->getSerialization(); |
273 | 273 | }, |
274 | 274 | $entityIds |
@@ -287,17 +287,17 @@ discard block |
||
287 | 287 | 'Sparql API replied with status 429 and a retry-after header. Requesting to retry after {retryAfterTime}', |
288 | 288 | [ |
289 | 289 | 'retryAfterTime' => $retryAfterTime, |
290 | - 'responseHeaders' => json_encode( $request->getResponseHeaders() ), |
|
290 | + 'responseHeaders' => json_encode($request->getResponseHeaders()), |
|
291 | 291 | 'responseContent' => $request->getContent(), |
292 | 292 | ] |
293 | 293 | ); |
294 | 294 | } |
295 | 295 | |
296 | - public function logSparqlHelperTooManyRequestsRetryAfterInvalid( MWHttpRequest $request ) { |
|
296 | + public function logSparqlHelperTooManyRequestsRetryAfterInvalid(MWHttpRequest $request) { |
|
297 | 297 | $this->logger->warning( |
298 | 298 | 'Sparql API replied with status 429 and no valid retry-after header.', |
299 | 299 | [ |
300 | - 'responseHeaders' => json_encode( $request->getResponseHeaders() ), |
|
300 | + 'responseHeaders' => json_encode($request->getResponseHeaders()), |
|
301 | 301 | 'responseContent' => $request->getContent(), |
302 | 302 | ] |
303 | 303 | ); |
@@ -15,7 +15,7 @@ discard block |
||
15 | 15 | * |
16 | 16 | * @throws DBUnexpectedError |
17 | 17 | */ |
18 | - public function insertBatch( array $constraints ); |
|
18 | + public function insertBatch(array $constraints); |
|
19 | 19 | |
20 | 20 | /** |
21 | 21 | * Delete all constraints for the property ID. |
@@ -24,6 +24,6 @@ discard block |
||
24 | 24 | * |
25 | 25 | * @throws DBUnexpectedError |
26 | 26 | */ |
27 | - public function deleteForProperty( NumericPropertyId $propertyId ); |
|
27 | + public function deleteForProperty(NumericPropertyId $propertyId); |
|
28 | 28 | |
29 | 29 | } |
@@ -24,16 +24,16 @@ discard block |
||
24 | 24 | * then using the main DBLoadBalancer service may be incorrect. |
25 | 25 | * @param string|false $dbName Database name ($domain for ILoadBalancer methods). |
26 | 26 | */ |
27 | - public function __construct( ILoadBalancer $lb, $dbName ) { |
|
27 | + public function __construct(ILoadBalancer $lb, $dbName) { |
|
28 | 28 | $this->lb = $lb; |
29 | 29 | $this->dbName = $dbName; |
30 | 30 | } |
31 | 31 | |
32 | - private function encodeConstraintParameters( array $constraintParameters ) { |
|
33 | - $json = json_encode( $constraintParameters, JSON_FORCE_OBJECT ); |
|
32 | + private function encodeConstraintParameters(array $constraintParameters) { |
|
33 | + $json = json_encode($constraintParameters, JSON_FORCE_OBJECT); |
|
34 | 34 | |
35 | - if ( strlen( $json ) > 50000 ) { |
|
36 | - $json = json_encode( [ '@error' => [ 'toolong' => true ] ] ); |
|
35 | + if (strlen($json) > 50000) { |
|
36 | + $json = json_encode(['@error' => ['toolong' => true]]); |
|
37 | 37 | } |
38 | 38 | |
39 | 39 | return $json; |
@@ -44,28 +44,28 @@ discard block |
||
44 | 44 | * |
45 | 45 | * @throws DBUnexpectedError |
46 | 46 | */ |
47 | - public function insertBatch( array $constraints ) { |
|
48 | - if ( !$constraints ) { |
|
47 | + public function insertBatch(array $constraints) { |
|
48 | + if (!$constraints) { |
|
49 | 49 | return; |
50 | 50 | } |
51 | 51 | |
52 | 52 | $accumulator = array_map( |
53 | - function ( Constraint $constraint ) { |
|
53 | + function(Constraint $constraint) { |
|
54 | 54 | return [ |
55 | 55 | 'constraint_guid' => $constraint->getConstraintId(), |
56 | 56 | 'pid' => $constraint->getPropertyId()->getNumericId(), |
57 | 57 | 'constraint_type_qid' => $constraint->getConstraintTypeItemId(), |
58 | - 'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() ), |
|
58 | + 'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters()), |
|
59 | 59 | ]; |
60 | 60 | }, |
61 | 61 | $constraints |
62 | 62 | ); |
63 | 63 | |
64 | - $dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName ); |
|
64 | + $dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName); |
|
65 | 65 | $dbw->newInsertQueryBuilder() |
66 | - ->insertInto( 'wbqc_constraints' ) |
|
67 | - ->rows( $accumulator ) |
|
68 | - ->caller( __METHOD__ ) |
|
66 | + ->insertInto('wbqc_constraints') |
|
67 | + ->rows($accumulator) |
|
68 | + ->caller(__METHOD__) |
|
69 | 69 | ->execute(); |
70 | 70 | } |
71 | 71 | |
@@ -76,14 +76,14 @@ discard block |
||
76 | 76 | * |
77 | 77 | * @throws DBUnexpectedError |
78 | 78 | */ |
79 | - public function deleteForProperty( NumericPropertyId $propertyId ) { |
|
80 | - $dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName ); |
|
79 | + public function deleteForProperty(NumericPropertyId $propertyId) { |
|
80 | + $dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName); |
|
81 | 81 | $dbw->newDeleteQueryBuilder() |
82 | - ->deleteFrom( 'wbqc_constraints' ) |
|
83 | - ->where( [ |
|
82 | + ->deleteFrom('wbqc_constraints') |
|
83 | + ->where([ |
|
84 | 84 | 'pid' => $propertyId->getNumericId(), |
85 | - ] ) |
|
86 | - ->caller( __METHOD__ ) |
|
85 | + ]) |
|
86 | + ->caller(__METHOD__) |
|
87 | 87 | ->execute(); |
88 | 88 | } |
89 | 89 |
@@ -30,53 +30,53 @@ discard block |
||
30 | 30 | use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer; |
31 | 31 | |
32 | 32 | return [ |
33 | - ConstraintsServices::EXPIRY_LOCK => static function ( MediaWikiServices $services ): ExpiryLock { |
|
34 | - return new ExpiryLock( $services->getObjectCacheFactory()->getInstance( CACHE_ANYTHING ) ); |
|
33 | + ConstraintsServices::EXPIRY_LOCK => static function(MediaWikiServices $services): ExpiryLock { |
|
34 | + return new ExpiryLock($services->getObjectCacheFactory()->getInstance(CACHE_ANYTHING)); |
|
35 | 35 | }, |
36 | 36 | |
37 | - ConstraintsServices::LOGGING_HELPER => static function ( MediaWikiServices $services ): LoggingHelper { |
|
37 | + ConstraintsServices::LOGGING_HELPER => static function(MediaWikiServices $services): LoggingHelper { |
|
38 | 38 | return new LoggingHelper( |
39 | 39 | $services->getStatsdDataFactory(), |
40 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ), |
|
40 | + LoggerFactory::getInstance('WikibaseQualityConstraints'), |
|
41 | 41 | $services->getMainConfig() |
42 | 42 | ); |
43 | 43 | }, |
44 | 44 | |
45 | - ConstraintsServices::CONSTRAINT_STORE => static function ( MediaWikiServices $services ): ConstraintRepositoryStore { |
|
46 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
47 | - $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE ); |
|
48 | - if ( $propertySource === null ) { |
|
49 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' ); |
|
45 | + ConstraintsServices::CONSTRAINT_STORE => static function(MediaWikiServices $services): ConstraintRepositoryStore { |
|
46 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
47 | + $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE); |
|
48 | + if ($propertySource === null) { |
|
49 | + throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.'); |
|
50 | 50 | } |
51 | 51 | |
52 | - $localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName(); |
|
53 | - if ( $propertySource->getSourceName() !== $localEntitySourceName ) { |
|
54 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for a non local entity source.' ); |
|
52 | + $localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName(); |
|
53 | + if ($propertySource->getSourceName() !== $localEntitySourceName) { |
|
54 | + throw new RuntimeException('Can\'t get a ConstraintStore for a non local entity source.'); |
|
55 | 55 | } |
56 | 56 | |
57 | 57 | $dbName = $propertySource->getDatabaseName(); |
58 | 58 | return new ConstraintRepositoryStore( |
59 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
59 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
60 | 60 | $dbName |
61 | 61 | ); |
62 | 62 | }, |
63 | 63 | |
64 | - ConstraintsServices::CONSTRAINT_LOOKUP => static function ( MediaWikiServices $services ): ConstraintLookup { |
|
65 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
66 | - $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE ); |
|
67 | - if ( $propertySource === null ) { |
|
68 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' ); |
|
64 | + ConstraintsServices::CONSTRAINT_LOOKUP => static function(MediaWikiServices $services): ConstraintLookup { |
|
65 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
66 | + $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE); |
|
67 | + if ($propertySource === null) { |
|
68 | + throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.'); |
|
69 | 69 | } |
70 | 70 | |
71 | 71 | $dbName = $propertySource->getDatabaseName(); |
72 | 72 | $rawLookup = new ConstraintRepositoryLookup( |
73 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
73 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
74 | 74 | $dbName |
75 | 75 | ); |
76 | - return new CachingConstraintLookup( $rawLookup ); |
|
76 | + return new CachingConstraintLookup($rawLookup); |
|
77 | 77 | }, |
78 | 78 | |
79 | - ConstraintsServices::CHECK_RESULT_SERIALIZER => static function ( MediaWikiServices $services ): CheckResultSerializer { |
|
79 | + ConstraintsServices::CHECK_RESULT_SERIALIZER => static function(MediaWikiServices $services): CheckResultSerializer { |
|
80 | 80 | return new CheckResultSerializer( |
81 | 81 | new ConstraintSerializer( |
82 | 82 | false // constraint parameters are not exposed |
@@ -87,9 +87,9 @@ discard block |
||
87 | 87 | ); |
88 | 88 | }, |
89 | 89 | |
90 | - ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function ( MediaWikiServices $services ): CheckResultDeserializer { |
|
91 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
92 | - $dataValueFactory = WikibaseRepo::getDataValueFactory( $services ); |
|
90 | + ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function(MediaWikiServices $services): CheckResultDeserializer { |
|
91 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
92 | + $dataValueFactory = WikibaseRepo::getDataValueFactory($services); |
|
93 | 93 | |
94 | 94 | return new CheckResultDeserializer( |
95 | 95 | new ConstraintDeserializer(), |
@@ -102,17 +102,17 @@ discard block |
||
102 | 102 | ); |
103 | 103 | }, |
104 | 104 | |
105 | - ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function ( |
|
105 | + ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function( |
|
106 | 106 | MediaWikiServices $services |
107 | 107 | ): ViolationMessageSerializer { |
108 | 108 | return new ViolationMessageSerializer(); |
109 | 109 | }, |
110 | 110 | |
111 | - ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function ( |
|
111 | + ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function( |
|
112 | 112 | MediaWikiServices $services |
113 | 113 | ): ViolationMessageDeserializer { |
114 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
115 | - $dataValueFactory = WikibaseRepo::getDataValueFactory( $services ); |
|
114 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
115 | + $dataValueFactory = WikibaseRepo::getDataValueFactory($services); |
|
116 | 116 | |
117 | 117 | return new ViolationMessageDeserializer( |
118 | 118 | $entityIdParser, |
@@ -120,39 +120,39 @@ discard block |
||
120 | 120 | ); |
121 | 121 | }, |
122 | 122 | |
123 | - ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function ( |
|
123 | + ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function( |
|
124 | 124 | MediaWikiServices $services |
125 | 125 | ): ConstraintParameterParser { |
126 | - $deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory( $services ); |
|
127 | - $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
126 | + $deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory($services); |
|
127 | + $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
128 | 128 | |
129 | 129 | return new ConstraintParameterParser( |
130 | 130 | $services->getMainConfig(), |
131 | 131 | $deserializerFactory, |
132 | - $entitySourceDefinitions->getDatabaseSourceForEntityType( 'item' )->getConceptBaseUri() |
|
132 | + $entitySourceDefinitions->getDatabaseSourceForEntityType('item')->getConceptBaseUri() |
|
133 | 133 | ); |
134 | 134 | }, |
135 | 135 | |
136 | - ConstraintsServices::CONNECTION_CHECKER_HELPER => static function ( MediaWikiServices $services ): ConnectionCheckerHelper { |
|
136 | + ConstraintsServices::CONNECTION_CHECKER_HELPER => static function(MediaWikiServices $services): ConnectionCheckerHelper { |
|
137 | 137 | return new ConnectionCheckerHelper(); |
138 | 138 | }, |
139 | 139 | |
140 | - ConstraintsServices::RANGE_CHECKER_HELPER => static function ( MediaWikiServices $services ): RangeCheckerHelper { |
|
140 | + ConstraintsServices::RANGE_CHECKER_HELPER => static function(MediaWikiServices $services): RangeCheckerHelper { |
|
141 | 141 | return new RangeCheckerHelper( |
142 | 142 | $services->getMainConfig(), |
143 | - WikibaseRepo::getUnitConverter( $services ) |
|
143 | + WikibaseRepo::getUnitConverter($services) |
|
144 | 144 | ); |
145 | 145 | }, |
146 | 146 | |
147 | - ConstraintsServices::SPARQL_HELPER => static function ( MediaWikiServices $services ): SparqlHelper { |
|
148 | - $endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
149 | - if ( $endpoint === '' ) { |
|
147 | + ConstraintsServices::SPARQL_HELPER => static function(MediaWikiServices $services): SparqlHelper { |
|
148 | + $endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint'); |
|
149 | + if ($endpoint === '') { |
|
150 | 150 | return new DummySparqlHelper(); |
151 | 151 | } |
152 | 152 | |
153 | - $rdfVocabulary = WikibaseRepo::getRdfVocabulary( $services ); |
|
154 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
155 | - $propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup( $services ); |
|
153 | + $rdfVocabulary = WikibaseRepo::getRdfVocabulary($services); |
|
154 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
155 | + $propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup($services); |
|
156 | 156 | |
157 | 157 | return new SparqlHelper( |
158 | 158 | $services->getMainConfig(), |
@@ -160,128 +160,128 @@ discard block |
||
160 | 160 | $entityIdParser, |
161 | 161 | $propertyDataTypeLookup, |
162 | 162 | $services->getMainWANObjectCache(), |
163 | - ConstraintsServices::getViolationMessageSerializer( $services ), |
|
164 | - ConstraintsServices::getViolationMessageDeserializer( $services ), |
|
163 | + ConstraintsServices::getViolationMessageSerializer($services), |
|
164 | + ConstraintsServices::getViolationMessageDeserializer($services), |
|
165 | 165 | $services->getStatsdDataFactory(), |
166 | - ConstraintsServices::getExpiryLock( $services ), |
|
167 | - ConstraintsServices::getLoggingHelper( $services ), |
|
168 | - WikiMap::getCurrentWikiId() . ' WikibaseQualityConstraints ' . $services->getHttpRequestFactory()->getUserAgent(), |
|
166 | + ConstraintsServices::getExpiryLock($services), |
|
167 | + ConstraintsServices::getLoggingHelper($services), |
|
168 | + WikiMap::getCurrentWikiId().' WikibaseQualityConstraints '.$services->getHttpRequestFactory()->getUserAgent(), |
|
169 | 169 | $services->getHttpRequestFactory() |
170 | 170 | ); |
171 | 171 | }, |
172 | 172 | |
173 | - ConstraintsServices::TYPE_CHECKER_HELPER => static function ( MediaWikiServices $services ): TypeCheckerHelper { |
|
173 | + ConstraintsServices::TYPE_CHECKER_HELPER => static function(MediaWikiServices $services): TypeCheckerHelper { |
|
174 | 174 | return new TypeCheckerHelper( |
175 | - WikibaseServices::getEntityLookup( $services ), |
|
175 | + WikibaseServices::getEntityLookup($services), |
|
176 | 176 | $services->getMainConfig(), |
177 | - ConstraintsServices::getSparqlHelper( $services ), |
|
178 | - $services->getStatsFactory()->withComponent( 'WikibaseQualityConstraints' ) |
|
177 | + ConstraintsServices::getSparqlHelper($services), |
|
178 | + $services->getStatsFactory()->withComponent('WikibaseQualityConstraints') |
|
179 | 179 | ); |
180 | 180 | }, |
181 | 181 | |
182 | - ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function ( |
|
182 | + ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function( |
|
183 | 183 | MediaWikiServices $services |
184 | 184 | ): DelegatingConstraintChecker { |
185 | - $statementGuidParser = WikibaseRepo::getStatementGuidParser( $services ); |
|
185 | + $statementGuidParser = WikibaseRepo::getStatementGuidParser($services); |
|
186 | 186 | |
187 | 187 | $config = $services->getMainConfig(); |
188 | 188 | $checkerMap = [ |
189 | - $config->get( 'WBQualityConstraintsConflictsWithConstraintId' ) |
|
190 | - => ConstraintCheckerServices::getConflictsWithChecker( $services ), |
|
191 | - $config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' ) |
|
192 | - => ConstraintCheckerServices::getItemChecker( $services ), |
|
193 | - $config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' ) |
|
194 | - => ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ), |
|
195 | - $config->get( 'WBQualityConstraintsSymmetricConstraintId' ) |
|
196 | - => ConstraintCheckerServices::getSymmetricChecker( $services ), |
|
197 | - $config->get( 'WBQualityConstraintsInverseConstraintId' ) |
|
198 | - => ConstraintCheckerServices::getInverseChecker( $services ), |
|
199 | - $config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' ) |
|
200 | - => ConstraintCheckerServices::getQualifierChecker( $services ), |
|
201 | - $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' ) |
|
202 | - => ConstraintCheckerServices::getQualifiersChecker( $services ), |
|
203 | - $config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' ) |
|
204 | - => ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ), |
|
205 | - $config->get( 'WBQualityConstraintsRangeConstraintId' ) |
|
206 | - => ConstraintCheckerServices::getRangeChecker( $services ), |
|
207 | - $config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' ) |
|
208 | - => ConstraintCheckerServices::getDiffWithinRangeChecker( $services ), |
|
209 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ) |
|
210 | - => ConstraintCheckerServices::getTypeChecker( $services ), |
|
211 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ) |
|
212 | - => ConstraintCheckerServices::getValueTypeChecker( $services ), |
|
213 | - $config->get( 'WBQualityConstraintsSingleValueConstraintId' ) |
|
214 | - => ConstraintCheckerServices::getSingleValueChecker( $services ), |
|
215 | - $config->get( 'WBQualityConstraintsMultiValueConstraintId' ) |
|
216 | - => ConstraintCheckerServices::getMultiValueChecker( $services ), |
|
217 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ) |
|
218 | - => ConstraintCheckerServices::getUniqueValueChecker( $services ), |
|
219 | - $config->get( 'WBQualityConstraintsFormatConstraintId' ) |
|
220 | - => ConstraintCheckerServices::getFormatChecker( $services ), |
|
221 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ) |
|
222 | - => ConstraintCheckerServices::getCommonsLinkChecker( $services ), |
|
223 | - $config->get( 'WBQualityConstraintsOneOfConstraintId' ) |
|
224 | - => ConstraintCheckerServices::getOneOfChecker( $services ), |
|
225 | - $config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' ) |
|
226 | - => ConstraintCheckerServices::getValueOnlyChecker( $services ), |
|
227 | - $config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' ) |
|
228 | - => ConstraintCheckerServices::getReferenceChecker( $services ), |
|
229 | - $config->get( 'WBQualityConstraintsNoBoundsConstraintId' ) |
|
230 | - => ConstraintCheckerServices::getNoBoundsChecker( $services ), |
|
231 | - $config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' ) |
|
232 | - => ConstraintCheckerServices::getAllowedUnitsChecker( $services ), |
|
233 | - $config->get( 'WBQualityConstraintsSingleBestValueConstraintId' ) |
|
234 | - => ConstraintCheckerServices::getSingleBestValueChecker( $services ), |
|
235 | - $config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' ) |
|
236 | - => ConstraintCheckerServices::getEntityTypeChecker( $services ), |
|
237 | - $config->get( 'WBQualityConstraintsNoneOfConstraintId' ) |
|
238 | - => ConstraintCheckerServices::getNoneOfChecker( $services ), |
|
239 | - $config->get( 'WBQualityConstraintsIntegerConstraintId' ) |
|
240 | - => ConstraintCheckerServices::getIntegerChecker( $services ), |
|
241 | - $config->get( 'WBQualityConstraintsCitationNeededConstraintId' ) |
|
242 | - => ConstraintCheckerServices::getCitationNeededChecker( $services ), |
|
243 | - $config->get( 'WBQualityConstraintsPropertyScopeConstraintId' ) |
|
244 | - => ConstraintCheckerServices::getPropertyScopeChecker( $services ), |
|
245 | - $config->get( 'WBQualityConstraintsContemporaryConstraintId' ) |
|
246 | - => ConstraintCheckerServices::getContemporaryChecker( $services ), |
|
247 | - $config->get( 'WBQualityConstraintsLexemeLanguageConstraintId' ) |
|
248 | - => ConstraintCheckerServices::getLexemeLanguageChecker( $services ), |
|
249 | - $config->get( 'WBQualityConstraintsLabelInLanguageConstraintId' ) |
|
250 | - => ConstraintCheckerServices::getLabelInLanguageChecker( $services ), |
|
189 | + $config->get('WBQualityConstraintsConflictsWithConstraintId') |
|
190 | + => ConstraintCheckerServices::getConflictsWithChecker($services), |
|
191 | + $config->get('WBQualityConstraintsItemRequiresClaimConstraintId') |
|
192 | + => ConstraintCheckerServices::getItemChecker($services), |
|
193 | + $config->get('WBQualityConstraintsValueRequiresClaimConstraintId') |
|
194 | + => ConstraintCheckerServices::getTargetRequiredClaimChecker($services), |
|
195 | + $config->get('WBQualityConstraintsSymmetricConstraintId') |
|
196 | + => ConstraintCheckerServices::getSymmetricChecker($services), |
|
197 | + $config->get('WBQualityConstraintsInverseConstraintId') |
|
198 | + => ConstraintCheckerServices::getInverseChecker($services), |
|
199 | + $config->get('WBQualityConstraintsUsedAsQualifierConstraintId') |
|
200 | + => ConstraintCheckerServices::getQualifierChecker($services), |
|
201 | + $config->get('WBQualityConstraintsAllowedQualifiersConstraintId') |
|
202 | + => ConstraintCheckerServices::getQualifiersChecker($services), |
|
203 | + $config->get('WBQualityConstraintsMandatoryQualifierConstraintId') |
|
204 | + => ConstraintCheckerServices::getMandatoryQualifiersChecker($services), |
|
205 | + $config->get('WBQualityConstraintsRangeConstraintId') |
|
206 | + => ConstraintCheckerServices::getRangeChecker($services), |
|
207 | + $config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId') |
|
208 | + => ConstraintCheckerServices::getDiffWithinRangeChecker($services), |
|
209 | + $config->get('WBQualityConstraintsTypeConstraintId') |
|
210 | + => ConstraintCheckerServices::getTypeChecker($services), |
|
211 | + $config->get('WBQualityConstraintsValueTypeConstraintId') |
|
212 | + => ConstraintCheckerServices::getValueTypeChecker($services), |
|
213 | + $config->get('WBQualityConstraintsSingleValueConstraintId') |
|
214 | + => ConstraintCheckerServices::getSingleValueChecker($services), |
|
215 | + $config->get('WBQualityConstraintsMultiValueConstraintId') |
|
216 | + => ConstraintCheckerServices::getMultiValueChecker($services), |
|
217 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId') |
|
218 | + => ConstraintCheckerServices::getUniqueValueChecker($services), |
|
219 | + $config->get('WBQualityConstraintsFormatConstraintId') |
|
220 | + => ConstraintCheckerServices::getFormatChecker($services), |
|
221 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId') |
|
222 | + => ConstraintCheckerServices::getCommonsLinkChecker($services), |
|
223 | + $config->get('WBQualityConstraintsOneOfConstraintId') |
|
224 | + => ConstraintCheckerServices::getOneOfChecker($services), |
|
225 | + $config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId') |
|
226 | + => ConstraintCheckerServices::getValueOnlyChecker($services), |
|
227 | + $config->get('WBQualityConstraintsUsedAsReferenceConstraintId') |
|
228 | + => ConstraintCheckerServices::getReferenceChecker($services), |
|
229 | + $config->get('WBQualityConstraintsNoBoundsConstraintId') |
|
230 | + => ConstraintCheckerServices::getNoBoundsChecker($services), |
|
231 | + $config->get('WBQualityConstraintsAllowedUnitsConstraintId') |
|
232 | + => ConstraintCheckerServices::getAllowedUnitsChecker($services), |
|
233 | + $config->get('WBQualityConstraintsSingleBestValueConstraintId') |
|
234 | + => ConstraintCheckerServices::getSingleBestValueChecker($services), |
|
235 | + $config->get('WBQualityConstraintsAllowedEntityTypesConstraintId') |
|
236 | + => ConstraintCheckerServices::getEntityTypeChecker($services), |
|
237 | + $config->get('WBQualityConstraintsNoneOfConstraintId') |
|
238 | + => ConstraintCheckerServices::getNoneOfChecker($services), |
|
239 | + $config->get('WBQualityConstraintsIntegerConstraintId') |
|
240 | + => ConstraintCheckerServices::getIntegerChecker($services), |
|
241 | + $config->get('WBQualityConstraintsCitationNeededConstraintId') |
|
242 | + => ConstraintCheckerServices::getCitationNeededChecker($services), |
|
243 | + $config->get('WBQualityConstraintsPropertyScopeConstraintId') |
|
244 | + => ConstraintCheckerServices::getPropertyScopeChecker($services), |
|
245 | + $config->get('WBQualityConstraintsContemporaryConstraintId') |
|
246 | + => ConstraintCheckerServices::getContemporaryChecker($services), |
|
247 | + $config->get('WBQualityConstraintsLexemeLanguageConstraintId') |
|
248 | + => ConstraintCheckerServices::getLexemeLanguageChecker($services), |
|
249 | + $config->get('WBQualityConstraintsLabelInLanguageConstraintId') |
|
250 | + => ConstraintCheckerServices::getLabelInLanguageChecker($services), |
|
251 | 251 | ]; |
252 | 252 | |
253 | 253 | return new DelegatingConstraintChecker( |
254 | - WikibaseServices::getEntityLookup( $services ), |
|
254 | + WikibaseServices::getEntityLookup($services), |
|
255 | 255 | $checkerMap, |
256 | - ConstraintsServices::getConstraintLookup( $services ), |
|
257 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
256 | + ConstraintsServices::getConstraintLookup($services), |
|
257 | + ConstraintsServices::getConstraintParameterParser($services), |
|
258 | 258 | $statementGuidParser, |
259 | - ConstraintsServices::getLoggingHelper( $services ), |
|
260 | - $config->get( 'WBQualityConstraintsCheckQualifiers' ), |
|
261 | - $config->get( 'WBQualityConstraintsCheckReferences' ), |
|
262 | - $config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' ) |
|
259 | + ConstraintsServices::getLoggingHelper($services), |
|
260 | + $config->get('WBQualityConstraintsCheckQualifiers'), |
|
261 | + $config->get('WBQualityConstraintsCheckReferences'), |
|
262 | + $config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers') |
|
263 | 263 | ); |
264 | 264 | }, |
265 | 265 | |
266 | - ConstraintsServices::RESULTS_SOURCE => static function ( MediaWikiServices $services ): ResultsSource { |
|
266 | + ConstraintsServices::RESULTS_SOURCE => static function(MediaWikiServices $services): ResultsSource { |
|
267 | 267 | $config = $services->getMainConfig(); |
268 | 268 | $resultsSource = new CheckingResultsSource( |
269 | - ConstraintsServices::getDelegatingConstraintChecker( $services ) |
|
269 | + ConstraintsServices::getDelegatingConstraintChecker($services) |
|
270 | 270 | ); |
271 | 271 | |
272 | 272 | $cacheCheckConstraintsResults = false; |
273 | 273 | |
274 | - if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) { |
|
274 | + if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) { |
|
275 | 275 | $cacheCheckConstraintsResults = true; |
276 | 276 | // check that we can use getLocalRepoWikiPageMetaDataAccessor() |
277 | 277 | // TODO we should always be able to cache constraint check results (T244726) |
278 | - $entitySources = WikibaseRepo::getEntitySourceDefinitions( $services )->getSources(); |
|
279 | - $localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName(); |
|
278 | + $entitySources = WikibaseRepo::getEntitySourceDefinitions($services)->getSources(); |
|
279 | + $localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName(); |
|
280 | 280 | |
281 | - foreach ( $entitySources as $entitySource ) { |
|
282 | - if ( $entitySource->getSourceName() !== $localEntitySourceName ) { |
|
283 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' )->warning( |
|
284 | - 'Cannot cache constraint check results for non-local source: ' . |
|
281 | + foreach ($entitySources as $entitySource) { |
|
282 | + if ($entitySource->getSourceName() !== $localEntitySourceName) { |
|
283 | + LoggerFactory::getInstance('WikibaseQualityConstraints')->warning( |
|
284 | + 'Cannot cache constraint check results for non-local source: '. |
|
285 | 285 | $entitySource->getSourceName() |
286 | 286 | ); |
287 | 287 | $cacheCheckConstraintsResults = false; |
@@ -290,42 +290,42 @@ discard block |
||
290 | 290 | } |
291 | 291 | } |
292 | 292 | |
293 | - if ( $cacheCheckConstraintsResults ) { |
|
293 | + if ($cacheCheckConstraintsResults) { |
|
294 | 294 | $possiblyStaleConstraintTypes = [ |
295 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ), |
|
296 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ), |
|
297 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ), |
|
298 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ), |
|
295 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId'), |
|
296 | + $config->get('WBQualityConstraintsTypeConstraintId'), |
|
297 | + $config->get('WBQualityConstraintsValueTypeConstraintId'), |
|
298 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId'), |
|
299 | 299 | ]; |
300 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
300 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
301 | 301 | $wikiPageEntityMetaDataAccessor = WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor( |
302 | 302 | $services ); |
303 | 303 | |
304 | 304 | $resultsSource = new CachingResultsSource( |
305 | 305 | $resultsSource, |
306 | 306 | ResultsCache::getDefaultInstance(), |
307 | - ConstraintsServices::getCheckResultSerializer( $services ), |
|
308 | - ConstraintsServices::getCheckResultDeserializer( $services ), |
|
307 | + ConstraintsServices::getCheckResultSerializer($services), |
|
308 | + ConstraintsServices::getCheckResultDeserializer($services), |
|
309 | 309 | $wikiPageEntityMetaDataAccessor, |
310 | 310 | $entityIdParser, |
311 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ), |
|
311 | + $config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'), |
|
312 | 312 | $possiblyStaleConstraintTypes, |
313 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ), |
|
314 | - ConstraintsServices::getLoggingHelper( $services ) |
|
313 | + $config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'), |
|
314 | + ConstraintsServices::getLoggingHelper($services) |
|
315 | 315 | ); |
316 | 316 | } |
317 | 317 | |
318 | 318 | return $resultsSource; |
319 | 319 | }, |
320 | 320 | |
321 | - ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function ( |
|
321 | + ConstraintsServices::VIOLATION_MESSAGE_RENDERER_FACTORY => static function( |
|
322 | 322 | MediaWikiServices $services |
323 | 323 | ): ViolationMessageRendererFactory { |
324 | 324 | return new ViolationMessageRendererFactory( |
325 | 325 | $services->getMainConfig(), |
326 | 326 | $services->getLanguageNameUtils(), |
327 | - WikibaseRepo::getEntityIdHtmlLinkFormatterFactory( $services ), |
|
328 | - WikibaseRepo::getValueFormatterFactory( $services ) |
|
327 | + WikibaseRepo::getEntityIdHtmlLinkFormatterFactory($services), |
|
328 | + WikibaseRepo::getValueFormatterFactory($services) |
|
329 | 329 | ); |
330 | 330 | }, |
331 | 331 | ]; |