Completed
Push — master ( 15f106...b12154 )
by
unknown
02:36
created
src/ConstraintCheck/Checker/MultiValueChecker.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@  discard block
 block discarded – undo
55 55
 	 *
56 56
 	 * @return CheckResult
57 57
 	 */
58
-	public function checkConstraint( Context $context, Constraint $constraint ) {
59
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
60
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
58
+	public function checkConstraint(Context $context, Constraint $constraint) {
59
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
60
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
61 61
 		}
62 62
 
63 63
 		$propertyId = $context->getSnak()->getPropertyId();
@@ -69,18 +69,18 @@  discard block
 block discarded – undo
69 69
 			$propertyId
70 70
 		);
71 71
 
72
-		if ( $propertyCount <= 1 ) {
73
-			$message = new ViolationMessage( 'wbqc-violation-message-multi-value' );
72
+		if ($propertyCount <= 1) {
73
+			$message = new ViolationMessage('wbqc-violation-message-multi-value');
74 74
 			$status = CheckResult::STATUS_VIOLATION;
75 75
 		} else {
76 76
 			$message = null;
77 77
 			$status = CheckResult::STATUS_COMPLIANCE;
78 78
 		}
79 79
 
80
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
80
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
81 81
 	}
82 82
 
83
-	public function checkConstraintParameters( Constraint $constraint ) {
83
+	public function checkConstraintParameters(Constraint $constraint) {
84 84
 		// no parameters
85 85
 		return [];
86 86
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ValueOnlyChecker.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -36,16 +36,16 @@
 block discarded – undo
36 36
 		];
37 37
 	}
38 38
 
39
-	public function checkConstraint( Context $context, Constraint $constraint ) {
40
-		if ( $context->getType() === Context::TYPE_STATEMENT ) {
41
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
39
+	public function checkConstraint(Context $context, Constraint $constraint) {
40
+		if ($context->getType() === Context::TYPE_STATEMENT) {
41
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
42 42
 		} else {
43
-			$message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
44
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
43
+			$message = new ViolationMessage('wbqc-violation-message-valueOnly');
44
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
45 45
 		}
46 46
 	}
47 47
 
48
-	public function checkConstraintParameters( Constraint $constraint ) {
48
+	public function checkConstraintParameters(Constraint $constraint) {
49 49
 		// no parameters
50 50
 		return [];
51 51
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -36,16 +36,16 @@
 block discarded – undo
36 36
 		];
37 37
 	}
38 38
 
39
-	public function checkConstraint( Context $context, Constraint $constraint ) {
40
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
41
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
39
+	public function checkConstraint(Context $context, Constraint $constraint) {
40
+		if ($context->getType() === Context::TYPE_REFERENCE) {
41
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
42 42
 		} else {
43
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
44
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
43
+			$message = new ViolationMessage('wbqc-violation-message-reference');
44
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
45 45
 		}
46 46
 	}
47 47
 
48
-	public function checkConstraintParameters( Constraint $constraint ) {
48
+	public function checkConstraintParameters(Constraint $constraint) {
49 49
 		// no parameters
50 50
 		return [];
51 51
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@  discard block
 block discarded – undo
55 55
 	 *
56 56
 	 * @return CheckResult
57 57
 	 */
58
-	public function checkConstraint( Context $context, Constraint $constraint ) {
59
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
60
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
58
+	public function checkConstraint(Context $context, Constraint $constraint) {
59
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
60
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
61 61
 		}
62 62
 
63 63
 		$propertyId = $context->getSnak()->getPropertyId();
@@ -69,18 +69,18 @@  discard block
 block discarded – undo
69 69
 			$propertyId
70 70
 		);
71 71
 
72
-		if ( $propertyCount > 1 ) {
73
-			$message = new ViolationMessage( 'wbqc-violation-message-single-value' );
72
+		if ($propertyCount > 1) {
73
+			$message = new ViolationMessage('wbqc-violation-message-single-value');
74 74
 			$status = CheckResult::STATUS_VIOLATION;
75 75
 		} else {
76 76
 			$message = null;
77 77
 			$status = CheckResult::STATUS_COMPLIANCE;
78 78
 		}
79 79
 
80
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
80
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
81 81
 	}
82 82
 
83
-	public function checkConstraintParameters( Constraint $constraint ) {
83
+	public function checkConstraintParameters(Constraint $constraint) {
84 84
 		// no parameters
85 85
 		return [];
86 86
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -71,40 +71,40 @@
 block discarded – undo
71 71
 	 * @throws ConstraintParameterException
72 72
 	 * @return CheckResult
73 73
 	 */
74
-	public function checkConstraint( Context $context, Constraint $constraint ) {
75
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
74
+	public function checkConstraint(Context $context, Constraint $constraint) {
75
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
76
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77 77
 		}
78 78
 
79 79
 		$parameters = [];
80 80
 		$constraintParameters = $constraint->getConstraintParameters();
81 81
 
82
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
83
-		$parameters['property'] = [ $propertyId ];
82
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
83
+		$parameters['property'] = [$propertyId];
84 84
 
85
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
86
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
87
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
85
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
86
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
87
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
88 88
 		$status = CheckResult::STATUS_VIOLATION;
89 89
 
90 90
 		/** @var Snak $qualifier */
91
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
92
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
91
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
92
+			if ($propertyId->equals($qualifier->getPropertyId())) {
93 93
 				$message = null;
94 94
 				$status = CheckResult::STATUS_COMPLIANCE;
95 95
 				break;
96 96
 			}
97 97
 		}
98 98
 
99
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
99
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
100 100
 	}
101 101
 
102
-	public function checkConstraintParameters( Constraint $constraint ) {
102
+	public function checkConstraintParameters(Constraint $constraint) {
103 103
 		$constraintParameters = $constraint->getConstraintParameters();
104 104
 		$exceptions = [];
105 105
 		try {
106
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
107
-		} catch ( ConstraintParameterException $e ) {
106
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
107
+		} catch (ConstraintParameterException $e) {
108 108
 			$exceptions[] = $e;
109 109
 		}
110 110
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -71,53 +71,53 @@
 block discarded – undo
71 71
 	 * @throws ConstraintParameterException
72 72
 	 * @return CheckResult
73 73
 	 */
74
-	public function checkConstraint( Context $context, Constraint $constraint ) {
75
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
74
+	public function checkConstraint(Context $context, Constraint $constraint) {
75
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
76
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77 77
 		}
78 78
 
79 79
 		$parameters = [];
80 80
 		$constraintParameters = $constraint->getConstraintParameters();
81 81
 
82
-		$properties = $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
82
+		$properties = $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
83 83
 		$parameters['property'] = $properties;
84 84
 
85 85
 		$message = null;
86 86
 		$status = CheckResult::STATUS_COMPLIANCE;
87 87
 
88 88
 		/** @var Snak $qualifier */
89
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
89
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
90 90
 			$allowedQualifier = false;
91
-			foreach ( $properties as $property ) {
92
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
91
+			foreach ($properties as $property) {
92
+				if ($qualifier->getPropertyId()->equals($property)) {
93 93
 					$allowedQualifier = true;
94 94
 					break;
95 95
 				}
96 96
 			}
97
-			if ( !$allowedQualifier ) {
98
-				if ( empty( $properties ) || $properties === [ '' ] ) {
99
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
100
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
97
+			if (!$allowedQualifier) {
98
+				if (empty($properties) || $properties === ['']) {
99
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
100
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
101 101
 				} else {
102
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
103
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
104
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
105
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
102
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
103
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
104
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
105
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
106 106
 				}
107 107
 				$status = CheckResult::STATUS_VIOLATION;
108 108
 				break;
109 109
 			}
110 110
 		}
111 111
 
112
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
112
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
113 113
 	}
114 114
 
115
-	public function checkConstraintParameters( Constraint $constraint ) {
115
+	public function checkConstraintParameters(Constraint $constraint) {
116 116
 		$constraintParameters = $constraint->getConstraintParameters();
117 117
 		$exceptions = [];
118 118
 		try {
119
-			$this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
120
-		} catch ( ConstraintParameterException $e ) {
119
+			$this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
120
+		} catch (ConstraintParameterException $e) {
121 121
 			$exceptions[] = $e;
122 122
 		}
123 123
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/UniqueValueChecker.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -74,22 +74,22 @@  discard block
 block discarded – undo
74 74
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
75 75
 	 * @return CheckResult
76 76
 	 */
77
-	public function checkConstraint( Context $context, Constraint $constraint ) {
78
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
79
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
77
+	public function checkConstraint(Context $context, Constraint $constraint) {
78
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
79
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
80 80
 		}
81 81
 
82 82
 		$parameters = [];
83 83
 
84
-		if ( $this->sparqlHelper !== null ) {
85
-			if ( $context->getType() === 'statement' ) {
84
+		if ($this->sparqlHelper !== null) {
85
+			if ($context->getType() === 'statement') {
86 86
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
87 87
 					$context->getSnakStatement(),
88 88
 					true // ignore deprecated statements
89 89
 				);
90 90
 			} else {
91
-				if ( $context->getSnak()->getType() !== 'value' ) {
92
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
91
+				if ($context->getSnak()->getType() !== 'value') {
92
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
93 93
 				}
94 94
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
95 95
 					$context->getEntity()->getId(),
@@ -102,27 +102,27 @@  discard block
 block discarded – undo
102 102
 			$otherEntities = $result->getArray();
103 103
 			$metadata = $result->getMetadata();
104 104
 
105
-			if ( $otherEntities === [] ) {
105
+			if ($otherEntities === []) {
106 106
 				$status = CheckResult::STATUS_COMPLIANCE;
107 107
 				$message = null;
108 108
 			} else {
109
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
109
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
110 110
 				$status = CheckResult::STATUS_VIOLATION;
111
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
112
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
111
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
112
+					->withEntityIdList($otherEntities, Role::SUBJECT);
113 113
 			}
114 114
 		} else {
115 115
 			$status = CheckResult::STATUS_TODO;
116
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
117
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
116
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
117
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
118 118
 			$metadata = Metadata::blank();
119 119
 		}
120 120
 
121
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
122
-			->withMetadata( $metadata );
121
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
122
+			->withMetadata($metadata);
123 123
 	}
124 124
 
125
-	public function checkConstraintParameters( Constraint $constraint ) {
125
+	public function checkConstraintParameters(Constraint $constraint) {
126 126
 		// no parameters
127 127
 		return [];
128 128
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -87,18 +87,18 @@  discard block
 block discarded – undo
87 87
 	 * @throws ConstraintParameterException
88 88
 	 * @return CheckResult
89 89
 	 */
90
-	public function checkConstraint( Context $context, Constraint $constraint ) {
91
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
92
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
90
+	public function checkConstraint(Context $context, Constraint $constraint) {
91
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
92
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
93 93
 		}
94 94
 
95 95
 		$parameters = [];
96 96
 		$constraintParameters = $constraint->getConstraintParameters();
97 97
 
98
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
99
-		$parameters['property'] = [ $propertyId ];
98
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
99
+		$parameters['property'] = [$propertyId];
100 100
 
101
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
101
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
102 102
 		$parameters['items'] = $items;
103 103
 
104 104
 		/*
@@ -106,15 +106,15 @@  discard block
 block discarded – undo
106 106
 		 *   a) a property only
107 107
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
108 108
 		 */
109
-		if ( $items === [] ) {
109
+		if ($items === []) {
110 110
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
111 111
 				$context->getEntity()->getStatements(),
112 112
 				$propertyId
113 113
 			);
114
-			if ( $offendingStatement !== null ) {
115
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
116
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
117
-					->withEntityId( $propertyId, Role::PREDICATE );
114
+			if ($offendingStatement !== null) {
115
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
116
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
117
+					->withEntityId($propertyId, Role::PREDICATE);
118 118
 				$status = CheckResult::STATUS_VIOLATION;
119 119
 			} else {
120 120
 				$message = null;
@@ -126,12 +126,12 @@  discard block
 block discarded – undo
126 126
 				$propertyId,
127 127
 				$items
128 128
 			);
129
-			if ( $offendingStatement !== null ) {
130
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
131
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
132
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
133
-					->withEntityId( $propertyId, Role::PREDICATE )
134
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
129
+			if ($offendingStatement !== null) {
130
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
131
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
132
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
133
+					->withEntityId($propertyId, Role::PREDICATE)
134
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
135 135
 				$status = CheckResult::STATUS_VIOLATION;
136 136
 			} else {
137 137
 				$message = null;
@@ -139,20 +139,20 @@  discard block
 block discarded – undo
139 139
 			}
140 140
 		}
141 141
 
142
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
142
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
143 143
 	}
144 144
 
145
-	public function checkConstraintParameters( Constraint $constraint ) {
145
+	public function checkConstraintParameters(Constraint $constraint) {
146 146
 		$constraintParameters = $constraint->getConstraintParameters();
147 147
 		$exceptions = [];
148 148
 		try {
149
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
150
-		} catch ( ConstraintParameterException $e ) {
149
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
150
+		} catch (ConstraintParameterException $e) {
151 151
 			$exceptions[] = $e;
152 152
 		}
153 153
 		try {
154
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
155
-		} catch ( ConstraintParameterException $e ) {
154
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
155
+		} catch (ConstraintParameterException $e) {
156 156
 			$exceptions[] = $e;
157 157
 		}
158 158
 		return $exceptions;
Please login to merge, or discard this patch.
src/WikibaseQualityConstraintsHooks.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -28,35 +28,35 @@  discard block
 block discarded – undo
28 28
 	/**
29 29
 	 * @param DatabaseUpdater $updater
30 30
 	 */
31
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
32
-		$updater->addExtensionTable( 'wbqc_constraints', __DIR__ . '/../sql/create_wbqc_constraints.sql' );
31
+	public static function onCreateSchema(DatabaseUpdater $updater) {
32
+		$updater->addExtensionTable('wbqc_constraints', __DIR__.'/../sql/create_wbqc_constraints.sql');
33 33
 	}
34 34
 
35
-	public static function onWikibaseChange( Change $change ) {
35
+	public static function onWikibaseChange(Change $change) {
36 36
 		$config = MediaWikiServices::getInstance()->getMainConfig();
37
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
38
-			self::isConstraintStatementsChange( $config, $change )
37
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
38
+			self::isConstraintStatementsChange($config, $change)
39 39
 		) {
40 40
 			/** @var EntityChange $change */
41 41
 			$title = Title::newMainPage();
42
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
42
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
43 43
 			JobQueueGroup::singleton()->push(
44
-				new JobSpecification( 'constraintsTableUpdate', $params, [], $title )
44
+				new JobSpecification('constraintsTableUpdate', $params, [], $title)
45 45
 			);
46 46
 		}
47 47
 	}
48 48
 
49
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
50
-		if ( !( $change instanceof EntityChange ) ||
49
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
50
+		if (!($change instanceof EntityChange) ||
51 51
 			 $change->getAction() !== EntityChange::UPDATE ||
52
-			 !( $change->getEntityId() instanceof PropertyId )
52
+			 !($change->getEntityId() instanceof PropertyId)
53 53
 		) {
54 54
 			return false;
55 55
 		}
56 56
 
57 57
 		$info = $change->getInfo();
58 58
 
59
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
59
+		if (!array_key_exists('compactDiff', $info)) {
60 60
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
61 61
 			// so we only know that the change *might* affect the constraint statements
62 62
 			return true;
@@ -65,18 +65,18 @@  discard block
 block discarded – undo
65 65
 		/** @var EntityDiffChangedAspects $aspects */
66 66
 		$aspects = $info['compactDiff'];
67 67
 
68
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
69
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
68
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
69
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
70 70
 	}
71 71
 
72
-	public static function onArticlePurge( WikiPage $wikiPage ) {
72
+	public static function onArticlePurge(WikiPage $wikiPage) {
73 73
 		$repo = WikibaseRepo::getDefaultInstance();
74 74
 
75 75
 		$entityContentFactory = $repo->getEntityContentFactory();
76
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
77
-			$entityId = $entityContentFactory->getEntityIdForTitle( $wikiPage->getTitle() );
76
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
77
+			$entityId = $entityContentFactory->getEntityIdForTitle($wikiPage->getTitle());
78 78
 			$resultsCache = ResultsCache::getDefaultInstance();
79
-			$resultsCache->delete( $entityId );
79
+			$resultsCache->delete($entityId);
80 80
 		}
81 81
 	}
82 82
 
@@ -85,18 +85,18 @@  discard block
 block discarded – undo
85 85
 	 * @param int $timestamp UTC timestamp (seconds since the Epoch)
86 86
 	 * @return bool
87 87
 	 */
88
-	public static function isGadgetEnabledForUserName( $userName, $timestamp ) {
88
+	public static function isGadgetEnabledForUserName($userName, $timestamp) {
89 89
 		$initial = $userName[0];
90 90
 
91
-		if ( $initial === 'Z' ) {
91
+		if ($initial === 'Z') {
92 92
 			$firstWeek = 0;
93
-		} elseif ( $initial >= 'W' && $initial < 'Z' ) {
93
+		} elseif ($initial >= 'W' && $initial < 'Z') {
94 94
 			$firstWeek = 1;
95
-		} elseif ( $initial >= 'T' && $initial < 'W' ) {
95
+		} elseif ($initial >= 'T' && $initial < 'W') {
96 96
 			$firstWeek = 2;
97
-		} elseif ( $initial >= 'N' && $initial < 'T' ) {
97
+		} elseif ($initial >= 'N' && $initial < 'T') {
98 98
 			$firstWeek = 3;
99
-		} elseif ( $initial >= 'E' && $initial < 'N' ) {
99
+		} elseif ($initial >= 'E' && $initial < 'N') {
100 100
 			$firstWeek = 4;
101 101
 		} else {
102 102
 			$firstWeek = 5;
@@ -114,27 +114,27 @@  discard block
 block discarded – undo
114 114
 		return $timestamp >= $threshold;
115 115
 	}
116 116
 
117
-	public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
117
+	public static function onBeforePageDisplay(OutputPage $out, Skin $skin) {
118 118
 		$repo = WikibaseRepo::getDefaultInstance();
119 119
 
120 120
 		$lookup = $repo->getEntityNamespaceLookup();
121 121
 		$title = $out->getTitle();
122
-		if ( $title === null ) {
122
+		if ($title === null) {
123 123
 			return;
124 124
 		}
125 125
 
126
-		if ( !$lookup->isEntityNamespace( $title->getNamespace() ) ) {
126
+		if (!$lookup->isEntityNamespace($title->getNamespace())) {
127 127
 			return;
128 128
 		}
129
-		if ( !$out->getUser()->isLoggedIn() ) {
129
+		if (!$out->getUser()->isLoggedIn()) {
130 130
 			return;
131 131
 		}
132
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
132
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
133 133
 			return;
134 134
 		}
135 135
 
136
-		if ( self::isGadgetEnabledForUserName( $out->getUser()->getName(), time() ) ) {
137
-			$out->addModules( 'wikibase.quality.constraints.gadget' );
136
+		if (self::isGadgetEnabledForUserName($out->getUser()->getName(), time())) {
137
+			$out->addModules('wikibase.quality.constraints.gadget');
138 138
 		}
139 139
 	}
140 140
 
Please login to merge, or discard this patch.