wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Message/ViolationMessage.php

Spacing +23 added lines, -23 removed lines

@@ -85,17 +85,17 @@ 
 	public function __construct(
 		$messageKey
 	) {
-		if ( strpos( $messageKey, self::MESSAGE_KEY_PREFIX ) !== 0 ) {
+		if (strpos($messageKey, self::MESSAGE_KEY_PREFIX) !== 0) {
 			throw new InvalidArgumentException(
-				'ViolationMessage key ⧼' .
-				$messageKey .
-				'⧽ should start with "' .
-				self::MESSAGE_KEY_PREFIX .
+				'ViolationMessage key ⧼'.
+				$messageKey.
+				'⧽ should start with "'.
+				self::MESSAGE_KEY_PREFIX.
 				'".'
 			);
 		}
 
-		$this->messageKeySuffix = substr( $messageKey, strlen( self::MESSAGE_KEY_PREFIX ) );
+		$this->messageKeySuffix = substr($messageKey, strlen(self::MESSAGE_KEY_PREFIX));
 		$this->arguments = [];
 	}
 
@@ -104,7 +104,7 @@ 
 	 * @return string
 	 */
 	public function getMessageKey() {
-		return self::MESSAGE_KEY_PREFIX . $this->messageKeySuffix;
+		return self::MESSAGE_KEY_PREFIX.$this->messageKeySuffix;
 	}
 
 	/**
@@ -122,9 +122,9 @@ 
 	 * @param mixed $value the value, which should match the $type
 	 * @return ViolationMessage
 	 */
-	private function withArgument( $type, $role, $value ) {
+	private function withArgument($type, $role, $value) {
 		$ret = clone $this;
-		$ret->arguments[] = [ 'type' => $type, 'role' => $role, 'value' => $value ];
+		$ret->arguments[] = ['type' => $type, 'role' => $role, 'value' => $value];
 		return $ret;
 	}
 
@@ -136,8 +136,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withEntityId( EntityId $entityId, $role = null ) {
-		return $this->withArgument( self::TYPE_ENTITY_ID, $role, $entityId );
+	public function withEntityId(EntityId $entityId, $role = null) {
+		return $this->withArgument(self::TYPE_ENTITY_ID, $role, $entityId);
 	}
 
 	/**
@@ -154,8 +154,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withEntityIdList( array $entityIdList, $role = null ) {
-		return $this->withArgument( self::TYPE_ENTITY_ID_LIST, $role, $entityIdList );
+	public function withEntityIdList(array $entityIdList, $role = null) {
+		return $this->withArgument(self::TYPE_ENTITY_ID_LIST, $role, $entityIdList);
 	}
 
 	/**
@@ -166,8 +166,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value );
+	public function withItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value);
 	}
 
 	/**
@@ -184,8 +184,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withItemIdSnakValueList( array $valueList, $role = null ) {
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList );
+	public function withItemIdSnakValueList(array $valueList, $role = null) {
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList);
 	}
 
 	/**
@@ -196,8 +196,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withDataValue( DataValue $dataValue, $role = null ) {
-		return $this->withArgument( self::TYPE_DATA_VALUE, $role, $dataValue );
+	public function withDataValue(DataValue $dataValue, $role = null) {
+		return $this->withArgument(self::TYPE_DATA_VALUE, $role, $dataValue);
 	}
 
 	/**
@@ -212,8 +212,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withDataValueType( $dataValueType, $role = null ) {
-		return $this->withArgument( self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType );
+	public function withDataValueType($dataValueType, $role = null) {
+		return $this->withArgument(self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType);
 	}
 
 	/**
@@ -224,8 +224,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withInlineCode( $code, $role = null ) {
-		return $this->withArgument( self::TYPE_INLINE_CODE, $role, $code );
+	public function withInlineCode($code, $role = null) {
+		return $this->withArgument(self::TYPE_INLINE_CODE, $role, $code);
 	}
 
 }

src/ConstraintCheck/Message/ViolationMessageRenderer.php

Spacing +66 added lines, -66 removed lines

@@ -54,96 +54,96 @@ 
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
 	 * @return string
 	 */
-	public function render( $violationMessage ) {
-		if ( is_string( $violationMessage ) ) {
+	public function render($violationMessage) {
+		if (is_string($violationMessage)) {
 			// TODO remove this once all checkers produce ViolationMessage objects
 			return $violationMessage;
 		}
-		$message = new Message( $violationMessage->getMessageKey() );
-		foreach ( $violationMessage->getArguments() as $argument ) {
-			$this->renderArgument( $argument, $message );
+		$message = new Message($violationMessage->getMessageKey());
+		foreach ($violationMessage->getArguments() as $argument) {
+			$this->renderArgument($argument, $message);
 		}
 		return $message->escaped();
 	}
 
-	private function addRole( $value, $role ) {
-		if ( $role === null ) {
+	private function addRole($value, $role) {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
-			$value .
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
+			$value.
 			'</span>';
 	}
 
-	private function renderArgument( array $argument, Message $message ) {
+	private function renderArgument(array $argument, Message $message) {
 		$type = $argument['type'];
 		$value = $argument['value'];
 		$role = $argument['role'];
-		switch ( $type ) {
+		switch ($type) {
 			case ViolationMessage::TYPE_ENTITY_ID:
-				$params = $this->renderEntityId( $value, $role );
+				$params = $this->renderEntityId($value, $role);
 				break;
 			case ViolationMessage::TYPE_ENTITY_ID_LIST:
-				$params = $this->renderEntityIdList( $value, $role );
+				$params = $this->renderEntityIdList($value, $role);
 				break;
 			case ViolationMessage::TYPE_ITEM_ID_SNAK_VALUE:
-				$params = $this->renderItemIdSnakValue( $value, $role );
+				$params = $this->renderItemIdSnakValue($value, $role);
 				break;
 			case ViolationMessage::TYPE_ITEM_ID_SNAK_VALUE_LIST:
-				$params = $this->renderItemIdSnakValueList( $value, $role );
+				$params = $this->renderItemIdSnakValueList($value, $role);
 				break;
 			case ViolationMessage::TYPE_DATA_VALUE:
-				$params = $this->renderDataValue( $value, $role );
+				$params = $this->renderDataValue($value, $role);
 				break;
 			case ViolationMessage::TYPE_DATA_VALUE_TYPE:
-				$params = $this->renderDataValueType( $value, $role );
+				$params = $this->renderDataValueType($value, $role);
 				break;
 			case ViolationMessage::TYPE_INLINE_CODE:
-				$params = $this->renderInlineCode( $value, $role );
+				$params = $this->renderInlineCode($value, $role);
 				break;
 			default:
 				throw new InvalidArgumentException(
-					'Unknown ViolationMessage argument type ' . $type . '!'
+					'Unknown ViolationMessage argument type '.$type.'!'
 				);
 		}
-		$message->params( $params );
+		$message->params($params);
 	}
 
-	private function renderList( array $list, $role, callable $render ) {
-		if ( $list === [] ) {
+	private function renderList(array $list, $role, callable $render) {
+		if ($list === []) {
 			return [
-				Message::numParam( 0 ),
-				Message::rawParam( '<ul></ul>' ),
+				Message::numParam(0),
+				Message::rawParam('<ul></ul>'),
 			];
 		}
 
-		if ( count( $list ) > $this->maxListLength ) {
-			$list = array_slice( $list, 0, $this->maxListLength );
+		if (count($list) > $this->maxListLength) {
+			$list = array_slice($list, 0, $this->maxListLength);
 			$truncated = true;
 		}
 
 		$renderedParams = array_map(
 			$render,
 			$list,
-			array_fill( 0, count( $list ), $role )
+			array_fill(0, count($list), $role)
 		);
 		$renderedElements = array_map(
-			function ( $param ) {
+			function($param) {
 				return $param['raw'];
 			},
 			$renderedParams
 		);
-		if ( isset( $truncated ) ) {
-			$renderedElements[] = wfMessage( 'ellipsis' )->escaped();
+		if (isset($truncated)) {
+			$renderedElements[] = wfMessage('ellipsis')->escaped();
 		}
 
 		return array_merge(
 			[
-				Message::numParam( count( $list ) ),
+				Message::numParam(count($list)),
 				Message::rawParam(
-					'<ul><li>' .
-					implode( '</li><li>', $renderedElements ) .
+					'<ul><li>'.
+					implode('</li><li>', $renderedElements).
 					'</li></ul>'
 				),
 			],
@@ -151,35 +151,35 @@ 
 		);
 	}
 
-	private function renderEntityId( EntityId $entityId, $role ) {
-		return Message::rawParam( $this->addRole(
-			$this->entityIdFormatter->formatEntityId( $entityId ),
+	private function renderEntityId(EntityId $entityId, $role) {
+		return Message::rawParam($this->addRole(
+			$this->entityIdFormatter->formatEntityId($entityId),
 			$role
-		) );
+		));
 	}
 
-	private function renderEntityIdList( array $entityIdList, $role ) {
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
+	private function renderEntityIdList(array $entityIdList, $role) {
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
 	}
 
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, $role ) {
-		switch ( true ) {
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, $role) {
+		switch (true) {
 			case $value->isValue():
-				return $this->renderEntityId( $value->getItemId(), $role );
+				return $this->renderEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
-						wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped() .
+				return Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
+						wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped().
 						'</span>',
 					$role
-				) );
+				));
 			case $value->isNoValue():
-				return Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
-						wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped() .
+				return Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
+						wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped().
 						'</span>',
 					$role
-				) );
+				));
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
@@ -189,43 +189,43 @@ 
 		}
 	}
 
-	private function renderItemIdSnakValueList( array $valueList, $role ) {
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
+	private function renderItemIdSnakValueList(array $valueList, $role) {
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
 	}
 
-	private function renderDataValue( DataValue $dataValue, $role ) {
-		return Message::rawParam( $this->addRole(
-			$this->dataValueFormatter->format( $dataValue ),
+	private function renderDataValue(DataValue $dataValue, $role) {
+		return Message::rawParam($this->addRole(
+			$this->dataValueFormatter->format($dataValue),
 			$role
-		) );
+		));
 	}
 
-	private function renderDataValueType( $dataValueType, $role ) {
+	private function renderDataValueType($dataValueType, $role) {
 		$messageKeys = [
 			'string' => 'datatypes-type-string',
 			'monolingualtext' => 'datatypes-monolingualtext',
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
 		];
 
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
-			return Message::rawParam( $this->addRole(
-				wfMessage( $messageKeys[$dataValueType] )->escaped(),
+		if (array_key_exists($dataValueType, $messageKeys)) {
+			return Message::rawParam($this->addRole(
+				wfMessage($messageKeys[$dataValueType])->escaped(),
 				$role
-			) );
+			));
 		} else {
 			// @codeCoverageIgnoreStart
 			throw new LogicException(
-				'Unknown data value type ' . $dataValueType
+				'Unknown data value type '.$dataValueType
 			);
 			// @codeCoverageIgnoreEnd
 		}
 	}
 
-	private function renderInlineCode( $code, $role ) {
-		return Message::rawParam( $this->addRole(
-			'<code>' . htmlspecialchars( $code ) . '</code>',
+	private function renderInlineCode($code, $role) {
+		return Message::rawParam($this->addRole(
+			'<code>'.htmlspecialchars($code).'</code>',
 			$role
-		) );
+		));
 	}
 
 }