wikimedia / mediawiki-extensions-WikibaseQualityConstraints

maintenance/ImportConstraintEntities.php

Spacing +59 added lines, -59 removed lines

@@ -17,10 +17,10 @@ 
 use Wikibase\Repo\WikibaseRepo;
 
 // @codeCoverageIgnoreStart
-$basePath = getenv( "MW_INSTALL_PATH" ) !== false
-	? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../..";
+$basePath = getenv("MW_INSTALL_PATH") !== false
+	? getenv("MW_INSTALL_PATH") : __DIR__."/../../..";
 
-require_once $basePath . "/maintenance/Maintenance.php";
+require_once $basePath."/maintenance/Maintenance.php";
 // @codeCoverageIgnoreEnd
 
 /**
@@ -59,20 +59,20 @@ 
 		parent::__construct();
 
 		$this->addDescription(
-			'Import entities needed for constraint checks ' .
+			'Import entities needed for constraint checks '.
 			'from Wikidata into the local repository.'
 		);
 		$this->addOption(
 			'config-format',
-			'The format in which the resulting configuration will be omitted: ' .
-			'"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), ' .
+			'The format in which the resulting configuration will be omitted: '.
+			'"globals" for directly settings global variables, suitable for inclusion in LocalSettings.php (default), '.
 			'or "wgConf" for printing parts of arrays suitable for inclusion in $wgConf->settings.'
 		);
 		$this->addOption(
 			'dry-run',
 			'Don’t actually import entities, just print which ones would be imported.'
 		);
-		$this->requireExtension( 'WikibaseQualityConstraints' );
+		$this->requireExtension('WikibaseQualityConstraints');
 	}
 
 	/**
@@ -80,12 +80,12 @@ 
 	 */
 	private function setupServices() {
 		$services = MediaWikiServices::getInstance();
-		$this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer( $services );
-		$this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer( $services );
-		$this->entityStore = WikibaseRepo::getEntityStore( $services );
+		$this->entitySerializer = WikibaseRepo::getAllTypesEntitySerializer($services);
+		$this->entityDeserializer = WikibaseRepo::getInternalFormatEntityDeserializer($services);
+		$this->entityStore = WikibaseRepo::getEntityStore($services);
 		$this->httpRequestFactory = $services->getHttpRequestFactory();
-		if ( !$this->getOption( 'dry-run', false ) ) {
-			$this->user = User::newSystemUser( 'WikibaseQualityConstraints importer' );
+		if (!$this->getOption('dry-run', false)) {
+			$this->user = User::newSystemUser('WikibaseQualityConstraints importer');
 		}
 	}
 
@@ -94,21 +94,21 @@ 
 
 		$configUpdates = [];
 
-		$extensionJsonFile = __DIR__ . '/../extension.json';
-		$extensionJsonText = file_get_contents( $extensionJsonFile );
-		$extensionJson = json_decode( $extensionJsonText, /* assoc = */ true );
+		$extensionJsonFile = __DIR__.'/../extension.json';
+		$extensionJsonText = file_get_contents($extensionJsonFile);
+		$extensionJson = json_decode($extensionJsonText, /* assoc = */ true);
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		$wikidataEntityIds = $this->getEntitiesToImport( $extensionJson['config'], $this->getConfig() );
+		$wikidataEntityIds = $this->getEntitiesToImport($extensionJson['config'], $this->getConfig());
 
-		foreach ( $wikidataEntityIds as $key => $wikidataEntityId ) {
-			$localEntityId = $this->importEntityFromWikidata( $wikidataEntityId );
+		foreach ($wikidataEntityIds as $key => $wikidataEntityId) {
+			$localEntityId = $this->importEntityFromWikidata($wikidataEntityId);
 			$configUpdates[$key] = [
 				'wikidata' => $wikidataEntityId,
 				'local' => $localEntityId,
 			];
 		}
 
-		$this->outputConfigUpdates( $configUpdates );
+		$this->outputConfigUpdates($configUpdates);
 	}
 
 	/**
@@ -116,18 +116,18 @@ 
 	 * @param Config $wikiConfig
 	 * @return string[]
 	 */
-	private function getEntitiesToImport( array $extensionJsonConfig, Config $wikiConfig ) {
+	private function getEntitiesToImport(array $extensionJsonConfig, Config $wikiConfig) {
 		$wikidataEntityIds = [];
 
-		foreach ( $extensionJsonConfig as $key => $value ) {
-			if ( !preg_match( '/Id$/', $key ) ) {
+		foreach ($extensionJsonConfig as $key => $value) {
+			if (!preg_match('/Id$/', $key)) {
 				continue;
 			}
 
 			$wikidataEntityId = $value['value'];
-			$localEntityId = $wikiConfig->get( $key );
+			$localEntityId = $wikiConfig->get($key);
 
-			if ( $localEntityId === $wikidataEntityId ) {
+			if ($localEntityId === $wikidataEntityId) {
 				$wikidataEntityIds[$key] = $wikidataEntityId;
 			}
 		}
@@ -139,10 +139,10 @@ 
 	 * @param string $wikidataEntityId
 	 * @return string local entity ID
 	 */
-	private function importEntityFromWikidata( $wikidataEntityId ) {
+	private function importEntityFromWikidata($wikidataEntityId) {
 		$wikidataEntityUrl = "https://www.wikidata.org/wiki/Special:EntityData/$wikidataEntityId.json";
-		$wikidataEntitiesJson = $this->httpRequestFactory->get( $wikidataEntityUrl, [], __METHOD__ );
-		return $this->importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson );
+		$wikidataEntitiesJson = $this->httpRequestFactory->get($wikidataEntityUrl, [], __METHOD__);
+		return $this->importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson);
 	}
 
 	/**
@@ -150,24 +150,24 @@ 
 	 * @param string $wikidataEntitiesJson
 	 * @return string local entity ID
 	 */
-	private function importEntityFromJson( $wikidataEntityId, $wikidataEntitiesJson ) {
+	private function importEntityFromJson($wikidataEntityId, $wikidataEntitiesJson) {
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		$wikidataEntityArray = json_decode( $wikidataEntitiesJson, true )['entities'][$wikidataEntityId];
-		$wikidataEntity = $this->entityDeserializer->deserialize( $wikidataEntityArray );
+		$wikidataEntityArray = json_decode($wikidataEntitiesJson, true)['entities'][$wikidataEntityId];
+		$wikidataEntity = $this->entityDeserializer->deserialize($wikidataEntityArray);
 
-		$wikidataEntity->setId( null );
+		$wikidataEntity->setId(null);
 
-		if ( $wikidataEntity instanceof StatementListProvider ) {
+		if ($wikidataEntity instanceof StatementListProvider) {
 			$wikidataEntity->getStatements()->clear();
 		}
 
-		if ( $wikidataEntity instanceof Item ) {
-			$wikidataEntity->setSiteLinkList( new SiteLinkList() );
+		if ($wikidataEntity instanceof Item) {
+			$wikidataEntity->setSiteLinkList(new SiteLinkList());
 		}
 
-		if ( $this->getOption( 'dry-run', false ) ) {
-			$wikidataEntityJson = json_encode( $this->entitySerializer->serialize( $wikidataEntity ) );
-			$this->output( $wikidataEntityJson . "\n" );
+		if ($this->getOption('dry-run', false)) {
+			$wikidataEntityJson = json_encode($this->entitySerializer->serialize($wikidataEntity));
+			$this->output($wikidataEntityJson."\n");
 			return "-$wikidataEntityId";
 		}
 
@@ -180,12 +180,12 @@ 
 			)->getEntity();
 
 			return $localEntity->getId()->getSerialization();
-		} catch ( StorageException $storageException ) {
-			return $this->storageExceptionToEntityId( $storageException );
+		} catch (StorageException $storageException) {
+			return $this->storageExceptionToEntityId($storageException);
 		}
 	}
 
-	private function storageExceptionToEntityId( StorageException $storageException ) {
+	private function storageExceptionToEntityId(StorageException $storageException) {
 		$message = $storageException->getMessage();
 		// example messages:
 		// * Item [[Item:Q475|Q475]] already has label "as references"
@@ -195,25 +195,25 @@ 
 		// * Property [[Property:P694|P694]] already has label "instance of"
 		//   associated with language code en.
 		$pattern = '/[[|]([^][|]*)]] already has label .* associated with language code/';
-		if ( preg_match( $pattern, $message, $matches ) ) {
+		if (preg_match($pattern, $message, $matches)) {
 			return $matches[1];
 		} else {
 			throw $storageException;
 		}
 	}
 
-	private function outputConfigUpdates( array $configUpdates ) {
-		$configFormat = $this->getOption( 'config-format', 'globals' );
-		switch ( $configFormat ) {
+	private function outputConfigUpdates(array $configUpdates) {
+		$configFormat = $this->getOption('config-format', 'globals');
+		switch ($configFormat) {
 			case 'globals':
-				$this->outputConfigUpdatesGlobals( $configUpdates );
+				$this->outputConfigUpdatesGlobals($configUpdates);
 				break;
 			case 'wgConf':
-				$this->outputConfigUpdatesWgConf( $configUpdates );
+				$this->outputConfigUpdatesWgConf($configUpdates);
 				break;
 			default:
-				$this->error( "Invalid config format \"$configFormat\", using \"globals\"" );
-				$this->outputConfigUpdatesGlobals( $configUpdates );
+				$this->error("Invalid config format \"$configFormat\", using \"globals\"");
+				$this->outputConfigUpdatesGlobals($configUpdates);
 				break;
 		}
 	}
@@ -221,22 +221,22 @@ 
 	/**
 	 * @param array[] $configUpdates
 	 */
-	private function outputConfigUpdatesGlobals( array $configUpdates ) {
-		foreach ( $configUpdates as $key => $value ) {
-			$localValueCode = var_export( $value['local'], true );
-			$this->output( "\$wg$key = $localValueCode;\n" );
+	private function outputConfigUpdatesGlobals(array $configUpdates) {
+		foreach ($configUpdates as $key => $value) {
+			$localValueCode = var_export($value['local'], true);
+			$this->output("\$wg$key = $localValueCode;\n");
 		}
 	}
 
 	/**
 	 * @param array[] $configUpdates
 	 */
-	private function outputConfigUpdatesWgConf( array $configUpdates ) {
-		foreach ( $configUpdates as $key => $value ) {
-			$keyCode = var_export( "wg$key", true );
-			$wikidataValueCode = var_export( $value['wikidata'], true );
-			$localValueCode = var_export( $value['local'], true );
-			$wikiIdCode = var_export( wfWikiID(), true );
+	private function outputConfigUpdatesWgConf(array $configUpdates) {
+		foreach ($configUpdates as $key => $value) {
+			$keyCode = var_export("wg$key", true);
+			$wikidataValueCode = var_export($value['wikidata'], true);
+			$localValueCode = var_export($value['local'], true);
+			$wikiIdCode = var_export(wfWikiID(), true);
 			$block = <<< EOF
 $keyCode => [
 	'default' => $wikidataValueCode,
@@ -245,7 +245,7 @@ 
 
 
 EOF;
-			$this->output( $block );
+			$this->output($block);
 		}
 	}
 

src/Api/CheckConstraints.php

Spacing +33 added lines, -33 removed lines

@@ -85,13 +85,13 @@ 
 
 		$language = WikibaseRepo::getUserLanguage();
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
-		$valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
+		$valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
 
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
-		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $language );
+		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($language);
 		$entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory();
-		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $language );
+		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($language);
 
 		$checkResultsRenderer = new CheckResultsRenderer(
 			$entityTitleLookup,
@@ -109,7 +109,7 @@ 
 			$name,
 			$entityIdParser,
 			$statementGuidValidator,
-			$repo->getApiHelperFactory( $main->getContext() ),
+			$repo->getApiHelperFactory($main->getContext()),
 			$resultsSource,
 			$checkResultsRenderer,
 			$dataFactory
@@ -136,11 +136,11 @@ 
 		CheckResultsRenderer $checkResultsRenderer,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->resultsSource = $resultsSource;
 		$this->checkResultsRenderer = $checkResultsRenderer;
 		$this->dataFactory = $dataFactory;
@@ -156,9 +156,9 @@ 
 
 		$params = $this->extractRequestParams();
 
-		$this->validateParameters( $params );
-		$entityIds = $this->parseEntityIds( $params );
-		$claimIds = $this->parseClaimIds( $params );
+		$this->validateParameters($params);
+		$entityIds = $this->parseEntityIds($params);
+		$claimIds = $this->parseClaimIds($params);
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
 		$statuses = $params[self::PARAM_STATUS];
 
@@ -174,7 +174,7 @@ 
 				)
 			)->getArray()
 		);
-		$this->resultBuilder->markSuccess( 1 );
+		$this->resultBuilder->markSuccess(1);
 	}
 
 	/**
@@ -182,24 +182,24 @@ 
 	 *
 	 * @return EntityId[]
 	 */
-	private function parseEntityIds( array $params ) {
+	private function parseEntityIds(array $params) {
 		$ids = $params[self::PARAM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		return array_map( function ( $id ) {
+		return array_map(function($id) {
 			try {
-				return $this->entityIdParser->parse( $id );
-			} catch ( EntityIdParsingException $e ) {
+				return $this->entityIdParser->parse($id);
+			} catch (EntityIdParsingException $e) {
 				$this->errorReporter->dieError(
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
 			}
-		}, $ids );
+		}, $ids);
 	}
 
 	/**
@@ -207,35 +207,35 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function parseClaimIds( array $params ) {
+	private function parseClaimIds(array $params) {
 		$ids = $params[self::PARAM_CLAIM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		foreach ( $ids as $id ) {
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
+		foreach ($ids as $id) {
+			if (!$this->statementGuidValidator->validate($id)) {
 				$this->errorReporter->dieError(
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
 			}
 		}
 
 		return $ids;
 	}
 
-	private function validateParameters( array $params ) {
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
+	private function validateParameters(array $params) {
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
 		) {
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
 			$this->errorReporter->dieError(
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
 		}
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
 			$paramId = self::PARAM_ID;
 			$paramClaimId = self::PARAM_CLAIM_ID;
 			$this->errorReporter->dieError(
@@ -276,7 +276,7 @@ 
 				],
 				ApiBase::PARAM_ISMULTI => true,
 				ApiBase::PARAM_ALL => true,
-				ApiBase::PARAM_DFLT => implode( '|', CachingResultsSource::CACHED_STATUSES ),
+				ApiBase::PARAM_DFLT => implode('|', CachingResultsSource::CACHED_STATUSES),
 				ApiBase::PARAM_HELP_MSG_PER_VALUE => [],
 			],
 		];

src/Api/CheckConstraintParameters.php

Spacing +51 added lines, -51 removed lines

@@ -77,16 +77,16 @@ 
 		DelegatingConstraintChecker $delegatingConstraintChecker
 	): self {
 		$repo = WikibaseRepo::getDefaultInstance();
-		$helperFactory = $repo->getApiHelperFactory( $main->getContext() );
+		$helperFactory = $repo->getApiHelperFactory($main->getContext());
 		$language = WikibaseRepo::getUserLanguage();
 
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
 		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory
-			->getEntityIdFormatter( $language );
+			->getEntityIdFormatter($language);
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
 		$dataValueFormatter = $valueFormatterFactory
-			->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
+			->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
 		$violationMessageRenderer = new MultilingualTextViolationMessageRenderer(
 			$entityIdHtmlLinkFormatter,
 			$dataValueFormatter,
@@ -122,9 +122,9 @@ 
 		StatementGuidParser $statementGuidParser,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
 		$this->violationMessageRenderer = $violationMessageRenderer;
 		$this->statementGuidParser = $statementGuidParser;
@@ -139,39 +139,39 @@ 
 		$params = $this->extractRequestParams();
 		$result = $this->getResult();
 
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
 
-		$this->checkPropertyIds( $propertyIds, $result );
-		$this->checkConstraintIds( $constraintIds, $result );
+		$this->checkPropertyIds($propertyIds, $result);
+		$this->checkConstraintIds($constraintIds, $result);
 
-		$result->addValue( null, 'success', 1 );
+		$result->addValue(null, 'success', 1);
 	}
 
 	/**
 	 * @param array|null $propertyIdSerializations
 	 * @return PropertyId[]
 	 */
-	private function parsePropertyIds( $propertyIdSerializations ) {
-		if ( $propertyIdSerializations === null ) {
+	private function parsePropertyIds($propertyIdSerializations) {
+		if ($propertyIdSerializations === null) {
 			return [];
-		} elseif ( empty( $propertyIdSerializations ) ) {
+		} elseif (empty($propertyIdSerializations)) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $propertyIdSerialization ) {
+			function($propertyIdSerialization) {
 				try {
-					return new PropertyId( $propertyIdSerialization );
-				} catch ( InvalidArgumentException $e ) {
+					return new PropertyId($propertyIdSerialization);
+				} catch (InvalidArgumentException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid id: $propertyIdSerialization",
 						'invalid-property-id',
 						0, // default argument
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
 					);
 				}
 			},
@@ -183,35 +183,35 @@ 
 	 * @param array|null $constraintIds
 	 * @return string[]
 	 */
-	private function parseConstraintIds( $constraintIds ) {
-		if ( $constraintIds === null ) {
+	private function parseConstraintIds($constraintIds) {
+		if ($constraintIds === null) {
 			return [];
-		} elseif ( empty( $constraintIds ) ) {
+		} elseif (empty($constraintIds)) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $constraintId ) {
+			function($constraintId) {
 				try {
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-					if ( !$propertyId instanceof PropertyId ) {
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+					if (!$propertyId instanceof PropertyId) {
 						$this->apiErrorReporter->dieError(
 							"Invalid property ID: {$propertyId->getSerialization()}",
 							'invalid-property-id',
 							0, // default argument
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
 						);
 					}
 					return $constraintId;
-				} catch ( StatementGuidParsingException $e ) {
+				} catch (StatementGuidParsingException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid statement GUID: $constraintId",
 						'invalid-guid',
 						0, // default argument
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
 					);
 				}
 			},
@@ -223,12 +223,12 @@ 
 	 * @param PropertyId[] $propertyIds
 	 * @param ApiResult $result
 	 */
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ) {
-		foreach ( $propertyIds as $propertyId ) {
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
+	private function checkPropertyIds(array $propertyIds, ApiResult $result) {
+		foreach ($propertyIds as $propertyId) {
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
 			$allConstraintExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnPropertyId( $propertyId );
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
+				->checkConstraintParametersOnPropertyId($propertyId);
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
 				$this->addConstraintParameterExceptionsToResult(
 					$constraintId,
 					$constraintParameterExceptions,
@@ -242,15 +242,15 @@ 
 	 * @param string[] $constraintIds
 	 * @param ApiResult $result
 	 */
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ) {
-		foreach ( $constraintIds as $constraintId ) {
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
+	private function checkConstraintIds(array $constraintIds, ApiResult $result) {
+		foreach ($constraintIds as $constraintId) {
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
 				// already checked as part of checkPropertyIds()
 				continue;
 			}
 			$constraintParameterExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnConstraintId( $constraintId );
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+				->checkConstraintParametersOnConstraintId($constraintId);
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 		}
 	}
 
@@ -258,18 +258,18 @@ 
 	 * @param PropertyId $propertyId
 	 * @return string[]
 	 */
-	private function getResultPathForPropertyId( PropertyId $propertyId ) {
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
+	private function getResultPathForPropertyId(PropertyId $propertyId) {
+		return [$this->getModuleName(), $propertyId->getSerialization()];
 	}
 
 	/**
 	 * @param string $constraintId
 	 * @return string[]
 	 */
-	private function getResultPathForConstraintId( $constraintId ) {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
+	private function getResultPathForConstraintId($constraintId) {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
 		'@phan-var PropertyId $propertyId';
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
 	}
 
 	/**
@@ -284,8 +284,8 @@ 
 		$constraintParameterExceptions,
 		ApiResult $result
 	) {
-		$path = $this->getResultPathForConstraintId( $constraintId );
-		if ( $constraintParameterExceptions === null ) {
+		$path = $this->getResultPathForConstraintId($constraintId);
+		if ($constraintParameterExceptions === null) {
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
@@ -295,12 +295,12 @@ 
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
-				empty( $constraintParameterExceptions ) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY
+				empty($constraintParameterExceptions) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY
 			);
 			$result->addValue(
 				$path,
 				self::KEY_PROBLEMS,
-				array_map( [ $this, 'formatConstraintParameterException' ], $constraintParameterExceptions )
+				array_map([$this, 'formatConstraintParameterException'], $constraintParameterExceptions)
 			);
 		}
 	}
@@ -311,7 +311,7 @@ 
 	 * @param ConstraintParameterException $e
 	 * @return string[]
 	 */
-	private function formatConstraintParameterException( ConstraintParameterException $e ) {
+	private function formatConstraintParameterException(ConstraintParameterException $e) {
 		return [
 			self::KEY_MESSAGE_HTML => $this->violationMessageRenderer->render(
 				$e->getViolationMessage()
@@ -344,8 +344,8 @@ 
 		return [
 			'action=wbcheckconstraintparameters&propertyid=P247'
 				=> 'apihelp-wbcheckconstraintparameters-example-propertyid-1',
-			'action=wbcheckconstraintparameters&' .
-			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' .
+			'action=wbcheckconstraintparameters&'.
+			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'.
 			'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f'
 				=> 'apihelp-wbcheckconstraintparameters-example-constraintid-2',
 		];

src/ServiceWiring-Wikibase.php

Spacing +6 added lines, -6 removed lines

@@ -8,20 +8,20 @@
 use Wikibase\Repo\WikibaseRepo;
 
 return [
-	WikibaseServices::ENTITY_LOOKUP => function ( MediaWikiServices $services ) {
+	WikibaseServices::ENTITY_LOOKUP => function(MediaWikiServices $services) {
 		return new ExceptionIgnoringEntityLookup(
-			WikibaseRepo::getEntityLookup( $services )
+			WikibaseRepo::getEntityLookup($services)
 		);
 	},
 
-	WikibaseServices::ENTITY_LOOKUP_WITHOUT_CACHE => function ( MediaWikiServices $services ) {
+	WikibaseServices::ENTITY_LOOKUP_WITHOUT_CACHE => function(MediaWikiServices $services) {
 		return new ExceptionIgnoringEntityLookup(
-			WikibaseRepo::getStore( $services )
-				->getEntityLookup( Store::LOOKUP_CACHING_RETRIEVE_ONLY )
+			WikibaseRepo::getStore($services)
+				->getEntityLookup(Store::LOOKUP_CACHING_RETRIEVE_ONLY)
 		);
 	},
 
-	WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function ( MediaWikiServices $services ) {
+	WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function(MediaWikiServices $services) {
 		return WikibaseRepo::getDefaultInstance()->getPropertyDataTypeLookup();
 	},
 ];

src/Job/UpdateConstraintsTableJob.php

Spacing +28 added lines, -28 removed lines

@@ -38,8 +38,8 @@ 
 	 */
 	private const BATCH_SIZE = 50;
 
-	public static function newFromGlobalState( Title $title, array $params ) {
-		Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' );
+	public static function newFromGlobalState(Title $title, array $params) {
+		Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]');
 		$services = MediaWikiServices::getInstance();
 		$repo = WikibaseRepo::getDefaultInstance();
 		return new UpdateConstraintsTableJob(
@@ -50,8 +50,8 @@ 
 			$services->getMainConfig(),
 			ConstraintsServices::getConstraintStore(),
 			$services->getDBLoadBalancerFactory(),
-			WikibaseRepo::getStore()->getEntityRevisionLookup( Store::LOOKUP_CACHING_DISABLED ),
-			WikibaseRepo::getBaseDataModelSerializerFactory( $services )
+			WikibaseRepo::getStore()->getEntityRevisionLookup(Store::LOOKUP_CACHING_DISABLED),
+			WikibaseRepo::getBaseDataModelSerializerFactory($services)
 				->newSnakSerializer()
 		);
 	}
@@ -111,7 +111,7 @@ 
 		EntityRevisionLookup $entityRevisionLookup,
 		Serializer $snakSerializer
 	) {
-		parent::__construct( 'constraintsTableUpdate', $title, $params );
+		parent::__construct('constraintsTableUpdate', $title, $params);
 
 		$this->propertyId = $propertyId;
 		$this->revisionId = $revisionId;
@@ -122,11 +122,11 @@ 
 		$this->snakSerializer = $snakSerializer;
 	}
 
-	public function extractParametersFromQualifiers( SnakList $qualifiers ) {
+	public function extractParametersFromQualifiers(SnakList $qualifiers) {
 		$parameters = [];
-		foreach ( $qualifiers as $qualifier ) {
+		foreach ($qualifiers as $qualifier) {
 			$qualifierId = $qualifier->getPropertyId()->getSerialization();
-			$paramSerialization = $this->snakSerializer->serialize( $qualifier );
+			$paramSerialization = $this->snakSerializer->serialize($qualifier);
 			$parameters[$qualifierId][] = $paramSerialization;
 		}
 		return $parameters;
@@ -143,7 +143,7 @@ 
 		'@phan-var \Wikibase\DataModel\Entity\EntityIdValue $dataValue';
 		$entityId = $dataValue->getEntityId();
 		$constraintTypeQid = $entityId->getSerialization();
-		$parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() );
+		$parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers());
 		return new Constraint(
 			$constraintId,
 			$propertyId,
@@ -158,24 +158,24 @@ 
 		PropertyId $propertyConstraintPropertyId
 	) {
 		$constraintsStatements = $property->getStatements()
-			->getByPropertyId( $propertyConstraintPropertyId )
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByPropertyId($propertyConstraintPropertyId)
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 		$constraints = [];
-		foreach ( $constraintsStatements->getIterator() as $constraintStatement ) {
-			$constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement );
-			if ( count( $constraints ) >= self::BATCH_SIZE ) {
-				$constraintStore->insertBatch( $constraints );
+		foreach ($constraintsStatements->getIterator() as $constraintStatement) {
+			$constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement);
+			if (count($constraints) >= self::BATCH_SIZE) {
+				$constraintStore->insertBatch($constraints);
 				// interrupt transaction and wait for replication
-				$connection = $this->lbFactory->getMainLB()->getConnection( DB_MASTER );
-				$connection->endAtomic( __CLASS__ );
-				if ( !$connection->explicitTrxActive() ) {
+				$connection = $this->lbFactory->getMainLB()->getConnection(DB_MASTER);
+				$connection->endAtomic(__CLASS__);
+				if (!$connection->explicitTrxActive()) {
 					$this->lbFactory->waitForReplication();
 				}
-				$connection->startAtomic( __CLASS__ );
+				$connection->startAtomic(__CLASS__);
 				$constraints = [];
 			}
 		}
-		$constraintStore->insertBatch( $constraints );
+		$constraintStore->insertBatch($constraints);
 	}
 
 	/**
@@ -186,24 +186,24 @@ 
 	public function run() {
 		// TODO in the future: only touch constraints affected by the edit (requires T163465)
 
-		$propertyId = new PropertyId( $this->propertyId );
+		$propertyId = new PropertyId($this->propertyId);
 		$propertyRevision = $this->entityRevisionLookup->getEntityRevision(
 			$propertyId,
 			0, // latest
 			LookupConstants::LATEST_FROM_REPLICA
 		);
 
-		if ( $this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId ) {
-			JobQueueGroup::singleton()->push( $this );
+		if ($this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId) {
+			JobQueueGroup::singleton()->push($this);
 			return true;
 		}
 
-		$connection = $this->lbFactory->getMainLB()->getConnection( DB_MASTER );
+		$connection = $this->lbFactory->getMainLB()->getConnection(DB_MASTER);
 		// start transaction (if not started yet) – using __CLASS__, not __METHOD__,
 		// because importConstraintsForProperty() can interrupt the transaction
-		$connection->startAtomic( __CLASS__ );
+		$connection->startAtomic(__CLASS__);
 
-		$this->constraintStore->deleteForProperty( $propertyId );
+		$this->constraintStore->deleteForProperty($propertyId);
 
 		/** @var Property $property */
 		$property = $propertyRevision->getEntity();
@@ -211,10 +211,10 @@ 
 		$this->importConstraintsForProperty(
 			$property,
 			$this->constraintStore,
-			new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) )
+			new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId'))
 		);
 
-		$connection->endAtomic( __CLASS__ );
+		$connection->endAtomic(__CLASS__);
 
 		return true;
 	}