Completed
Push — master ( b1dc35...53ddd5 )
by
unknown
01:52
created
src/ConstraintCheck/Checker/ContemporaryChecker.php 1 patch
Spacing   +42 added lines, -43 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	 * @codeCoverageIgnore This method is purely declarative.
80 80
 	 */
81 81
 	public function getDefaultContextTypes() {
82
-		return [ Context::TYPE_STATEMENT ];
82
+		return [Context::TYPE_STATEMENT];
83 83
 	}
84 84
 
85 85
 	/**
@@ -91,31 +91,31 @@  discard block
 block discarded – undo
91 91
 	 * @return CheckResult
92 92
 	 * @throws \ConfigException
93 93
 	 */
94
-	public function checkConstraint( Context $context, Constraint $constraint ) {
95
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
96
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
94
+	public function checkConstraint(Context $context, Constraint $constraint) {
95
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
96
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
97 97
 		}
98 98
 		$snak = $context->getSnak();
99
-		if ( !$snak instanceof PropertyValueSnak ) {
99
+		if (!$snak instanceof PropertyValueSnak) {
100 100
 			// nothing to check
101
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
101
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
102 102
 		}
103 103
 
104 104
 		$dataValue = $snak->getDataValue();
105
-		if ( !$dataValue instanceof EntityIdValue ) {
105
+		if (!$dataValue instanceof EntityIdValue) {
106 106
 			// wrong data type
107
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
108
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
109
-				->withDataValueType( 'wikibase-entityid' );
110
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
107
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
108
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
109
+				->withDataValueType('wikibase-entityid');
110
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
111 111
 		}
112 112
 
113 113
 		$objectId = $dataValue->getEntityId();
114
-		$objectItem = $this->entityLookup->getEntity( $objectId );
115
-		if ( !( $objectItem instanceof StatementListProvider ) ) {
114
+		$objectItem = $this->entityLookup->getEntity($objectId);
115
+		if (!($objectItem instanceof StatementListProvider)) {
116 116
 			// object was deleted/doesn't exist
117
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
118
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
117
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
118
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
119 119
 		}
120 120
 		/** @var Statement[] $objectStatements */
121 121
 		$objectStatements = $objectItem->getStatements()->toArray();
@@ -123,9 +123,9 @@  discard block
 block discarded – undo
123 123
 		$subjectId = $context->getEntity()->getId();
124 124
 		$subjectStatements = $context->getEntity()->getStatements()->toArray();
125 125
 		/** @var String[] $startPropertyIds */
126
-		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
126
+		$startPropertyIds = $this->config->get(self::CONFIG_VARIABLE_START_PROPERTY_IDS);
127 127
 		/** @var String[] $endPropertyIds */
128
-		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );
128
+		$endPropertyIds = $this->config->get(self::CONFIG_VARIABLE_END_PROPERTY_IDS);
129 129
 		$subjectStartValue = $this->getExtremeValue(
130 130
 			$startPropertyIds,
131 131
 			$subjectStatements,
@@ -147,15 +147,15 @@  discard block
 block discarded – undo
147 147
 			'end'
148 148
 		);
149 149
 		if (
150
-			$this->rangeCheckerHelper->getComparison( $subjectStartValue, $subjectEndValue ) <= 0 &&
151
-			$this->rangeCheckerHelper->getComparison( $objectStartValue, $objectEndValue ) <= 0 && (
152
-				$this->rangeCheckerHelper->getComparison( $subjectEndValue, $objectStartValue ) < 0 ||
153
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectStartValue ) < 0
150
+			$this->rangeCheckerHelper->getComparison($subjectStartValue, $subjectEndValue) <= 0 &&
151
+			$this->rangeCheckerHelper->getComparison($objectStartValue, $objectEndValue) <= 0 && (
152
+				$this->rangeCheckerHelper->getComparison($subjectEndValue, $objectStartValue) < 0 ||
153
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectStartValue) < 0
154 154
 			)
155 155
 		) {
156 156
 			if (
157 157
 				$subjectEndValue == null ||
158
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectEndValue ) < 0
158
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectEndValue) < 0
159 159
 			) {
160 160
 				$earlierEntityId = $objectId;
161 161
 				$minEndValue = $objectEndValue;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 			$message = null;
179 179
 			$status = CheckResult::STATUS_COMPLIANCE;
180 180
 		}
181
-		return new CheckResult( $context, $constraint, [], $status, $message );
181
+		return new CheckResult($context, $constraint, [], $status, $message);
182 182
 	}
183 183
 
184 184
 	/**
@@ -188,19 +188,19 @@  discard block
 block discarded – undo
188 188
 	 *
189 189
 	 * @return DataValue|null
190 190
 	 */
191
-	private function getExtremeValue( $extremePropertyIds, $statements, $startOrEnd ) {
192
-		if ( $startOrEnd !== 'start' && $startOrEnd !== 'end' ) {
193
-			throw new \InvalidArgumentException( '$startOrEnd must be \'start\' or \'end\'.' );
191
+	private function getExtremeValue($extremePropertyIds, $statements, $startOrEnd) {
192
+		if ($startOrEnd !== 'start' && $startOrEnd !== 'end') {
193
+			throw new \InvalidArgumentException('$startOrEnd must be \'start\' or \'end\'.');
194 194
 		}
195 195
 		$extremeValue = null;
196
-		foreach ( $extremePropertyIds as $extremePropertyId ) {
197
-			$statementList = new StatementList( $statements );
198
-			$extremeStatements = $statementList->getByPropertyId( new PropertyId( $extremePropertyId ) );
196
+		foreach ($extremePropertyIds as $extremePropertyId) {
197
+			$statementList = new StatementList($statements);
198
+			$extremeStatements = $statementList->getByPropertyId(new PropertyId($extremePropertyId));
199 199
 			/** @var Statement $extremeStatement */
200
-			foreach ( $extremeStatements as $extremeStatement ) {
201
-				if ( $extremeStatement->getRank() !== Statement::RANK_DEPRECATED ) {
200
+			foreach ($extremeStatements as $extremeStatement) {
201
+				if ($extremeStatement->getRank() !== Statement::RANK_DEPRECATED) {
202 202
 					$snak = $extremeStatement->getMainSnak();
203
-					if ( !$snak instanceof PropertyValueSnak ) {
203
+					if (!$snak instanceof PropertyValueSnak) {
204 204
 						return null;
205 205
 					} else {
206 206
 						$comparison = $this->rangeCheckerHelper->getComparison(
@@ -209,8 +209,8 @@  discard block
 block discarded – undo
209 209
 						);
210 210
 						if (
211 211
 							$extremeValue === null ||
212
-							( $startOrEnd === 'start' && $comparison < 0 ) ||
213
-							( $startOrEnd === 'end' && $comparison > 0 )
212
+							($startOrEnd === 'start' && $comparison < 0) ||
213
+							($startOrEnd === 'end' && $comparison > 0)
214 214
 						) {
215 215
 							$extremeValue = $snak->getDataValue();
216 216
 						}
@@ -240,17 +240,16 @@  discard block
 block discarded – undo
240 240
 		DataValue $maxStartValue
241 241
 	) {
242 242
 		$messageKey = $earlierEntityId === $subjectId ?
243
-			'wbqc-violation-message-contemporary-subject-earlier' :
244
-			'wbqc-violation-message-contemporary-value-earlier';
245
-		return ( new ViolationMessage( $messageKey ) )
246
-			->withEntityId( $subjectId, Role::SUBJECT )
247
-			->withEntityId( $propertyId, Role::PREDICATE )
248
-			->withEntityId( $objectId, Role::OBJECT )
249
-			->withDataValue( $minEndValue, Role::OBJECT )
250
-			->withDataValue( $maxStartValue, Role::OBJECT );
243
+			'wbqc-violation-message-contemporary-subject-earlier' : 'wbqc-violation-message-contemporary-value-earlier';
244
+		return (new ViolationMessage($messageKey))
245
+			->withEntityId($subjectId, Role::SUBJECT)
246
+			->withEntityId($propertyId, Role::PREDICATE)
247
+			->withEntityId($objectId, Role::OBJECT)
248
+			->withDataValue($minEndValue, Role::OBJECT)
249
+			->withDataValue($maxStartValue, Role::OBJECT);
251 250
 	}
252 251
 
253
-	public function checkConstraintParameters( Constraint $constraint ) {
252
+	public function checkConstraintParameters(Constraint $constraint) {
254 253
 		// no parameters
255 254
 		return [];
256 255
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
 	 * @throws ConstraintParameterException
72 72
 	 * @return CheckResult
73 73
 	 */
74
-	public function checkConstraint( Context $context, Constraint $constraint ) {
75
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
74
+	public function checkConstraint(Context $context, Constraint $constraint) {
75
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
76
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77 77
 		}
78 78
 
79 79
 		$parameters = [];
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			$constraintParameters,
85 85
 			$constraintTypeItemId
86 86
 		);
87
-		$parameters['property'] = [ $propertyId ];
87
+		$parameters['property'] = [$propertyId];
88 88
 
89 89
 		$items = $this->constraintParameterParser->parseItemsParameter(
90 90
 			$constraintParameters,
@@ -95,22 +95,22 @@  discard block
 block discarded – undo
95 95
 
96 96
 		$statementList = $context->getEntity()
97 97
 			->getStatements()
98
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
98
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
99 99
 
100 100
 		/*
101 101
 		 * 'Conflicts with' can be defined with
102 102
 		 *   a) a property only
103 103
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
104 104
 		 */
105
-		if ( $items === [] ) {
105
+		if ($items === []) {
106 106
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
107 107
 				$statementList,
108 108
 				$propertyId
109 109
 			);
110
-			if ( $offendingStatement !== null ) {
111
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
112
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
113
-					->withEntityId( $propertyId, Role::PREDICATE );
110
+			if ($offendingStatement !== null) {
111
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
112
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
113
+					->withEntityId($propertyId, Role::PREDICATE);
114 114
 				$status = CheckResult::STATUS_VIOLATION;
115 115
 			} else {
116 116
 				$message = null;
@@ -122,12 +122,12 @@  discard block
 block discarded – undo
122 122
 				$propertyId,
123 123
 				$items
124 124
 			);
125
-			if ( $offendingStatement !== null ) {
126
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
127
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
128
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
129
-					->withEntityId( $propertyId, Role::PREDICATE )
130
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
125
+			if ($offendingStatement !== null) {
126
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
127
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
128
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
129
+					->withEntityId($propertyId, Role::PREDICATE)
130
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
131 131
 				$status = CheckResult::STATUS_VIOLATION;
132 132
 			} else {
133 133
 				$message = null;
@@ -135,10 +135,10 @@  discard block
 block discarded – undo
135 135
 			}
136 136
 		}
137 137
 
138
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
138
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
139 139
 	}
140 140
 
141
-	public function checkConstraintParameters( Constraint $constraint ) {
141
+	public function checkConstraintParameters(Constraint $constraint) {
142 142
 		$constraintParameters = $constraint->getConstraintParameters();
143 143
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
144 144
 		$exceptions = [];
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 				$constraintParameters,
148 148
 				$constraintTypeItemId
149 149
 			);
150
-		} catch ( ConstraintParameterException $e ) {
150
+		} catch (ConstraintParameterException $e) {
151 151
 			$exceptions[] = $e;
152 152
 		}
153 153
 		try {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 				$constraintTypeItemId,
157 157
 				false
158 158
 			);
159
-		} catch ( ConstraintParameterException $e ) {
159
+		} catch (ConstraintParameterException $e) {
160 160
 			$exceptions[] = $e;
161 161
 		}
162 162
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/ViolationMessageDeserializer.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -39,23 +39,23 @@  discard block
 block discarded – undo
39 39
 		$this->dataValueFactory = $dataValueFactory;
40 40
 	}
41 41
 
42
-	public function unabbreviateViolationMessageKey( $messageKeySuffix ) {
43
-		return ViolationMessage::MESSAGE_KEY_PREFIX . $messageKeySuffix;
42
+	public function unabbreviateViolationMessageKey($messageKeySuffix) {
43
+		return ViolationMessage::MESSAGE_KEY_PREFIX.$messageKeySuffix;
44 44
 	}
45 45
 
46 46
 	/**
47 47
 	 * @param array $serialization
48 48
 	 * @return ViolationMessage
49 49
 	 */
50
-	public function deserialize( $serialization ) {
51
-		Assert::parameterType( 'array', $serialization, '$serialization' );
50
+	public function deserialize($serialization) {
51
+		Assert::parameterType('array', $serialization, '$serialization');
52 52
 
53 53
 		$message = new ViolationMessage(
54
-			$this->unabbreviateViolationMessageKey( $serialization['k'] )
54
+			$this->unabbreviateViolationMessageKey($serialization['k'])
55 55
 		);
56 56
 
57
-		foreach ( $serialization['a'] as $serializedArgument ) {
58
-			$message = $this->deserializeArgument( $message, $serializedArgument );
57
+		foreach ($serialization['a'] as $serializedArgument) {
58
+			$message = $this->deserializeArgument($message, $serializedArgument);
59 59
 		}
60 60
 
61 61
 		return $message;
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * @param array $serializedArgument [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
67 67
 	 * @return ViolationMessage $message with the deserialized argument appended
68 68
 	 */
69
-	private function deserializeArgument( ViolationMessage $message, array $serializedArgument ) {
69
+	private function deserializeArgument(ViolationMessage $message, array $serializedArgument) {
70 70
 		$methods = [
71 71
 			ViolationMessage::TYPE_ENTITY_ID => 'deserializeEntityId',
72 72
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'deserializeEntityIdList',
@@ -87,23 +87,23 @@  discard block
 block discarded – undo
87 87
 		$serializedValue = $serializedArgument['v'];
88 88
 		$role = $serializedArgument['r'];
89 89
 
90
-		if ( array_key_exists( $type, $methods ) ) {
90
+		if (array_key_exists($type, $methods)) {
91 91
 			$method = $methods[$type];
92
-			$value = $this->$method( $serializedValue );
92
+			$value = $this->$method($serializedValue);
93 93
 		} else {
94 94
 			throw new InvalidArgumentException(
95
-				'Unknown ViolationMessage argument type ' . $type . '!'
95
+				'Unknown ViolationMessage argument type '.$type.'!'
96 96
 			);
97 97
 		}
98 98
 
99
-		return $message->withArgument( $type, $role, $value );
99
+		return $message->withArgument($type, $role, $value);
100 100
 	}
101 101
 
102 102
 	/**
103 103
 	 * @param string $string any value that shall simply be deserialized into itself
104 104
 	 * @return string that same value, unchanged
105 105
 	 */
106
-	private function deserializeStringByIdentity( $string ) {
106
+	private function deserializeStringByIdentity($string) {
107 107
 		return $string;
108 108
 	}
109 109
 
@@ -111,32 +111,32 @@  discard block
 block discarded – undo
111 111
 	 * @param string $entityIdSerialization entity ID serialization
112 112
 	 * @return EntityId
113 113
 	 */
114
-	private function deserializeEntityId( $entityIdSerialization ) {
115
-		return $this->entityIdParser->parse( $entityIdSerialization );
114
+	private function deserializeEntityId($entityIdSerialization) {
115
+		return $this->entityIdParser->parse($entityIdSerialization);
116 116
 	}
117 117
 
118 118
 	/**
119 119
 	 * @param string[] $entityIdSerializations entity ID serializations
120 120
 	 * @return EntityId[]
121 121
 	 */
122
-	private function deserializeEntityIdList( array $entityIdSerializations ) {
123
-		return array_map( [ $this, 'deserializeEntityId' ], $entityIdSerializations );
122
+	private function deserializeEntityIdList(array $entityIdSerializations) {
123
+		return array_map([$this, 'deserializeEntityId'], $entityIdSerializations);
124 124
 	}
125 125
 
126 126
 	/**
127 127
 	 * @param string $valueSerialization entity ID serialization, '::somevalue' or '::novalue'
128 128
 	 * @return ItemIdSnakValue
129 129
 	 */
130
-	private function deserializeItemIdSnakValue( $valueSerialization ) {
131
-		switch ( $valueSerialization ) {
130
+	private function deserializeItemIdSnakValue($valueSerialization) {
131
+		switch ($valueSerialization) {
132 132
 			case '::somevalue':
133 133
 				return ItemIdSnakValue::someValue();
134 134
 			case '::novalue':
135 135
 				return ItemIdSnakValue::noValue();
136 136
 			default:
137
-				$itemId = $this->deserializeEntityId( $valueSerialization );
137
+				$itemId = $this->deserializeEntityId($valueSerialization);
138 138
 				'@phan-var \Wikibase\DataModel\Entity\ItemId $itemId';
139
-				return ItemIdSnakValue::fromItemId( $itemId );
139
+				return ItemIdSnakValue::fromItemId($itemId);
140 140
 		}
141 141
 	}
142 142
 
@@ -144,24 +144,24 @@  discard block
 block discarded – undo
144 144
 	 * @param string[] $valueSerializations entity ID serializations, '::somevalue's or '::novalue's
145 145
 	 * @return ItemIdSnakValue[]
146 146
 	 */
147
-	private function deserializeItemIdSnakValueList( $valueSerializations ) {
148
-		return array_map( [ $this, 'deserializeItemIdSnakValue' ], $valueSerializations );
147
+	private function deserializeItemIdSnakValueList($valueSerializations) {
148
+		return array_map([$this, 'deserializeItemIdSnakValue'], $valueSerializations);
149 149
 	}
150 150
 
151 151
 	/**
152 152
 	 * @param array $dataValueSerialization the data value in array form
153 153
 	 * @return DataValue
154 154
 	 */
155
-	private function deserializeDataValue( array $dataValueSerialization ) {
156
-		return $this->dataValueFactory->newFromArray( $dataValueSerialization );
155
+	private function deserializeDataValue(array $dataValueSerialization) {
156
+		return $this->dataValueFactory->newFromArray($dataValueSerialization);
157 157
 	}
158 158
 
159 159
 	/**
160 160
 	 * @param string $contextTypeAbbreviation
161 161
 	 * @return string one of the Context::TYPE_* constants
162 162
 	 */
163
-	private function deserializeContextType( $contextTypeAbbreviation ) {
164
-		switch ( $contextTypeAbbreviation ) {
163
+	private function deserializeContextType($contextTypeAbbreviation) {
164
+		switch ($contextTypeAbbreviation) {
165 165
 			case 's':
166 166
 				return Context::TYPE_STATEMENT;
167 167
 			case 'q':
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			default:
172 172
 				// @codeCoverageIgnoreStart
173 173
 				throw new LogicException(
174
-					'Unknown context type abbreviation ' . $contextTypeAbbreviation
174
+					'Unknown context type abbreviation '.$contextTypeAbbreviation
175 175
 				);
176 176
 				// @codeCoverageIgnoreEnd
177 177
 		}
@@ -181,16 +181,16 @@  discard block
 block discarded – undo
181 181
 	 * @param string[] $contextTypeAbbreviations
182 182
 	 * @return string[] Context::TYPE_* constants
183 183
 	 */
184
-	private function deserializeContextTypeList( array $contextTypeAbbreviations ) {
185
-		return array_map( [ $this, 'deserializeContextType' ], $contextTypeAbbreviations );
184
+	private function deserializeContextTypeList(array $contextTypeAbbreviations) {
185
+		return array_map([$this, 'deserializeContextType'], $contextTypeAbbreviations);
186 186
 	}
187 187
 
188 188
 	/**
189 189
 	 * @param mixed $textSerialization {@see MultilingualTextValue::getArrayValue}
190 190
 	 * @return MultilingualTextValue
191 191
 	 */
192
-	private function deserializeMultilingualText( $textSerialization ) {
193
-		return MultilingualTextValue::newFromArray( $textSerialization );
192
+	private function deserializeMultilingualText($textSerialization) {
193
+		return MultilingualTextValue::newFromArray($textSerialization);
194 194
 	}
195 195
 
196 196
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/DiffWithinRangeChecker.php 1 patch
Spacing   +41 added lines, -42 removed lines patch added patch discarded remove patch
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
76 76
 	 * @throws ConstraintParameterException
77 77
 	 * @return array [ DataValue|null $min, DataValue|null $max, PropertyId $property, array $parameters ]
78 78
 	 */
79
-	private function parseConstraintParameters( Constraint $constraint ) {
80
-		list( $min, $max ) = $this->constraintParameterParser->parseQuantityRangeParameter(
79
+	private function parseConstraintParameters(Constraint $constraint) {
80
+		list($min, $max) = $this->constraintParameterParser->parseQuantityRangeParameter(
81 81
 			$constraint->getConstraintParameters(),
82 82
 			$constraint->getConstraintTypeItemId()
83 83
 		);
@@ -87,15 +87,15 @@  discard block
 block discarded – undo
87 87
 		);
88 88
 
89 89
 		$parameters = [];
90
-		if ( $min !== null ) {
91
-			$parameters['minimum_quantity'] = [ $min ];
90
+		if ($min !== null) {
91
+			$parameters['minimum_quantity'] = [$min];
92 92
 		}
93
-		if ( $max !== null ) {
94
-			$parameters['maximum_quantity'] = [ $max ];
93
+		if ($max !== null) {
94
+			$parameters['maximum_quantity'] = [$max];
95 95
 		}
96
-		$parameters['property'] = [ $property ];
96
+		$parameters['property'] = [$property];
97 97
 
98
-		return [ $min, $max, $property, $parameters ];
98
+		return [$min, $max, $property, $parameters];
99 99
 	}
100 100
 
101 101
 	/**
@@ -105,13 +105,13 @@  discard block
 block discarded – undo
105 105
 	 *
106 106
 	 * @return bool
107 107
 	 */
108
-	private function rangeInYears( $min, $max ) {
109
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
108
+	private function rangeInYears($min, $max) {
109
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
110 110
 
111
-		if ( $min !== null && $min->getUnit() === $yearUnit ) {
111
+		if ($min !== null && $min->getUnit() === $yearUnit) {
112 112
 			return true;
113 113
 		}
114
-		if ( $max !== null && $max->getUnit() === $yearUnit ) {
114
+		if ($max !== null && $max->getUnit() === $yearUnit) {
115 115
 			return true;
116 116
 		}
117 117
 
@@ -127,30 +127,30 @@  discard block
 block discarded – undo
127 127
 	 * @throws ConstraintParameterException
128 128
 	 * @return CheckResult
129 129
 	 */
130
-	public function checkConstraint( Context $context, Constraint $constraint ) {
131
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
132
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
130
+	public function checkConstraint(Context $context, Constraint $constraint) {
131
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
132
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
133 133
 		}
134 134
 
135 135
 		$parameters = [];
136 136
 
137 137
 		$snak = $context->getSnak();
138 138
 
139
-		if ( !$snak instanceof PropertyValueSnak ) {
139
+		if (!$snak instanceof PropertyValueSnak) {
140 140
 			// nothing to check
141
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
141
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
142 142
 		}
143 143
 
144 144
 		$minuend = $snak->getDataValue();
145 145
 		'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $minuend';
146 146
 
147 147
 		/** @var PropertyId $property */
148
-		list( $min, $max, $property, $parameters ) = $this->parseConstraintParameters( $constraint );
148
+		list($min, $max, $property, $parameters) = $this->parseConstraintParameters($constraint);
149 149
 
150 150
 		// checks only the first occurrence of the referenced property
151
-		foreach ( $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ) as $otherSnak ) {
151
+		foreach ($context->getSnakGroup(Context::GROUP_NON_DEPRECATED) as $otherSnak) {
152 152
 			if (
153
-				!$property->equals( $otherSnak->getPropertyId() ) ||
153
+				!$property->equals($otherSnak->getPropertyId()) ||
154 154
 				!$otherSnak instanceof PropertyValueSnak
155 155
 			) {
156 156
 				continue;
@@ -158,30 +158,29 @@  discard block
 block discarded – undo
158 158
 
159 159
 			$subtrahend = $otherSnak->getDataValue();
160 160
 			'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $subtrahend';
161
-			if ( $subtrahend->getType() === $minuend->getType() ) {
162
-				$diff = $this->rangeInYears( $min, $max ) && $minuend->getType() === 'time' ?
163
-					$this->rangeCheckerHelper->getDifferenceInYears( $minuend, $subtrahend ) :
164
-					$this->rangeCheckerHelper->getDifference( $minuend, $subtrahend );
161
+			if ($subtrahend->getType() === $minuend->getType()) {
162
+				$diff = $this->rangeInYears($min, $max) && $minuend->getType() === 'time' ?
163
+					$this->rangeCheckerHelper->getDifferenceInYears($minuend, $subtrahend) : $this->rangeCheckerHelper->getDifference($minuend, $subtrahend);
165 164
 
166
-				if ( $this->rangeCheckerHelper->getComparison( $min, $diff ) > 0 ||
167
-					$this->rangeCheckerHelper->getComparison( $diff, $max ) > 0
165
+				if ($this->rangeCheckerHelper->getComparison($min, $diff) > 0 ||
166
+					$this->rangeCheckerHelper->getComparison($diff, $max) > 0
168 167
 				) {
169 168
 					// at least one of $min, $max is set at this point, otherwise there could be no violation
170
-					$openness = $min !== null ? ( $max !== null ? '' : '-rightopen' ) : '-leftopen';
169
+					$openness = $min !== null ? ($max !== null ? '' : '-rightopen') : '-leftopen';
171 170
 					// possible message keys:
172 171
 					// wbqc-violation-message-diff-within-range
173 172
 					// wbqc-violation-message-diff-within-range-leftopen
174 173
 					// wbqc-violation-message-diff-within-range-rightopen
175
-					$message = ( new ViolationMessage( "wbqc-violation-message-diff-within-range$openness" ) )
176
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
177
-						->withDataValue( $minuend, Role::OBJECT )
178
-						->withEntityId( $otherSnak->getPropertyId(), Role::PREDICATE )
179
-						->withDataValue( $subtrahend, Role::OBJECT );
180
-					if ( $min !== null ) {
181
-						$message = $message->withDataValue( $min, Role::OBJECT );
174
+					$message = (new ViolationMessage("wbqc-violation-message-diff-within-range$openness"))
175
+						->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
176
+						->withDataValue($minuend, Role::OBJECT)
177
+						->withEntityId($otherSnak->getPropertyId(), Role::PREDICATE)
178
+						->withDataValue($subtrahend, Role::OBJECT);
179
+					if ($min !== null) {
180
+						$message = $message->withDataValue($min, Role::OBJECT);
182 181
 					}
183
-					if ( $max !== null ) {
184
-						$message = $message->withDataValue( $max, Role::OBJECT );
182
+					if ($max !== null) {
183
+						$message = $message->withDataValue($max, Role::OBJECT);
185 184
 					}
186 185
 					$status = CheckResult::STATUS_VIOLATION;
187 186
 				} else {
@@ -189,17 +188,17 @@  discard block
 block discarded – undo
189 188
 					$status = CheckResult::STATUS_COMPLIANCE;
190 189
 				}
191 190
 			} else {
192
-				$message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-must-have-equal-types' );
191
+				$message = new ViolationMessage('wbqc-violation-message-diff-within-range-must-have-equal-types');
193 192
 				$status = CheckResult::STATUS_VIOLATION;
194 193
 			}
195 194
 
196
-			return new CheckResult( $context, $constraint, $parameters, $status, $message );
195
+			return new CheckResult($context, $constraint, $parameters, $status, $message);
197 196
 		}
198 197
 
199
-		return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
198
+		return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
200 199
 	}
201 200
 
202
-	public function checkConstraintParameters( Constraint $constraint ) {
201
+	public function checkConstraintParameters(Constraint $constraint) {
203 202
 		$constraintParameters = $constraint->getConstraintParameters();
204 203
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
205 204
 		$exceptions = [];
@@ -208,7 +207,7 @@  discard block
 block discarded – undo
208 207
 				$constraintParameters,
209 208
 				$constraintTypeItemId
210 209
 			);
211
-		} catch ( ConstraintParameterException $e ) {
210
+		} catch (ConstraintParameterException $e) {
212 211
 			$exceptions[] = $e;
213 212
 		}
214 213
 		try {
@@ -216,7 +215,7 @@  discard block
 block discarded – undo
216 215
 				$constraintParameters,
217 216
 				$constraintTypeItemId
218 217
 			);
219
-		} catch ( ConstraintParameterException $e ) {
218
+		} catch (ConstraintParameterException $e) {
220 219
 			$exceptions[] = $e;
221 220
 		}
222 221
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ValueTypeChecker.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
91 91
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
92 92
 	 * @return CheckResult
93 93
 	 */
94
-	public function checkConstraint( Context $context, Constraint $constraint ) {
95
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
96
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
94
+	public function checkConstraint(Context $context, Constraint $constraint) {
95
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
96
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
97 97
 		}
98 98
 
99 99
 		$parameters = [];
@@ -105,8 +105,8 @@  discard block
 block discarded – undo
105 105
 			$constraintTypeItemId
106 106
 		);
107 107
 		$parameters['class'] = array_map(
108
-			function( $id ) {
109
-				return new ItemId( $id );
108
+			function($id) {
109
+				return new ItemId($id);
110 110
 			},
111 111
 			$classes
112 112
 		);
@@ -116,19 +116,19 @@  discard block
 block discarded – undo
116 116
 			$constraintTypeItemId
117 117
 		);
118 118
 		$relationIds = [];
119
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
120
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
119
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
120
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
121 121
 		}
122
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
123
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
122
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
123
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
124 124
 		}
125
-		$parameters['relation'] = [ $relation ];
125
+		$parameters['relation'] = [$relation];
126 126
 
127 127
 		$snak = $context->getSnak();
128 128
 
129
-		if ( !$snak instanceof PropertyValueSnak ) {
129
+		if (!$snak instanceof PropertyValueSnak) {
130 130
 			// nothing to check
131
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
131
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
132 132
 		}
133 133
 
134 134
 		$dataValue = $snak->getDataValue();
@@ -137,23 +137,23 @@  discard block
 block discarded – undo
137 137
 		 * error handling:
138 138
 		 *   type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid'
139 139
 		 */
140
-		if ( !$dataValue instanceof EntityIdValue ) {
141
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
142
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
143
-				->withDataValueType( 'wikibase-entityid' );
144
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
140
+		if (!$dataValue instanceof EntityIdValue) {
141
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
142
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
143
+				->withDataValueType('wikibase-entityid');
144
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
145 145
 		}
146 146
 
147 147
 		try {
148
-			$item = $this->entityLookup->getEntity( $dataValue->getEntityId() );
149
-		} catch ( UnresolvedEntityRedirectException $e ) {
148
+			$item = $this->entityLookup->getEntity($dataValue->getEntityId());
149
+		} catch (UnresolvedEntityRedirectException $e) {
150 150
 			// Edge case (double redirect): Pretend the entity doesn't exist
151 151
 			$item = null;
152 152
 		}
153 153
 
154
-		if ( !( $item instanceof StatementListProvidingEntity ) ) {
155
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
156
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
154
+		if (!($item instanceof StatementListProvidingEntity)) {
155
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
156
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
157 157
 		}
158 158
 
159 159
 		$statements = $item->getStatements();
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 			$classes
165 165
 		);
166 166
 
167
-		if ( $result->getBool() ) {
167
+		if ($result->getBool()) {
168 168
 			$message = null;
169 169
 			$status = CheckResult::STATUS_COMPLIANCE;
170 170
 		} else {
@@ -178,11 +178,11 @@  discard block
 block discarded – undo
178 178
 			$status = CheckResult::STATUS_VIOLATION;
179 179
 		}
180 180
 
181
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
182
-			->withMetadata( $result->getMetadata() );
181
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
182
+			->withMetadata($result->getMetadata());
183 183
 	}
184 184
 
185
-	public function checkConstraintParameters( Constraint $constraint ) {
185
+	public function checkConstraintParameters(Constraint $constraint) {
186 186
 		$constraintParameters = $constraint->getConstraintParameters();
187 187
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
188 188
 		$exceptions = [];
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 				$constraintParameters,
192 192
 				$constraintTypeItemId
193 193
 			);
194
-		} catch ( ConstraintParameterException $e ) {
194
+		} catch (ConstraintParameterException $e) {
195 195
 			$exceptions[] = $e;
196 196
 		}
197 197
 		try {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 				$constraintParameters,
200 200
 				$constraintTypeItemId
201 201
 			);
202
-		} catch ( ConstraintParameterException $e ) {
202
+		} catch (ConstraintParameterException $e) {
203 203
 			$exceptions[] = $e;
204 204
 		}
205 205
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/RangeCheckerHelper.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 		$this->config = $config;
54 54
 		$this->timeParser = new IsoTimestampParser();
55 55
 		$this->timeCalculator = new TimeValueCalculator();
56
-		$this->timeValueComparer = new TimeValueComparer( $this->timeCalculator );
56
+		$this->timeValueComparer = new TimeValueComparer($this->timeCalculator);
57 57
 		$this->unitConverter = $unitConverter;
58 58
 	}
59 59
 
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
 	 * @param UnboundedQuantityValue $value
62 62
 	 * @return UnboundedQuantityValue $value converted to standard units if possible, otherwise unchanged $value.
63 63
 	 */
64
-	private function standardize( UnboundedQuantityValue $value ) {
65
-		if ( $this->unitConverter !== null ) {
66
-			$standard = $this->unitConverter->toStandardUnits( $value );
67
-			if ( $standard !== null ) {
64
+	private function standardize(UnboundedQuantityValue $value) {
65
+		if ($this->unitConverter !== null) {
66
+			$standard = $this->unitConverter->toStandardUnits($value);
67
+			if ($standard !== null) {
68 68
 				return $standard;
69 69
 			} else {
70 70
 				return $value;
@@ -86,33 +86,33 @@  discard block
 block discarded – undo
86 86
 	 *                 when $lhs is respectively less than, equal to, or greater than $rhs.
87 87
 	 *                 (In other words, just like the “spaceship” operator <=>.)
88 88
 	 */
89
-	public function getComparison( DataValue $lhs = null, DataValue $rhs = null ) {
90
-		if ( $lhs === null || $rhs === null ) {
89
+	public function getComparison(DataValue $lhs = null, DataValue $rhs = null) {
90
+		if ($lhs === null || $rhs === null) {
91 91
 			return 0;
92 92
 		}
93 93
 
94
-		if ( $lhs->getType() !== $rhs->getType() ) {
95
-			throw new InvalidArgumentException( 'Different data value types' );
94
+		if ($lhs->getType() !== $rhs->getType()) {
95
+			throw new InvalidArgumentException('Different data value types');
96 96
 		}
97 97
 
98
-		switch ( $lhs->getType() ) {
98
+		switch ($lhs->getType()) {
99 99
 			case 'time':
100 100
 				/** @var TimeValue $lhs */
101 101
 				/** @var TimeValue $rhs */
102 102
 				'@phan-var TimeValue $lhs';
103 103
 				'@phan-var TimeValue $rhs';
104
-				return $this->timeValueComparer->getComparison( $lhs, $rhs );
104
+				return $this->timeValueComparer->getComparison($lhs, $rhs);
105 105
 			case 'quantity':
106 106
 				/** @var QuantityValue|UnboundedQuantityValue $lhs */
107 107
 				/** @var QuantityValue|UnboundedQuantityValue $rhs */
108 108
 				'@phan-var QuantityValue|UnboundedQuantityValue $lhs';
109 109
 				'@phan-var QuantityValue|UnboundedQuantityValue $rhs';
110
-				$lhsStandard = $this->standardize( $lhs );
111
-				$rhsStandard = $this->standardize( $rhs );
112
-				return $lhsStandard->getAmount()->compare( $rhsStandard->getAmount() );
110
+				$lhsStandard = $this->standardize($lhs);
111
+				$rhsStandard = $this->standardize($rhs);
112
+				return $lhsStandard->getAmount()->compare($rhsStandard->getAmount());
113 113
 		}
114 114
 
115
-		throw new InvalidArgumentException( 'Unsupported data value type' );
115
+		throw new InvalidArgumentException('Unsupported data value type');
116 116
 	}
117 117
 
118 118
 	/**
@@ -127,71 +127,71 @@  discard block
 block discarded – undo
127 127
 	 * @throws InvalidArgumentException if the values do not both have the same, supported data value type
128 128
 	 * @return UnboundedQuantityValue
129 129
 	 */
130
-	public function getDifference( DataValue $minuend, DataValue $subtrahend ) {
131
-		if ( $minuend->getType() === 'time' && $subtrahend->getType() === 'time' ) {
132
-			$minuendSeconds = $this->timeCalculator->getTimestamp( $minuend );
133
-			$subtrahendSeconds = $this->timeCalculator->getTimestamp( $subtrahend );
130
+	public function getDifference(DataValue $minuend, DataValue $subtrahend) {
131
+		if ($minuend->getType() === 'time' && $subtrahend->getType() === 'time') {
132
+			$minuendSeconds = $this->timeCalculator->getTimestamp($minuend);
133
+			$subtrahendSeconds = $this->timeCalculator->getTimestamp($subtrahend);
134 134
 			return UnboundedQuantityValue::newFromNumber(
135 135
 				$minuendSeconds - $subtrahendSeconds,
136
-				$this->config->get( 'WBQualityConstraintsSecondUnit' )
136
+				$this->config->get('WBQualityConstraintsSecondUnit')
137 137
 			);
138 138
 		}
139
-		if ( $minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity' ) {
140
-			$minuendStandard = $this->standardize( $minuend );
141
-			$subtrahendStandard = $this->standardize( $subtrahend );
139
+		if ($minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity') {
140
+			$minuendStandard = $this->standardize($minuend);
141
+			$subtrahendStandard = $this->standardize($subtrahend);
142 142
 			$minuendValue = $minuendStandard->getAmount()->getValueFloat();
143 143
 			$subtrahendValue = $subtrahendStandard->getAmount()->getValueFloat();
144 144
 			$diff = $minuendValue - $subtrahendValue;
145 145
 			// we don’t check whether both quantities have the same standard unit –
146 146
 			// that’s the job of a different constraint type, Units (T164372)
147
-			return UnboundedQuantityValue::newFromNumber( $diff, $minuendStandard->getUnit() );
147
+			return UnboundedQuantityValue::newFromNumber($diff, $minuendStandard->getUnit());
148 148
 		}
149 149
 
150
-		throw new InvalidArgumentException( 'Unsupported or different data value types' );
150
+		throw new InvalidArgumentException('Unsupported or different data value types');
151 151
 	}
152 152
 
153
-	public function getDifferenceInYears( TimeValue $minuend, TimeValue $subtrahend ) {
154
-		if ( !preg_match( '/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches ) ||
155
-			!preg_match( '/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches )
153
+	public function getDifferenceInYears(TimeValue $minuend, TimeValue $subtrahend) {
154
+		if (!preg_match('/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches) ||
155
+			!preg_match('/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches)
156 156
 		) {
157
-			throw new InvalidArgumentException( 'TimeValue::getTime() did not match expected format' );
157
+			throw new InvalidArgumentException('TimeValue::getTime() did not match expected format');
158 158
 		}
159
-		$minuendYear = (float)$minuendMatches[1];
160
-		$subtrahendYear = (float)$subtrahendMatches[1];
159
+		$minuendYear = (float) $minuendMatches[1];
160
+		$subtrahendYear = (float) $subtrahendMatches[1];
161 161
 		$minuendRest = $minuendMatches[2];
162 162
 		$subtrahendRest = $subtrahendMatches[2];
163 163
 
164 164
 		// calculate difference of years
165 165
 		$diff = $minuendYear - $subtrahendYear;
166
-		if ( $minuendYear > 0.0 && $subtrahendYear < 0.0 ) {
166
+		if ($minuendYear > 0.0 && $subtrahendYear < 0.0) {
167 167
 			$diff -= 1.0; // there is no year 0, remove it from difference
168
-		} elseif ( $minuendYear < 0.0 && $subtrahendYear > 0.0 ) {
168
+		} elseif ($minuendYear < 0.0 && $subtrahendYear > 0.0) {
169 169
 			$diff -= -1.0; // there is no year 0, remove it from negative difference
170 170
 		}
171 171
 
172 172
 		// adjust for date within year by parsing the month-day part within the same year
173
-		$minuendDateValue = $this->timeParser->parse( '+0000000000001970-' . $minuendRest );
174
-		$subtrahendDateValue = $this->timeParser->parse( '+0000000000001970-' . $subtrahendRest );
175
-		$minuendDateSeconds = $this->timeCalculator->getTimestamp( $minuendDateValue );
176
-		$subtrahendDateSeconds = $this->timeCalculator->getTimestamp( $subtrahendDateValue );
177
-		if ( $minuendDateSeconds < $subtrahendDateSeconds ) {
173
+		$minuendDateValue = $this->timeParser->parse('+0000000000001970-'.$minuendRest);
174
+		$subtrahendDateValue = $this->timeParser->parse('+0000000000001970-'.$subtrahendRest);
175
+		$minuendDateSeconds = $this->timeCalculator->getTimestamp($minuendDateValue);
176
+		$subtrahendDateSeconds = $this->timeCalculator->getTimestamp($subtrahendDateValue);
177
+		if ($minuendDateSeconds < $subtrahendDateSeconds) {
178 178
 			// difference in the last year is actually less than one full year
179 179
 			// e. g. 1975-03-01 - 1974-09-01 is just six months
180 180
 			// (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough)
181 181
 			$diff -= 0.5;
182
-		} elseif ( $minuendDateSeconds > $subtrahendDateSeconds ) {
182
+		} elseif ($minuendDateSeconds > $subtrahendDateSeconds) {
183 183
 			// difference in the last year is actually more than one full year
184 184
 			// e. g. 1975-09-01 - 1974-03-01 is 18 months
185 185
 			// (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough)
186 186
 			$diff += 0.5;
187 187
 		}
188 188
 
189
-		$unit = $this->config->get( 'WBQualityConstraintsYearUnit' );
190
-		return UnboundedQuantityValue::newFromNumber( $diff, $unit );
189
+		$unit = $this->config->get('WBQualityConstraintsYearUnit');
190
+		return UnboundedQuantityValue::newFromNumber($diff, $unit);
191 191
 	}
192 192
 
193
-	public function isFutureTime( TimeValue $timeValue ) {
194
-		return $this->timeValueComparer->isFutureTime( $timeValue );
193
+	public function isFutureTime(TimeValue $timeValue) {
194
+		return $this->timeValueComparer->isFutureTime($timeValue);
195 195
 	}
196 196
 
197 197
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/TypeCheckerHelper.php 1 patch
Spacing   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -80,23 +80,23 @@  discard block
 block discarded – undo
80 80
 	 * @return bool
81 81
 	 * @throws OverflowException if $entitiesChecked exceeds the configured limit
82 82
 	 */
83
-	private function isSubclassOf( EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0 ) {
84
-		$maxEntities = $this->config->get( 'WBQualityConstraintsTypeCheckMaxEntities' );
83
+	private function isSubclassOf(EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0) {
84
+		$maxEntities = $this->config->get('WBQualityConstraintsTypeCheckMaxEntities');
85 85
 		if ( ++$entitiesChecked > $maxEntities ) {
86
-			throw new OverflowException( 'Too many entities to check' );
86
+			throw new OverflowException('Too many entities to check');
87 87
 		}
88 88
 
89
-		$item = $this->entityLookup->getEntity( $comparativeClass );
90
-		if ( !( $item instanceof StatementListProvider ) ) {
89
+		$item = $this->entityLookup->getEntity($comparativeClass);
90
+		if (!($item instanceof StatementListProvider)) {
91 91
 			return false; // lookup failed, probably because item doesn't exist
92 92
 		}
93 93
 
94
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
94
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfId');
95 95
 		/** @var Statement $statement */
96
-		foreach ( $item->getStatements()->getByPropertyId( new PropertyId( $subclassId ) ) as $statement ) {
96
+		foreach ($item->getStatements()->getByPropertyId(new PropertyId($subclassId)) as $statement) {
97 97
 			$mainSnak = $statement->getMainSnak();
98 98
 
99
-			if ( !( $this->hasCorrectType( $mainSnak ) ) ) {
99
+			if (!($this->hasCorrectType($mainSnak))) {
100 100
 				continue;
101 101
 			}
102 102
 			/** @var PropertyValueSnak $mainSnak */
@@ -106,11 +106,11 @@  discard block
 block discarded – undo
106 106
 			'@phan-var EntityIdValue $dataValue';
107 107
 			$comparativeClass = $dataValue->getEntityId();
108 108
 
109
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
109
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
110 110
 				return true;
111 111
 			}
112 112
 
113
-			if ( $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ) ) {
113
+			if ($this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked)) {
114 114
 				return true;
115 115
 			}
116 116
 		}
@@ -131,48 +131,48 @@  discard block
 block discarded – undo
131 131
 	 * @return CachedBool
132 132
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
133 133
 	 */
134
-	public function isSubclassOfWithSparqlFallback( EntityId $comparativeClass, array $classesToCheck ) {
134
+	public function isSubclassOfWithSparqlFallback(EntityId $comparativeClass, array $classesToCheck) {
135 135
 		try {
136 136
 			$entitiesChecked = 0;
137
-			$start1 = microtime( true );
138
-			$isSubclass = $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked );
139
-			$end1 = microtime( true );
137
+			$start1 = microtime(true);
138
+			$isSubclass = $this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked);
139
+			$end1 = microtime(true);
140 140
 			$this->dataFactory->timing(
141 141
 				'wikibase.quality.constraints.type.php.success.timing',
142
-				( $end1 - $start1 ) * 1000
142
+				($end1 - $start1) * 1000
143 143
 			);
144 144
 			$this->dataFactory->timing( // not really a timing, but works like one (we want percentiles etc.)
145 145
 				'wikibase.quality.constraints.type.php.success.entities',
146 146
 				$entitiesChecked
147 147
 			);
148 148
 
149
-			return new CachedBool( $isSubclass, Metadata::blank() );
150
-		} catch ( OverflowException $e ) {
151
-			$end1 = microtime( true );
149
+			return new CachedBool($isSubclass, Metadata::blank());
150
+		} catch (OverflowException $e) {
151
+			$end1 = microtime(true);
152 152
 			$this->dataFactory->timing(
153 153
 				'wikibase.quality.constraints.type.php.overflow.timing',
154
-				( $end1 - $start1 ) * 1000
154
+				($end1 - $start1) * 1000
155 155
 			);
156 156
 
157
-			if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
157
+			if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
158 158
 				$this->dataFactory->increment(
159 159
 					'wikibase.quality.constraints.sparql.typeFallback'
160 160
 				);
161 161
 
162
-				$start2 = microtime( true );
162
+				$start2 = microtime(true);
163 163
 				$hasType = $this->sparqlHelper->hasType(
164 164
 					$comparativeClass->getSerialization(),
165 165
 					$classesToCheck
166 166
 				);
167
-				$end2 = microtime( true );
167
+				$end2 = microtime(true);
168 168
 				$this->dataFactory->timing(
169 169
 					'wikibase.quality.constraints.type.sparql.success.timing',
170
-					( $end2 - $start2 ) * 1000
170
+					($end2 - $start2) * 1000
171 171
 				);
172 172
 
173 173
 				return $hasType;
174 174
 			} else {
175
-				return new CachedBool( false, Metadata::blank() );
175
+				return new CachedBool(false, Metadata::blank());
176 176
 			}
177 177
 		}
178 178
 	}
@@ -190,13 +190,13 @@  discard block
 block discarded – undo
190 190
 	 * @return CachedBool
191 191
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
192 192
 	 */
193
-	public function hasClassInRelation( StatementList $statements, array $relationIds, array $classesToCheck ) {
193
+	public function hasClassInRelation(StatementList $statements, array $relationIds, array $classesToCheck) {
194 194
 		$metadatas = [];
195 195
 
196
-		foreach ( $this->getStatementsByPropertyIds( $statements, $relationIds ) as $statement ) {
196
+		foreach ($this->getStatementsByPropertyIds($statements, $relationIds) as $statement) {
197 197
 			$mainSnak = $statement->getMainSnak();
198 198
 
199
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
199
+			if (!$this->hasCorrectType($mainSnak)) {
200 200
 				continue;
201 201
 			}
202 202
 			/** @var PropertyValueSnak $mainSnak */
@@ -206,24 +206,24 @@  discard block
 block discarded – undo
206 206
 			'@phan-var EntityIdValue $dataValue';
207 207
 			$comparativeClass = $dataValue->getEntityId();
208 208
 
209
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
209
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
210 210
 				// discard $metadatas, we know this is fresh
211
-				return new CachedBool( true, Metadata::blank() );
211
+				return new CachedBool(true, Metadata::blank());
212 212
 			}
213 213
 
214
-			$result = $this->isSubclassOfWithSparqlFallback( $comparativeClass, $classesToCheck );
214
+			$result = $this->isSubclassOfWithSparqlFallback($comparativeClass, $classesToCheck);
215 215
 			$metadatas[] = $result->getMetadata();
216
-			if ( $result->getBool() ) {
216
+			if ($result->getBool()) {
217 217
 				return new CachedBool(
218 218
 					true,
219
-					Metadata::merge( $metadatas )
219
+					Metadata::merge($metadatas)
220 220
 				);
221 221
 			}
222 222
 		}
223 223
 
224 224
 		return new CachedBool(
225 225
 			false,
226
-			Metadata::merge( $metadatas )
226
+			Metadata::merge($metadatas)
227 227
 		);
228 228
 	}
229 229
 
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 	 * @return bool
233 233
 	 * @phan-assert PropertyValueSnak $mainSnak
234 234
 	 */
235
-	private function hasCorrectType( Snak $mainSnak ) {
235
+	private function hasCorrectType(Snak $mainSnak) {
236 236
 		return $mainSnak instanceof PropertyValueSnak
237 237
 			&& $mainSnak->getDataValue()->getType() === 'wikibase-entityid';
238 238
 	}
@@ -249,12 +249,12 @@  discard block
 block discarded – undo
249 249
 	) {
250 250
 		$statementArrays = [];
251 251
 
252
-		foreach ( $propertyIdSerializations as $propertyIdSerialization ) {
253
-			$propertyId = new PropertyId( $propertyIdSerialization );
254
-			$statementArrays[] = $statements->getByPropertyId( $propertyId )->toArray();
252
+		foreach ($propertyIdSerializations as $propertyIdSerialization) {
253
+			$propertyId = new PropertyId($propertyIdSerialization);
254
+			$statementArrays[] = $statements->getByPropertyId($propertyId)->toArray();
255 255
 		}
256 256
 
257
-		return call_user_func_array( 'array_merge', $statementArrays );
257
+		return call_user_func_array('array_merge', $statementArrays);
258 258
 	}
259 259
 
260 260
 	/**
@@ -266,10 +266,10 @@  discard block
 block discarded – undo
266 266
 	 *
267 267
 	 * @return ViolationMessage
268 268
 	 */
269
-	public function getViolationMessage( PropertyId $propertyId, EntityId $entityId, array $classes, $checker, $relation ) {
269
+	public function getViolationMessage(PropertyId $propertyId, EntityId $entityId, array $classes, $checker, $relation) {
270 270
 		$classes = array_map(
271
-			function( $itemIdSerialization ) {
272
-				return new ItemId( $itemIdSerialization );
271
+			function($itemIdSerialization) {
272
+				return new ItemId($itemIdSerialization);
273 273
 			},
274 274
 			$classes
275 275
 		);
@@ -281,10 +281,10 @@  discard block
 block discarded – undo
281 281
 		// wbqc-violation-message-valueType-instance
282 282
 		// wbqc-violation-message-valueType-subclass
283 283
 		// wbqc-violation-message-valueType-instanceOrSubclass
284
-		return ( new ViolationMessage( 'wbqc-violation-message-' . $checker . '-' . $relation ) )
285
-			->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
286
-			->withEntityId( $entityId, Role::SUBJECT )
287
-			->withEntityIdList( $classes, Role::OBJECT );
284
+		return (new ViolationMessage('wbqc-violation-message-'.$checker.'-'.$relation))
285
+			->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
286
+			->withEntityId($entityId, Role::SUBJECT)
287
+			->withEntityIdList($classes, Role::OBJECT);
288 288
 	}
289 289
 
290 290
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/ContextCursorSerializer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@  discard block
 block discarded – undo
13 13
 	 * @param ContextCursor $cursor
14 14
 	 * @return array
15 15
 	 */
16
-	public function serialize( ContextCursor $cursor ) {
17
-		if ( $cursor instanceof EntityContextCursor ) {
16
+	public function serialize(ContextCursor $cursor) {
17
+		if ($cursor instanceof EntityContextCursor) {
18 18
 			return [
19 19
 				't' => '\entity',
20 20
 				'i' => $cursor->getEntityId(),
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 			'h' => $cursor->getSnakHash(),
31 31
 		];
32 32
 
33
-		if ( $type === Context::TYPE_QUALIFIER || $type === Context::TYPE_REFERENCE ) {
33
+		if ($type === Context::TYPE_QUALIFIER || $type === Context::TYPE_REFERENCE) {
34 34
 			$serialization['P'] = $cursor->getSnakPropertyId();
35
-			if ( $type === Context::TYPE_REFERENCE ) {
35
+			if ($type === Context::TYPE_REFERENCE) {
36 36
 				/** @var ReferenceContextCursor $cursor */
37 37
 				'@phan-var ReferenceContextCursor $cursor';
38 38
 				$serialization['r'] = $cursor->getReferenceHash();
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/RangeChecker.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 	 * @throws ConstraintParameterException
85 85
 	 * @return CheckResult
86 86
 	 */
87
-	public function checkConstraint( Context $context, Constraint $constraint ) {
88
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
89
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
87
+	public function checkConstraint(Context $context, Constraint $constraint) {
88
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
89
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
90 90
 		}
91 91
 
92 92
 		$parameters = [];
@@ -94,28 +94,28 @@  discard block
 block discarded – undo
94 94
 
95 95
 		$snak = $context->getSnak();
96 96
 
97
-		if ( !$snak instanceof PropertyValueSnak ) {
97
+		if (!$snak instanceof PropertyValueSnak) {
98 98
 			// nothing to check
99
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
99
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
100 100
 		}
101 101
 
102 102
 		$dataValue = $snak->getDataValue();
103 103
 
104
-		list( $min, $max ) = $this->parseRangeParameter(
104
+		list($min, $max) = $this->parseRangeParameter(
105 105
 			$constraintParameters,
106 106
 			$constraint->getConstraintTypeItemId(),
107 107
 			$dataValue->getType()
108 108
 		);
109 109
 		$parameterKey = $dataValue->getType() === 'quantity' ? 'quantity' : 'date';
110
-		if ( $min !== null ) {
111
-			$parameters['minimum_' . $parameterKey] = [ $min ];
110
+		if ($min !== null) {
111
+			$parameters['minimum_'.$parameterKey] = [$min];
112 112
 		}
113
-		if ( $max !== null ) {
114
-			$parameters['maximum_' . $parameterKey] = [ $max ];
113
+		if ($max !== null) {
114
+			$parameters['maximum_'.$parameterKey] = [$max];
115 115
 		}
116 116
 
117
-		if ( $this->rangeCheckerHelper->getComparison( $min, $dataValue ) > 0 ||
118
-			 $this->rangeCheckerHelper->getComparison( $dataValue, $max ) > 0
117
+		if ($this->rangeCheckerHelper->getComparison($min, $dataValue) > 0 ||
118
+			 $this->rangeCheckerHelper->getComparison($dataValue, $max) > 0
119 119
 		) {
120 120
 			$message = $this->getViolationMessage(
121 121
 				$context->getSnak()->getPropertyId(),
@@ -131,16 +131,16 @@  discard block
 block discarded – undo
131 131
 
132 132
 		if (
133 133
 			$dataValue instanceof TimeValue &&
134
-			( $min instanceof NowValue || $max instanceof NowValue ) &&
135
-			$this->rangeCheckerHelper->isFutureTime( $dataValue )
134
+			($min instanceof NowValue || $max instanceof NowValue) &&
135
+			$this->rangeCheckerHelper->isFutureTime($dataValue)
136 136
 		) {
137
-			$dependencyMetadata = DependencyMetadata::ofFutureTime( $dataValue );
137
+			$dependencyMetadata = DependencyMetadata::ofFutureTime($dataValue);
138 138
 		} else {
139 139
 			$dependencyMetadata = DependencyMetadata::blank();
140 140
 		}
141 141
 
142
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
143
-			->withMetadata( Metadata::ofDependencyMetadata( $dependencyMetadata ) );
142
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
143
+			->withMetadata(Metadata::ofDependencyMetadata($dependencyMetadata));
144 144
 	}
145 145
 
146 146
 	/**
@@ -151,8 +151,8 @@  discard block
 block discarded – undo
151 151
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
152 152
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
153 153
 	 */
154
-	private function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) {
155
-		switch ( $type ) {
154
+	private function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) {
155
+		switch ($type) {
156 156
 			case 'quantity':
157 157
 				return $this->constraintParameterParser->parseQuantityRangeParameter(
158 158
 					$constraintParameters,
@@ -166,10 +166,10 @@  discard block
 block discarded – undo
166 166
 		}
167 167
 
168 168
 		throw new ConstraintParameterException(
169
-			( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
170
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
171
-				->withDataValueType( 'quantity' )
172
-				->withDataValueType( 'time' )
169
+			(new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
170
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
171
+				->withDataValueType('quantity')
172
+				->withDataValueType('time')
173 173
 		);
174 174
 	}
175 175
 
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 	 *
182 182
 	 * @return ViolationMessage
183 183
 	 */
184
-	private function getViolationMessage( PropertyId $predicate, DataValue $value, $min, $max ) {
184
+	private function getViolationMessage(PropertyId $predicate, DataValue $value, $min, $max) {
185 185
 		// possible message keys:
186 186
 		// wbqc-violation-message-range-quantity-closed
187 187
 		// wbqc-violation-message-range-quantity-leftopen
@@ -194,39 +194,39 @@  discard block
 block discarded – undo
194 194
 		// wbqc-violation-message-range-time-rightopen
195 195
 		// wbqc-violation-message-range-time-rightopen-leftnow
196 196
 		$messageKey = 'wbqc-violation-message-range';
197
-		$messageKey .= '-' . $value->getType();
197
+		$messageKey .= '-'.$value->getType();
198 198
 		// at least one of $min, $max is set, otherwise there could be no violation
199
-		$messageKey .= '-' . ( $min !== null ? ( $max !== null ? 'closed' : 'rightopen' ) : 'leftopen' );
200
-		if ( $min instanceof NowValue ) {
199
+		$messageKey .= '-'.($min !== null ? ($max !== null ? 'closed' : 'rightopen') : 'leftopen');
200
+		if ($min instanceof NowValue) {
201 201
 			$messageKey .= '-leftnow';
202
-		} elseif ( $max instanceof NowValue ) {
202
+		} elseif ($max instanceof NowValue) {
203 203
 			$messageKey .= '-rightnow';
204 204
 		}
205
-		$message = ( new ViolationMessage( $messageKey ) )
206
-			->withEntityId( $predicate, Role::PREDICATE )
207
-			->withDataValue( $value, Role::OBJECT );
208
-		if ( $min !== null && !( $min instanceof NowValue ) ) {
209
-			$message = $message->withDataValue( $min, Role::OBJECT );
205
+		$message = (new ViolationMessage($messageKey))
206
+			->withEntityId($predicate, Role::PREDICATE)
207
+			->withDataValue($value, Role::OBJECT);
208
+		if ($min !== null && !($min instanceof NowValue)) {
209
+			$message = $message->withDataValue($min, Role::OBJECT);
210 210
 		}
211
-		if ( $max !== null && !( $max instanceof NowValue ) ) {
212
-			$message = $message->withDataValue( $max, Role::OBJECT );
211
+		if ($max !== null && !($max instanceof NowValue)) {
212
+			$message = $message->withDataValue($max, Role::OBJECT);
213 213
 		}
214 214
 		return $message;
215 215
 	}
216 216
 
217
-	public function checkConstraintParameters( Constraint $constraint ) {
217
+	public function checkConstraintParameters(Constraint $constraint) {
218 218
 		$constraintParameters = $constraint->getConstraintParameters();
219 219
 		$exceptions = [];
220 220
 		try {
221 221
 			// we don’t have a data value here, so get the type from the property instead
222 222
 			// (the distinction between data type and data value type is irrelevant for 'quantity' and 'time')
223
-			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty( $constraint->getPropertyId() );
223
+			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty($constraint->getPropertyId());
224 224
 			$this->parseRangeParameter(
225 225
 				$constraintParameters,
226 226
 				$constraint->getConstraintTypeItemId(),
227 227
 				$type
228 228
 			);
229
-		} catch ( ConstraintParameterException $e ) {
229
+		} catch (ConstraintParameterException $e) {
230 230
 			$exceptions[] = $e;
231 231
 		}
232 232
 		return $exceptions;
Please login to merge, or discard this patch.