wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Cache/DependencyMetadata.php

Spacing +12 added lines, -12 removed lines

@@ -37,7 +37,7 @@ 
 	 * @param EntityId $entityId An entity ID from which the value was derived.
 	 * @return self Indication that a value was derived from the entity with the given ID.
 	 */
-	public static function ofEntityId( EntityId $entityId ) {
+	public static function ofEntityId(EntityId $entityId) {
 		$ret = new self;
 		$ret->entityIds[] = $entityId;
 		return $ret;
@@ -49,7 +49,7 @@ 
 	 * @return self Indication that a value will only remain valid
 	 * as long as the given time value is in the future, not in the past.
 	 */
-	public static function ofFutureTime( TimeValue $timeValue ) {
+	public static function ofFutureTime(TimeValue $timeValue) {
 		$ret = new self;
 		$ret->timeValue = $timeValue;
 		return $ret;
@@ -59,17 +59,17 @@ 
 	 * @param self[] $metadatas
 	 * @return self
 	 */
-	public static function merge( array $metadatas ) {
-		Assert::parameterElementType( self::class, $metadatas, '$metadatas' );
+	public static function merge(array $metadatas) {
+		Assert::parameterElementType(self::class, $metadatas, '$metadatas');
 		$ret = new self;
 		$entityIds = [];
-		foreach ( $metadatas as $metadata ) {
-			foreach ( $metadata->entityIds as $entityId ) {
+		foreach ($metadatas as $metadata) {
+			foreach ($metadata->entityIds as $entityId) {
 				$entityIds[$entityId->getSerialization()] = $entityId;
 			}
-			$ret->timeValue = self::minTimeValue( $ret->timeValue, $metadata->timeValue );
+			$ret->timeValue = self::minTimeValue($ret->timeValue, $metadata->timeValue);
 		}
-		$ret->entityIds = array_values( $entityIds );
+		$ret->entityIds = array_values($entityIds);
 		return $ret;
 	}
 
@@ -78,14 +78,14 @@ 
 	 * @param TimeValue|null $t2
 	 * @return TimeValue|null
 	 */
-	private static function minTimeValue( TimeValue $t1 = null, TimeValue $t2 = null ) {
-		if ( $t1 === null ) {
+	private static function minTimeValue(TimeValue $t1 = null, TimeValue $t2 = null) {
+		if ($t1 === null) {
 			return $t2;
 		}
-		if ( $t2 === null ) {
+		if ($t2 === null) {
 			return $t1;
 		}
-		return ( new TimeValueComparer() )->getMinimum( $t1, $t2 );
+		return (new TimeValueComparer())->getMinimum($t1, $t2);
 	}
 
 	/**

src/ConstraintCheck/Helper/LoggingHelper.php

Spacing +20 added lines, -20 removed lines

@@ -47,8 +47,8 @@ 
 		$this->dataFactory = $dataFactory;
 		$this->logger = $logger;
 		$this->constraintCheckDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'),
 		];
 	}
 
@@ -74,46 +74,46 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 );
+		$constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1);
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
 		$this->dataFactory->timing(
-			'wikibase.quality.constraints.check.timing.' .
-				$constraintTypeItemId . '-' .
+			'wikibase.quality.constraints.check.timing.'.
+				$constraintTypeItemId.'-'.
 				$constraintCheckerClassShortName,
 			$durationSeconds * 1000
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		foreach ( $this->constraintCheckDurationLimits as $level => $limit ) {
+		foreach ($this->constraintCheckDurationLimits as $level => $limit) {
 			if (
 				// duration exceeds this limit
-				isset( $limit ) && $durationSeconds > $limit &&
+				isset($limit) && $durationSeconds > $limit &&
 				// this limit is longer than previous longest limit
-				( !isset( $limitSeconds ) || $limit > $limitSeconds )
+				(!isset($limitSeconds) || $limit > $limitSeconds)
 			) {
 				$limitSeconds = $limit;
 				$logLevel = $level;
 			}
 		}
 
-		if ( !isset( $limitSeconds ) ) {
+		if (!isset($limitSeconds)) {
 			return;
 		}
-		if ( $context->getType() !== Context::TYPE_STATEMENT ) {
+		if ($context->getType() !== Context::TYPE_STATEMENT) {
 			// TODO log less details but still log something
 			return;
 		}
 
 		$resultMessage = $result->getMessage();
-		if ( $resultMessage instanceof ViolationMessage ) {
+		if ($resultMessage instanceof ViolationMessage) {
 			$resultMessage = $resultMessage->getMessageKey();
 		}
 
 		$this->logger->log(
 			$logLevel,
-			'Constraint check with {constraintCheckerClassShortName} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Constraint check with {constraintCheckerClassShortName} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -140,7 +140,7 @@ 
 	 *
 	 * @param EntityId $entityId
 	 */
-	public function logCheckConstraintsCacheHit( EntityId $entityId ) {
+	public function logCheckConstraintsCacheHit(EntityId $entityId) {
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.cache.entity.hit'
 		);
@@ -151,10 +151,10 @@ 
 	 *
 	 * @param EntityId[] $entityIds
 	 */
-	public function logCheckConstraintsCacheMisses( array $entityIds ) {
+	public function logCheckConstraintsCacheMisses(array $entityIds) {
 		$this->dataFactory->updateCount(
 			'wikibase.quality.constraints.cache.entity.miss',
-			count( $entityIds )
+			count($entityIds)
 		);
 	}
 
@@ -181,16 +181,16 @@ 
 	 * @param EntityId[] $entityIds
 	 * @param int $maxRevisionIds
 	 */
-	public function logHugeDependencyMetadata( array $entityIds, $maxRevisionIds ) {
+	public function logHugeDependencyMetadata(array $entityIds, $maxRevisionIds) {
 		$this->logger->log(
 			'warning',
-			'Dependency metadata for constraint check result has huge set of entity IDs ' .
-			'(count ' . count( $entityIds ) . ', limit ' . $maxRevisionIds . '); ' .
+			'Dependency metadata for constraint check result has huge set of entity IDs '.
+			'(count '.count($entityIds).', limit '.$maxRevisionIds.'); '.
 			'caching disabled for this check result.',
 			[
 				'loggingMethod' => __METHOD__,
 				'entityIds' => array_map(
-					function ( EntityId $entityId ) {
+					function(EntityId $entityId) {
 						return $entityId->getSerialization();
 					},
 					$entityIds

src/ConstraintCheck/Context/ContextCursor.php

Spacing +1 added lines, -1 removed lines

@@ -86,6 +86,6 @@
 	 * @param array|null $result
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container );
+	public function storeCheckResultInArray(array $result = null, array &$container);
 
 }

src/ConstraintCheck/Result/CheckResult.php

Spacing +5 added lines, -5 removed lines

@@ -122,12 +122,12 @@ 
 		$status = self::STATUS_TODO,
 		$message = null
 	) {
-		if ( $contextCursor instanceof Context ) {
+		if ($contextCursor instanceof Context) {
 			$context = $contextCursor;
 			$this->contextCursor = $context->getCursor();
 			$this->snakType = $context->getSnak()->getType();
 			$mainSnak = $context->getSnak();
-			if ( $mainSnak instanceof PropertyValueSnak ) {
+			if ($mainSnak instanceof PropertyValueSnak) {
 				$this->dataValue = $mainSnak->getDataValue();
 			} else {
 				$this->dataValue = null;
@@ -190,7 +190,7 @@ 
 	 * @param string $key
 	 * @param string $value
 	 */
-	public function addParameter( $key, $value ) {
+	public function addParameter($key, $value) {
 		$this->parameters[$key][] = $value;
 	}
 
@@ -204,7 +204,7 @@ 
 	/**
 	 * @param string $status
 	 */
-	public function setStatus( $status ) {
+	public function setStatus($status) {
 		$this->status = $status;
 	}
 
@@ -219,7 +219,7 @@ 
 	 * @param Metadata $metadata
 	 * @return self
 	 */
-	public function withMetadata( Metadata $metadata ) {
+	public function withMetadata(Metadata $metadata) {
 		$this->metadata = $metadata;
 		return $this;
 	}

src/ConstraintCheck/Context/QualifierContext.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -33,7 +33,7 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +4 added lines, -4 removed lines

@@ -20,9 +20,9 @@ 
 	 */
 	private $statement;
 
-	public function __construct( EntityDocument $entity, Statement $statement ) {
-		Assert::parameterType( StatementListProvider::class, $entity, '$entity' );
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(EntityDocument $entity, Statement $statement) {
+		Assert::parameterType(StatementListProvider::class, $entity, '$entity');
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -43,7 +43,7 @@ 
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
 		return $statements
-			->getByRank( [ Statement::RANK_NORMAL, Statement::RANK_PREFERRED ] )
+			->getByRank([Statement::RANK_NORMAL, Statement::RANK_PREFERRED])
 			->getMainSnaks();
 	}
 

src/ConstraintCheck/Context/ReferenceContext.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
 		Reference $reference,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 		$this->reference = $reference;
 	}
@@ -41,7 +41,7 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->reference->getSnaks();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {

src/WikibaseQualityConstraintsHooks.php

Spacing +31 added lines, -31 removed lines

@@ -28,36 +28,36 @@ 
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
-		$updater->addExtensionTable( 'wbqc_constraints', __DIR__ . '/../sql/create_wbqc_constraints.sql' );
-		$updater->addExtensionField( 'wbqc_constraints', 'constraint_id', __DIR__ . '/../sql/patch-wbqc_constraints-constraint_id.sql' );
+	public static function onCreateSchema(DatabaseUpdater $updater) {
+		$updater->addExtensionTable('wbqc_constraints', __DIR__.'/../sql/create_wbqc_constraints.sql');
+		$updater->addExtensionField('wbqc_constraints', 'constraint_id', __DIR__.'/../sql/patch-wbqc_constraints-constraint_id.sql');
 	}
 
-	public static function onWikibaseChange( Change $change ) {
+	public static function onWikibaseChange(Change $change) {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-			self::isConstraintStatementsChange( $config, $change )
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
+			self::isConstraintStatementsChange($config, $change)
 		) {
 			/** @var EntityChange $change */
 			$title = Title::newMainPage();
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
 			JobQueueGroup::singleton()->push(
-				new JobSpecification( 'constraintsTableUpdate', $params, [], $title )
+				new JobSpecification('constraintsTableUpdate', $params, [], $title)
 			);
 		}
 	}
 
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
-		if ( !( $change instanceof EntityChange ) ||
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
+		if (!($change instanceof EntityChange) ||
 			 $change->getAction() !== EntityChange::UPDATE ||
-			 !( $change->getEntityId() instanceof PropertyId )
+			 !($change->getEntityId() instanceof PropertyId)
 		) {
 			return false;
 		}
 
 		$info = $change->getInfo();
 
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
+		if (!array_key_exists('compactDiff', $info)) {
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
 			// so we only know that the change *might* affect the constraint statements
 			return true;
@@ -66,18 +66,18 @@ 
 		/** @var EntityDiffChangedAspects $aspects */
 		$aspects = $info['compactDiff'];
 
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
 	}
 
-	public static function onArticlePurge( WikiPage $wikiPage ) {
+	public static function onArticlePurge(WikiPage $wikiPage) {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$entityContentFactory = $repo->getEntityContentFactory();
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
-			$entityId = $entityContentFactory->getEntityIdForTitle( $wikiPage->getTitle() );
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
+			$entityId = $entityContentFactory->getEntityIdForTitle($wikiPage->getTitle());
 			$resultsCache = ResultsCache::getDefaultInstance();
-			$resultsCache->delete( $entityId );
+			$resultsCache->delete($entityId);
 		}
 	}
 
@@ -86,18 +86,18 @@ 
 	 * @param int $timestamp UTC timestamp (seconds since the Epoch)
 	 * @return bool
 	 */
-	public static function isGadgetEnabledForUserName( $userName, $timestamp ) {
+	public static function isGadgetEnabledForUserName($userName, $timestamp) {
 		$initial = $userName[0];
 
-		if ( $initial === 'Z' ) {
+		if ($initial === 'Z') {
 			$firstWeek = 0;
-		} elseif ( $initial >= 'W' && $initial < 'Z' ) {
+		} elseif ($initial >= 'W' && $initial < 'Z') {
 			$firstWeek = 1;
-		} elseif ( $initial >= 'T' && $initial < 'W' ) {
+		} elseif ($initial >= 'T' && $initial < 'W') {
 			$firstWeek = 2;
-		} elseif ( $initial >= 'N' && $initial < 'T' ) {
+		} elseif ($initial >= 'N' && $initial < 'T') {
 			$firstWeek = 3;
-		} elseif ( $initial >= 'E' && $initial < 'N' ) {
+		} elseif ($initial >= 'E' && $initial < 'N') {
 			$firstWeek = 4;
 		} else {
 			$firstWeek = 5;
@@ -115,27 +115,27 @@ 
 		return $timestamp >= $threshold;
 	}
 
-	public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
+	public static function onBeforePageDisplay(OutputPage $out, Skin $skin) {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$lookup = $repo->getEntityNamespaceLookup();
 		$title = $out->getTitle();
-		if ( $title === null ) {
+		if ($title === null) {
 			return;
 		}
 
-		if ( !$lookup->isEntityNamespace( $title->getNamespace() ) ) {
+		if (!$lookup->isEntityNamespace($title->getNamespace())) {
 			return;
 		}
-		if ( !$out->getUser()->isLoggedIn() ) {
+		if (!$out->getUser()->isLoggedIn()) {
 			return;
 		}
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
 			return;
 		}
 
-		if ( self::isGadgetEnabledForUserName( $out->getUser()->getName(), time() ) ) {
-			$out->addModules( 'wikibase.quality.constraints.gadget' );
+		if (self::isGadgetEnabledForUserName($out->getUser()->getName(), time())) {
+			$out->addModules('wikibase.quality.constraints.gadget');
 		}
 	}
 

src/ConstraintCheck/Context/ReferenceContextCursor.php

Spacing +12 added lines, -12 removed lines

@@ -92,43 +92,43 @@
 		return $this->referenceHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
-		$statementArray = &$this->getStatementArray( $container );
+	protected function &getMainArray(array &$container) {
+		$statementArray = &$this->getStatementArray($container);
 
-		if ( !array_key_exists( 'references', $statementArray ) ) {
+		if (!array_key_exists('references', $statementArray)) {
 			$statementArray['references'] = [];
 		}
 		$referencesArray = &$statementArray['references'];
 
 		$referenceHash = $this->getReferenceHash();
-		foreach ( $referencesArray as &$potentialReferenceArray ) {
-			if ( $potentialReferenceArray['hash'] === $referenceHash ) {
+		foreach ($referencesArray as &$potentialReferenceArray) {
+			if ($potentialReferenceArray['hash'] === $referenceHash) {
 				$referenceArray = &$potentialReferenceArray;
 				break;
 			}
 		}
-		if ( !isset( $referenceArray ) ) {
-			$referenceArray = [ 'hash' => $referenceHash, 'snaks' => [] ];
+		if (!isset($referenceArray)) {
+			$referenceArray = ['hash' => $referenceHash, 'snaks' => []];
 			$referencesArray[] = &$referenceArray;
 		}
 
 		$snaksArray = &$referenceArray['snaks'];
 
 		$snakPropertyId = $this->getSnakPropertyId();
-		if ( !array_key_exists( $snakPropertyId, $snaksArray ) ) {
+		if (!array_key_exists($snakPropertyId, $snaksArray)) {
 			$snaksArray[$snakPropertyId] = [];
 		}
 		$propertyArray = &$snaksArray[$snakPropertyId];
 
 		$snakHash = $this->getSnakHash();
-		foreach ( $propertyArray as &$potentialSnakArray ) {
-			if ( $potentialSnakArray['hash'] === $snakHash ) {
+		foreach ($propertyArray as &$potentialSnakArray) {
+			if ($potentialSnakArray['hash'] === $snakHash) {
 				$snakArray = &$potentialSnakArray;
 				break;
 			}
 		}
-		if ( !isset( $snakArray ) ) {
-			$snakArray = [ 'hash' => $snakHash ];
+		if (!isset($snakArray)) {
+			$snakArray = ['hash' => $snakHash];
 			$propertyArray[] = &$snakArray;
 		}