wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/ValueTypeChecker.php

Spacing +25 added lines, -25 removed lines

@@ -88,9 +88,9 @@ 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -106,18 +106,18 @@ 
 			$constraintTypeItemId
 		);
 		$relationIds = [];
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
 		}
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
 		}
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -126,23 +126,23 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		try {
-			$item = $this->entityLookup->getEntity( $dataValue->getEntityId() );
-		} catch ( UnresolvedEntityRedirectException $e ) {
+			$item = $this->entityLookup->getEntity($dataValue->getEntityId());
+		} catch (UnresolvedEntityRedirectException $e) {
 			// Edge case (double redirect): Pretend the entity doesn't exist
 			$item = null;
 		}
 
-		if ( !( $item instanceof StatementListProvidingEntity ) ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!($item instanceof StatementListProvidingEntity)) {
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$statements = $item->getStatements();
@@ -153,7 +153,7 @@ 
 			$classes
 		);
 
-		if ( $result->getBool() ) {
+		if ($result->getBool()) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
@@ -167,11 +167,11 @@ 
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( $result->getMetadata() );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata($result->getMetadata());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -180,7 +180,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -188,7 +188,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintRepositoryLookup.php

Spacing +17 added lines, -17 removed lines

@@ -29,7 +29,7 @@ 
 	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
 	 * @param LoggerInterface|null $logger
 	 */
-	public function __construct( ILoadBalancer $lb, $dbName, ?LoggerInterface $logger = null ) {
+	public function __construct(ILoadBalancer $lb, $dbName, ?LoggerInterface $logger = null) {
 		$this->lb = $lb;
 		$this->dbName = $dbName;
 		$this->logger = $logger ?? new NullLogger();
@@ -40,22 +40,22 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( NumericPropertyId $propertyId ) {
-		$dbr = $this->lb->getConnection( ILoadBalancer::DB_REPLICA, [], $this->dbName );
+	public function queryConstraintsForProperty(NumericPropertyId $propertyId) {
+		$dbr = $this->lb->getConnection(ILoadBalancer::DB_REPLICA, [], $this->dbName);
 
 		$results = $dbr->newSelectQueryBuilder()
-			->select( [
+			->select([
 				'constraint_type_qid',
 				'constraint_parameters',
 				'constraint_guid',
 				'pid',
-			] )
-			->from( 'wbqc_constraints' )
-			->where( [ 'pid' => $propertyId->getNumericId() ] )
-			->caller( __METHOD__ )
+			])
+			->from('wbqc_constraints')
+			->where(['pid' => $propertyId->getNumericId()])
+			->caller(__METHOD__)
 			->fetchResultSet();
 
-		return $this->convertToConstraints( $results );
+		return $this->convertToConstraints($results);
 	}
 
 	/**
@@ -63,25 +63,25 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	private function convertToConstraints( IResultWrapper $results ) {
+	private function convertToConstraints(IResultWrapper $results) {
 		$constraints = [];
-		foreach ( $results as $result ) {
+		foreach ($results as $result) {
 			$constraintTypeItemId = $result->constraint_type_qid;
-			$constraintParameters = json_decode( $result->constraint_parameters, true );
+			$constraintParameters = json_decode($result->constraint_parameters, true);
 
-			if ( $constraintParameters === null ) {
+			if ($constraintParameters === null) {
 				// T171295
-				$this->logger->warning( 'Constraint {constraintId} has invalid constraint parameters.', [
+				$this->logger->warning('Constraint {constraintId} has invalid constraint parameters.', [
 					'method' => __METHOD__,
 					'constraintId' => $result->constraint_guid,
 					'constraintParameters' => $result->constraint_parameters,
-				] );
-				$constraintParameters = [ '@error' => [ /* unknown */ ] ];
+				]);
+				$constraintParameters = ['@error' => [/* unknown */]];
 			}
 
 			$constraints[] = new Constraint(
 				$result->constraint_guid,
-				NumericPropertyId::newFromNumber( $result->pid ),
+				NumericPropertyId::newFromNumber($result->pid),
 				$constraintTypeItemId,
 				$constraintParameters
 			);

src/WikibaseServices.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport;
 
@@ -26,9 +26,9 @@ 
 	public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
 
 	/** @return mixed */
-	private static function getService( ?MediaWikiServices $services, string $name ) {
+	private static function getService(?MediaWikiServices $services, string $name) {
 		$services ??= MediaWikiServices::getInstance();
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
@@ -38,8 +38,8 @@ 
 	 * this lookup ignores exceptions (such as unresolved redirects, T93273),
 	 * as it is more convenient to treat them all as missing entities in WBQC.
 	 */
-	public static function getEntityLookup( ?MediaWikiServices $services = null ): EntityLookup {
-		return self::getService( $services, self::ENTITY_LOOKUP );
+	public static function getEntityLookup(?MediaWikiServices $services = null): EntityLookup {
+		return self::getService($services, self::ENTITY_LOOKUP);
 	}
 
 	/**
@@ -49,8 +49,8 @@ 
 	 * were exceeding the request memory limit when they were all added to the cache (T227450).
 	 * Also, like {@link self::getEntityLookup()}, this lookup ignores exceptions.
 	 */
-	public static function getEntityLookupWithoutCache( ?MediaWikiServices $services = null ): EntityLookup {
-		return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE );
+	public static function getEntityLookupWithoutCache(?MediaWikiServices $services = null): EntityLookup {
+		return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE);
 	}
 
 }

src/ConstraintCheckerServices.php

Spacing +64 added lines, -64 removed lines

@@ -45,257 +45,257 @@
 	public const LABEL_IN_LANGUAGE_CHECKER = 'WBQC_LabelInLanguageChecker';
 
 	/** @return mixed */
-	private static function getService( ?MediaWikiServices $services, string $name ) {
+	private static function getService(?MediaWikiServices $services, string $name) {
 		$services ??= MediaWikiServices::getInstance();
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getConflictsWithChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONFLICTS_WITH_CHECKER );
+	public static function getConflictsWithChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::CONFLICTS_WITH_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getItemChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ITEM_CHECKER );
+	public static function getItemChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::ITEM_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getTargetRequiredClaimChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::TARGET_REQUIRED_CLAIM_CHECKER );
+	public static function getTargetRequiredClaimChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::TARGET_REQUIRED_CLAIM_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getSymmetricChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SYMMETRIC_CHECKER );
+	public static function getSymmetricChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::SYMMETRIC_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getInverseChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::INVERSE_CHECKER );
+	public static function getInverseChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::INVERSE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getQualifierChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::QUALIFIER_CHECKER );
+	public static function getQualifierChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::QUALIFIER_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getQualifiersChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::QUALIFIERS_CHECKER );
+	public static function getQualifiersChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::QUALIFIERS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getMandatoryQualifiersChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::MANDATORY_QUALIFIERS_CHECKER );
+	public static function getMandatoryQualifiersChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::MANDATORY_QUALIFIERS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getRangeChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::RANGE_CHECKER );
+	public static function getRangeChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::RANGE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getDiffWithinRangeChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::DIFF_WITHIN_RANGE_CHECKER );
+	public static function getDiffWithinRangeChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::DIFF_WITHIN_RANGE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getTypeChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::TYPE_CHECKER );
+	public static function getTypeChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::TYPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getValueTypeChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::VALUE_TYPE_CHECKER );
+	public static function getValueTypeChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::VALUE_TYPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getSingleValueChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SINGLE_VALUE_CHECKER );
+	public static function getSingleValueChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::SINGLE_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getMultiValueChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::MULTI_VALUE_CHECKER );
+	public static function getMultiValueChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::MULTI_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getUniqueValueChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::UNIQUE_VALUE_CHECKER );
+	public static function getUniqueValueChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::UNIQUE_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getFormatChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::FORMAT_CHECKER );
+	public static function getFormatChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::FORMAT_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getCommonsLinkChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::COMMONS_LINK_CHECKER );
+	public static function getCommonsLinkChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::COMMONS_LINK_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getOneOfChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ONE_OF_CHECKER );
+	public static function getOneOfChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::ONE_OF_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getValueOnlyChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::VALUE_ONLY_CHECKER );
+	public static function getValueOnlyChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::VALUE_ONLY_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getReferenceChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::REFERENCE_CHECKER );
+	public static function getReferenceChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::REFERENCE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getNoBoundsChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::NO_BOUNDS_CHECKER );
+	public static function getNoBoundsChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::NO_BOUNDS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getAllowedUnitsChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ALLOWED_UNITS_CHECKER );
+	public static function getAllowedUnitsChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::ALLOWED_UNITS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getSingleBestValueChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SINGLE_BEST_VALUE_CHECKER );
+	public static function getSingleBestValueChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::SINGLE_BEST_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getEntityTypeChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ENTITY_TYPE_CHECKER );
+	public static function getEntityTypeChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::ENTITY_TYPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getNoneOfChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::NONE_OF_CHECKER );
+	public static function getNoneOfChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::NONE_OF_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getIntegerChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::INTEGER_CHECKER );
+	public static function getIntegerChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::INTEGER_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getCitationNeededChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CITATION_NEEDED_CHECKER );
+	public static function getCitationNeededChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::CITATION_NEEDED_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getPropertyScopeChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::PROPERTY_SCOPE_CHECKER );
+	public static function getPropertyScopeChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::PROPERTY_SCOPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getContemporaryChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONTEMPORARY_CHECKER );
+	public static function getContemporaryChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::CONTEMPORARY_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return LanguageChecker
 	 */
-	public static function getLexemeLanguageChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::LEXEME_LANGUAGE_CHECKER );
+	public static function getLexemeLanguageChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::LEXEME_LANGUAGE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return LabelInLanguageChecker
 	 */
-	public static function getLabelInLanguageChecker( ?MediaWikiServices $services = null ) {
-		return self::getService( $services, self::LABEL_IN_LANGUAGE_CHECKER );
+	public static function getLabelInLanguageChecker(?MediaWikiServices $services = null) {
+		return self::getService($services, self::LABEL_IN_LANGUAGE_CHECKER);
 	}
 
 }

src/ConstraintCheck/Helper/NowValue.php

Spacing +4 added lines, -4 removed lines

@@ -28,7 +28,7 @@ 
 	 * @return string
 	 */
 	public function getTime() {
-		return gmdate( '+Y-m-d\TH:i:s\Z' );
+		return gmdate('+Y-m-d\TH:i:s\Z');
 	}
 
 	/** @inheritDoc */
@@ -43,12 +43,12 @@ 
 
 	/** @inheritDoc */
 	public function getArrayValue() {
-		throw new LogicException( 'NowValue should never be serialized' );
+		throw new LogicException('NowValue should never be serialized');
 	}
 
 	/** @inheritDoc */
-	public function equals( $value ) {
-		return get_class( $value ) === self::class;
+	public function equals($value) {
+		return get_class($value) === self::class;
 	}
 
 }

src/ConstraintCheck/Cache/Metadata.php

Spacing +7 added lines, -7 removed lines

@@ -32,14 +32,14 @@ 
 		return $ret;
 	}
 
-	public static function ofCachingMetadata( CachingMetadata $cachingMetadata ): self {
+	public static function ofCachingMetadata(CachingMetadata $cachingMetadata): self {
 		$ret = new self;
 		$ret->cachingMetadata = $cachingMetadata;
 		$ret->dependencyMetadata = DependencyMetadata::blank();
 		return $ret;
 	}
 
-	public static function ofDependencyMetadata( DependencyMetadata $dependencyMetadata ): self {
+	public static function ofDependencyMetadata(DependencyMetadata $dependencyMetadata): self {
 		$ret = new self;
 		$ret->cachingMetadata = CachingMetadata::fresh();
 		$ret->dependencyMetadata = $dependencyMetadata;
@@ -50,17 +50,17 @@ 
 	 * @param self[] $metadatas
 	 * @return self
 	 */
-	public static function merge( array $metadatas ) {
-		Assert::parameterElementType( self::class, $metadatas, '$metadatas' );
+	public static function merge(array $metadatas) {
+		Assert::parameterElementType(self::class, $metadatas, '$metadatas');
 		$cachingMetadatas = [];
 		$dependencyMetadatas = [];
-		foreach ( $metadatas as $metadata ) {
+		foreach ($metadatas as $metadata) {
 			$cachingMetadatas[] = $metadata->cachingMetadata;
 			$dependencyMetadatas[] = $metadata->dependencyMetadata;
 		}
 		$ret = new self;
-		$ret->cachingMetadata = CachingMetadata::merge( $cachingMetadatas );
-		$ret->dependencyMetadata = DependencyMetadata::merge( $dependencyMetadatas );
+		$ret->cachingMetadata = CachingMetadata::merge($cachingMetadatas);
+		$ret->dependencyMetadata = DependencyMetadata::merge($dependencyMetadatas);
 		return $ret;
 	}
 

src/ConstraintsServices.php

Spacing +27 added lines, -27 removed lines

@@ -43,95 +43,95 @@
 	public const VIOLATION_MESSAGE_RENDERER_FACTORY = 'WBQC_ViolationMessageRendererFactory';
 
 	/** @return mixed */
-	private static function getService( ?MediaWikiServices $services, string $name ) {
+	private static function getService(?MediaWikiServices $services, string $name) {
 		$services ??= MediaWikiServices::getInstance();
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
-	public static function getLogger( ?MediaWikiServices $services = null ): LoggerInterface {
-		return self::getService( $services, self::LOGGER );
+	public static function getLogger(?MediaWikiServices $services = null): LoggerInterface {
+		return self::getService($services, self::LOGGER);
 	}
 
-	public static function getLoggingHelper( ?MediaWikiServices $services = null ): LoggingHelper {
-		return self::getService( $services, self::LOGGING_HELPER );
+	public static function getLoggingHelper(?MediaWikiServices $services = null): LoggingHelper {
+		return self::getService($services, self::LOGGING_HELPER);
 	}
 
 	public static function getConstraintStore(
 		?MediaWikiServices $services = null
 	): ConstraintStore {
-		return self::getService( $services, self::CONSTRAINT_STORE );
+		return self::getService($services, self::CONSTRAINT_STORE);
 	}
 
-	public static function getConstraintLookup( ?MediaWikiServices $services = null ): ConstraintLookup {
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
+	public static function getConstraintLookup(?MediaWikiServices $services = null): ConstraintLookup {
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
 	}
 
 	public static function getCheckResultSerializer(
 		?MediaWikiServices $services = null
 	): CheckResultSerializer {
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
 	}
 
 	public static function getCheckResultDeserializer(
 		?MediaWikiServices $services = null
 	): CheckResultDeserializer {
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
 	}
 
 	public static function getViolationMessageSerializer(
 		?MediaWikiServices $services = null
 	): ViolationMessageSerializer {
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
 	}
 
 	public static function getViolationMessageDeserializer(
 		?MediaWikiServices $services = null
 	): ViolationMessageDeserializer {
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
 	}
 
 	public static function getConstraintParameterParser(
 		?MediaWikiServices $services = null
 	): ConstraintParameterParser {
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
 	}
 
 	public static function getConnectionCheckerHelper(
 		?MediaWikiServices $services = null
 	): ConnectionCheckerHelper {
-		return self::getService( $services, self::CONNECTION_CHECKER_HELPER );
+		return self::getService($services, self::CONNECTION_CHECKER_HELPER);
 	}
 
-	public static function getRangeCheckerHelper( ?MediaWikiServices $services = null ): RangeCheckerHelper {
-		return self::getService( $services, self::RANGE_CHECKER_HELPER );
+	public static function getRangeCheckerHelper(?MediaWikiServices $services = null): RangeCheckerHelper {
+		return self::getService($services, self::RANGE_CHECKER_HELPER);
 	}
 
-	public static function getSparqlHelper( ?MediaWikiServices $services = null ): SparqlHelper {
-		return self::getService( $services, self::SPARQL_HELPER );
+	public static function getSparqlHelper(?MediaWikiServices $services = null): SparqlHelper {
+		return self::getService($services, self::SPARQL_HELPER);
 	}
 
-	public static function getTypeCheckerHelper( ?MediaWikiServices $services = null ): TypeCheckerHelper {
-		return self::getService( $services, self::TYPE_CHECKER_HELPER );
+	public static function getTypeCheckerHelper(?MediaWikiServices $services = null): TypeCheckerHelper {
+		return self::getService($services, self::TYPE_CHECKER_HELPER);
 	}
 
 	public static function getDelegatingConstraintChecker(
 		?MediaWikiServices $services = null
 	): DelegatingConstraintChecker {
-		return self::getService( $services, self::DELEGATING_CONSTRAINT_CHECKER );
+		return self::getService($services, self::DELEGATING_CONSTRAINT_CHECKER);
 	}
 
-	public static function getResultsSource( ?MediaWikiServices $services = null ): ResultsSource {
-		return self::getService( $services, self::RESULTS_SOURCE );
+	public static function getResultsSource(?MediaWikiServices $services = null): ResultsSource {
+		return self::getService($services, self::RESULTS_SOURCE);
 	}
 
-	public static function getExpiryLock( ?MediaWikiServices $services = null ): ExpiryLock {
-		return self::getService( $services, self::EXPIRY_LOCK );
+	public static function getExpiryLock(?MediaWikiServices $services = null): ExpiryLock {
+		return self::getService($services, self::EXPIRY_LOCK);
 	}
 
 	public static function getViolationMessageRendererFactory(
 		?MediaWikiServices $services = null
 	): ViolationMessageRendererFactory {
-		return self::getService( $services, self::VIOLATION_MESSAGE_RENDERER_FACTORY );
+		return self::getService($services, self::VIOLATION_MESSAGE_RENDERER_FACTORY);
 	}
 
 }

src/ConstraintRepositoryStore.php

Spacing +19 added lines, -19 removed lines

@@ -24,16 +24,16 @@ 
 	 * then using the main DBLoadBalancer service may be incorrect.
 	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
 	 */
-	public function __construct( ILoadBalancer $lb, $dbName ) {
+	public function __construct(ILoadBalancer $lb, $dbName) {
 		$this->lb = $lb;
 		$this->dbName = $dbName;
 	}
 
-	private function encodeConstraintParameters( array $constraintParameters ): string {
-		$json = json_encode( $constraintParameters, JSON_FORCE_OBJECT );
+	private function encodeConstraintParameters(array $constraintParameters): string {
+		$json = json_encode($constraintParameters, JSON_FORCE_OBJECT);
 
-		if ( strlen( $json ) > 50000 ) {
-			$json = json_encode( [ '@error' => [ 'toolong' => true ] ] );
+		if (strlen($json) > 50000) {
+			$json = json_encode(['@error' => ['toolong' => true]]);
 		}
 
 		return $json;
@@ -44,28 +44,28 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function insertBatch( array $constraints ) {
-		if ( !$constraints ) {
+	public function insertBatch(array $constraints) {
+		if (!$constraints) {
 			return;
 		}
 
 		$accumulator = array_map(
-			function ( Constraint $constraint ) {
+			function(Constraint $constraint) {
 				return [
 					'constraint_guid' => $constraint->getConstraintId(),
 					'pid' => $constraint->getPropertyId()->getNumericId(),
 					'constraint_type_qid' => $constraint->getConstraintTypeItemId(),
-					'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() ),
+					'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters()),
 				];
 			},
 			$constraints
 		);
 
-		$dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
+		$dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName);
 		$dbw->newInsertQueryBuilder()
-			->insertInto( 'wbqc_constraints' )
-			->rows( $accumulator )
-			->caller( __METHOD__ )
+			->insertInto('wbqc_constraints')
+			->rows($accumulator)
+			->caller(__METHOD__)
 			->execute();
 	}
 
@@ -76,14 +76,14 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function deleteForProperty( NumericPropertyId $propertyId ) {
-		$dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
+	public function deleteForProperty(NumericPropertyId $propertyId) {
+		$dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName);
 		$dbw->newDeleteQueryBuilder()
-			->deleteFrom( 'wbqc_constraints' )
-			->where( [
+			->deleteFrom('wbqc_constraints')
+			->where([
 				'pid' => $propertyId->getNumericId(),
-			] )
-			->caller( __METHOD__ )
+			])
+			->caller(__METHOD__)
 			->execute();
 	}
 

src/ConstraintCheck/Context/ContextCursor.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -61,6 +61,6 @@ 
 	 * @param ?array $result
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( ?array $result, array &$container ): void;
+	public function storeCheckResultInArray(?array $result, array &$container): void;
 
 }