@@ -10,7 +10,7 @@ |
||
10 | 10 | class SparqlHelperException extends RuntimeException { |
11 | 11 | |
12 | 12 | public function __construct() { |
13 | - parent::__construct( 'The SPARQL query endpoint returned an error.' ); |
|
13 | + parent::__construct('The SPARQL query endpoint returned an error.'); |
|
14 | 14 | } |
15 | 15 | |
16 | 16 | } |
@@ -20,7 +20,7 @@ |
||
20 | 20 | */ |
21 | 21 | private $metadata; |
22 | 22 | |
23 | - public function __construct( array $array, Metadata $metadata ) { |
|
23 | + public function __construct(array $array, Metadata $metadata) { |
|
24 | 24 | $this->array = $array; |
25 | 25 | $this->metadata = $metadata; |
26 | 26 | } |
@@ -29,7 +29,7 @@ discard block |
||
29 | 29 | * @param EntityId $entityId An entity ID from which the value was derived. |
30 | 30 | * @return self Indication that a value is was derived from the entity with the given ID. |
31 | 31 | */ |
32 | - public static function ofEntityId( EntityId $entityId ) { |
|
32 | + public static function ofEntityId(EntityId $entityId) { |
|
33 | 33 | $ret = new self; |
34 | 34 | $ret->entityIds[] = $entityId; |
35 | 35 | return $ret; |
@@ -39,11 +39,11 @@ discard block |
||
39 | 39 | * @param self[] $metadatas |
40 | 40 | * @return self |
41 | 41 | */ |
42 | - public static function merge( array $metadatas ) { |
|
43 | - Assert::parameterElementType( self::class, $metadatas, '$metadatas' ); |
|
42 | + public static function merge(array $metadatas) { |
|
43 | + Assert::parameterElementType(self::class, $metadatas, '$metadatas'); |
|
44 | 44 | $ret = new self; |
45 | - foreach ( $metadatas as $metadata ) { |
|
46 | - $ret->entityIds = array_merge( $ret->entityIds, $metadata->entityIds ); |
|
45 | + foreach ($metadatas as $metadata) { |
|
46 | + $ret->entityIds = array_merge($ret->entityIds, $metadata->entityIds); |
|
47 | 47 | } |
48 | 48 | return $ret; |
49 | 49 | } |
@@ -24,7 +24,7 @@ |
||
24 | 24 | * @param bool $bool |
25 | 25 | * @param Metadata $metadata |
26 | 26 | */ |
27 | - public function __construct( $bool, Metadata $metadata ) { |
|
27 | + public function __construct($bool, Metadata $metadata) { |
|
28 | 28 | $this->bool = $bool; |
29 | 29 | $this->metadata = $metadata; |
30 | 30 | } |
@@ -32,14 +32,14 @@ discard block |
||
32 | 32 | return $ret; |
33 | 33 | } |
34 | 34 | |
35 | - public static function ofCachingMetadata( CachingMetadata $cachingMetadata ) { |
|
35 | + public static function ofCachingMetadata(CachingMetadata $cachingMetadata) { |
|
36 | 36 | $ret = new self; |
37 | 37 | $ret->cachingMetadata = $cachingMetadata; |
38 | 38 | $ret->dependencyMetadata = DependencyMetadata::blank(); |
39 | 39 | return $ret; |
40 | 40 | } |
41 | 41 | |
42 | - public static function ofDependencyMetadata( DependencyMetadata $dependencyMetadata ) { |
|
42 | + public static function ofDependencyMetadata(DependencyMetadata $dependencyMetadata) { |
|
43 | 43 | $ret = new self; |
44 | 44 | $ret->cachingMetadata = CachingMetadata::fresh(); |
45 | 45 | $ret->dependencyMetadata = $dependencyMetadata; |
@@ -50,17 +50,17 @@ discard block |
||
50 | 50 | * @param self[] $metadatas |
51 | 51 | * @return self |
52 | 52 | */ |
53 | - public static function merge( array $metadatas ) { |
|
54 | - Assert::parameterElementType( self::class, $metadatas, '$metadatas' ); |
|
53 | + public static function merge(array $metadatas) { |
|
54 | + Assert::parameterElementType(self::class, $metadatas, '$metadatas'); |
|
55 | 55 | $cachingMetadatas = []; |
56 | 56 | $dependencyMetadatas = []; |
57 | - foreach ( $metadatas as $metadata ) { |
|
57 | + foreach ($metadatas as $metadata) { |
|
58 | 58 | $cachingMetadatas[] = $metadata->cachingMetadata; |
59 | 59 | $dependencyMetadatas[] = $metadata->dependencyMetadata; |
60 | 60 | } |
61 | 61 | $ret = new self; |
62 | - $ret->cachingMetadata = CachingMetadata::merge( $cachingMetadatas ); |
|
63 | - $ret->dependencyMetadata = DependencyMetadata::merge( $dependencyMetadatas ); |
|
62 | + $ret->cachingMetadata = CachingMetadata::merge($cachingMetadatas); |
|
63 | + $ret->dependencyMetadata = DependencyMetadata::merge($dependencyMetadatas); |
|
64 | 64 | return $ret; |
65 | 65 | } |
66 | 66 |
@@ -137,7 +137,7 @@ discard block |
||
137 | 137 | public static function getDefaultInstance() { |
138 | 138 | static $instance = null; |
139 | 139 | |
140 | - if ( $instance === null ) { |
|
140 | + if ($instance === null) { |
|
141 | 141 | $wikibaseRepo = WikibaseRepo::getDefaultInstance(); |
142 | 142 | $entityIdFormatter = $wikibaseRepo->getEntityIdHtmlLinkFormatterFactory()->getEntityIdFormatter( |
143 | 143 | $wikibaseRepo->getLanguageFallbackLabelDescriptionLookupFactory()->newLabelDescriptionLookup( |
@@ -205,21 +205,21 @@ discard block |
||
205 | 205 | * @return DelegatingConstraintChecker |
206 | 206 | */ |
207 | 207 | public function getConstraintChecker() { |
208 | - if ( $this->delegatingConstraintChecker === null ) { |
|
208 | + if ($this->delegatingConstraintChecker === null) { |
|
209 | 209 | $this->delegatingConstraintChecker = new DelegatingConstraintChecker( |
210 | 210 | $this->lookup, |
211 | 211 | $this->getConstraintCheckerMap(), |
212 | - new CachingConstraintLookup( $this->getConstraintRepository() ), |
|
212 | + new CachingConstraintLookup($this->getConstraintRepository()), |
|
213 | 213 | $this->constraintParameterParser, |
214 | 214 | $this->statementGuidParser, |
215 | 215 | new LoggingHelper( |
216 | 216 | $this->dataFactory, |
217 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ), |
|
217 | + LoggerFactory::getInstance('WikibaseQualityConstraints'), |
|
218 | 218 | $this->config |
219 | 219 | ), |
220 | - $this->config->get( 'WBQualityConstraintsCheckQualifiers' ), |
|
221 | - $this->config->get( 'WBQualityConstraintsCheckReferences' ), |
|
222 | - $this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' ) |
|
220 | + $this->config->get('WBQualityConstraintsCheckQualifiers'), |
|
221 | + $this->config->get('WBQualityConstraintsCheckReferences'), |
|
222 | + $this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers') |
|
223 | 223 | ); |
224 | 224 | } |
225 | 225 | |
@@ -230,10 +230,10 @@ discard block |
||
230 | 230 | * @return ConstraintChecker[] |
231 | 231 | */ |
232 | 232 | private function getConstraintCheckerMap() { |
233 | - if ( $this->constraintCheckerMap === null ) { |
|
233 | + if ($this->constraintCheckerMap === null) { |
|
234 | 234 | $connectionCheckerHelper = new ConnectionCheckerHelper(); |
235 | - $rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter ); |
|
236 | - if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) { |
|
235 | + $rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter); |
|
236 | + if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') { |
|
237 | 237 | $sparqlHelper = new SparqlHelper( |
238 | 238 | $this->config, |
239 | 239 | $this->rdfVocabulary, |
@@ -254,74 +254,74 @@ discard block |
||
254 | 254 | ); |
255 | 255 | |
256 | 256 | $this->constraintCheckerMap = [ |
257 | - $this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' ) |
|
257 | + $this->config->get('WBQualityConstraintsConflictsWithConstraintId') |
|
258 | 258 | => new ConflictsWithChecker( |
259 | 259 | $this->lookup, |
260 | 260 | $this->constraintParameterParser, |
261 | 261 | $connectionCheckerHelper, |
262 | 262 | $this->constraintParameterRenderer |
263 | 263 | ), |
264 | - $this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' ) |
|
264 | + $this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId') |
|
265 | 265 | => new ItemChecker( |
266 | 266 | $this->lookup, |
267 | 267 | $this->constraintParameterParser, |
268 | 268 | $connectionCheckerHelper, |
269 | 269 | $this->constraintParameterRenderer |
270 | 270 | ), |
271 | - $this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' ) |
|
271 | + $this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId') |
|
272 | 272 | => new TargetRequiredClaimChecker( |
273 | 273 | $this->lookup, |
274 | 274 | $this->constraintParameterParser, |
275 | 275 | $connectionCheckerHelper, |
276 | 276 | $this->constraintParameterRenderer |
277 | 277 | ), |
278 | - $this->config->get( 'WBQualityConstraintsSymmetricConstraintId' ) |
|
278 | + $this->config->get('WBQualityConstraintsSymmetricConstraintId') |
|
279 | 279 | => new SymmetricChecker( |
280 | 280 | $this->lookup, |
281 | 281 | $connectionCheckerHelper, |
282 | 282 | $this->constraintParameterRenderer |
283 | 283 | ), |
284 | - $this->config->get( 'WBQualityConstraintsInverseConstraintId' ) |
|
284 | + $this->config->get('WBQualityConstraintsInverseConstraintId') |
|
285 | 285 | => new InverseChecker( |
286 | 286 | $this->lookup, |
287 | 287 | $this->constraintParameterParser, |
288 | 288 | $connectionCheckerHelper, |
289 | 289 | $this->constraintParameterRenderer |
290 | 290 | ), |
291 | - $this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' ) |
|
291 | + $this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId') |
|
292 | 292 | => new QualifierChecker(), |
293 | - $this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' ) |
|
293 | + $this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId') |
|
294 | 294 | => new QualifiersChecker( |
295 | 295 | $this->constraintParameterParser, |
296 | 296 | $this->constraintParameterRenderer |
297 | 297 | ), |
298 | - $this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' ) |
|
298 | + $this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId') |
|
299 | 299 | => new MandatoryQualifiersChecker( |
300 | 300 | $this->constraintParameterParser, |
301 | 301 | $this->constraintParameterRenderer |
302 | 302 | ), |
303 | - $this->config->get( 'WBQualityConstraintsRangeConstraintId' ) |
|
303 | + $this->config->get('WBQualityConstraintsRangeConstraintId') |
|
304 | 304 | => new RangeChecker( |
305 | 305 | $this->propertyDataTypeLookup, |
306 | 306 | $this->constraintParameterParser, |
307 | 307 | $rangeCheckerHelper, |
308 | 308 | $this->constraintParameterRenderer |
309 | 309 | ), |
310 | - $this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' ) |
|
310 | + $this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId') |
|
311 | 311 | => new DiffWithinRangeChecker( |
312 | 312 | $this->constraintParameterParser, |
313 | 313 | $rangeCheckerHelper, |
314 | 314 | $this->constraintParameterRenderer, |
315 | 315 | $this->config |
316 | 316 | ), |
317 | - $this->config->get( 'WBQualityConstraintsTypeConstraintId' ) |
|
317 | + $this->config->get('WBQualityConstraintsTypeConstraintId') |
|
318 | 318 | => new TypeChecker( |
319 | 319 | $this->lookup, |
320 | 320 | $this->constraintParameterParser, |
321 | 321 | $typeCheckerHelper, |
322 | 322 | $this->config |
323 | 323 | ), |
324 | - $this->config->get( 'WBQualityConstraintsValueTypeConstraintId' ) |
|
324 | + $this->config->get('WBQualityConstraintsValueTypeConstraintId') |
|
325 | 325 | => new ValueTypeChecker( |
326 | 326 | $this->lookup, |
327 | 327 | $this->constraintParameterParser, |
@@ -329,36 +329,36 @@ discard block |
||
329 | 329 | $typeCheckerHelper, |
330 | 330 | $this->config |
331 | 331 | ), |
332 | - $this->config->get( 'WBQualityConstraintsSingleValueConstraintId' ) |
|
332 | + $this->config->get('WBQualityConstraintsSingleValueConstraintId') |
|
333 | 333 | => new SingleValueChecker(), |
334 | - $this->config->get( 'WBQualityConstraintsMultiValueConstraintId' ) |
|
334 | + $this->config->get('WBQualityConstraintsMultiValueConstraintId') |
|
335 | 335 | => new MultiValueChecker(), |
336 | - $this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ) |
|
336 | + $this->config->get('WBQualityConstraintsDistinctValuesConstraintId') |
|
337 | 337 | => new UniqueValueChecker( |
338 | 338 | $this->constraintParameterRenderer, |
339 | 339 | $sparqlHelper |
340 | 340 | ), |
341 | - $this->config->get( 'WBQualityConstraintsFormatConstraintId' ) |
|
341 | + $this->config->get('WBQualityConstraintsFormatConstraintId') |
|
342 | 342 | => new FormatChecker( |
343 | 343 | $this->constraintParameterParser, |
344 | 344 | $this->constraintParameterRenderer, |
345 | 345 | $this->config, |
346 | 346 | $sparqlHelper |
347 | 347 | ), |
348 | - $this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ) |
|
348 | + $this->config->get('WBQualityConstraintsCommonsLinkConstraintId') |
|
349 | 349 | => new CommonsLinkChecker( |
350 | 350 | $this->constraintParameterParser, |
351 | 351 | $this->constraintParameterRenderer, |
352 | 352 | $this->titleParser |
353 | 353 | ), |
354 | - $this->config->get( 'WBQualityConstraintsOneOfConstraintId' ) |
|
354 | + $this->config->get('WBQualityConstraintsOneOfConstraintId') |
|
355 | 355 | => new OneOfChecker( |
356 | 356 | $this->constraintParameterParser, |
357 | 357 | $this->constraintParameterRenderer |
358 | 358 | ), |
359 | - $this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' ) |
|
359 | + $this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId') |
|
360 | 360 | => new ValueOnlyChecker(), |
361 | - $this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' ) |
|
361 | + $this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId') |
|
362 | 362 | => new ReferenceChecker(), |
363 | 363 | ]; |
364 | 364 | } |
@@ -370,26 +370,26 @@ discard block |
||
370 | 370 | * @return array[] |
371 | 371 | */ |
372 | 372 | public function getConstraintParameterMap() { |
373 | - if ( $this->constraintParameterMap === null ) { |
|
373 | + if ($this->constraintParameterMap === null) { |
|
374 | 374 | $this->constraintParameterMap = [ |
375 | - 'Commons link' => [ 'namespace' ], |
|
376 | - 'Conflicts with' => [ 'property', 'item' ], |
|
377 | - 'Diff within range' => [ 'property', 'minimum_quantity', 'maximum_quantity' ], |
|
378 | - 'Format' => [ 'pattern' ], |
|
379 | - 'Inverse' => [ 'property' ], |
|
380 | - 'Item' => [ 'property', 'item' ], |
|
381 | - 'Mandatory qualifiers' => [ 'property' ], |
|
375 | + 'Commons link' => ['namespace'], |
|
376 | + 'Conflicts with' => ['property', 'item'], |
|
377 | + 'Diff within range' => ['property', 'minimum_quantity', 'maximum_quantity'], |
|
378 | + 'Format' => ['pattern'], |
|
379 | + 'Inverse' => ['property'], |
|
380 | + 'Item' => ['property', 'item'], |
|
381 | + 'Mandatory qualifiers' => ['property'], |
|
382 | 382 | 'Multi value' => [], |
383 | - 'One of' => [ 'item' ], |
|
383 | + 'One of' => ['item'], |
|
384 | 384 | 'Qualifier' => [], |
385 | - 'Qualifiers' => [ 'property' ], |
|
386 | - 'Range' => [ 'minimum_quantity', 'maximum_quantity', 'minimum_date', 'maximum_date' ], |
|
385 | + 'Qualifiers' => ['property'], |
|
386 | + 'Range' => ['minimum_quantity', 'maximum_quantity', 'minimum_date', 'maximum_date'], |
|
387 | 387 | 'Single value' => [], |
388 | 388 | 'Symmetric' => [], |
389 | - 'Target required claim' => [ 'property', 'item' ], |
|
390 | - 'Type' => [ 'class', 'relation' ], |
|
389 | + 'Target required claim' => ['property', 'item'], |
|
390 | + 'Type' => ['class', 'relation'], |
|
391 | 391 | 'Unique value' => [], |
392 | - 'Value type' => [ 'class', 'relation' ] |
|
392 | + 'Value type' => ['class', 'relation'] |
|
393 | 393 | ]; |
394 | 394 | } |
395 | 395 | |
@@ -400,7 +400,7 @@ discard block |
||
400 | 400 | * @return ConstraintRepository |
401 | 401 | */ |
402 | 402 | public function getConstraintRepository() { |
403 | - if ( $this->constraintRepository === null ) { |
|
403 | + if ($this->constraintRepository === null) { |
|
404 | 404 | $this->constraintRepository = new ConstraintRepository(); |
405 | 405 | } |
406 | 406 |
@@ -65,10 +65,10 @@ discard block |
||
65 | 65 | * |
66 | 66 | * @return self |
67 | 67 | */ |
68 | - public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) { |
|
68 | + public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') { |
|
69 | 69 | $constraintReportFactory = ConstraintReportFactory::getDefaultInstance(); |
70 | 70 | $repo = WikibaseRepo::getDefaultInstance(); |
71 | - $helperFactory = $repo->getApiHelperFactory( RequestContext::getMain() ); |
|
71 | + $helperFactory = $repo->getApiHelperFactory(RequestContext::getMain()); |
|
72 | 72 | return new self( |
73 | 73 | $main, |
74 | 74 | $name, |
@@ -98,9 +98,9 @@ discard block |
||
98 | 98 | StatementGuidParser $statementGuidParser, |
99 | 99 | IBufferingStatsdDataFactory $dataFactory |
100 | 100 | ) { |
101 | - parent::__construct( $main, $name, $prefix ); |
|
101 | + parent::__construct($main, $name, $prefix); |
|
102 | 102 | |
103 | - $this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
103 | + $this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this); |
|
104 | 104 | $this->delegatingConstraintChecker = $delegatingConstraintChecker; |
105 | 105 | $this->statementGuidParser = $statementGuidParser; |
106 | 106 | $this->dataFactory = $dataFactory; |
@@ -114,39 +114,39 @@ discard block |
||
114 | 114 | $params = $this->extractRequestParams(); |
115 | 115 | $result = $this->getResult(); |
116 | 116 | |
117 | - $propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] ); |
|
118 | - $constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] ); |
|
117 | + $propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]); |
|
118 | + $constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]); |
|
119 | 119 | |
120 | - $this->checkPropertyIds( $propertyIds, $result ); |
|
121 | - $this->checkConstraintIds( $constraintIds, $result ); |
|
120 | + $this->checkPropertyIds($propertyIds, $result); |
|
121 | + $this->checkConstraintIds($constraintIds, $result); |
|
122 | 122 | |
123 | - $result->addValue( null, 'success', 1 ); |
|
123 | + $result->addValue(null, 'success', 1); |
|
124 | 124 | } |
125 | 125 | |
126 | 126 | /** |
127 | 127 | * @param array|null $propertyIdSerializations |
128 | 128 | * @return PropertyId[] |
129 | 129 | */ |
130 | - private function parsePropertyIds( $propertyIdSerializations ) { |
|
131 | - if ( $propertyIdSerializations === null ) { |
|
130 | + private function parsePropertyIds($propertyIdSerializations) { |
|
131 | + if ($propertyIdSerializations === null) { |
|
132 | 132 | return []; |
133 | - } elseif ( empty( $propertyIdSerializations ) ) { |
|
133 | + } elseif (empty($propertyIdSerializations)) { |
|
134 | 134 | $this->apiErrorReporter->dieError( |
135 | - 'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.', |
|
135 | + 'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.', |
|
136 | 136 | 'no-data' |
137 | 137 | ); |
138 | 138 | } |
139 | 139 | |
140 | 140 | return array_map( |
141 | - function( $propertyIdSerialization ) { |
|
141 | + function($propertyIdSerialization) { |
|
142 | 142 | try { |
143 | - return new PropertyId( $propertyIdSerialization ); |
|
144 | - } catch ( InvalidArgumentException $e ) { |
|
143 | + return new PropertyId($propertyIdSerialization); |
|
144 | + } catch (InvalidArgumentException $e) { |
|
145 | 145 | $this->apiErrorReporter->dieError( |
146 | 146 | "Invalid id: $propertyIdSerialization", |
147 | 147 | 'invalid-property-id', |
148 | 148 | 0, // default argument |
149 | - [ self::PARAM_PROPERTY_ID => $propertyIdSerialization ] |
|
149 | + [self::PARAM_PROPERTY_ID => $propertyIdSerialization] |
|
150 | 150 | ); |
151 | 151 | } |
152 | 152 | }, |
@@ -158,35 +158,35 @@ discard block |
||
158 | 158 | * @param array|null $constraintIds |
159 | 159 | * @return string[] |
160 | 160 | */ |
161 | - private function parseConstraintIds( $constraintIds ) { |
|
162 | - if ( $constraintIds === null ) { |
|
161 | + private function parseConstraintIds($constraintIds) { |
|
162 | + if ($constraintIds === null) { |
|
163 | 163 | return []; |
164 | - } elseif ( empty( $constraintIds ) ) { |
|
164 | + } elseif (empty($constraintIds)) { |
|
165 | 165 | $this->apiErrorReporter->dieError( |
166 | - 'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.', |
|
166 | + 'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.', |
|
167 | 167 | 'no-data' |
168 | 168 | ); |
169 | 169 | } |
170 | 170 | |
171 | 171 | return array_map( |
172 | - function( $constraintId ) { |
|
172 | + function($constraintId) { |
|
173 | 173 | try { |
174 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
175 | - if ( !$propertyId instanceof PropertyId ) { |
|
174 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
175 | + if (!$propertyId instanceof PropertyId) { |
|
176 | 176 | $this->apiErrorReporter->dieError( |
177 | 177 | "Invalid property ID: {$propertyId->getSerialization()}", |
178 | 178 | 'invalid-property-id', |
179 | 179 | 0, // default argument |
180 | - [ self::PARAM_CONSTRAINT_ID => $constraintId ] |
|
180 | + [self::PARAM_CONSTRAINT_ID => $constraintId] |
|
181 | 181 | ); |
182 | 182 | } |
183 | 183 | return $constraintId; |
184 | - } catch ( StatementGuidParsingException $e ) { |
|
184 | + } catch (StatementGuidParsingException $e) { |
|
185 | 185 | $this->apiErrorReporter->dieError( |
186 | 186 | "Invalid statement GUID: $constraintId", |
187 | 187 | 'invalid-guid', |
188 | 188 | 0, // default argument |
189 | - [ self::PARAM_CONSTRAINT_ID => $constraintId ] |
|
189 | + [self::PARAM_CONSTRAINT_ID => $constraintId] |
|
190 | 190 | ); |
191 | 191 | } |
192 | 192 | }, |
@@ -198,12 +198,12 @@ discard block |
||
198 | 198 | * @param PropertyId[] $propertyIds |
199 | 199 | * @param ApiResult $result |
200 | 200 | */ |
201 | - private function checkPropertyIds( array $propertyIds, ApiResult $result ) { |
|
202 | - foreach ( $propertyIds as $propertyId ) { |
|
203 | - $result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' ); |
|
204 | - $allConstraintExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnPropertyId( $propertyId ); |
|
205 | - foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) { |
|
206 | - $this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result ); |
|
201 | + private function checkPropertyIds(array $propertyIds, ApiResult $result) { |
|
202 | + foreach ($propertyIds as $propertyId) { |
|
203 | + $result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc'); |
|
204 | + $allConstraintExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnPropertyId($propertyId); |
|
205 | + foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) { |
|
206 | + $this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result); |
|
207 | 207 | } |
208 | 208 | } |
209 | 209 | } |
@@ -212,14 +212,14 @@ discard block |
||
212 | 212 | * @param string[] $constraintIds |
213 | 213 | * @param ApiResult $result |
214 | 214 | */ |
215 | - private function checkConstraintIds( array $constraintIds, ApiResult $result ) { |
|
216 | - foreach ( $constraintIds as $constraintId ) { |
|
217 | - if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) { |
|
215 | + private function checkConstraintIds(array $constraintIds, ApiResult $result) { |
|
216 | + foreach ($constraintIds as $constraintId) { |
|
217 | + if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) { |
|
218 | 218 | // already checked as part of checkPropertyIds() |
219 | 219 | continue; |
220 | 220 | } |
221 | - $constraintParameterExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnConstraintId( $constraintId ); |
|
222 | - $this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result ); |
|
221 | + $constraintParameterExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnConstraintId($constraintId); |
|
222 | + $this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result); |
|
223 | 223 | } |
224 | 224 | } |
225 | 225 | |
@@ -227,17 +227,17 @@ discard block |
||
227 | 227 | * @param PropertyId $propertyId |
228 | 228 | * @return string[] |
229 | 229 | */ |
230 | - private function getResultPathForPropertyId( PropertyId $propertyId ) { |
|
231 | - return [ $this->getModuleName(), $propertyId->getSerialization() ]; |
|
230 | + private function getResultPathForPropertyId(PropertyId $propertyId) { |
|
231 | + return [$this->getModuleName(), $propertyId->getSerialization()]; |
|
232 | 232 | } |
233 | 233 | |
234 | 234 | /** |
235 | 235 | * @param string $constraintId |
236 | 236 | * @return string[] |
237 | 237 | */ |
238 | - private function getResultPathForConstraintId( $constraintId ) { |
|
239 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
240 | - return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] ); |
|
238 | + private function getResultPathForConstraintId($constraintId) { |
|
239 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
240 | + return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]); |
|
241 | 241 | } |
242 | 242 | |
243 | 243 | /** |
@@ -247,9 +247,9 @@ discard block |
||
247 | 247 | * @param ConstraintParameterException[]|null $constraintParameterExceptions |
248 | 248 | * @param ApiResult $result |
249 | 249 | */ |
250 | - private function addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, ApiResult $result ) { |
|
251 | - $path = $this->getResultPathForConstraintId( $constraintId ); |
|
252 | - if ( $constraintParameterExceptions === null ) { |
|
250 | + private function addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, ApiResult $result) { |
|
251 | + $path = $this->getResultPathForConstraintId($constraintId); |
|
252 | + if ($constraintParameterExceptions === null) { |
|
253 | 253 | $result->addValue( |
254 | 254 | $path, |
255 | 255 | self::KEY_STATUS, |
@@ -259,12 +259,12 @@ discard block |
||
259 | 259 | $result->addValue( |
260 | 260 | $path, |
261 | 261 | self::KEY_STATUS, |
262 | - empty( $constraintParameterExceptions ) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY |
|
262 | + empty($constraintParameterExceptions) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY |
|
263 | 263 | ); |
264 | 264 | $result->addValue( |
265 | 265 | $path, |
266 | 266 | self::KEY_PROBLEMS, |
267 | - array_map( [ $this, 'formatConstraintParameterException' ], $constraintParameterExceptions ) |
|
267 | + array_map([$this, 'formatConstraintParameterException'], $constraintParameterExceptions) |
|
268 | 268 | ); |
269 | 269 | } |
270 | 270 | } |
@@ -275,7 +275,7 @@ discard block |
||
275 | 275 | * @param ConstraintParameterException $e |
276 | 276 | * @return array |
277 | 277 | */ |
278 | - private function formatConstraintParameterException( ConstraintParameterException $e ) { |
|
278 | + private function formatConstraintParameterException(ConstraintParameterException $e) { |
|
279 | 279 | return [ |
280 | 280 | self::KEY_MESSAGE_HTML => $e->getMessage(), |
281 | 281 | ]; |
@@ -86,6 +86,6 @@ |
||
86 | 86 | * @param array|null $result |
87 | 87 | * @param array[] &$container |
88 | 88 | */ |
89 | - public function storeCheckResultInArray( array $result = null, array &$container ); |
|
89 | + public function storeCheckResultInArray(array $result = null, array &$container); |
|
90 | 90 | |
91 | 91 | } |
@@ -36,29 +36,29 @@ discard block |
||
36 | 36 | $propertyId, |
37 | 37 | $statementGuid |
38 | 38 | ) { |
39 | - if ( !array_key_exists( $entityId, $container ) ) { |
|
39 | + if (!array_key_exists($entityId, $container)) { |
|
40 | 40 | $container[$entityId] = []; |
41 | 41 | } |
42 | 42 | $entityContainer = &$container[$entityId]; |
43 | 43 | |
44 | - if ( !array_key_exists( 'claims', $entityContainer ) ) { |
|
44 | + if (!array_key_exists('claims', $entityContainer)) { |
|
45 | 45 | $entityContainer['claims'] = []; |
46 | 46 | } |
47 | 47 | $claimsContainer = &$entityContainer['claims']; |
48 | 48 | |
49 | - if ( !array_key_exists( $propertyId, $claimsContainer ) ) { |
|
49 | + if (!array_key_exists($propertyId, $claimsContainer)) { |
|
50 | 50 | $claimsContainer[$propertyId] = []; |
51 | 51 | } |
52 | 52 | $propertyContainer = &$claimsContainer[$propertyId]; |
53 | 53 | |
54 | - foreach ( $propertyContainer as &$statement ) { |
|
55 | - if ( $statement['id'] === $statementGuid ) { |
|
54 | + foreach ($propertyContainer as &$statement) { |
|
55 | + if ($statement['id'] === $statementGuid) { |
|
56 | 56 | $statementArray = &$statement; |
57 | 57 | break; |
58 | 58 | } |
59 | 59 | } |
60 | - if ( !isset( $statementArray ) ) { |
|
61 | - $statementArray = [ 'id' => $statementGuid ]; |
|
60 | + if (!isset($statementArray)) { |
|
61 | + $statementArray = ['id' => $statementGuid]; |
|
62 | 62 | $propertyContainer[] = &$statementArray; |
63 | 63 | } |
64 | 64 | |
@@ -73,19 +73,19 @@ discard block |
||
73 | 73 | * @param array[] &$container |
74 | 74 | * @return array |
75 | 75 | */ |
76 | - abstract protected function &getMainArray( array &$container ); |
|
76 | + abstract protected function &getMainArray(array &$container); |
|
77 | 77 | |
78 | 78 | /** |
79 | 79 | * @param array|null $result |
80 | 80 | * @param array[] &$container |
81 | 81 | */ |
82 | - public function storeCheckResultInArray( array $result = null, array &$container ) { |
|
83 | - $mainArray = &$this->getMainArray( $container ); |
|
84 | - if ( !array_key_exists( 'results', $mainArray ) ) { |
|
82 | + public function storeCheckResultInArray(array $result = null, array &$container) { |
|
83 | + $mainArray = &$this->getMainArray($container); |
|
84 | + if (!array_key_exists('results', $mainArray)) { |
|
85 | 85 | $mainArray['results'] = []; |
86 | 86 | } |
87 | 87 | |
88 | - if ( $result !== null ) { |
|
88 | + if ($result !== null) { |
|
89 | 89 | $mainArray['results'][] = $result; |
90 | 90 | } |
91 | 91 | } |