Completed
Push — master ( aa4c74...3cf82e )
by
unknown
40s
created
src/ConstraintCheck/Context/ApiV2ContextCursor.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -27,15 +27,15 @@  discard block
 block discarded – undo
27 27
 	 * @param array[] &$container
28 28
 	 * @return array
29 29
 	 */
30
-	protected function &getClaimsArray( array &$container ) {
30
+	protected function &getClaimsArray(array &$container) {
31 31
 		$entityId = $this->getEntityId();
32 32
 
33
-		if ( !array_key_exists( $entityId, $container ) ) {
33
+		if (!array_key_exists($entityId, $container)) {
34 34
 			$container[$entityId] = [];
35 35
 		}
36 36
 		$entityContainer = &$container[$entityId];
37 37
 
38
-		if ( !array_key_exists( 'claims', $entityContainer ) ) {
38
+		if (!array_key_exists('claims', $entityContainer)) {
39 39
 			$entityContainer['claims'] = [];
40 40
 		}
41 41
 		$claimsArray = &$entityContainer['claims'];
@@ -49,25 +49,25 @@  discard block
 block discarded – undo
49 49
 	 * @param array[] &$container
50 50
 	 * @return array
51 51
 	 */
52
-	protected function &getStatementArray( array &$container ) {
52
+	protected function &getStatementArray(array &$container) {
53 53
 		$statementPropertyId = $this->getStatementPropertyId();
54 54
 		$statementGuid = $this->getStatementGuid();
55 55
 
56
-		$claimsContainer = &$this->getClaimsArray( $container );
56
+		$claimsContainer = &$this->getClaimsArray($container);
57 57
 
58
-		if ( !array_key_exists( $statementPropertyId, $claimsContainer ) ) {
58
+		if (!array_key_exists($statementPropertyId, $claimsContainer)) {
59 59
 			$claimsContainer[$statementPropertyId] = [];
60 60
 		}
61 61
 		$propertyContainer = &$claimsContainer[$statementPropertyId];
62 62
 
63
-		foreach ( $propertyContainer as &$statement ) {
64
-			if ( $statement['id'] === $statementGuid ) {
63
+		foreach ($propertyContainer as &$statement) {
64
+			if ($statement['id'] === $statementGuid) {
65 65
 				$statementArray = &$statement;
66 66
 				break;
67 67
 			}
68 68
 		}
69
-		if ( !isset( $statementArray ) ) {
70
-			$statementArray = [ 'id' => $statementGuid ];
69
+		if (!isset($statementArray)) {
70
+			$statementArray = ['id' => $statementGuid];
71 71
 			$propertyContainer[] = &$statementArray;
72 72
 		}
73 73
 
@@ -82,19 +82,19 @@  discard block
 block discarded – undo
82 82
 	 * @param array[] &$container
83 83
 	 * @return array
84 84
 	 */
85
-	abstract protected function &getMainArray( array &$container );
85
+	abstract protected function &getMainArray(array &$container);
86 86
 
87 87
 	/**
88 88
 	 * @param ?array $result
89 89
 	 * @param array[] &$container
90 90
 	 */
91
-	public function storeCheckResultInArray( ?array $result, array &$container ) {
92
-		$mainArray = &$this->getMainArray( $container );
93
-		if ( !array_key_exists( 'results', $mainArray ) ) {
91
+	public function storeCheckResultInArray(?array $result, array &$container) {
92
+		$mainArray = &$this->getMainArray($container);
93
+		if (!array_key_exists('results', $mainArray)) {
94 94
 			$mainArray['results'] = [];
95 95
 		}
96 96
 
97
-		if ( $result !== null ) {
97
+		if ($result !== null) {
98 98
 			$mainArray['results'][] = $result;
99 99
 		}
100 100
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/ItemIdSnakValue.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @param ItemId $itemId
45 45
 	 * @return self
46 46
 	 */
47
-	public static function fromItemId( ItemId $itemId ) {
47
+	public static function fromItemId(ItemId $itemId) {
48 48
 		$ret = new self;
49 49
 		$ret->itemId = $itemId;
50 50
 		return $ret;
@@ -80,14 +80,14 @@  discard block
 block discarded – undo
80 80
 	 * @throws InvalidArgumentException
81 81
 	 * @return self
82 82
 	 */
83
-	public static function fromSnak( Snak $snak ) {
84
-		switch ( true ) {
83
+	public static function fromSnak(Snak $snak) {
84
+		switch (true) {
85 85
 			case $snak instanceof PropertyValueSnak:
86 86
 				$dataValue = $snak->getDataValue();
87
-				if ( $dataValue instanceof EntityIdValue ) {
87
+				if ($dataValue instanceof EntityIdValue) {
88 88
 					$itemId = $dataValue->getEntityId();
89
-					if ( $itemId instanceof ItemId ) {
90
-						return self::fromItemId( $itemId );
89
+					if ($itemId instanceof ItemId) {
90
+						return self::fromItemId($itemId);
91 91
 					}
92 92
 				}
93 93
 				break;
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 				return self::noValue();
98 98
 		}
99 99
 
100
-		throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' );
100
+		throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak');
101 101
 	}
102 102
 
103 103
 	/**
@@ -135,8 +135,8 @@  discard block
 block discarded – undo
135 135
 	 * @return ItemId
136 136
 	 */
137 137
 	public function getItemId() {
138
-		if ( !$this->isValue() ) {
139
-			throw new DomainException( 'This value does not contain an item ID.' );
138
+		if (!$this->isValue()) {
139
+			throw new DomainException('This value does not contain an item ID.');
140 140
 		}
141 141
 		return $this->itemId;
142 142
 	}
@@ -148,14 +148,14 @@  discard block
 block discarded – undo
148 148
 	 * @param Snak $snak
149 149
 	 * @return bool
150 150
 	 */
151
-	public function matchesSnak( Snak $snak ) {
152
-		switch ( true ) {
151
+	public function matchesSnak(Snak $snak) {
152
+		switch (true) {
153 153
 			case $snak instanceof PropertyValueSnak:
154 154
 				$dataValue = $snak->getDataValue();
155 155
 				return $this->isValue() &&
156 156
 					$dataValue instanceof EntityIdValue &&
157 157
 					$dataValue->getEntityId() instanceof ItemId &&
158
-					$dataValue->getEntityId()->equals( $this->getItemId() );
158
+					$dataValue->getEntityId()->equals($this->getItemId());
159 159
 			case $snak instanceof PropertySomeValueSnak:
160 160
 				return $this->isSomeValue();
161 161
 			case $snak instanceof PropertyNoValueSnak:
Please login to merge, or discard this patch.
src/Api/CheckConstraintsRdf.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 		EntityIdLookup $entityIdLookup,
48 48
 		RdfVocabulary $rdfVocabulary
49 49
 	) {
50
-		parent::__construct( $page, $context );
50
+		parent::__construct($page, $context);
51 51
 		$this->resultsSource = $resultsSource;
52 52
 		$this->entityIdLookup = $entityIdLookup;
53 53
 		$this->rdfVocabulary = $rdfVocabulary;
@@ -108,8 +108,8 @@  discard block
 block discarded – undo
108 108
 	 * @param string $guid
109 109
 	 * @return string
110 110
 	 */
111
-	private function cleanupGuid( $guid ) {
112
-		return preg_replace( '/[^\w-]/', '-', $guid );
111
+	private function cleanupGuid($guid) {
112
+		return preg_replace('/[^\w-]/', '-', $guid);
113 113
 	}
114 114
 
115 115
 	/**
@@ -121,60 +121,60 @@  discard block
 block discarded – undo
121 121
 		$response = $this->getRequest()->response();
122 122
 		$this->getOutput()->disable();
123 123
 
124
-		if ( !$this->resultsSource instanceof CachingResultsSource ) {
124
+		if (!$this->resultsSource instanceof CachingResultsSource) {
125 125
 			// TODO: make configurable whether only cached results are returned
126
-			$response->statusHeader( 501 ); // Not Implemented
126
+			$response->statusHeader(501); // Not Implemented
127 127
 			return null;
128 128
 		}
129 129
 
130
-		$entityId = $this->entityIdLookup->getEntityIdForTitle( $this->getTitle() );
131
-		if ( $entityId === null ) {
132
-			$response->statusHeader( 404 ); // Not Found
130
+		$entityId = $this->entityIdLookup->getEntityIdForTitle($this->getTitle());
131
+		if ($entityId === null) {
132
+			$response->statusHeader(404); // Not Found
133 133
 			return null;
134 134
 		}
135
-		$revId = $this->getRequest()->getInt( 'revision' );
135
+		$revId = $this->getRequest()->getInt('revision');
136 136
 
137
-		$results = $this->resultsSource->getStoredResults( $entityId, $revId );
138
-		if ( $results === null ) {
139
-			$response->statusHeader( 204 ); // No Content
137
+		$results = $this->resultsSource->getStoredResults($entityId, $revId);
138
+		if ($results === null) {
139
+			$response->statusHeader(204); // No Content
140 140
 			return null;
141 141
 		}
142 142
 
143 143
 		$format = 'ttl'; // TODO: make format an option
144 144
 
145 145
 		$writerFactory = new RdfWriterFactory();
146
-		$formatName = $writerFactory->getFormatName( $format );
147
-		$contentType = $writerFactory->getMimeTypes( $formatName )[0];
146
+		$formatName = $writerFactory->getFormatName($format);
147
+		$contentType = $writerFactory->getMimeTypes($formatName)[0];
148 148
 
149
-		$writer = $writerFactory->getWriter( $formatName );
150
-		foreach ( [ RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY ] as $ns ) {
151
-			$writer->prefix( $ns, $this->rdfVocabulary->getNamespaceURI( $ns ) );
149
+		$writer = $writerFactory->getWriter($formatName);
150
+		foreach ([RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY] as $ns) {
151
+			$writer->prefix($ns, $this->rdfVocabulary->getNamespaceURI($ns));
152 152
 		}
153 153
 		$writer->start();
154 154
 		$writtenAny = false;
155 155
 
156
-		foreach ( $results->getArray() as $checkResult ) {
157
-			if ( $checkResult instanceof NullResult ) {
156
+		foreach ($results->getArray() as $checkResult) {
157
+			if ($checkResult instanceof NullResult) {
158 158
 				continue;
159 159
 			}
160
-			if ( $checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS ) {
160
+			if ($checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS) {
161 161
 				continue;
162 162
 			}
163 163
 			$writtenAny = true;
164
-			$writer->about( RdfVocabulary::NS_STATEMENT,
165
-				$this->cleanupGuid( $checkResult->getContextCursor()->getStatementGuid() ) )
166
-				->say( RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint' )
167
-				->is( RdfVocabulary::NS_STATEMENT,
168
-					$this->cleanupGuid( $checkResult->getConstraint()->getConstraintId() ) );
164
+			$writer->about(RdfVocabulary::NS_STATEMENT,
165
+				$this->cleanupGuid($checkResult->getContextCursor()->getStatementGuid()))
166
+				->say(RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint')
167
+				->is(RdfVocabulary::NS_STATEMENT,
168
+					$this->cleanupGuid($checkResult->getConstraint()->getConstraintId()));
169 169
 		}
170 170
 		$writer->finish();
171
-		if ( $writtenAny ) {
172
-			$response->header( "Content-Type: $contentType; charset=UTF-8" );
171
+		if ($writtenAny) {
172
+			$response->header("Content-Type: $contentType; charset=UTF-8");
173 173
 			echo $writer->drain();
174 174
 		} else {
175 175
 			// Do not output RDF if we haven't written any actual statements. Output 204 instead
176 176
 			$writer->drain();
177
-			$response->statusHeader( 204 ); // No Content
177
+			$response->statusHeader(204); // No Content
178 178
 		}
179 179
 		return null;
180 180
 	}
Please login to merge, or discard this patch.
src/Job/CheckConstraintsJob.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -37,25 +37,25 @@  discard block
 block discarded – undo
37 37
 	 * @param Title $title
38 38
 	 * @param string[] $params should contain 'entityId' => 'Q1234'
39 39
 	 */
40
-	public function __construct( Title $title, array $params ) {
41
-		parent::__construct( self::COMMAND, $title, $params );
40
+	public function __construct(Title $title, array $params) {
41
+		parent::__construct(self::COMMAND, $title, $params);
42 42
 		$this->removeDuplicates = true;
43 43
 
44
-		Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' );
44
+		Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']');
45 45
 
46
-		$resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() );
46
+		$resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance());
47 47
 		'@phan-var CachingResultsSource $resultSource';
48 48
 		// This job should only ever be used when caching result sources are used.
49
-		$this->setResultsSource( $resultSource );
49
+		$this->setResultsSource($resultSource);
50 50
 
51
-		$this->setEntityIdParser( WikibaseRepo::getEntityIdParser() );
51
+		$this->setEntityIdParser(WikibaseRepo::getEntityIdParser());
52 52
 	}
53 53
 
54
-	public function setResultsSource( CachingResultsSource $resultsSource ) {
54
+	public function setResultsSource(CachingResultsSource $resultsSource) {
55 55
 		$this->resultsSource = $resultsSource;
56 56
 	}
57 57
 
58
-	public function setEntityIdParser( EntityIdParser $parser ) {
58
+	public function setEntityIdParser(EntityIdParser $parser) {
59 59
 		$this->entityIdParser = $parser;
60 60
 	}
61 61
 
@@ -66,19 +66,19 @@  discard block
 block discarded – undo
66 66
 	 */
67 67
 	public function run() {
68 68
 		try {
69
-			$entityId = $this->entityIdParser->parse( $this->params['entityId'] );
70
-		} catch ( EntityIdParsingException $e ) {
69
+			$entityId = $this->entityIdParser->parse($this->params['entityId']);
70
+		} catch (EntityIdParsingException $e) {
71 71
 			return false;
72 72
 		}
73 73
 
74
-		$this->checkConstraints( $entityId );
74
+		$this->checkConstraints($entityId);
75 75
 
76 76
 		return true;
77 77
 	}
78 78
 
79
-	private function checkConstraints( EntityId $entityId ) {
79
+	private function checkConstraints(EntityId $entityId) {
80 80
 		$this->resultsSource->getResults(
81
-			[ $entityId ],
81
+			[$entityId],
82 82
 			[],
83 83
 			null,
84 84
 			[]
Please login to merge, or discard this patch.
src/WikibaseServices.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -20,35 +20,35 @@
 block discarded – undo
20 20
 	public const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup';
21 21
 	public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
22 22
 
23
-	private static function getService( ?MediaWikiServices $services, $name ) {
24
-		if ( $services === null ) {
23
+	private static function getService(?MediaWikiServices $services, $name) {
24
+		if ($services === null) {
25 25
 			$services = MediaWikiServices::getInstance();
26 26
 		}
27
-		return $services->getService( $name );
27
+		return $services->getService($name);
28 28
 	}
29 29
 
30 30
 	/**
31 31
 	 * @param MediaWikiServices|null $services
32 32
 	 * @return EntityLookup
33 33
 	 */
34
-	public static function getEntityLookup( MediaWikiServices $services = null ) {
35
-		return self::getService( $services, self::ENTITY_LOOKUP );
34
+	public static function getEntityLookup(MediaWikiServices $services = null) {
35
+		return self::getService($services, self::ENTITY_LOOKUP);
36 36
 	}
37 37
 
38 38
 	/**
39 39
 	 * @param MediaWikiServices|null $services
40 40
 	 * @return PropertyDataTypeLookup
41 41
 	 */
42
-	public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) {
43
-		return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP );
42
+	public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) {
43
+		return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP);
44 44
 	}
45 45
 
46 46
 	/**
47 47
 	 * @param MediaWikiServices|null $services
48 48
 	 * @return EntityLookup
49 49
 	 */
50
-	public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ) {
51
-		return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE );
50
+	public static function getEntityLookupWithoutCache(MediaWikiServices $services = null) {
51
+		return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE);
52 52
 	}
53 53
 
54 54
 }
Please login to merge, or discard this patch.
maintenance/ImportConstraintStatements.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -11,10 +11,10 @@  discard block
 block discarded – undo
11 11
 use Wikimedia\Rdbms\ILBFactory;
12 12
 
13 13
 // @codeCoverageIgnoreStart
14
-$basePath = getenv( "MW_INSTALL_PATH" ) !== false
15
-	? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../..";
14
+$basePath = getenv("MW_INSTALL_PATH") !== false
15
+	? getenv("MW_INSTALL_PATH") : __DIR__."/../../..";
16 16
 
17
-require_once $basePath . "/maintenance/Maintenance.php";
17
+require_once $basePath."/maintenance/Maintenance.php";
18 18
 // @codeCoverageIgnoreEnd
19 19
 
20 20
 /**
@@ -46,57 +46,57 @@  discard block
 block discarded – undo
46 46
 
47 47
 	public function __construct() {
48 48
 		parent::__construct();
49
-		$this->newUpdateConstraintsTableJob = static function ( $propertyIdSerialization ) {
49
+		$this->newUpdateConstraintsTableJob = static function($propertyIdSerialization) {
50 50
 			return UpdateConstraintsTableJob::newFromGlobalState(
51 51
 				Title::newMainPage(),
52
-				[ 'propertyId' => $propertyIdSerialization ]
52
+				['propertyId' => $propertyIdSerialization]
53 53
 			);
54 54
 		};
55 55
 
56
-		$this->addDescription( 'Imports property constraints from statements on properties' );
57
-		$this->requireExtension( 'WikibaseQualityConstraints' );
58
-		$this->setBatchSize( 10 );
56
+		$this->addDescription('Imports property constraints from statements on properties');
57
+		$this->requireExtension('WikibaseQualityConstraints');
58
+		$this->setBatchSize(10);
59 59
 
60 60
 		// Wikibase classes are not yet loaded, so setup services in a callback run in execute
61 61
 		// that can be overridden in tests.
62
-		$this->setupServices = function () {
62
+		$this->setupServices = function() {
63 63
 			$services = MediaWikiServices::getInstance();
64
-			$this->propertyInfoLookup = WikibaseRepo::getStore( $services )->getPropertyInfoLookup();
64
+			$this->propertyInfoLookup = WikibaseRepo::getStore($services)->getPropertyInfoLookup();
65 65
 			$this->lbFactory = $services->getDBLoadBalancerFactory();
66 66
 		};
67 67
 	}
68 68
 
69 69
 	public function execute() {
70
-		( $this->setupServices )();
71
-		if ( !$this->getConfig()->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) ) {
72
-			$this->error( 'Constraint statements are not enabled. Aborting.' );
70
+		($this->setupServices)();
71
+		if (!$this->getConfig()->get('WBQualityConstraintsEnableConstraintsImportFromStatements')) {
72
+			$this->error('Constraint statements are not enabled. Aborting.');
73 73
 			return;
74 74
 		}
75 75
 
76 76
 		$propertyInfos = $this->propertyInfoLookup->getAllPropertyInfo();
77
-		$propertyIds = array_keys( $propertyInfos );
77
+		$propertyIds = array_keys($propertyInfos);
78 78
 
79
-		foreach ( array_chunk( $propertyIds, $this->getBatchSize() ) as $propertyIdsChunk ) {
80
-			foreach ( $propertyIdsChunk as $propertyIdSerialization ) {
81
-				$this->output( sprintf(
79
+		foreach (array_chunk($propertyIds, $this->getBatchSize()) as $propertyIdsChunk) {
80
+			foreach ($propertyIdsChunk as $propertyIdSerialization) {
81
+				$this->output(sprintf(
82 82
 					'Importing constraint statements for % 6s... ',
83 83
 					$propertyIdSerialization ),
84 84
 					$propertyIdSerialization
85 85
 				);
86
-				$startTime = microtime( true );
87
-				$job = call_user_func( $this->newUpdateConstraintsTableJob, $propertyIdSerialization );
86
+				$startTime = microtime(true);
87
+				$job = call_user_func($this->newUpdateConstraintsTableJob, $propertyIdSerialization);
88 88
 				$job->run();
89
-				$endTime = microtime( true );
90
-				$millis = ( $endTime - $startTime ) * 1000;
91
-				$this->output( sprintf( 'done in % 6.2f ms.', $millis ), $propertyIdSerialization );
89
+				$endTime = microtime(true);
90
+				$millis = ($endTime - $startTime) * 1000;
91
+				$this->output(sprintf('done in % 6.2f ms.', $millis), $propertyIdSerialization);
92 92
 			}
93 93
 
94
-			$this->output( 'Waiting for replication... ', 'waitForReplication' );
95
-			$startTime = microtime( true );
94
+			$this->output('Waiting for replication... ', 'waitForReplication');
95
+			$startTime = microtime(true);
96 96
 			$this->lbFactory->waitForReplication();
97
-			$endTime = microtime( true );
98
-			$millis = ( $endTime - $startTime ) * 1000;
99
-			$this->output( sprintf( 'done in % 6.2f ms.', $millis ), 'waitForReplication' );
97
+			$endTime = microtime(true);
98
+			$millis = ($endTime - $startTime) * 1000;
99
+			$this->output(sprintf('done in % 6.2f ms.', $millis), 'waitForReplication');
100 100
 		}
101 101
 	}
102 102
 
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/ValueCountCheckerHelper.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
 	 * @param PropertyId $propertyId
21 21
 	 * @return int
22 22
 	 */
23
-	public function getPropertyCount( array $snaks, PropertyId $propertyId ) {
24
-		return count( array_filter(
23
+	public function getPropertyCount(array $snaks, PropertyId $propertyId) {
24
+		return count(array_filter(
25 25
 			$snaks,
26
-			static function ( Snak $snak ) use ( $propertyId ) {
27
-				return $snak->getPropertyId()->equals( $propertyId );
26
+			static function(Snak $snak) use ($propertyId) {
27
+				return $snak->getPropertyId()->equals($propertyId);
28 28
 			}
29
-		) );
29
+		));
30 30
 	}
31 31
 
32 32
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/TypeChecker.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -75,12 +75,12 @@  discard block
 block discarded – undo
75 75
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
76 76
 	 * @return CheckResult
77 77
 	 */
78
-	public function checkConstraint( Context $context, Constraint $constraint ) {
79
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
80
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
78
+	public function checkConstraint(Context $context, Constraint $constraint) {
79
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
80
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
81 81
 		}
82
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
83
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE );
82
+		if ($context->getType() === Context::TYPE_REFERENCE) {
83
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE);
84 84
 		}
85 85
 
86 86
 		$parameters = [];
@@ -92,8 +92,8 @@  discard block
 block discarded – undo
92 92
 			$constraintTypeItemId
93 93
 		);
94 94
 		$parameters['class'] = array_map(
95
-			static function ( $id ) {
96
-				return new ItemId( $id );
95
+			static function($id) {
96
+				return new ItemId($id);
97 97
 			},
98 98
 			$classes
99 99
 		);
@@ -103,13 +103,13 @@  discard block
 block discarded – undo
103 103
 			$constraintTypeItemId
104 104
 		);
105 105
 		$relationIds = [];
106
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
107
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
106
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
107
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
108 108
 		}
109
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
110
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
109
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
110
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
111 111
 		}
112
-		$parameters['relation'] = [ $relation ];
112
+		$parameters['relation'] = [$relation];
113 113
 
114 114
 		$result = $this->typeCheckerHelper->hasClassInRelation(
115 115
 			$context->getEntity()->getStatements(),
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 			$classes
118 118
 		);
119 119
 
120
-		if ( $result->getBool() ) {
120
+		if ($result->getBool()) {
121 121
 			$message = null;
122 122
 			$status = CheckResult::STATUS_COMPLIANCE;
123 123
 		} else {
@@ -131,11 +131,11 @@  discard block
 block discarded – undo
131 131
 			$status = CheckResult::STATUS_VIOLATION;
132 132
 		}
133 133
 
134
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
135
-			->withMetadata( $result->getMetadata() );
134
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
135
+			->withMetadata($result->getMetadata());
136 136
 	}
137 137
 
138
-	public function checkConstraintParameters( Constraint $constraint ) {
138
+	public function checkConstraintParameters(Constraint $constraint) {
139 139
 		$constraintParameters = $constraint->getConstraintParameters();
140 140
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
141 141
 		$exceptions = [];
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 				$constraintParameters,
145 145
 				$constraintTypeItemId
146 146
 			);
147
-		} catch ( ConstraintParameterException $e ) {
147
+		} catch (ConstraintParameterException $e) {
148 148
 			$exceptions[] = $e;
149 149
 		}
150 150
 		try {
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 				$constraintParameters,
153 153
 				$constraintTypeItemId
154 154
 			);
155
-		} catch ( ConstraintParameterException $e ) {
155
+		} catch (ConstraintParameterException $e) {
156 156
 			$exceptions[] = $e;
157 157
 		}
158 158
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ValueTypeChecker.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
91 91
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
92 92
 	 * @return CheckResult
93 93
 	 */
94
-	public function checkConstraint( Context $context, Constraint $constraint ) {
95
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
96
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
94
+	public function checkConstraint(Context $context, Constraint $constraint) {
95
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
96
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
97 97
 		}
98 98
 
99 99
 		$parameters = [];
@@ -105,8 +105,8 @@  discard block
 block discarded – undo
105 105
 			$constraintTypeItemId
106 106
 		);
107 107
 		$parameters['class'] = array_map(
108
-			static function ( $id ) {
109
-				return new ItemId( $id );
108
+			static function($id) {
109
+				return new ItemId($id);
110 110
 			},
111 111
 			$classes
112 112
 		);
@@ -116,19 +116,19 @@  discard block
 block discarded – undo
116 116
 			$constraintTypeItemId
117 117
 		);
118 118
 		$relationIds = [];
119
-		if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) {
120
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' );
119
+		if ($relation === 'instance' || $relation === 'instanceOrSubclass') {
120
+			$relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId');
121 121
 		}
122
-		if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) {
123
-			$relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
122
+		if ($relation === 'subclass' || $relation === 'instanceOrSubclass') {
123
+			$relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId');
124 124
 		}
125
-		$parameters['relation'] = [ $relation ];
125
+		$parameters['relation'] = [$relation];
126 126
 
127 127
 		$snak = $context->getSnak();
128 128
 
129
-		if ( !$snak instanceof PropertyValueSnak ) {
129
+		if (!$snak instanceof PropertyValueSnak) {
130 130
 			// nothing to check
131
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
131
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
132 132
 		}
133 133
 
134 134
 		$dataValue = $snak->getDataValue();
@@ -137,23 +137,23 @@  discard block
 block discarded – undo
137 137
 		 * error handling:
138 138
 		 *   type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid'
139 139
 		 */
140
-		if ( !$dataValue instanceof EntityIdValue ) {
141
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
142
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
143
-				->withDataValueType( 'wikibase-entityid' );
144
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
140
+		if (!$dataValue instanceof EntityIdValue) {
141
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
142
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
143
+				->withDataValueType('wikibase-entityid');
144
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
145 145
 		}
146 146
 
147 147
 		try {
148
-			$item = $this->entityLookup->getEntity( $dataValue->getEntityId() );
149
-		} catch ( UnresolvedEntityRedirectException $e ) {
148
+			$item = $this->entityLookup->getEntity($dataValue->getEntityId());
149
+		} catch (UnresolvedEntityRedirectException $e) {
150 150
 			// Edge case (double redirect): Pretend the entity doesn't exist
151 151
 			$item = null;
152 152
 		}
153 153
 
154
-		if ( !( $item instanceof StatementListProvidingEntity ) ) {
155
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
156
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
154
+		if (!($item instanceof StatementListProvidingEntity)) {
155
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
156
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
157 157
 		}
158 158
 
159 159
 		$statements = $item->getStatements();
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 			$classes
165 165
 		);
166 166
 
167
-		if ( $result->getBool() ) {
167
+		if ($result->getBool()) {
168 168
 			$message = null;
169 169
 			$status = CheckResult::STATUS_COMPLIANCE;
170 170
 		} else {
@@ -178,11 +178,11 @@  discard block
 block discarded – undo
178 178
 			$status = CheckResult::STATUS_VIOLATION;
179 179
 		}
180 180
 
181
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
182
-			->withMetadata( $result->getMetadata() );
181
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
182
+			->withMetadata($result->getMetadata());
183 183
 	}
184 184
 
185
-	public function checkConstraintParameters( Constraint $constraint ) {
185
+	public function checkConstraintParameters(Constraint $constraint) {
186 186
 		$constraintParameters = $constraint->getConstraintParameters();
187 187
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
188 188
 		$exceptions = [];
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 				$constraintParameters,
192 192
 				$constraintTypeItemId
193 193
 			);
194
-		} catch ( ConstraintParameterException $e ) {
194
+		} catch (ConstraintParameterException $e) {
195 195
 			$exceptions[] = $e;
196 196
 		}
197 197
 		try {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 				$constraintParameters,
200 200
 				$constraintTypeItemId
201 201
 			);
202
-		} catch ( ConstraintParameterException $e ) {
202
+		} catch (ConstraintParameterException $e) {
203 203
 			$exceptions[] = $e;
204 204
 		}
205 205
 		return $exceptions;
Please login to merge, or discard this patch.