@@ -53,7 +53,7 @@ discard block |
||
| 53 | 53 | $this->config = $config; |
| 54 | 54 | $this->timeParser = new IsoTimestampParser(); |
| 55 | 55 | $this->timeCalculator = new TimeValueCalculator(); |
| 56 | - $this->timeValueComparer = new TimeValueComparer( $this->timeCalculator ); |
|
| 56 | + $this->timeValueComparer = new TimeValueComparer($this->timeCalculator); |
|
| 57 | 57 | $this->unitConverter = $unitConverter; |
| 58 | 58 | } |
| 59 | 59 | |
@@ -61,10 +61,10 @@ discard block |
||
| 61 | 61 | * @param UnboundedQuantityValue $value |
| 62 | 62 | * @return UnboundedQuantityValue $value converted to standard units if possible, otherwise unchanged $value. |
| 63 | 63 | */ |
| 64 | - private function standardize( UnboundedQuantityValue $value ) { |
|
| 65 | - if ( $this->unitConverter !== null ) { |
|
| 66 | - $standard = $this->unitConverter->toStandardUnits( $value ); |
|
| 67 | - if ( $standard !== null ) { |
|
| 64 | + private function standardize(UnboundedQuantityValue $value) { |
|
| 65 | + if ($this->unitConverter !== null) { |
|
| 66 | + $standard = $this->unitConverter->toStandardUnits($value); |
|
| 67 | + if ($standard !== null) { |
|
| 68 | 68 | return $standard; |
| 69 | 69 | } else { |
| 70 | 70 | return $value; |
@@ -86,33 +86,33 @@ discard block |
||
| 86 | 86 | * when $lhs is respectively less than, equal to, or greater than $rhs. |
| 87 | 87 | * (In other words, just like the “spaceship” operator <=>.) |
| 88 | 88 | */ |
| 89 | - public function getComparison( ?DataValue $lhs, ?DataValue $rhs ) { |
|
| 90 | - if ( $lhs === null || $rhs === null ) { |
|
| 89 | + public function getComparison(?DataValue $lhs, ?DataValue $rhs) { |
|
| 90 | + if ($lhs === null || $rhs === null) { |
|
| 91 | 91 | return 0; |
| 92 | 92 | } |
| 93 | 93 | |
| 94 | - if ( $lhs->getType() !== $rhs->getType() ) { |
|
| 95 | - throw new InvalidArgumentException( 'Different data value types' ); |
|
| 94 | + if ($lhs->getType() !== $rhs->getType()) { |
|
| 95 | + throw new InvalidArgumentException('Different data value types'); |
|
| 96 | 96 | } |
| 97 | 97 | |
| 98 | - switch ( $lhs->getType() ) { |
|
| 98 | + switch ($lhs->getType()) { |
|
| 99 | 99 | case 'time': |
| 100 | 100 | /** @var TimeValue $lhs */ |
| 101 | 101 | /** @var TimeValue $rhs */ |
| 102 | 102 | '@phan-var TimeValue $lhs'; |
| 103 | 103 | '@phan-var TimeValue $rhs'; |
| 104 | - return $this->timeValueComparer->getComparison( $lhs, $rhs ); |
|
| 104 | + return $this->timeValueComparer->getComparison($lhs, $rhs); |
|
| 105 | 105 | case 'quantity': |
| 106 | 106 | /** @var QuantityValue|UnboundedQuantityValue $lhs */ |
| 107 | 107 | /** @var QuantityValue|UnboundedQuantityValue $rhs */ |
| 108 | 108 | '@phan-var QuantityValue|UnboundedQuantityValue $lhs'; |
| 109 | 109 | '@phan-var QuantityValue|UnboundedQuantityValue $rhs'; |
| 110 | - $lhsStandard = $this->standardize( $lhs ); |
|
| 111 | - $rhsStandard = $this->standardize( $rhs ); |
|
| 112 | - return $lhsStandard->getAmount()->compare( $rhsStandard->getAmount() ); |
|
| 110 | + $lhsStandard = $this->standardize($lhs); |
|
| 111 | + $rhsStandard = $this->standardize($rhs); |
|
| 112 | + return $lhsStandard->getAmount()->compare($rhsStandard->getAmount()); |
|
| 113 | 113 | } |
| 114 | 114 | |
| 115 | - throw new InvalidArgumentException( 'Unsupported data value type' ); |
|
| 115 | + throw new InvalidArgumentException('Unsupported data value type'); |
|
| 116 | 116 | } |
| 117 | 117 | |
| 118 | 118 | /** |
@@ -127,71 +127,71 @@ discard block |
||
| 127 | 127 | * @throws InvalidArgumentException if the values do not both have the same, supported data value type |
| 128 | 128 | * @return UnboundedQuantityValue |
| 129 | 129 | */ |
| 130 | - public function getDifference( DataValue $minuend, DataValue $subtrahend ) { |
|
| 131 | - if ( $minuend->getType() === 'time' && $subtrahend->getType() === 'time' ) { |
|
| 132 | - $minuendSeconds = $this->timeCalculator->getTimestamp( $minuend ); |
|
| 133 | - $subtrahendSeconds = $this->timeCalculator->getTimestamp( $subtrahend ); |
|
| 130 | + public function getDifference(DataValue $minuend, DataValue $subtrahend) { |
|
| 131 | + if ($minuend->getType() === 'time' && $subtrahend->getType() === 'time') { |
|
| 132 | + $minuendSeconds = $this->timeCalculator->getTimestamp($minuend); |
|
| 133 | + $subtrahendSeconds = $this->timeCalculator->getTimestamp($subtrahend); |
|
| 134 | 134 | return UnboundedQuantityValue::newFromNumber( |
| 135 | 135 | $minuendSeconds - $subtrahendSeconds, |
| 136 | - $this->config->get( 'WBQualityConstraintsSecondUnit' ) |
|
| 136 | + $this->config->get('WBQualityConstraintsSecondUnit') |
|
| 137 | 137 | ); |
| 138 | 138 | } |
| 139 | - if ( $minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity' ) { |
|
| 140 | - $minuendStandard = $this->standardize( $minuend ); |
|
| 141 | - $subtrahendStandard = $this->standardize( $subtrahend ); |
|
| 139 | + if ($minuend->getType() === 'quantity' && $subtrahend->getType() === 'quantity') { |
|
| 140 | + $minuendStandard = $this->standardize($minuend); |
|
| 141 | + $subtrahendStandard = $this->standardize($subtrahend); |
|
| 142 | 142 | $minuendValue = $minuendStandard->getAmount()->getValueFloat(); |
| 143 | 143 | $subtrahendValue = $subtrahendStandard->getAmount()->getValueFloat(); |
| 144 | 144 | $diff = $minuendValue - $subtrahendValue; |
| 145 | 145 | // we don’t check whether both quantities have the same standard unit – |
| 146 | 146 | // that’s the job of a different constraint type, Units (T164372) |
| 147 | - return UnboundedQuantityValue::newFromNumber( $diff, $minuendStandard->getUnit() ); |
|
| 147 | + return UnboundedQuantityValue::newFromNumber($diff, $minuendStandard->getUnit()); |
|
| 148 | 148 | } |
| 149 | 149 | |
| 150 | - throw new InvalidArgumentException( 'Unsupported or different data value types' ); |
|
| 150 | + throw new InvalidArgumentException('Unsupported or different data value types'); |
|
| 151 | 151 | } |
| 152 | 152 | |
| 153 | - public function getDifferenceInYears( TimeValue $minuend, TimeValue $subtrahend ): DataValue { |
|
| 154 | - if ( !preg_match( '/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches ) || |
|
| 155 | - !preg_match( '/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches ) |
|
| 153 | + public function getDifferenceInYears(TimeValue $minuend, TimeValue $subtrahend): DataValue { |
|
| 154 | + if (!preg_match('/^([-+]\d{1,16})-(.*)$/', $minuend->getTime(), $minuendMatches) || |
|
| 155 | + !preg_match('/^([-+]\d{1,16})-(.*)$/', $subtrahend->getTime(), $subtrahendMatches) |
|
| 156 | 156 | ) { |
| 157 | - throw new InvalidArgumentException( 'TimeValue::getTime() did not match expected format' ); |
|
| 157 | + throw new InvalidArgumentException('TimeValue::getTime() did not match expected format'); |
|
| 158 | 158 | } |
| 159 | - $minuendYear = (float)$minuendMatches[1]; |
|
| 160 | - $subtrahendYear = (float)$subtrahendMatches[1]; |
|
| 159 | + $minuendYear = (float) $minuendMatches[1]; |
|
| 160 | + $subtrahendYear = (float) $subtrahendMatches[1]; |
|
| 161 | 161 | $minuendRest = $minuendMatches[2]; |
| 162 | 162 | $subtrahendRest = $subtrahendMatches[2]; |
| 163 | 163 | |
| 164 | 164 | // calculate difference of years |
| 165 | 165 | $diff = $minuendYear - $subtrahendYear; |
| 166 | - if ( $minuendYear > 0.0 && $subtrahendYear < 0.0 ) { |
|
| 166 | + if ($minuendYear > 0.0 && $subtrahendYear < 0.0) { |
|
| 167 | 167 | $diff -= 1.0; // there is no year 0, remove it from difference |
| 168 | - } elseif ( $minuendYear < 0.0 && $subtrahendYear > 0.0 ) { |
|
| 168 | + } elseif ($minuendYear < 0.0 && $subtrahendYear > 0.0) { |
|
| 169 | 169 | $diff -= -1.0; // there is no year 0, remove it from negative difference |
| 170 | 170 | } |
| 171 | 171 | |
| 172 | 172 | // adjust for date within year by parsing the month-day part within the same year |
| 173 | - $minuendDateValue = $this->timeParser->parse( '+0000000000001970-' . $minuendRest ); |
|
| 174 | - $subtrahendDateValue = $this->timeParser->parse( '+0000000000001970-' . $subtrahendRest ); |
|
| 175 | - $minuendDateSeconds = $this->timeCalculator->getTimestamp( $minuendDateValue ); |
|
| 176 | - $subtrahendDateSeconds = $this->timeCalculator->getTimestamp( $subtrahendDateValue ); |
|
| 177 | - if ( $minuendDateSeconds < $subtrahendDateSeconds ) { |
|
| 173 | + $minuendDateValue = $this->timeParser->parse('+0000000000001970-'.$minuendRest); |
|
| 174 | + $subtrahendDateValue = $this->timeParser->parse('+0000000000001970-'.$subtrahendRest); |
|
| 175 | + $minuendDateSeconds = $this->timeCalculator->getTimestamp($minuendDateValue); |
|
| 176 | + $subtrahendDateSeconds = $this->timeCalculator->getTimestamp($subtrahendDateValue); |
|
| 177 | + if ($minuendDateSeconds < $subtrahendDateSeconds) { |
|
| 178 | 178 | // difference in the last year is actually less than one full year |
| 179 | 179 | // e. g. 1975-03-01 - 1974-09-01 is just six months |
| 180 | 180 | // (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough) |
| 181 | 181 | $diff -= 0.5; |
| 182 | - } elseif ( $minuendDateSeconds > $subtrahendDateSeconds ) { |
|
| 182 | + } elseif ($minuendDateSeconds > $subtrahendDateSeconds) { |
|
| 183 | 183 | // difference in the last year is actually more than one full year |
| 184 | 184 | // e. g. 1975-09-01 - 1974-03-01 is 18 months |
| 185 | 185 | // (we don’t need sub-year precision in the difference, adjusting by 0.5 is enough) |
| 186 | 186 | $diff += 0.5; |
| 187 | 187 | } |
| 188 | 188 | |
| 189 | - $unit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
| 190 | - return UnboundedQuantityValue::newFromNumber( $diff, $unit ); |
|
| 189 | + $unit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
| 190 | + return UnboundedQuantityValue::newFromNumber($diff, $unit); |
|
| 191 | 191 | } |
| 192 | 192 | |
| 193 | - public function isFutureTime( TimeValue $timeValue ): bool { |
|
| 194 | - return $this->timeValueComparer->isFutureTime( $timeValue ); |
|
| 193 | + public function isFutureTime(TimeValue $timeValue): bool { |
|
| 194 | + return $this->timeValueComparer->isFutureTime($timeValue); |
|
| 195 | 195 | } |
| 196 | 196 | |
| 197 | 197 | } |
@@ -9,8 +9,8 @@ |
||
| 9 | 9 | */ |
| 10 | 10 | class SparqlHelperException extends RuntimeException { |
| 11 | 11 | |
| 12 | - public function __construct( string $msg = 'The SPARQL query endpoint returned an error.' ) { |
|
| 13 | - parent::__construct( $msg ); |
|
| 12 | + public function __construct(string $msg = 'The SPARQL query endpoint returned an error.') { |
|
| 13 | + parent::__construct($msg); |
|
| 14 | 14 | } |
| 15 | 15 | |
| 16 | 16 | } |
@@ -16,27 +16,27 @@ |
||
| 16 | 16 | */ |
| 17 | 17 | private $timeValueCalculator; |
| 18 | 18 | |
| 19 | - public function __construct( ?TimeValueCalculator $timeValueCalculator = null ) { |
|
| 19 | + public function __construct(?TimeValueCalculator $timeValueCalculator = null) { |
|
| 20 | 20 | $this->timeValueCalculator = $timeValueCalculator ?: new TimeValueCalculator(); |
| 21 | 21 | } |
| 22 | 22 | |
| 23 | - public function getComparison( TimeValue $lhs, TimeValue $rhs ): int { |
|
| 24 | - $lhsTimestamp = $this->timeValueCalculator->getTimestamp( $lhs ); |
|
| 25 | - $rhsTimestamp = $this->timeValueCalculator->getTimestamp( $rhs ); |
|
| 23 | + public function getComparison(TimeValue $lhs, TimeValue $rhs): int { |
|
| 24 | + $lhsTimestamp = $this->timeValueCalculator->getTimestamp($lhs); |
|
| 25 | + $rhsTimestamp = $this->timeValueCalculator->getTimestamp($rhs); |
|
| 26 | 26 | |
| 27 | - if ( $lhsTimestamp === $rhsTimestamp ) { |
|
| 27 | + if ($lhsTimestamp === $rhsTimestamp) { |
|
| 28 | 28 | return 0; |
| 29 | 29 | } |
| 30 | 30 | |
| 31 | 31 | return $lhsTimestamp < $rhsTimestamp ? -1 : 1; |
| 32 | 32 | } |
| 33 | 33 | |
| 34 | - public function getMinimum( TimeValue $timeValue1, TimeValue $timeValue2 ): TimeValue { |
|
| 35 | - return $this->getComparison( $timeValue1, $timeValue2 ) <= 0 ? $timeValue1 : $timeValue2; |
|
| 34 | + public function getMinimum(TimeValue $timeValue1, TimeValue $timeValue2): TimeValue { |
|
| 35 | + return $this->getComparison($timeValue1, $timeValue2) <= 0 ? $timeValue1 : $timeValue2; |
|
| 36 | 36 | } |
| 37 | 37 | |
| 38 | - public function isFutureTime( TimeValue $timeValue ): bool { |
|
| 39 | - return $this->getComparison( $timeValue, new NowValue() ) >= 0; |
|
| 38 | + public function isFutureTime(TimeValue $timeValue): bool { |
|
| 39 | + return $this->getComparison($timeValue, new NowValue()) >= 0; |
|
| 40 | 40 | } |
| 41 | 41 | |
| 42 | 42 | } |
@@ -10,14 +10,13 @@ |
||
| 10 | 10 | */ |
| 11 | 11 | class ConstraintDeserializer { |
| 12 | 12 | |
| 13 | - public function deserialize( array $serialization ): Constraint { |
|
| 13 | + public function deserialize(array $serialization): Constraint { |
|
| 14 | 14 | return new Constraint( |
| 15 | 15 | $serialization['id'], |
| 16 | - new NumericPropertyId( $serialization['pid'] ), |
|
| 16 | + new NumericPropertyId($serialization['pid']), |
|
| 17 | 17 | $serialization['qid'], |
| 18 | - array_key_exists( 'params', $serialization ) ? |
|
| 19 | - $serialization['params'] : |
|
| 20 | - [] |
|
| 18 | + array_key_exists('params', $serialization) ? |
|
| 19 | + $serialization['params'] : [] |
|
| 21 | 20 | ); |
| 22 | 21 | } |
| 23 | 22 | |
@@ -44,57 +44,56 @@ |
||
| 44 | 44 | ) { |
| 45 | 45 | $results = []; |
| 46 | 46 | $metadatas = []; |
| 47 | - $statusesFlipped = array_flip( $statuses ); |
|
| 48 | - foreach ( $entityIds as $entityId ) { |
|
| 47 | + $statusesFlipped = array_flip($statuses); |
|
| 48 | + foreach ($entityIds as $entityId) { |
|
| 49 | 49 | $entityResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId( |
| 50 | 50 | $entityId, |
| 51 | 51 | $constraintIds, |
| 52 | - [ $this, 'defaultResultsPerContext' ], |
|
| 53 | - [ $this, 'defaultResultsPerEntity' ] |
|
| 52 | + [$this, 'defaultResultsPerContext'], |
|
| 53 | + [$this, 'defaultResultsPerEntity'] |
|
| 54 | 54 | ); |
| 55 | - foreach ( $entityResults as $result ) { |
|
| 55 | + foreach ($entityResults as $result) { |
|
| 56 | 56 | $metadatas[] = $result->getMetadata(); |
| 57 | - if ( $this->statusSelected( $statusesFlipped, $result ) ) { |
|
| 57 | + if ($this->statusSelected($statusesFlipped, $result)) { |
|
| 58 | 58 | $results[] = $result; |
| 59 | 59 | } |
| 60 | 60 | } |
| 61 | 61 | } |
| 62 | - foreach ( $claimIds as $claimId ) { |
|
| 62 | + foreach ($claimIds as $claimId) { |
|
| 63 | 63 | $claimResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId( |
| 64 | 64 | $claimId, |
| 65 | 65 | $constraintIds, |
| 66 | - [ $this, 'defaultResultsPerContext' ] |
|
| 66 | + [$this, 'defaultResultsPerContext'] |
|
| 67 | 67 | ); |
| 68 | - foreach ( $claimResults as $result ) { |
|
| 68 | + foreach ($claimResults as $result) { |
|
| 69 | 69 | $metadatas[] = $result->getMetadata(); |
| 70 | - if ( $this->statusSelected( $statusesFlipped, $result ) ) { |
|
| 70 | + if ($this->statusSelected($statusesFlipped, $result)) { |
|
| 71 | 71 | $results[] = $result; |
| 72 | 72 | } |
| 73 | 73 | } |
| 74 | 74 | } |
| 75 | 75 | return new CachedCheckResults( |
| 76 | 76 | $results, |
| 77 | - Metadata::merge( $metadatas ) |
|
| 77 | + Metadata::merge($metadatas) |
|
| 78 | 78 | ); |
| 79 | 79 | } |
| 80 | 80 | |
| 81 | - public function defaultResultsPerContext( Context $context ): array { |
|
| 81 | + public function defaultResultsPerContext(Context $context): array { |
|
| 82 | 82 | return $context->getType() === Context::TYPE_STATEMENT ? |
| 83 | - [ new NullResult( $context->getCursor() ) ] : |
|
| 84 | - []; |
|
| 83 | + [new NullResult($context->getCursor())] : []; |
|
| 85 | 84 | } |
| 86 | 85 | |
| 87 | - public function defaultResultsPerEntity( EntityId $entityId ): array { |
|
| 86 | + public function defaultResultsPerEntity(EntityId $entityId): array { |
|
| 88 | 87 | return [ |
| 89 | - ( new NullResult( new EntityContextCursor( $entityId->getSerialization() ) ) ) |
|
| 90 | - ->withMetadata( Metadata::ofDependencyMetadata( |
|
| 91 | - DependencyMetadata::ofEntityId( $entityId ) |
|
| 92 | - ) ), |
|
| 88 | + (new NullResult(new EntityContextCursor($entityId->getSerialization()))) |
|
| 89 | + ->withMetadata(Metadata::ofDependencyMetadata( |
|
| 90 | + DependencyMetadata::ofEntityId($entityId) |
|
| 91 | + )), |
|
| 93 | 92 | ]; |
| 94 | 93 | } |
| 95 | 94 | |
| 96 | - public function statusSelected( array $statusesFlipped, CheckResult $result ): bool { |
|
| 97 | - return array_key_exists( $result->getStatus(), $statusesFlipped ) || |
|
| 95 | + public function statusSelected(array $statusesFlipped, CheckResult $result): bool { |
|
| 96 | + return array_key_exists($result->getStatus(), $statusesFlipped) || |
|
| 98 | 97 | $result instanceof NullResult; |
| 99 | 98 | } |
| 100 | 99 | |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Helper; |
| 6 | 6 | |
@@ -28,15 +28,15 @@ discard block |
||
| 28 | 28 | // no parent::__construct() call |
| 29 | 29 | } |
| 30 | 30 | |
| 31 | - public function hasType( EntityId $id, array $classes ): CachedBool { |
|
| 32 | - throw new LogicException( 'methods of this class should never be called' ); |
|
| 31 | + public function hasType(EntityId $id, array $classes): CachedBool { |
|
| 32 | + throw new LogicException('methods of this class should never be called'); |
|
| 33 | 33 | } |
| 34 | 34 | |
| 35 | 35 | public function findEntitiesWithSameStatement( |
| 36 | 36 | Statement $statement, |
| 37 | 37 | array $separators |
| 38 | 38 | ): CachedEntityIds { |
| 39 | - throw new LogicException( 'methods of this class should never be called' ); |
|
| 39 | + throw new LogicException('methods of this class should never be called'); |
|
| 40 | 40 | } |
| 41 | 41 | |
| 42 | 42 | public function findEntitiesWithSameQualifierOrReference( |
@@ -45,15 +45,15 @@ discard block |
||
| 45 | 45 | string $type, |
| 46 | 46 | bool $ignoreDeprecatedStatements |
| 47 | 47 | ): CachedEntityIds { |
| 48 | - throw new LogicException( 'methods of this class should never be called' ); |
|
| 48 | + throw new LogicException('methods of this class should never be called'); |
|
| 49 | 49 | } |
| 50 | 50 | |
| 51 | - public function matchesRegularExpression( string $text, string $regex ): bool { |
|
| 52 | - throw new LogicException( 'methods of this class should never be called' ); |
|
| 51 | + public function matchesRegularExpression(string $text, string $regex): bool { |
|
| 52 | + throw new LogicException('methods of this class should never be called'); |
|
| 53 | 53 | } |
| 54 | 54 | |
| 55 | - public function runQuery( string $query, string $endpoint, bool $needsPrefixes = true ): CachedQueryResults { |
|
| 56 | - throw new LogicException( 'methods of this class should never be called' ); |
|
| 55 | + public function runQuery(string $query, string $endpoint, bool $needsPrefixes = true): CachedQueryResults { |
|
| 56 | + throw new LogicException('methods of this class should never be called'); |
|
| 57 | 57 | } |
| 58 | 58 | |
| 59 | 59 | } |
@@ -108,7 +108,7 @@ discard block |
||
| 108 | 108 | * @throws ConstraintParameterException if the constraint parameters are invalid |
| 109 | 109 | * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs |
| 110 | 110 | */ |
| 111 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult; |
|
| 111 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult; |
|
| 112 | 112 | |
| 113 | 113 | /** |
| 114 | 114 | * Check if the constraint parameters of $constraint are valid. |
@@ -119,6 +119,6 @@ discard block |
||
| 119 | 119 | * |
| 120 | 120 | * @return ConstraintParameterException[] |
| 121 | 121 | */ |
| 122 | - public function checkConstraintParameters( Constraint $constraint ): array; |
|
| 122 | + public function checkConstraintParameters(Constraint $constraint): array; |
|
| 123 | 123 | |
| 124 | 124 | } |
@@ -67,9 +67,9 @@ discard block |
||
| 67 | 67 | * @throws ConstraintParameterException |
| 68 | 68 | * @return CheckResult |
| 69 | 69 | */ |
| 70 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult { |
|
| 71 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
| 72 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED ); |
|
| 70 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult { |
|
| 71 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
| 72 | + return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED); |
|
| 73 | 73 | } |
| 74 | 74 | |
| 75 | 75 | $constraintParameters = $constraint->getConstraintParameters(); |
@@ -80,24 +80,24 @@ discard block |
||
| 80 | 80 | $constraintTypeItemId |
| 81 | 81 | ); |
| 82 | 82 | |
| 83 | - $message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) ) |
|
| 84 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
| 85 | - ->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE ); |
|
| 83 | + $message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier')) |
|
| 84 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
| 85 | + ->withEntityId($propertyId, Role::QUALIFIER_PREDICATE); |
|
| 86 | 86 | $status = CheckResult::STATUS_VIOLATION; |
| 87 | 87 | |
| 88 | 88 | /** @var Snak $qualifier */ |
| 89 | - foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) { |
|
| 90 | - if ( $propertyId->equals( $qualifier->getPropertyId() ) ) { |
|
| 89 | + foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) { |
|
| 90 | + if ($propertyId->equals($qualifier->getPropertyId())) { |
|
| 91 | 91 | $message = null; |
| 92 | 92 | $status = CheckResult::STATUS_COMPLIANCE; |
| 93 | 93 | break; |
| 94 | 94 | } |
| 95 | 95 | } |
| 96 | 96 | |
| 97 | - return new CheckResult( $context, $constraint, $status, $message ); |
|
| 97 | + return new CheckResult($context, $constraint, $status, $message); |
|
| 98 | 98 | } |
| 99 | 99 | |
| 100 | - public function checkConstraintParameters( Constraint $constraint ): array { |
|
| 100 | + public function checkConstraintParameters(Constraint $constraint): array { |
|
| 101 | 101 | $constraintParameters = $constraint->getConstraintParameters(); |
| 102 | 102 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
| 103 | 103 | $exceptions = []; |
@@ -106,7 +106,7 @@ discard block |
||
| 106 | 106 | $constraintParameters, |
| 107 | 107 | $constraintTypeItemId |
| 108 | 108 | ); |
| 109 | - } catch ( ConstraintParameterException $e ) { |
|
| 109 | + } catch (ConstraintParameterException $e) { |
|
| 110 | 110 | $exceptions[] = $e; |
| 111 | 111 | } |
| 112 | 112 | return $exceptions; |
@@ -76,9 +76,9 @@ discard block |
||
| 76 | 76 | * @throws ConstraintParameterException |
| 77 | 77 | * @return CheckResult |
| 78 | 78 | */ |
| 79 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult { |
|
| 80 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
| 81 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED ); |
|
| 79 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult { |
|
| 80 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
| 81 | + return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED); |
|
| 82 | 82 | } |
| 83 | 83 | |
| 84 | 84 | $constraintParameters = $constraint->getConstraintParameters(); |
@@ -97,22 +97,22 @@ discard block |
||
| 97 | 97 | |
| 98 | 98 | $statementList = $context->getEntity() |
| 99 | 99 | ->getStatements() |
| 100 | - ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] ); |
|
| 100 | + ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]); |
|
| 101 | 101 | |
| 102 | 102 | /* |
| 103 | 103 | * 'Conflicts with' can be defined with |
| 104 | 104 | * a) a property only |
| 105 | 105 | * b) a property and a number of items (each combination of property and item forming an individual claim) |
| 106 | 106 | */ |
| 107 | - if ( $items === [] ) { |
|
| 107 | + if ($items === []) { |
|
| 108 | 108 | $offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty( |
| 109 | 109 | $statementList, |
| 110 | 110 | $propertyId |
| 111 | 111 | ); |
| 112 | - if ( $offendingStatement !== null ) { |
|
| 113 | - $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) ) |
|
| 114 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
| 115 | - ->withEntityId( $propertyId, Role::PREDICATE ); |
|
| 112 | + if ($offendingStatement !== null) { |
|
| 113 | + $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property')) |
|
| 114 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
| 115 | + ->withEntityId($propertyId, Role::PREDICATE); |
|
| 116 | 116 | $status = CheckResult::STATUS_VIOLATION; |
| 117 | 117 | } else { |
| 118 | 118 | $message = null; |
@@ -124,12 +124,12 @@ discard block |
||
| 124 | 124 | $propertyId, |
| 125 | 125 | $items |
| 126 | 126 | ); |
| 127 | - if ( $offendingStatement !== null ) { |
|
| 128 | - $offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() ); |
|
| 129 | - $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) ) |
|
| 130 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
| 131 | - ->withEntityId( $propertyId, Role::PREDICATE ) |
|
| 132 | - ->withItemIdSnakValue( $offendingValue, Role::OBJECT ); |
|
| 127 | + if ($offendingStatement !== null) { |
|
| 128 | + $offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak()); |
|
| 129 | + $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim')) |
|
| 130 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
| 131 | + ->withEntityId($propertyId, Role::PREDICATE) |
|
| 132 | + ->withItemIdSnakValue($offendingValue, Role::OBJECT); |
|
| 133 | 133 | $status = CheckResult::STATUS_VIOLATION; |
| 134 | 134 | } else { |
| 135 | 135 | $message = null; |
@@ -137,10 +137,10 @@ discard block |
||
| 137 | 137 | } |
| 138 | 138 | } |
| 139 | 139 | |
| 140 | - return new CheckResult( $context, $constraint, $status, $message ); |
|
| 140 | + return new CheckResult($context, $constraint, $status, $message); |
|
| 141 | 141 | } |
| 142 | 142 | |
| 143 | - public function checkConstraintParameters( Constraint $constraint ): array { |
|
| 143 | + public function checkConstraintParameters(Constraint $constraint): array { |
|
| 144 | 144 | $constraintParameters = $constraint->getConstraintParameters(); |
| 145 | 145 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
| 146 | 146 | $exceptions = []; |
@@ -149,7 +149,7 @@ discard block |
||
| 149 | 149 | $constraintParameters, |
| 150 | 150 | $constraintTypeItemId |
| 151 | 151 | ); |
| 152 | - } catch ( ConstraintParameterException $e ) { |
|
| 152 | + } catch (ConstraintParameterException $e) { |
|
| 153 | 153 | $exceptions[] = $e; |
| 154 | 154 | } |
| 155 | 155 | try { |
@@ -158,7 +158,7 @@ discard block |
||
| 158 | 158 | $constraintTypeItemId, |
| 159 | 159 | false |
| 160 | 160 | ); |
| 161 | - } catch ( ConstraintParameterException $e ) { |
|
| 161 | + } catch (ConstraintParameterException $e) { |
|
| 162 | 162 | $exceptions[] = $e; |
| 163 | 163 | } |
| 164 | 164 | return $exceptions; |