wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +7 added lines, -7 removed lines

@@ -20,9 +20,9 @@ 
 	 */
 	private $statement;
 
-	public function __construct( EntityDocument $entity, Statement $statement ) {
-		Assert::parameterType( StatementListProvider::class, $entity, '$entity' );
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(EntityDocument $entity, Statement $statement) {
+		Assert::parameterType(StatementListProvider::class, $entity, '$entity');
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -43,7 +43,7 @@ 
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
 		return $statements
-			->getByRank( [ Statement::RANK_NORMAL, Statement::RANK_PREFERRED ] )
+			->getByRank([Statement::RANK_NORMAL, Statement::RANK_PREFERRED])
 			->getMainSnaks();
 	}
 
@@ -56,7 +56,7 @@ 
 		);
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -64,8 +64,8 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'mainsnak', $statementArray ) ) {
-			$statementArray['mainsnak'] = [ 'hash' => $this->statement->getMainSnak()->getHash() ];
+		if (!array_key_exists('mainsnak', $statementArray)) {
+			$statementArray['mainsnak'] = ['hash' => $this->statement->getMainSnak()->getHash()];
 		}
 		$mainsnakArray = &$statementArray['mainsnak'];
 

src/ConstraintCheck/Context/QualifierContext.php

Spacing +9 added lines, -9 removed lines

@@ -23,7 +23,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -33,7 +33,7 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {
@@ -46,7 +46,7 @@ 
 		);
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -54,25 +54,25 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'qualifiers', $statementArray ) ) {
+		if (!array_key_exists('qualifiers', $statementArray)) {
 			$statementArray['qualifiers'] = [];
 		}
 		$qualifiersArray = &$statementArray['qualifiers'];
 
 		$propertyId = $this->getSnak()->getPropertyId()->getSerialization();
-		if ( !array_key_exists( $propertyId, $qualifiersArray ) ) {
+		if (!array_key_exists($propertyId, $qualifiersArray)) {
 			$qualifiersArray[$propertyId] = [];
 		}
 		$propertyArray = &$qualifiersArray[$propertyId];
 
-		foreach ( $propertyArray as &$potentialQualifierArray ) {
-			if ( $potentialQualifierArray['hash'] === $this->getSnak()->getHash() ) {
+		foreach ($propertyArray as &$potentialQualifierArray) {
+			if ($potentialQualifierArray['hash'] === $this->getSnak()->getHash()) {
 				$qualifierArray = &$potentialQualifierArray;
 				break;
 			}
 		}
-		if ( !isset( $qualifierArray ) ) {
-			$qualifierArray = [ 'hash' => $this->getSnak()->getHash() ];
+		if (!isset($qualifierArray)) {
+			$qualifierArray = ['hash' => $this->getSnak()->getHash()];
 			$propertyArray[] = &$qualifierArray;
 		}
 

src/ConstraintCheck/Context/MainSnakContextCursor.php

Spacing +3 added lines, -3 removed lines

@@ -61,7 +61,7 @@ 
 		return $this->snakHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entityId,
@@ -69,8 +69,8 @@ 
 			$this->statementGuid
 		);
 
-		if ( !array_key_exists( 'mainsnak', $statementArray ) ) {
-			$statementArray['mainsnak'] = [ 'hash' => $this->snakHash ];
+		if (!array_key_exists('mainsnak', $statementArray)) {
+			$statementArray['mainsnak'] = ['hash' => $this->snakHash];
 		}
 		$mainsnakArray = &$statementArray['mainsnak'];
 

src/ConstraintCheck/Context/ReferenceContextCursor.php

Spacing +11 added lines, -11 removed lines

@@ -77,7 +77,7 @@ 
 		return $this->snakHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entityId,
@@ -85,37 +85,37 @@ 
 			$this->statementGuid
 		);
 
-		if ( !array_key_exists( 'references', $statementArray ) ) {
+		if (!array_key_exists('references', $statementArray)) {
 			$statementArray['references'] = [];
 		}
 		$referencesArray = &$statementArray['references'];
 
-		foreach ( $referencesArray as &$potentialReferenceArray ) {
-			if ( $potentialReferenceArray['hash'] === $this->referenceHash ) {
+		foreach ($referencesArray as &$potentialReferenceArray) {
+			if ($potentialReferenceArray['hash'] === $this->referenceHash) {
 				$referenceArray = &$potentialReferenceArray;
 				break;
 			}
 		}
-		if ( !isset( $referenceArray ) ) {
-			$referenceArray = [ 'hash' => $this->referenceHash, 'snaks' => [] ];
+		if (!isset($referenceArray)) {
+			$referenceArray = ['hash' => $this->referenceHash, 'snaks' => []];
 			$referencesArray[] = &$referenceArray;
 		}
 
 		$snaksArray = &$referenceArray['snaks'];
 
-		if ( !array_key_exists( $this->snakPropertyId, $snaksArray ) ) {
+		if (!array_key_exists($this->snakPropertyId, $snaksArray)) {
 			$snaksArray[$this->snakPropertyId] = [];
 		}
 		$propertyArray = &$snaksArray[$this->snakPropertyId];
 
-		foreach ( $propertyArray as &$potentialSnakArray ) {
-			if ( $potentialSnakArray['hash'] === $this->snakHash ) {
+		foreach ($propertyArray as &$potentialSnakArray) {
+			if ($potentialSnakArray['hash'] === $this->snakHash) {
 				$snakArray = &$potentialSnakArray;
 				break;
 			}
 		}
-		if ( !isset( $snakArray ) ) {
-			$snakArray = [ 'hash' => $this->snakHash ];
+		if (!isset($snakArray)) {
+			$snakArray = ['hash' => $this->snakHash];
 			$propertyArray[] = &$snakArray;
 		}
 

src/ConstraintCheck/Context/QualifierContextCursor.php

Spacing +7 added lines, -7 removed lines

@@ -69,7 +69,7 @@ 
 		return $this->snakHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entityId,
@@ -77,24 +77,24 @@ 
 			$this->statementGuid
 		);
 
-		if ( !array_key_exists( 'qualifiers', $statementArray ) ) {
+		if (!array_key_exists('qualifiers', $statementArray)) {
 			$statementArray['qualifiers'] = [];
 		}
 		$qualifiersArray = &$statementArray['qualifiers'];
 
-		if ( !array_key_exists( $this->snakPropertyId, $qualifiersArray ) ) {
+		if (!array_key_exists($this->snakPropertyId, $qualifiersArray)) {
 			$qualifiersArray[$this->snakPropertyId] = [];
 		}
 		$propertyArray = &$qualifiersArray[$this->snakPropertyId];
 
-		foreach ( $propertyArray as &$potentialQualifierArray ) {
-			if ( $potentialQualifierArray['hash'] === $this->snakHash ) {
+		foreach ($propertyArray as &$potentialQualifierArray) {
+			if ($potentialQualifierArray['hash'] === $this->snakHash) {
 				$qualifierArray = &$potentialQualifierArray;
 				break;
 			}
 		}
-		if ( !isset( $qualifierArray ) ) {
-			$qualifierArray = [ 'hash' => $this->snakHash ];
+		if (!isset($qualifierArray)) {
+			$qualifierArray = ['hash' => $this->snakHash];
 			$propertyArray[] = &$qualifierArray;
 		}
 

src/Api/CheckingResultsBuilder.php

Spacing +30 added lines, -31 removed lines

@@ -84,65 +84,64 @@ 
 	) {
 		$response = [];
 		$metadatas = [];
-		$statusesFlipped = array_flip( $statuses );
-		foreach ( $entityIds as $entityId ) {
+		$statusesFlipped = array_flip($statuses);
+		foreach ($entityIds as $entityId) {
 			$results = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId(
 				$entityId,
 				$constraintIds,
-				[ $this, 'defaultResults' ]
+				[$this, 'defaultResults']
 			);
-			foreach ( $results as $result ) {
+			foreach ($results as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
-					$resultArray = $this->checkResultToArray( $result );
-					$result->getContextCursor()->storeCheckResultInArray( $resultArray, $response );
+				if ($this->statusSelected($statusesFlipped, $result)) {
+					$resultArray = $this->checkResultToArray($result);
+					$result->getContextCursor()->storeCheckResultInArray($resultArray, $response);
 				}
 			}
 		}
-		foreach ( $claimIds as $claimId ) {
+		foreach ($claimIds as $claimId) {
 			$results = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId(
 				$claimId,
 				$constraintIds,
-				[ $this, 'defaultResults' ]
+				[$this, 'defaultResults']
 			);
-			foreach ( $results as $result ) {
+			foreach ($results as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
-					$resultArray = $this->checkResultToArray( $result );
-					$result->getContextCursor()->storeCheckResultInArray( $resultArray, $response );
+				if ($this->statusSelected($statusesFlipped, $result)) {
+					$resultArray = $this->checkResultToArray($result);
+					$result->getContextCursor()->storeCheckResultInArray($resultArray, $response);
 				}
 			}
 		}
 		return new CachedCheckConstraintsResponse(
 			$response,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	public function defaultResults( Context $context ) {
+	public function defaultResults(Context $context) {
 		return $context->getType() === Context::TYPE_STATEMENT ?
-			[ new NullResult( $context ) ] :
-			[];
+			[new NullResult($context)] : [];
 	}
 
-	public function statusSelected( array $statusesFlipped, CheckResult $result ) {
-		return array_key_exists( $result->getStatus(), $statusesFlipped ) ||
+	public function statusSelected(array $statusesFlipped, CheckResult $result) {
+		return array_key_exists($result->getStatus(), $statusesFlipped) ||
 			$result instanceof NullResult;
 	}
 
-	public function checkResultToArray( CheckResult $checkResult ) {
-		if ( $checkResult instanceof NullResult ) {
+	public function checkResultToArray(CheckResult $checkResult) {
+		if ($checkResult instanceof NullResult) {
 			return null;
 		}
 
 		$constraintId = $checkResult->getConstraint()->getConstraintId();
 		$typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId();
-		$constraintPropertyId = new PropertyId( $checkResult->getContextCursor()->getSnakPropertyId() );
+		$constraintPropertyId = new PropertyId($checkResult->getContextCursor()->getSnakPropertyId());
 
-		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
-		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
+		$title = $this->entityTitleLookup->getTitleForId($constraintPropertyId);
+		$typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId));
 		// TODO link to the statement when possible (T169224)
-		$link = $title->getFullURL() . '#' . $this->config->get( 'WBQualityConstraintsPropertyConstraintId' );
+		$link = $title->getFullURL().'#'.$this->config->get('WBQualityConstraintsPropertyConstraintId');
 
 		$constraint = [
 			'id' => $constraintId,
@@ -151,11 +150,11 @@ 
 			'link' => $link,
 			'discussLink' => $title->getTalkPage()->getFullURL(),
 		];
-		if ( $this->config->get( 'WBQualityConstraintsIncludeDetailInApi' ) ) {
+		if ($this->config->get('WBQualityConstraintsIncludeDetailInApi')) {
 			$parameters = $checkResult->getParameters();
 			$constraint += [
 				'detail' => $parameters,
-				'detailHTML' => $this->constraintParameterRenderer->formatParameters( $parameters ),
+				'detailHTML' => $this->constraintParameterRenderer->formatParameters($parameters),
 			];
 		}
 
@@ -165,14 +164,14 @@ 
 			'constraint' => $constraint
 		];
 		$message = $checkResult->getMessage();
-		if ( $message ) {
-			$result['message-html'] = $this->violationMessageRenderer->render( $message );
+		if ($message) {
+			$result['message-html'] = $this->violationMessageRenderer->render($message);
 		}
-		if ( $checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT ) {
+		if ($checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT) {
 			$result['claim'] = $checkResult->getContextCursor()->getStatementGuid();
 		}
 		$cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray();
-		if ( $cachingMetadataArray !== null ) {
+		if ($cachingMetadataArray !== null) {
 			$result['cached'] = $cachingMetadataArray;
 		}