wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/MainSnakContextCursor.php

Spacing +4 added lines, -4 removed lines

@@ -72,12 +72,12 @@
 		return $this->snakHash;
 	}
 
-	protected function &getMainArray( array &$container ) {
-		$statementArray = &$this->getStatementArray( $container );
+	protected function &getMainArray(array &$container) {
+		$statementArray = &$this->getStatementArray($container);
 
-		if ( !array_key_exists( 'mainsnak', $statementArray ) ) {
+		if (!array_key_exists('mainsnak', $statementArray)) {
 			$snakHash = $this->getSnakHash();
-			$statementArray['mainsnak'] = [ 'hash' => $snakHash ];
+			$statementArray['mainsnak'] = ['hash' => $snakHash];
 		}
 		$mainsnakArray = &$statementArray['mainsnak'];
 

src/ConstraintCheck/Context/ContextCursorDeserializer.php

Spacing +3 added lines, -3 removed lines

@@ -11,8 +11,8 @@ 
  */
 class ContextCursorDeserializer {
 
-	public function deserialize( array $serialization ) {
-		switch ( $serialization['t'] ) {
+	public function deserialize(array $serialization) {
+		switch ($serialization['t']) {
 			case Context::TYPE_STATEMENT:
 				return new MainSnakContextCursor(
 					$serialization['i'],
@@ -39,7 +39,7 @@ 
 				);
 			default:
 				throw new InvalidArgumentException(
-					'Unknown serialization type ' . $serialization['t']
+					'Unknown serialization type '.$serialization['t']
 				);
 		}
 	}

src/ConstraintCheck/Result/NullResult.php

Spacing +5 added lines, -5 removed lines

@@ -24,22 +24,22 @@
 	 */
 	const NULL_PROPERTY_ID = 'P2147483647';
 
-	public function __construct( ContextCursor $contextCursor ) {
+	public function __construct(ContextCursor $contextCursor) {
 		$constraint = new Constraint(
 			'null',
-			new PropertyId( self::NULL_PROPERTY_ID ),
+			new PropertyId(self::NULL_PROPERTY_ID),
 			'none',
 			[]
 		);
-		parent::__construct( $contextCursor, $constraint );
+		parent::__construct($contextCursor, $constraint);
 	}
 
 	public function getConstraint() {
-		throw new DomainException( 'NullResult holds no constraint' );
+		throw new DomainException('NullResult holds no constraint');
 	}
 
 	public function getConstraintId() {
-		throw new DomainException( 'NullResult holds no constraint' );
+		throw new DomainException('NullResult holds no constraint');
 	}
 
 }

src/ConstraintCheck/Result/CheckResultSerializer.php

Spacing +14 added lines, -14 removed lines

@@ -76,14 +76,14 @@ 
 	 * @param CheckResult $checkResult
 	 * @return array
 	 */
-	public function serialize( CheckResult $checkResult ) {
+	public function serialize(CheckResult $checkResult) {
 		$contextCursor = $checkResult->getContextCursor();
 
 		$serialization = [
-			self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize( $contextCursor ),
+			self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize($contextCursor),
 		];
 
-		if ( $checkResult instanceof NullResult ) {
+		if ($checkResult instanceof NullResult) {
 			$serialization[self::KEY_NULL_RESULT] = 1;
 		} else {
 			$constraint = $checkResult->getConstraint();
@@ -91,21 +91,21 @@ 
 			$violationMessage = $checkResult->getMessage();
 
 			$serialization[self::KEY_CONSTRAINT] =
-				$this->constraintSerializer->serialize( $constraint );
+				$this->constraintSerializer->serialize($constraint);
 			$serialization[self::KEY_CHECK_RESULT_STATUS] =
 				$checkResult->getStatus();
 			$serialization[self::KEY_CACHING_METADATA] =
-				$this->serializeCachingMetadata( $cachingMetadata );
+				$this->serializeCachingMetadata($cachingMetadata);
 
-			if ( $violationMessage !== null ) {
+			if ($violationMessage !== null) {
 				$serialization[self::KEY_VIOLATION_MESSAGE] =
-					$this->violationMessageSerializer->serialize( $violationMessage );
+					$this->violationMessageSerializer->serialize($violationMessage);
 			}
 		}
 
-		if ( $this->serializeDependencyMetadata ) {
+		if ($this->serializeDependencyMetadata) {
 			$serialization[self::KEY_DEPENDENCY_METADATA] =
-				$this->serializeDependencyMetadata( $checkResult );
+				$this->serializeDependencyMetadata($checkResult);
 		}
 
 		return $serialization;
@@ -115,12 +115,12 @@ 
 	 * @param CachingMetadata $cachingMetadata
 	 * @return array
 	 */
-	private function serializeCachingMetadata( CachingMetadata $cachingMetadata ) {
+	private function serializeCachingMetadata(CachingMetadata $cachingMetadata) {
 		$maximumAge = $cachingMetadata->getMaximumAgeInSeconds();
 
 		$serialization = [];
 
-		if ( $maximumAge > 0 ) {
+		if ($maximumAge > 0) {
 			$serialization[self::KEY_CACHING_METADATA_MAX_AGE] = $maximumAge;
 		}
 
@@ -131,21 +131,21 @@ 
 	 * @param CheckResult $checkResult
 	 * @return array
 	 */
-	private function serializeDependencyMetadata( CheckResult $checkResult ) {
+	private function serializeDependencyMetadata(CheckResult $checkResult) {
 		$dependencyMetadata = $checkResult->getMetadata()->getDependencyMetadata();
 		$entityIds = $dependencyMetadata->getEntityIds();
 		$futureTime = $dependencyMetadata->getFutureTime();
 
 		$serialization = [
 			self::KEY_DEPENDENCY_METADATA_ENTITY_IDS => array_map(
-				function ( EntityId $entityId ) {
+				function(EntityId $entityId) {
 					return $entityId->getSerialization();
 				},
 				$entityIds
 			),
 		];
 
-		if ( $futureTime !== null ) {
+		if ($futureTime !== null) {
 			$serialization[self::KEY_DEPENDENCY_METADATA_FUTURE_TIME] =
 				$futureTime->getArrayValue();
 		}

src/Api/CheckingResultsSource.php

Spacing +20 added lines, -21 removed lines

@@ -44,57 +44,56 @@
 	) {
 		$results = [];
 		$metadatas = [];
-		$statusesFlipped = array_flip( $statuses );
-		foreach ( $entityIds as $entityId ) {
+		$statusesFlipped = array_flip($statuses);
+		foreach ($entityIds as $entityId) {
 			$entityResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId(
 				$entityId,
 				$constraintIds,
-				[ $this, 'defaultResultsPerContext' ],
-				[ $this, 'defaultResultsPerEntity' ]
+				[$this, 'defaultResultsPerContext'],
+				[$this, 'defaultResultsPerEntity']
 			);
-			foreach ( $entityResults as $result ) {
+			foreach ($entityResults as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
+				if ($this->statusSelected($statusesFlipped, $result)) {
 					$results[] = $result;
 				}
 			}
 		}
-		foreach ( $claimIds as $claimId ) {
+		foreach ($claimIds as $claimId) {
 			$claimResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId(
 				$claimId,
 				$constraintIds,
-				[ $this, 'defaultResultsPerContext' ]
+				[$this, 'defaultResultsPerContext']
 			);
-			foreach ( $claimResults as $result ) {
+			foreach ($claimResults as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
+				if ($this->statusSelected($statusesFlipped, $result)) {
 					$results[] = $result;
 				}
 			}
 		}
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	public function defaultResultsPerContext( Context $context ) {
+	public function defaultResultsPerContext(Context $context) {
 		return $context->getType() === Context::TYPE_STATEMENT ?
-			[ new NullResult( $context->getCursor() ) ] :
-			[];
+			[new NullResult($context->getCursor())] : [];
 	}
 
-	public function defaultResultsPerEntity( EntityId $entityId ) {
+	public function defaultResultsPerEntity(EntityId $entityId) {
 		return [
-			( new NullResult( new EntityContextCursor( $entityId->getSerialization() ) ) )
-				->withMetadata( Metadata::ofDependencyMetadata(
-					DependencyMetadata::ofEntityId( $entityId )
-				) )
+			(new NullResult(new EntityContextCursor($entityId->getSerialization())))
+				->withMetadata(Metadata::ofDependencyMetadata(
+					DependencyMetadata::ofEntityId($entityId)
+				))
 		];
 	}
 
-	public function statusSelected( array $statusesFlipped, CheckResult $result ) {
-		return array_key_exists( $result->getStatus(), $statusesFlipped ) ||
+	public function statusSelected(array $statusesFlipped, CheckResult $result) {
+		return array_key_exists($result->getStatus(), $statusesFlipped) ||
 			$result instanceof NullResult;
 	}
 

src/ConstraintCheck/Result/CheckResultDeserializer.php

Spacing +21 added lines, -21 removed lines

@@ -56,13 +56,13 @@ 
 	 * @param array $serialization
 	 * @return CheckResult
 	 */
-	public function deserialize( array $serialization ) {
+	public function deserialize(array $serialization) {
 		$contextCursor = $this->contextCursorDeserializer->deserialize(
 			$serialization[CheckResultSerializer::KEY_CONTEXT_CURSOR]
 		);
 
-		if ( array_key_exists( CheckResultSerializer::KEY_NULL_RESULT, $serialization ) ) {
-			$result = new NullResult( $contextCursor );
+		if (array_key_exists(CheckResultSerializer::KEY_NULL_RESULT, $serialization)) {
+			$result = new NullResult($contextCursor);
 			$cachingMetadata = CachingMetadata::fresh();
 		} else {
 			$constraint = $this->constraintDeserializer->deserialize(
@@ -73,7 +73,7 @@ 
 
 			$status = $serialization[CheckResultSerializer::KEY_CHECK_RESULT_STATUS];
 
-			$violationMessage = $this->getViolationMessageFromSerialization( $serialization );
+			$violationMessage = $this->getViolationMessageFromSerialization($serialization);
 
 			$result = new CheckResult(
 				$contextCursor,
@@ -88,13 +88,13 @@ 
 			);
 		}
 
-		$dependencyMetadata = $this->getDependencyMetadataFromSerialization( $serialization );
+		$dependencyMetadata = $this->getDependencyMetadataFromSerialization($serialization);
 
 		return $result->withMetadata(
-			Metadata::merge( [
-				Metadata::ofCachingMetadata( $cachingMetadata ),
-				Metadata::ofDependencyMetadata( $dependencyMetadata ),
-			] )
+			Metadata::merge([
+				Metadata::ofCachingMetadata($cachingMetadata),
+				Metadata::ofDependencyMetadata($dependencyMetadata),
+			])
 		);
 	}
 
@@ -102,8 +102,8 @@ 
 	 * @param array $serialization
 	 * @return null|ViolationMessage
 	 */
-	private function getViolationMessageFromSerialization( array $serialization ) {
-		if ( array_key_exists( CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization ) ) {
+	private function getViolationMessageFromSerialization(array $serialization) {
+		if (array_key_exists(CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization)) {
 			return $this->violationMessageDeserializer->deserialize(
 				$serialization[CheckResultSerializer::KEY_VIOLATION_MESSAGE]
 			);
@@ -116,8 +116,8 @@ 
 	 * @param array $serialization
 	 * @return DependencyMetadata
 	 */
-	private function getDependencyMetadataFromSerialization( array $serialization ) {
-		if ( array_key_exists( CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization ) ) {
+	private function getDependencyMetadataFromSerialization(array $serialization) {
+		if (array_key_exists(CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization)) {
 			return $this->deserializeDependencyMetadata(
 				$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA]
 			);
@@ -130,7 +130,7 @@ 
 	 * @param array $serialization
 	 * @return CachingMetadata
 	 */
-	private function deserializeCachingMetadata( array $serialization ) {
+	private function deserializeCachingMetadata(array $serialization) {
 		if (
 			array_key_exists(
 				CheckResultSerializer::KEY_CACHING_METADATA_MAX_AGE,
@@ -149,7 +149,7 @@ 
 	 * @param array $serialization
 	 * @return DependencyMetadata
 	 */
-	private function deserializeDependencyMetadata( array $serialization ) {
+	private function deserializeDependencyMetadata(array $serialization) {
 		if (
 			array_key_exists(
 				CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME,
@@ -159,20 +159,20 @@ 
 			$futureTime = TimeValue::newFromArray(
 				$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME]
 			);
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
 		$dependencyMetadata = array_reduce(
 			$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_ENTITY_IDS],
-			function ( DependencyMetadata $metadata, $entityIdSerialization ) {
-				$entityId = $this->entityIdParser->parse( $entityIdSerialization );
+			function(DependencyMetadata $metadata, $entityIdSerialization) {
+				$entityId = $this->entityIdParser->parse($entityIdSerialization);
 
-				return DependencyMetadata::merge( [
+				return DependencyMetadata::merge([
 					$metadata,
-					DependencyMetadata::ofEntityId( $entityId )
-				] );
+					DependencyMetadata::ofEntityId($entityId)
+				]);
 			},
 			$futureTimeDependencyMetadata
 		);

WikibaseQualityConstraints.php

Spacing +7 added lines, -7 removed lines

@@ -4,17 +4,17 @@
  * @license GPL-2.0-or-later
  */
 
-if ( function_exists( 'wfLoadExtension' ) ) {
-	wfLoadExtension( 'WikibaseQualityConstraints', __DIR__ . '/extension.json' );
+if (function_exists('wfLoadExtension')) {
+	wfLoadExtension('WikibaseQualityConstraints', __DIR__.'/extension.json');
 	// Keep i18n globals so mergeMessageFileList.php doesn't break
-	$wgMessagesDirs['WikibaseQualityConstraints'] = __DIR__ . '/i18n';
-	$wgExtensionMessagesFiles['WikibaseQualityConstraintsAlias'] = __DIR__ . '/WikibaseQualityConstraints.alias.php';
+	$wgMessagesDirs['WikibaseQualityConstraints'] = __DIR__.'/i18n';
+	$wgExtensionMessagesFiles['WikibaseQualityConstraintsAlias'] = __DIR__.'/WikibaseQualityConstraints.alias.php';
 	wfWarn(
-		'Deprecated PHP entry point used for WikibaseQualityConstraints extension. ' .
-		'Please use wfLoadExtension instead, ' .
+		'Deprecated PHP entry point used for WikibaseQualityConstraints extension. '.
+		'Please use wfLoadExtension instead, '.
 		'see https://www.mediawiki.org/wiki/Extension_registration for more details.'
 	);
 	return;
 } else {
-	die( 'This version of the WikibaseQualityConstraints extension requires MediaWiki 1.25+' );
+	die('This version of the WikibaseQualityConstraints extension requires MediaWiki 1.25+');
 }

src/ConstraintCheck/Helper/ConstraintParameterException.php

Spacing +3 added lines, -3 removed lines

@@ -21,9 +21,9 @@
 	/**
 	 * @param ViolationMessage $violationMessage
 	 */
-	public function __construct( ViolationMessage $violationMessage ) {
-		$message = '⧼' . $violationMessage->getMessageKey() . '⧽';
-		parent::__construct( $message );
+	public function __construct(ViolationMessage $violationMessage) {
+		$message = '⧼'.$violationMessage->getMessageKey().'⧽';
+		parent::__construct($message);
 
 		$this->violationMessage = $violationMessage;
 	}

src/ConstraintCheck/Message/MultilingualTextViolationMessageRenderer.php

Spacing +21 added lines, -21 removed lines

@@ -55,34 +55,34 @@ 
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
 	 * @return string
 	 */
-	public function render( ViolationMessage $violationMessage ) {
-		if ( !array_key_exists( $violationMessage->getMessageKey(), $this->alternativeMessageKeys ) ) {
-			return parent::render( $violationMessage );
+	public function render(ViolationMessage $violationMessage) {
+		if (!array_key_exists($violationMessage->getMessageKey(), $this->alternativeMessageKeys)) {
+			return parent::render($violationMessage);
 		}
 
 		$arguments = $violationMessage->getArguments();
-		$multilingualTextArgument = array_pop( $arguments );
+		$multilingualTextArgument = array_pop($arguments);
 		$multilingualTextParams = $this->renderMultilingualText(
 			$multilingualTextArgument['value'],
 			$multilingualTextArgument['role']
 		);
 
-		$paramsLists = [ [] ];
-		foreach ( $arguments as $argument ) {
-			$paramsLists[] = $this->renderArgument( $argument );
+		$paramsLists = [[]];
+		foreach ($arguments as $argument) {
+			$paramsLists[] = $this->renderArgument($argument);
 		}
-		$regularParams = call_user_func_array( 'array_merge', $paramsLists );
+		$regularParams = call_user_func_array('array_merge', $paramsLists);
 
-		if ( $multilingualTextParams === null ) {
+		if ($multilingualTextParams === null) {
 			return $this->messageLocalizer
-				->msg( $this->alternativeMessageKeys[$violationMessage->getMessageKey()] )
-				->params( $regularParams )
+				->msg($this->alternativeMessageKeys[$violationMessage->getMessageKey()])
+				->params($regularParams)
 				->escaped();
 		} else {
 			return $this->messageLocalizer
-				->msg( $violationMessage->getMessageKey() )
-				->params( $regularParams )
-				->params( $multilingualTextParams )
+				->msg($violationMessage->getMessageKey())
+				->params($regularParams)
+				->params($multilingualTextParams)
 				->escaped();
 		}
 	}
@@ -93,18 +93,18 @@ 
 	 * @return array[]|null list of parameters as accepted by Message::params(),
 	 * or null if the text is not available in the user’s language
 	 */
-	protected function renderMultilingualText( MultilingualTextValue $text, $role ) {
+	protected function renderMultilingualText(MultilingualTextValue $text, $role) {
 		global $wgLang;
 		$languageCodes = $wgLang->getFallbackLanguages();
-		array_unshift( $languageCodes, $wgLang->getCode() );
+		array_unshift($languageCodes, $wgLang->getCode());
 
 		$texts = $text->getTexts();
-		foreach ( $languageCodes as $languageCode ) {
-			if ( array_key_exists( $languageCode, $texts ) ) {
-				return [ Message::rawParam( $this->addRole(
-					htmlspecialchars( $texts[$languageCode]->getText() ),
+		foreach ($languageCodes as $languageCode) {
+			if (array_key_exists($languageCode, $texts)) {
+				return [Message::rawParam($this->addRole(
+					htmlspecialchars($texts[$languageCode]->getText()),
 					$role
-				) ) ];
+				))];
 			}
 		}