Inspection of "Merge "Migrate all SparqlHelper.php methods to sta..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 60f697...f33fff )

unknown

created 2025-03-18 16:03 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
 			$constraintTypeItemId
 		);
 
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
+		if (in_array($context->getType(), $allowedContextTypes)) {
 			return new CheckResult(
 				$context->getCursor(),
 				$constraint,
@@ -66,15 +66,15 @@  discard block
 block discarded – undo
 				$context->getCursor(),
 				$constraint,
 				CheckResult::STATUS_VIOLATION,
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
-					->withEntityId( $context->getSnak()->getPropertyId() )
-					->withPropertyScope( $context->getType() )
-					->withPropertyScopeList( $allowedContextTypes )
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
+					->withEntityId($context->getSnak()->getPropertyId())
+					->withPropertyScope($context->getType())
+					->withPropertyScopeList($allowedContextTypes)
 			);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SingleBestValueChecker.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -63,9 +63,9 @@  discard block
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
@@ -74,13 +74,13 @@  discard block
 block discarded – undo
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
+			$context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
 			$propertyId
 		);
 
-		if ( $bestRankCount > 1 ) {
+		if ($bestRankCount > 1) {
 			$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
-				$context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
+				$context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
 				$propertyId
 			);
 			$message = $this->getViolationMessage(
@@ -95,15 +95,15 @@  discard block
 block discarded – undo
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
@@ -122,23 +122,23 @@  discard block
 block discarded – undo
 		$separators,
 		$propertyId
 	) {
-		if ( $bestRankCount === $nonDeprecatedCount ) {
-			if ( $separators === [] ) {
+		if ($bestRankCount === $nonDeprecatedCount) {
+			if ($separators === []) {
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
 			} else {
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
 			}
 		} else {
-			if ( $separators === [] ) {
+			if ($separators === []) {
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
 			} else {
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
 			}
 		}
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
 }

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ItemChecker.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -75,9 +75,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
@@ -112,21 +112,21 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -67,9 +67,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -84,33 +84,33 @@  discard block
 block discarded – undo
 		$status = CheckResult::STATUS_COMPLIANCE;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
 			$allowedQualifier = false;
-			foreach ( $properties as $property ) {
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
+			foreach ($properties as $property) {
+				if ($qualifier->getPropertyId()->equals($property)) {
 					$allowedQualifier = true;
 					break;
 				}
 			}
-			if ( !$allowedQualifier ) {
-				if ( $properties === [] || $properties === [ '' ] ) {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+			if (!$allowedQualifier) {
+				if ($properties === [] || $properties === ['']) {
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 				} else {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
 				}
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch

Spacing +15 added lines, -16 removed lines patch added patch discarded remove patch

@@ -64,9 +64,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
@@ -75,19 +75,19 @@  discard block
 block discarded – undo
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount > 1 ) {
-			$message = $this->getViolationMessage( $separators, $propertyId );
+		if ($propertyCount > 1) {
+			$message = $this->getViolationMessage($separators, $propertyId);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
 	/**
@@ -95,22 +95,21 @@  discard block
 block discarded – undo
 	 * @param PropertyId $propertyId
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
 		$messageKey = $separators === [] ?
-			'wbqc-violation-message-single-value' :
-			'wbqc-violation-message-single-value-separators';
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/CitationNeededChecker.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 	 * @codeCoverageIgnore This method is purely declarative.
 	 */
 	public function getDefaultContextTypes(): array {
-		return [ Context::TYPE_STATEMENT ];
+		return [Context::TYPE_STATEMENT];
 	}
 
 	/** @codeCoverageIgnore This method is purely declarative. */
@@ -38,12 +38,12 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$referenceList = $context->getSnakStatement()->getReferences();
 
-		if ( $referenceList->isEmpty() ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-citationNeeded' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($referenceList->isEmpty()) {
+			$message = (new ViolationMessage('wbqc-violation-message-citationNeeded'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			return new CheckResult(
 				$context,
 				$constraint,
@@ -52,10 +52,10 @@  discard block
 block discarded – undo
 			);
 		}
 
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php 1 patch

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -79,9 +79,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -100,9 +100,9 @@  discard block
 block discarded – undo
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -111,18 +111,18 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -143,23 +143,23 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SymmetricChecker.php 1 patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -79,17 +79,17 @@  discard block
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$snak = $context->getSnak();
 		$propertyId = $context->getSnak()->getPropertyId();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -98,18 +98,18 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -117,23 +117,23 @@  discard block
 block discarded – undo
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $symmetricStatement !== null ) {
+		if ($symmetricStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/NoneOfChecker.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -57,9 +57,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -76,20 +76,20 @@  discard block
 block discarded – undo
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-					->withItemIdSnakValueList( $items, Role::OBJECT );
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+					->withItemIdSnakValueList($items, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
 				$constraintTypeItemId,
 				true
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46	return self::ALL_ENTITY_TYPES_SUPPORTED;
47	47	}
48	48
49		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
	49	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
50	50	$constraintParameters = $constraint->getConstraintParameters();
51	51	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
52	52
		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	$constraintTypeItemId
56	56	);
57	57
58		- if ( in_array( $context->getType(), $allowedContextTypes ) ) {
	58	+ if (in_array($context->getType(), $allowedContextTypes)) {
59	59	return new CheckResult(
60	60	$context->getCursor(),
61	61	$constraint,
		@@ -66,15 +66,15 @@ discard block
		block discarded – undo
66	66	$context->getCursor(),
67	67	$constraint,
68	68	CheckResult::STATUS_VIOLATION,
69		- ( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
70		- ->withEntityId( $context->getSnak()->getPropertyId() )
71		- ->withPropertyScope( $context->getType() )
72		- ->withPropertyScopeList( $allowedContextTypes )
	69	+ (new ViolationMessage('wbqc-violation-message-property-scope'))
	70	+ ->withEntityId($context->getSnak()->getPropertyId())
	71	+ ->withPropertyScope($context->getType())
	72	+ ->withPropertyScopeList($allowedContextTypes)
73	73	);
74	74	}
75	75	}
76	76
77		- public function checkConstraintParameters( Constraint $constraint ): array {
	77	+ public function checkConstraintParameters(Constraint $constraint): array {
78	78	$constraintParameters = $constraint->getConstraintParameters();
79	79	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
80	80	$exceptions = [];
		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	$constraintParameters,
84	84	$constraintTypeItemId
85	85	);
86		- } catch ( ConstraintParameterException $e ) {
	86	+ } catch (ConstraintParameterException $e) {
87	87	$exceptions[] = $e;
88	88	}
89	89	return $exceptions;

		@@ -63,9 +63,9 @@ discard block
		block discarded – undo
63	63	*
64	64	* @return CheckResult
65	65	*/
66		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
67		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
68		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	66	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	67	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	68	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
69	69	}
70	70
71	71	$separators = $this->constraintParameterParser->parseSeparatorsParameter(
		@@ -74,13 +74,13 @@ discard block
		block discarded – undo
74	74
75	75	$propertyId = $context->getSnak()->getPropertyId();
76	76	$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
77		- $context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
	77	+ $context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
78	78	$propertyId
79	79	);
80	80
81		- if ( $bestRankCount > 1 ) {
	81	+ if ($bestRankCount > 1) {
82	82	$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
83		- $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
	83	+ $context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
84	84	$propertyId
85	85	);
86	86	$message = $this->getViolationMessage(
		@@ -95,15 +95,15 @@ discard block
		block discarded – undo
95	95	$status = CheckResult::STATUS_COMPLIANCE;
96	96	}
97	97
98		- return new CheckResult( $context, $constraint, $status, $message );
	98	+ return new CheckResult($context, $constraint, $status, $message);
99	99	}
100	100
101		- public function checkConstraintParameters( Constraint $constraint ): array {
	101	+ public function checkConstraintParameters(Constraint $constraint): array {
102	102	$constraintParameters = $constraint->getConstraintParameters();
103	103	$exceptions = [];
104	104	try {
105		- $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
106		- } catch ( ConstraintParameterException $e ) {
	105	+ $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
	106	+ } catch (ConstraintParameterException $e) {
107	107	$exceptions[] = $e;
108	108	}
109	109	return $exceptions;
		@@ -122,23 +122,23 @@ discard block
		block discarded – undo
122	122	$separators,
123	123	$propertyId
124	124	) {
125		- if ( $bestRankCount === $nonDeprecatedCount ) {
126		- if ( $separators === [] ) {
	125	+ if ($bestRankCount === $nonDeprecatedCount) {
	126	+ if ($separators === []) {
127	127	$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
128	128	} else {
129	129	$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
130	130	}
131	131	} else {
132		- if ( $separators === [] ) {
	132	+ if ($separators === []) {
133	133	$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
134	134	} else {
135	135	$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
136	136	}
137	137	}
138	138
139		- return ( new ViolationMessage( $messageKey ) )
140		- ->withEntityId( $propertyId )
141		- ->withEntityIdList( $separators );
	139	+ return (new ViolationMessage($messageKey))
	140	+ ->withEntityId($propertyId)
	141	+ ->withEntityIdList($separators);
142	142	}
143	143
144	144	}

		@@ -75,9 +75,9 @@ discard block
		block discarded – undo
75	75	* @throws ConstraintParameterException
76	76	* @return CheckResult
77	77	*/
78		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
79		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
80		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	78	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	79	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	80	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
81	81	}
82	82
83	83	$constraintParameters = $constraint->getConstraintParameters();
		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	* a) a property only
100	100	* b) a property and a number of items (each combination of property and item forming an individual claim)
101	101	*/
102		- if ( $items === [] ) {
	102	+ if ($items === []) {
103	103	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
104	104	$context->getEntity()->getStatements(),
105	105	$propertyId
		@@ -112,21 +112,21 @@ discard block
		block discarded – undo
112	112	);
113	113	}
114	114
115		- if ( $requiredStatement !== null ) {
	115	+ if ($requiredStatement !== null) {
116	116	$status = CheckResult::STATUS_COMPLIANCE;
117	117	$message = null;
118	118	} else {
119	119	$status = CheckResult::STATUS_VIOLATION;
120		- $message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
121		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
122		- ->withEntityId( $propertyId, Role::PREDICATE )
123		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	120	+ $message = (new ViolationMessage('wbqc-violation-message-item'))
	121	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	122	+ ->withEntityId($propertyId, Role::PREDICATE)
	123	+ ->withItemIdSnakValueList($items, Role::OBJECT);
124	124	}
125	125
126		- return new CheckResult( $context, $constraint, $status, $message );
	126	+ return new CheckResult($context, $constraint, $status, $message);
127	127	}
128	128
129		- public function checkConstraintParameters( Constraint $constraint ): array {
	129	+ public function checkConstraintParameters(Constraint $constraint): array {
130	130	$constraintParameters = $constraint->getConstraintParameters();
131	131	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
132	132	$exceptions = [];
		@@ -135,7 +135,7 @@ discard block
		block discarded – undo
135	135	$constraintParameters,
136	136	$constraintTypeItemId
137	137	);
138		- } catch ( ConstraintParameterException $e ) {
	138	+ } catch (ConstraintParameterException $e) {
139	139	$exceptions[] = $e;
140	140	}
141	141	try {
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	$constraintTypeItemId,
145	145	false
146	146	);
147		- } catch ( ConstraintParameterException $e ) {
	147	+ } catch (ConstraintParameterException $e) {
148	148	$exceptions[] = $e;
149	149	}
150	150	return $exceptions;

		@@ -67,9 +67,9 @@ discard block
		block discarded – undo
67	67	* @throws ConstraintParameterException
68	68	* @return CheckResult
69	69	*/
70		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
71		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	70	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	71	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	72	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
73	73	}
74	74
75	75	$constraintParameters = $constraint->getConstraintParameters();
		@@ -84,33 +84,33 @@ discard block
		block discarded – undo
84	84	$status = CheckResult::STATUS_COMPLIANCE;
85	85
86	86	/** @var Snak $qualifier */
87		- foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
	87	+ foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
88	88	$allowedQualifier = false;
89		- foreach ( $properties as $property ) {
90		- if ( $qualifier->getPropertyId()->equals( $property ) ) {
	89	+ foreach ($properties as $property) {
	90	+ if ($qualifier->getPropertyId()->equals($property)) {
91	91	$allowedQualifier = true;
92	92	break;
93	93	}
94	94	}
95		- if ( !$allowedQualifier ) {
96		- if ( $properties === [] \|\| $properties === [ '' ] ) {
97		- $message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
98		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	95	+ if (!$allowedQualifier) {
	96	+ if ($properties === [] \|\| $properties === ['']) {
	97	+ $message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
	98	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
99	99	} else {
100		- $message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
101		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
102		- ->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
103		- ->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
	100	+ $message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
	101	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	102	+ ->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
	103	+ ->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
104	104	}
105	105	$status = CheckResult::STATUS_VIOLATION;
106	106	break;
107	107	}
108	108	}
109	109
110		- return new CheckResult( $context, $constraint, $status, $message );
	110	+ return new CheckResult($context, $constraint, $status, $message);
111	111	}
112	112
113		- public function checkConstraintParameters( Constraint $constraint ): array {
	113	+ public function checkConstraintParameters(Constraint $constraint): array {
114	114	$constraintParameters = $constraint->getConstraintParameters();
115	115	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
116	116	$exceptions = [];
		@@ -119,7 +119,7 @@ discard block
		block discarded – undo
119	119	$constraintParameters,
120	120	$constraintTypeItemId
121	121	);
122		- } catch ( ConstraintParameterException $e ) {
	122	+ } catch (ConstraintParameterException $e) {
123	123	$exceptions[] = $e;
124	124	}
125	125	return $exceptions;

		@@ -64,9 +64,9 @@ discard block
		block discarded – undo
64	64	* @throws ConstraintParameterException
65	65	* @return CheckResult
66	66	*/
67		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
68		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
69		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	67	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	68	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	69	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
70	70	}
71	71
72	72	$separators = $this->constraintParameterParser->parseSeparatorsParameter(
		@@ -75,19 +75,19 @@ discard block
		block discarded – undo
75	75
76	76	$propertyId = $context->getSnak()->getPropertyId();
77	77	$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
78		- $context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
	78	+ $context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
79	79	$propertyId
80	80	);
81	81
82		- if ( $propertyCount > 1 ) {
83		- $message = $this->getViolationMessage( $separators, $propertyId );
	82	+ if ($propertyCount > 1) {
	83	+ $message = $this->getViolationMessage($separators, $propertyId);
84	84	$status = CheckResult::STATUS_VIOLATION;
85	85	} else {
86	86	$message = null;
87	87	$status = CheckResult::STATUS_COMPLIANCE;
88	88	}
89	89
90		- return new CheckResult( $context, $constraint, $status, $message );
	90	+ return new CheckResult($context, $constraint, $status, $message);
91	91	}
92	92
93	93	/**
		@@ -95,22 +95,21 @@ discard block
		block discarded – undo
95	95	* @param PropertyId $propertyId
96	96	* @return ViolationMessage
97	97	*/
98		- private function getViolationMessage( array $separators, PropertyId $propertyId ) {
	98	+ private function getViolationMessage(array $separators, PropertyId $propertyId) {
99	99	$messageKey = $separators === [] ?
100		- 'wbqc-violation-message-single-value' :
101		- 'wbqc-violation-message-single-value-separators';
	100	+ 'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
102	101
103		- return ( new ViolationMessage( $messageKey ) )
104		- ->withEntityId( $propertyId )
105		- ->withEntityIdList( $separators );
	102	+ return (new ViolationMessage($messageKey))
	103	+ ->withEntityId($propertyId)
	104	+ ->withEntityIdList($separators);
106	105	}
107	106
108		- public function checkConstraintParameters( Constraint $constraint ): array {
	107	+ public function checkConstraintParameters(Constraint $constraint): array {
109	108	$constraintParameters = $constraint->getConstraintParameters();
110	109	$exceptions = [];
111	110	try {
112		- $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
113		- } catch ( ConstraintParameterException $e ) {
	111	+ $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
	112	+ } catch (ConstraintParameterException $e) {
114	113	$exceptions[] = $e;
115	114	}
116	115	return $exceptions;

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	* @codeCoverageIgnore This method is purely declarative.
31	31	*/
32	32	public function getDefaultContextTypes(): array {
33		- return [ Context::TYPE_STATEMENT ];
	33	+ return [Context::TYPE_STATEMENT];
34	34	}
35	35
36	36	/** @codeCoverageIgnore This method is purely declarative. */
		@@ -38,12 +38,12 @@ discard block
		block discarded – undo
38	38	return self::ALL_ENTITY_TYPES_SUPPORTED;
39	39	}
40	40
41		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
	41	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
42	42	$referenceList = $context->getSnakStatement()->getReferences();
43	43
44		- if ( $referenceList->isEmpty() ) {
45		- $message = ( new ViolationMessage( 'wbqc-violation-message-citationNeeded' ) )
46		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	44	+ if ($referenceList->isEmpty()) {
	45	+ $message = (new ViolationMessage('wbqc-violation-message-citationNeeded'))
	46	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
47	47	return new CheckResult(
48	48	$context,
49	49	$constraint,
		@@ -52,10 +52,10 @@ discard block
		block discarded – undo
52	52	);
53	53	}
54	54
55		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	55	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
56	56	}
57	57
58		- public function checkConstraintParameters( Constraint $constraint ): array {
	58	+ public function checkConstraintParameters(Constraint $constraint): array {
59	59	// no parameters
60	60	return [];
61	61	}

		@@ -79,9 +79,9 @@ discard block
		block discarded – undo
79	79	* @throws ConstraintParameterException
80	80	* @return CheckResult
81	81	*/
82		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
83		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
84		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	82	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	83	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	84	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
85	85	}
86	86
87	87	$constraintParameters = $constraint->getConstraintParameters();
		@@ -100,9 +100,9 @@ discard block
		block discarded – undo
100	100
101	101	$snak = $context->getSnak();
102	102
103		- if ( !$snak instanceof PropertyValueSnak ) {
	103	+ if (!$snak instanceof PropertyValueSnak) {
104	104	// nothing to check
105		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	105	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
106	106	}
107	107
108	108	$dataValue = $snak->getDataValue();
		@@ -111,18 +111,18 @@ discard block
		block discarded – undo
111	111	* error handling:
112	112	* type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
113	113	*/
114		- if ( !$dataValue instanceof EntityIdValue ) {
115		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
116		- ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
117		- ->withDataValueType( 'wikibase-entityid' );
118		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	114	+ if (!$dataValue instanceof EntityIdValue) {
	115	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	116	+ ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
	117	+ ->withDataValueType('wikibase-entityid');
	118	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
119	119	}
120	120
121	121	$targetEntityId = $dataValue->getEntityId();
122		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
123		- if ( !$targetEntity instanceof StatementListProvider ) {
124		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
125		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	122	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	123	+ if (!$targetEntity instanceof StatementListProvider) {
	124	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	125	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
126	126	}
127	127
128	128	/*
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	* a) a property only
131	131	* b) a property and a number of items (each combination forming an individual claim)
132	132	*/
133		- if ( $items === [] ) {
	133	+ if ($items === []) {
134	134	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
135	135	$targetEntity->getStatements(),
136	136	$propertyId
		@@ -143,23 +143,23 @@ discard block
		block discarded – undo
143	143	);
144	144	}
145	145
146		- if ( $requiredStatement !== null ) {
	146	+ if ($requiredStatement !== null) {
147	147	$status = CheckResult::STATUS_COMPLIANCE;
148	148	$message = null;
149	149	} else {
150	150	$status = CheckResult::STATUS_VIOLATION;
151		- $message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
152		- ->withEntityId( $targetEntityId, Role::SUBJECT )
153		- ->withEntityId( $propertyId, Role::PREDICATE )
154		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	151	+ $message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
	152	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	153	+ ->withEntityId($propertyId, Role::PREDICATE)
	154	+ ->withItemIdSnakValueList($items, Role::OBJECT);
155	155	}
156	156
157		- return ( new CheckResult( $context, $constraint, $status, $message ) )
158		- ->withMetadata( Metadata::ofDependencyMetadata(
159		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	157	+ return (new CheckResult($context, $constraint, $status, $message))
	158	+ ->withMetadata(Metadata::ofDependencyMetadata(
	159	+ DependencyMetadata::ofEntityId($targetEntityId) ));
160	160	}
161	161
162		- public function checkConstraintParameters( Constraint $constraint ): array {
	162	+ public function checkConstraintParameters(Constraint $constraint): array {
163	163	$constraintParameters = $constraint->getConstraintParameters();
164	164	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
165	165	$exceptions = [];
		@@ -168,7 +168,7 @@ discard block
		block discarded – undo
168	168	$constraintParameters,
169	169	$constraintTypeItemId
170	170	);
171		- } catch ( ConstraintParameterException $e ) {
	171	+ } catch (ConstraintParameterException $e) {
172	172	$exceptions[] = $e;
173	173	}
174	174	try {
		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	$constraintTypeItemId,
178	178	false
179	179	);
180		- } catch ( ConstraintParameterException $e ) {
	180	+ } catch (ConstraintParameterException $e) {
181	181	$exceptions[] = $e;
182	182	}
183	183	return $exceptions;

		@@ -79,17 +79,17 @@ discard block
		block discarded – undo
79	79	*
80	80	* @return CheckResult
81	81	*/
82		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
83		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
84		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	82	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	83	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	84	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
85	85	}
86	86
87	87	$snak = $context->getSnak();
88	88	$propertyId = $context->getSnak()->getPropertyId();
89	89
90		- if ( !$snak instanceof PropertyValueSnak ) {
	90	+ if (!$snak instanceof PropertyValueSnak) {
91	91	// nothing to check
92		- return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
	92	+ return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
93	93	}
94	94
95	95	$dataValue = $snak->getDataValue();
		@@ -98,18 +98,18 @@ discard block
		block discarded – undo
98	98	* error handling:
99	99	* type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
100	100	*/
101		- if ( !$dataValue instanceof EntityIdValue ) {
102		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
103		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
104		- ->withDataValueType( 'wikibase-entityid' );
105		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	101	+ if (!$dataValue instanceof EntityIdValue) {
	102	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	103	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	104	+ ->withDataValueType('wikibase-entityid');
	105	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
106	106	}
107	107
108	108	$targetEntityId = $dataValue->getEntityId();
109		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
110		- if ( !$targetEntity instanceof StatementListProvider ) {
111		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
112		- return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
	109	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	110	+ if (!$targetEntity instanceof StatementListProvider) {
	111	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	112	+ return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
113	113	}
114	114
115	115	$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
		@@ -117,23 +117,23 @@ discard block
		block discarded – undo
117	117	$propertyId,
118	118	$context->getEntity()->getId()
119	119	);
120		- if ( $symmetricStatement !== null ) {
	120	+ if ($symmetricStatement !== null) {
121	121	$message = null;
122	122	$status = CheckResult::STATUS_COMPLIANCE;
123	123	} else {
124		- $message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
125		- ->withEntityId( $targetEntityId, Role::SUBJECT )
126		- ->withEntityId( $propertyId, Role::PREDICATE )
127		- ->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
	124	+ $message = (new ViolationMessage('wbqc-violation-message-symmetric'))
	125	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	126	+ ->withEntityId($propertyId, Role::PREDICATE)
	127	+ ->withEntityId($context->getEntity()->getId(), Role::OBJECT);
128	128	$status = CheckResult::STATUS_VIOLATION;
129	129	}
130	130
131		- return ( new CheckResult( $context, $constraint, $status, $message ) )
132		- ->withMetadata( Metadata::ofDependencyMetadata(
133		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	131	+ return (new CheckResult($context, $constraint, $status, $message))
	132	+ ->withMetadata(Metadata::ofDependencyMetadata(
	133	+ DependencyMetadata::ofEntityId($targetEntityId) ));
134	134	}
135	135
136		- public function checkConstraintParameters( Constraint $constraint ): array {
	136	+ public function checkConstraintParameters(Constraint $constraint): array {
137	137	// no parameters
138	138	return [];
139	139	}

		@@ -57,9 +57,9 @@ discard block
		block discarded – undo
57	57	* @throws ConstraintParameterException
58	58	* @return CheckResult
59	59	*/
60		- public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
61		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
62		- return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
	60	+ public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
	61	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	62	+ return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
63	63	}
64	64
65	65	$constraintParameters = $constraint->getConstraintParameters();
		@@ -76,20 +76,20 @@ discard block
		block discarded – undo
76	76	$message = null;
77	77	$status = CheckResult::STATUS_COMPLIANCE;
78	78
79		- foreach ( $items as $item ) {
80		- if ( $item->matchesSnak( $snak ) ) {
81		- $message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
82		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
83		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	79	+ foreach ($items as $item) {
	80	+ if ($item->matchesSnak($snak)) {
	81	+ $message = (new ViolationMessage('wbqc-violation-message-none-of'))
	82	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
	83	+ ->withItemIdSnakValueList($items, Role::OBJECT);
84	84	$status = CheckResult::STATUS_VIOLATION;
85	85	break;
86	86	}
87	87	}
88	88
89		- return new CheckResult( $context, $constraint, $status, $message );
	89	+ return new CheckResult($context, $constraint, $status, $message);
90	90	}
91	91
92		- public function checkConstraintParameters( Constraint $constraint ): array {
	92	+ public function checkConstraintParameters(Constraint $constraint): array {
93	93	$constraintParameters = $constraint->getConstraintParameters();
94	94	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
95	95	$exceptions = [];
		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	$constraintTypeItemId,
100	100	true
101	101	);
102		- } catch ( ConstraintParameterException $e ) {
	102	+ } catch (ConstraintParameterException $e) {
103	103	$exceptions[] = $e;
104	104	}
105	105	return $exceptions;

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( 60f697...f33fff )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch