wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Api/ExpiryLock.php

Spacing +19 added lines, -19 removed lines

@@ -26,7 +26,7 @@ 
 	/**
 	 * @param BagOStuff $cache
 	 */
-	public function __construct( BagOStuff $cache ) {
+	public function __construct(BagOStuff $cache) {
 		$this->cache = $cache;
 	}
 
@@ -37,17 +37,17 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function makeKey( $id ) {
-		if ( empty( trim( $id ) ) ) {
-			throw new ParameterTypeException( '$id', 'non-empty string' );
+	private function makeKey($id) {
+		if (empty(trim($id))) {
+			throw new ParameterTypeException('$id', 'non-empty string');
 		}
 
-		Assert::parameterType( 'string', $id, '$id' );
+		Assert::parameterType('string', $id, '$id');
 
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints',
 			'ExpiryLock',
-			(string)$id
+			(string) $id
 		);
 	}
 
@@ -59,15 +59,15 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function lock( $id, ConvertibleTimestamp $expiryTimestamp ) {
+	public function lock($id, ConvertibleTimestamp $expiryTimestamp) {
 
-		$cacheId = $this->makeKey( $id );
+		$cacheId = $this->makeKey($id);
 
-		if ( !$this->isLockedInternal( $cacheId ) ) {
+		if (!$this->isLockedInternal($cacheId)) {
 			return $this->cache->set(
 				$cacheId,
-				$expiryTimestamp->getTimestamp( TS_UNIX ),
-				(int)$expiryTimestamp->getTimestamp( TS_UNIX )
+				$expiryTimestamp->getTimestamp(TS_UNIX),
+				(int) $expiryTimestamp->getTimestamp(TS_UNIX)
 			);
 		} else {
 			return false;
@@ -81,20 +81,20 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function isLockedInternal( $cacheId ) {
-		$expiryTime = $this->cache->get( $cacheId );
-		if ( !$expiryTime ) {
+	private function isLockedInternal($cacheId) {
+		$expiryTime = $this->cache->get($cacheId);
+		if (!$expiryTime) {
 			return false;
 		}
 
 		try {
-			$lockExpiryTimeStamp = new ConvertibleTimestamp( $expiryTime );
-		} catch ( TimestampException $exception ) {
+			$lockExpiryTimeStamp = new ConvertibleTimestamp($expiryTime);
+		} catch (TimestampException $exception) {
 			return false;
 		}
 
 		$now = new ConvertibleTimestamp();
-		if ( $now->timestamp < $lockExpiryTimeStamp->timestamp ) {
+		if ($now->timestamp < $lockExpiryTimeStamp->timestamp) {
 			return true;
 		} else {
 			return false;
@@ -108,8 +108,8 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function isLocked( $id ) {
-		return $this->isLockedInternal( $this->makeKey( $id ) );
+	public function isLocked($id) {
+		return $this->isLockedInternal($this->makeKey($id));
 	}
 
 }

src/CachingConstraintLookup.php

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
 	/**
 	 * @param ConstraintLookup $lookup The lookup to which all queries are delegated.
 	 */
-	public function __construct( ConstraintLookup $lookup ) {
+	public function __construct(ConstraintLookup $lookup) {
 		$this->lookup = $lookup;
 	}
 
@@ -35,10 +35,10 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( NumericPropertyId $propertyId ) {
+	public function queryConstraintsForProperty(NumericPropertyId $propertyId) {
 		$id = $propertyId->getSerialization();
-		if ( !array_key_exists( $id, $this->cache ) ) {
-			$this->cache[$id] = $this->lookup->queryConstraintsForProperty( $propertyId );
+		if (!array_key_exists($id, $this->cache)) {
+			$this->cache[$id] = $this->lookup->queryConstraintsForProperty($propertyId);
 		}
 		return $this->cache[$id];
 	}

src/ConstraintLookup.php

Spacing +1 added lines, -1 removed lines

@@ -14,6 +14,6 @@
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( NumericPropertyId $propertyId );
+	public function queryConstraintsForProperty(NumericPropertyId $propertyId);
 
 }

src/Job/UpdateConstraintsTableJob.php

Spacing +28 added lines, -28 removed lines

@@ -38,8 +38,8 @@ 
 	 */
 	private const BATCH_SIZE = 50;
 
-	public static function newFromGlobalState( Title $title, array $params ) {
-		Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' );
+	public static function newFromGlobalState(Title $title, array $params) {
+		Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]');
 		$services = MediaWikiServices::getInstance();
 		return new UpdateConstraintsTableJob(
 			$title,
@@ -49,8 +49,8 @@ 
 			$services->getMainConfig(),
 			ConstraintsServices::getConstraintStore(),
 			$services->getDBLoadBalancerFactory(),
-			WikibaseRepo::getStore()->getEntityRevisionLookup( Store::LOOKUP_CACHING_DISABLED ),
-			WikibaseRepo::getBaseDataModelSerializerFactory( $services )
+			WikibaseRepo::getStore()->getEntityRevisionLookup(Store::LOOKUP_CACHING_DISABLED),
+			WikibaseRepo::getBaseDataModelSerializerFactory($services)
 				->newSnakSerializer(),
 			$services->getJobQueueGroup()
 		);
@@ -118,7 +118,7 @@ 
 		Serializer $snakSerializer,
 		JobQueueGroup $jobQueueGroup
 	) {
-		parent::__construct( 'constraintsTableUpdate', $title, $params );
+		parent::__construct('constraintsTableUpdate', $title, $params);
 
 		$this->propertyId = $propertyId;
 		$this->revisionId = $revisionId;
@@ -130,11 +130,11 @@ 
 		$this->jobQueueGroup = $jobQueueGroup;
 	}
 
-	public function extractParametersFromQualifiers( SnakList $qualifiers ) {
+	public function extractParametersFromQualifiers(SnakList $qualifiers) {
 		$parameters = [];
-		foreach ( $qualifiers as $qualifier ) {
+		foreach ($qualifiers as $qualifier) {
 			$qualifierId = $qualifier->getPropertyId()->getSerialization();
-			$paramSerialization = $this->snakSerializer->serialize( $qualifier );
+			$paramSerialization = $this->snakSerializer->serialize($qualifier);
 			$parameters[$qualifierId][] = $paramSerialization;
 		}
 		return $parameters;
@@ -151,7 +151,7 @@ 
 		'@phan-var \Wikibase\DataModel\Entity\EntityIdValue $dataValue';
 		$entityId = $dataValue->getEntityId();
 		$constraintTypeQid = $entityId->getSerialization();
-		$parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() );
+		$parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers());
 		return new Constraint(
 			$constraintId,
 			$propertyId,
@@ -166,25 +166,25 @@ 
 		NumericPropertyId $propertyConstraintPropertyId
 	) {
 		$constraintsStatements = $property->getStatements()
-			->getByPropertyId( $propertyConstraintPropertyId )
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByPropertyId($propertyConstraintPropertyId)
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 		$constraints = [];
-		foreach ( $constraintsStatements->getIterator() as $constraintStatement ) {
+		foreach ($constraintsStatements->getIterator() as $constraintStatement) {
 			// @phan-suppress-next-line PhanTypeMismatchArgumentSuperType
-			$constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement );
-			if ( count( $constraints ) >= self::BATCH_SIZE ) {
-				$constraintStore->insertBatch( $constraints );
+			$constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement);
+			if (count($constraints) >= self::BATCH_SIZE) {
+				$constraintStore->insertBatch($constraints);
 				// interrupt transaction and wait for replication
-				$connection = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY );
-				$connection->endAtomic( __CLASS__ );
-				if ( !$connection->explicitTrxActive() ) {
+				$connection = $this->lbFactory->getMainLB()->getConnection(DB_PRIMARY);
+				$connection->endAtomic(__CLASS__);
+				if (!$connection->explicitTrxActive()) {
 					$this->lbFactory->waitForReplication();
 				}
-				$connection->startAtomic( __CLASS__ );
+				$connection->startAtomic(__CLASS__);
 				$constraints = [];
 			}
 		}
-		$constraintStore->insertBatch( $constraints );
+		$constraintStore->insertBatch($constraints);
 	}
 
 	/**
@@ -195,24 +195,24 @@ 
 	public function run() {
 		// TODO in the future: only touch constraints affected by the edit (requires T163465)
 
-		$propertyId = new NumericPropertyId( $this->propertyId );
+		$propertyId = new NumericPropertyId($this->propertyId);
 		$propertyRevision = $this->entityRevisionLookup->getEntityRevision(
 			$propertyId,
 			0, // latest
 			LookupConstants::LATEST_FROM_REPLICA
 		);
 
-		if ( $this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId ) {
-			$this->jobQueueGroup->push( $this );
+		if ($this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId) {
+			$this->jobQueueGroup->push($this);
 			return true;
 		}
 
-		$connection = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY );
+		$connection = $this->lbFactory->getMainLB()->getConnection(DB_PRIMARY);
 		// start transaction (if not started yet) – using __CLASS__, not __METHOD__,
 		// because importConstraintsForProperty() can interrupt the transaction
-		$connection->startAtomic( __CLASS__ );
+		$connection->startAtomic(__CLASS__);
 
-		$this->constraintStore->deleteForProperty( $propertyId );
+		$this->constraintStore->deleteForProperty($propertyId);
 
 		/** @var Property $property */
 		$property = $propertyRevision->getEntity();
@@ -220,10 +220,10 @@ 
 		$this->importConstraintsForProperty(
 			$property,
 			$this->constraintStore,
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) )
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId'))
 		);
 
-		$connection->endAtomic( __CLASS__ );
+		$connection->endAtomic(__CLASS__);
 
 		return true;
 	}

src/ConstraintRepositoryLookup.php

Spacing +18 added lines, -18 removed lines

@@ -25,7 +25,7 @@ 
 	 * then using the main DBLoadBalancer service may be incorrect.
 	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
 	 */
-	public function __construct( ILoadBalancer $lb, $dbName ) {
+	public function __construct(ILoadBalancer $lb, $dbName) {
 		$this->lb = $lb;
 		$this->dbName = $dbName;
 	}
@@ -35,22 +35,22 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( NumericPropertyId $propertyId ) {
-		$dbr = $this->lb->getConnection( ILoadBalancer::DB_REPLICA, [], $this->dbName );
+	public function queryConstraintsForProperty(NumericPropertyId $propertyId) {
+		$dbr = $this->lb->getConnection(ILoadBalancer::DB_REPLICA, [], $this->dbName);
 
 		$results = $dbr->newSelectQueryBuilder()
-			->select( [
+			->select([
 				'constraint_type_qid',
 				'constraint_parameters',
 				'constraint_guid',
 				'pid',
-			] )
-			->from( 'wbqc_constraints' )
-			->where( [ 'pid' => $propertyId->getNumericId() ] )
-			->caller( __METHOD__ )
+			])
+			->from('wbqc_constraints')
+			->where(['pid' => $propertyId->getNumericId()])
+			->caller(__METHOD__)
 			->fetchResultSet();
 
-		return $this->convertToConstraints( $results );
+		return $this->convertToConstraints($results);
 	}
 
 	/**
@@ -58,26 +58,26 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	private function convertToConstraints( IResultWrapper $results ) {
+	private function convertToConstraints(IResultWrapper $results) {
 		$constraints = [];
-		$logger = LoggerFactory::getInstance( 'WikibaseQualityConstraints' );
-		foreach ( $results as $result ) {
+		$logger = LoggerFactory::getInstance('WikibaseQualityConstraints');
+		foreach ($results as $result) {
 			$constraintTypeItemId = $result->constraint_type_qid;
-			$constraintParameters = json_decode( $result->constraint_parameters, true );
+			$constraintParameters = json_decode($result->constraint_parameters, true);
 
-			if ( $constraintParameters === null ) {
+			if ($constraintParameters === null) {
 				// T171295
-				$logger->warning( 'Constraint {constraintId} has invalid constraint parameters.', [
+				$logger->warning('Constraint {constraintId} has invalid constraint parameters.', [
 					'method' => __METHOD__,
 					'constraintId' => $result->constraint_guid,
 					'constraintParameters' => $result->constraint_parameters,
-				] );
-				$constraintParameters = [ '@error' => [ /* unknown */ ] ];
+				]);
+				$constraintParameters = ['@error' => [/* unknown */]];
 			}
 
 			$constraints[] = new Constraint(
 				$result->constraint_guid,
-				NumericPropertyId::newFromNumber( $result->pid ),
+				NumericPropertyId::newFromNumber($result->pid),
 				$constraintTypeItemId,
 				$constraintParameters
 			);

src/ConstraintCheck/Context/ReferenceContext.php

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -32,7 +32,7 @@ 
 		Reference $reference,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 		$this->reference = $reference;
 	}
@@ -41,16 +41,16 @@ 
 		return self::TYPE_REFERENCE;
 	}
 
-	public function getSnakGroup( string $groupingMode, array $separators = [] ): array {
+	public function getSnakGroup(string $groupingMode, array $separators = []): array {
 		$snaks = $this->reference->getSnaks();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor(): ContextCursor {
 		return new ReferenceContextCursor(
 			$this->entity->getId()->getSerialization(),
 			$this->statement->getPropertyId()->getSerialization(),
-			$this->getStatementGuid( $this->statement ),
+			$this->getStatementGuid($this->statement),
 			$this->snak->getHash(),
 			$this->snak->getPropertyId()->getSerialization(),
 			$this->reference->getHash()

src/ConstraintCheck/Context/Context.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -119,7 +119,7 @@ 
 	 * @return Snak[] not a SnakList because for a statement context,
 	 * the returned value might contain the same snak several times.
 	 */
-	public function getSnakGroup( string $groupingMode, array $separators = [] ): array;
+	public function getSnakGroup(string $groupingMode, array $separators = []): array;
 
 	/**
 	 * Get the cursor that can be used to address check results for this context.

src/ConstraintCheck/Context/QualifierContext.php

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -25,7 +25,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -33,16 +33,16 @@ 
 		return self::TYPE_QUALIFIER;
 	}
 
-	public function getSnakGroup( string $groupingMode, array $separators = [] ): array {
+	public function getSnakGroup(string $groupingMode, array $separators = []): array {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor(): ContextCursor {
 		return new QualifierContextCursor(
 			$this->entity->getId()->getSerialization(),
 			$this->statement->getPropertyId()->getSerialization(),
-			$this->getStatementGuid( $this->statement ),
+			$this->getStatementGuid($this->statement),
 			$this->snak->getHash(),
 			$this->snak->getPropertyId()->getSerialization()
 		);

src/ConstraintCheck/Context/AbstractContext.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
 
@@ -21,7 +21,7 @@ 
 
 	protected Snak $snak;
 
-	public function __construct( StatementListProvidingEntity $entity, Snak $snak ) {
+	public function __construct(StatementListProvidingEntity $entity, Snak $snak) {
 		$this->entity = $entity;
 		$this->snak = $snak;
 	}
@@ -47,15 +47,15 @@ 
 	// unimplemented: getCursor
 
 	/** Helper function for {@link getCursor()} implementations. */
-	protected function getStatementGuid( Statement $statement ): string {
+	protected function getStatementGuid(Statement $statement): string {
 		$guid = $statement->getGuid();
-		if ( $guid === null ) {
-			if ( defined( 'MW_PHPUNIT_TEST' ) ) {
+		if ($guid === null) {
+			if (defined('MW_PHPUNIT_TEST')) {
 				// let unit tests get away with not specifying a statement GUID:
 				// much more convenient to fake it here than to add one to all tests
 				return 'Q0$DEADBEEF-DEAD-BEEF-DEAD-BEEFDEADBEEF';
 			} else {
-				throw new InvalidArgumentException( 'Statement for Context must have a GUID' );
+				throw new InvalidArgumentException('Statement for Context must have a GUID');
 			}
 		}
 		return $guid;