Issues in dumpJson.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

repo/maintenance/dumpJson.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\Repo\Maintenance;

use MediaWiki\MediaWikiServices;
use Serializers\Serializer;
use Wikibase\DataModel\Services\Entity\EntityPrefetcher;
use Wikibase\DataModel\Services\Lookup\PropertyDataTypeLookup;
use Wikibase\Lib\Store\EntityRevisionLookup;
use Wikibase\Repo\Dumpers\DumpGenerator;
use Wikibase\Repo\Dumpers\JsonDumpGenerator;
use Wikibase\Repo\Store\Sql\SqlEntityIdPagerFactory;
use Wikibase\Repo\WikibaseRepo;

require_once __DIR__ . '/DumpEntities.php';

/**
 * @license GPL-2.0-or-later
 * @author Daniel Kinzler
 * @author Addshore
 */
class DumpJson extends DumpEntities {

	/**
	 * @var EntityRevisionLookup
	 */
	private $entityRevisionLookup;

	/**
	 * @var Serializer
	 */
	private $entitySerializer;

	/**
	 * @var EntityPrefetcher
	 */
	private $entityPrefetcher;

	/**
	 * @var PropertyDataTypeLookup
	 */
	private $propertyDatatypeLookup;

	/**
	 * @var bool
	 */
	private $hasHadServicesSet = false;

	public function __construct() {
		parent::__construct();

		$this->addOption(
			'snippet',
			'Output a JSON snippet without square brackets at the start and end. Allows output to'
				. ' be combined more freely.',
			false,
			false
		);
	}

	public function setServices(
		SqlEntityIdPagerFactory $sqlEntityIdPagerFactory,
		array $existingEntityTypes,
		EntityPrefetcher $entityPrefetcher,
		PropertyDataTypeLookup $propertyDataTypeLookup,
		EntityRevisionLookup $entityRevisionLookup,
		Serializer $entitySerializer
	) {
		parent::setDumpEntitiesServices(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
			$sqlEntityIdPagerFactory,
			$existingEntityTypes,
			[]
		);
		$this->entityPrefetcher = $entityPrefetcher;
		$this->propertyDatatypeLookup = $propertyDataTypeLookup;
		$this->entityRevisionLookup = $entityRevisionLookup;
		$this->entitySerializer = $entitySerializer;
		$this->hasHadServicesSet = true;
	}

	public function execute() {
		if ( !$this->hasHadServicesSet ) {
			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
			$sqlEntityIdPagerFactory = new SqlEntityIdPagerFactory(
				$wikibaseRepo->getEntityNamespaceLookup(),
				$wikibaseRepo->getEntityIdLookup(),
				MediaWikiServices::getInstance()->getLinkCache()
			);
			$revisionLookup = $wikibaseRepo->getEntityRevisionLookup(
				$this->getEntityRevisionLookupCacheMode()
			);

			$this->setServices(
				$sqlEntityIdPagerFactory,
				$wikibaseRepo->getEnabledEntityTypes(),
				$wikibaseRepo->getStore()->getEntityPrefetcher(),
				$wikibaseRepo->getPropertyDataTypeLookup(),
				$revisionLookup,
				$wikibaseRepo->getCompactEntitySerializer()
			);
		}
		parent::execute();
	}

	/**
	 * Create concrete dumper instance
	 * @param resource $output
	 * @return DumpGenerator
	 */
	protected function createDumper( $output ) {
		$dataTypeLookup = $this->propertyDatatypeLookup;

		$dumper = new JsonDumpGenerator(
			$output,
			$this->entityRevisionLookup,
			$this->entitySerializer,
			$this->entityPrefetcher,
			$dataTypeLookup
		);

		$dumper->setUseSnippets( (bool)$this->getOption( 'snippet', false ) );
		return $dumper;
	}

}

$maintClass = DumpJson::class;
require_once RUN_MAINTENANCE_IF_MAIN;


1			<?php
2
3			namespace Wikibase\Repo\Maintenance;
4
5			use MediaWiki\MediaWikiServices;
6			use Serializers\Serializer;
7			use Wikibase\DataModel\Services\Entity\EntityPrefetcher;
8			use Wikibase\DataModel\Services\Lookup\PropertyDataTypeLookup;
9			use Wikibase\Lib\Store\EntityRevisionLookup;
10			use Wikibase\Repo\Dumpers\DumpGenerator;
11			use Wikibase\Repo\Dumpers\JsonDumpGenerator;
12			use Wikibase\Repo\Store\Sql\SqlEntityIdPagerFactory;
13			use Wikibase\Repo\WikibaseRepo;
14
15			require_once __DIR__ . '/DumpEntities.php';
16
17			/**
18			* @license GPL-2.0-or-later
19			* @author Daniel Kinzler
20			* @author Addshore
21			*/
22			class DumpJson extends DumpEntities {
23
24			/**
25			* @var EntityRevisionLookup
26			*/
27			private $entityRevisionLookup;
28
29			/**
30			* @var Serializer
31			*/
32			private $entitySerializer;
33
34			/**
35			* @var EntityPrefetcher
36			*/
37			private $entityPrefetcher;
38
39			/**
40			* @var PropertyDataTypeLookup
41			*/
42			private $propertyDatatypeLookup;
43
44			/**
45			* @var bool
46			*/
47			private $hasHadServicesSet = false;
48
49			public function __construct() {
50			parent::__construct();
51
52			$this->addOption(
53			'snippet',
54			'Output a JSON snippet without square brackets at the start and end. Allows output to'
55			. ' be combined more freely.',
56			false,
57			false
58			);
59			}
60
61			public function setServices(
62			SqlEntityIdPagerFactory $sqlEntityIdPagerFactory,
63			array $existingEntityTypes,
64			EntityPrefetcher $entityPrefetcher,
65			PropertyDataTypeLookup $propertyDataTypeLookup,
66			EntityRevisionLookup $entityRevisionLookup,
67			Serializer $entitySerializer
68			) {
69			parent::setDumpEntitiesServices(
			0 ignored issues – show Comprehensibility Bug introduced 2018-06-08 12:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`setDumpEntitiesServices()` instead of `setServices()`). Are you sure this is correct? If so, you might want to change this to `$this->setDumpEntitiesServices()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
70			$sqlEntityIdPagerFactory,
71			$existingEntityTypes,
72			[]
73			);
74			$this->entityPrefetcher = $entityPrefetcher;
75			$this->propertyDatatypeLookup = $propertyDataTypeLookup;
76			$this->entityRevisionLookup = $entityRevisionLookup;
77			$this->entitySerializer = $entitySerializer;
78			$this->hasHadServicesSet = true;
79			}
80
81			public function execute() {
82			if ( !$this->hasHadServicesSet ) {
83			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
84			$sqlEntityIdPagerFactory = new SqlEntityIdPagerFactory(
85			$wikibaseRepo->getEntityNamespaceLookup(),
86			$wikibaseRepo->getEntityIdLookup(),
87			MediaWikiServices::getInstance()->getLinkCache()
88			);
89			$revisionLookup = $wikibaseRepo->getEntityRevisionLookup(
90			$this->getEntityRevisionLookupCacheMode()
91			);
92
93			$this->setServices(
94			$sqlEntityIdPagerFactory,
95			$wikibaseRepo->getEnabledEntityTypes(),
96			$wikibaseRepo->getStore()->getEntityPrefetcher(),
97			$wikibaseRepo->getPropertyDataTypeLookup(),
98			$revisionLookup,
99			$wikibaseRepo->getCompactEntitySerializer()
100			);
101			}
102			parent::execute();
103			}
104
105			/**
106			* Create concrete dumper instance
107			* @param resource $output
108			* @return DumpGenerator
109			*/
110			protected function createDumper( $output ) {
111			$dataTypeLookup = $this->propertyDatatypeLookup;
112
113			$dumper = new JsonDumpGenerator(
114			$output,
115			$this->entityRevisionLookup,
116			$this->entitySerializer,
117			$this->entityPrefetcher,
118			$dataTypeLookup
119			);
120
121			$dumper->setUseSnippets( (bool)$this->getOption( 'snippet', false ) );
122			return $dumper;
123			}
124
125			}
126
127			$maintClass = DumpJson::class;
128			require_once RUN_MAINTENANCE_IF_MAIN;
129

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

repo/maintenance/dumpJson.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like