Issues in SpecialWikibasePage.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

repo/includes/Specials/SpecialWikibasePage.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\Repo\Specials;

use SpecialPage;
use UserBlockedError;
use Wikibase\Lib\StringNormalizer;

/**
 * Base for special pages of the Wikibase extension,
 * holding some scaffolding and preventing us from needing to
 * deal with weird SpecialPage insanity (ie $this->mFile inclusion)
 * in every base class.
 *
 * @license GPL-2.0-or-later
 * @author Jeroen De Dauw < [email protected] >
 * @author Bene* < [email protected] >
 */
abstract class SpecialWikibasePage extends SpecialPage {

	/**
	 * @var StringNormalizer
	 */
	protected $stringNormalizer;

	/**
	 * @param string $name
	 * @param string $restriction
	 * @param bool   $listed
	 */
	public function __construct( $name = '', $restriction = '', $listed = true ) {
		parent::__construct( $name, $restriction, $listed );

		// XXX: Use StringNormalizer as a plain composite - since it
		//      doesn't have any dependencies, local instantiation isn't an issue.
		$this->stringNormalizer = new StringNormalizer();
	}

	/**
	 * @see SpecialPage::getGroupName
	 *
	 * @return string
	 */
	protected function getGroupName() {
		return 'wikibase';
	}

	/**
	 * @see SpecialPage::getDescription
	 *
	 * @return string
	 */
	public function getDescription() {
		return $this->msg( 'special-' . strtolower( $this->getName() ) )->text();

	}

	/**
	 * @inheritDoc
	 */
	public function setHeaders() {
		$out = $this->getOutput();
		$out->setArticleRelated( false );
		$out->setPageTitle( $this->getDescription() );
	}

	/**
	 * @see SpecialPage::execute
	 *
	 * @param string|null $subPage
	 */
	public function execute( $subPage ) {
		$this->setHeaders();
		$this->outputHeader( 'wikibase-' . strtolower( $this->getName() ) . '-summary' );


		// If the user is authorized, display the page, if not, show an error.
		if ( !$this->userCanExecute( $this->getUser() ) ) {
			$this->displayRestrictionError();
		}
	}

	/**
	 * Checks if user is blocked, and if blocked throws a UserBlocked.
	 *
	 * @throws UserBlockedError
	 */
	protected function checkBlocked() {
		$block = $this->getUser()->getBlock();
		if ( $block && $block->isSitewide() ) {
			throw new UserBlockedError( $this->getUser()->getBlock() );
		}
	}

	/**
	 * @param string $error The error message in HTML format
	 */
	protected function showErrorHTML( $error ) {
		$this->getOutput()->addHTML( '<p class="error">' . $error . '</p>' );
	}

}


1			<?php
2
3			namespace Wikibase\Repo\Specials;
4
5			use SpecialPage;
6			use UserBlockedError;
7			use Wikibase\Lib\StringNormalizer;
8
9			/**
10			* Base for special pages of the Wikibase extension,
11			* holding some scaffolding and preventing us from needing to
12			* deal with weird SpecialPage insanity (ie $this->mFile inclusion)
13			* in every base class.
14			*
15			* @license GPL-2.0-or-later
16			* @author Jeroen De Dauw < [email protected] >
17			* @author Bene* < [email protected] >
18			*/
19			abstract class SpecialWikibasePage extends SpecialPage {
20
21			/**
22			* @var StringNormalizer
23			*/
24			protected $stringNormalizer;
25
26			/**
27			* @param string $name
28			* @param string $restriction
29			* @param bool $listed
30			*/
31			public function __construct( $name = '', $restriction = '', $listed = true ) {
32			parent::__construct( $name, $restriction, $listed );
33
34			// XXX: Use StringNormalizer as a plain composite - since it
35			// doesn't have any dependencies, local instantiation isn't an issue.
36			$this->stringNormalizer = new StringNormalizer();
37			}
38
39			/**
40			* @see SpecialPage::getGroupName
41			*
42			* @return string
43			*/
44			protected function getGroupName() {
45			return 'wikibase';
46			}
47
48			/**
49			* @see SpecialPage::getDescription
50			*
51			* @return string
52			*/
53			public function getDescription() {
54			return $this->msg( 'special-' . strtolower( $this->getName() ) )->text();
			0 ignored issues – show Bug introduced 2016-02-26 19:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using `$this->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
55			}
56
57			/**
58			* @inheritDoc
59			*/
60			public function setHeaders() {
61			$out = $this->getOutput();
62			$out->setArticleRelated( false );
63			$out->setPageTitle( $this->getDescription() );
64			}
65
66			/**
67			* @see SpecialPage::execute
68			*
69			* @param string\|null $subPage
70			*/
71			public function execute( $subPage ) {
72			$this->setHeaders();
73			$this->outputHeader( 'wikibase-' . strtolower( $this->getName() ) . '-summary' );
			0 ignored issues – show Bug introduced 2016-02-26 19:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using `$this->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
74
75			// If the user is authorized, display the page, if not, show an error.
76			if ( !$this->userCanExecute( $this->getUser() ) ) {
77			$this->displayRestrictionError();
78			}
79			}
80
81			/**
82			* Checks if user is blocked, and if blocked throws a UserBlocked.
83			*
84			* @throws UserBlockedError
85			*/
86			protected function checkBlocked() {
87			$block = $this->getUser()->getBlock();
88			if ( $block && $block->isSitewide() ) {
89			throw new UserBlockedError( $this->getUser()->getBlock() );
90			}
91			}
92
93			/**
94			* @param string $error The error message in HTML format
95			*/
96			protected function showErrorHTML( $error ) {
97			$this->getOutput()->addHTML( '<p class="error">' . $error . '</p>' );
98			}
99
100			}
101

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

repo/includes/Specials/SpecialWikibasePage.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like