Issues in DefaultEntityLinkFormatter.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Hooks/Formatters/DefaultEntityLinkFormatter.php (3 issues)

Labels

Bug 3

Severity

Minor 3

Stanislav Malyshev 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\Repo\Hooks\Formatters;

use HtmlArmor;
use Language;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\Lib\Store\EntityTitleTextLookup;

/**
 * Utility class to format entity links with labels for usage in hooks.
 */
class DefaultEntityLinkFormatter implements EntityLinkFormatter {

	/**
	 * @var Language
	 */
	private $pageLanguage;

	/**
	 * @var EntityTitleTextLookup
	 */
	private $entityTitleTextLookup;

	public function __construct( Language $pageLanguage, EntityTitleTextLookup $entityTitleTextLookup ) {
		$this->pageLanguage = $pageLanguage;
		$this->entityTitleTextLookup = $entityTitleTextLookup;
	}

	/**
	 * @inheritDoc
	 */
	public function getHtml( EntityId $entityId, array $labelData = null ) {
		/** @var Language $labelLang */
		list( $labelText, $labelLang ) = $this->extractTextAndLanguage( $labelData );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$idHtml = '<span class="wb-itemlink-id">'
				  . wfMessage(
					  'wikibase-itemlink-id-wrapper',
					  $entityId->getSerialization()
				  )->inContentLanguage()->escaped()
				  . '</span>';

		$labelHtml = '<span class="wb-itemlink-label"'
					 . ' lang="' . htmlspecialchars( $labelLang->getHtmlCode() ) . '"'
					 . ' dir="' . htmlspecialchars( $labelLang->getDir() ) . '">'
					 . HtmlArmor::getHtml( $labelText )
					 . '</span>';

		return '<span class="wb-itemlink">'
			   . wfMessage( 'wikibase-itemlink' )->rawParams(
				$labelHtml,
				$idHtml
			)->inContentLanguage()->escaped()
			   . '</span>';
	}

	/**
	 * @param string[]|null $termData A term record as returned by
	 * TermLanguageFallbackChain::extractPreferredValueOrAny(),
	 * containing the 'value' and 'language' fields, or null
	 * or an empty array.
	 *
	 * @see TermLanguageFallbackChain::extractPreferredValueOrAny
	 *
	 * @return array list( string $text, Language $language )
	 */
	private function extractTextAndLanguage( array $termData = null ) {
		if ( $termData ) {
			return [
				$termData['value'],
				Language::factory( $termData['language'] )
			];
		} else {
			return [
				'',
				$this->pageLanguage
			];
		}
	}

	/**
	 * @inheritDoc
	 */
	public function getTitleAttribute(
		EntityId $entityId,
		array $labelData = null,
		array $descriptionData = null
	) {
		/** @var Language $labelLang */
		/** @var Language $descriptionLang */

		list( $labelText, $labelLang ) = $this->extractTextAndLanguage( $labelData );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		list( $descriptionText, $descriptionLang ) = $this->extractTextAndLanguage( $descriptionData );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		// Set title attribute for constructed link, and make tricks with the directionality to get it right
		$titleText = ( $labelText !== '' )
			? $labelLang->getDirMark() . $labelText
			. $this->pageLanguage->getDirMark()
			: $this->entityTitleTextLookup->getPrefixedText( $entityId );

		if ( $descriptionText !== '' ) {
			$descriptionText = $descriptionLang->getDirMark() . $descriptionText
							   . $this->pageLanguage->getDirMark();
			return wfMessage(
				'wikibase-itemlink-title',
				$titleText,
				$descriptionText
			)->inContentLanguage()->text();
		} else {
			return $titleText; // no description, just display the title then
		}
	}

	public function getFragment( EntityId $entityId, $fragment ) {
		return $fragment;
	}

}


1			<?php
2
3			namespace Wikibase\Repo\Hooks\Formatters;
4
5			use HtmlArmor;
6			use Language;
7			use Wikibase\DataModel\Entity\EntityId;
8			use Wikibase\Lib\Store\EntityTitleTextLookup;
9
10			/**
11			* Utility class to format entity links with labels for usage in hooks.
12			*/
13			class DefaultEntityLinkFormatter implements EntityLinkFormatter {
14
15			/**
16			* @var Language
17			*/
18			private $pageLanguage;
19
20			/**
21			* @var EntityTitleTextLookup
22			*/
23			private $entityTitleTextLookup;
24
25			public function __construct( Language $pageLanguage, EntityTitleTextLookup $entityTitleTextLookup ) {
26			$this->pageLanguage = $pageLanguage;
27			$this->entityTitleTextLookup = $entityTitleTextLookup;
28			}
29
30			/**
31			* @inheritDoc
32			*/
33			public function getHtml( EntityId $entityId, array $labelData = null ) {
34			/** @var Language $labelLang */
35			list( $labelText, $labelLang ) = $this->extractTextAndLanguage( $labelData );
			0 ignored issues – show Bug introduced 2018-06-01 08:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$labelData` can also be of type `array`; however, `Wikibase\Repo\Hooks\Form...xtractTextAndLanguage()` does only seem to accept `null\|array<integer,string>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
36
37			$idHtml = '<span class="wb-itemlink-id">'
38			. wfMessage(
39			'wikibase-itemlink-id-wrapper',
40			$entityId->getSerialization()
41			)->inContentLanguage()->escaped()
42			. '</span>';
43
44			$labelHtml = '<span class="wb-itemlink-label"'
45			. ' lang="' . htmlspecialchars( $labelLang->getHtmlCode() ) . '"'
46			. ' dir="' . htmlspecialchars( $labelLang->getDir() ) . '">'
47			. HtmlArmor::getHtml( $labelText )
48			. '</span>';
49
50			return '<span class="wb-itemlink">'
51			. wfMessage( 'wikibase-itemlink' )->rawParams(
52			$labelHtml,
53			$idHtml
54			)->inContentLanguage()->escaped()
55			. '</span>';
56			}
57
58			/**
59			* @param string[]\|null $termData A term record as returned by
60			* TermLanguageFallbackChain::extractPreferredValueOrAny(),
61			* containing the 'value' and 'language' fields, or null
62			* or an empty array.
63			*
64			* @see TermLanguageFallbackChain::extractPreferredValueOrAny
65			*
66			* @return array list( string $text, Language $language )
67			*/
68			private function extractTextAndLanguage( array $termData = null ) {
69			if ( $termData ) {
70			return [
71			$termData['value'],
72			Language::factory( $termData['language'] )
73			];
74			} else {
75			return [
76			'',
77			$this->pageLanguage
78			];
79			}
80			}
81
82			/**
83			* @inheritDoc
84			*/
85			public function getTitleAttribute(
86			EntityId $entityId,
87			array $labelData = null,
88			array $descriptionData = null
89			) {
90			/** @var Language $labelLang */
91			/** @var Language $descriptionLang */
92
93			list( $labelText, $labelLang ) = $this->extractTextAndLanguage( $labelData );
			0 ignored issues – show Bug introduced 2018-06-01 08:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$labelData` can also be of type `array`; however, `Wikibase\Repo\Hooks\Form...xtractTextAndLanguage()` does only seem to accept `null\|array<integer,string>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
94			list( $descriptionText, $descriptionLang ) = $this->extractTextAndLanguage( $descriptionData );
			0 ignored issues – show Bug introduced 2018-06-01 08:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$descriptionData` can also be of type `array`; however, `Wikibase\Repo\Hooks\Form...xtractTextAndLanguage()` does only seem to accept `null\|array<integer,string>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
95
96			// Set title attribute for constructed link, and make tricks with the directionality to get it right
97			$titleText = ( $labelText !== '' )
98			? $labelLang->getDirMark() . $labelText
99			. $this->pageLanguage->getDirMark()
100			: $this->entityTitleTextLookup->getPrefixedText( $entityId );
101
102			if ( $descriptionText !== '' ) {
103			$descriptionText = $descriptionLang->getDirMark() . $descriptionText
104			. $this->pageLanguage->getDirMark();
105			return wfMessage(
106			'wikibase-itemlink-title',
107			$titleText,
108			$descriptionText
109			)->inContentLanguage()->text();
110			} else {
111			return $titleText; // no description, just display the title then
112			}
113			}
114
115			public function getFragment( EntityId $entityId, $fragment ) {
116			return $fragment;
117			}
118
119			}
120

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

Hooks/Formatters/DefaultEntityLinkFormatter.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like