Issues in ItemDiffVisualizer.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

repo/includes/Diff/ItemDiffVisualizer.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\Repo\Diff;

use Diff\DiffOp\Diff\Diff;
use MessageLocalizer;
use SiteLookup;
use Wikibase\DataModel\Services\Diff\EntityDiff;
use Wikibase\DataModel\Services\EntityId\EntityIdFormatter;
use Wikibase\Repo\Content\EntityContentDiff;

/**
 * Class for generating views of EntityDiff objects.
 *
 * @license GPL-2.0-or-later
 * @author Amir Sarabadani
 */
class ItemDiffVisualizer implements EntityDiffVisualizer {

	/**
	 * @var MessageLocalizer
	 */
	private $messageLocalizer;

	/**
	 * @var ClaimDiffer|null
	 */
	private $claimDiffer;

	/**
	 * @var ClaimDifferenceVisualizer|null
	 */
	private $claimDiffVisualizer;

	/**
	 * @var SiteLookup
	 */
	private $siteLookup;

	/**
	 * @var EntityIdFormatter
	 */
	private $entityIdFormatter;

	/**
	 * @var BasicEntityDiffVisualizer
	 */
	private $basicEntityDiffVisualizer;

	public function __construct(
		MessageLocalizer $messageLocalizer,
		ClaimDiffer $claimDiffer,
		ClaimDifferenceVisualizer $claimDiffView,
		SiteLookup $siteLookup,
		EntityIdFormatter $entityIdFormatter,
		EntityDiffVisualizer $basicEntityDiffVisualizer
	) {
		$this->messageLocalizer = $messageLocalizer;
		$this->claimDiffer = $claimDiffer;
		$this->claimDiffVisualizer = $claimDiffView;
		$this->siteLookup = $siteLookup;
		$this->entityIdFormatter = $entityIdFormatter;
		$this->basicEntityDiffVisualizer = $basicEntityDiffVisualizer;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
	}

	/**
	 * Generates and returns an HTML visualization of the provided EntityContentDiff.
	 *
	 * @param EntityContentDiff $diff
	 *
	 * @return string
	 */
	public function visualizeEntityContentDiff( EntityContentDiff $diff ) {
		if ( $diff->isEmpty() ) {
			return '';
		}

		$basicHtml = $this->basicEntityDiffVisualizer->visualizeEntityContentDiff( $diff );

		return $basicHtml . $this->visualizeEntityDiff( $diff->getEntityDiff() );
	}

	/**
	 * Generates and returns an HTML visualization of the provided EntityDiff.
	 *
	 * @param EntityDiff $diff
	 *
	 * @return string
	 */
	protected function visualizeEntityDiff( EntityDiff $diff ) {
		return ( new ItemDiffView(
			[],
			new Diff(
				[
					// FIXME: getSiteLinkDiff only exists in ItemDiff
					// @phan-suppress-next-line PhanUndeclaredMethod
					$this->messageLocalizer->msg( 'wikibase-diffview-link' )->text() => $diff->getSiteLinkDiff(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
				],
				true
			),
			$this->siteLookup,
			$this->entityIdFormatter,
			$this->messageLocalizer
		) )->getHtml();
	}

}


1			<?php
2
3			namespace Wikibase\Repo\Diff;
4
5			use Diff\DiffOp\Diff\Diff;
6			use MessageLocalizer;
7			use SiteLookup;
8			use Wikibase\DataModel\Services\Diff\EntityDiff;
9			use Wikibase\DataModel\Services\EntityId\EntityIdFormatter;
10			use Wikibase\Repo\Content\EntityContentDiff;
11
12			/**
13			* Class for generating views of EntityDiff objects.
14			*
15			* @license GPL-2.0-or-later
16			* @author Amir Sarabadani
17			*/
18			class ItemDiffVisualizer implements EntityDiffVisualizer {
19
20			/**
21			* @var MessageLocalizer
22			*/
23			private $messageLocalizer;
24
25			/**
26			* @var ClaimDiffer\|null
27			*/
28			private $claimDiffer;
29
30			/**
31			* @var ClaimDifferenceVisualizer\|null
32			*/
33			private $claimDiffVisualizer;
34
35			/**
36			* @var SiteLookup
37			*/
38			private $siteLookup;
39
40			/**
41			* @var EntityIdFormatter
42			*/
43			private $entityIdFormatter;
44
45			/**
46			* @var BasicEntityDiffVisualizer
47			*/
48			private $basicEntityDiffVisualizer;
49
50			public function __construct(
51			MessageLocalizer $messageLocalizer,
52			ClaimDiffer $claimDiffer,
53			ClaimDifferenceVisualizer $claimDiffView,
54			SiteLookup $siteLookup,
55			EntityIdFormatter $entityIdFormatter,
56			EntityDiffVisualizer $basicEntityDiffVisualizer
57			) {
58			$this->messageLocalizer = $messageLocalizer;
59			$this->claimDiffer = $claimDiffer;
60			$this->claimDiffVisualizer = $claimDiffView;
61			$this->siteLookup = $siteLookup;
62			$this->entityIdFormatter = $entityIdFormatter;
63			$this->basicEntityDiffVisualizer = $basicEntityDiffVisualizer;
			0 ignored issues – show Documentation Bug introduced 2017-11-01 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$basicEntityDiffVisualizer` is of type `object<Wikibase\Repo\Diff\EntityDiffVisualizer>`, but the property `$basicEntityDiffVisualizer` was declared to be of type `object<Wikibase\Repo\Dif...icEntityDiffVisualizer>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
64			}
65
66			/**
67			* Generates and returns an HTML visualization of the provided EntityContentDiff.
68			*
69			* @param EntityContentDiff $diff
70			*
71			* @return string
72			*/
73			public function visualizeEntityContentDiff( EntityContentDiff $diff ) {
74			if ( $diff->isEmpty() ) {
75			return '';
76			}
77
78			$basicHtml = $this->basicEntityDiffVisualizer->visualizeEntityContentDiff( $diff );
79
80			return $basicHtml . $this->visualizeEntityDiff( $diff->getEntityDiff() );
81			}
82
83			/**
84			* Generates and returns an HTML visualization of the provided EntityDiff.
85			*
86			* @param EntityDiff $diff
87			*
88			* @return string
89			*/
90			protected function visualizeEntityDiff( EntityDiff $diff ) {
91			return ( new ItemDiffView(
92			[],
93			new Diff(
94			[
95			// FIXME: getSiteLinkDiff only exists in ItemDiff
96			// @phan-suppress-next-line PhanUndeclaredMethod
97			$this->messageLocalizer->msg( 'wikibase-diffview-link' )->text() => $diff->getSiteLinkDiff(),
			0 ignored issues – show Bug introduced 2017-11-01 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Wikibase\DataModel\Services\Diff\EntityDiff` as the method `getSiteLinkDiff()` does only exist in the following sub-classes of `Wikibase\DataModel\Services\Diff\EntityDiff`: `Wikibase\DataModel\Services\Diff\ItemDiff`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
98			],
99			true
100			),
101			$this->siteLookup,
102			$this->entityIdFormatter,
103			$this->messageLocalizer
104			) )->getHtml();
105			}
106
107			}
108

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

repo/includes/Diff/ItemDiffVisualizer.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like