Issues in SingleEntitySourceServicesTest.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/phpunit/SingleEntitySourceServicesTest.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\DataAccess\Tests;

use DataValues\Deserializers\DataValueDeserializer;
use LogicException;
use MediaWiki\Storage\NameTableStore;
use PHPUnit\Framework\MockObject\MockObject;
use Wikibase\DataAccess\EntitySource;
use Wikibase\DataAccess\GenericServices;
use Wikibase\DataAccess\PrefetchingTermLookup;
use Wikibase\DataAccess\SingleEntitySourceServices;
use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Services\Entity\EntityPrefetcher;
use Wikibase\DataModel\Services\EntityId\EntityIdComposer;
use Wikibase\Lib\EntityTypeDefinitions;
use Wikibase\Lib\Interactors\TermSearchInteractorFactory;
use Wikibase\Lib\Store\EntityRevisionLookup;
use Wikibase\Lib\Store\PropertyInfoLookup;
use Wikibase\Lib\Store\Sql\Terms\TermInLangIdsResolver;
use Wikimedia\Assert\ParameterElementTypeException;

/**
 * @covers \Wikibase\DataAccess\SingleEntitySourceServices
 *
 * @group Wikibase
 *
 * @license GPL-2.0-or-later
 */
class SingleEntitySourceServicesTest extends \PHPUnit\Framework\TestCase {

	public function testValidConstruction() {
		$this->newSingleEntitySourceServices();
		$this->assertTrue( true );
	}

	public function provideSimpleServiceGetters() {
		return [
			[ 'getEntityRevisionLookup', EntityRevisionLookup::class, true ],
			[ 'getTermSearchInteractorFactory', TermSearchInteractorFactory::class, true ],
			[ 'getPrefetchingTermLookup', PrefetchingTermLookup::class, true ],
			[ 'getEntityPrefetcher', EntityPrefetcher::class, true ],
			[ 'getPropertyInfoLookup', PropertyInfoLookup::class, true ],
			[ 'getEntitySource', EntitySource::class, true ],
			[ 'getTermInLangIdsResolver', TermInLangIdsResolver::class, false ],
		];
	}

	/**
	 * @dataProvider provideSimpleServiceGetters
	 */
	public function testSimpleServiceGetters( $function, $expected, $expectSame ) {
		$services = $this->newSingleEntitySourceServices();

		$serviceOne = $services->$function();
		$serviceTwo = $services->$function();

		$this->assertInstanceOf( $expected, $serviceOne );

		if ( $expectSame ) {
			$this->assertSame( $serviceOne, $serviceTwo );
		} else {
			$this->assertNotSame( $serviceOne, $serviceTwo );
		}
	}

	public function testGivenEntitySourceDoesNotProvideProperties_getPropertyInfoLookupThrowsException() {
		$services = new SingleEntitySourceServices(
			$this->newGenericServices(),
			new BasicEntityIdParser(),
			new EntityIdComposer( [] ),
			new DataValueDeserializer( [] ),
			$this->getMockNameTableStore(),
			DataAccessSettingsFactory::anySettings(),
			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
			[ 'strval' ],
			[],
			[],
			[]
		);

		$this->expectException( LogicException::class );
		$services->getPropertyInfoLookup();
	}

	public function testInvalidConstruction_deserializeFactoryCallbacks() {
		$this->expectException( ParameterElementTypeException::class );
		new SingleEntitySourceServices(
			$this->newGenericServices(),
			new BasicEntityIdParser(),
			new EntityIdComposer( [] ),
			new DataValueDeserializer( [] ),
			$this->getMockNameTableStore(),
			DataAccessSettingsFactory::anySettings(),
			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
			[ null ],
			[],
			[],
			[]
		);
	}

	public function testInvalidConstruction_entityMetaDataAccessorCallbacks() {
		$this->expectException( ParameterElementTypeException::class );
		new SingleEntitySourceServices(
			$this->newGenericServices(),
			new BasicEntityIdParser(),
			new EntityIdComposer( [] ),
			new DataValueDeserializer( [] ),
			$this->getMockNameTableStore(),
			DataAccessSettingsFactory::anySettings(),
			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
			[],
			[ null ],
			[],
			[]
		);
	}

	public function testInvalidConstruction_prefetchingTermLookupCallbacks() {
		$this->expectException( ParameterElementTypeException::class );
		new SingleEntitySourceServices(
			$this->newGenericServices(),
			new BasicEntityIdParser(),
			new EntityIdComposer( [] ),
			new DataValueDeserializer( [] ),
			$this->getMockNameTableStore(),
			DataAccessSettingsFactory::anySettings(),
			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
			[],
			[],
			[ null ],
			[]
		);
	}

	public function testGivenCustomLookupConstructingCallbacks_getPrefetchingTermLookupReturnsCustomLookup() {
		$customLookup = $this->createMock( PrefetchingTermLookup::class );
		$customLookup->method( $this->anything() )
			->willReturn( 'CUSTOM' );

		$customItemLookupCallback = function() use ( $customLookup ) {
			return $customLookup;
		};

		$services = new SingleEntitySourceServices(
			$this->newGenericServices(),
			new BasicEntityIdParser(),
			new EntityIdComposer( [] ),
			new DataValueDeserializer( [] ),
			$this->getMockNameTableStore(),
			DataAccessSettingsFactory::anySettings(),
			new EntitySource(
				'source',
				'sourcedb',
				[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ], 'property' => [ 'namespaceId' => 200, 'slot' => 'main' ] ],
				'',
				'',
				'',
				''
			),
			[],
			[],
			[ 'item' => $customItemLookupCallback ],
			[]
		);

		$lookup = $services->getPrefetchingTermLookup();

		$this->assertSame( 'CUSTOM', $lookup->getLabel( new ItemId( 'Q123' ), 'fake' ) );
	}

	public function newSingleEntitySourceServices() {
		return new SingleEntitySourceServices(
			$this->newGenericServices(),
			new BasicEntityIdParser(),
			new EntityIdComposer( [] ),
			new DataValueDeserializer( [] ),
			$this->getMockNameTableStore(),
			DataAccessSettingsFactory::anySettings(),
			new EntitySource( 'source', 'sourcedb', [ 'property' => [ 'namespaceId' => 200, 'slot' => 'main' ] ], '', '', '', '' ),
			[],
			[],
			[],
			[]
		);
	}

	public function newGenericServices() {
		return new GenericServices(
			new EntityTypeDefinitions( [] ),
			[],

			[]
		);
	}

	/**
	 * @return MockObject|NameTableStore
	 */
	private function getMockNameTableStore() {
		$m = $this->getMockBuilder( NameTableStore::class );
		return $m->disableOriginalConstructor()->getMock();
	}

	// TODO test entityUpdated
	// TODO test redirectUpdated
	// TODO test entityDeleted

}


1			<?php
2
3			namespace Wikibase\DataAccess\Tests;
4
5			use DataValues\Deserializers\DataValueDeserializer;
6			use LogicException;
7			use MediaWiki\Storage\NameTableStore;
8			use PHPUnit\Framework\MockObject\MockObject;
9			use Wikibase\DataAccess\EntitySource;
10			use Wikibase\DataAccess\GenericServices;
11			use Wikibase\DataAccess\PrefetchingTermLookup;
12			use Wikibase\DataAccess\SingleEntitySourceServices;
13			use Wikibase\DataModel\Entity\BasicEntityIdParser;
14			use Wikibase\DataModel\Entity\ItemId;
15			use Wikibase\DataModel\Services\Entity\EntityPrefetcher;
16			use Wikibase\DataModel\Services\EntityId\EntityIdComposer;
17			use Wikibase\Lib\EntityTypeDefinitions;
18			use Wikibase\Lib\Interactors\TermSearchInteractorFactory;
19			use Wikibase\Lib\Store\EntityRevisionLookup;
20			use Wikibase\Lib\Store\PropertyInfoLookup;
21			use Wikibase\Lib\Store\Sql\Terms\TermInLangIdsResolver;
22			use Wikimedia\Assert\ParameterElementTypeException;
23
24			/**
25			* @covers \Wikibase\DataAccess\SingleEntitySourceServices
26			*
27			* @group Wikibase
28			*
29			* @license GPL-2.0-or-later
30			*/
31			class SingleEntitySourceServicesTest extends \PHPUnit\Framework\TestCase {
32
33			public function testValidConstruction() {
34			$this->newSingleEntitySourceServices();
35			$this->assertTrue( true );
36			}
37
38			public function provideSimpleServiceGetters() {
39			return [
40			[ 'getEntityRevisionLookup', EntityRevisionLookup::class, true ],
41			[ 'getTermSearchInteractorFactory', TermSearchInteractorFactory::class, true ],
42			[ 'getPrefetchingTermLookup', PrefetchingTermLookup::class, true ],
43			[ 'getEntityPrefetcher', EntityPrefetcher::class, true ],
44			[ 'getPropertyInfoLookup', PropertyInfoLookup::class, true ],
45			[ 'getEntitySource', EntitySource::class, true ],
46			[ 'getTermInLangIdsResolver', TermInLangIdsResolver::class, false ],
47			];
48			}
49
50			/**
51			* @dataProvider provideSimpleServiceGetters
52			*/
53			public function testSimpleServiceGetters( $function, $expected, $expectSame ) {
54			$services = $this->newSingleEntitySourceServices();
55
56			$serviceOne = $services->$function();
57			$serviceTwo = $services->$function();
58
59			$this->assertInstanceOf( $expected, $serviceOne );
60
61			if ( $expectSame ) {
62			$this->assertSame( $serviceOne, $serviceTwo );
63			} else {
64			$this->assertNotSame( $serviceOne, $serviceTwo );
65			}
66			}
67
68			public function testGivenEntitySourceDoesNotProvideProperties_getPropertyInfoLookupThrowsException() {
69			$services = new SingleEntitySourceServices(
70			$this->newGenericServices(),
71			new BasicEntityIdParser(),
72			new EntityIdComposer( [] ),
73			new DataValueDeserializer( [] ),
74			$this->getMockNameTableStore(),
75			DataAccessSettingsFactory::anySettings(),
76			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
77			[ 'strval' ],
78			[],
79			[],
80			[]
81			);
82
83			$this->expectException( LogicException::class );
84			$services->getPropertyInfoLookup();
85			}
86
87			public function testInvalidConstruction_deserializeFactoryCallbacks() {
88			$this->expectException( ParameterElementTypeException::class );
89			new SingleEntitySourceServices(
90			$this->newGenericServices(),
91			new BasicEntityIdParser(),
92			new EntityIdComposer( [] ),
93			new DataValueDeserializer( [] ),
94			$this->getMockNameTableStore(),
95			DataAccessSettingsFactory::anySettings(),
96			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
97			[ null ],
98			[],
99			[],
100			[]
101			);
102			}
103
104			public function testInvalidConstruction_entityMetaDataAccessorCallbacks() {
105			$this->expectException( ParameterElementTypeException::class );
106			new SingleEntitySourceServices(
107			$this->newGenericServices(),
108			new BasicEntityIdParser(),
109			new EntityIdComposer( [] ),
110			new DataValueDeserializer( [] ),
111			$this->getMockNameTableStore(),
112			DataAccessSettingsFactory::anySettings(),
113			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
114			[],
115			[ null ],
116			[],
117			[]
118			);
119			}
120
121			public function testInvalidConstruction_prefetchingTermLookupCallbacks() {
122			$this->expectException( ParameterElementTypeException::class );
123			new SingleEntitySourceServices(
124			$this->newGenericServices(),
125			new BasicEntityIdParser(),
126			new EntityIdComposer( [] ),
127			new DataValueDeserializer( [] ),
128			$this->getMockNameTableStore(),
129			DataAccessSettingsFactory::anySettings(),
130			new EntitySource( 'source', 'sourcedb', [], '', '', '', '' ),
131			[],
132			[],
133			[ null ],
134			[]
135			);
136			}
137
138			public function testGivenCustomLookupConstructingCallbacks_getPrefetchingTermLookupReturnsCustomLookup() {
139			$customLookup = $this->createMock( PrefetchingTermLookup::class );
140			$customLookup->method( $this->anything() )
141			->willReturn( 'CUSTOM' );
142
143			$customItemLookupCallback = function() use ( $customLookup ) {
144			return $customLookup;
145			};
146
147			$services = new SingleEntitySourceServices(
148			$this->newGenericServices(),
149			new BasicEntityIdParser(),
150			new EntityIdComposer( [] ),
151			new DataValueDeserializer( [] ),
152			$this->getMockNameTableStore(),
153			DataAccessSettingsFactory::anySettings(),
154			new EntitySource(
155			'source',
156			'sourcedb',
157			[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ], 'property' => [ 'namespaceId' => 200, 'slot' => 'main' ] ],
158			'',
159			'',
160			'',
161			''
162			),
163			[],
164			[],
165			[ 'item' => $customItemLookupCallback ],
166			[]
167			);
168
169			$lookup = $services->getPrefetchingTermLookup();
170
171			$this->assertSame( 'CUSTOM', $lookup->getLabel( new ItemId( 'Q123' ), 'fake' ) );
172			}
173
174			public function newSingleEntitySourceServices() {
175			return new SingleEntitySourceServices(
176			$this->newGenericServices(),
177			new BasicEntityIdParser(),
178			new EntityIdComposer( [] ),
179			new DataValueDeserializer( [] ),
180			$this->getMockNameTableStore(),
181			DataAccessSettingsFactory::anySettings(),
182			new EntitySource( 'source', 'sourcedb', [ 'property' => [ 'namespaceId' => 200, 'slot' => 'main' ] ], '', '', '', '' ),
183			[],
184			[],
185			[],
186			[]
187			);
188			}
189
190			public function newGenericServices() {
191			return new GenericServices(
192			new EntityTypeDefinitions( [] ),
193			[],
			0 ignored issues – show Unused Code introduced 2020-08-18 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `GenericServices::__construct()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
194			[]
195			);
196			}
197
198			/**
199			* @return MockObject\|NameTableStore
200			*/
201			private function getMockNameTableStore() {
202			$m = $this->getMockBuilder( NameTableStore::class );
203			return $m->disableOriginalConstructor()->getMock();
204			}
205
206			// TODO test entityUpdated
207			// TODO test redirectUpdated
208			// TODO test entityDeleted
209
210			}
211

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

tests/phpunit/SingleEntitySourceServicesTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like