Issues in MultipleEntitySourceServicesTest.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/phpunit/MultipleEntitySourceServicesTest.php (5 issues)

Labels

Unused Code 5

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\DataAccess\Tests;

use LogicException;
use PHPUnit\Framework\TestCase;
use Wikibase\DataAccess\EntitySource;
use Wikibase\DataAccess\EntitySourceDefinitions;
use Wikibase\DataAccess\GenericServices;
use Wikibase\DataAccess\MultipleEntitySourceServices;
use Wikibase\DataAccess\SingleEntitySourceServices;
use Wikibase\DataModel\Entity\EntityRedirect;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Term\Term;
use Wikibase\Lib\EntityTypeDefinitions;
use Wikibase\Lib\Interactors\TermSearchInteractor;
use Wikibase\Lib\Interactors\TermSearchInteractorFactory;
use Wikibase\Lib\Interactors\TermSearchResult;
use Wikibase\Lib\Store\EntityRevision;
use Wikibase\Lib\Store\EntityRevisionLookup;
use Wikibase\Lib\Store\PropertyInfoLookup;
use Wikibase\Lib\TermIndexEntry;
use Wikibase\Lib\Tests\Store\MockPropertyInfoLookup;

/**
 * @covers \Wikibase\DataAccess\MultipleEntitySourceServices
 *
 * @group Wikibase
 *
 * @license GPL-2.0-or-later
 */
class MultipleEntitySourceServicesTest extends TestCase {

	public function testGetEntityRevisionLookupReturnsLookupThatReturnsExpectedRevisionData() {
		$itemRevisionData = 'item revision data';
		$itemRevisionLookup = $this->createMock( EntityRevisionLookup::class );
		$itemRevisionLookup->method( 'getEntityRevision' )
			->willReturn( $itemRevisionData );

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getEntityRevisionLookup' )
			->willReturn( $itemRevisionLookup );

		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->method( 'getEntityRevisionLookup' )
			->willReturn( $this->newThrowingEntityRevisionLookup() );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$lookup = $services->getEntityRevisionLookup();

		$this->assertSame( $itemRevisionData, $lookup->getEntityRevision( new ItemId( 'Q123' ) ) );
	}

	private function newThrowingEntityRevisionLookup() {
		$propertyRevisionLookup = $this->createMock( EntityRevisionLookup::class );
		$propertyRevisionLookup->method( $this->anything() )
			->willThrowException( new LogicException( 'This service should not be used' ) );
		return $propertyRevisionLookup;
	}

	public function testGetTermSearchInteractorFactoryGeneratesInteractorsReturningResultsForConfiguredSources() {
		$itemResult = new TermSearchResult( new Term( 'en', 'test' ), TermIndexEntry::TYPE_LABEL, new ItemId( 'Q123' ) );

		$itemInteractor = $this->createMock( TermSearchInteractor::class );
		$itemInteractor->method( 'searchForEntities' )
			->willReturn( $itemResult );

		$itemInteractorFactory = $this->createMock( TermSearchInteractorFactory::class );
		$itemInteractorFactory->method( 'newInteractor' )
			->willReturn( $itemInteractor );

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getTermSearchInteractorFactory' )
			->willReturn( $itemInteractorFactory );

		$dummyInteractorFactory = $this->createMock( TermSearchInteractorFactory::class );
		$dummyInteractorFactory->method( 'newInteractor' )
			->willReturn( $this->createMock( TermSearchInteractor::class ) );

		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->method( 'getTermSearchInteractorFactory' )
			->willReturn( $dummyInteractorFactory );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$interactor = $services->getTermSearchInteractorFactory()->newInteractor( 'en' );

		$searchResult = $interactor->searchForEntities( 'test', 'en', 'item', [ TermIndexEntry::TYPE_LABEL ] );

		$this->assertEquals( $itemResult, $searchResult );
	}

	public function testGetPrefetchingTermLookupReturnsLookupBufferingDataOfSourceEntities() {
		$itemId = new ItemId( 'Q200' );
		$propertyId = new PropertyId( 'P500' );
		$fakeItemLabel = 'Q200 en label';
		$fakePropertyLabel = 'P500 en label';

		$itemLookup = new FakePrefetchingTermLookup();

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getPrefetchingTermLookup' )
			->willReturn( $itemLookup );

		$propertyLookup = new FakePrefetchingTermLookup();

		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->method( 'getPrefetchingTermLookup' )
			->willReturn( $propertyLookup );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$lookup = $services->getPrefetchingTermLookup();
		$lookup->prefetchTerms( [ $itemId, $propertyId ], [ 'label' ], [ 'en' ] );

		$this->assertEquals( $fakeItemLabel, $lookup->getPrefetchedTerm( $itemId, 'label', 'en' ) );
		$this->assertEquals( $fakePropertyLabel, $lookup->getPrefetchedTerm( $propertyId, 'label', 'en' ) );
	}

	public function testGetPrefetchingTermLookupReturnsLookupReturningTermsOfEntitiesConfiguredInSources() {
		$itemId = new ItemId( 'Q200' );
		$fakeItemLabel = 'Q200 en label';

		$itemLookup = new FakePrefetchingTermLookup();

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getPrefetchingTermLookup' )
			->willReturn( $itemLookup );

		$entityTypeDefinitions = new EntityTypeDefinitions( [] );

		$services = new MultipleEntitySourceServices(
			new EntitySourceDefinitions( [
				new EntitySource(
					'items',
					'itemdb',
					[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
					'',
					'',
					'',
					''
				)
			], $entityTypeDefinitions ),
			new GenericServices( $entityTypeDefinitions, [], [] ),

			[ 'items' => $itemServices ]
		);

		$lookup = $services->getPrefetchingTermLookup();

		$this->assertEquals( $fakeItemLabel, $lookup->getLabel( $itemId, 'en' ) );
	}

	public function testGetPrefetchingTermLookupReturnsLookupReturningNullWhenGivenEntitiesUnknownInSources() {
		$itemLookup = new FakePrefetchingTermLookup();

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getPrefetchingTermLookup' )
			->willReturn( $itemLookup );

		$entityTypeDefinitions = new EntityTypeDefinitions( [] );

		$services = new MultipleEntitySourceServices(
			new EntitySourceDefinitions( [
				new EntitySource(
					'items',
					'itemdb',
					[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
					'',
					'',
					'',
					''
				)
			], $entityTypeDefinitions ),
			new GenericServices( $entityTypeDefinitions, [], [] ),

			[ 'items' => $itemServices ]
		);

		$lookup = $services->getPrefetchingTermLookup();

		$this->assertNull( $lookup->getLabel( new PropertyId( 'P123' ), 'en' ) );
	}

	public function testGetEntityPrefetcherReturnsServiceBufferingDataOfSourceEntities() {
		$itemId = new ItemId( 'Q200' );
		$propertyId = new PropertyId( 'P500' );

		$itemPrefetcher = new EntityPrefetcherSpy();

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getEntityPrefetcher' )
			->willReturn( $itemPrefetcher );

		$propertyPrefetcher = new EntityPrefetcherSpy();

		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->method( 'getEntityPrefetcher' )
			->willReturn( $propertyPrefetcher );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$prefetcher = $services->getEntityPrefetcher();
		$prefetcher->prefetch( [ $itemId, $propertyId ] );

		$this->assertEquals(
			[ $itemId, $propertyId ],
			array_merge( $itemPrefetcher->getPrefetchedEntities(), $propertyPrefetcher->getPrefetchedEntities() )
		);
	}

	public function testGetEntityPrefetcherReturnsServiceThatDoesNotPrefetchEntitiesNotConfiguredInSources() {
		$itemId = new ItemId( 'Q200' );
		$propertyId = new PropertyId( 'P500' );

		$itemPrefetcher = new EntityPrefetcherSpy();

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->method( 'getEntityPrefetcher' )
			->willReturn( $itemPrefetcher );

		$entityTypeDefinitions = new EntityTypeDefinitions( [] );

		$services = new MultipleEntitySourceServices(
			new EntitySourceDefinitions( [
				new EntitySource(
					'items',
					'itemdb',
					[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
					'',
					'',
					'',
					''
				)
			], $entityTypeDefinitions ),
			new GenericServices( $entityTypeDefinitions, [], [] ),

			[ 'items' => $itemServices ]
		);

		$prefetcher = $services->getEntityPrefetcher();
		$prefetcher->prefetch( [ $itemId, $propertyId ] );

		$this->assertNotContains( [ $propertyId ], $itemPrefetcher->getPrefetchedEntities() );
	}

	public function testGetPropertyInfoLookupReturnsPropertyDataAccessingService() {
		$propertyId = new PropertyId( 'P6' );

		$propertyLookup = new MockPropertyInfoLookup();
		$propertyLookup->addPropertyInfo( $propertyId, [ PropertyInfoLookup::KEY_DATA_TYPE => 'string' ] );

		$sourceServices = $this->createMock( SingleEntitySourceServices::class );
		$sourceServices->method( 'getPropertyInfoLookup' )
			->willReturn( $propertyLookup );

		$services = $this->newMultipleEntitySourceServices( [ 'props' => $sourceServices ] );

		$lookup = $services->getPropertyInfoLookup();

		$this->assertEquals( [ 'type' => 'string' ], $lookup->getPropertyInfo( $propertyId ) );
	}

	public function testGivenNoSourceProvidingProperties_getPropertyInfoLookupThrowsException() {
		$entityTypeDefinitions = new EntityTypeDefinitions( [] );
		$services = new MultipleEntitySourceServices(
			new EntitySourceDefinitions( [
				new EntitySource(
					'items',
					'itemdb',
					[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
					'',
					'',
					'',
					''
				),
			], $entityTypeDefinitions ),
			new GenericServices( $entityTypeDefinitions, [], [] ),

			[]
		);

		$this->expectException( LogicException::class );
		$services->getPropertyInfoLookup();
	}

	public function testEntityFromKnownSourceUpdated_entityUpdatedPassedToRelevantServiceContainer() {
		$itemRevision = new EntityRevision( new Item( new ItemId( 'Q1' ) ) );

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->expects( $this->atLeastOnce() )
			->method( 'entityUpdated' )
			->with( $itemRevision );
		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->expects( $this->never() )
			->method( 'entityUpdated' );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$services->entityUpdated( $itemRevision );
	}

	public function testEntityFromKnownSourceDeleted_entityDeletedPassedToRelevantServiceContainer() {
		$itemId = new ItemId( 'Q1' );

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->expects( $this->atLeastOnce() )
			->method( 'entityDeleted' )
			->with( $itemId );
		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->expects( $this->never() )
			->method( 'entityDeleted' );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$services->entityDeleted( $itemId );
	}

	public function testRedirectOfEntityFromKnownSourceDeleted_redirectUpdatedPassedToRelevantServiceContainer() {
		$itemRedirect = new EntityRedirect( new ItemId( 'Q1' ), new ItemId( 'Q300' ) );
		$revisionId = 333;

		$itemServices = $this->createMock( SingleEntitySourceServices::class );
		$itemServices->expects( $this->atLeastOnce() )
			->method( 'redirectUpdated' )
			->with( $itemRedirect, $revisionId );
		$propertyServices = $this->createMock( SingleEntitySourceServices::class );
		$propertyServices->expects( $this->never() )
			->method( 'redirectUpdated' );

		$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );

		$services->redirectUpdated( $itemRedirect, $revisionId );
	}

	/**
	 * @param SingleEntitySourceServices[] $perSourceServices
	 * @return MultipleEntitySourceServices
	 */
	private function newMultipleEntitySourceServices( array $perSourceServices ) {
		$entityTypeDefinitions = new EntityTypeDefinitions( [] );
		return new MultipleEntitySourceServices(
			new EntitySourceDefinitions( [
				new EntitySource(
					'items',
					'itemdb',
					[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
					'',
					'',
					'',
					''
				),
				new EntitySource(
					'props',
					'propb',
					[ 'property' => [ 'namespaceId' => 200, 'slot' => 'main' ] ],
					'',
					'prop',
					'prop',
					'props'
				),
			], $entityTypeDefinitions ),
			new GenericServices( $entityTypeDefinitions, [], [] ),

			$perSourceServices
		);
	}

}


1			<?php
2
3			namespace Wikibase\DataAccess\Tests;
4
5			use LogicException;
6			use PHPUnit\Framework\TestCase;
7			use Wikibase\DataAccess\EntitySource;
8			use Wikibase\DataAccess\EntitySourceDefinitions;
9			use Wikibase\DataAccess\GenericServices;
10			use Wikibase\DataAccess\MultipleEntitySourceServices;
11			use Wikibase\DataAccess\SingleEntitySourceServices;
12			use Wikibase\DataModel\Entity\EntityRedirect;
13			use Wikibase\DataModel\Entity\Item;
14			use Wikibase\DataModel\Entity\ItemId;
15			use Wikibase\DataModel\Entity\PropertyId;
16			use Wikibase\DataModel\Term\Term;
17			use Wikibase\Lib\EntityTypeDefinitions;
18			use Wikibase\Lib\Interactors\TermSearchInteractor;
19			use Wikibase\Lib\Interactors\TermSearchInteractorFactory;
20			use Wikibase\Lib\Interactors\TermSearchResult;
21			use Wikibase\Lib\Store\EntityRevision;
22			use Wikibase\Lib\Store\EntityRevisionLookup;
23			use Wikibase\Lib\Store\PropertyInfoLookup;
24			use Wikibase\Lib\TermIndexEntry;
25			use Wikibase\Lib\Tests\Store\MockPropertyInfoLookup;
26
27			/**
28			* @covers \Wikibase\DataAccess\MultipleEntitySourceServices
29			*
30			* @group Wikibase
31			*
32			* @license GPL-2.0-or-later
33			*/
34			class MultipleEntitySourceServicesTest extends TestCase {
35
36			public function testGetEntityRevisionLookupReturnsLookupThatReturnsExpectedRevisionData() {
37			$itemRevisionData = 'item revision data';
38			$itemRevisionLookup = $this->createMock( EntityRevisionLookup::class );
39			$itemRevisionLookup->method( 'getEntityRevision' )
40			->willReturn( $itemRevisionData );
41
42			$itemServices = $this->createMock( SingleEntitySourceServices::class );
43			$itemServices->method( 'getEntityRevisionLookup' )
44			->willReturn( $itemRevisionLookup );
45
46			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
47			$propertyServices->method( 'getEntityRevisionLookup' )
48			->willReturn( $this->newThrowingEntityRevisionLookup() );
49
50			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
51
52			$lookup = $services->getEntityRevisionLookup();
53
54			$this->assertSame( $itemRevisionData, $lookup->getEntityRevision( new ItemId( 'Q123' ) ) );
55			}
56
57			private function newThrowingEntityRevisionLookup() {
58			$propertyRevisionLookup = $this->createMock( EntityRevisionLookup::class );
59			$propertyRevisionLookup->method( $this->anything() )
60			->willThrowException( new LogicException( 'This service should not be used' ) );
61			return $propertyRevisionLookup;
62			}
63
64			public function testGetTermSearchInteractorFactoryGeneratesInteractorsReturningResultsForConfiguredSources() {
65			$itemResult = new TermSearchResult( new Term( 'en', 'test' ), TermIndexEntry::TYPE_LABEL, new ItemId( 'Q123' ) );
66
67			$itemInteractor = $this->createMock( TermSearchInteractor::class );
68			$itemInteractor->method( 'searchForEntities' )
69			->willReturn( $itemResult );
70
71			$itemInteractorFactory = $this->createMock( TermSearchInteractorFactory::class );
72			$itemInteractorFactory->method( 'newInteractor' )
73			->willReturn( $itemInteractor );
74
75			$itemServices = $this->createMock( SingleEntitySourceServices::class );
76			$itemServices->method( 'getTermSearchInteractorFactory' )
77			->willReturn( $itemInteractorFactory );
78
79			$dummyInteractorFactory = $this->createMock( TermSearchInteractorFactory::class );
80			$dummyInteractorFactory->method( 'newInteractor' )
81			->willReturn( $this->createMock( TermSearchInteractor::class ) );
82
83			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
84			$propertyServices->method( 'getTermSearchInteractorFactory' )
85			->willReturn( $dummyInteractorFactory );
86
87			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
88
89			$interactor = $services->getTermSearchInteractorFactory()->newInteractor( 'en' );
90
91			$searchResult = $interactor->searchForEntities( 'test', 'en', 'item', [ TermIndexEntry::TYPE_LABEL ] );
92
93			$this->assertEquals( $itemResult, $searchResult );
94			}
95
96			public function testGetPrefetchingTermLookupReturnsLookupBufferingDataOfSourceEntities() {
97			$itemId = new ItemId( 'Q200' );
98			$propertyId = new PropertyId( 'P500' );
99			$fakeItemLabel = 'Q200 en label';
100			$fakePropertyLabel = 'P500 en label';
101
102			$itemLookup = new FakePrefetchingTermLookup();
103
104			$itemServices = $this->createMock( SingleEntitySourceServices::class );
105			$itemServices->method( 'getPrefetchingTermLookup' )
106			->willReturn( $itemLookup );
107
108			$propertyLookup = new FakePrefetchingTermLookup();
109
110			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
111			$propertyServices->method( 'getPrefetchingTermLookup' )
112			->willReturn( $propertyLookup );
113
114			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
115
116			$lookup = $services->getPrefetchingTermLookup();
117			$lookup->prefetchTerms( [ $itemId, $propertyId ], [ 'label' ], [ 'en' ] );
118
119			$this->assertEquals( $fakeItemLabel, $lookup->getPrefetchedTerm( $itemId, 'label', 'en' ) );
120			$this->assertEquals( $fakePropertyLabel, $lookup->getPrefetchedTerm( $propertyId, 'label', 'en' ) );
121			}
122
123			public function testGetPrefetchingTermLookupReturnsLookupReturningTermsOfEntitiesConfiguredInSources() {
124			$itemId = new ItemId( 'Q200' );
125			$fakeItemLabel = 'Q200 en label';
126
127			$itemLookup = new FakePrefetchingTermLookup();
128
129			$itemServices = $this->createMock( SingleEntitySourceServices::class );
130			$itemServices->method( 'getPrefetchingTermLookup' )
131			->willReturn( $itemLookup );
132
133			$entityTypeDefinitions = new EntityTypeDefinitions( [] );
134
135			$services = new MultipleEntitySourceServices(
136			new EntitySourceDefinitions( [
137			new EntitySource(
138			'items',
139			'itemdb',
140			[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
141			'',
142			'',
143			'',
144			''
145			)
146			], $entityTypeDefinitions ),
147			new GenericServices( $entityTypeDefinitions, [], [] ),
			0 ignored issues – show Unused Code introduced 2020-08-18 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `GenericServices::__construct()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
148			[ 'items' => $itemServices ]
149			);
150
151			$lookup = $services->getPrefetchingTermLookup();
152
153			$this->assertEquals( $fakeItemLabel, $lookup->getLabel( $itemId, 'en' ) );
154			}
155
156			public function testGetPrefetchingTermLookupReturnsLookupReturningNullWhenGivenEntitiesUnknownInSources() {
157			$itemLookup = new FakePrefetchingTermLookup();
158
159			$itemServices = $this->createMock( SingleEntitySourceServices::class );
160			$itemServices->method( 'getPrefetchingTermLookup' )
161			->willReturn( $itemLookup );
162
163			$entityTypeDefinitions = new EntityTypeDefinitions( [] );
164
165			$services = new MultipleEntitySourceServices(
166			new EntitySourceDefinitions( [
167			new EntitySource(
168			'items',
169			'itemdb',
170			[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
171			'',
172			'',
173			'',
174			''
175			)
176			], $entityTypeDefinitions ),
177			new GenericServices( $entityTypeDefinitions, [], [] ),
			0 ignored issues – show Unused Code introduced 2020-08-18 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `GenericServices::__construct()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
178			[ 'items' => $itemServices ]
179			);
180
181			$lookup = $services->getPrefetchingTermLookup();
182
183			$this->assertNull( $lookup->getLabel( new PropertyId( 'P123' ), 'en' ) );
184			}
185
186			public function testGetEntityPrefetcherReturnsServiceBufferingDataOfSourceEntities() {
187			$itemId = new ItemId( 'Q200' );
188			$propertyId = new PropertyId( 'P500' );
189
190			$itemPrefetcher = new EntityPrefetcherSpy();
191
192			$itemServices = $this->createMock( SingleEntitySourceServices::class );
193			$itemServices->method( 'getEntityPrefetcher' )
194			->willReturn( $itemPrefetcher );
195
196			$propertyPrefetcher = new EntityPrefetcherSpy();
197
198			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
199			$propertyServices->method( 'getEntityPrefetcher' )
200			->willReturn( $propertyPrefetcher );
201
202			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
203
204			$prefetcher = $services->getEntityPrefetcher();
205			$prefetcher->prefetch( [ $itemId, $propertyId ] );
206
207			$this->assertEquals(
208			[ $itemId, $propertyId ],
209			array_merge( $itemPrefetcher->getPrefetchedEntities(), $propertyPrefetcher->getPrefetchedEntities() )
210			);
211			}
212
213			public function testGetEntityPrefetcherReturnsServiceThatDoesNotPrefetchEntitiesNotConfiguredInSources() {
214			$itemId = new ItemId( 'Q200' );
215			$propertyId = new PropertyId( 'P500' );
216
217			$itemPrefetcher = new EntityPrefetcherSpy();
218
219			$itemServices = $this->createMock( SingleEntitySourceServices::class );
220			$itemServices->method( 'getEntityPrefetcher' )
221			->willReturn( $itemPrefetcher );
222
223			$entityTypeDefinitions = new EntityTypeDefinitions( [] );
224
225			$services = new MultipleEntitySourceServices(
226			new EntitySourceDefinitions( [
227			new EntitySource(
228			'items',
229			'itemdb',
230			[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
231			'',
232			'',
233			'',
234			''
235			)
236			], $entityTypeDefinitions ),
237			new GenericServices( $entityTypeDefinitions, [], [] ),
			0 ignored issues – show Unused Code introduced 2020-08-18 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `GenericServices::__construct()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
238			[ 'items' => $itemServices ]
239			);
240
241			$prefetcher = $services->getEntityPrefetcher();
242			$prefetcher->prefetch( [ $itemId, $propertyId ] );
243
244			$this->assertNotContains( [ $propertyId ], $itemPrefetcher->getPrefetchedEntities() );
245			}
246
247			public function testGetPropertyInfoLookupReturnsPropertyDataAccessingService() {
248			$propertyId = new PropertyId( 'P6' );
249
250			$propertyLookup = new MockPropertyInfoLookup();
251			$propertyLookup->addPropertyInfo( $propertyId, [ PropertyInfoLookup::KEY_DATA_TYPE => 'string' ] );
252
253			$sourceServices = $this->createMock( SingleEntitySourceServices::class );
254			$sourceServices->method( 'getPropertyInfoLookup' )
255			->willReturn( $propertyLookup );
256
257			$services = $this->newMultipleEntitySourceServices( [ 'props' => $sourceServices ] );
258
259			$lookup = $services->getPropertyInfoLookup();
260
261			$this->assertEquals( [ 'type' => 'string' ], $lookup->getPropertyInfo( $propertyId ) );
262			}
263
264			public function testGivenNoSourceProvidingProperties_getPropertyInfoLookupThrowsException() {
265			$entityTypeDefinitions = new EntityTypeDefinitions( [] );
266			$services = new MultipleEntitySourceServices(
267			new EntitySourceDefinitions( [
268			new EntitySource(
269			'items',
270			'itemdb',
271			[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
272			'',
273			'',
274			'',
275			''
276			),
277			], $entityTypeDefinitions ),
278			new GenericServices( $entityTypeDefinitions, [], [] ),
			0 ignored issues – show Unused Code introduced 2020-08-18 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `GenericServices::__construct()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
279			[]
280			);
281
282			$this->expectException( LogicException::class );
283			$services->getPropertyInfoLookup();
284			}
285
286			public function testEntityFromKnownSourceUpdated_entityUpdatedPassedToRelevantServiceContainer() {
287			$itemRevision = new EntityRevision( new Item( new ItemId( 'Q1' ) ) );
288
289			$itemServices = $this->createMock( SingleEntitySourceServices::class );
290			$itemServices->expects( $this->atLeastOnce() )
291			->method( 'entityUpdated' )
292			->with( $itemRevision );
293			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
294			$propertyServices->expects( $this->never() )
295			->method( 'entityUpdated' );
296
297			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
298
299			$services->entityUpdated( $itemRevision );
300			}
301
302			public function testEntityFromKnownSourceDeleted_entityDeletedPassedToRelevantServiceContainer() {
303			$itemId = new ItemId( 'Q1' );
304
305			$itemServices = $this->createMock( SingleEntitySourceServices::class );
306			$itemServices->expects( $this->atLeastOnce() )
307			->method( 'entityDeleted' )
308			->with( $itemId );
309			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
310			$propertyServices->expects( $this->never() )
311			->method( 'entityDeleted' );
312
313			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
314
315			$services->entityDeleted( $itemId );
316			}
317
318			public function testRedirectOfEntityFromKnownSourceDeleted_redirectUpdatedPassedToRelevantServiceContainer() {
319			$itemRedirect = new EntityRedirect( new ItemId( 'Q1' ), new ItemId( 'Q300' ) );
320			$revisionId = 333;
321
322			$itemServices = $this->createMock( SingleEntitySourceServices::class );
323			$itemServices->expects( $this->atLeastOnce() )
324			->method( 'redirectUpdated' )
325			->with( $itemRedirect, $revisionId );
326			$propertyServices = $this->createMock( SingleEntitySourceServices::class );
327			$propertyServices->expects( $this->never() )
328			->method( 'redirectUpdated' );
329
330			$services = $this->newMultipleEntitySourceServices( [ 'items' => $itemServices, 'props' => $propertyServices ] );
331
332			$services->redirectUpdated( $itemRedirect, $revisionId );
333			}
334
335			/**
336			* @param SingleEntitySourceServices[] $perSourceServices
337			* @return MultipleEntitySourceServices
338			*/
339			private function newMultipleEntitySourceServices( array $perSourceServices ) {
340			$entityTypeDefinitions = new EntityTypeDefinitions( [] );
341			return new MultipleEntitySourceServices(
342			new EntitySourceDefinitions( [
343			new EntitySource(
344			'items',
345			'itemdb',
346			[ 'item' => [ 'namespaceId' => 100, 'slot' => 'main' ] ],
347			'',
348			'',
349			'',
350			''
351			),
352			new EntitySource(
353			'props',
354			'propb',
355			[ 'property' => [ 'namespaceId' => 200, 'slot' => 'main' ] ],
356			'',
357			'prop',
358			'prop',
359			'props'
360			),
361			], $entityTypeDefinitions ),
362			new GenericServices( $entityTypeDefinitions, [], [] ),
			0 ignored issues – show Unused Code introduced 2020-08-18 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `GenericServices::__construct()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
363			$perSourceServices
364			);
365			}
366
367			}
368

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

tests/phpunit/MultipleEntitySourceServicesTest.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like