Issues in FakePrefetchingTermLookup.php (master) - Issues in master - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1401)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/phpunit/FakePrefetchingTermLookup.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\DataAccess\Tests;

use Wikibase\DataAccess\PrefetchingTermLookup;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Term\TermTypes;

/**
 * A PrefetchingTermLookup providing dummy TermLookup functionality, i.e. always returning a fake label/description,
 * and optional aliases, and also a Spy on TermBuffer
 * i.e. provides access to "prefetched" terms stored in the buffer after prefetchTerms method is called.
 *
 * @license GPL-2.0-or-later
 */
class FakePrefetchingTermLookup implements PrefetchingTermLookup {

	private $buffer;

	/**
	 * @param array $entityIds
	 * @param array|null $termTypes if null, defaults to labels and descriptions only
	 * @param array|null $languageCodes if null, defaults to de and en
	 */
	public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
		if ( $termTypes === null ) {
			$termTypes = [ TermTypes::TYPE_LABEL, TermTypes::TYPE_DESCRIPTION ];
		}
		if ( $languageCodes === null ) {
			$languageCodes = [ 'de', 'en' ];
		}
		$this->bufferFakeTermsForEntities( $entityIds, $termTypes, $languageCodes );
	}

	private function bufferFakeTermsForEntities( array $entityIds, array $termTypes, array $languageCodes ) {
		foreach ( $entityIds as $id ) {
			foreach ( $termTypes as $type ) {
				foreach ( $languageCodes as $lang ) {
					if ( $type !== TermTypes::TYPE_ALIAS ) {
						$this->bufferNonAliasTerm( $id, $type, $lang );
					} else {
						$this->bufferAliasTerms( $id, $type, $lang );
					}
				}
			}
		}
	}

	private function bufferNonAliasTerm( EntityId $id, $type, $lang ) {
		$this->buffer[$id->getSerialization()][$type][$lang] = $this->generateFakeTerm( $id, $type, $lang );
	}

	private function bufferAliasTerms( EntityId $id, $type, $lang ) {
		$this->buffer[$id->getSerialization()][$type][$lang] = [];
		$this->buffer[$id->getSerialization()][$type][$lang][] = $this->generateFakeTerm( $id, $type, $lang, 1 );
		$this->buffer[$id->getSerialization()][$type][$lang][] = $this->generateFakeTerm( $id, $type, $lang, 2 );
	}

	/**
	 * @param EntityId $id
	 * @param string $type
	 * @param string $lang
	 * @param int $count Used for aliases
	 * @return string
	 */
	private function generateFakeTerm( EntityId $id, $type, $lang, $count = 0 ) {
		$suffix = $count ? ' ' . $count : '';

		return $id->getSerialization() . ' ' . $lang . ' ' . $type . $suffix;
	}

	public function getPrefetchedTerms() {
		$terms = [];

		foreach ( $this->buffer as $entityTerms ) {
			foreach ( $entityTerms as $termsByLang ) {
				foreach ( $termsByLang as $term ) {
					$terms[] = $term;
				}
			}
		}

		return $terms;
	}

	public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
		$id = $entityId->getSerialization();
		return $this->buffer[$id][$termType][$languageCode] ?? null;
	}

	public function getLabel( EntityId $entityId, $languageCode ) {
		return $this->generateFakeTerm( $entityId, TermTypes::TYPE_LABEL, $languageCode );
	}

	public function getLabels( EntityId $entityId, array $languageCodes ) {
		$labels = [];

		foreach ( $languageCodes as $lang ) {
			$labels[$lang] = $this->generateFakeTerm( $entityId, TermTypes::TYPE_LABEL, $lang );
		}
		return $labels;
	}

	public function getDescription( EntityId $entityId, $languageCode ) {
		return $this->generateFakeTerm( $entityId, TermTypes::TYPE_DESCRIPTION, $languageCode );
	}

	public function getDescriptions( EntityId $entityId, array $languageCodes ) {
		$descriptions = [];

		foreach ( $languageCodes as $lang ) {
			$descriptions[$lang] = $this->generateFakeTerm( $entityId, TermTypes::TYPE_DESCRIPTION, $lang );
		}
		return $descriptions;
	}

	public function getPrefetchedAliases( EntityId $entityId, $languageCode ) {
		$id = $entityId->getSerialization();
		if ( array_key_exists( $id, $this->buffer ) ) {
			if ( array_key_exists( TermTypes::TYPE_ALIAS, $this->buffer[$id] ) ) {
				if ( array_key_exists( $languageCode, $this->buffer[$id][TermTypes::TYPE_ALIAS] ) ) {
					return $this->buffer[$id][TermTypes::TYPE_ALIAS][$languageCode];
				}
			}
		}

		return [];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

}


1			<?php
2
3			namespace Wikibase\DataAccess\Tests;
4
5			use Wikibase\DataAccess\PrefetchingTermLookup;
6			use Wikibase\DataModel\Entity\EntityId;
7			use Wikibase\DataModel\Term\TermTypes;
8
9			/**
10			* A PrefetchingTermLookup providing dummy TermLookup functionality, i.e. always returning a fake label/description,
11			* and optional aliases, and also a Spy on TermBuffer
12			* i.e. provides access to "prefetched" terms stored in the buffer after prefetchTerms method is called.
13			*
14			* @license GPL-2.0-or-later
15			*/
16			class FakePrefetchingTermLookup implements PrefetchingTermLookup {
17
18			private $buffer;
19
20			/**
21			* @param array $entityIds
22			* @param array\|null $termTypes if null, defaults to labels and descriptions only
23			* @param array\|null $languageCodes if null, defaults to de and en
24			*/
25			public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
26			if ( $termTypes === null ) {
27			$termTypes = [ TermTypes::TYPE_LABEL, TermTypes::TYPE_DESCRIPTION ];
28			}
29			if ( $languageCodes === null ) {
30			$languageCodes = [ 'de', 'en' ];
31			}
32			$this->bufferFakeTermsForEntities( $entityIds, $termTypes, $languageCodes );
33			}
34
35			private function bufferFakeTermsForEntities( array $entityIds, array $termTypes, array $languageCodes ) {
36			foreach ( $entityIds as $id ) {
37			foreach ( $termTypes as $type ) {
38			foreach ( $languageCodes as $lang ) {
39			if ( $type !== TermTypes::TYPE_ALIAS ) {
40			$this->bufferNonAliasTerm( $id, $type, $lang );
41			} else {
42			$this->bufferAliasTerms( $id, $type, $lang );
43			}
44			}
45			}
46			}
47			}
48
49			private function bufferNonAliasTerm( EntityId $id, $type, $lang ) {
50			$this->buffer[$id->getSerialization()][$type][$lang] = $this->generateFakeTerm( $id, $type, $lang );
51			}
52
53			private function bufferAliasTerms( EntityId $id, $type, $lang ) {
54			$this->buffer[$id->getSerialization()][$type][$lang] = [];
55			$this->buffer[$id->getSerialization()][$type][$lang][] = $this->generateFakeTerm( $id, $type, $lang, 1 );
56			$this->buffer[$id->getSerialization()][$type][$lang][] = $this->generateFakeTerm( $id, $type, $lang, 2 );
57			}
58
59			/**
60			* @param EntityId $id
61			* @param string $type
62			* @param string $lang
63			* @param int $count Used for aliases
64			* @return string
65			*/
66			private function generateFakeTerm( EntityId $id, $type, $lang, $count = 0 ) {
67			$suffix = $count ? ' ' . $count : '';
68
69			return $id->getSerialization() . ' ' . $lang . ' ' . $type . $suffix;
70			}
71
72			public function getPrefetchedTerms() {
73			$terms = [];
74
75			foreach ( $this->buffer as $entityTerms ) {
76			foreach ( $entityTerms as $termsByLang ) {
77			foreach ( $termsByLang as $term ) {
78			$terms[] = $term;
79			}
80			}
81			}
82
83			return $terms;
84			}
85
86			public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
87			$id = $entityId->getSerialization();
88			return $this->buffer[$id][$termType][$languageCode] ?? null;
89			}
90
91			public function getLabel( EntityId $entityId, $languageCode ) {
92			return $this->generateFakeTerm( $entityId, TermTypes::TYPE_LABEL, $languageCode );
93			}
94
95			public function getLabels( EntityId $entityId, array $languageCodes ) {
96			$labels = [];
97
98			foreach ( $languageCodes as $lang ) {
99			$labels[$lang] = $this->generateFakeTerm( $entityId, TermTypes::TYPE_LABEL, $lang );
100			}
101			return $labels;
102			}
103
104			public function getDescription( EntityId $entityId, $languageCode ) {
105			return $this->generateFakeTerm( $entityId, TermTypes::TYPE_DESCRIPTION, $languageCode );
106			}
107
108			public function getDescriptions( EntityId $entityId, array $languageCodes ) {
109			$descriptions = [];
110
111			foreach ( $languageCodes as $lang ) {
112			$descriptions[$lang] = $this->generateFakeTerm( $entityId, TermTypes::TYPE_DESCRIPTION, $lang );
113			}
114			return $descriptions;
115			}
116
117			public function getPrefetchedAliases( EntityId $entityId, $languageCode ) {
118			$id = $entityId->getSerialization();
119			if ( array_key_exists( $id, $this->buffer ) ) {
120			if ( array_key_exists( TermTypes::TYPE_ALIAS, $this->buffer[$id] ) ) {
121			if ( array_key_exists( $languageCode, $this->buffer[$id][TermTypes::TYPE_ALIAS] ) ) {
122			return $this->buffer[$id][TermTypes::TYPE_ALIAS][$languageCode];
123			}
124			}
125			}
126
127			return [];
			0 ignored issues – show Bug Best Practice introduced 2020-01-13 11:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return array();` (`array`) is incompatible with the return type declared by the interface `Wikibase\DataAccess\Alia...r::getPrefetchedAliases` of type `string[]\|false\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
128			}
129
130			}
131

wikimedia / mediawiki-extensions-Wikibase

Issues (1401)

Security Analysis no request data

tests/phpunit/FakePrefetchingTermLookup.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like