Completed
Pull Request — master (#4)
by
unknown
08:24
created
repo/tests/phpunit/includes/Api/RemoveQualifiersTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -110,6 +110,9 @@  discard block
 block discarded – undo
110 110
 		}
111 111
 	}
112 112
 
113
+	/**
114
+	 * @param string|null $statementGuid
115
+	 */
113 116
 	protected function makeValidRequest( $statementGuid, array $hashes ) {
114 117
 		$params = array(
115 118
 			'action' => 'wbremovequalifiers',
@@ -125,6 +128,9 @@  discard block
 block discarded – undo
125 128
 		$this->makeInvalidRequest( $statementGuid, $hashes, 'no-such-qualifier' );
126 129
 	}
127 130
 
131
+	/**
132
+	 * @param string $expectedError
133
+	 */
128 134
 	protected function makeInvalidRequest( $statementGuid, array $hashes, $expectedError = null ) {
129 135
 		$params = array(
130 136
 			'action' => 'wbremovequalifiers',
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Specials/HtmlAssertionHelpers.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -122,6 +122,9 @@
 block discarded – undo
122 122
 		$this->fail( "Failed to find submit element" );
123 123
 	}
124 124
 
125
+	/**
126
+	 * @param string $messageText
127
+	 */
125 128
 	protected function assertHtmlContainsErrorMessage( $html, $messageText ) {
126 129
 		$assertions = [
127 130
 			[ $this, 'assertHtmlContainsFormErrorMessage' ],
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -101,6 +101,8 @@
 block discarded – undo
101 101
 
102 102
 	/**
103 103
 	 * Gets a "lagged" database connection: We always leave out the first row on select.
104
+	 * @param integer $selectCount
105
+	 * @param integer $selectRowCount
104 106
 	 */
105 107
 	private function getLaggedDatabase( Database $realDB, $selectCount, $selectRowCount ) {
106 108
 		$db = $this->getMockBuilder( Database::class )
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/WikibaseRepoTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use DataValues\UnboundedQuantityValue;
15 15
 use DataValues\UnknownValue;
16 16
 use Deserializers\Deserializer;
17
-use Language;
18 17
 use MediaWikiTestCase;
19 18
 use RequestContext;
20 19
 use Serializers\Serializer;
Please login to merge, or discard this patch.
repo/tests/phpunit/maintenance/dumpRdfTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -166,6 +166,9 @@
 block discarded – undo
166 166
 		return $mockDataTypeLookup;
167 167
 	}
168 168
 
169
+	/**
170
+	 * @param string $string
171
+	 */
169 172
 	private function fixLineEndings( $string ) {
170 173
 		return preg_replace( '~(*BSR_ANYCRLF)\R~', "\n", $string );
171 174
 	}
Please login to merge, or discard this patch.
repo/Wikibase.hooks.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
 	 * @param SkinTemplate $skinTemplate
414 414
 	 * @param array $links
415 415
 	 *
416
-	 * @return bool
416
+	 * @return null|boolean
417 417
 	 */
418 418
 	public static function onPageTabs( SkinTemplate &$skinTemplate, array &$links ) {
419 419
 		$entityContentFactory = WikibaseRepo::getDefaultInstance()->getEntityContentFactory();
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
 	 * @param Title|null $title use for further information
742 742
 	 * @param bool $local shall links be generated locally or globally
743 743
 	 *
744
-	 * @return bool
744
+	 * @return boolean|null
745 745
 	 */
746 746
 	public static function onFormat( &$comment, $pre, $auto, $post, $title, $local ) {
747 747
 		global $wgLang, $wgTitle;
@@ -859,7 +859,7 @@  discard block
 block discarded – undo
859 859
 	 * @param string $modelId
860 860
 	 * @param ContentHandler|null $handler
861 861
 	 *
862
-	 * @return bool|null False on success to stop other ContentHandlerForModelID hooks from running,
862
+	 * @return false|null False on success to stop other ContentHandlerForModelID hooks from running,
863 863
 	 *  null on error.
864 864
 	 */
865 865
 	public static function onContentHandlerForModelID( $modelId, &$handler ) {
Please login to merge, or discard this patch.
view/src/SimpleEntityTermsView.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -112,6 +112,9 @@
 block discarded – undo
112 112
 		);
113 113
 	}
114 114
 
115
+	/**
116
+	 * @param string $languageCode
117
+	 */
115 118
 	protected function getHeadingHtml(
116 119
 		$languageCode,
117 120
 		EntityId $entityId = null,
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/EntitySearchHelperTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	 * @param string $type
62 62
 	 * @param TermSearchResult[] $returnResults
63 63
 	 *
64
-	 * @return ConfigurableTermSearchInteractor|\PHPUnit_Framework_MockObject_MockObject
64
+	 * @return ConfigurableTermSearchInteractor
65 65
 	 */
66 66
 	private function getMockSearchInteractor( $search, $language, $type, array $returnResults = array() ) {
67 67
 		$mock = $this->getMock( ConfigurableTermSearchInteractor::class );
Please login to merge, or discard this patch.
repo/includes/Api/SetQualifier.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Wikibase\DataModel\Entity\PropertyId;
10 10
 use Wikibase\DataModel\Services\Statement\StatementGuidParser;
11 11
 use Wikibase\DataModel\Statement\Statement;
12
-use Wikibase\Repo\WikibaseRepo;
13 12
 
14 13
 /**
15 14
  * API module for creating a qualifier or setting the value of an existing one.
Please login to merge, or discard this patch.