wikimedia / mediawiki-extensions-Wikibase

repo/includes/Api/EntityLoadingHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -234,7 +234,7 @@
 	 * @param string $title
 	 *
 	 * @throws ApiUsageException If no such entity is found.
-	 * @return EntityId The ID of the entity connected to $title on $site.
+	 * @return null|\Wikibase\DataModel\Entity\ItemId The ID of the entity connected to $title on $site.
 	 */
 	private function getEntityIdFromSiteTitleCombination( $site, $title ) {
 		if ( $this->siteLinkLookup ) {

repo/includes/Api/MergeItems.php

Doc Comments +3 added lines

@@ -173,6 +173,9 @@
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function addEntityToOutput( EntityRevision $entityRevision, $name ) {
 		$entityId = $entityRevision->getEntity()->getId();
 		$revisionId = $entityRevision->getRevisionId();

repo/includes/Api/ParseValue.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use Wikibase\Repo\Validators\CompositeValidator;
 use Wikibase\Repo\Validators\ValidatorErrorLocalizer;
 use Wikibase\Repo\ValueParserFactory;
-use Wikibase\Repo\WikibaseRepo;
 
 /**
  * API module for using value parsers.

repo/includes/Api/ResultBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -1058,7 +1058,7 @@
 	 * @see ApiResult::addValue()
 	 *
 	 * @param Status $status The status to get the revision ID from.
-	 * @param string|null|array $path Where in the result to put the revision id
+	 * @param string $path Where in the result to put the revision id
 	 * @param int|null $oldRevId The id of the latest revision of the entity before
 	 *        the last (possibly null) edit
 	 */

repo/includes/Content/EntityHandler.php

Doc Comments +4 added lines, -4 removed lines

@@ -301,7 +301,7 @@ 
 	/**
 	 * @see ContentHandler::makeParserOptions
 	 *
-	 * @param IContextSource|User|string $context
+	 * @param string $context
 	 *
 	 * @return ParserOptions
 	 */
@@ -575,7 +575,7 @@ 
 	 * @param Revision $newerRevision The revision to undo
 	 * @param Revision $olderRevision Must be an earlier revision than $undo
 	 *
-	 * @return Content|bool Content on success, false on failure
+	 * @return null|Content Content on success, false on failure
 	 */
 	public function getUndoContent(
 		Revision $latestRevision,
@@ -632,7 +632,7 @@ 
 	 * @param EntityContent $content
 	 * @param Title $title
 	 *
-	 * @return DataUpdate[]
+	 * @return DataUpdateAdapter[]
 	 */
 	public function getEntityDeletionUpdates( EntityContent $content, Title $title ) {
 		$updates = array();
@@ -671,7 +671,7 @@ 
 	 * @param EntityContent $content
 	 * @param Title $title
 	 *
-	 * @return DataUpdate[]
+	 * @return DataUpdateAdapter[]
 	 */
 	public function getEntityModificationUpdates( EntityContent $content, Title $title ) {
 		$updates = array();

repo/includes/Dumpers/RdfDumpGenerator.php

Doc Comments +3 added lines

@@ -174,6 +174,9 @@
 		$this->timestamp = (int)$timestamp;
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private static function getRdfWriter( $name ) {
 		$factory = new RdfWriterFactory();
 		$format = $factory->getFormatName( $name );

repo/includes/Interactors/ItemMergeInteractor.php

Doc Comments +4 added lines, -1 removed lines

@@ -279,7 +279,7 @@ 
 	 * @param string|null $summary
 	 * @param bool $bot
 	 *
-	 * @return array A list of exactly two EntityRevision objects. The first one represents the
+	 * @return \Wikibase\EntityRevision[] A list of exactly two EntityRevision objects. The first one represents the
 	 *  modified source item, the second one represents the modified target item.
 	 */
 	private function attemptSaveMerge( Item $fromItem, Item $toItem, $summary, $bot ) {
@@ -292,6 +292,9 @@ 
 		return array( $fromRev, $toRev );
 	}
 
+	/**
+	 * @param boolean $bot
+	 */
 	private function saveItem( Item $item, Summary $summary, $bot ) {
 		// Given we already check all constraints in ChangeOpsMerge, it's
 		// fine to ignore them here. This is also needed to not run into

repo/includes/WikibaseRepo.php

Doc Comments +6 added lines, -3 removed lines

@@ -1213,7 +1213,7 @@ 
 	/**
 	 * Get the mapping of entity types => content models
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public function getContentModelMappings() {
 		$map = $this->entityTypeDefinitions->getContentModelIds();
@@ -1233,7 +1233,7 @@ 
 	}
 
 	/**
-	 * @return string[] List of entity type identifiers (typically "item" and "property")
+	 * @return integer[] List of entity type identifiers (typically "item" and "property")
 	 *  that are configured in WikibaseRepo.entitytypes.php and enabled via the
 	 *  $wgWBRepoSettings['entityNamespaces'] setting. Optionally the list also contains
 	 *  entity types from the configured foreign repositories.
@@ -1261,7 +1261,7 @@ 
 	}
 
 	/**
-	 * @return string[] List of entity type identifiers (typically "item" and "property")
+	 * @return integer[] List of entity type identifiers (typically "item" and "property")
 	 *  that are configured in WikibaseRepo.entitytypes.php and enabled via the
 	 *  $wgWBRepoSettings['entityNamespaces'] setting.
 	 */
@@ -1792,6 +1792,9 @@ 
 		return new EntityTypesConfigValueProvider( $this->entityTypeDefinitions );
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function fixLegacyContentModelSetting( array $setting, $name ) {
 		if ( isset( $setting[ 'wikibase-item' ] ) || isset( $setting[ 'wikibase-property' ] ) ) {
 			wfWarn( "The specified value for the Wikibase setting '$name' uses content model ids as keys. This is deprecated. " .

repo/tests/phpunit/includes/Actions/EditEntityActionTest.php

Doc Comments +3 added lines

@@ -52,6 +52,9 @@
 		$this->assertInstanceOf( SubmitEntityAction::class, $action );
 	}
 
+	/**
+	 * @param string $key
+	 */
 	protected function adjustRevisionParam( $key, array &$params, WikiPage $page ) {
 		if ( !isset( $params[$key] ) || ( is_int( $params[$key] ) && $params[$key] > 0 ) ) {
 			return;