Completed
Pull Request — master (#4)
by
unknown
08:24
created
lib/includes/Store/BufferingTermLookup.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -106,8 +106,8 @@
 block discarded – undo
106 106
 	 * The source from which to fetch would typically be supplied to the buffer's constructor.
107 107
 	 *
108 108
 	 * @param EntityId[] $entityIds
109
-	 * @param string[]|null $termTypes
110
-	 * @param string[]|null $languageCodes
109
+	 * @param string[] $termTypes
110
+	 * @param string[] $languageCodes
111 111
 	 *
112 112
 	 * @throws StorageException
113 113
 	 */
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/Sql/SqlEntitiesWithoutTermFinderTest.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -212,6 +212,12 @@  discard block
 block discarded – undo
212 212
 		];
213 213
 	}
214 214
 
215
+	/**
216
+	 * @param integer $numericEntityId
217
+	 * @param string $entityType
218
+	 * @param string $languageCode
219
+	 * @param string $termType
220
+	 */
215 221
 	private function getTermRow( $numericEntityId, $entityType, $languageCode, $termType ) {
216 222
 		return [
217 223
 			'term_entity_id' => $numericEntityId,
@@ -223,6 +229,11 @@  discard block
 block discarded – undo
223 229
 		];
224 230
 	}
225 231
 
232
+	/**
233
+	 * @param integer $entityNamespace
234
+	 * @param integer $numericEntityId
235
+	 * @param string $entityIdPrefix
236
+	 */
226 237
 	private function getPageRow( $entityNamespace, $numericEntityId, $entityIdPrefix, $isRedirect ) {
227 238
 		return [
228 239
 			'page_namespace' => $entityNamespace,
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Specials/SpecialMergeItemsTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
 	/**
122 122
 	 * @param SpecialMergeItems $page
123
-	 * @param User $user
123
+	 * @param User|null $user
124 124
 	 */
125 125
 	private function overrideServices( SpecialMergeItems $page, User $user ) {
126 126
 		$wikibaseRepo = WikibaseRepo::getDefaultInstance();
@@ -200,6 +200,9 @@  discard block
 block discarded – undo
200 200
 		return $titleLookup;
201 201
 	}
202 202
 
203
+	/**
204
+	 * @return string
205
+	 */
203 206
 	private function executeSpecialMergeItems( $params, User $user = null ) {
204 207
 		if ( !$user ) {
205 208
 			$user = $GLOBALS['wgUser'];
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Specials/SpecialRedirectEntityTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
 	/**
114 114
 	 * @param SpecialRedirectEntity $page
115
-	 * @param User $user
115
+	 * @param User|null $user
116 116
 	 */
117 117
 	private function overrideServices( SpecialRedirectEntity $page, User $user ) {
118 118
 		$wikibaseRepo = WikibaseRepo::getDefaultInstance();
@@ -157,6 +157,9 @@  discard block
 block discarded – undo
157 157
 		);
158 158
 	}
159 159
 
160
+	/**
161
+	 * @return string
162
+	 */
160 163
 	private function executeSpecialEntityRedirect( array $params, User $user = null ) {
161 164
 		if ( !$user ) {
162 165
 			$user = $GLOBALS['wgUser'];
Please login to merge, or discard this patch.
client/includes/Specials/SpecialPagesWithBadges.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,6 @@  discard block
 block discarded – undo
45 45
 	/**
46 46
 	 * @see SpecialPage::__construct
47 47
 	 *
48
-	 * @param string $name
49 48
 	 * @param LanguageFallbackLabelDescriptionLookupFactory $labelDescriptionLookupFactory
50 49
 	 * @param string[] $badgeIds
51 50
 	 * @param string $siteId
@@ -80,6 +79,9 @@  discard block
 block discarded – undo
80 79
 		}
81 80
 	}
82 81
 
82
+	/**
83
+	 * @param string $subPage
84
+	 */
83 85
 	private function prepareParams( $subPage ) {
84 86
 		$badge = $this->getRequest()->getText( 'badge', $subPage );
85 87
 
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Content/ItemContentTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 	}
48 48
 
49 49
 	/**
50
-	 * @param ItemId|null $itemId
50
+	 * @param null|EntityId $itemId
51 51
 	 *
52 52
 	 * @throws InvalidArgumentException
53 53
 	 * @return ItemContent
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Content/PropertyContentTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	}
32 32
 
33 33
 	/**
34
-	 * @param PropertyId|null $propertyId
34
+	 * @param null|EntityId $propertyId
35 35
 	 *
36 36
 	 * @throws InvalidArgumentException
37 37
 	 * @return PropertyContent
Please login to merge, or discard this patch.
repo/maintenance/dumpEntities.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	 * @param null|string $entityType
190 190
 	 * @param ExceptionHandler|null $exceptionReporter
191 191
 	 *
192
-	 * @return EntityIdReader|SqlEntityIdPager a stream of EntityId objects
192
+	 * @return EntityIdPager a stream of EntityId objects
193 193
 	 */
194 194
 	private function makeIdStream( $entityType = null, ExceptionHandler $exceptionReporter = null ) {
195 195
 		$listFile = $this->getOption( 'list-file' );
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	/**
207 207
 	 * Returns EntityIdPager::NO_REDIRECTS.
208 208
 	 *
209
-	 * @return mixed a EntityIdPager::XXX_REDIRECTS constant
209
+	 * @return string a EntityIdPager::XXX_REDIRECTS constant
210 210
 	 */
211 211
 	protected function getRedirectMode() {
212 212
 		return EntityIdPager::NO_REDIRECTS;
Please login to merge, or discard this patch.
repo/includes/Api/EditEntity.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 
668 668
 	/**
669 669
 	 * @param mixed $data
670
-	 * @param array $allowedProps
670
+	 * @param string[] $allowedProps
671 671
 	 */
672 672
 	private function checkValidJson( $data, array $allowedProps ) {
673 673
 		if ( is_null( $data ) ) {
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
 	 * Check some of the supplied data for multilang arg
865 865
 	 *
866 866
 	 * @param string[] $arg The argument array to verify
867
-	 * @param int|string $langCode The language code used in the value part
867
+	 * @param integer $langCode The language code used in the value part
868 868
 	 */
869 869
 	private function validateMultilangArgs( $arg, $langCode ) {
870 870
 		$this->assertArray( $arg, 'An array was expected, but not found in the json for the '
Please login to merge, or discard this patch.