Completed
Pull Request — master (#4)
by
unknown
08:24
created
repo/includes/Api/EntitySavingHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -353,7 +353,7 @@
 block discarded – undo
353 353
 	/**
354 354
 	 * @param array $params
355 355
 	 *
356
-	 * @return string|bool|null Token string, or false if not needed, or null if not set.
356
+	 * @return string|boolean Token string, or false if not needed, or null if not set.
357 357
 	 */
358 358
 	private function evaluateTokenParam( array $params ) {
359 359
 		if ( !$this->apiModule->needsToken() ) {
Please login to merge, or discard this patch.
repo/includes/Api/ModifyEntity.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -336,6 +336,9 @@
 block discarded – undo
336 336
 		return $this->isWriteMode() ? array( 'read', 'edit' ) : array( 'read' );
337 337
 	}
338 338
 
339
+	/**
340
+	 * @param integer $oldRevId
341
+	 */
339 342
 	private function addToOutput( EntityDocument $entity, Status $status, $oldRevId = null ) {
340 343
 		$this->getResultBuilder()->addBasicEntityInformation( $entity->getId(), 'entity' );
341 344
 		$this->getResultBuilder()->addRevisionIdFromStatusToResult( $status, 'entity', $oldRevId );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/EntityLoadingHelperTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 	 * @param EntityRevision|null $entityRevision The EntityRevision getEntityRevision() should return.
55 55
 	 * @param Exception|null $exception The Exception getEntityRevision() should throw.
56 56
 	 *
57
-	 * @return EntityRevisionLookup|PHPUnit_Framework_MockObject_MockObject
57
+	 * @return EntityRevisionLookup
58 58
 	 */
59 59
 	protected function getMockEntityRevisionLookup(
60 60
 		EntityId $entityId = null,
Please login to merge, or discard this patch.
client/includes/Hooks/InfoActionHookHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
 
148 148
 	/**
149 149
 	 * @param IContextSource $context
150
-	 * @param array $usage
150
+	 * @param \Wikibase\Client\Usage\EntityUsage[] $usage
151 151
 	 *
152 152
 	 * @return string[]
153 153
 	 */
Please login to merge, or discard this patch.
lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -191,6 +191,9 @@
 block discarded – undo
191 191
 		return $this->lookup->loadRevisionInformationByRevisionId( $entityId, $revisionId, $mode );
192 192
 	}
193 193
 
194
+	/**
195
+	 * @param string $mode
196
+	 */
194 197
 	private function doFetch( $mode ) {
195 198
 		if ( empty( $this->toFetch ) ) {
196 199
 			return;
Please login to merge, or discard this patch.
lib/includes/Interactors/TermIndexSearchInteractor.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
 	/**
342 342
 	 * @param EntityId $entityId
343 343
 	 *
344
-	 * @return null|Term
344
+	 * @return \Wikibase\DataModel\Term\TermFallback|null
345 345
 	 */
346 346
 	private function getLabelDisplayTerm( EntityId $entityId ) {
347 347
 		return $this->labelDescriptionLookup->getLabel( $entityId );
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 	/**
351 351
 	 * @param EntityId $entityId
352 352
 	 *
353
-	 * @return null|Term
353
+	 * @return \Wikibase\DataModel\Term\TermFallback|null
354 354
 	 */
355 355
 	private function getDescriptionDisplayTerm( EntityId $entityId ) {
356 356
 		return $this->labelDescriptionLookup->getDescription( $entityId );
Please login to merge, or discard this patch.
lib/tests/phpunit/Store/DispatchingEntityRevisionLookupTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 class DispatchingEntityRevisionLookupTest extends \PHPUnit_Framework_TestCase {
23 23
 
24 24
 	/**
25
-	 * @return \PHPUnit_Framework_MockObject_MockObject|EntityRevisionLookup
25
+	 * @return \Wikibase\DataModel\Entity\EntityDocument
26 26
 	 */
27 27
 	private function getDummyEntityRevisionLookup() {
28 28
 		return $this->getMock( EntityRevisionLookup::class );
Please login to merge, or discard this patch.
lib/includes/Store/DispatchingTermBuffer.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,8 +66,8 @@  discard block
 block discarded – undo
66 66
 	 * @see TermBuffer::prefetchTerms
67 67
 	 *
68 68
 	 * @param array $entityIds
69
-	 * @param array|null $termTypes
70
-	 * @param array|null $languageCodes
69
+	 * @param string[] $termTypes
70
+	 * @param string[] $languageCodes
71 71
 	 */
72 72
 	public function prefetchTerms( array $entityIds, array $termTypes = null, array $languageCodes = null ) {
73 73
 		$groupedIds = $this->groupEntityIdsByRepo( $entityIds );
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	 * @param string $termType
96 96
 	 * @param string $languageCode
97 97
 	 *
98
-	 * @return string|false|null
98
+	 * @return string|null
99 99
 	 */
100 100
 	public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
101 101
 		$termBuffer = $this->getTermBufferForRepository( $entityId->getRepositoryName() );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/Sql/SqlEntityIdPagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -80,6 +80,9 @@
 block discarded – undo
80 80
 		);
81 81
 	}
82 82
 
83
+	/**
84
+	 * @param boolean $isRedirect
85
+	 */
83 86
 	private function getPageRow( EntityId $entityId, $isRedirect ) {
84 87
 		$entityNamespaceLookup = WikibaseRepo::getDefaultInstance()->getEntityNamespaceLookup();
85 88
 
Please login to merge, or discard this patch.