wikimedia / mediawiki-extensions-Wikibase

repo/includes/Hooks/LinkBeginHookHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -203,7 +203,7 @@ 
 	}
 
 	/**
-	 * @param array $termsByLanguage
+	 * @param string[] $termsByLanguage
 	 *
 	 * @return string[]|null
 	 */
@@ -224,7 +224,7 @@ 
 	 *
 	 * @param Title|null $currentTitle
 	 * @param RequestContext $context
-	 * @return bool
+	 * @return null|boolean
 	 */
 	private function shouldConvert( Title $currentTitle = null, RequestContext $context ) {
 		static $shouldConvert = null;

client/tests/phpunit/includes/DataAccess/PropertyParserFunction/StatementGroupRendererFactoryTest.php

Doc Comments +7 added lines

@@ -302,6 +302,13 @@
 		return $parser;
 	}
 
+	/**
+	 * @param string $languageCode
+	 * @param string $userLanguageCode
+	 * @param boolean $interfaceMessage
+	 * @param boolean $disableContentConversion
+	 * @param boolean $disableTitleConversion
+	 */
 	private function getParserOptions( $languageCode, $userLanguageCode, $interfaceMessage,
 		$disableContentConversion, $disableTitleConversion
 	) {

repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -116,7 +116,7 @@ 
 	 * @param OutputPage $out
 	 * @param string &$html the HTML to mangle
 	 *
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public static function onOutputPageBeforeHTML( OutputPage $out, &$html ) {
 		$self = self::newFromGlobalState();
@@ -128,7 +128,7 @@ 
 	 * @param OutputPage $out
 	 * @param string &$html
 	 *
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function doOutputPageBeforeHTML( OutputPage $out, &$html ) {
 		$placeholders = $out->getProperty( 'wikibase-view-chunks' );

lib/includes/Store/ChunkCache.php

Doc Comments +1 added lines, -1 removed lines

@@ -211,7 +211,7 @@
 	 * @param int $before insert into the internal entry list before this position.
 	 *
 	 * @throws MWException
-	 * @return array|bool the cache entry created by inserting the new chunk, or false if
+	 * @return integer|null the cache entry created by inserting the new chunk, or false if
 	 *         there is no more data to load from the source at the given position.
 	 *         The cache entry is an associative array containing the following keys:
 	 *         - start: the key the chunk starts at

lib/tests/phpunit/Formatters/TimeDetailsFormatterTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 
 	/**
 	 * @param string $timestamp
-	 * @param int|string $timezone
+	 * @param integer $timezone
 	 * @param int|string $before
 	 * @param int|string $after
 	 * @param int|string $precision

lib/tests/phpunit/Store/CachingEntityRevisionLookupTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 	 * @param EntityRevision[] $entityRevisions
 	 * @param EntityRedirect[] $entityRedirects
 	 *
-	 * @return EntityLookup
+	 * @return CachingEntityRevisionLookup
 	 */
 	protected function newEntityRevisionLookup( array $entityRevisions, array $entityRedirects ) {
 		$mock = new MockRepository();

repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
 	/**
 	 * Convenience method for creating Statements.
 	 *
-	 * @param string|PropertyId $propertyId
+	 * @param string $propertyId
 	 *
 	 * @param string|int|float|DataValue|null $value The value of the new
 	 *        claim's main snak. Null will result in a PropertyNoValueSnak.

repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php

Doc Comments +3 added lines

@@ -543,6 +543,9 @@
 		$this->assertEntityPerPage( false, $entityId );
 	}
 
+	/**
+	 * @param boolean $expected
+	 */
 	private function assertEntityPerPage( $expected, EntityId $entityId ) {
 		$pageId = $this->getPageId( $entityId );
 

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Wikibase\Repo\Tests\Store\Sql;
 
 use InvalidArgumentException;
-use MediaWiki\MediaWikiServices;
 use MediaWikiTestCase;
 use RawMessage;
 use Revision;

client/includes/Hooks/EchoNotificationsHandlers.php

Doc Comments +1 added lines, -1 removed lines

@@ -235,7 +235,7 @@
 	 *
 	 * @param DiffOp $siteLinkDiffOp
 	 *
-	 * @return Title|false
+	 * @return \Wikibase\DataModel\Entity\EntityId
 	 */
 	private function getTitleForNotification( DiffOp $siteLinkDiffOp ) {
 		if ( $siteLinkDiffOp instanceof DiffOpAdd ) {