Completed
Push — master ( b5c57e...a9243a )
by
unknown
06:33
created
repo/tests/phpunit/includes/HttpResponseMockerTrait.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -14,6 +14,7 @@
 block discarded – undo
14 14
 
15 15
 	/**
16 16
 	 * Some test appear to want to simulate null status codes, hence the type hint
17
+	 * @param integer $statusCode
17 18
 	 */
18 19
 	private function newMockResponse( $response, ?int $statusCode ): ResponseInterface {
19 20
 		$mockStream = $this->createMock( StreamInterface::class );
Please login to merge, or discard this patch.
lib/tests/phpunit/EntityRevisionLookupTestCase.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -56,6 +56,9 @@
 block discarded – undo
56 56
 		];
57 57
 	}
58 58
 
59
+	/**
60
+	 * @param integer $revision
61
+	 */
59 62
 	protected function resolveLogicalRevision( $revision ) {
60 63
 		return $revision;
61 64
 	}
Please login to merge, or discard this patch.
client/includes/Changes/AffectedPagesFinder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -355,7 +355,7 @@
 block discarded – undo
355 355
 	}
356 356
 
357 357
 	/**
358
-	 * @param iterable<PageEntityUsages> $usages
358
+	 * @param Traversable $usages
359 359
 	 * @param EntityId $entityId
360 360
 	 * @param string[] $changedAspects
361 361
 	 *
Please login to merge, or discard this patch.
client/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@
 block discarded – undo
139 139
 	/**
140 140
 	 * @param EntityId $entityId
141 141
 	 * @param Language $language
142
-	 * @param $termType
142
+	 * @param string $termType
143 143
 	 * @return TermFallback|null
144 144
 	 */
145 145
 	private function lookupWithoutCache( EntityId $entityId, Language $language, $termType ): ?TermFallback {
Please login to merge, or discard this patch.
unit/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookupTest.php 1 patch
Doc Comments   +21 added lines patch added patch discarded remove patch
@@ -97,6 +97,11 @@  discard block
 block discarded – undo
97 97
 		);
98 98
 	}
99 99
 
100
+	/**
101
+	 * @param string $term
102
+	 * @param string $requestLanguageCode
103
+	 * @param string $actualLanguageCode
104
+	 */
100 105
 	private function getTermFallback( $term, $requestLanguageCode, $actualLanguageCode = null ): ?TermFallback {
101 106
 		if ( $term === null ) {
102 107
 			return null;
@@ -280,6 +285,9 @@  discard block
 block discarded – undo
280 285
 		yield [ TermTypes::TYPE_DESCRIPTION ];
281 286
 	}
282 287
 
288
+	/**
289
+	 * @param ItemId $itemId
290
+	 */
283 291
 	private function mockCacheWithContent( string $term, $itemId ): void {
284 292
 		$termFallback = new TermFallback( 'en', $term, 'en', 'en' );
285 293
 		$this->revisionLookup->method( 'lookupLatestRevisionResolvingRedirect' )->willReturn( [ 1, $itemId ] );
@@ -300,6 +308,9 @@  discard block
 block discarded – undo
300 308
 			->willReturn( [ self::ITEM_Q1_REVISION, $itemId ] );
301 309
 	}
302 310
 
311
+	/**
312
+	 * @param ItemId $itemId
313
+	 */
303 314
 	private function mockCacheEmpty( $itemId ): void {
304 315
 		$this->mockRevisionLookup( $itemId );
305 316
 
@@ -309,6 +320,12 @@  discard block
 block discarded – undo
309 320
 			->willReturn( TermFallbackCacheFacade::NO_VALUE );
310 321
 	}
311 322
 
323
+	/**
324
+	 * @param TermFallback|null $termFallback
325
+	 * @param ItemId $targetEntityId
326
+	 * @param integer $revisionId
327
+	 * @param string $termType
328
+	 */
312 329
 	private function mockCacheSetExpectation(
313 330
 		$termFallback,
314 331
 		$targetEntityId,
@@ -323,6 +340,10 @@  discard block
 block discarded – undo
323 340
 			->with( $termFallback, $targetEntityId, $revisionId, $languageCode, $termType );
324 341
 	}
325 342
 
343
+	/**
344
+	 * @param ItemId $itemId
345
+	 * @param TermFallback|null $termFallback
346
+	 */
326 347
 	private function mockInternalLookupWithContent(
327 348
 		$itemId,
328 349
 		?TermFallback $termFallback,
Please login to merge, or discard this patch.